aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bacapp.c
AgeCommit message (Collapse)AuthorFilesLines
2011-11-09Fix some [-Wunused-but-set-variable] warnings;wmeier1-23/+23
Trailing whitespace cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39771 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-30Fixed some coding errors:stig1-2/+2
packet-bacapp.c:6154: error: stray '\250' in program packet-bacapp.c:7137: warning: cast to pointer from integer of different size git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39680 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-30Fix unused variable warnings.etxrab1-13/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39679 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-30From Lori Tribble:etxrab1-63/+652
I found many new properties in BACnet that were not decoded correctly in Wireshark. I have attached a patch that adds decoding to the following properties: Fixed the following properties to decode: In the Accumulator Object: scale (187) prescale (185) logging-record (184) In Access Door Object: door-members (228) masked-alarm-values (234) In the Pulse Converter Object: input-reference (181) In the Group Object: list-of-group-members (53) In the Event Enrollment Object: object-property-reference (78) In the Command Object: action (2) In the Trend Log Multiple object: log-buffer (131) In the Event Log Object: log-buffer (131) In the Structured View object: subordinate-list (211) Added decoding for the following enumeration type properties: Logging-type (197) event-state (36) reliability (103) notify-type (208) door-status (231) lock-status (233) secured-status (235) maintenance-required (158) program-state (92) program-change (90) reason-for-halt (100) mode (160) silenced (163) operation-expected (161) tracking-value (164) file-access-method (41) The above fixes also fixed the log-buffer decoding of the old trend log recorded as Wireshark bug: #6458 I believe this patch also fixes bug: #6235. But the original bug did not contain a capture file so I am not positive my capture represents the originators issue. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6475 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39676 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.wmeier1-3/+3
Also: remove trailing whitespace for a number of files. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39503 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵wmeier1-1/+1
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39328 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵wmeier1-11/+11
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39288 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-12From Danny Breton: Property name time-synchronization-interval(204) is ↵wmeier1-1/+1
incorrectly shown as time-synchronization-recipents. See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6336 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38977 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-07From Lori Tribble:etxrab1-0/+7
Fix problem with the decoding of the exception schedule. It was eating one too many closing tags before exiting and causing the rest of the information to fail to decode correctly. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6178 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38919 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-07From Lori Tribble:etxrab1-64/+204
Fixes log-status and status-flags plus other BACnet decoding bugs This patch fixes the log-status and status-flag decoding issues described in this bug report. This patch also fixes the following items: 1) date-list decoding 2) time-synchronization-recipients decoding 3) decoding of UTF-8 character strings (when using character set 0) 4) event-parameter decoding https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5120 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38914 f5534014-38df-0310-8fa8-9805f1628bb7
2011-08-23"fix":etxrab1-3/+3
Error: Found non-ASCII characters on line 4135 of packet-bacapp.c Error: Found non-ASCII characters on line 4163 of packet-bacapp.c Error: Found non-ASCII characters on line 4198 of packet-bacapp.c git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38681 f5534014-38df-0310-8fa8-9805f1628bb7
2011-08-23From Steve Karg:etxrab1-3/+352
BACnet Dissector latest enumerations for properties, states, error codes, and vendor ids. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6249 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38678 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-19Based on the information provided by Steve Karg via -dev, change all ↵cmaynard1-33/+33
occurrences of ENC_LITTLE_ENDIAN to ENC_BIG_ENDIAN. Ref: http://www.wireshark.org/lists/wireshark-dev/201107/msg00305.html git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38110 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-19Use ENC_LITTLE_ENDIAN rather than TRUE in proto_tree_add_item() calls. guy1-34/+33
(Yes, that means that all but one call uses ENC_LITTLE_ENDIAN, and one uses ENC_BIG_ENDIAN. I guess that's how the protocol works....) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38106 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-19From Michael Mann via bug 5769: In fDevice_Instance(), add field in propercmaynard1-1/+1
big-endian byte order. Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5769 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38105 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-22From Yaniv Kaul: Some 'set but not used' compilation fixes;wmeier1-24/+27
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5858 From me: 2 corrections to the patch and sevral other minor changes. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37350 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-14Make the tree items for strings look a little less ugly.guy1-1/+2
Note that the string value should be put into the protocol tree. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37137 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-06 VALS(& -> VALS(etxrab1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37009 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-05Remove some unused hf_ variables.morriss1-38/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36469 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-05From Felix Kraemer: fix ↵morriss1-122/+371
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5694 : This patch adds the capability to create BACnet statistics trees. Find the respective menu items under 'Statistics->BACnet'. Packets can be sorted by different criteria: - Src/Dst IP adresses - Instance ID - Object Type - Service From me: - Don't use C++/C99-style comments. - Name variables for tick_stat_node() don't need to be static. - Change updateBacnetInfoValue() to require 'data' to be ep_ allocated. Change the couple of calls that did not send in ep_ allocated data to do so. - Change one or two functions to be static. - Do not use (memory-unsafe) g_sprintf(). - Use ep_strconcat() instead of leaking memory with g_strconcat(). - Put back one if(tree) that doesn't appear to do any harm. - Remove variable declarations and #includes from the header file. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36468 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-04 Don't assign to a proto_item * if the value won't be used: Coverity 846 & 848;wmeier1-11/+6
Also: remove some unneeded #includes git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36464 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-30Introduce "Fragment count" filter element for all protocols doing reassembly.stig1-0/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35705 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-20Fix the dead initialization warnings found by clang's static analysissfisher1-1/+1
("Value stored to 'xxx' during its initialization is never read") git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35598 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-12From Steve Karg:jake1-8/+38
Added a display filter on BACnet WhoIs Low Limit and High Limit. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35503 f5534014-38df-0310-8fa8-9805f1628bb7
2010-12-20Rename the routines that handle dissector tables with unsigned integerguy1-1/+1
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35224 f5534014-38df-0310-8fa8-9805f1628bb7
2010-12-10From Lori Tribble:etxrab1-8/+97
Enhancements to BACnet's bacapp dissector Details: 1) Added the low and high instance parameters of the who-is command to the summary view, if present. 2) Added dissecting of the property active-cov-subscriptions. 3) Added tag details to the decoded view of ProcessId. 4) Fixed the indent levels of the recipientProcess decoding. 5) Fixed the indent tree levels for ReadPropertyMultiple-ACK when decoding error response. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5473 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35170 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-05Initialize a variable to remove a warning from clang.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34786 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-22From Lori Tribble: Add vendor identifier dissector access to BACnet Private ↵wmeier1-10/+49
Transfer Msgs BACnet has a private transfer service which is vendor specific. The start of each request and response contains the vendor identifier. I've added a way for vendors to provide their own dissectors by registering their vendor identifier. The packet-bacapp.c method fConfirmedPrivateTransfer has been modified to look for a vendor specified dissector. If found it will be run. If not found we default to running the standard dissection included in packet-bacapp.c. I modified the summary column display for private transfer messages so that the summary now displays the Vendor Identifier (V=xx) and the Service Number (SN=xx). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5250 From me: Rename sub-dissector tablle to "bacapp.vendor_identifier" Change subdissector ui_name to "BACapp Vendor Identifier" git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34625 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.morriss1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34227 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-11Remove non-ASCII characters.morriss1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33771 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-11From Herbert Lischka:etxrab1-47/+147
Resolves problems reported in bug #5090 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5090 I have 3 potentially risks of endless loop eliminated the rest is cosmetic git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33765 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-09Future-proof a for loop.gerald1-1/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33752 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-09Fix another compile error. wmeier1-1/+0
(Note to self: take the time to read *all* the compiler error output before committing). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33750 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-09Fix another compile error :(wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33749 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-09Fix a compile error.wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33748 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-09From Herbert Lischka: "corrected the dissection of reassembled UDP packets".wmeier1-190/+260
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5051 From me: - Move proto_register... and proto_reg_handoff.. to the end of the file; - Define a function as static; - Minor reformatting and whitespace cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33747 f5534014-38df-0310-8fa8-9805f1628bb7
2010-06-01From Herbert Lischka:jake1-5/+16
Lori made a simple change to the bacapp.c file for segmentation parsing. Basically all fragments have some common data in the APDU which is useful to see parsed in the tree. I added support for vendor numbers bigger than 255. Corrected Info column for "message fragment" and "message reassembled" git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33033 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-10Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)wmeier1-107/+107
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32735 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-07Squelch a compiler warning.guy1-1/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32415 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-03Remove unneeded #include <stdio.h>wmeier1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32367 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-06Renamed some reassembled data texts.stig1-57/+47
Removed some check_col(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31809 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-02Introduce "Reassembled length" filter element for all protocols doingstig1-1/+7
reassembly. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31767 f5534014-38df-0310-8fa8-9805f1628bb7
2010-01-18Fix a number of gcc _Wshadow warningswmeier1-4/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31557 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-29From Herbert Lischka:etxrab1-0/+10
Patch to resolve Error in decoding BACnet NotificationParameters, https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4250 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31111 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-17Added format argument.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30986 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-17Herbert Lischka:etxrab1-2/+65
Recipients as IPv4 and IPv6. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30985 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-13From Herbert Lischka:jake1-27/+2128
- packet-bacapp.h eliminated and included in packet-bacapp.c - dissection of recipient-list and client-cov-increment added git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30955 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-09Avoid a warning about signed/unsigned comparison.martinm1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30875 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-08Fixed printing of BACnetTypeName in the Packet Details tree.stig1-10/+10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30870 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-08From Steve Karg and Herbert Lischka via bug 4190:stig1-308/+340
Modified the open/close context tagging to include context tag number. Modified the info column to show more specific information about certain packets. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30869 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-18 16:59:58 +0000