aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-asterix.c
AgeCommit message (Collapse)AuthorFilesLines
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-18asterix: special processing for field item I021/150Marko Hrastovec1-18/+40
There is a problem where one field decodes differently depending on another fields content. A code has been added to save information for 021_150_IM field. When the next field 021_150_ASPD is decoded, the stored information determines how it shall be scaled. This is a special case for I021/150 only. The same way as this change, other changes shall be done for fields that are dependent on other fields. Bug: 14076 Change-Id: I51f2c8f79bc6bde9efc0429e54fbea36818e9b36 Reviewed-on: https://code.wireshark.org/review/24734 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-10asterix: wrong presentation of fields I009/080 in CAT009.Marko Hrastovec1-3/+3
Fields I009/080 were wrongly represented for CAT009. 8 and 16 bit long fields were represented as 24 bit. Change-Id: I5bd1c1f006292f58d0290ced80dde22324cb4002 Reviewed-on: https://code.wireshark.org/review/24746 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-08Typing error correction for CAT002 settings selection.Marko Hrastovec1-1/+1
Two settings had the same string "Select the CAT001 version". One should be CAT002. Change-Id: Iee6204a1064af786338d1b53c7b983763b985a0c Reviewed-on: https://code.wireshark.org/review/24745 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-05Fix unit of measurement in category 048 of ASTERIX protocol.Dmitry Bravikov1-1/+1
Change-Id: Icdd39166059c080e7844968219f2a8f387c587a6 Reviewed-on: https://code.wireshark.org/review/23391 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-05asterix: add a link to the specificationsMartin Kaiser1-0/+8
It was pointed out during the discussions in https://code.wireshark.org/review/#/c/19568/ that the specifications are publicly available. Change-Id: Idc21a606c9b9aedb16f7632b24322c901e7db524 Reviewed-on: https://code.wireshark.org/review/21963 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2017-04-11packet-asterix.c: Make hf_021_230_RA FT_DOUBLE typeMichael Mann1-1/+1
Bug: 13580 Change-Id: I4861c9b69bafe72ecb44e57c9be393506fb9715b Reviewed-on: https://code.wireshark.org/review/21021 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-23ASTERIX: Avoid an integer overflow.Gerald Combs1-4/+5
Count using a guint instead of a guint8. Bug: 13344 Change-Id: Ic7d337dbb29b92ebb8332f50fd47b5ba2aa3f41e Reviewed-on: https://code.wireshark.org/review/19746 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-11packet-asterix.c doesn't need a preference callback function.Michael Mann1-1/+1
Just causes preference to be added twice. Bug: 13113 Change-Id: Iebbe296a8b35cbe58c163c4f1f5fac9d27c76ead Reviewed-on: https://code.wireshark.org/review/18737 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-13Convert most UDP dissectors to use "auto" preferences.Michael Mann1-1/+1
Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67, convert dissectors that use "udp.port". More cleanup done on dissectors that use both TCP and UDP dissector tables, so that less preference callbacks exist. Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3 Reviewed-on: https://code.wireshark.org/review/18120 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-19asterix: remove unused hf entryMartin Kaiser1-2/+0
Change-Id: I17dc7cfb8144dbfe3e36ff1902ce91241c5629ed Reviewed-on: https://code.wireshark.org/review/16536 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-04Include ws_diag_control.h in config.hJoão Valverde1-4/+1
Change-Id: Ia394071710ecda3b0e6686a51fbca45a8ff20317 Reviewed-on: https://code.wireshark.org/review/14749 Petri-Dish: João Valverde <j@v6e.pt> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-26ASTERIX: Add CAT025 dissectionAndrew Hoag1-1/+245
The CAT025 type of ASTERIX messages is "CNS/ATM Ground System Status Report". Change-Id: Icf39d595cef8663357a487b799bf32e738236757 Reviewed-on: https://code.wireshark.org/review/14590 Tested-by: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-17ASTERIX: fix for wrong RE and SP fields in CAT048.Marko Hrastovec1-1/+1
Bug: 12267 Change-Id: I4871da19cb8b11e2df0de13993350a71168f7ab4 Reviewed-on: https://code.wireshark.org/review/14502 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-09Convert some UDP subdissectors to "new" style.Michael Mann1-3/+4
Change-Id: I3c1ee97f68af4539b97d50b75c03ff82147dbc5e Reviewed-on: https://code.wireshark.org/review/11649 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-18Asterix: field array must be NULL terminatedPascal Quantin1-5/+10
Bug: 11287 Change-Id: Iffcaa1cd2663768f616aedb550a101b7196e456b Reviewed-on: https://code.wireshark.org/review/8975 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-06-17Asterix dissector support for category 021 v2.3Andrew Hoag1-6/+48
- Add item 040 field LLC - Add item 200 field ME - Edit item 271 field LW Change-Id: I13b3774b248731f208b3b950f7ae0736398edbe4 Reviewed-on: https://code.wireshark.org/review/8892 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Marko Hrastovec <marko.hrastovec@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-06-12Asterix dissector can now dissect ASTERIX Category 004.Marko Hrastovec1-5/+1217
The code was added to dissect CAT004. Change-Id: I7be543468d7df959db6bcef53d21d49846d29990 Reviewed-on: https://code.wireshark.org/review/8883 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-16Suppress more pedantic warnings.Gerald Combs1-0/+29
Suppress warning: initialization of a flexible array member [-Wpedantic] Change-Id: I49c2cf8b97539660742ef1b19752a0f56404d78a Reviewed-on: https://code.wireshark.org/review/7155 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-22Decoding of Asterix categories 063 and 065 extended to item decoding.Marko Hrastovec1-25/+337
Categories 063 and 065 were decoded only partially. Now the dissector dissects all the items in these two categories. Change-Id: Ib8fd1d18327cbea668600f7376a6b83a270909a2 Reviewed-on: https://code.wireshark.org/review/6714 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-12-22First batch of unincludes. Last attempt...Martin Mathieson1-1/+0
Change-Id: I3681462aeb98ca62ed3ec5eb226b2553317391a9 Reviewed-on: https://code.wireshark.org/review/5997 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+2
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-13Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...Bill Meier1-1/+1
(for some dissectors which fetch all other integral fields using ENC_BIG_ENDIAN). Change-Id: Ic18e3172aad76af12b12d6732c88497be22aed56 Reviewed-on: https://code.wireshark.org/review/5748 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-01Asterix: fix Coverity scan (1025624 & 1025625: Missing break in switch)Marko Hrastovec1-0/+2
Two comments are added to the code to notify Coverity scan that breaks are not put in switch statement intentionally. Change-Id: Ie391790ee7365da56ddf0bf7b19042c9a11efddd Reviewed-on: https://code.wireshark.org/review/5554 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-11-26Fix a number of dup hf[] filter-names probably resulting from cut/paste errs.Bill Meier1-1/+1
Change-Id: I9242300b2ace3155c1506b584a90f073100a305e Reviewed-on: https://code.wireshark.org/review/5512 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-05-25Grab-bag of dead initializers and two actual bugs.Evan Huus1-5/+2
All caught by cppcheck. The two (semi)-interesting bugs are: - in asn1/atn-cpdlc/packet-atn-cpdlc-template.c where the break statement should have been inside the brace, causing potential control-flow weirdness with exceptions - in epan/dissectors/packet-ieee80211.c where the bounds check for tag_len did not match the expert info given Change-Id: Ie173fb8d917aabb9b4571435d671d6f16e1c7569 Reviewed-on: https://code.wireshark.org/review/1793 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-11Function to calculate twos complement is quicker and hopefully better ↵Marko Hrastovec1-7/+4
understandable. Change-Id: I1948eeaf5fa5aa4a5ccd0f81be894f655907a4dc Reviewed-on: https://code.wireshark.org/review/1570 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-08ASTERIX - added dissector for category 023.Marko Hrastovec1-4/+297
Sample file with traffic is the same as for CAT021 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9953). Apply filter "asterix.category == 23" to see only CAT023 packets. A small change in actual dissecting code was also needed because of strange item I023/101. The first FX bit is in the second byte and then grows only for a byte. Change-Id: I3f80e6e46b642efc6f2e19e6f931cdef1c39495a Reviewed-on: https://code.wireshark.org/review/993 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-06Bugfix for ASTERIX category 021.Marko Hrastovec1-4/+2
It was found in https://code.wireshark.org/review/#/c/972/ and only commented out. The bug is now fixed, the variable is used. Change-Id: I0361b269a06f45f4d36b8bc97c3623618cb5f859 Reviewed-on: https://code.wireshark.org/review/976 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-05Get it compiling again: packet-asterix.c has unused const variable.Hadriel Kaplan1-0/+3
Change-Id: I07125f1779063527f24d9195a9999cef4c8fe343 Reviewed-on: https://code.wireshark.org/review/972 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-04-05Decoder for category 021 added to ASTERIX dissector. Bug 9953.Michael Mann1-2/+1561
Change-Id: If72685f41cd32854d6c0c04716ee640196431f87 Reviewed-on: https://code.wireshark.org/review/961 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-17Asterix CAT062 fix. Units for cartesian velocity of track were displayed ↵Marko Hrastovec1-2/+2
with wrong units. Change-Id: I716dfeb16b049544e691dcdf75c488758d9e1fa0 Reviewed-on: https://code.wireshark.org/review/707 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespace.Bill Meier1-1/+1
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6 Reviewed-on: https://code.wireshark.org/review/372 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-01-28From Marko Hrastovec viaEvan Huus1-320/+1160
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9697 Architectural support for multiple version of the same Asterix categories. Includes implementation of CAT064 v.0.17. svn path=/trunk/; revision=54987
2014-01-09From Marko HrastovecMartin Kaiser1-6/+356
dissect all elements of category 48 messages https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9629 svn path=/trunk/; revision=54680
2014-01-09From Marko HrastovecMartin Kaiser1-3/+3
rename RE field len to make it generic for all categories https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9624 svn path=/trunk/; revision=54679
2014-01-08remove duplicate editor modelinesMartin Kaiser1-4/+0
it's enough to have them at the end of the file svn path=/trunk/; revision=54665
2014-01-08From Antony BridleMartin Kaiser1-18/+121
Added dissection capabilities for ASTERIX Category 062 Reserved Expansion Field. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9624 svn path=/trunk/; revision=54664
2013-12-22Don't use 'L' as a constant modifier.Bill Meier1-1/+1
svn path=/trunk/; revision=54358
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-10-29Whitespace fixes: Replace some tabs by spaces & etcBill Meier1-100/+100
svn path=/trunk/; revision=52950
2013-10-29From Marko Hrastovec via ↵Jeff Morriss1-6/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9347 : Asterix dissector had two #if 0 ... #endif blocks because it obviously did not compile on some systems. Blocks were created because of mistyped variable names and variable not used warning/error. The errors were corrected. svn path=/trunk/; revision=52949
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+4
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-22Remove instances of unused 'data_handle' (and of one other handle).Bill Meier1-3/+0
svn path=/trunk/; revision=52767
2013-10-10From Marko Hrastovec viaEvan Huus1-1/+300
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9239 Add dissection of Asterix category 008. svn path=/trunk/; revision=52496
2013-08-05Keep result of [new_]register_dissector in some dissectors. [2 of x]Jakub Zawadzki1-3/+3
(don't create new dissector handle if we can use already existing one) svn path=/trunk/; revision=51159
2013-07-30From Marko Hrastovec viaStig Bjørlykke1-75/+75
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8994 Adjusts field lengths to display values properly. svn path=/trunk/; revision=51025
2013-07-18From Marko Hrastovec via ↵Jeff Morriss1-14/+42
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8926 : A better fix for this bug (as compared to r50532): this version takes into account the scaling factors. svn path=/trunk/; revision=50732