aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-artnet.c
AgeCommit message (Collapse)AuthorFilesLines
2014-08-03Eliminate proto_tree_add_text from some dissectors.Michael Mann1-5/+11
Change-Id: Ib6024307e85d6c23decf40e9759f549c19ffe136 Reviewed-on: https://code.wireshark.org/review/3318 Petri-Dish: Michael Mann <mmann78@netscape.net> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris1-1/+1
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-1/+1
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-1/+1
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-1/+1
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-23Use tvb_get_string_enc() rather than tvb_get_string().Guy Harris1-2/+2
Update URL of spec. svn path=/trunk/; revision=54924
2013-12-20Change G_GINT64_CONSTANT(xxxxU) to G_GUINT64_CONSTANT(xxxx)Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=54314
2013-10-14Try to pptimize heuristics slightly.Anders Broman1-4/+5
svn path=/trunk/; revision=52603
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-03-12- [-Wmissing-prototypes]Anders Broman1-0/+3
- explicit casts. svn path=/trunk/; revision=48274
2013-02-21String passed to val_to_str() must have int format specifier (%u, %d, %x, ↵Jakub Zawadzki1-2/+2
and so on...). Fix some cases (easy to grep) by call to val_to_str_const(). svn path=/trunk/; revision=47807
2012-10-24No need to increment offset past bytes in tvb; just return instead.Chris Maynard1-8/+5
svn path=/trunk/; revision=45772
2012-10-18General cleanup:Bill Meier1-338/+253
- revert incorrect replacement of FALSE by ENC_BIG_ENDIAN done a while back (2 cases); [The incorrect use of ENC_BIG_ENDIAN was benign since ENC_BIG_ENDIAN is currently defined ad 0x0000000]; - use proto_tree_add_item() instead of proto_tree_add_uint() when appropriate; - move proto_register...() to just before proto_reg_handoff..() as per convention; - proto_reg_handoff...() doesn't need 'if (!initialized)' - remove unneeded #includes; - remove some "boilerplate" comments; - remove unneeded forward declaration; - whitespace. svn path=/trunk/; revision=45631
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-23Comment out all but first value_string array entries with dup values:Bill Meier1-2/+1
kept: first dup since that's the one which would be found with a linear search. svn path=/trunk/; revision=44642
2012-07-24(Trivial) whitespace cleanupBill Meier1-7/+7
svn path=/trunk/; revision=43959
2012-07-13Fix incorrect(duplicate) value in artnet_oem_code_vals[] value string array;Bill Meier1-1/+1
{ 0x0ae0, "chainzone:RoundTable:0 DMX Inputs, ... - { 0x0ae0, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:... + { 0x0b00, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:... Correct value obtained from Bug #7407 attachment #8684: "Art-Net OEM manufacturer codes for 1.4be specification" https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8684 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407 (Issue noticed because value_string_ext search was 'linear' for this array). svn path=/trunk/; revision=43689
2012-07-06Add a few missing ENC_ASCII and remove a few unused hf entriesPascal Quantin1-32/+4
svn path=/trunk/; revision=43581
2012-07-06From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407 :Pascal Quantin1-4/+772
Update ESTA manufacturer IDs and OEM code values svn path=/trunk/; revision=43580
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-28Set but not used variableAnders Broman1-2/+0
svn path=/trunk/; revision=42885
2012-05-28Remove C++ style comments initilize some variables.Anders Broman1-3/+4
svn path=/trunk/; revision=42884
2012-05-28From Erwin Rol:Anders Broman1-299/+1282
Artnet, RDM and DMX dissector updates https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7286 svn path=/trunk/; revision=42880
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-4/+2
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
2012-04-23Do indentation cleanup (e.g., 4-space tabs => spaces)Bill Meier1-9/+9
Reformat a few long lines. svn path=/trunk/; revision=42213
2012-04-04Avoid some potential divide by zero errors that Clang reports.Chris Maynard1-1/+1
svn path=/trunk/; revision=41923
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier1-1/+1
(Some minor whitespace cleanup). svn path=/trunk/; revision=39488
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-7/+7
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-3/+3
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-62/+62
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-09-26Get rid of check_col, while at it set ENC.Anders Broman1-108/+104
svn path=/trunk/; revision=39146
2011-04-19From Michael Mann via bug 2794:Stig Bjørlykke1-1/+1
Fixed display filters with obvious typos. svn path=/trunk/; revision=36713
2011-01-16Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure theJeff Morriss1-1/+1
return string is NULL terminated. There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_*(): just use proto_tree_add_item(). svn path=/trunk/; revision=35548
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.Jeff Morriss1-6/+6
svn path=/trunk/; revision=34227
2010-05-10Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)Bill Meier1-15/+15
svn path=/trunk/; revision=32735
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2009-10-09From Didier Gautheron:Anders Broman1-7/+5
Dissectors using call_dissector() function inside a 'if (tree) {}' block. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107 svn path=/trunk/; revision=30415
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-3/+1
svn path=/trunk/; revision=29346
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-3/+1
svn path=/trunk/; revision=29345
2009-07-07From Kovarththanan Rajaratnam:Stig Bjørlykke1-1/+1
More FT_XXX cleanup. svn path=/trunk/; revision=28971
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-132/+132
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-01From Reinhard Speyerer:Jaap Keuter1-3/+3
This patch fixes several misspellings/typos in Wireshark SVN revision 28201. svn path=/trunk/; revision=28208
2009-03-18None of those strings will have a length that doesn't fit in a gulong.Guy Harris1-4/+4
svn path=/trunk/; revision=27787
2009-03-17Add a comment about the way g_snprintf() is used.Bill Meier1-0/+7
svn path=/trunk/; revision=27756
2009-02-22Incorporate plugin dissector into build in collection.Jaap Keuter1-0/+2705
svn path=/trunk/; revision=27505