aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-afp.c
AgeCommit message (Collapse)AuthorFilesLines
2011-12-04Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clangalagoutte1-8/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40093 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-19Fix Coverity ID #1288: UNUSED_VALUE in spotlight_dissect_query_loop:sfisher1-1/+1
"returned_pointer: Pointer ... is never used" due to break and end of function after the switch block. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39470 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-19Fix Coverity ID 1300: UNUSED_VALUE in dissect_spotlight: "returned_pointersfisher1-6/+6
is never used" because of the return -1 at the end of this if block. Removed item_toc = assignment and fixed indentation. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39469 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-17Cleanup AFP Version display filter name.cmaynard1-5/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39448 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵wmeier1-24/+24
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39426 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-02Squelch some more warnings.guy1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39212 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-02Squelch warnings (at that point, toc_offset has been determined to fitguy1-6/+6
into an int, as has offset + toc_offset + 8). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39211 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-02SQ_TYPE_NULL appears to do run-length encoding of nulls; do run-lengthguy1-99/+236
encoding of the list of nulls in the protocol tree, so if we have a ridiculously large number of nulls, we don't have a ridiculously large number of protocol tree entries, one for each null. This should (finally) fix bug 6378. Add some additional sanity checks to avoid integer overflows and underflows due to subtracting N from a value not guaranteed to be >= N. In the big switch statements for AFP command codes, put the break statement on a separate line, so it's a bit more obvious that the code isn't falling through. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39210 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-28Quit if we have a zero-length query, so we don't loop indefinitely. guy1-0/+4
Should fix bug 6378. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39176 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-21Make query_length a gint as the lenght argument to proto_tree_add_text() is ↵etxrab1-1/+1
a gint. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39067 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-20From Frank Lahm: Complete dissection of AFP FPSpotlightRPC function.guy1-154/+320
From me: don't use global variables in FPSpotlightRPC dissection. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39065 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-20Use ENC_ values in proto_tree_add_item() calls. Use ENC_UTF_8 forguy1-409/+440
strings, and note that, for older AFP clients and servers, we might need a way to say to use some Mac encoding instead. Use tvb_strsize() rather than tvb_get_ephemeral_stringz() to just get the length of a null-terminated string. Use FT_GUID for UUIDs. The low-order bit in the MessageBitmap in the FPGetSrvrMsg reply does not, at least according to the current AFP spec, specify whether there's a message at all, it specifies whether it's a server message or a login message. The spec *does* now mention the "message is UTF-8" bit; use it. Fix a blurb. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39063 f5534014-38df-0310-8fa8-9805f1628bb7
2011-06-17Added some casts from spotlight_ntoh64 to guint.stig1-5/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37694 f5534014-38df-0310-8fa8-9805f1628bb7
2011-05-26From Michael Mann.etxrab1-1/+1
Part of "display filters with redundancies of PROTABBREV in them." The ones left outs should be fixed differently I think. Rename som ndps hf variables while at it. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37406 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-16Use tvb_memeql().morriss1-2/+2
Use tvb_ip_to_str(). There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the return string is NULL terminated. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35547 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-08Use value_string_ext fcns to access certain value_string arrays;wmeier1-334/+340
Sort a few value_string arrays to be in ascending order by value; Do minor reformatting and whitespace cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34813 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-24(Refining the regexp...) Replace blurbs that match the name (case ↵morriss1-4/+4
insensitive) with NULL. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34230 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-24Replace another blurb that matches the name (case insensitive) with NULL.morriss1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34228 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.morriss1-13/+13
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34227 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-08From Frank Lahm via bug #5169: Provide initial support for the undocumentedsfisher1-0/+379
AFP FPSpotlightRPC call. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34083 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-27Update some links.guy1-3/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33969 f5534014-38df-0310-8fa8-9805f1628bb7
2010-08-27From Frank Lahm via bug 5136:stig1-7/+7
Correct volume flags for FPGetSrvrParms. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33961 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-13As suggested in ↵morriss1-8/+1
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32790 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-06Use consistent indentation & whitespace.wmeier1-2318/+2318
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32693 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-06#include <string.h> not needed.wmeier1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32410 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-03Remove unneeded #include <stdio.h>wmeier1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32367 f5534014-38df-0310-8fa8-9805f1628bb7
2010-03-03remove check_coletxrab1-45/+26
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32089 f5534014-38df-0310-8fa8-9805f1628bb7
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofguy1-7/+7
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31319 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-30Remove some unneeded (indirect) 'if(check_col()...)' guarding.wmeier1-11/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30213 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-15From Didier Gautheron via ↵morriss1-13/+22
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3995 There's a copy and paste error in hf_afp_vol_attribute_CaseSensitive declaration and add kSupportsTMLockSteal git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29916 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-10From Alex deVries:etxrab1-4/+15
DSI/AFP dissectors need support for AFP 3.3 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3995 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29836 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()krj1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29446 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkkrj1-2/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29340 f5534014-38df-0310-8fa8-9805f1628bb7
2009-06-18From Kovarththanan Rajaratnam via bug 3548:stig1-84/+84
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28770 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-25Added an expert info for "IP port reused".stig1-1/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28472 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-17From Didier Gautheron via bug 3210:gerald1-13/+65
This patch improves the decoding of MapID and MapName Apple's AFP commands for subtype 5 and 6. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28383 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-23Fixed some data types to remove some warnings.stig1-14/+12
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27828 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-31Fix some "format not a string literal and no format arguments" warnings.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26646 f5534014-38df-0310-8fa8-9805f1628bb7
2008-08-14Fix a few typos & spelling errorswmeier1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26014 f5534014-38df-0310-8fa8-9805f1628bb7
2008-04-21From Alex deVries (bug 2486):stig1-0/+23
This adds fpSyncFork and fpSyncDir functionality to the AFP dissector. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25142 f5534014-38df-0310-8fa8-9805f1628bb7
2008-04-09Remove:etxrab1-4/+0
#ifdef NEED_G_ASCII_STRCASECMP_H #include "g_ascii_strcasecmp.h" #endif git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24859 f5534014-38df-0310-8fa8-9805f1628bb7
2008-03-14Update documentation links.guy1-5/+9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24623 f5534014-38df-0310-8fa8-9805f1628bb7
2007-11-27strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delendaguy1-4/+8
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our own versions if they're missing from GLib (as is the case with GLib 1.x). In the code to build the list of named fields for Diameter, don't use g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping in the hash function and use g_ascii_strcasecmp() in the compare function. We do this because there is no guarantee that toupper(), tolower(), and functions that use them will, for example, map between "I" and "i" in all locales; in Turkish locales, for example, there are, in both upper case and lower case, versions of "i" with and without a dot, and the upper-case version of "i" is "I"-with-a-dot and the lower-case version of "I" is "i"-without-a-dot. This causes strings that should match not to match. This finishes fixing bug 2010 - an earlier checkin prevented the crash (as there are other ways to produce the same crash, e.g. a bogus dictionary.xml file), but didn't fix the case-insensitive string matching. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23623 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-15Implement some of the minor possible speed improvment patches.etxrab1-76/+80
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23192 f5534014-38df-0310-8fa8-9805f1628bb7
2007-06-13Include a link to the AFP reference, as well as to the programmingguy1-0/+2
guide. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22095 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-28Remove almost all of the casts I committed recently and in place ofsfisher1-4/+4
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21253 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors sfisher1-4/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21233 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-26From Peter Johansson:sfisher1-3/+1
Fix warnings git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21214 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-23fix some more warningsulfl1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21143 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-19packet-afp: remove unneeded line of code;wmeier1-1/+0
packet-sctp: register sctp dissector since packet-lge-monitor wants to call same git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20850 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-03 15:31:55 +0000