aboutsummaryrefslogtreecommitdiffstats
path: root/echld/echld.h
AgeCommit message (Collapse)AuthorFilesLines
2014-07-07Wrong macro.Guy Harris1-1/+1
Change-Id: I2e0e7c1a30c9fc2d5af7cbd53dae26ad9a619e71 Reviewed-on: https://code.wireshark.org/review/2908 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-06Add printf-format annotations, fix garbagePeter Wu1-1/+3
The WRETH dissector showed up some garbage in the column display. Upon further inspection, it turns out that the format string had a trailing percent sign which caused (unsigned)-1 to be returned by g_printf_string_upper_bound (in emem_strdup_vprintf). Then ep_alloc is called with (unsigned)-1 + 1 = 0 memory, no wonder that garbage shows up. ASAN could not even catch this error because EP is in charge of this. So, start adding G_GNUC_PRINTF annotations in each header that uses the "fmt" or "format" paramters (grepped + awk). This revealed some other errors. The NCP2222 dissector was missing a format string (not a security vuln though). Many dissectors used val_to_str with a constant (but empty) string, these have been replaced by val_to_str_const. ASN.1 dissectors were regenerated for this. Minor: the mate plugin used "%X" instead of "%p" for a pointer type. The ncp2222 dissector and wimax plugin gained modelines. Change-Id: I7f3f6a3136116f9b251719830a39a7b21646f622 Reviewed-on: https://code.wireshark.org/review/2881 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-09-13Fix warnings shown by gcc-4.8.1Jörg Mayer1-3/+4
/home/jmayer/work/wireshark/svn/trunk/echld/common.c:134:2: error: enum conversion in initialization is invalid in C++ [-Werror=c++-compat] {0,NULL} ^ /home/jmayer/work/wireshark/svn/trunk/echld/common.c:134:2: error: (near initialization for ‘t_map[34].type’) [-Werror=c++-compat] /home/jmayer/work/wireshark/svn/trunk/echld/common.c:269:3: note: expected ‘echld_msg_type_t’ but argument is of type ‘guint32’ /home/jmayer/work/wireshark/svn/trunk/echld/common.c:253:8: error: variable ‘off’ set but not used [-Werror=unused-but-set-variable] long off; ^ cc1: all warnings being treated as errors Still todo: /home/jmayer/work/wireshark/svn/trunk/echld/common.c: In function ‘echld_read_frame’: /home/jmayer/work/wireshark/svn/trunk/echld/common.c:269:3: error: enum conversion when passing argument 4 of ‘cb’ is invalid in C++ [-Werror=c++-compat] cb( &(r->rp[sizeof(hdr_t)]), HDR_LEN(h), h->h.chld_id, HDR_TYPE(h), h->h.reqh_id, cb_data); ^ /home/jmayer/work/wireshark/svn/trunk/echld/common.c:269:3: note: expected ‘echld_msg_type_t’ but argument is of type ‘guint32’ Whitespace fixes svn path=/trunk/; revision=52007
2013-07-23Yet another iteration...Luis Ontanon1-4/+21
svn path=/trunk/; revision=50846
2013-07-21Remove trailing whitespaceJörg Mayer1-14/+14
svn path=/trunk/; revision=50754
2013-07-05Yet another iteration:Luis Ontanon1-24/+51
- improve the parameter api - Add a parameter set message to the NEW child message to set parameters in bulk in the child - some more harvestig from tshark svn path=/trunk/; revision=50393
2013-06-29One further iteration, get things right, put placeholders for things to do.Luis Ontanon1-0/+1
svn path=/trunk/; revision=50227
2013-06-28MS: new childLuis Ontanon1-0/+1
MS: ping child MS: set/get child parameter svn path=/trunk/; revision=50218
2013-06-27MS: list interfaces!Luis Ontanon1-1/+9
svn path=/trunk/; revision=50195
2013-06-25another iteration, prepared for automake.Luis Ontanon1-32/+34
svn path=/trunk/; revision=50136
2013-06-22Not yet running but almost there with the dummyLuis Ontanon1-30/+5
svn path=/trunk/; revision=50114
2013-06-21move echld to final dest...Luis Ontanon1-0/+401
svn path=/trunk/; revision=50102
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-18 03:32:46 +0000