aboutsummaryrefslogtreecommitdiffstats
path: root/asn1/c1222
AgeCommit message (Collapse)AuthorFilesLines
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-1/+1
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-04C12.22: fix compilation without LibgcryptPascal Quantin1-1/+3
Change-Id: I9ef842b4ed543cfbd199e49496bc01a09f71404b Reviewed-on: https://code.wireshark.org/review/13039 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-01ifdef out the decryption code and preferences if LIBGCRYPT isn't defined.Guy Harris1-22/+22
Change-Id: Idf4f1e461d3bc6e85f2760488ad566a4cd70c5ea Reviewed-on: https://code.wireshark.org/review/12999 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-10Convert ASN.1 dissectors to remove "new" from "new-style" dissector function ↵Michael Mann1-1/+1
names that were generated from asn2wrs.py This includes: 1. new_create_dissector_handle -> create_dissector_handle 2. new_register_dissector -> register_dissector 3. new_register_ber_oid_dissector -> register_ber_oid_dissector 4. new_register_ber_syntax_dissector -> register_ber_syntax_dissector Also remove PDU_NEW, SYNTAX_NEW and REGISTER_NEW as there is no need for the distinction anymore. Change-Id: I82c7de7c8ffeeab3259d1b55bb4afc5f6a1e0329 Reviewed-on: https://code.wireshark.org/review/12491 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09"new" dissector API -> dissector API for ASN.1 dissectors.Michael Mann1-2/+2
Change-Id: I7b794cba2feda2cae40411e2b1cb9fb091d08220 Reviewed-on: https://code.wireshark.org/review/12480 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-01C12.22: check c1222_baseoid_len before doing a memcpyPascal Quantin1-4/+10
Should fix the following runtime error reported by Joerg: ../../asn1/c1222/packet-c1222-template.c:1427:3: runtime error: null pointer passed as argument 1, which is declared to never be null ../../asn1/c1222/packet-c1222-template.c:1427:3: runtime error: null pointer passed as argument 2, which is declared to never be null Change-Id: I2f952815ed81e47b504e6479835a357b7656828e Reviewed-on: https://code.wireshark.org/review/8251 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-09REplace deprecated API tvb_length -> tvb_reported_lengthAndersBroman1-2/+2
Change-Id: I6090055a9c31f6787626b810de655d1cc71b99de Reviewed-on: https://code.wireshark.org/review/8002 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-18Make UAT record update callbacks return a success/failure indication.Guy Harris1-1/+5
Have them return TRUE on success and FALSE on failure. Check the return value rather than whether the error string pointer is null or not. Change-Id: I800a03bcd70a6bbb7b217cf7c4800e9cdcf2189c Reviewed-on: https://code.wireshark.org/review/7222 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-27Lua: Expose tcp_dissect_pdus() to LuaHadriel Kaplan1-1/+1
Provide a way for Lua-based dissectors to invoke tcp_dissect_pdus() to make TCP-based dissection easier. Bug: 9851 Change-Id: I91630ebf1f1fc1964118b6750cc34238e18a8ad3 Reviewed-on: https://code.wireshark.org/review/6778 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com>
2015-01-19Convert OID APIs to use wmem.Michael Mann1-1/+2
There are a few oid functions that are only called in oids_test.c. I'll presume the APIs are used in proprietary dissectors rather than just remove them. Change-Id: I4595e00f93bf9ab8cf2493fe0432b91960f55a3f Reviewed-on: https://code.wireshark.org/review/6592 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-13UAT error string pointers should not be const pointers.Guy Harris1-1/+1
UAT error strings are usually allocated by g_strdup() or g_strdup_printf(), and must ultimately be freed by the caller. Make the pointer-to-error-string-pointer arguments to various functions be "char **", not "const char **". Fix cases that finds where a raw string was being used, as that won't work if you try to free it; g_strdup() it instead. Add a missing free of an error string. Remove some no-longer-necessary casts. Remove some unnecessary g_strdup()s (the string being handed to it was already g_malloc()ated). Change some variable declarations to match. Put in XXX comments for some cases where the error string is just freed, without being shown to the user. Change-Id: I40297746a2ef729c56763baeddbb0842386fa0d0 Reviewed-on: https://code.wireshark.org/review/6525 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-07tvb_bytes_to_ep_str -> tvb_bytes_to_strMichael Mann1-1/+1
Change-Id: I79c613cbdd8dc939dd4c29ebc477fb6eefd5bfc4 Reviewed-on: https://code.wireshark.org/review/6371 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier1-11/+4
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-22Fix unknown command tag name [-Wdocumentation-unknown-command]Alexis La Goutte1-1/+1
Change-Id: I6c2564a86e13d9321001856ba1f51681a9f20976 Reviewed-on: https://code.wireshark.org/review/5979 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-13ASN1: Register PDU-dissectors as NEWStig Bjørlykke2-8/+4
Change-Id: I1a317b19d8076588c9305dae6287bb80cc14da64 Reviewed-on: https://code.wireshark.org/review/4494 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-07-30Add some files under asn1 to the distribution.Guy Harris1-1/+1
Include CMakeLists.txt files and the gnm subdirectory, along with the top-level Makefile.inc and Makefile.preinc files. Don't explicitly include Custom.make, as automake does that automatically given that it's included by asn1/Makefile.am. Add some files to EXTRA_DIST lists. Move some .asn files to EXTRA_DIST; they don't need to be in SRC_FILES, as SRC_FILES always includes EXTRA_DIST, and they *do* need to be in EXTRA_DIST so that they're in the distribution. Change-Id: Id91df577260fa57028d40fe098be1d79c59398e6 Reviewed-on: https://code.wireshark.org/review/3273 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19batch of manual tvb_length conversionsEvan Huus1-2/+2
Change-Id: Ib3a1ddc4342a7a8648d6ed8bfcb35aa229c56a27 Reviewed-on: https://code.wireshark.org/review/2445 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Update ASN.1 source files with the API changes done in g021e7af"Pascal Quantin1-4/+4
This reverts commit e308e7c4de81c2ff7159e444b865ac59de4faa2b. Change-Id: I079616d63f643f79f1bc03ef5fdf724f36df4071 Reviewed-on: https://code.wireshark.org/review/2435 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update ASN.1 source files with the API changes done in g971ffd6Pascal Quantin1-2/+2
Change-Id: Iac4952f64622cd28941f582adf54ecf7843f8c28 Reviewed-on: https://code.wireshark.org/review/2395 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update ASN.1 source files with the API changes done in g021e7afPascal Quantin1-4/+4
Change-Id: I52ecfccbce423206242e3cf99401a8c9e1655d88 Reviewed-on: https://code.wireshark.org/review/2385 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate ↵Bill Meier1-2/+2
dissectors. Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4 Reviewed-on: https://code.wireshark.org/review/412 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-18Remove $Id$ from the ASN.1 dissectors and regenerate them.Jeff Morriss7-17/+0
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954 Reviewed-on: https://code.wireshark.org/review/244 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-03Apply g4cc69483 to asn1 templates.Stig Bjørlykke1-1/+1
Change-Id: Id44ef17e7293be5d713c5e9e5d55b25194b46016 Reviewed-on: https://code.wireshark.org/review/86 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-1/+1
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-10- Forward declaration of register functions.Anders Broman1-0/+2
svn path=/trunk/; revision=53901
2013-11-09Add data parameter to tcp_dissect_pdus() as well as convert it to using ↵Michael Mann1-7/+10
"new" style dissectors. Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that? Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one. svn path=/trunk/; revision=53198
2013-11-07Remove extraction of cmake parameters from autotools files.Jörg Mayer1-33/+17
While it was an interesting exercise it just doesn't work good enough to stay, i.e. it doesn't automatically pick up changes but requires rerunning cmake instead. svn path=/trunk/; revision=53149
2013-10-25Add a very small hack to make the UAT update callback error string freeable, andEvan Huus1-3/+3
convert all existing UAT update callbacks to use glib memory instead of ephemeral memory for that string. UAT code paths are entirely distinct from packet dissection, so using ephemeral memory was the wrong choice, because there was no guarantees about when it would be freed. The move away from emem still needs to be propogated deeper into the UAT code itself at some point. Net effect: remove another bunch of emem calls from dissectors, where replacing with wmem would have caused assertions. svn path=/trunk/; revision=52854
2013-10-16From Ed Beroset: add modelines and fix irregular indenting;Bill Meier4-334/+369
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9273 This patch adds modelines and cleans up the irregular indentation of this dissector's code. The only other change was in asn1/c1222/packet-c1222-template.c to consolidate an #ifdef that had a redundant #endif (line 812) and subsequent reopening #ifdef (line 824). The only thing between them was comments, so the span of the original #ifdef (line 644) was simply extended by eliminating those two lines. The purpose for this patch is to make the file easier to edit and understand in advance of more substantive patches later. This patch is intended to be easy to review by having only non-substantive changes. svn path=/trunk/; revision=52636
2013-10-11Fix compilation when we don't HAVE_LIBGCRYPTJeff Morriss1-2/+4
svn path=/trunk/; revision=52527
2013-10-10Add a call to tvb_ensure_bytes_exist before we allocate memory based on ourEvan Huus1-2/+3
offset+size, prevents attempts to allocate outrageous memory, fixing https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9260 svn path=/trunk/; revision=52503
2013-10-10From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9246Evan Huus2-10/+24
Fix memory leaks and bad memory accesses in c1222 dissector. From me: use realloc in a handoff function since it may get called multiple times, and we only need the latest. svn path=/trunk/; revision=52497
2013-10-06Fully support relative AP-titles in C12.22. Bug 9196 ↵Michael Mann4-12/+44
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9196) From Ed Beroset svn path=/trunk/; revision=52394
2013-09-26From beroset@mindspring.com:Anders Broman1-1/+1
c1222 dissector has wrong tag value for BER-encoding of calling_AE_qualifier https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9193 svn path=/trunk/; revision=52225
2013-09-22emem -> wmem conversion:Pascal Quantin1-6/+6
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-21Add _g_ to the names of functions that allocate glib memory. This is a bit moreEvan Huus1-4/+4
explicit, and frees up the "generic" names (like tvb_memdup) for new signatures that take the appropriate wmem pool. Majority of the conversion done with sed. svn path=/trunk/; revision=52164
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-15/+15
svn path=/trunk/; revision=51851
2013-08-12- Extract variables from Makefile.common.Jörg Mayer1-17/+33
- Apply this to asn1/c1222/ svn path=/trunk/; revision=51324
2013-08-10Fix (-W)documentation error found by ClangAlexis La Goutte1-20/+20
../../asn1/c1222/packet-c1222-template.c:348:15: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param pinfo ~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:349:14: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tree ~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:350:16: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param length ~~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:351:16: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param offset ~~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:758:11: error: parameter 'keybuf' not found in the function declaration [-Werror,-Wdocumentation] * \param keybuf is updated with a copy of the key data if successful lookup. ^~~~~~ ../../asn1/c1222/packet-c1222-template.c:758:11: note: did you mean 'keybuff'? * \param keybuf is updated with a copy of the key data if successful lookup. ^~~~~~ keybuff ../../asn1/c1222/packet-c1222-template.c:879:13: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tvb ~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:880:16: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param offset ~~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:881:13: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param len ~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:882:15: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param pinfo ~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:883:14: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tree ~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1023:13: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tvb ~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1024:15: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param pinfo ~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1025:14: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tree ~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1047:15: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param pinfo ~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1048:13: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tvb ~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1049:16: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param offset ~~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1068:13: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tvb ~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1069:15: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param pinfo ~~~~~~~~~~~^ ../../asn1/c1222/packet-c1222-template.c:1070:14: error: empty paragraph passed to '\param' command [-Werror,-Wdocumentation] * \param tree ~~~~~~~~~~^ svn path=/trunk/; revision=51272
2013-08-01Move a bunch of the crypt modules and pint.h into wsutil.Jeff Morriss1-2/+4
This means wsutil now links against libcrypt. Protect a bunch of the crypt header files from multiple inclusion. svn path=/trunk/; revision=51100
2013-07-06Squelch some warnings that show up with, for example, the GCC 4.2.1 thatGuy Harris1-1/+1
comes with Xcode 3.2.6 (it's not a real problem, but that requires more flow analysis than that version of the compiler does, apparently). svn path=/trunk/; revision=50419
2013-07-06Fix display filter errors caught by checkfiltername.plMichael Mann3-3/+3
svn path=/trunk/; revision=50399
2013-06-04From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8746 :Pascal Quantin1-5/+31
Add procedure numbers to C12.22 dissection svn path=/trunk/; revision=49775
2013-06-04From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8762 :Jeff Morriss1-6/+2
Remove dead code (condition can never happen). svn path=/trunk/; revision=49743
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann1-24/+56
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-06-01Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8745 :Pascal Quantin2-12/+16
Upgrade AP-title ASN.1 description svn path=/trunk/; revision=49684
2013-06-01Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8744 :Pascal Quantin1-0/+1
Display C12.22 Invocation Id as unsigned integer svn path=/trunk/; revision=49682
2013-05-07Another set of asn1 protocols can now be generated with cmakeJörg Mayer1-0/+30
svn path=/trunk/; revision=49197
2013-05-05Just whitespace changesJörg Mayer1-2/+3
svn path=/trunk/; revision=49167
2013-05-01Make C12.22 work over UDP.Anders Broman1-2/+5
svn path=/trunk/; revision=49104