aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-01-07BGP: update Well-known CommunitiesUli Heilmeier1-1/+10
Update the well-known communities as defined by https://www.iana.org/assignments/bgp-well-known-communities/bgp-well-known-communities.xhtml Communities for expired drafts has been ignored. Change-Id: I3dedea2bdaad8feda3c7f1d9886092d4c02d6f95 Reviewed-on: https://code.wireshark.org/review/35602 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07TFTP Header End FixRoman Koshelev1-2/+4
Change-Id: I70d66bb49384f2eac865a81ffc23b76362c37191 Reviewed-on: https://code.wireshark.org/review/35578 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07NL80211: Remove global variable m_pinfo from dissectorJaap Keuter1-29/+40
The Netlink 80211 dissector has a global variable to pass the pinfo pointer to dissection routines that need it. Replace this by properly passing it to the functions via a new private data structure, akin other netlink dissectors. Change-Id: Ie08e370b65f7068c01cc93100657e3b8baa5fd63 Reviewed-on: https://code.wireshark.org/review/35657 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07case-sensitive: Fix casing for PCAP and WinSparkleMartin Boye Petersen2-3/+3
CMake is unable to find PCAP and WinSparkle under Windows when using case sensitive folders. Change-Id: I30ba4073afc6089b08cef3c010b09c257362929b Reviewed-on: https://code.wireshark.org/review/35505 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07debian: remove double spaces.Dario Lombardo1-3/+3
Change-Id: Ifee8b32bbde5947944c6f3a30b5245d173beea09 Reviewed-on: https://code.wireshark.org/review/35661 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07Qt: Don't plot zero values in I/O scatter plotsGerald Combs3-7/+30
We don't currently distinguish between missing and zero values in I/O graphs. This can be problematic in scatter plots since the plot points tend to show up as chartjunk which overwhelms the X axis. In plain, non-calculated plots assume that zero values mean "missing" and omit those points. Describe this in the User's Guide, but comment the text out for now pending a full update to the I/O Graph section. Switch to title case in our default graphs. Make the TCP Errors graph red by default. Change-Id: I92dcbf05f58ae0b7b7734fa8dfc342424bbea114 Reviewed-on: https://code.wireshark.org/review/35645 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-smb2: handle SMB2_CHANNEL_RDMA_V1_INVALIDATE for readStefan Metzmacher1-0/+1
Change-Id: I96045fb2b07d8bae26360558f34dd6de3442ecd0 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35594 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-smb-direct: move Flags into data_tree.Stefan Metzmacher1-1/+1
Change-Id: I919994c084d4f5702b0a6d504c8cd5a8b716498b Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35596 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: implement NETLOGON_FLAG_AES decryptionStefan Metzmacher1-14/+159
Change-Id: I2ff05f528fe8c3ab6f5407c0289064b62f3f0202 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35593 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: remove STRONGKEY related processing from get_seal_key()Stefan Metzmacher1-24/+27
This won't be needed for NETLOGON_FLAG_AES. Change-Id: I668bca15ed13e5a2767fa3e39c5cad0d510a8f5d Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35592 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: split out prepare_decryption_cipher[_strong]()Stefan Metzmacher1-11/+56
Change-Id: Ie63c2d0311be058c5694245d8576ea75d7e6bc14 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35591 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: split out uncrypt_sequence_strong()Stefan Metzmacher1-2/+16
Change-Id: Ie58377b319632c74ad61c2df42e690466b5c5608 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35590 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: use the correct NETLOGON_FLAG_AES flagStefan Metzmacher1-8/+10
See [MS-NRPC] 3.1.4.2 Netlogon Negotiable Options, it's flag W: Supports Advanced Encryption Standard (AES) encryption (128 bit in 8-bit CFB mode) and SHA2 hashing ... Change-Id: I4b677e1ca1c3b3b9bc47ccc412380cc18659fd5d Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35589 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: fix the build with DEBUG_NETLOGONStefan Metzmacher1-2/+2
Change-Id: Iab70f2847343f934864cf205569fe64cf9e98d9b Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35588 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07UDP: Add a filter for payload.Anders Broman5-19/+64
A filter for payload makes it easier to exoprt it. Change-Id: I0732c60c7fac37283fcbe6508d5e27bcd3c603fd Reviewed-on: https://code.wireshark.org/review/35519 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07rtp_player: Player is able to set start of audio play by double clickJirka Novak9-60/+212
Patch adds ability to set start of audio play by double clicking on waveform. Patch fixes unreported issue with placing waveform at incorrect place when switched relative/absolute time mode (check/uncheck Time of Day). Change-Id: Ib8ce24aea870e2443e033afbb6d6e9fbcf222431 Reviewed-on: https://code.wireshark.org/review/35621 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07rtp_analysis_dialog: Improved codec recognition during saving of audio to .auJirka Novak2-26/+34
I found that when codec is negotiated to nonstandard payload id, it was reported as unsupported even was supported. Patch fixes it. Change-Id: I4eb14fc22f83eb42300fc67baee8456dff65d191 Reviewed-on: https://code.wireshark.org/review/35575 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07NAS 5GS: add missing R15 bits in 5GS network feature support IEPascal Quantin1-1/+29
Bug: 16310 Change-Id: I52a3e8bbe6ae89c227cd0eee58bb46ba37eceeb6 Reviewed-on: https://code.wireshark.org/review/35676 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07voip_calls_dialog/voip_calls: Fix for duplicated entries after retapJirka Novak1-0/+4
Issue seen from 2.6: 1) Open pcap with any VoIP call 2) Open Telephony->VoIP calls 3) Select one or more calls 4) Press Flow Sequence - sequence is shown 5) Close Flow Sequence 6) Press Play Streams - Play dialog is shown 7) Close Play dialog 8) Press Flow Sequence - sequence is shown, but all entries are duplicated If you repeat 6-7 multiple times, all entries are shown multiple times in 8 Patch adds missing clear of graph_analysis before retaping the stream. Tested on master, but should be backported to as many stable branches as possible. Change-Id: I9793f6e874defde2f377732d78689e957df71b33 Reviewed-on: https://code.wireshark.org/review/35672 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-06Qt: don't use monospace fonts for licence dialog.Dario Lombardo1-2/+0
Authors and licence dialogs were using monospace fonts to resemble GTK interface. Authors is not monospace anymore. Not using monospace for license dialog makes the text look more similar to other dialogs and more readable. Change-Id: I5a62f0993d579af5b1db7dea351d9a10175a069d Reviewed-on: https://code.wireshark.org/review/35663 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-06wsutil: Replace disallowed filename characters to '-'Stig Bjørlykke1-1/+18
Revert the removal of replacing disallowed filename characters in create_tempfile() to allow this characters in extcap interface names. This is a regression from g2925fb08. Change-Id: I833d1d19080c9c688dcaf076a840f55ef31e457d Reviewed-on: https://code.wireshark.org/review/35669 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-06NSIS: Don't package .pdb files.Gerald Combs5-15/+17
We run `windeployqt ... --pdbs` at build time, which means that we need to be careful not to include them in the NSIS package. Switch from using wildcards ("File ...\*") to using separate "File" commands for each file. Simplify the PDB Zip package command while we're here. Bug: 16307 Change-Id: Ibd9bcbdfdc216f1f6a067baf711bbc184845143f Reviewed-on: https://code.wireshark.org/review/35670 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-06USB MSC: Dissect subclass and protocol codesTomasz Moń2-1/+64
Change-Id: I7a818a11352e437a9492f896557c3348abe33c95 Reviewed-on: https://code.wireshark.org/review/35668 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-06Get rid of %debug, so protobuf_lang.y can be processed by Berkeley YACC.Guy Harris3-6/+3
If somebody wants to debug the parser, they can add it if necessary in their version. Bug: 16306 Change-Id: I00e5924058d9401176e3fab40833932dc5757e6a Reviewed-on: https://code.wireshark.org/review/35665 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-06USB Audio: Fix Feature Unit Descriptor dissectionTomasz Moń1-12/+26
Properly calculate the number of logical channels in the cluster. Report expert info if number of channels does not turn into integer. Bug: 16305 Change-Id: I028f3f00912629351641ef9297864ea832629cf0 Reviewed-on: https://code.wireshark.org/review/35656 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-06voip_calls_dialog: avoiding of 'remove_tap_listener(): no listener ...' warningJirka Novak2-4/+15
When voip_calls_dialog is opened and then closed, mentioned warning is shown because voip_calls_remove_all_tap_listeners is called twice in two different methods. Removing of the call from one of method is not possible therefore I introduced variable which tracks whether voip_calls_remove_all_tap_listeners was already called or not. Change-Id: Ic3c206cb7baf6612958d383880af296af019ffd8 Reviewed-on: https://code.wireshark.org/review/35660 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-05IPv4: Fix incorrect expert info for IGMP TTLJoão Valverde1-4/+7
IGMP uses TTL = 1 for the network control block. The code assumes a certain registered multicast destination address always carries traffic for that protocol, which isn't true. For example mDNS usually uses a TTL of 255 but IGMP Membership reports use a TTL of 1 for the same destination address. The end result is that IGMP traffic to mDNS multicast destination shows a confusing and incorrect "TTL != 255 for the Local Network Control Block" expert info. Rename the "ttl" variable for clarity. Change-Id: I693306cd6531aa250a6f5884a6731a2ea254bf2a Reviewed-on: https://code.wireshark.org/review/35639 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-05[Automatic update for 2020-01-05]Gerald Combs18-62/+134
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I871629b91d38be26bfe448bf90dfbb47a97acdfa Reviewed-on: https://code.wireshark.org/review/35652 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-05SIP: authorization validation segfault on missing fieldserikdejong1-1/+2
Fix for segfaults caused by missing username and or realm fields when validating SIP authorization. Change-Id: Ia418f2a7f036ef706fcd6e4a766ea43098a6883d Reviewed-on: https://code.wireshark.org/review/35644 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-05Try this - it might be clearer.Guy Harris1-1/+1
It doesn't contain the text "please do not report it", so nobody will think it's a warning not to report the problem, it just says "don't call it a crash". Change-Id: I9ce71e6a1cc37446a08e44da64c8411166844f75 Reviewed-on: https://code.wireshark.org/review/35649 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-05Rewrite the "please submit" message a bit.Guy Harris1-2/+2
Say "as a bug" upfront, and clarify that "please do not report it as such" doesn't mean "please do not report this at all" (even though we say "please report this" earlier), it means "please do not report this as being a crash". Change-Id: I2656c4c13e90fcf41d00a4b6ab3c2f2998f55fd6 Reviewed-on: https://code.wireshark.org/review/35647 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-05tools: Make compress-pngs a standard utility.Gerald Combs1-16/+15
Switch from using `find` to find PNGs to simply accepting a list of files as arguments. Pass long arguments to some compressors. Change-Id: I37884049026fea714d0dd30b08496744c6272379 Reviewed-on: https://code.wireshark.org/review/35646 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-04IPv4: Fix indentation (use spaces)João Valverde1-3/+2
Change-Id: Ie89c3c958567182c1f5fe66cff23522e797a3e78 Reviewed-on: https://code.wireshark.org/review/35640 Reviewed-by: João Valverde <j@v6e.pt>
2020-01-04gtpv2: added IE Monitoring Event InformationJoakim Karlsson1-3/+73
Change-Id: Icf02c5715c2eda01fc86d5a71a209983b2f5df68 Reviewed-on: https://code.wireshark.org/review/35603 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-04WSUG: Note that you can edit packet ranges.Gerald Combs1-0/+2
Note that you can edit the packet ranges shown in the Packet Lengths dialog. Change-Id: I23170de175e5b7cf5545240b3e4c8be716ce2c27 Reviewed-on: https://code.wireshark.org/review/35638 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03WSDG: More translation updates.Gerald Combs1-7/+22
Update the Transifex URL and describe how its resources are organized. Change-Id: Icc03ff57da73c0a60da0ea1e7ff19d6ecffae3a1 Reviewed-on: https://code.wireshark.org/review/35637 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03Qt: Update translations.Gerald Combs1-4750/+1426
We added wireshark_es.ts in gd832145366 / change 35620. Sync up with Transifex by running `tools/update-tx`. Change-Id: I3e565cbc227b124e79bc759ab6a6a095fed8ce5d Reviewed-on: https://code.wireshark.org/review/35635 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03WSUG: Add a Packet Lengths dialog section.Gerald Combs7-9/+48
Add a section for the Packet Lengths window. Use title case for the column headers. Fix a button name and other issues elsewhere. Change-Id: I339d56aa169158e0788acd02a897729205e9f50e Reviewed-on: https://code.wireshark.org/review/35615 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03WSDG: Miscellaneous updates.Gerald Combs3-22/+21
Add a note about case sensitive directories on Windows. Recommend the "winflexbison3" Chocolatey package. Update our list of Linux distributions. Change-Id: I4676453941a66de71215d6ce6cf7057623c92fec Reviewed-on: https://code.wireshark.org/review/35622 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03packet-iec104: Use pinfo->match_uint instead of port number from configurationJiří Engelthaler1-14/+2
Dissector port number is used to determine the direction. It will not work with Decode As when port number from the configuration is used. It is better to use the actual dissector port from pinfo->match_uint. Change-Id: I156728a66ed0cf0fe536da8d9ae958c8c4e0b361 Reviewed-on: https://code.wireshark.org/review/35632 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-03Qt: Add Spanish (es) translation assets.Gerald Combs6-0/+17078
Add an initial "es" Qt translation file and an accompanying flag image. The image came from https://en.wikipedia.org/wiki/File:Flag_of_Spain.svg and is in the public domain. (We already had a debian/po/es.po.) Change-Id: I5378ad2cbffb2267389fc8ae6af6d591071e0144 Reviewed-on: https://code.wireshark.org/review/35620 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-03GSM RLC/MAC: dissect Mobile Identity in Packet Paging RequestVadim Yanitskiy1-9/+18
Before this patch, Mobile Identity was displayed as an array: PACKET_PAGING_REQUEST (34) (downlink) 1000 10.. = MESSAGE_TYPE (DL): PACKET_PAGING_REQUEST (34) .... ..00 = PAGE_MODE: Normal Paging (0) 0... .... = Exist_PERSISTENCE_LEVEL: 0 .0.. .... = Exist_NLN: 0 ..1. .... = Repeated_Page_info Exist: 1 Repeated_Page_info ...1 .... = Repeated_Page_info: (Union) u.Page_req_RR .... 1... = Page_request_for_RR_conn: (Union) u.Mobile_Identity .... .100 0... .... = Length_of_Mobile_Identity_contents: 8 .001 0100 1... .... = Mobile_Identity_contents: 41 .001 0011 0... .... = Mobile_Identity_contents: 38 .001 0010 0... .... = Mobile_Identity_contents: 36 .000 0000 0... .... = Mobile_Identity_contents: 0 .000 0000 0... .... = Mobile_Identity_contents: 0 .000 0000 0... .... = Mobile_Identity_contents: 0 .000 0000 0... .... = Mobile_Identity_contents: 0 .001 0010 0... .... = Mobile_Identity_contents: 36 .00. .... = CHANNEL_NEEDED: 0 ...0 .... = Exist_eMLPP_PRIORITY: 0 after this patch: u.Mobile_Identity .... .100 0... .... = Length_of_Mobile_Identity_contents: 8 0010 .... = Identity Digit 1: 2 .... 1... = Odd/even indication: Odd number of identity digits .... .001 = Mobile Identity Type: IMSI (1) IMSI: 262420000000042 [Association IMSI: 262420000000042] Mobile Country Code (MCC): Germany (262) Mobile Network Code (MNC): Vodafone GmbH (42) .00. .... = CHANNEL_NEEDED: 0 ...0 .... = Exist_eMLPP_PRIORITY: 0 Achieved by calling de_mid() on an octet-aligned buffer. Change-Id: Ia77e388f9ac18e4ecda27eeb3e04ce1bd978a3a5 Reviewed-on: https://code.wireshark.org/review/35625 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-02make-manuf.py: Add "of" to the general terms list.Gerald Combs1-0/+1
Add "of" to the list of general terms to remove when shortening. Change-Id: Idbfea2d502a89d668ba2f170bf3450cfcbb91fe5 Reviewed-on: https://code.wireshark.org/review/35627 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-02BER: fix ber.error.bits_unknown displayPascal Quantin1-10/+19
Before the changes done in v3.1.0rc0-431-gc2ac157ac0 and v3.1.0rc0-458-g37b91eedd6 the expert info was only displayed if at least 1 unknown bit was set to 1. Restore this behavior. Bug: 16301 Change-Id: I3bea0992d6727154ef07d40ac18a7b012d3c1da4 Reviewed-on: https://code.wireshark.org/review/35612 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-02BGP: Support for drafts Tunnel Encapsulation and Segment RoutingUli Heilmeier1-27/+551
Add support for BGP Tunnel Encapsulation Attribute (draft-ietf-idr-tunnel-encaps-15) and Advertising Segment Routing Policies in BGP (draft-ietf-idr-segment-routing-te-policy-08). Due to missing pcap file(s) most of the Segment List Sub-TLVs are still missing. Bug: 16294 Change-Id: I0d7524934d5c5f2458a3f9a68e1e49c95a030c32 Reviewed-on: https://code.wireshark.org/review/35587 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-01Happy New Year 2020Stig Bjørlykke2-3/+3
Change-Id: Ic569e499d40def9397203510a121ff17a495ba9a Reviewed-on: https://code.wireshark.org/review/35616 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-12-31WSUG: Update the Capture Properties dialog section.Gerald Combs4-35/+64
Change-Id: Ib7ee22076c63fc1be339d4c1b586b73490a3a950 Reviewed-on: https://code.wireshark.org/review/35541 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-31HTTP: Fix dissection of data following the HTTP Upgrade responsePeter Wu1-0/+7
When a HTTP response includes HTTP headers and a subset of data for the subdissector in the same frame, be sure to skip the HTTP headers for reassembly of the latter data. Otherwise the HTTP headers will be misinterpreted as the subprotocol (for example, WebSocket). Bug: 16274 Change-Id: Ida6f6f2f7d0c463be2d498bfde5e8a9cd11a4b25 Reviewed-on: https://code.wireshark.org/review/35536 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-12-31LPP: upgrade dissector to 37.355 v15.0.0Pascal Quantin6-8/+8
3GPP decided to transfer the specification from 36.355 to 37.355 now that it covers NR also. 37.355 v15.0.0 is equivalent to 36.355 v15.5.0. Change-Id: I63aba21f55861ffd8a5c0adbd307b0453482baaa Reviewed-on: https://code.wireshark.org/review/35613 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-30Guides: Update some of the MaxMind text.Gerald Combs2-8/+6
Update the User's Guide to match MaxMind's upcoming database access changes: https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/ Add a Win64 link to the Developer's Guide. Change-Id: Iaaaaedeb81616f026c542c6f2d8559a3a0084f95 Reviewed-on: https://code.wireshark.org/review/35610 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>