aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-03-30ws_load_library() is called with constant char reflect that.MSVC15 build.AndersBroman2-2/+2
Change-Id: I7d103c7316ee372b5cdb3aa9033a62eb75cd38b2 Reviewed-on: https://code.wireshark.org/review/14702 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-30Add support for National Language tables in GSM UDIgnacio Martínez1-1/+79
Change-Id: Idc375b468754ac1287401ebfb88f77a40f747a79 Reviewed-on: https://code.wireshark.org/review/14698 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-30Remove not needed initialisation breaking MSVC 15 nmake build.AndersBroman1-1/+0
Change-Id: Ia486209a8eef5bf02b5b3f6d793698c4cc802dc9 Reviewed-on: https://code.wireshark.org/review/14699 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-30make-taps.pl: Fix generated code indentationJoão Valverde1-8/+11
Change-Id: Ife25c519acb56b58819bc1aabfa069b5fbbc788d Reviewed-on: https://code.wireshark.org/review/14676 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-29[Exported PDU] Add the abillity to use dissector tables from the file.AndersBroman2-20/+84
Change-Id: I51ac8ce56641cf6eeda18c2a3f6d6952d3126415 Reviewed-on: https://code.wireshark.org/review/14693 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-29TCP: Remove double semicolonAlexis La Goutte1-1/+1
Change-Id: I77f96cfee089b8e6a26504279c7a6cd4b6e36a5c Reviewed-on: https://code.wireshark.org/review/14696 Reviewed-by: Matthieu Coudron <matthieu.coudron@lip6.fr> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-03-29EPL: Fix segmented transfer complete detectionChristoph Schlosser1-53/+96
In case of a segmented SDO transfer, the transfer complete response can contain additional data that should not be evaluated by the dissector. Change-Id: I7016eb88b93aac8c318e703fe60a90c3adbf9eeb Reviewed-on: https://code.wireshark.org/review/14692 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-03-29Remove an unused variable from both the Gtk and Qt UIs.Jeff Morriss2-18/+2
Change-Id: I4c7c5aeaa1fa452605cf02a5c86dfe161c451f65 Reviewed-on: https://code.wireshark.org/review/14654 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-03-29Update min. GLib version and add Qt version checksJaap Keuter1-5/+5
The document describes why and how to version check, but 1) is not up to date with respect to minimum GLib version 2) does not yet mention Qt version requirement and check. This change addresses both issues. Change-Id: Ibb56c02cf48f6a4c6270b20686ca4d6e8aaf99d1 Reviewed-on: https://code.wireshark.org/review/14669 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-03-29Use "old-style" moc options to ensure backward compatibility for Qt toolsJoão Valverde2-3/+6
Change-Id: Ic96df4ba521e0fbaf4ac34f23e3a89304ed5de5c Reviewed-on: https://code.wireshark.org/review/14662 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-29Add GLib version info to configure status messageJoão Valverde1-1/+2
Change-Id: I279996e6713cad809a9487a83dc9692e7673f604 Reviewed-on: https://code.wireshark.org/review/14663 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-29configure.ac: Fix bogus variable nameJoão Valverde1-4/+4
Change-Id: Iaca06400a337340b679f4b017103f28af7155535 Reviewed-on: https://code.wireshark.org/review/14684 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-29configure: fix cache var handlingMike Frysinger1-16/+15
Need to use the AC_CACHE_CHECK macro in order for the cache vars to be loaded+checked, otherwise the vars here are just plain variables. This also allows people to control the various tests when cross-compiling. Bug: 9912 Change-Id: I119eb87807098c84520954dd34cbd0ddd1b6ccb0 Reviewed-on: https://code.wireshark.org/review/14683 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-29Fix modeline definitionsPeter Wu3-6/+6
Fix mismatching emacs and vi modelines. Change-Id: I5cab8c5b7692746a5fa731c977cef903ad19a6f6 Reviewed-on: https://code.wireshark.org/review/14688 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-03-29GSM CBCH: fix an out of bounds accessPascal Quantin1-6/+6
As explained by Guy, we should use new_slots[i] and not new_slots[k] Bug: 12278 Change-Id: Ifae44f9d5948bed5c4ee0442510724016e307dee Reviewed-on: https://code.wireshark.org/review/14678 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-29Another round of extcap memleak fixesPeter Wu5-66/+97
Fix a bunch of memory leaks, mainly because extcap_base_cleanup is not called on most execution paths and because memory allocated for options were not freed. Additionally, randpkt will now fail if no option is given (it previously returned 0 if --capture was missing). Logic using "goto" is introduced with the idea that a program should fail (ret = EXIT_FAILURE) unless proven otherwise. Now none of the extcap programs are leaking: for what in ssh cisco; do for arg in '' --help --extcap-interfaces --extcap-interface=$what; do extcap/${what}dump $arg; done; done ./tshark -D Change-Id: I6df1027ed0c32bd53fe87e6c54d355bc8ddd01f5 Reviewed-on: https://code.wireshark.org/review/14671 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-03-29Assorted cleanups.Guy Harris1-17/+29
1) Handle the ASCII and Unicode magic numbers the same way - as static const char arrays. Note that Unicode specifically means little-endian UCS-2 (or UTF-16, but they probably use few if any characters outside of ASCII, much less the Basic Multilingual Plane). 2) Treat all seek errors as open errors rather than "not my file type". 3) Fix capitalization of "Unicode". Change-Id: I47b7e057ccada00347499a6b17f8f8fc44e7c503 Reviewed-on: https://code.wireshark.org/review/14689 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-28Trun on -Wused-but-marked-unused but only as warning, never as error.Joerg Mayer1-0/+3
(possibly clang only) Change-Id: I014b8f069515af6128177dfc5813380db445957c Reviewed-on: https://code.wireshark.org/review/14686 Petri-Dish: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix out-of-tree "gen-authors" targetPeter Wu3-11/+10
Change directory to the source tree before invoking `git shortlog`, otherwise it fails on build directories outside the source tree. Alexis suggested to move the git invocation to the perl script, this is done now and also avoids writing AUTHORS.git in the source tree. Change-Id: I5905ebf40d8d32a586c88671b52f28c542ca33ba Reviewed-on: https://code.wireshark.org/review/14660 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-03-28Fix -Wused-but-marked-unused warning/errorJoerg Mayer1-1/+6
Change-Id: I9e0a6766aa443907505889e392ea9a7d6c07b94b Reviewed-on: https://code.wireshark.org/review/14685 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix more -Wused-but-marked-unused warnings/errors.Joerg Mayer26-138/+138
Change-Id: Ieb3e70a23c1a55b7ba60b1b32f159341adfe65b7 Reviewed-on: https://code.wireshark.org/review/14682 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28configure: fix non-POSIX testMike Frysinger1-1/+1
The == operator is not in POSIX -- it's an extension some shells support. Change-Id: Idb2be90307de783b4220cc7d91222b462c98dee4 Reviewed-on: https://code.wireshark.org/review/14680 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-28wslua: handle parameters with const keyword when generating tapsPascal Quantin1-0/+2
Change-Id: I46148b6454a501035d86fa8f1eb767687f68aa42 Reviewed-on: https://code.wireshark.org/review/14670 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-28Qt: Make conversation menu items static.Gerald Combs14-105/+323
Add a ConversationAction and ColorizeAction classes which respectively handle conversation filtering and colorization. Move conversation menu initialization to initConversationMenus and call it once at startup. This keeps us from leaking quite a bit of memory each time we select a packet or proto tree item. Bug: 12044 Change-Id: I32e8cedaba08a419d5da6a7a9db31c910909f450 Reviewed-on: https://code.wireshark.org/review/14516 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-03-28Fix warnings/errors of type -Wused-but-marked-unusedJoerg Mayer15-24/+34
Change-Id: I34c2d9953272822da0745d1b24c64d8466e43b37 Reviewed-on: https://code.wireshark.org/review/14668 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix some warnings/errors of typeJoerg Mayer25-179/+143
git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used [-Werror,-Wused-but-marked-unused] proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown")); ^ Added manual change id because file-jpeg.c forced the use of commit -n Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb Fix warnings/errors of type: git/epan/dissectors/packet-ax25-kiss.c:205:52: error: 'pseudo_header' was marked unused but was used [-Werror,-Wused-but-marked-unused] return capture_ax25( pd, l_offset, len, cpinfo, pseudo_header ); Fix checkhf warnings: Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_netswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_subswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_poll_reply_trailer Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_rdm_universe Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_tod_data_universe Change-Id: Id1fa12afb97a8e9cd4ed0ea25351c3b2639c930e Reviewed-on: https://code.wireshark.org/review/14667 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix some warnings/errors of typeJoerg Mayer12-14/+38
git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used [-Werror,-Wused-but-marked-unused] proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown")); ^ Added manual change id because file-jpeg.c forced the use of commit -n Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb Reviewed-on: https://code.wireshark.org/review/14666 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28NAS EPS: add a missing breakPascal Quantin1-0/+1
Change-Id: I71a32b831cdb8d7d07e48cabe2c6cd7204968c28 Reviewed-on: https://code.wireshark.org/review/14665 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-28[docsis->mdd] Add support for TLV 1.7Adrian Simionov1-1/+67
Change-Id: I9e67ccee06c93c25c766fae8bdd8a9890416655f Reviewed-on: https://code.wireshark.org/review/14648 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-28tools/generate_authors.pl: avoid duplicatesPeter Wu3-18/+9
Officially, the local part of an email address is case sensitive, but in practice this is ignored. Ensure that duplicate email addresses are not listed. While at it, detect duplicates using `grep -Po '<\K[^>]+' AUTHORS | tr '[:upper:]' '[:lower:]' | sort | uniq -cd` and resolve them. Change-Id: Ie1e853d6253758c8454d9583f0a11f317c8390cb Reviewed-on: https://code.wireshark.org/review/14659 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-27NAS EPS: upgrade dissector to v13.5.0Pascal Quantin1-13/+334
Change-Id: I04319c1ca0a6c166904a584f31088460ea35eb89 Reviewed-on: https://code.wireshark.org/review/14655 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-27If setting an address from a tvb and the address length is 0, the address ↵Michael Mann1-1/+4
should be NULL. Bug: 12295 Change-Id: I875308a16b11023a691d34057c7f8561a15aa598 Reviewed-on: https://code.wireshark.org/review/14649 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-27NGHTTP2: Update to 1.8.0Alexis La Goutte5-37/+596
Change-Id: Ic818b7df95c9812076303f613b0641b9e702b62e Reviewed-on: https://code.wireshark.org/review/14562 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-27Treat Gammu DCT3 trace files as having magic numbers.Guy Harris1-1/+2
Otherwise, they get treated as generic XML files. No, a standard XML tag, followed by <dump>, isn't a *perfect* magic number, but if you *really* want to read it as a generic XML file, you can do so from the UI. (This is just like TNEF files.) Change-Id: I7624023ecf87a21ef339222c89b3c9abd7acc727 Reviewed-on: https://code.wireshark.org/review/14656 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-27[Automatic update for 2016-03-27]Gerald Combs14-937/+1422
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I19f4ffca89acbd207cafe1f29f14aba293b068f4 Reviewed-on: https://code.wireshark.org/review/14650 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-03-27Add dissector table for negotiated WebSocket protocolGregor Jasny3-3/+20
This adds the possibility to filter on the negotiated WebSocket protocol from the upgrade response as well as on a specific TCP port Bug: 12298 Change-Id: I8e0b785cec0b8c71ec558b74ac07c81194268b38 Signed-off-by: Gregor Jasny <gjasny@googlemail.com> Reviewed-on: https://code.wireshark.org/review/14645 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-27Pull the invocation of the Lex scanner into common code.Guy Harris4-25/+9
Instead of text_import_setup() and text_import_cleanup() routines, and the actual scanner invocation being done in the dialog box, have a text_import() routine that does all the work. Change-Id: Ifd8a999618dbb411d613e6596484e4c2e013431d Reviewed-on: https://code.wireshark.org/review/14647 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-27Make failure_alert_box() be printf-like.Guy Harris6-9/+20
Have it be printf-like, and have vfailure_alert_box() be vprintf-like. Rename a few variables to make it clearer what pointers point to vprintf-like functions. Change-Id: I960e2138a18edcc742c450d68a0c6f7248f50c3f Reviewed-on: https://code.wireshark.org/review/14646 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-26Make sure conversation exists (CID-280536)Jaap Keuter1-0/+2
The code sets up a conversation, then proceeds getting it and using it. It must be there, so assert that it is before dereferencing it. Change-Id: I5384b9b773a5f4e86f649612ee4f4929a503c523 Reviewed-on: https://code.wireshark.org/review/14641 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-26ethercat: Fix Control flow issues MISSING_BREAK (CID 1357204)Alexis La Goutte1-0/+1
Change-Id: I7efc9b4b44590e3408ba058d7aa02f843cbfeca4 Reviewed-on: https://code.wireshark.org/review/14642 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-26Improves MPTCP analysisMatthieu Coudron3-61/+466
Adds options that control depth of MPTCP analysis, notably: - if mptcp_relative_seq is enabled, can display relative MPTCP sequence numbers - if mapping analysis is allowed, can tell in which packets the DSS mappings covering this data was sent - if intersubflow checks are enabled, it can check for retransmissions over other subflows Change-Id: I82b934513c9f16affb60c066a1fbcca234ffc999 Reviewed-on: https://code.wireshark.org/review/12316 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26bootp: Add support for iSNS (RFC4174) dissectionVictor Dodon3-1/+373
Change-Id: I2d1807e631991d4115ca33d351e85c36272c209b Reviewed-on: https://code.wireshark.org/review/14523 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26ASTERIX: Add CAT025 dissectionAndrew Hoag1-1/+245
The CAT025 type of ASTERIX messages is "CNS/ATM Ground System Status Report". Change-Id: Icf39d595cef8663357a487b799bf32e738236757 Reviewed-on: https://code.wireshark.org/review/14590 Tested-by: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26PTP: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I277c0e6f0f257dfb84bfb778c221c519204907d4 Reviewed-on: https://code.wireshark.org/review/14643 Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26Fix compile errors when compiling w/o zlibDaniël van Eeden5-5/+5
Change-Id: I443cd0d4a143e456e11b5939891312a0501770a0 Reviewed-on: https://code.wireshark.org/review/14636 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26MySQL: Fix query string in info columnDaniël van Eeden1-1/+1
Change-Id: I2d0aae95c41f527c4a1e0327bf6c3950204458e1 Reviewed-on: https://code.wireshark.org/review/14637 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26Make sure there's enough data in the header for a FMTP packet.Michael Mann1-2/+7
Bug: 12285 Change-Id: I103dff37b34f922ac5c3071c49b7dfe55b059717 Reviewed-on: https://code.wireshark.org/review/14634 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-26Fix typo in README.cmakeDaniël van Eeden1-1/+1
Change-Id: I2bbb589c5a0c5cbab9fd6f0623682e119bbfd46a Reviewed-on: https://code.wireshark.org/review/14635 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-26Push initial directory code up into CaptureFileDialog.Jeff Morriss3-87/+26
That way each (CaptureFileDialog) user doesn't have to (remember to) check the preference, etc., to figure out what directory to start in. Change-Id: Ifa60e1ef9dbd11689a3f72906997cf3ed8ce259c Reviewed-on: https://code.wireshark.org/review/14550 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26Choose the appropriate initial directory for the Export Dissections window.Jeff Morriss1-2/+26
Bug: 12105 Change-Id: Ib2398e5213b2ef2501660d1bba13dca66f04bd55 Reviewed-on: https://code.wireshark.org/review/14549 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>