aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-12-29ISAKMP: add Reserved fields for Fibre ChannelMirko Parthey1-3/+11
Add Reserved fields for Fibre Channel Traffic Selectors. Reference: RFC 4595, section 4.4 Change-Id: Iba0b3d9a4d3d96918971a9a597fa313b022b5ca2 Reviewed-on: https://code.wireshark.org/review/19444 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28CMake,autotools: enable -Werror=implicit by defaultPeter Wu3-4/+19
The -Wimplicit error covers two warnings, trying to catch these cases: Setting a global variable without declaring its type (-Wimplicit-int): undeclared_type = 1; More importantly, -Wimplicit-function-declaration catches the case where a function is not declared (missing header, programming error, etc.). Turn these warnings into errors, most likely it will be a programming error that results in a link failure anyway. See also https://fedoraproject.org/wiki/Changes/Fedora26CFlags Also fix autotools checks not to trigger -Wimplicit-int and -Wimplicit-function-declaration (in krb5 check due to missing include). Tested on Ubuntu 16.04 (autotools & cmake) and Arch Linux (cmake), configure/cmake output and config.h are identical. Change-Id: I137284263f3b1223df6e6a893111c3640802631f Reviewed-on: https://code.wireshark.org/review/19331 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-12-28Qt: Remove "Extcap" from window title.Stig Bjørlykke1-2/+2
An average user does not need to know that an interface is of type extcap. Remove "Extcap" from the "Extcap Interface Options" dialog. Change-Id: Iafadf2d312a4ffd5530deeac63194151571fc7d3 Reviewed-on: https://code.wireshark.org/review/19443 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-12-28Qt: Fix open extcap help URL.Stig Bjørlykke1-1/+3
The return value from QString::compare() is equal to zero when the strings are equal. Fix the code for checking and opening the extcap help URL if not matching "file". This bug was introduced in g46caff30. Ping-Bug: 13218 Change-Id: I2a84e61f0191b57269f8ce829ff82200bf19a7ac Reviewed-on: https://code.wireshark.org/review/19442 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-12-28Infiniband: Use base of packet tree (top_tree) for ↵Michael Mann1-23/+24
"infiniband.mad.cm.private" heuristic dissector. The "infiniband.payload" heuristic dissector was converted to use the base of the packet tree so that subdissectors could show their protocol as the base layer. Since many of the subdissectors use the same dissection function for both "infiniband.payload" and "infiniband.mad.cm.private", ensure that both use the same "tree level", but still pass in the "payload tree" as part of the dissector data in case a subdissector wants to use it (currently used by InfinibandSDP) Ping-Bug: 13259 Change-Id: I899e8348f6b23d8eee9e74764d8ca32d7bf6e625 Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19441 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Parav Pandit <paravpandit@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28ISAKMP: add traffic selector subtreeMirko Parthey1-105/+100
Create a new subtree for each traffic selector. Use the length field to find the next traffic selector rather than accumulating the individual TS field sizes. Split dissect_ts() to introduce separate offset variables. After adding the final field, do not advance offset again to avoid unused variable warnings. Change-Id: I9951662c1bb3958994162b25b70b43ec1da103a7 Reviewed-on: https://code.wireshark.org/review/19440 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28macosx: Update Read me first.rtf with some additional install/deinstall notesJim Young1-6/+20
Report that files /etc/paths.d/Wireshark and /etc/manpaths.d/Wireshark are added and should be removed. Change-Id: I2f9d3aea0dd4f86cb9a86065108a3948e28d3001 Reviewed-on: https://code.wireshark.org/review/19436 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28Added basic support for NVM Express over Fabrics for RDMA.Parav Pandit6-0/+1717
NVM Express is high speed interface for accessing solid state drives. NVM Express specifications are maintained by NVM Express industry association at http://www.nvmexpress.org. Bug: 13201 Change-Id: Id40edaf72838eea9f4087c8ddba9518a9374efab Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19063 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Parav Pandit <paravpandit@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-27Move DigestInfo from pkcs12 to cmsРоман Донченко6-50/+42
This type is originally from PKCS #7, the predecessor of CMS, so it makes more sense for it to be there. Change-Id: I3a146f1d000a3bcbcd0d8f1cfe2fc27ed80cc69d Reviewed-on: https://code.wireshark.org/review/19335 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-27InterfaceList: Add check for remote interfaceRoland Knall8-0/+120
Add a check, to allow the filtering of remote only interfaces. Also add the necessary options to the type menu. Change-Id: Ib82519362454094f64abf1cbe6d7bc917990d7ac Reviewed-on: https://code.wireshark.org/review/19438 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-27Replace assignment with structure assignment (CID 1397183)Jaap Keuter1-2/+1
Replace the individual field assignment with struct assignement to - Reduce code (only single line, but he), - (Hopefully) show Coverity this is as intended. Change-Id: I9400b6e38f86acf57018ee7993e66d5b06d1c39c Reviewed-on: https://code.wireshark.org/review/19434 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-27Merge AIM files into single dissector file.Michael Mann26-4806/+3100
These are probably obsolete dissectors anyway, but they are a bunch of very small files causing unnecessary file pollution. Change-Id: I03976484996b4bf987d6743ed379534456809c2c Reviewed-on: https://code.wireshark.org/review/19437 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-26zvt: dissect the TLV container's payloadMartin Kaiser1-26/+121
add a function to dissect the sequence of TLV elements use a hash table for payload functions like we do for the bitmaps add two tags whose payload is another TLV sequence Change-Id: Ibb19fd7af2f58e201174d07d410557dc315c652a Reviewed-on: https://code.wireshark.org/review/19435 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-26Don't claim packet as MATE if there is no MATE configurationMichael Mann1-1/+6
This prevents MATE from (falsely) being included in the list of protocols for any given frame. Change-Id: I9ffdfb52cf31dfda89b674a41bcc0992e17de5e8 Reviewed-on: https://code.wireshark.org/review/19432 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25[Automatic update for 2016-12-25]Gerald Combs12-1388/+1896
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I8fd8115fdfd4623bdf94602b6fd55a724e09cec3 Reviewed-on: https://code.wireshark.org/review/19429 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-25Remove individual post-dissect enable preferences.Michael Mann3-48/+23
Use Analyze -> Enabled Protocol dialog interface. Added support for backwards compatibility of preference. Change-Id: I32b3fce9d18083d9324197e3fd7ddc7eb888d1fb Reviewed-on: https://code.wireshark.org/review/19422 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25DVB-CI: simplify dissection of the resource idMartin Kaiser1-22/+11
Now that proto_tree_add_bitmask_value_with_flags() works for tvb==NULL, we can use it to simplify the dissection of DVB-CI's resource id. Change-Id: Ia09d5668bf0a61161ecd0cb412680838a67d7a7a Reviewed-on: https://code.wireshark.org/review/19409 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Wireshark doesn't require X11 any more.Guy Harris1-1/+1
Change-Id: Ib5ba38e5103f31f115608b92dd32f3ce1e5eec67 Reviewed-on: https://code.wireshark.org/review/19424 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-25Fix some narrowing warnings.Guy Harris1-3/+3
Don't narrow values until it's necessary, and then put in explicit casts to indicate that the narrowing is intentional. Change-Id: I8afc2a457822febbed33cee573953993013a7185 Reviewed-on: https://code.wireshark.org/review/19423 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-25packetbb: Add decoding for TLV with single valueFrancois Schneider1-49/+327
Bug: 4118 Change-Id: I282fb8da657701c5b855dafe1568a5f226d3c12b Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-on: https://code.wireshark.org/review/13985 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25rtp_analysis_dialog (Qt): Fix Dead Store (Dead assignement/Dead increment) ↵Alexis La Goutte1-1/+0
Warning found by Clang Change-Id: I48dd8af83c97301b6bd314801ca36ac13c790eaa Reviewed-on: https://code.wireshark.org/review/19413 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Cleanup transum post-dissector.Michael Mann6-665/+546
1. Enable/disable preference not needed - just use Enabled Protocol dialog interface. Added support for backwards compatibility of preference. 2. Add value_string for calculation values 3. Create an structured array of "hfs of interest" so they can more easily be extended. 4. Convert a bunch of arrays into hash tables and lists. For the amount of wasted space they were taking up, we can live with the very slight performance degrade. Also puts less limits on number of things to process. Change-Id: I7399789d62432b507062ed9cdc20ad974b9dde1b Reviewed-on: https://code.wireshark.org/review/19406 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Support all MA modes, fix BB CRC and frag edge casesMustBeArt1-85/+175
Support all four mode adaptation interface formats. Add a user preference to specify which format is in use, or to request that the format be guessed. Guessing is improved, but can never be reliable. Fix problem with baseband header CRC check that caused almost all packets to show a spurious CRC error, introduced with proto_tree_add_checksum. Fix problem with GSE PDU fragmentation CRC beginning in one fragment and ending in another. Any GSE frames following the fragment containing the end of the CRC would be parsed at the wrong offset. Fix problem with IPv4 or IPv6 starting exactly on a fragmentation boundary, so that one baseband frame contains the complete GSE header but zero bytes of the IP payload. Trying to further dissect the zero-length payload led to a "malformed packet" display. Standardize spelling per governing document: adaption -> adaptation Change-Id: I69e64e74e4b4f02515411471e1d76b0eeb02fef1 Reviewed-on: https://code.wireshark.org/review/19421 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Avoid recursive scan_local_interfaces operationMikael Kanstrup1-0/+11
When the local networks interfaces changes quickly or when refreshing the list of network interfaces there's a risk of recursive calls into scan_local_interfaces. The recursive calls are a result of calling update_cb to process UI events during function operation which in turn again discover a network interface change. This results in strange duplicate entries of network interfaces and crashes. To avoid recursive calls a check is added to stop running the function while already updating. This patch is really just a workaround for the problem. Ideally some asynchronous operation should be implemented instead to avoid the UI update_cb callback alltogether. Bug: 11553 Bug: 12263 Change-Id: I3b74d8f196677e0e261a395aff558dd9f685b538 Reviewed-on: https://code.wireshark.org/review/14492 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25udpdump: remove libwireshark dependancy.Dario Lombardo3-35/+97
Export pdu routines have been rewritten here on purpose. Change-Id: If4879de4c98b6f20a75df158cae0cf9a80ffae57 Reviewed-on: https://code.wireshark.org/review/19384 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25802.11(ad): split Sector Sweep Feedback in 2Alexis La Goutte1-3/+51
one from ISS and other to ISS Add also reserved field Issue reported by Hany ASSASA Bug:13244 Change-Id: Ib20cf6ae455664b87ea3470ebb6d5386a97b0f48 Reviewed-on: https://code.wireshark.org/review/19420 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25802.11(ad): fix typoAlexis La Goutte1-1/+1
Acknoledgment => Acknowledgment Ping-Bug: 13244 Change-Id: Ia2e8eedec05c39ed0ebc38235cc52d43488e00d4 Reviewed-on: https://code.wireshark.org/review/19419 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25802.11(ad): Enhance dissection of Beam RefinementAlexis La Goutte1-57/+50
You can now use bitmap on 64bits (or 40bits) and also add a reserved field Change-Id: Ibc68b56477e76c2b13624920eb7a9a49f8f887f3 Ping-Bug: 13244 Reviewed-on: https://code.wireshark.org/review/19418 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25802.11(ad): Add reserved field for BRP RequestAlexis La Goutte1-0/+7
Change-Id: Iee6012e841007b731dc16545a1d9bf6f17377580 Ping-Bug: 13244 Reviewed-on: https://code.wireshark.org/review/19417 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25802.11(ad): fix wrong bitmask for BRP TX AntennaAlexis La Goutte1-1/+1
Missing a zero Change-Id: I43097bc62fb66dea849c5ed7882d01a6de768c82 Ping-Bug: 13244 Reviewed-on: https://code.wireshark.org/review/19416 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-24Lemon: resync with upstreamAlexis La Goutte2-209/+495
lemon: Tue Aug 16 16:46:40 2016 lempar: Tue Dec 6 17:59:05 2016 +0000 a copy of all Wireshark changes are available https://github.com/alagoutte/sqlite/tree/wireshark Change-Id: I144d0f983e4ac960b5a7a2fd8cd379f6282579f8 Reviewed-on: https://code.wireshark.org/review/15987 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-24AFP: fix indent (use tabs)Alexis La Goutte1-159/+159
Change-Id: I3d1078ddff6ec7b9c7efc5cda9a1821ef52b46ce Reviewed-on: https://code.wireshark.org/review/19415 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-24ppi-vector: Fix Dead Store (Dead assignement/Dead increment) Warning found ↵Alexis La Goutte1-1/+1
by Clang Change-Id: I44ae8a9cc6b09ad205b9c90e7d9595768fcac71b Reviewed-on: https://code.wireshark.org/review/19412 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-24bthci_evt: Fix Dead Store (Dead assignement/Dead increment) Warning found by ↵Alexis La Goutte1-4/+4
Clang Change-Id: Ic9962a1824b9f9d137177c81cb15d7ef4bc7bfc2 Reviewed-on: https://code.wireshark.org/review/19411 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-24disabled_protos: fix no previous prototype for function 'read_protos_list' ↵Alexis La Goutte1-1/+1
[-Wmissing-prototypes] Change-Id: I5bfa11213ca27308204a1d8b6073661161c9151e Reviewed-on: https://code.wireshark.org/review/19414 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-24extcap_options_dialog: fix compilation with Qt4Martin Kaiser1-1/+2
Qt4's QFileInfo::exist() can only be used with an existing QFileInfo object. The version that accepts the file name as paramter was introduced in Qt5. Create a temporary QFileInfo object and call exists() on this object. Change-Id: I162cc22ecba61b2c2f16f9f0916b0db7969abb51 Reviewed-on: https://code.wireshark.org/review/19408 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-12-24zvt: len is used in dissect_zvt_int_status()Martin Kaiser1-1/+1
Change-Id: I8937dc605abf0414159acfc75ee05ccac89658fb Reviewed-on: https://code.wireshark.org/review/19410 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-24[TRANSUM] smb2.msg_id is now a FT_UINT64.Michael Mann1-1/+1
Per bug 12915, SMB2 message ID should be treated as a unsigned 64bit value. Have transum logic match that as it was assuming SMB2 message ID was a signed 64bit value Change-Id: Ide0c12b505d1eef2aeb89d165a3ea59058e6be34 Reviewed-on: https://code.wireshark.org/review/19407 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-24Add enabled protocol list for dissectors who are disabled by defaultMichael Mann17-196/+448
We save a list of dissectors that are disabled through the Enabled Protocols dialog. This is because we assume dissectors are enabled by default. For dissectors that are disabled by default, we have no way to keep them enabled through the Enabled Protocols dialog. A dissector that defaults to being disabled has to be reset to enabled each time Wireshark is launched. Add a list similar to the disabled list for enabling dissectors that are disabled by default. This mostly applies to post-dissectors. Change-Id: I31a8d97a9fdbc472fe2a8666384e0f8786bb8e9f Reviewed-on: https://code.wireshark.org/review/19405 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-23Set BCP BPDU to size of bytes used by the protocol, not whole packet.Michael Mann1-0/+2
Bug: 13188 Change-Id: I29b2712d4d6ae57e4b0ea4bc0ec126cb80172779 Reviewed-on: https://code.wireshark.org/review/19400 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-23bthci_cmd: Fix Dead Store (Dead assignement/Dead increment) Warning found by ↵Alexis La Goutte1-1/+1
Clang Change-Id: I84472632e715a6f13e2fa5b58ae95f9dc9d16776 Reviewed-on: https://code.wireshark.org/review/19399 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-23make proto_tree_add_bitmask_value_with_flags() work for tvb==NULLMartin Kaiser1-1/+3
proto_tree_add_bitmask_value_with_flags() eventually calls proto_tree_add_XXX() for the main hf and for the field elements. These functions work for tvb==NULL if the length is also set to 0. Otherwise, we'll end up in proto_tree_add_pi(), get_hfi_length() and run into the DISSECTOR_ASSERT() there. proto_tree_add_bitmask_value...() are meant for cases where the data is passed directly and not read from a tvb. If tvb==NULL, set our length to 0 instead of using the field length from the main hf. Change-Id: Ia55b068e9842ba4a1ae8be8692320a8e93ea8631 Reviewed-on: https://code.wireshark.org/review/19394 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-23Qt: add local file existence check for extcap help.Dario Lombardo1-8/+21
The extcap help pages point to local manpages. Check the existence of local file before attempting to open them, and if it fails, give the user an error. Ping-Bug: 13218 Change-Id: I0e0ff1e66e439d3ff8c992dbb42652782c047bb5 Reviewed-on: https://code.wireshark.org/review/19180 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-23Make sure we know that a RNG_RSP_DL_FREQ_OVERRIDE item is present.Guy Harris1-1/+4
Set a variable that we were supposed to be setting. Also, note some items that should probably be expert info items instead of, or in addition to, additional text at the end of protocol tree items. Addresses CID 1397702. Change-Id: I2ff0c2549f229546035964efa6af19b77646f7d2 Reviewed-on: https://code.wireshark.org/review/19397 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-23DVB-CI: don't call proto_tree_add_subtree_format() with tvb==NULLMartin Kaiser1-4/+10
When I first implemented this, proto_tree_add_subtree_format() worked for tvb==NULL if len was also 0. The bounds check added in 56706427f53cc64793870bf072c2c06248ae88f3 breaks this use case and makes DVB-CI spill out dissector asserts. Warn Dissector bug, protocol DVB-CI, in packet 625: ../epan/tvbuff.c:532: failed assertion "tvb && tvb->initialized" Create a proto_item first and link the subtree to this item. This will work as long as proto_tree_add_uint() accepts tvb==NULL. Thanks to Kay Katzorke for reporting this bug. Change-Id: I25a071c21925f7d362c92852fd5a8136e4d361c8 Reviewed-on: https://code.wireshark.org/review/19389 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-23GSM A GM: align protocol / container id filter format with displayed onePascal Quantin1-1/+1
Change-Id: If5dcee6a2a9dd6de304e78f84456903c932ad452 Reviewed-on: https://code.wireshark.org/review/19393 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-23GSM A GM: use same spelling as the 3GPP specificationPascal Quantin1-2/+2
Change-Id: I706b64bb3875a15d8be0e486a03784e19ab5af23 Reviewed-on: https://code.wireshark.org/review/19392 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-23Initialize the dissection options along with the other command-line options.Guy Harris1-0/+1
Change-Id: I35ff8f36d12831d408666c3422444371a2ac0c25 Reviewed-on: https://code.wireshark.org/review/19391 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-22packet-rtp.c: Fix of decoding RTP over TCPJiri Novak1-0/+2
During patch modification in https://code.wireshark.org/review/#/c/19293/ we made mistake :-( Change-Id: I2ff65170dbcf3b5c4d27d6d7c629092d5080ed28 Reviewed-on: https://code.wireshark.org/review/19382 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-22udpdump: set default value for payloadDario Lombardo1-0/+3
Change-Id: Iad8624cbb9102611f806cdcce152b8ed14ce4474 Reviewed-on: https://code.wireshark.org/review/19383 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-24 04:59:57 +0000