aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2012-05-20Change the "user_saved" member of a capture_file structure toGuy Harris15-95/+124
"unsaved_changes", and have it be TRUE iff changes have been made to the file since it was read - *not* if it's a temporary file from a live capture. Check the "is_tempfile" member, and the "unsaved_changes" member, when appropriate. Just have a set_toolbar_for_capture_file() routine that updates the "save", "close", and "reload" toolbar as appropriate, given a capture_file structure - absorb the function of set_toolbar_for_unsaved_capture_file() into it. svn path=/trunk/; revision=42721
2012-05-19Fix RVALS() macro usagepascal11-45/+45
svn path=/trunk/; revision=42720
2012-05-19Add an 'if' test to prevent a potential null pointer dereferenceBill Meier1-7/+8
identified by clang scan-build. svn path=/trunk/; revision=42719
2012-05-19Rework 'ct_nb_switch_page_cb()' slightly to prevent a scan-build "null ↵Bill Meier1-15/+16
pointer de-reference" message; (In practice, the "null pointer de-reference" would not actually occur ?). svn path=/trunk/; revision=42718
2012-05-19Rework proto_registrar_dump_protocols() to prevent a Clang scan-build ↵Bill Meier1-2/+4
"de-reference of a null poiunter" warning (In practice, bug would not actually occur). svn path=/trunk/; revision=42717
2012-05-19Use col_append_sep_str instead of col_append_strpascal4-4/+4
svn path=/trunk/; revision=42716
2012-05-19Fix some "warning: Value stored to '...' is never read" clang scan-build ↵Bill Meier6-28/+22
warnings. Also; Do some whitespace cleanup in a few cases. svn path=/trunk/; revision=42715
2012-05-19Z_BLOCK was added in zlib-1.2.0.5Jakub Zawadzki1-2/+8
Pass Z_NO_FLUSH to inflate() when Z_BLOCK is not defined, just in case also disable fast seeking when it's not defined. References: http://www.wireshark.org/lists/wireshark-dev/201205/msg00145.html svn path=/trunk/; revision=42714
2012-05-19From Thomas Loockx via ↵pascal1-0/+52
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7269 : Add BGP MDT-SAFI dissection (RFC6037) svn path=/trunk/; revision=42713
2012-05-19From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7262 :pascal1-1/+1
Digest details display issue in SPB Digest subtlv (ISIS hello pdu) svn path=/trunk/; revision=42712
2012-05-19Improve Gadu-Gadu dissector and fix some comments.Jakub Zawadzki1-58/+255
svn path=/trunk/; revision=42711
2012-05-19Fix the DCH data collection for conversation setupAnders Broman4-53/+216
svn path=/trunk/; revision=42710
2012-05-18Improve Gadu-Gadu dissector.Jakub Zawadzki1-71/+889
svn path=/trunk/; revision=42709
2012-05-18There's no need to include Custom.common here; it gets pulled in by ↵Jeff Morriss1-2/+0
Makefile.common svn path=/trunk/; revision=42708
2012-05-18Allow custom dissectors in automake too.Jeff Morriss4-3/+3
svn path=/trunk/; revision=42707
2012-05-18Expand a comment.Guy Harris1-2/+12
Clear the struct sigaction *before* we fill in any fields in it. svn path=/trunk/; revision=42706
2012-05-18When saving packets, fill in hdr.presence_flags from the flags in theGuy Harris1-2/+17
frame_data structure; there's no guarantee that the wtap_pkthdr in the wtap structure reflects the current packet. svn path=/trunk/; revision=42705
2012-05-17Tabs -> spacespascal1-128/+128
svn path=/trunk/; revision=42691
2012-05-17From Martin Kaiser via ↵pascal4-0/+296
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7255 : dissector for generic ISO 7816 messages (atr and apdus) svn path=/trunk/; revision=42689
2012-05-17Use some newer versions.Michael Tüxen1-15/+15
svn path=/trunk/; revision=42687
2012-05-17Fix an "unused variable" warning....Bill Meier1-2/+0
svn path=/trunk/; revision=42686
2012-05-17Fix the fix ....Bill Meier1-1/+1
svn path=/trunk/; revision=42685
2012-05-17Silence a "may be used uninitialiuzed" warning.....Bill Meier1-1/+1
svn path=/trunk/; revision=42684
2012-05-17General cleanup including as appropriate:Bill Meier10-1604/+1600
- Remove unneeded #include files (string.h, addr_resolv.h); - Remove unneeded 'if(!initialized){...}' in proto_reg_handoff(); - Reformat hf[] entries; - Remove unneeded variable initializations; - "localize" some variables; - Whitespace/indentation/long lines/formatting (in one case: re-order code slightly to not do col_set_str() & etc until after initial "frame acceptance testing" by dissector. svn path=/trunk/; revision=42683
2012-05-17Fix copy&paste: hf variable name in hfi->abbrevJakub Zawadzki2-3/+3
svn path=/trunk/; revision=42682
2012-05-17No leading whitespaces in the INFO column.Michael Tüxen1-3/+16
svn path=/trunk/; revision=42679
2012-05-17General Cleanup including:Bill Meier8-5557/+5616
- Remove unneeded #include <stdlib.h>; - Remove "README.developer" comments; - Reformat hf[] entries; - Remove unneeded variable initialization; - "localize" some variables; - Whitespace/indentation/long lines/formatting - (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *); svn path=/trunk/; revision=42678
2012-05-17Add support for specifying an SCTP port number.Michael Tüxen1-2/+18
svn path=/trunk/; revision=42677
2012-05-17Fix string buffer overflow (bug #7029)Jakub Zawadzki1-11/+21
g_strlcpy() always return the size of strlen(src), so in case of truncation it could happen that offset_r > size or offset_e > size. Fix it by adding new function protoo_strlcpy() which returns how many bytes was copied to dest buffer. svn path=/trunk/; revision=42676
2012-05-17Fix spice.common_cap_byte1 filter I changed by mistake in r42664pascal1-6/+6
svn path=/trunk/; revision=42675
2012-05-16Use BASE_DEC for spice.common_cap_byte1. (Hopefully that's correct.)Gerald Combs1-3/+2
svn path=/trunk/; revision=42668
2012-05-16From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7264 :pascal1-15/+60
Enhance the Spice dissector to deal with sized data streams and playback data From me: fix a few hf entries svn path=/trunk/; revision=42664
2012-05-16From Pontus Andersson via ↵pascal1-1/+0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7259 : GTP Extension headers are dissected incorrectly svn path=/trunk/; revision=42663
2012-05-16Largely, whitespace and formatting changes. Added modelines to match.Chris Maynard1-4694/+4347
Other misc. changes: -> Delete useless, duplicate assignment of offset to 0 in dissect_vsnp(). -> Change short seq # display filter so it's not the same as the seq # filter. -> pppoe.dump.gz looks to be malformed, so remove unnecessary "remlen" code in dissect_cp() and let the packets be displayed as malformed since they are. -> Remove if (check_col()) checks. -> Fix copy-and-paste of filter name for ipcp.opt.max_header. svn path=/trunk/; revision=42661
2012-05-16Update INSTALL_DIR to match r42659.Gerald Combs1-3/+3
svn path=/trunk/; revision=42660
2012-05-16Fix the *test_install targets so they put the test tools in the right ↵Jeff Morriss1-3/+3
directory (wireshark-gtk2 is one dir up from here). svn path=/trunk/; revision=42659
2012-05-16Fix a bunch of uninitialized variables found by Coverity Scan. CIDsGerald Combs10-168/+177
702403, 702404, 702405, 702406, 702407, 702408, 702409, 702410, 702411, and 702412. svn path=/trunk/; revision=42658
2012-05-16se_allocate and store per packet data.Anders Broman1-10/+5
svn path=/trunk/; revision=42657
2012-05-16Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7186 :pascal1-1/+4
Link together access-request and access-challenge messages svn path=/trunk/; revision=42656
2012-05-16Handle DCH information in RadioLinkReconfigurationPrepareFDDAnders Broman4-54/+142
svn path=/trunk/; revision=42655
2012-05-16Free memory when create_tempfile() failed.Jakub Zawadzki2-0/+6
svn path=/trunk/; revision=42654
2012-05-16Only do HS-DSCH Control frames for now as something is broken.Anders Broman3-4/+21
svn path=/trunk/; revision=42653
2012-05-16From David Wei:Anders Broman1-0/+2
Corrected info column for piggybacked GTPv2 messages. svn path=/trunk/; revision=42652
2012-05-16Setup frame for HSDSCHAnders Broman1-0/+2
svn path=/trunk/; revision=42651
2012-05-16Bug fixes and add HSDSCHAnders Broman1-30/+52
svn path=/trunk/; revision=42650
2012-05-16Bug fixes and add HSDSCHAnders Broman4-33/+54
svn path=/trunk/; revision=42649
2012-05-16Store a copy of the default preferences (e_prefs; the dissectors' defaultJeff Morriss1-10/+157
preference values have been stored for a while now). If a preference has not been changed from its default value, comment it out when writing the preferences file. That way you won't get warnings about some new "gui.*" (or other non-dissector) preference when switching between SVN Wireshark and some older version. Also fix some ommissions in copy_prefs() (preferences that were not copied). (All these non-dissector preferences seem to require an awful lot of code; it would be very nice to have a non-dissector preference registration API that the GUI and core could use so we could eliminate a lot of this code.) svn path=/trunk/; revision=42648
2012-05-16all:Bill Meier11-2267/+2087
Merge .h files into .c files since .h files unused elsewhere; Do whitespace, indentation & formatting cleanup. packet-acn.c: Fix 2 minor bugs wherein subtree not displayed in packet-details because tree variable used in proto_tree_add_text() always NULL. svn path=/trunk/; revision=42647
2012-05-16Most dissectors don't register their preferences in subtrees, so don't ↵Jeff Morriss1-2/+6
allocate the submodules pe_tree until it's needed. svn path=/trunk/; revision=42646
2012-05-16Check the return value of create_tempfile. Fixes CIDs 280527 and 280528.Gerald Combs2-26/+47
svn path=/trunk/; revision=42645