AgeCommit message (Collapse)AuthorFilesLines
2017-01-08qcdiag_log: Implement RRC dissectionlaforge/qcdiagHarald Welte1-3/+97
Change-Id: If7a5ea0fb44a40fd0abd67606ee7dcb83efe6fec
2017-01-08qcdiag: Dissect Log Configuration packetsHarald Welte1-2/+65
Change-Id: I5c54a49e41e84d043f55ab0a05e6ffed2f8e1291
2017-01-08qcdiag_msg: Add summary info to root nodeHarald Welte1-0/+4
Change-Id: I9769c6834a5fed6698695170e4bac775922c1a14
2017-01-08qcdiag: Add summary information to qcdiag root nodeHarald Welte1-0/+3
Change-Id: Id648ccdc000da5cd4d4d881b1720cf6164a526d9
2017-01-08qcdiag: Use value_string_extHarald Welte1-2/+6
Change-Id: I736d69cb524af2e8254d94b9ab15577f5b65646e
2017-01-08qcdiag_msg: Avoid multi-line COL_INFO and crashes in case of %sHarald Welte1-21/+58
also, add the formatted string not only to COL_INFO but also to the packet details. Change-Id: I54ccb1621b640f8676f7248bf23f9eed3da3cbdb
2017-01-07WIP: Qualcomm DIAG Protocol supportHarald Welte8-0/+1182
Change-Id: I0bd06c46e00570005a1148860954a77c8f5445a8
2017-01-07WIP: RSL Ericsson supportHarald Welte1-0/+141
Change-Id: I1e9b3c08848f4feb60361e629d7225b6d2e1dcbd
2017-01-07HACK: Hand GPRS RLC payload to GPRS LLC dissectorHarald Welte1-4/+6
this is an ugly hack, as there is no code for packet re-assembly in betwween, i.e. we only get proper dissection if the LLC message was fitting entirely into one RLC block. Nevertheless, sufficient to see things like RAU, ATTACH, IDENTITY procedures. Change-Id: I1fc488aa58353e5f4264b940f9f4c18987148a7d
2017-01-07WIP: Jacob's EGPRS patchHarald Welte1-0/+170
... with add_new_data_source() to visualize the re-aligned bits Change-Id: I1604dceaf3d91228e87712e099c8a209ff812f4a
2017-01-07l2tp: Introduce preference for default pseudowireHarald Welte1-2/+21
In some cases, the establishment of the L2TP session is not captured in the pcap file, and thus wireshark cannot determine the l2tp pseudowire to be used for decode. So rather than using a ocmpile-time hard-coded default of cisco hdlc, let's introduce a prference where the user can select the default pseudowire in such cases. Change-Id: I44a6373d4812c9ab5a919514273a41a2ab57142c
2017-01-07L2TP: Add preference to select Ericsson HDLC flavorHarald Welte1-1/+13
At some point over the wireshark last years, the connection between the L2TP dissector and the Ericsson HDLC dissector (packet-ehdlc.c) got broken. I cannot poinpoint the exact change when it broke. However, traces with Ericsson L2TP that used to display correctly no longer do so. The problem with Ericsson L2TP is that they simply re-use the HDLC pseudowire (0x0006), but then have frames completely different than what's specified in the RFCs for that. To address this, let's add a protocol preference to allow the user to choose. Change-Id: Idce022ef0f233c01ecffc67dca7f428bde31ef6b
2017-01-07DVB-S2 BB: Fix BB header CRC checksMustBeArt1-9/+4
Fix problem with baseband header CRC check that caused almost all baseband frames to show a spurious CRC error, introduced with proto_tree_add_checksum. Change-Id: I6b2f9680507eeb79e59b825f3ac9e4cee1033976 Reviewed-on: https://code.wireshark.org/review/19567 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2017-01-07Make column size sanity check more sensible.Noel Power1-1/+3
The existing sanity check on column_size makes incorrect assumptions about the size of the CTableColumn structure (which is an internal dissector structure that contains optional data). The sanity check test *always* fails. This change uses the minimum size of CTableColumn structure instead which should prevent excessive allocation during fuzz testing. Bug: 13299 Change-Id: Id9fcbc15a4df4c74bb7576c6fdca1000890947fd Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-on: https://code.wireshark.org/review/19566 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-07Add support for RROCE(v2) over IPv4 (without UDP).Jeff Morriss1-2/+6
This isn't standard but has been seen in the wild, see: https://ask.wireshark.org/questions/58521/cannot-decode-rocev2-traffic With this change users can Decode-As an IP Protocol as RROCE (by selecting Infiniband (IB) as the protocol). Change-Id: Iec865478d056f687f2f66124d6e936f67707d2c4 Reviewed-on: https://code.wireshark.org/review/19572 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-07packet-nvme: Dissect read/write cmd and SGLParav Pandit1-4/+268
1. Added support to dissect read and write commands. 2. Added support to dissect SGL fields addr, len, key. 3. Changed long reserved fields to decimal presentation. 4. Fixed typo for cqe reserved field. Change-Id: I63c674c68143c9c61610bada0410b49a134361d4 Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19565 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07packet: fix memleak of "short_name" for heuristics dissectorsPeter Wu1-1/+3
Change-Id: I3b954e3623473899b6039f0ff572eb56defe14cc Fixes: v2.3.0rc0-1841-ga8b68205a4 ("packet: duplicate short_name to fix UAF in wslua") Reviewed-on: https://code.wireshark.org/review/19571 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07Convert range API to always use wmem memory.Michael Mann54-207/+189
This is mostly to address memory leaks in range preferences (the biggest user of range functionality) on shutdown. Now range preferences must use epan scoped memory when referencing internal preference structures to keep consistency. Change-Id: Idc644f59b5b42fa1d46891542b53ff13ea754157 Reviewed-on: https://code.wireshark.org/review/19387 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): Enhance dissection of Beacon Interval Control (BIC)Alexis La Goutte1-28/+36
You can now use bitmap on 64bits (or 48bits) and also add a reserved field Ping-Bug: 13244 Change-Id: I2ec9412f6cfebd3a8ca5c082af5e8481e2646eaf Reviewed-on: https://code.wireshark.org/review/19561 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-06Convert some easily identifiable pinos.Michael Mann9-30/+30
grepping for "Decode As" comments reveals exactly was pinos were created for - distinguishing multiple dissection functions in a single dissection table. Change-Id: Iaa9294045e9d0633563e7d763cb585c0e6dc598f Reviewed-on: https://code.wireshark.org/review/19490 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06VLAN: Support IEEE 802.1Q-2005 and -2011 changesJohn A. Thacker1-20/+174
Supports the recommended meanings of the priority field as changed by 802.1Q-2005, and the change from the CFI to DEI in 802.1Q-2011. A preference is added to use the older (non-compatible) spec version. Note that 802.1Q-2011 is consistent with 802.1ad and ah, which got rolled up in 802.1Q, but ends up removing support for bridging Token Ring and FDDI over Ethernet. Bug: 13294 Change-Id: Ieeadb0f6dda2758750f9e6649f1390609d78c50e Reviewed-on: https://code.wireshark.org/review/19548 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): add reserved fields for Beam FormingAlexis La Goutte1-0/+14
Change-Id: I486c883b27059eb55e9fe11fcc372fc31c1e56ca Ping-Bug: 13244 Reviewed-on: https://code.wireshark.org/review/19560 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): align length of Beam FormingAlexis La Goutte1-10/+10
use UINT16 Change-Id: I7f7c4e847ed6ccb6ced446d493aa27f76cc8db61 Reviewed-on: https://code.wireshark.org/review/19559 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): fix typoAlexis La Goutte1-1/+1
Wrong field name for Dynamic Allocation Issue reported by Hany ASSASA Bug: 13244 Change-Id: Idec2cb48c5b3d22d75880325d2aec0083d89ca95 Reviewed-on: https://code.wireshark.org/review/19558 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-05Update the preference help text to indicate the correct default RROCE port.Jeff Morriss1-2/+2
I97b82fb53fd63d9107ee5d4c64b94840e743fc72 changed the default but not the help text. Change-Id: I05375c44c01703e36686d0a16a094cb8d6b3dcd2 Reviewed-on: https://code.wireshark.org/review/19557 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-05NAS EPS: NAS message container in Control Plane Service Request can be cipheredPascal Quantin1-2/+21
Change-Id: I026fc63e09c54807604c5d5a112c36dd41759c00 Reviewed-on: https://code.wireshark.org/review/19556 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-05Add g_log entries to measure startup time, protected by #ifdefAndersBroman1-5/+51
Change-Id: Ic32f89dc824a6da838643445a30335a8c73af1ee Reviewed-on: https://code.wireshark.org/review/19540 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-05More make-version.pl fixups.Gerald Combs1-13/+14
Don't add extra \n's. Change ".*([\r\n]+)$" matches to ".*?([\r\n]+)$" so that we don't greedily match the wrong line ending. Change-Id: I916ee49207eaac17e1e4c4f677558f7be13a099a Reviewed-on: https://code.wireshark.org/review/19541 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-05Do RA_DISSECTORS in the Qt UI.Guy Harris2-3/+6
It looks as if a fair bit of work is done under RA_DISSECTORS before we register any individual items, so add it to the splash screen update with the Qt UI - it's used in the GTK+ UI. Update a comment to explicitly indicate what action transactions are being counted (other than the individual-item ones, where we have to call routines that give us a count of items). Change-Id: I3ec5e5fbfdcf523d693bcf1b0f0ffbe0d05d61ae Reviewed-on: https://code.wireshark.org/review/19553 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-05Fix comment.Guy Harris1-1/+1
Change-Id: I5c18130dc22220ddd85109235383fcf61e543d89 Reviewed-on: https://code.wireshark.org/review/19552 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-05Remove RA_CONFIGURATION.Guy Harris4-11/+3
It's not used at all in the Qt UI, and the point at which it's used in the GTK+ UI doesn't involve reading configuration files - between it and RA_INTERFACES, some mostly quick command-line argument processing is done. Change-Id: Ib4de97c8b6dba658a6e9d8f596b551f7c45739d2 Reviewed-on: https://code.wireshark.org/review/19551 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04QUIC: fix typo on ACK num revived field descriptionAlexis La Goutte1-1/+1
Found in https://ask.wireshark.org/questions/58396/some-question-about-quic-decode-result Change-Id: Ic7fc2c2318186eabb5047f816987d2553a6fd449 Reviewed-on: https://code.wireshark.org/review/19547 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04Clean up indentation.Guy Harris1-11/+11
Change-Id: Ie5a2cc5650840a40fe3a84c04598e1f35dc47f4a Reviewed-on: https://code.wireshark.org/review/19550 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Include extcap binaries in the count of things to point out during startup.Guy Harris4-3/+51
The GTK+ version, at least, crashes if there are more "doing XXX..." items put up than the calculated count, so, now that we're putting up items for extcap binaries, we need to count the extcap binaries. Clean up some stuff we found doing this (indentation, a _U_ on something that's used). Change-Id: I1f88042b64ce4b9ae352de37689677c694e3770b Reviewed-on: https://code.wireshark.org/review/19549 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Escape opening curly braces in gen-bugnote.Gerald Combs1-5/+6
Curly braces are used for attribute replacement in AsciiDoc. Change-Id: I1461ee26543dd20a9f799084a01710faef78f2d0 Reviewed-on: https://code.wireshark.org/review/19517 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-04Add a startup message for Initializing extcap.AndersBroman5-8/+17
Change-Id: I06262e98bb4a55ee1eacd7a36b938b45eaffaf76 Reviewed-on: https://code.wireshark.org/review/19535 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04Revert "Another change required for that."Guy Harris1-1/+1
This reverts commit 3cfa4f760276bf995aca2479166a2128451fd402. Nope, *not* needed, and not wanted, either. Change-Id: I71ac174a9b9b19980d0a6f44088d0a66f71ef99b Reviewed-on: https://code.wireshark.org/review/19538 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Another change required for that.Guy Harris1-1/+1
Bug: 13270 Change-Id: I86e779c8f7b89ca928556d8b1acc1015b96f9100 Reviewed-on: https://code.wireshark.org/review/19537 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Running Wireshark through a symlink doesn't work.Guy Harris3-21/+22
We can't just symbolically link to the executables, as that means that the executable won't be in Contents/MacOS, which means that all @executable_path-relative references will go to the wrong place if we run the executables using the symlink, which means that the executables could fail (they *do* fail to find the Cocoa Qt plugin, for example). So, instead, we go back to the old version of the utility launcher, and put that in Contents/Resources/bin as well as, if the user requests the CLI utilities, /usr/local/bin. Maybe PackageMaker will find that acceptable and include them in the installer package. Bug: 13270 Change-Id: I4016b58c9ce0df05d78525d35e53431750c2b4d9 Reviewed-on: https://code.wireshark.org/review/19536 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Oops, source and target are the other way around.Guy Harris1-2/+2
Bug: 13270 Change-Id: Ibeddb435acca298c90f2d6b9c0228e8a9a747b38 Reviewed-on: https://code.wireshark.org/review/19534 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Create the Content/Resources/bin directory if necessary.Guy Harris1-0/+4
Bug: 13270 Change-Id: Idc4223a24d6d2037d13a85331ce63e5a24168d3a Reviewed-on: https://code.wireshark.org/review/19533 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Qt: add SACK graphs to tcptrace graphKevin Hogan3-57/+185
Primarily, this adds visual indication of SACK blocks to tcptrace. In addition: - cleaned up focus behavior for graph selector and spinboxes - added time-delay update to streamNumber spinBox (similar to behavior of maWindow spinBox) - changed ACK selection to select only SACKed responses (rather than all ACKs - SACKs seemed more useful to look at) Change-Id: I47d9e98d54f14e4955008ecea791b77f805c8ba9 Reviewed-on: https://code.wireshark.org/review/19388 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04RTPS: Added dissection for Parametrized user dataJuanjo Martin1-1/+78
Before we were showing an expert warning saying that it was not supported. Now we show the parametrized data dissected in the form sequence of (id, length, value) Added also filters so it is possible to filter on the ids (useful in RTPS) Bug: 13278 Change-Id: I8569830305bc303febe6f3460221e7a52867a34d Reviewed-on: https://code.wireshark.org/review/19458 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04RRC: upgrade dissector to v13.5.0Pascal Quantin7-433/+436
Change-Id: I95323ed8aabff7a20442c848fa0dc39854297584 Reviewed-on: https://code.wireshark.org/review/19527 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04Remove trailing whitespace.Guy Harris1-1/+1
Change-Id: Ifdea8516ccce7a72c88470913ce36b9226dfcb54 Reviewed-on: https://code.wireshark.org/review/19532 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Put symlinks to the executables in Contents/Resources/bin.Guy Harris1-1/+13
PackageMaker appears not to put them into the installer package, so construct them in the Wireshark post-install script. Bug: 13270 Change-Id: Idfa10d4d123d2c0e2f7b3ad65888e075fbfd27a7 Reviewed-on: https://code.wireshark.org/review/19531 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04No reason not to use etype_vals for an Ethertype field.Guy Harris1-1/+1
Maybe there was an issue on Windows back in the old days, when 1) we didn't have a shared libwireshark library from which to import functions and data variables and thus you couldn't get variables such as etype_vals in a plugin and 2) the Infiniband dissector was a plugin, but neither of those are the case any more. Change-Id: Id8b82886317bd36a32ad1e1591673623696d4808 Reviewed-on: https://code.wireshark.org/review/19530 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Ensure that tcp.reassembled_in is added to the tree for first segment.Martin Mathieson1-1/+12
Bug: 3264 Change-Id: I9fa8cfaf1e21a8a984941ee40e2e404ae21e55c9 Reviewed-on: https://code.wireshark.org/review/19528 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-03infiniband: remove offset variable.Dario Lombardo1-9/+7
Change-Id: Ie86c2aece05ebbc35eb15a54d8c3f2c455ff53cf Reviewed-on: https://code.wireshark.org/review/19516 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-01-03infiniband: fix error for clobbered variable.Dario Lombardo1-1/+1
Given by gcc-4.9.2 on arm: epan/dissectors/packet-infiniband.c:2708:9: error: variable ‘offset’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] int offset = 0; ^ cc1: all warnings being treated as errors Change-Id: I12066031093c1fa638792ff8be8f3f5457e3feda Reviewed-on: https://code.wireshark.org/review/19515 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>