aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-09-25CBSP: Message Content is a fixed-length IElaforge/cbspHarald Welte1-2/+6
There is a "User Info Length" field, but that field doesn't determine the actual length of the IE, but only the number of non-padding bytes within that IE. Let's solve this by making the IE a fixed-length IE of 83 bytes (83 + tag). Change-Id: Ib23254fb5eded555c1e79ff7a8f19703f5cc8cf8
2018-09-25CBSP: Fix typo Nomber->NumberHarald Welte1-1/+1
Change-Id: I672cc45412e75f700b2a36682657da6252b7cc2d
2018-09-20WIP: 3GPP CBSP (Cell Broadcast Service Protocol) dissectorHarald Welte3-0/+612
This protocol is spoken between the BSC (Base Station Controller) and the CBC (Cell Broadcast Centre). It runs over TCP Port 48049 and is specified in 3GPP TS 48.049. Change-Id: I183e4741e2db5b9cc4dfe2b89f7920a32af67971
2018-09-16packet-rsl: Fix dissection of "CB Command Type" IEHarald Welte1-2/+47
The "CB Command Type" IE is described in 3GPP TS 48.058 Section 9.3.41, and consists of three fields. Prior to this patch, the dissector would decode none of them and instead produce a non-applicable "channel type" dissection. Change-Id: Ibb97432871df1276524fe96512ac1b67d5c5d3f0
2018-09-16gsm-gsup: correct value OSMO_GSUP_CANCEL_TYPE_*Alexander Couzens1-2/+2
The value has to be reduced by one as the comment already describes. Change-Id: Ib33465e0450f05779856f23800fc3bb1703cbff6 Reviewed-on: https://code.wireshark.org/review/29678 Reviewed-by: Harald Welte <laforge@gnumonks.org> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-09-16[Automatic update for 2018-09-16]Gerald Combs3-25/+54
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0dd227496fdf196a63f29e57aac716c41a70dd48 Reviewed-on: https://code.wireshark.org/review/29679 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-16FP: Fix trying to resolve out-of-range LCHIDDarien Spencer1-25/+45
LCHID value of 15 indicates 'BCCH or PCCH' over HSDSCH and hence the MAC Content shouldn't be resolve by the ID. Also, make separate 'c/t' and 'lchid' concepts in the dch conversation info parsing. Bug: 14889 Change-Id: I7a3a8556108caf60c527e4cb5241dfad4ea9a331 Reviewed-on: https://code.wireshark.org/review/29657 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-15ssl,ssl-utils: remove PCT supportPeter Wu3-788/+10
This protocol was superseded by SSLv3 and has been disabled in MS products long time ago. Change-Id: If29bcfad394ba55c7d6605626762c29055a02ae9 Reviewed-on: https://code.wireshark.org/review/29667 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-15lwm2mtlv: Show resource name in a generated itemStig Bjørlykke1-0/+11
Change-Id: I9892755f8a97e535ba893ec7987df3a0bf39870a Reviewed-on: https://code.wireshark.org/review/29663 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-15rdp: fix Unused href entry: epan/dissectors/packet-rdp.c: hf_rdp_unusedAlexis La Goutte1-6/+0
Change-Id: I49e8a503daa28b90d4a6adcb28d789383b641116 Reviewed-on: https://code.wireshark.org/review/29666 Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-15couchbase: fix Unused href entry: epan/dissectors/packet-couchbase.c: ↵Alexis La Goutte1-2/+0
hf_flex_frame Change-Id: I3d0422f0e433ec9f3056b327b5e3da5e0510437d Reviewed-on: https://code.wireshark.org/review/29665 Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-15QUIC: remove draft -11 supportPeter Wu1-64/+27
Draft -11 was more or less complete, but complicates PKN handling. Drop it and update references to draft -13 (not the latest (-14) as we are trying to get -12 and -13 ready before moving on). Drop the "Short Packet Type" field and add a new field for three reserved bits. The Third, Fourth and Google QUIC Demultiplexing bits are not shown now for simplicity reasons. Change-Id: Ibf4e281a54488aab14f5c9ca48ecc532e9701b12 Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/29668 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-15packet.h: fix wrong parameter doc for register_dissector_table_aliasPeter Wu1-1/+1
Change-Id: I27512d19264309472be61ebc4ca2db40d2f79d32 Fixes: v2.9.0rc0-1828-g5dbc202063 ("Add support for aliases to dissector tables.") Reviewed-on: https://code.wireshark.org/review/29669 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-15Add support for aliases to dissector tables.Gerald Combs10-10/+71
Add register_dissector_table_alias, similar proto_register_alias. Add aliases for ssl.port, and ssl.handshake.extensions_alpn_str, and dtls.handshake.extensions_alpn_str. Change-Id: I87c3215e2872883ed0f581557e08c84f2dba12a0 Reviewed-on: https://code.wireshark.org/review/29652 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-15Aeron: Update disector on the latest aeron protocol specificationchaoyongzhou1-17/+293
1, update frame fields and offset 2, shift heartbeat frame from data frame which is a special data frame 3, support rtt frame supported by aeron in java 4, revise data/pad frame length alignment to 32 bytes but not 8 bytes 5, remove frame length alignment from setup,nak,err,and rtt frame 6, fix rtt frame length Bug: 15111 Change-Id: Ic627a9773850fa6bceacd313ddeba521487815e2 Reviewed-on: https://code.wireshark.org/review/29407 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-09-14Debian: Add missing symbols.Gerald Combs1-0/+2
Change-Id: I8c1b91d56466c15e797c5404b49dc7de57b8a2f5 Reviewed-on: https://code.wireshark.org/review/29664 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-14QUIC: recognize CRYPTO frame (draft -13)Peter Wu1-0/+33
Avoids malformed packet warnings. Actual TLS handshake/alert protocol support will be done later. Change-Id: I87e783ab12a10afad7c0372a0b3a900a5e37f6e1 Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/29642 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-14make-manuf.py: Improve truncation.Gerald Combs1-8/+31
If the PyICU module is available, use it to truncate manufacturer names by grapheme clusters. Change-Id: Ib7dcbb126809df496a534f44a47871a1b28dc539 Reviewed-on: https://code.wireshark.org/review/29660 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-14Test: Fix a copy+paste error.Gerald Combs1-1/+1
Change-Id: Id040b05af022752672f2d56d4796f0c71352e7b1 Reviewed-on: https://code.wireshark.org/review/29658 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-14evs: Start dissecting a bit of speech data.AndersBroman1-94/+254
Change-Id: I30ad1c083c2e3ed920245f0421b280b5b9b16336 Reviewed-on: https://code.wireshark.org/review/29656 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-14QUIC: split per-packet state to fix packet coalescingPeter Wu1-35/+54
Packet coalescing requires separate state for every QUIC packet. Split the state as each UDP datagram can contain multiple QUIC packets. Most datagrams will have only one packet, so to avoid multiple allocations, just embed the first packet into the datagram info and use a linked list for simplicity. Change-Id: Ib921e68a7312c6eccb5601b8951ff64cc9ea49cd Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/29647 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-14opcua: prevent opcua dissector crash by limiting nesting depthHannes Mezger2-1/+37
The OPC UA types DiagnosticInfo, Variant and ExtensionObject can be nested, which can lead to stack overflows when parsing specially crafted packets. This is fixed by storing the current nesting depth as expert info. The corresponding CVE is https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-12086 The corresponding security bulletin of the OPC Foundation is https://opcfoundation-onlineapplications.org/faq/SecurityBulletins/OPC_Foundation_Security_Bulletin_CVE-2018-12086.pdf Change-Id: I5f6da3a3e269f6db1b690b77470ddf60045bcedd Reviewed-on: https://code.wireshark.org/review/29645 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13Start renaming SSL to TLS.Gerald Combs51-442/+448
Rename the "ssl" protocol to "tls" and add an "ssl" alias. Prefer "TLS" over "SSL" in user interface text and in the documentation. Fix the test_tls_master_secret test while we're here. Bug: 14922 Change-Id: Iab6ba2c7c4c0f8f6dd0f6d5d90fac5e9486612f8 Reviewed-on: https://code.wireshark.org/review/29649 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-13QUIC: fix Initial dissection (draft -13)Peter Wu1-13/+50
Recognize the Token field in the Initial Packet. Accept Initial Packet from server and adjust connection tracking logic to take this into account. Tested with ngtcp2-13.pcap, now the Initial packets can be decrypted (even if the containing frames are not correctly handled). Change-Id: I5937fb85172a2f93d1b4a4ed7667474ec04f95fc Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/29641 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13QUIC: use HKDF-Expand-Label (draft -13)Peter Wu1-21/+68
Prepare for draft -13 support. A comment references draft -14 since the draft -13 text is wrong (it lacks the context argument). Change-Id: I3f2c59d2640693959372ebe0de3b58f67b5588b9 Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/29640 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13QUIC: implement draft -12 decryption (PNE and PP)Peter Wu1-43/+228
Packet number encryption (draft -12 + PR 1389) is implemented. The payload protection has been updated to use the decrypted PKN as well. Caveats: since the packet number is initially unavailable, the previous approach on detecting legitimate key updates no longer works. This change breaks Key Update support which needs to be revisited later. Due to how PKN lengths and decrypted results are stored (one per datagram), packet coalesing is also not fully supported. Bug: 13881 Change-Id: I13c63578cec7f7f74a404b1a7a8fc85026a14252 Reviewed-on: https://code.wireshark.org/review/29637 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13Prefs: Add a check for aliased protocol preferences.Gerald Combs1-2/+8
Add a check to set_pref for aliased protocols alongside the checks for protocols we've renamed in the past. Change-Id: I62ad2ddb17d66bd7385635bfa6ca1dd58fad6ad5 Reviewed-on: https://code.wireshark.org/review/29651 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-13DHCP: Fixup whitespace.Gerald Combs1-4/+4
Change-Id: Iaf56751dff81ff9f5c59e1e99ca93aafb38a934d Reviewed-on: https://code.wireshark.org/review/29650 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-13ieee80211: parse the 9th byte of the Extended Capability as a byteEmmanuel Grumbach1-3/+3
Some of the bits were parsed as a bit of a WORD, and others as a bit of BYTE leading to a bug in the display. Bug: 15133 Change-Id: Ie6877c4a4a79fcc802afec49436370cf22a6bfae Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Reviewed-on: https://code.wireshark.org/review/29633 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13evs: Put CMR "rate" in Info column.AndersBroman1-5/+17
Change-Id: I99447ac80751dea53849bd0575804dc7e74a27c5 Reviewed-on: https://code.wireshark.org/review/29638 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13gtp: move column append outside IF bracketsJoakim Karlsson1-2/+2
Column appended never happen on IPv4/IPv6 since latest refactor Change-Id: Icc85cfa8136386a440b226959f9df4a980a2658e Reviewed-on: https://code.wireshark.org/review/29644 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13MTP2 bitstream dissector - dissect MTP2 packets from RTP streamLajos Olah1-3/+878
Change-Id: I704c68caa8cd8aa60c6417e6ee038db5f6507686 Reviewed-on: https://code.wireshark.org/review/29506 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13tvbtest: Remove an unused function.Gerald Combs1-9/+0
It looks like "skip" hasn't been required since 2011. Change-Id: Idaf53943519fa76e362aaecc6999f9971a359348 Reviewed-on: https://code.wireshark.org/review/29643 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-13ospf: fix conlictAlexis La Goutte1-1/+1
'ospf.mpls.pri' exists multiple times with NOT compatible types: FT_FLOAT and FT_UINT8 Change-Id: Iea0b662d0a9ff4a7ea7363ef4ef049d11d5a5dca Reviewed-on: https://code.wireshark.org/review/29608 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12AT: Add CSUPI commandDarien Spencer1-0/+8
Change-Id: I501bd0e00a20b39e4c53bdd7e5e2b9b3c5234469 Reviewed-on: https://code.wireshark.org/review/29635 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12QUIC: create QUIC-specific cipher contextPeter Wu1-42/+48
This makes it easier to track the packet number cipher. Change-Id: I220935e91c324e0a641306c590f55af4992ee2e1 Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/29636 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12AT: Fix rejection valuesDarien Spencer1-2/+2
Dissect functions for CNUM/VTS were returning TRUE for all wrong role/type combinations instead of FALSE ( = Rejecting the parameter ) Change-Id: I1aae5b76db83cef6b59f5244c05a67b2110f8969 Reviewed-on: https://code.wireshark.org/review/29634 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12Revert "Some older compilers don't allow diagnostic pragmas inside a function."Guy Harris1-2/+3
This reverts commit f94cfa0cdc37955a5c68687af01bf4ad35ce27bd. Reason for revert: we don't use those diagnostic pragmas with those older compilers. Change-Id: I5154527dcc3813fb893c382059cb33538f2d29f7 Reviewed-on: https://code.wireshark.org/review/29639 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-12nas_5gs: can't decode 5GS NAS PDU when there are multiple NSSAIs.Rody Liu1-2/+1
Use dummy length in proto_tree_add_subtree_format(), proto_item_set_len() will set the correct length later. Bug: 15120 Change-Id: I7a56f3d1541b75eb53bc03750b6402a8b78a8251 Reviewed-on: https://code.wireshark.org/review/29465 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12nas5gs: Align with version 15.0.0AndersBroman1-12/+8
Change-Id: I068bef5cb9536e2af0c2be473841f4325b461cce Reviewed-on: https://code.wireshark.org/review/29632 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12tvbtest: fix no previous prototype for ‘test/skip/run_tests’ ↵Alexis La Goutte1-3/+3
[-Wmissing-prototypes] Change-Id: I21a2a0edc4cb96d4d757e4d6e9c38d7fc922afc8 Reviewed-on: https://code.wireshark.org/review/29631 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12gsm_a_gm: Fix dissection of 10.5.6.3 Protocol configuration options.AndersBroman1-3/+11
Session-AMBR dissected as QoS rules PDU session address lifetime dissected as Session-AMBR. Change-Id: Iee9e630644638718f37ddbc185e23add32ee61ea Reviewed-on: https://code.wireshark.org/review/29630 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12MBIM: changes after Microsoft fixed documentationJano Svitok1-29/+51
- update doc link to MBIM_CID_PCO - add numeric values and dissector skeleton for MBIM_CID_BASE_STATIONS_INFO and MBIM_CID_LOCATION_INFO_STATUS - MBIM_CID_MS_NETWORK_BLACKLIST: Set command has the same data as response - MBIM_CID_MS_NETWORK_BLACKLIST: Query command has no data, but is legal Change-Id: I8158029ae1e9ae2bc6fb389e889eb0bb71aa3d5d Reviewed-on: https://code.wireshark.org/review/29624 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-12Don't use -Werror with Apple's llvm-gcc.Guy Harris1-24/+17
Its handling of warnings, and of warnings-treated-as-errors, is horribly broken; once you've asked for a warning, and have specified -Werror, there appears to be nothing whatsoever that you can do to keep that warning from being an error *everywhere* in the code. Prior to change Ib591a1d6beaa13337d927a446b4d8d5e687ff610, the tests for warnings were all failing on the macOS buildbot, so *no* warnings were being requested. With this change, a warning won't be reported as an error, but at least it'll be reported. (We should probably switch to using Clang on the macOS buildbot at some point; I don't know whether the version of Clang currently on the buildbot is safe to use, but if we ever run a newer version of Xcode, which doesn't come with llvm-gcc - which may involve running a newer version of macOS on the buildbot as well - it's presumably safe, given that it's the only compiler Apple shipped.) Change-Id: I677967cb87b91f68f08de546e59abff1dbd6788b Reviewed-on: https://code.wireshark.org/review/29623 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-12QUIC: implement packet coalescing (draft >= 11)Peter Wu1-13/+57
Messages with long headers have a payload length while short header messages extend to the end of a datagram. Create a new tvb for every message since the decryption routines assume that the header starts from the beginning of the tvb. quic_get_message_tvb tries to avoid throwing exceptions in most cases if the (payload) length is too large such that dissection can proceed until the payload is encountered. (One edge case is when the varint cannot even be read, but then indeed the message is severely malformed.) Change-Id: Id42f55dfd73905b709b218002b9ca660f6f703f1 Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/29607 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12OK, try to prevent -Wunused-function warnings with llvm-gcc as well.Guy Harris1-0/+5
Change-Id: I53e48eb14d157eacd24322fb978f039e57377ed8 Reviewed-on: https://code.wireshark.org/review/29622 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-12Fix WITHOUT_VALS.Guy Harris1-2/+2
It was setting EF_TYPE and then clearing it; it should set EF_TYPE and clear EF_VALS. Change-Id: Ie0a85a12646c0395e50abb34caf32367e4191da0 Reviewed-on: https://code.wireshark.org/review/29621 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-12With llvm-gcc, just don't do -Wshorten-64-to-32.Guy Harris1-19/+16
If you specify -Werror and -Wshorten-64-to-32, there does not appear to be any way to get llvm-gcc *NOT* to treat those warnings as errors - not with pragmas, and not even with -Wno-error=shorten-64-to-32. Change-Id: Ia82df3f548085cca8d187c4b43c02060b87f0542 Reviewed-on: https://code.wireshark.org/review/29620 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-12-Wcomma isn't supported by llvm-gcc, so don't make it a non-error.Guy Harris1-1/+1
Replace a tab in an arguments string with a space while we're at it. Change-Id: Iee6ce920fbd7a883fb23bc798abb7f965e3757e6 Reviewed-on: https://code.wireshark.org/review/29619 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Just spaces between -W arguments.Guy Harris1-4/+1
Ninja, at least, complains about tabs. Change-Id: I65c3458dadc7096773084864d5e3970d1d9d580d Reviewed-on: https://code.wireshark.org/review/29618 Reviewed-by: Guy Harris <guy@alum.mit.edu>