aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-07-04Qt: add initializers (CID 1159357).Dario Lombardo1-1/+4
Change-Id: I27d561d8d63e0d15f7811dd7a033c38df17dfb36 Reviewed-on: https://code.wireshark.org/review/16271 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-04Qt: add initializer (CID 1159355).Dario Lombardo1-0/+1
Change-Id: If2504ea4a9d806005a6d7631ec4645df1af0206a Reviewed-on: https://code.wireshark.org/review/16270 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-04Qt: add initializer (CID 1159354).Dario Lombardo1-1/+3
Change-Id: I0aa4b9db902d084fe33eff5b69ac5cdc85c3fec8 Reviewed-on: https://code.wireshark.org/review/16269 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-03ssh: wmem_strdup() never returns NULLMartin Kaiser1-2/+4
Change-Id: I2f7b01e5a71f043e49305d0e2a3e78eaa5eae0a8 Reviewed-on: https://code.wireshark.org/review/16262 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-03[Automatic update for 2016-07-03]Gerald Combs13-604/+949
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ie8e9bf51a9c25c6693597ba1109c221a111e3b58 Reviewed-on: https://code.wireshark.org/review/16264 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-07-03iso14443: expert info if the crc is wrongMartin Kaiser1-12/+18
Change-Id: I1b59a7d7bf0f9f304f816558f38ce5d52deb504e Reviewed-on: https://code.wireshark.org/review/16263 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-07-03profinet, CID 1362120: check the return value of ftell()Martin Kaiser1-11/+14
change filePosRecord's data type to long, this is what ftell() and fseek() expect limit filePosRecord's scope to the block where it's actually used if ftell() returns < 0, don't move the file pointer and don't call fseek() with the negative offset Change-Id: If5a43099c32e476a691f4d6cd26ed7fb73490fcf Reviewed-on: https://code.wireshark.org/review/16258 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-03checkhf: Use colon as field separator for better readabilityJoão Valverde1-4/+4
Comma looks like a list when skimming quickly. Change-Id: Ic0ac1bc8746c70724d2279e3d725c5c9449b79d8 Reviewed-on: https://code.wireshark.org/review/16260 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-03ICMPv6-RPL: Fix DRO-ACK reserved field.João Valverde1-1/+1
Unused href entry: epan/dissectors/packet-icmpv6.c, hf_icmpv6_rpl_p2p_droack_flag_reserved Change-Id: I2fb74946aeb7cf1df708449c185126ee7b6b0253 Reviewed-on: https://code.wireshark.org/review/16259 Reviewed-by: João Valverde <j@v6e.pt>
2016-07-03profinet: add a space to make checkhf happyMartin Kaiser1-1/+1
without the space, checkhf complains about an ei entry martin@reykholt:~/src/wireshark.git$ ./tools/checkhf.pl plugins/profinet/packet-dcerpc-pn-io.c ERROR: NO ARRAY: plugins/profinet/packet-dcerpc-pn-io.c, ei_pn_io_unsupported Change-Id: Ie72efcec644225bc4f554117ae10672694823cad Reviewed-on: https://code.wireshark.org/review/16257 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-07-03dns: remove a bunch of unnecessary NULL checksMartin Kaiser1-50/+35
Change-Id: Ia4066ae3fc31fb43d4cc63cfb739f22738581831 Reviewed-on: https://code.wireshark.org/review/16256 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-07-03Revert "Support for NSH with VXLAN-GPE encapsulation"Alexis La Goutte1-4/+0
This reverts commit 76a8bca9bc87823e9182fa6ebb35f0b93bcc451b. Change-Id: I85b9778329373872e4f9fd1b90280dfef5e33a06 Reviewed-on: https://code.wireshark.org/review/16255 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-03Fix indentationJoão Valverde1-15/+15
Change-Id: I41b9cf4b7e3efbee48174fe0151ca94cb0bbc425 Reviewed-on: https://code.wireshark.org/review/16254 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-03ICMPv6: Avoid "no response found" for multicast pingJoão Valverde1-1/+7
Change-Id: Ia6bfdd28fc6d85b3899d542db5aa4ed54be054ea Reviewed-on: https://code.wireshark.org/review/16253 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-03ICMP: Avoid "no response found" for multicast pingJoão Valverde1-1/+9
Ping-Bug: 12581 Change-Id: I6943d275de988e9de66bc01e2b421901947a5b95 Reviewed-on: https://code.wireshark.org/review/16252 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-03DOCSIS: Update to Type 35 UCDAdrian Simionov1-19/+25
Change-Id: Ie0dda94894cfaec9bccbd69d52367034e1c629da Reviewed-on: https://code.wireshark.org/review/16242 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-03Support for NSH with VXLAN-GPE encapsulationsjha31-0/+4
Bug: 12271 Change-Id: I8481c4ab69c4432985acc79bff7818e6857fa1cb Reviewed-on: https://code.wireshark.org/review/16251 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-02Qt: add initializer (CID 1159352).Dario Lombardo1-1/+2
Change-Id: Ie355a31284685ca0c160a46a4daa6c28b39e3093 Reviewed-on: https://code.wireshark.org/review/16247 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-02Qt: remove unneeded check (CID 1159309).Dario Lombardo1-1/+1
fi has already been checked in line 51. Change-Id: Idd4d09a35ef1d4897479538979debd708e2cfe5b Reviewed-on: https://code.wireshark.org/review/16246 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-02Qt: Fixup byte view context menusGerald Combs1-3/+5
Shorten text similar to other context menus. Change-Id: I8806ed4dddb6fc3c51ddbd4150d9090f5b2ca787 Reviewed-on: https://code.wireshark.org/review/16238 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-02BGP: Fixed an side effect of length coding on offsetMatt Texier1-2/+2
Bug: 12568 Change-Id: Ibf063293041d749664f6e6ecd2455024ea3fd4ed Reviewed-on: https://code.wireshark.org/review/16237 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-02packetbb: Prevent divide by 0.Michael Mann1-6/+8
Bug: 12577 Change-Id: Ibfa605597b786d8dbf1e256ef2ca6dc691498974 Reviewed-on: https://code.wireshark.org/review/16241 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-02proto.c: allow calling get_hfi_length() with a 0 byte tvb and length=-1Pascal Quantin1-1/+1
As indicated in the comment, we allow FT_PROTOCOL, FT_NONE, FT_BYTES, FT_STRING and FT_STRINGZPAD to be zero-length. But in that case do not call tvb_ensure_captured_length_remaining() that ensures that at least 1 byte is present. Bug: 12561 Change-Id: I881754368c24d334b88f0dda1d59a68e08219227 Reviewed-on: https://code.wireshark.org/review/16167 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-01ZigBee Green Power: implement GP Pairing Configuration command dissection.dsrsupport1-2/+350
Change-Id: I539e98935699e5be8f91daaebade00f22b500dbc Reviewed-on: https://code.wireshark.org/review/16235 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-01Don't leak a file descriptor when changing the SSL debug file name.Jeff Morriss1-1/+4
I guess people don't change the SSL debug file name that often--this bug has been here since 2006... Change-Id: I3db053dd7e0cb9a9e4ae49a310e956b3c77c99f6 Reviewed-on: https://code.wireshark.org/review/16236 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-01fix missing fields for json, ek and pdml when used with -e fieldsHessam Jalali1-16/+21
Description: when -T json,ed or pdml used in conjunction with -e fields they would always miss the last field. in case of json and ek, if some fields in the middle are empty, the generated json would be invalid. sample for ek: { "_index": "packets-2016-06-30", "_type": "pcap_file", "_score": null, "_source": { "layers": { "e212.mcc": ["255","262"] "frame.time_epoch": ["1426550400.004751510"], "e212.mnc": ["1","1"] } } } command: tshark -T ek -r C:\a.pcap -e e212.mcc -e frame.comment -e frame.time_epoch -e e212.mnc > C:\test.json note: the comma is missing between e212.mcc and frame.time_epoch Change-Id: I2efae0c48036cf6313e2a064453c8dbc49f38b09 Reviewed-on: https://code.wireshark.org/review/16226 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Kacer <kacer.martin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-01Cleanup LAPD preferences and registration handoff routineJaap Keuter1-25/+18
The preferences and the registration handoff routine used to handle preference changes are setup inconsistent and less efficient. This change cleans it up. Change-Id: I9a1d51d8924c30d9e86d8af394ab1f0f31da4d2d Reviewed-on: https://code.wireshark.org/review/16208 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-01ASN.1 dissectors - don't try to find yourself.Michael Mann68-348/+280
If an ASN.1 dissector is calling register_dissector for itself in its proto_register_xxx function and then calling find_dissector for itself in its proto_reg_handoff_xxx function then just create a static handle for that dissector and use the return value of register_dissector, so the find isn't necessary. Change-Id: I911bdadc2fb4259601c141b955e741a2369cc447 Reviewed-on: https://code.wireshark.org/review/16233 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-01s7comm: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+0
Change-Id: I296d11ec43b3817d30920432239632f86b9f773f Reviewed-on: https://code.wireshark.org/review/16227 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Thomas Wiens <th.wiens@gmx.de> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-01Qt: Add ASCII+EBCDIC actions to the byte view context menu.Gerald Combs3-10/+35
Add actions to switch between ASCII and EBCDIC, similar to the hex and bits items. Bug: 5298 Change-Id: Ib601ac6e89411e6482f3e4172726e16a08fdbd2b Reviewed-on: https://code.wireshark.org/review/16225 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-01Qt+Gtk: Fix the -t command line flag.Gerald Combs8-15/+37
Add the time format to commandline_param_info_t and apply it when we've finished application initialization. Bug: 12489 Change-Id: Ice626198a610567e945a8e53c0c1093797e8208e Reviewed-on: https://code.wireshark.org/review/16232 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-01exported_pdu(.h): Fix warning: parameter 'tag_type.' not found in the ↵Alexis La Goutte1-2/+2
function declaration [-Wdocumentation] Change-Id: Ic93914a7f526b645bc21a5c9c5f2fa0bf988c27e Reviewed-on: https://code.wireshark.org/review/16230 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-30802.11 radio: fix an out of bounds accessPascal Quantin1-1/+1
Bug: 12571 Change-Id: I4dafdd9bdec5acddf346fd2db6a06d9dfabcbb2e Reviewed-on: https://code.wireshark.org/review/16228 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-30Speed up print_line_text.Gerald Combs2-24/+20
isatty adds a small delay, at least on OS X. Call it only when we allocate a stream. Do the same for our codeset check. Change-Id: Id3a20059dbc9cf7d5db16d8d238d038b9de0ebf2 Reviewed-on: https://code.wireshark.org/review/16222 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-30NAS EPS: upgrade dissector to v13.6.0Pascal Quantin2-347/+912
Change-Id: Ie27ce7481b9730ad8da0d465ed1c2bc373d4b602 Reviewed-on: https://code.wireshark.org/review/16224 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-30Reinstate the wmem test-programs target.Jeff Morriss1-0/+2
It's used when building the test programs (today wmem has only one but it might someday have more). Change-Id: I627513e1297b8348bf034e852eaf212ddbef96ff Reviewed-on: https://code.wireshark.org/review/16221 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-06-30Add missing breaks.Gerald Combs1-1/+3
Add a couple of missing breaks. Fixes CIDs 1362970 and 1362971. Change-Id: If37bcfed9b48ba30ce8ed85df6e232a6bc5d36f4 Reviewed-on: https://code.wireshark.org/review/16223 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-30Recompress PNGs.Gerald Combs311-7/+29
Recompress PNGs using the current versions of various compressors: optipng 0.7.6 advpng 1.20 advdef 1.20 pngcrush 1.8.1 Parallelize PNG compression. Note why we're not using a couple of other compression utilities. Change-Id: I52757d0bc2d424013e7f00b693a0f5378427cc31 Reviewed-on: https://code.wireshark.org/review/16209 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-30Remove Makefile.common filesJoão Valverde296-11440/+8122
Now that nmake build system has been removed they are not needed anymore. Change-Id: I88075f955bb4349185859c1af4be22e53de5850f Reviewed-on: https://code.wireshark.org/review/16050 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-06-30SDP: Fix warnings [-Wcast-qual]João Valverde1-3/+3
Change-Id: I471c3d060ff69982e94c9046ca121bb0c15f0d74 Reviewed-on: https://code.wireshark.org/review/16212 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-06-30Qt: Show the correct data in the packet dialog.Gerald Combs1-1/+2
Set our pointers and copy our data *after* we read our packet. Bug: 12556 Change-Id: I5b373f94ad5b2fa2e6563142200a80912e717a96 Reviewed-on: https://code.wireshark.org/review/16211 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-06-30BGP dissector: Fixing NLRI length for flow spec NLRIMatt Texier1-1/+1
Bug: 12568 Change-Id: Id2b89c2d133865771e21acf3ee224f57ac9d262b Reviewed-on: https://code.wireshark.org/review/16203 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-06-30remove Wireshark.pro, modify update-tx accordinglyMartin Kaiser3-643/+3
Wireshark.pro is the qt project file used by qmake which in turn was used by nmake now that nmake is gone, the only reason to keep Wireshark.pro was the update-tx script that syncs our translation files with Transifex update-tx calls lupdate to create a list of texts to translate and lrelease to convert such a list into a binary file lupdate and lrelase can read file names from a project file or get them on the command line modify update-tx to pass the required file names on the command line we can use wildcards so there's no need to change update-tx when a new source file is added remove Wireshark.pro from the release tarball as well Change-Id: I7ff4ebc96f13b4ffc6fb1b2f4e045999fbfbed5e Reviewed-on: https://code.wireshark.org/review/16151 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-06-30Pass the format as an argument to write_specified_fields().Guy Harris1-13/+9
That makes failing to specify a format a compile-time error. Change-Id: Iff0bda8be35b1e3acc97e4314657ceaff2b3d0be Reviewed-on: https://code.wireshark.org/review/16218 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-30Mention autotools, give some information for other UN*Xes.Guy Harris1-3/+23
For OS X, mention the use of CMake or autotools for building. For Linux, mention autotools as well as CMake, and speak of Debian derivatives other than Ubuntu. Add a section for UN*Xes other than OS X and Linux. Change-Id: I73bb7afe2d427333b10016aeb497ab32eee16d43 Reviewed-on: https://code.wireshark.org/review/16217 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-30ui/qt/i18n.qrc is a generated file; ignore it.Guy Harris1-0/+3
Change-Id: Ifc8b45d42d9dbf9560ec825e3ce1784534df7b3b Reviewed-on: https://code.wireshark.org/review/16216 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-30Remove unused edt field from print_data structure.Guy Harris1-3/+0
Change-Id: I5778b08c52119b5be1ec482be9417b3c4ba8ed62 Reviewed-on: https://code.wireshark.org/review/16215 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-29Get rid of unused edt member in write_pdml_data structure.Guy Harris1-2/+0
Change-Id: I2a41d378187c1685afb701372cf3a8ec9c0aeb70 Reviewed-on: https://code.wireshark.org/review/16214 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-29Remove unused edt member from write_json_data structure.Guy Harris1-3/+0
Change-Id: Id8b45715c753dc6006f7833e5f49bd8aabc15271 Reviewed-on: https://code.wireshark.org/review/16213 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-29Fix -T fields, broken by ceae9e4d1fff4500b285dba021c3f239ff87779e.Guy Harris1-27/+49
Rename write_fields_proto_tree() to write_specified_fields(), and make it static. Make write_fields_proto_tree() a wrapper around write_specified_fields() that sets the format to FORMAT_CSV. Have write_specified_fields() fail with an assertion if fields->format isn't one of the known formats, to catch problems such as this in the future. Don't fill in the "data" structure if we're not going to use it. Change-Id: I11dbf448d72ca389f0e5fb8558a41b7eecf7c9a4 Reviewed-on: https://code.wireshark.org/review/16210 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-07 17:07:54 +0000