aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2015-12-06[Automatic update for 2015-12-06]Gerald Combs17-1714/+2183
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I70fd3f5a9f8f53ea6a086b521c8f05d33815516f Reviewed-on: https://code.wireshark.org/review/12450 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-12-06Qt: No path for created and renamed profilesStig Bjørlykke3-16/+44
The path is not valid for created and renamed profiles because the directory is not created yet. Use this label as a info label to describe where the profile is created from or renamed from instead. Use correct path for the Default profile. Removed Bold from the current profile in status bar list. Added tooltip for system provided profiles. Change-Id: I61c8b1cc811dd9f9419ff9e373a8d00aa4e30446 Ping-Bug: 11704 Reviewed-on: https://code.wireshark.org/review/12447 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-06SCTP: It is odd that the body of dissect_heartbeat_ack_chunk' function is ↵Michael Tüxen1-3/+5
fully equivalent to the body of 'dissect_heartbeat_chunk' function found by PVS Studio (V524) This is just a cosmetic change, which makes sense. No funtional change. Change-Id: Id24d162379093207863608e70f405e66f789276c Reviewed-on: https://code.wireshark.org/review/12440 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Tüxen Reviewed-by: Michael Tüxen <tuexen@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2015-12-05Type cleanups.Guy Harris3-9/+10
dfilter_macro_apply_recurse() returns either NULL or a pointer to freshly-allocated memory, so it doesn't return a const pointer. dfilter_macro_apply() calls dfilter_macro_apply_recurse(), so it doesn't return a const pointer, either. In dfilter_compile(), have separate variables for the filter handed in and the macro-expanded filter, the former being const gchar * and the latter being gchar *. Change-Id: I191549bf0ff6c09c1278a98432a907c93d5e0e74 Reviewed-on: https://code.wireshark.org/review/12446 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Undoing base-64 encoding is not decryption.Guy Harris1-12/+12
For now, we don't change the name of the preference, but we *do* change the description of the preference and the name of the variable. Change-Id: I1f80b2e7187679dca787fda5f3d06e9d30536ddc Reviewed-on: https://code.wireshark.org/review/12444 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Revert "Build Flex-generated files with "warnings are errors"."Guy Harris9-61/+109
This reverts commit b56f53884be3bab935058b2bbbb4da0b8bbbe7f6. Sadly, we *do* get warnings at this point with older versions of Flex, such as the one on the 32-bit OS X buildbot. Change-Id: I9aec1a16e9f2e1bbcfaac3dffdabdd89af5815e3 Reviewed-on: https://code.wireshark.org/review/12443 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Fix for bug 11856:Andreas Urke1-1/+1
Correct parameter-name "opt-offset" to "offset" in macro "tvb_eui64_to_str" in epan/to_str.h such that offset is taken into account when converting eui64 to str. Bug: 11856 Change-Id: Id0b17c4b9186b4c41d6fe338ba7c017e88f63acf Reviewed-on: https://code.wireshark.org/review/12441 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-05Add missing table entry.Michael Tüxen1-0/+1
Add a missing table entry for Stream Reset Response parameters. Change-Id: I45172cace57cd3f628a94fd61c4cb37a6c2e17ed Reviewed-on: https://code.wireshark.org/review/12439 Reviewed-by: Michael Tüxen Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05RTPS: Minor improvementsJuanjo Martin1-49/+53
1) Fixed the guidPrefix deserialization (before it was showing counter and it should be instanceId). 2) The PID_PARTICIPANT_GUID was a total mess. Now it looks perfect. 3) Fixed some bounds in the proto_tree creations so instead of selecting the rest of the tvb, now they select what they have to. Did all of this keeping the dissection for version 1 untouched. Change-Id: I93df2a29e292655ceb3f8c1395f31d8e38106dee Reviewed-on: https://code.wireshark.org/review/12406 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05Build Flex-generated files with "warnings are errors".Guy Harris9-109/+61
We shouldn't be getting warnings at this point. Change-Id: I363a48546cb8d916425f42962ae1697d52ed9a29 Reviewed-on: https://code.wireshark.org/review/12436 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05packetbb: fix the display of IPv4 addressesLotte Steenbrink1-1/+2
IPv4 Addresses are currently displayed incorrectly in RFC5444 Addressblocks. For example, what should be `Address: 10.1.3.0` is incorrectly rendered as Address: 0.0.0.10 This commit fixes that. Bug: 11852 Change-Id: Id6dc954e9a06e79375058f6070fe8e0f64167d64 Reviewed-on: https://code.wireshark.org/review/12429 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05BGP: fix some issueMatt Texier1-5/+22
Fixing ESI Label extended community Fixing PMSI label field decoding on 20 bits Fixing inclusive multicast Ethernet tag route Fixing Ethernet segment route Bug: 11650 Change-Id: Ifadcc3099f681a5c9480d1ccdd50b29ef4c0069f Reviewed-on: https://code.wireshark.org/review/12430 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05ECMP: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-21/+18
Change-Id: Idd57cba39e82a2538bd8a8ceb2263ec23202c25a Reviewed-on: https://code.wireshark.org/review/12424 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05Enhancements for EtherNet/IP and CIPD. Ulis3-62/+162
EtherNet/IP 1. EtherNet Link object parsed Physical Address attribute response incorrectly. 2. Display Unknown Commands as ENIP instead of just TCP data. CIP 1. For connected data, don't interpret it as a Message Router Request/Response format when the Forward Open connection was not directed to the Message Router. Previously, this data would be incorrectly shown as explicit CIP data. In many cases, this would show as malformed. This traffic will now just display as Data in the Wireshark tree, and "Implicit Data - Class (0x123)" in the Info column. Make this data filterable by "cip.conn_path_class == 0x123". 2. Fix parsing of Unconnected Send responses. Previously, for most cases, the response was not fully parsed, and would just show "Data", or it would parse the response as if the request class was the Connection Manager, which is incorrect. Now, also show the request path of the original embedded message in the tree. 3. Add some detailed error data for malformed Forward Close response. Change-Id: I1c98ce516373d8c0ed6e049e25342f726bc370ea Reviewed-on: https://code.wireshark.org/review/12339 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: D. Ulis <daulis0@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05ECMP: fix indentAlexis La Goutte1-185/+189
Change-Id: I80e664185a34feaebc05fc089c405e658e3b1e60 Reviewed-on: https://code.wireshark.org/review/12423 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-05Remove a remnant of the old removed support for Python dissectors.Guy Harris1-1/+1
Change-Id: Ib5dcfc3b6ed08310b5aa8ddc3e08a0951f24bbb4 Reviewed-on: https://code.wireshark.org/review/12434 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Use noyywrap rather than defining our own yywrap functions.Guy Harris13-116/+62
Tweak lemonflex-tail.inc to fix an issue this reveals. It appears that, at least on the buildbots, the Visual Studio compiler no longer issues warnings for the code generated with %option noyywrap. Change-Id: Id64d56f1ae8a79d0336488a4a50518da1f511497 Reviewed-on: https://code.wireshark.org/review/12433 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-04CMake+PortableApps: Include the VC runtime (second try).Gerald Combs6-18/+42
Move the code that finds the Visual C++ redistributable DLLs to its own module. Run it before we create our NSIS and PortableApps targets. Add a PortableApps target that copies the redistributable This reverts commit 403fa9fbe0cdba3f443ec4674cda40092525ffe4. Bug: 11800 Change-Id: I081d8fd3f5f37dd590659ca8f2bd309642a9a9df Reviewed-on: https://code.wireshark.org/review/12431 Reviewed-by: Gerald Combs <gerald@wireshark.org> (cherry picked from commit 5b580834aeeee8477039bc099c49c21aeeb3b71f) Reviewed-on: https://code.wireshark.org/review/12432 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2015-12-04Export prefs_register_module() and prefs_register_subtree() functionsPascal Quantin1-2/+2
Change-Id: I09796eadb5fb8b564adfab5060715571983b1bb3 Reviewed-on: https://code.wireshark.org/review/12428 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-04[packet-h] Add defines to make it possible to convert functions prefixedAndersBroman2-6/+9
with new_ to plain function names without changing all at the same time. Change-Id: I52682996704ff2472c9830bb62fda2a3cbef6589 Reviewed-on: https://code.wireshark.org/review/12401 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-04Qt: fix a potential memory leak in RTP audio stream playbackPascal Quantin1-1/+1
Change-Id: I6847f85d56841f99594063bfb7441d0c40e452a7 Reviewed-on: https://code.wireshark.org/review/12425 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-04codecs: fix libary name when compiling with CMakePascal Quantin1-1/+1
Change-Id: I0ef328ac9a1fd7281267dbb7f9d1ace97ab41071 Reviewed-on: https://code.wireshark.org/review/12422 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-04Adds wmem_list_find functionMatthieu Coudron2-0/+20
Change-Id: I72162210b830a57978e108032d75d8c54f17d16b Reviewed-on: https://code.wireshark.org/review/12387 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-04More libcodecs -> libwscodecs.Guy Harris1-2/+2
Change-Id: I861c625a4bf36ec8bddebec483f43cf6b3cd7c09 Reviewed-on: https://code.wireshark.org/review/12421 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-04More libcodecs -> libwscodecs.Guy Harris6-23/+23
Change-Id: Ieb0bb131b6d141bf85997c9a0127e0eb11ea3a3b Reviewed-on: https://code.wireshark.org/review/12420 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03Change codecs from static to dynamic libraryPascal Quantin17-108/+252
This allows to properly register codecs plugins. See https://www.wireshark.org/lists/wireshark-dev/201511/msg00202.html for details. Change-Id: Ibc13a19936abb7a2e81b86582a75fa424351565b Reviewed-on: https://code.wireshark.org/review/12385 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03Modify application description of Wireshark in Korean. The transliteration ↵Shinjo Park2-2/+2
"네트워크" and "네트웍" is mixed in single file, but the former is standard notation. Change-Id: Ie67a449a2269daef33c627bd4cf77434eeacf22b Reviewed-on: https://code.wireshark.org/review/12418 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03Make the gauntlet a bit clearer.Guy Harris1-3/+2
if(is a fixed-length TDS type) { XXX } else if(is a variable-length TDS type) { XXX } Change-Id: Icaa8047ad76abe8b955fb5a025a057ddf8757b1f Reviewed-on: https://code.wireshark.org/review/12415 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03qt: Refresh local interface list only when interfaces added/removedMikael Kanstrup1-9/+1
Whenever data is received on the iface monitor socket the list of local network interfaces is refreshed. No check whether an interface is really added/removed is done. Changes to network interface options like promiscous mode flag generate traffic on the iface monitor socket that not necessarily mean an interface was brought up or down resulting in an unwanted refresh of local interfaces. When local interfaces are refreshed selected capture interface(s) get deselected. This in turn makes "Restart current capture" fail with a no capture interface selected error. Fixed by moving the refresh action from socket monitor callback to iface monitor callback where interface up/down status is known. Bug: 11834 Change-Id: Iffd39c3240049880b5a8311bc6484f3d1433f387 Reviewed-on: https://code.wireshark.org/review/12317 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03Qt: Update menus with new recent settings when changing profileStig Bjørlykke4-23/+43
Update all View options to new recent settings to reflect the changes. Also show/hide toolbars and packet panes accordingly. Change-Id: Idb07bd5c51c01810b1f4467d2401936dc533731b Reviewed-on: https://code.wireshark.org/review/12405 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-03Qt: Set timestamp precision when changing profileStig Bjørlykke1-0/+1
Change-Id: I85622a8e2689283017ba038ce61d98e22f1c1af3 Reviewed-on: https://code.wireshark.org/review/12403 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-03[MP2T] Reading buffer should have MP2T_SIZE+TRAILER_LEN_MAX space to give ↵Michael Mann1-1/+1
room for non-zero trailer. Bug: 11820 Change-Id: I7e0a603c20ca0c524399beb3d89e14c45dc3a06e Reviewed-on: https://code.wireshark.org/review/12393 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Qt: Disable setStretchLastSection in the packet list.Gerald Combs1-0/+18
QTreeView sets the stretchLastSection property of its header by default. In our case this means that if the sum of our recent column widths exceeds the width of the packet list viewport QHeaderView will shrink the last column to fit. Disable setStretchLastSection. We want its behavior when our columns are too narrow so check for that in ::showEvent and temporarily enable it there. Bug: 11738 Change-Id: Ia4aad63e4f4bf899891bcebb7032dc5ebeb74cc7 Reviewed-on: https://code.wireshark.org/review/12392 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03TDS: Sanity check number of columns to prevent crash.Michael Mann1-0/+4
Bug: 11846 Change-Id: I6eac46dc397263fe005e803730c5d3084bfb7f74 Reviewed-on: https://code.wireshark.org/review/12391 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Qt: Set main window font when changing profileStig Bjørlykke1-2/+2
The font is part of the preferences. Change-Id: Ibcdf1c06e92fc43547825b5fea9560e904003081 Reviewed-on: https://code.wireshark.org/review/12386 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Qt: Check display filter when changing profileStig Bjørlykke5-5/+14
The Display Filter Macros may have changed and if a macro is currently used in the display filter then cf_redissect_packets() will bail out in an assert if trying to apply an invalid filter. Change-Id: I842016360672d76d190454ce80ccc7604f2075b3 Reviewed-on: https://code.wireshark.org/review/12388 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Qt: fix selection of folder in UAT dialogPascal Quantin1-3/+10
Using getOpenFileName() even with ShowDirsOnly option does not work. Let's use the dedicated getExistingDirectory() method instead. Bug: 11842 Change-Id: Ie22c4c479005467dbf64d9a90a8f3b82d355d495 Reviewed-on: https://code.wireshark.org/review/12384 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Fix address hashing broken in g4f39c60Evan Huus8-32/+32
We actually have to *use* the return value of the method, which the macro did for us. Change-Id: I240ca7e526a18054fe39c6c4ded902998dc2fef0 Reviewed-on: https://code.wireshark.org/review/12389 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-12-02sctp_chunk_stat_dlg: fix The 'u_data->assoc' variable is assigned values ↵ruengeler1-2/+0
twice successively. found by PVS Studio (V519) Change-Id: I01ac47693279b5681c40287f12a63ef767c9ad74 Reviewed-on: https://code.wireshark.org/review/12382 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-02L2TP: define the Cisco ACK control messageNicolas S. Dade1-2/+9
This is a common packet when sniffing Cisco routers performing L2TP with their proprietary AVPs. Change-Id: I8093f7e3ceb39c9af5b6292289c55f705b53dffb Reviewed-on: https://code.wireshark.org/review/12368 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-02OSTIP: fix typo found by PVS Studio (V519)Alexis La Goutte1-1/+1
The 'pinfo->clnp_dstref' variable is assigned values twice successively Change-Id: I02b8ae54728f88c2173b4522d436bd2f7b1b7bc0 Reviewed-on: https://code.wireshark.org/review/12365 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-02L2TP: fix typo: s/zero length bit/zero length body/Nicolas S. Dade1-4/+4
A "ZLB" message is a Zero Length Body message. See RFC 3931 Change-Id: I89d8f2328754e236f0704f851831fd8274f3b99e Reviewed-on: https://code.wireshark.org/review/12366 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-02ui: Guard update_local_interfaces with HAVE_LIBPCAPStig Bjørlykke2-0/+4
Change-Id: I276193047e37cf581fd42ccc74ff9131ee4fa055 Reviewed-on: https://code.wireshark.org/review/12377 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-02L2TP: show unsigned value of control connection idNicolas S. Dade1-1/+1
Everywhere else in the l2tp packet tree we show the control connection ID as an unsigned decimal. Change-Id: I189b9ce8c56b024a249d18fc62641c2f5283b0c1 Reviewed-on: https://code.wireshark.org/review/12367 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-02ui: Update interfaces when when changing profile.Stig Bjørlykke4-21/+62
The interfaces preferences are different for each profile so ensure we update the interface settings when changing profile. This bug was introduced in version 1.8.0. Change-Id: Icf22670875e01bab6204c300ddc7fb8aeb3dcecf Reviewed-on: https://code.wireshark.org/review/12363 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-02Qt: Use uniform interface display nameStig Bjørlykke4-44/+54
Use common function to generate the interface display name, both when scanning for interfaces (scan_local_interfaces()) and when changing Comment in the Manage Interfaces dialog. Change-Id: I3260208856563aaf387ce397d4ae61bddcc89b4f Reviewed-on: https://code.wireshark.org/review/12362 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-02[SUA] Change the dissector table sua.prop.tags to use ↵AndersBroman1-1/+1
DISSECTOR_TABLE_ALLOW_DUPLICATE Change-Id: Iaabd69e5779534c1cf73b2c1ab1b957bb30c44d3 Reviewed-on: https://code.wireshark.org/review/12373 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-02PCP: Use GLib 2.32 < supported hash functionsRyan Doyle1-1/+1
GLib 2.32 is required for use of g_hash_table_contains function Change-Id: Ia2af2868ab1029d392d921d915b8898fb5ec81a4 Reviewed-on: https://code.wireshark.org/review/12361 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02PCP: Implement PMID to name mappingRyan Doyle1-22/+196
Tracks the interation between PMNS_NAMES and PMNS_IDS packets to build up a mapping from PMID to a text name and displays the name whenever the PMID is displayed. Change-Id: I665b293c32fee95b649fe6a6e26989db1eff38e0 Reviewed-on: https://code.wireshark.org/review/12303 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-02btatt - make size 32-bit in get_value()Michael Mann1-2/+2
Bug: 11817 Change-Id: I118ff55f9a709167976a2522114d65ec03fc68c5 Reviewed-on: https://code.wireshark.org/review/12353 Reviewed-by: Guy Harris <guy@alum.mit.edu>