aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-04-02Rename cf_not_saved() to cf_has_unsaved_data() to clarify what itGuy Harris5-8/+8
indicates. (Note: "unsaved data" is more than just "unsaved changes"; it could also mean "temporary file that hasn't been saved anywhere".) svn path=/trunk/; revision=48709
2013-04-02Handle the case of there being no comment view.Guy Harris1-9/+11
svn path=/trunk/; revision=48708
2013-04-02Show the comment area only if we could write out the comments were theGuy Harris1-20/+22
user to enter any. svn path=/trunk/; revision=48707
2013-04-02use proto_mpeg_descriptor_loop_dissect() for the EITMartin Kaiser1-5/+2
svn path=/trunk/; revision=48706
2013-04-02use proto_mpeg_descriptor_loop_dissect() in the BATMartin Kaiser1-7/+3
svn path=/trunk/; revision=48705
2013-04-02use proto_mpeg_descriptor_loop_dissect() for the PMTMartin Kaiser1-8/+3
svn path=/trunk/; revision=48704
2013-04-02use proto_mpeg_descriptor_loop_dissect() for the TOTMartin Kaiser1-4/+2
svn path=/trunk/; revision=48703
2013-04-02Include padding length in the AVP's length.Jeff Morriss1-28/+27
svn path=/trunk/; revision=48702
2013-04-02An explicit cast that was missing; at least some version of GCCGuy Harris1-1/+1
complains about its absence with -Wc++-compat. svn path=/trunk/; revision=48701
2013-04-02Dissect more 3GPP2 extensions.Anders Broman1-14/+60
svn path=/trunk/; revision=48700
2013-04-02Only enable Edit->Packet Comment... if we can save the file withoutGuy Harris1-1/+1
losing the packet comments, just as we now do in the GTK+ version. svn path=/trunk/; revision=48699
2013-04-02From Sebastiano Di Paola via ↵Evan Huus1-27/+116
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8461 Enhancements for the Honeypot Feeds dissector. From me: misc. cleanup, modelines, etc. svn path=/trunk/; revision=48698
2013-04-02From Vineeth via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8450 :Pascal Quantin1-2/+4
Do not try to systematically fetch a third digit for Country Code: its length can be from 1 to 3 digits. svn path=/trunk/; revision=48697
2013-04-02Add support for the initial direction indication. Irene will hookMichael Tüxen2-6/+38
it up to the GUI soon. svn path=/trunk/; revision=48696
2013-04-02Remove non ASCII charactersPascal Quantin1-4/+4
svn path=/trunk/; revision=48695
2013-04-02Dissect more of 3GPP2_OBJECT.Anders Broman1-6/+117
svn path=/trunk/; revision=48694
2013-04-01Add routines to file.c to indicate whether:Guy Harris7-90/+142
a save can be done ("can" in the sense of "there's something to save" and in the sense of "we can write that something out"); a "save as" can be done (in the sense of "we can write what we have out"); there's unsaved data to save (which might be unsaved changes or might be a temporary file full of packets); and use them as appropriate. This means that the "unsaved data" indicator in the UI will be turned on for temporary files full of packets as well as for files with unsaved changes; that's what we want. svn path=/trunk/; revision=48693
2013-04-01If we can't write the capture out in a file format that supportsGuy Harris1-1/+1
per-packet comments, don't let the user add/edit/delete per-packet comments - they can comment all they want, but once Wireshark closes the file, those comments will be gone. svn path=/trunk/; revision=48692
2013-04-01In the Lua dumper code, don't bother checking whether the encapsulationGuy Harris3-32/+51
is supported before trying to open for writing - the attempt to open for writing will do the check for you. Instead, check for specific errors if the attempt to open for writing fails, and use somewhat more specific error messages for certain error codes. (We should perhaps check for even more error codes in those cases.) That gets rid of all external calls to wtap_dump_can_write_encap(), so remove it from wtap.h and make it static. svn path=/trunk/; revision=48691
2013-04-01Add a wtap_dump_can_write() routine that indicates whether WiretapGuy Harris6-62/+72
supports writing files with a given set of encapsulations and comment types. Use it, rather than asking for a list of file formats that support the given set of encapsulation and comment types and checking whether we got back such a list, or duplicating its logic. Having file.c use it means that nobody's using wtap_dump_can_write_encaps() any more; get rid of it. Instead, have a private routine that checks whether a given file format supports a given set of encapsulations *and* comment types, and use that internally. svn path=/trunk/; revision=48690
2013-04-01Define a collection of bits for different types of capture file comments.Guy Harris7-201/+329
For each capture file type, have a bitset of comment types supported by that capture file type. Add a Wiretap routine that, for a given file type, returns the bitset of comment types it supports. Have wtap_get_savable_file_types() take a bitset of comment types that need to be supported by the file types it returns. Replace cf_has_comments() with a routine that returns a bitset of capture file comment types in the capture file. Use those routines in the capture file dialogs; don't wire in the notion that pcap-NG supports all comment types and no other file formats support any comment types. (That's currently true, but we don't want to wire that in as being forever true.) svn path=/trunk/; revision=48689
2013-04-01Add a setTitlebarForCaptureInProgress() method to MainWindow, and use itGuy Harris3-1/+21
to set the title when we have a capture in progress. svn path=/trunk/; revision=48688
2013-04-01Get rid of main_capture_set_main_window_title(), as it just wrapsGuy Harris1-8/+2
set_titlebar_for_capture_in_progress(); make the call directly, to make it a bit clearer when it needs to be called (which helps us do the equivalent in the Qt version). svn path=/trunk/; revision=48687
2013-04-01Now only if I can get the case right :)Jaap Keuter1-1/+1
svn path=/trunk/; revision=48686
2013-04-01Typo's. That is all.Jaap Keuter15-49/+49
svn path=/trunk/; revision=48685
2013-04-01Fix for bug 8548:Jaap Keuter1-32/+29
Allow the IRC command and response dissection functions to be called with subsets of the original (full) message line. Therefore we need to calculate with real lengths and offsets, not mixed with lengths of the subset itself. svn path=/trunk/; revision=48684
2013-04-01Move the knowledge about what the window title should be toGuy Harris5-35/+51
ui/gtk/main_titlebar.c, with set_titlebar_for_capture_file() for either no capture file or an opened capture file and set_titlebar_for_capture_in_progress() for an in-progress capture. svn path=/trunk/; revision=48683
2013-03-31Add a setTitlebarForCaptureFile() and have it set the titlebar and theGuy Harris3-4/+22
"modified" indicator. For some reason, it's not getting called in all the right places. svn path=/trunk/; revision=48682
2013-03-31Unused parameter.Anders Broman1-1/+1
svn path=/trunk/; revision=48681
2013-03-31Rename set_display_filename() to set_titlebar_for_capture_file(), asGuy Harris3-5/+6
it affects more than just the file name, it also affects whatever "you have unsaved changes" indicator the UI provides. Put a comment in the Qt code as a reminder of how to set the "you have unsaved changes" indicator. svn path=/trunk/; revision=48680
2013-03-31Initial decoding of 3GPP2_OBJECT.Anders Broman1-3/+80
svn path=/trunk/; revision=48679
2013-03-31coverity 281315 logically dead codeMartin Kaiser1-6/+1
svn path=/trunk/; revision=48676
2013-03-31coverity 990813 dereference after null checkMartin Kaiser1-2/+3
(hope I got it right this time) svn path=/trunk/; revision=48673
2013-03-31[NPL] Pushing changes to wireshark repoJakub Zawadzki3-245/+585
- parser no longer use abort() after failing - initial support for attributes - symbol hashing to avoid strcasecmp() - misc other fixes svn path=/trunk/; revision=48672
2013-03-31[Automatic manuf, services and enterprise-numbers update for 2013-03-31]Gerald Combs4-159/+474
svn path=/trunk/; revision=48671
2013-03-31remove empty else-branchesMartin Kaiser1-6/+3
svn path=/trunk/; revision=48670
2013-03-31TABs -> spacesMartin Kaiser1-981/+994
add editor modelines svn path=/trunk/; revision=48669
2013-03-31Add missing </endlist>.Guy Harris1-0/+1
svn path=/trunk/; revision=48668
2013-03-31Don't bundle "Open" and "Import" together; again, clarify that "Import"Guy Harris2-5/+22
is a somewhat limited function. svn path=/trunk/; revision=48667
2013-03-31Reflect the new menu item for the dialog box for importing a hex dumpGuy Harris2-5/+7
file (and note in more detail what it does). svn path=/trunk/; revision=48666
2013-03-31Make the menu item for importing a hex dump text file be "Import fromGuy Harris8-12/+12
Hex Dump", to clarify that it's not some sort of "generic" import function, just one that can read a hex dump file. ("Import from Hex Dump Text" is another possibility.) Use that string in the dialog title as well. svn path=/trunk/; revision=48665
2013-03-30From Hauke Mehrtens:Jaap Keuter1-1/+119
Wireshark misses some new TLS and DTLS cipher suite names which are assigned by IANA. svn path=/trunk/; revision=48664
2013-03-30Hopefully fix a false-positive warning in the Mac buildbot.Evan Huus1-1/+1
It complains that service_info may be used uninitialized, but my manual analysis agrees with GCC 4.7 that it can't, so just defaulting it to NULL will be fine. svn path=/trunk/; revision=48663
2013-03-30From Michal Labedzki via ↵Evan Huus2-6/+69
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509 Add basic support for Bluetooth GNSS profile. It uses NMEA-0183, but that is not free, so all we can do is add filtering and displaying for ASCII content. Also add colors for DUN, GNSS to show them in contrast to RFCOMM. svn path=/trunk/; revision=48662
2013-03-30From Michal Labedzki via ↵Evan Huus18-242/+199
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509 Unify bluetooth direction handling (sent vs rcvd). svn path=/trunk/; revision=48661
2013-03-30From Michal Labedzki via ↵Evan Huus7-408/+450
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509 Round 3 of Bluetooth SDP updates. Update the list of company IDs and fix service recognition. svn path=/trunk/; revision=48660
2013-03-30coverity 993742: potential division by zeroMartin Kaiser1-3/+6
svn path=/trunk/; revision=48659
2013-03-30fix indentation in one placeMartin Kaiser1-5/+6
svn path=/trunk/; revision=48658
2013-03-30coverity 280417: logically dead codeMartin Kaiser1-6/+1
svn path=/trunk/; revision=48657
2013-03-30From Tyson Key:Jaap Keuter1-4/+40
The attached patch adds support for dissection of SAMConfiguration request packets, and updates the opcode table to identify their corresponding (null/empty) responses. svn path=/trunk/; revision=48656