diff options
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 13605 |
1 files changed, 8928 insertions, 4677 deletions
@@ -1,8110 +1,12361 @@ ------------------------------------------------------------------------ -r15100 | lego | 2005-07-26 13:32:12 -0500 (Tue, 26 Jul 2005) | 7 lines -Changed paths: +r16192 | gerald | 2005-10-11 12:55:40 -0500 (Tue, 11 Oct 2005) | 159 lines +Changed paths: + M /releases/ethereal-0.10.13/capture.c + M /releases/ethereal-0.10.13/capture_loop.c + M /releases/ethereal-0.10.13/capture_opts.c + M /releases/ethereal-0.10.13/capture_sync.c + A /releases/ethereal-0.10.13/doc/README.malloc + M /releases/ethereal-0.10.13/doc/editcap.pod + M /releases/ethereal-0.10.13/doc/ethereal.pod + M /releases/ethereal-0.10.13/doc/tethereal.pod + M /releases/ethereal-0.10.13/docbook/Makefile + M /releases/ethereal-0.10.13/epan/Makefile.am + M /releases/ethereal-0.10.13/epan/dissectors/packet-cops.c + M /releases/ethereal-0.10.13/epan/dissectors/packet-h225.c + M /releases/ethereal-0.10.13/epan/dissectors/packet-h225.h + M /releases/ethereal-0.10.13/epan/dissectors/packet-h235.c + M /releases/ethereal-0.10.13/epan/dissectors/packet-h245.c + M /releases/ethereal-0.10.13/epan/dissectors/packet-h450.c + M /releases/ethereal-0.10.13/epan/dissectors/packet-h450.h + M /releases/ethereal-0.10.13/epan/dissectors/packet-per.c + M /releases/ethereal-0.10.13/epan/dissectors/packet-per.h + M /releases/ethereal-0.10.13/epan/dissectors/packet-xml.c + M /releases/ethereal-0.10.13/epan/dtd.h + M /releases/ethereal-0.10.13/epan/dtd_grammar.lemon + M /releases/ethereal-0.10.13/epan/dtd_parse.l + M /releases/ethereal-0.10.13/epan/dtd_preparse.l + M /releases/ethereal-0.10.13/epan/emem.c + M /releases/ethereal-0.10.13/epan/enterprise-numbers + M /releases/ethereal-0.10.13/file.c + M /releases/ethereal-0.10.13/gtk/capture_dlg.c + M /releases/ethereal-0.10.13/gtk/gui_utils.c + M /releases/ethereal-0.10.13/gtk/help_dlg.c + M /releases/ethereal-0.10.13/gtk/main.c + M /releases/ethereal-0.10.13/log.h + M /releases/ethereal-0.10.13/plugins/h223/packet-h223.c + M /releases/ethereal-0.10.13/tethereal.c + M /releases/ethereal-0.10.13/tools/asn2eth.py + +Copy over a bunch of fixes and updates from the trunk: + +cat !$ +cat ../sandboxes/svn.log +r16132: + M /trunk/epan/dissectors/packet-cops.c + +Don't try to strip the last byte from a zero-byte OID. Fixes bug 503. + +r16134: + M /trunk/gtk/main.c + +fix 369: we must do some more GUI stuff in capture_update_started(), +as GUI state get's cleared while switching to the next "multiple file" because of a call to cf_close() + +r16135: + M /trunk/capture_loop.c + +bugfix: reset the packet counter to zero, if switching to the next "multiple file". This fixes the live update of the packet output after switching to another capture file + +r16136: + M /trunk/file.c + M /trunk/gtk/gui_utils.c + M /trunk/gtk/main.c + M /trunk/log.h + +fix a packet_list_freeze / thaw pair, if a return comes in it's way +add a g_warning() call if an error occured while reading from capture file (while doing a live update), usually shouldn't happen but is difficult to debug *if* it happens +add a new log domain LOG_DOMAIN_MAIN and the standard log handler for it +add some (partly commented out) g_log() calls, useful for GUI sequence debugging + +r16137: + M /trunk/tethereal.c + +add missing #include "capture_errs.h" + +r16138: + M /trunk/doc/editcap.pod + +add missing -E parameter to the Options section + +r16141: + M /trunk/epan/dissectors/packet-per.c + +Octest string of (size 2) does not dissplay correctly. + +Handle multiple messages in a TCP segment, reassembly still needed. + +r16143: + M /trunk/epan/enterprise-numbers + +Update enterprise-numbers from http://www.iana.org/assignments/enterprise-numbers + +r16144: M /trunk/epan/emem.c - M /trunk/epan/emem.h - M /trunk/epan/libethereal.def - M /trunk/epan/tvbuff.c - M /trunk/epan/tvbuff.h -new functions: -ep_tvb_memdup() -ep_alloc0() -ep_strsplit() +ep_strndup and se_strndup do not have to expect strings to be null terminated. -add all of the ep_ allocators to libethereal.def +r16145: + M /trunk/epan/dtd_preparse.l ------------------------------------------------------------------------- -r15099 | gerald | 2005-07-26 13:28:01 -0500 (Tue, 26 Jul 2005) | 2 lines -Changed paths: - M /trunk/configure.in +remove file inclusion code altoghether and few other changes -Build randpkt by default. +r16147: + M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/dtd.h + M /trunk/epan/dtd_grammar.lemon + M /trunk/epan/dtd_parse.l + +remove location from dtd_build_data_t avoiding to (double) free it. + +r16148: + M /trunk/capture.c + +minor fix: fix the sequence while finishing a live capture, so the statusbar information about the file size is correct + +r16149: + M /trunk/capture_loop.c + M /trunk/capture_opts.c + M /trunk/capture_sync.c + M /trunk/doc/ethereal.pod + M /trunk/doc/tethereal.pod + M /trunk/gtk/capture_dlg.c + M /trunk/tethereal.c + +fix Ethereal so command line capture parameter will work with kilobytes (again) +remove Byte(s) from the dropdown list of filesizes, this doesn't make sense +replace 1000 with 1024, as all (modern?) file managers are based on 1024 bytes for a kilobyte (the old KB vs. KiB controversy) + +r16150: + M /trunk/gtk/main.c + +minor bugfix: while closing a capture file, update the packets statusbar *after* closing the file + +r16151: + M /trunk/plugins/h223/packet-h223.c + +Don't call "g_assert()" in dissectors - call "DISSECTOR_ASSERT()". + +r16153: + M /trunk/epan/dtd_parse.l + +"./dtd_parse.l", line 167: warning, rule cannot be matched + +the . matches one char as {special_char} does so {special_char} won't have been matched. change that for a non ">" + +r16154: + M /trunk/epan/dissectors/packet-xml.c + +do not free the element name, as its been passed to the hf array. + +r16157: + A /trunk/doc/README.malloc + +add initial better than nothing ep/se allocation documentation + +r16165: + M /trunk/doc/README.malloc + +Add some missing descriptions + +r16167: + M /trunk/epan/emem.c + +make .._strndup() not to call strndup. + +r16168: + M /trunk/doc/README.malloc + +set Id and eol-style + +r16169: + M /trunk/gtk/help_dlg.c + +fix the link to the online users-guide + +r16172: + M /trunk/epan/Makefile.am + +Add sminmpec.c to maintainer-clean + +r16181: + M /trunk/asn1/h245/h245.cnf + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h + M /trunk/epan/dissectors/packet-h235.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h450.c + M /trunk/epan/dissectors/packet-h450.h + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-per.h + M /trunk/tools/asn2eth.py + +Fix problems with bitstring: +- dissect_per_bitstring needs to know if extention exists or not. +- Fixes for bitstring sizes up to 16 ( where max = min ). +tinkle FC3:~/devel/ethereal$ ------------------------------------------------------------------------- -r15098 | ulfl | 2005-07-26 13:21:25 -0500 (Tue, 26 Jul 2005) | 1 line -Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_build_install.xml -fix: duplicate section id's not allowed ------------------------------------------------------------------------ -r15097 | lego | 2005-07-26 13:19:11 -0500 (Tue, 26 Jul 2005) | 3 lines +r16131 | gerald | 2005-10-05 14:19:04 -0500 (Wed, 05 Oct 2005) | 3 lines Changed paths: - M /trunk/gtk/voip_calls.c - -do not try to free the isup tap data. + A /releases/ethereal-0.10.13 (from /trunk:16130) +Carpe Buildbot. Copy off the 0.10.13 release directory while the builds are +stable, more or less. ------------------------------------------------------------------------ -r15096 | ulfl | 2005-07-26 13:17:09 -0500 (Tue, 26 Jul 2005) | 1 line +r16130 | jmayer | 2005-10-05 10:44:04 -0500 (Wed, 05 Oct 2005) | 1 line Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-amr.c + M /trunk/epan/dissectors/packet-csm-encaps.c -fix from previous check in, set compression back to on :-( +Don't reinvent the wheel, use val_to_str/match_strval ------------------------------------------------------------------------ -r15095 | ulfl | 2005-07-26 13:02:42 -0500 (Tue, 26 Jul 2005) | 1 line +r16129 | jmayer | 2005-10-05 10:43:07 -0500 (Wed, 05 Oct 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcom-cba-acco.c + M /trunk/manuf + M /trunk/wka.tmpl -add "BadOutOfService" quality code +Add two Enterasys STP multicast MACs ------------------------------------------------------------------------ -r15094 | ulfl | 2005-07-26 13:01:25 -0500 (Tue, 26 Jul 2005) | 3 lines +r16128 | sahlberg | 2005-10-05 08:39:44 -0500 (Wed, 05 Oct 2005) | 3 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_build_install.xml - M /trunk/docbook/user-guide.xml + A /trunk/epan/dissectors/pidl/IDL_LICENSE.txt + +add the licence file for the samba4 copied files -the user's guide are describing 0.10.12 already, bump up version -update the Windows installation section to reflect the current installer changes ------------------------------------------------------------------------ -r15093 | ulfl | 2005-07-26 12:58:17 -0500 (Tue, 26 Jul 2005) | 3 lines +r16127 | sahlberg | 2005-10-05 08:25:18 -0500 (Wed, 05 Oct 2005) | 5 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-fcels.c + +dissect one more bitfield +get rid of some strcpy() +get rid of a temporary string -fix detection of old/new WinPcap version, so WinPcap get's only installed by default if the user has a version lower than the delivered 3.1 beta 4 -fix statistics tree caption ------------------------------------------------------------------------ -r15092 | gerald | 2005-07-26 11:54:08 -0500 (Tue, 26 Jul 2005) | 4 lines +r16126 | sahlberg | 2005-10-05 07:42:34 -0500 (Wed, 05 Oct 2005) | 3 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/randpkt.c + M /trunk/epan/dissectors/packet-fcels.c -From Brice Augustin: Use the correct packet length in randpkt. +add dissection of another bitfield and remove some strcpy() -Build randpkt.exe by default under Windows. ------------------------------------------------------------------------ -r15091 | gerald | 2005-07-26 11:44:57 -0500 (Tue, 26 Jul 2005) | 2 lines +r16125 | sahlberg | 2005-10-05 06:55:49 -0500 (Wed, 05 Oct 2005) | 3 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/config.nmake - M /trunk/packaging/nsis/Makefile.am - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/WinPcapPage.ini - D /trunk/packaging/nsis/WinPcap_3_0.exe - A /trunk/packaging/nsis/WinPcap_3_1_beta4.exe - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-fcels.c + +rewrite dissection of service options flags to proper booleans and get rid of some strcpy() calls. -Revert back to GTK-Wimp 0.6.2. Move to WinPcap 3.1beta4. ------------------------------------------------------------------------ -r15090 | gerald | 2005-07-26 11:43:48 -0500 (Tue, 26 Jul 2005) | 2 lines +r16124 | ulfl | 2005-10-05 01:37:35 -0500 (Wed, 05 Oct 2005) | 1 line Changed paths: - M /trunk/NEWS + M /trunk/epan/dissectors/packet-bittorrent.c -Minor changes/updates. +bugfix: don't crash, if not enough bytes of the header available +------------------------------------------------------------------------ +r16123 | ulfl | 2005-10-05 01:05:35 -0500 (Wed, 05 Oct 2005) | 1 line +Changed paths: + M /trunk/capture_errs.h + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/capture_if_dlg.c +fix cant_load_winpcap_err() parameter ------------------------------------------------------------------------ -r15089 | gerald | 2005-07-26 10:59:54 -0500 (Tue, 26 Jul 2005) | 2 lines +r16122 | guy | 2005-10-04 17:08:20 -0500 (Tue, 04 Oct 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c -Don't add a new data source if we don't have any data. +Get rid of an unused variable. ------------------------------------------------------------------------ -r15088 | gerald | 2005-07-26 10:28:39 -0500 (Tue, 26 Jul 2005) | 2 lines +r16121 | etxrab | 2005-10-04 15:21:18 -0500 (Tue, 04 Oct 2005) | 7 lines Changed paths: - M /trunk/print.c + M /trunk/epan/dissectors/packet-iax2.c + +From Richard van der Hoff -In print_hex_data(), bail out early if our length is zero. +I've spotted a bug in the new desegmentation in iax2, which +means that higher-level PDUs aren't dissected when they ought to be, but +tend to be grouped together in later packets - I've attached a patch +against svn r16110 to fix this; it also makes the code a bit clearer... ------------------------------------------------------------------------ -r15087 | sahlberg | 2005-07-26 05:01:42 -0500 (Tue, 26 Jul 2005) | 3 lines +r16120 | etxrab | 2005-10-04 14:54:50 -0500 (Tue, 04 Oct 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-fcels.c - M /trunk/epan/dissectors/packet-fcels.h - -add iFCP ELS UNBIND dissection + A /trunk/plugins/h223/golay.h +Grr.. yet another missing file +------------------------------------------------------------------------ +r16119 | etxrab | 2005-10-04 14:51:31 -0500 (Tue, 04 Oct 2005) | 1 line +Changed paths: + A /trunk/plugins/h223/packet-srp.c + A /trunk/plugins/h223/packet-srp.h +Add two missing files. ------------------------------------------------------------------------ -r15086 | etxrab | 2005-07-26 04:52:50 -0500 (Tue, 26 Jul 2005) | 10 lines +r16118 | guy | 2005-10-04 13:21:04 -0500 (Tue, 04 Oct 2005) | 3 lines Changed paths: - M /trunk/tools/lemon/lemon.c + M /trunk/epan/dissectors/packet-cops.c -rom Maynard, Chris : -The attached patches, generated via svn diff , correct various compiler +Even a null object has a non-zero length (for the BER identifier and +length); update the offset when dissecting one. -& lint warnings, among them: +------------------------------------------------------------------------ +r16117 | sahlberg | 2005-10-04 09:41:39 -0500 (Tue, 04 Oct 2005) | 8 lines +Changed paths: + M /trunk/epan/dissectors/packet-t38.c - +the t38 tap would only initialize the t38_info structure when called from UDP +and when called from TCP this pointer would be uninitialized and thus dump core when dereferenced. + +at the same time remove the rotating buffers -lemon.c(2582) : warning C4090: '=' : different 'const' qualifiers +this fixes bugs 498 and 501 ------------------------------------------------------------------------ -r15085 | etxrab | 2005-07-26 04:52:06 -0500 (Tue, 26 Jul 2005) | 18 lines +r16116 | sahlberg | 2005-10-04 08:34:52 -0500 (Tue, 04 Oct 2005) | 13 lines Changed paths: - M /trunk/epan/dissectors/packet-afp.c - M /trunk/epan/dissectors/packet-afp.h - M /trunk/epan/dissectors/packet-ansi_637.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-bootp.c - M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/column-utils.c + M /trunk/epan/column-utils.h + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/libethereal.def -From Maynard, Chris : -The attached patches, generated via svn diff , correct various compiler +in svn 15335 the tcp analysis was changed to do its stuff and to populate (prepend to) COL_INFO before callking the subdissectors +instead of calling the tcp analysis (and prepend colingo) eitehr after the subdissector returned normally or if an exception caused by a subdissector was rised. -& lint warnings, among them: +this as a sideffect caused tcp analysis data to be overwritten if the subdissector caused any output to the info column. (and made tcp analysis suboptimal) - -lemon.c(2582) : warning C4090: '=' : different 'const' qualifiers +this change adds a new function col_prepend_fence_fstr() that will prepend +the info column with the string and also, if there was no fence already defined, create a fence and set it after the prepended col info text. -packet-ber.c(212) : warning C4018: '<=' : signed/unsigned mismatch +This way, even if the subdissectors generate and rewrite col info, the tcp analysis data will still be displayed on the info column. -packet-ber.c(228) : warning C4018: '>=' : signed/unsigned mismatch -packet-bootp.c(2112) : warning C4018: '<' : signed/unsigned mismatch -packet-iscsi.c(801) : warning C4018: '>=' : signed/unsigned mismatch +------------------------------------------------------------------------ +r16115 | guy | 2005-10-04 05:26:44 -0500 (Tue, 04 Oct 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-edonkey.c +Fix a typo. ------------------------------------------------------------------------ -r15084 | etxrab | 2005-07-26 04:34:49 -0500 (Tue, 26 Jul 2005) | 8 lines +r16114 | guy | 2005-10-04 05:26:17 -0500 (Tue, 04 Oct 2005) | 2 lines Changed paths: - M /trunk/editcap.c + M /trunk/epan/dissectors/packet-edonkey.c -From Peter Johansson: -The supplied patch takes care of the following compilation warnings: +Get rid of // comments - not all C compilers like them. + +------------------------------------------------------------------------ +r16113 | guy | 2005-10-04 05:23:40 -0500 (Tue, 04 Oct 2005) | 23 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc-lsa.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-dcerpc-spoolss.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-windows-common.c + M /trunk/epan/dissectors/packet-windows-common.h + +Don't ensure all the bytes of a security descriptor exist before calling +"dissect_nt_sec_desc()". Add a Boolean argument to +"dissect_nt_sec_desc()" to indicate whether a length was passed to it +(so we don't treat -1 as a special value; we want to stop treating -1 as +a special length value, and, in fact, want to stop treating *any* +negative length values specially, so that we don't have to worry about +passing arbitrary 32-bit values from packets as lengths), and have +"dissect_nt_sec_desc()" initially create the protocol tree item for the +security descriptor with a length of "go to the end of the tvbuff", and +set the length once we're done dissecting it - and, if the length was +specified, check at *that* point, *after* we've dissected the security +descriptor, whether we have the entire security descriptor in the +tvbuff. -editcap.c(273) : warning C4013: 'getpid' undefined; assuming extern -returning int -editcap.c(464) : warning C4018: '<' : signed/unsigned mismatch +That means that we don't have to worry about overflows after +"dissect_nt_sec_desc()" returns - if the length was so large that we +would have gotten an overflow, we'd have thrown an exception in the +"tvb_ensure_bytes_exist()" call at the end of "dissect_nt_sec_desc()". +Do sanity checks on offsets within the security descriptor, so we know +the item referred to by the offset is after the fixed-length portion of +the descriptor. ------------------------------------------------------------------------ -r15083 | etxrab | 2005-07-26 04:31:04 -0500 (Tue, 26 Jul 2005) | 10 lines +r16112 | guy | 2005-10-04 05:17:45 -0500 (Tue, 04 Oct 2005) | 8 lines Changed paths: - M /trunk/getopt.c + M /trunk/epan/dissectors/packet-cops.c -From Peter Johansson: -The supplied patch takes care of the following compilation warnings: +We can just use "get_ber_identifier()" and "get_ber_length()" to fetch +BER identifier and length information; calling +"dissect_ber_identifier()" and "dissect_ber_length()" with a null tree +argument doesn't have any advantages over that. -getopt.c(409) : warning C4013: 'strcmp' undefined; assuming extern -returning int -getopt.c(478) : warning C4013: 'strncmp' undefined; assuming extern -returning int -getopt.c(480) : warning C4013: 'strlen' undefined; assuming extern -returning int +Don't put an octet string into the protocol tree twice, once with +"dissect_ber_octet_string()" and once with the real value; once is enough. ------------------------------------------------------------------------ -r15082 | etxrab | 2005-07-26 04:25:46 -0500 (Tue, 26 Jul 2005) | 1 line +r16111 | guy | 2005-10-04 05:13:15 -0500 (Tue, 04 Oct 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/wiretap/atm.c + +A heuristic that only treats packets that appear to be LANE-encapsulated +Ethernet packets with a length field as LANE packets, and doesn't do so +for packets that appear to be LANE-encapsulated Ethernet packets with a +type field, is too weak. Back out that part of the heuristics added in +the previous checkin. -Get rid of an unused variable. ------------------------------------------------------------------------ -r15081 | etxrab | 2005-07-26 03:59:32 -0500 (Tue, 26 Jul 2005) | 10 lines +r16110 | guy | 2005-10-04 02:07:15 -0500 (Tue, 04 Oct 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-juniper.c + M /trunk/capture_errs.c + M /trunk/capture_errs.h -From Hannes Gredler: -a patch that adds support for -dissecting packets captured on ML-, LS- and AS PICs -using Multi-link PPP encapsulation, -running JUNOS 7.3 or higher; +Include <glib.h> to declare "g_strdup_printf()". -additional there i did some clean-up in the -juniper dissector that makes future addition -of JUNIPER_DLTs easier; +Properly declare "cant_load_winpcap_err()". ------------------------------------------------------------------------ -r15080 | sahlberg | 2005-07-26 03:47:46 -0500 (Tue, 26 Jul 2005) | 3 lines +r16109 | guy | 2005-10-04 01:25:01 -0500 (Tue, 04 Oct 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-fcels.c - M /trunk/epan/dissectors/packet-fcels.h + M /trunk/Makefile.common + A /trunk/capture_errs.c + A /trunk/capture_errs.h + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/capture_if_dlg.c + M /trunk/tethereal.c -add decoding of ELS iFCP CBIND packets +Add a "capture_errs.c" routine to cough up error messages for capture +problems, and use the first routine in it in multiple places. +Get rid of DISSECTOR_SUPPORT_INCLUDES - just add its contents to +ETHEREAL_COMMON_INCLUDES. ------------------------------------------------------------------------ -r15079 | jmayer | 2005-07-26 03:01:16 -0500 (Tue, 26 Jul 2005) | 1 line +r16108 | etxrab | 2005-10-04 00:42:18 -0500 (Tue, 04 Oct 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-aim-icq.c - M /trunk/epan/dissectors/packet-aim.h - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dcerpc-nt.h - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/packet-dcerpc-spoolss.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-dcom-remunkn.c - M /trunk/epan/dissectors/packet-dcom.c - M /trunk/epan/dissectors/packet-dcom.h - M /trunk/epan/dissectors/packet-dnp.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-ipv6.c - M /trunk/epan/dissectors/packet-ppp.c - M /trunk/epan/dissectors/packet-windows-common.h - M /trunk/epan/reassemble.c - M /trunk/epan/reassemble.h - M /trunk/ip_opts.h + M /trunk/AUTHORS + M /trunk/wiretap/atm.c + +From Rene Piltz: +Due to the fact that 3G Signaling appears at an undefined VPI/VCI I added a heuristics (very simple) which should take care of this fact. -char -> const char warning fixes ------------------------------------------------------------------------ -r15078 | sahlberg | 2005-07-25 20:18:25 -0500 (Mon, 25 Jul 2005) | 5 lines +r16107 | etxrab | 2005-10-04 00:36:31 -0500 (Tue, 04 Oct 2005) | 6 lines Changed paths: - M /trunk/AUTHORS - M /trunk/NEWS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-dec-dnart.c + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-edonkey.h -From fred hoekstra +From John Sullivan: +The current ethereal eDonkey dissector fails to handle a number of valid packet types - in particular the normal server<->client communication between current eserver and eMule versions (from both +sides) produces packets which ethereal incorrectly claims to be malformed. -New protocol: DEC DNA Routing protocol +This patch fills in these holes. +------------------------------------------------------------------------ +r16106 | etxrab | 2005-10-04 00:29:40 -0500 (Tue, 04 Oct 2005) | 1 line +Changed paths: + M /trunk/epan/libethereal.def +Add some requested items. ------------------------------------------------------------------------ -r15077 | sahlberg | 2005-07-25 20:08:12 -0500 (Mon, 25 Jul 2005) | 7 lines +r16105 | etxrab | 2005-10-04 00:16:26 -0500 (Tue, 04 Oct 2005) | 1 line Changed paths: - M /trunk/NEWS + M /trunk/epan/address.h + M /trunk/epan/libethereal.def + +Preparations for h223 +------------------------------------------------------------------------ +r16104 | etxrab | 2005-10-04 00:15:23 -0500 (Tue, 04 Oct 2005) | 11 lines +Changed paths: + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h -more news +From Dave Richards -SecureLDAP and GSS-KRB encrypted DCE/RPC decryption support. +1) Fixes context-tagged BACnet errors. +2) Fixes indeterminate tag data. If the tag length/value/type variable +was 6 or 7 you could not tell whether it was an open/close tag or had +length 6/7. +3) Don't make assumptions about property types for proprietary BACnet +object types. -TCP Sequence graphs is now tappified. ------------------------------------------------------------------------ -r15076 | sahlberg | 2005-07-25 19:54:16 -0500 (Mon, 25 Jul 2005) | 20 lines +r16103 | guy | 2005-10-03 23:23:09 -0500 (Mon, 03 Oct 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-fc.c - M /trunk/epan/dissectors/packet-fcp.c - M /trunk/epan/dissectors/packet-ifcp.c + M /trunk/capture_loop.c + M /trunk/tethereal.c -iFCP uses one dedicated TCP session per fc-endpoint pair. +Add a note about 64-bit support in WinPcap to the capture errors on +Windows, and add the URL for the CaptureSetup page to the Tethereal +error. -The FC D_id and S_id fields in teh FC frame encapsulated inside iFCP unfortunately has "undefined" (semi-random) values so we can not use th S_/D_id matching in FC when transported atop iFCP. +------------------------------------------------------------------------ +r16102 | guy | 2005-10-03 23:12:34 -0500 (Mon, 03 Oct 2005) | 3 lines +Changed paths: + M /trunk/version_info.c +Grr. Without the right version of the SDK, we can't even compile code +to *use* the shiny new features. -Change iFCP to call a new fc_ifcp handler instead of the fc handler. +------------------------------------------------------------------------ +r16101 | guy | 2005-10-03 22:58:40 -0500 (Mon, 03 Oct 2005) | 2 lines +Changed paths: + M /trunk/capture-wpcap.c -Add a new handler to FC specific to iFCP. -Only set the pinfo->src/dst fields to the S_id/D_id fields IFF the FC frame was NOT transported ontop of iFCP. -Othervise we just use the TCP/IP values that are already stored there. +Remove an extra " from a command, and fix indentation. -Some Hosts use RelativeOffset fields for FC. We can only dissect the RelOff field with offset 0. -Change FC to only call the FCP subdissector if offset==0 when relative offsets are used. +------------------------------------------------------------------------ +r16100 | guy | 2005-10-03 22:15:12 -0500 (Mon, 03 Oct 2005) | 3 lines +Changed paths: + M /trunk/version_info.c +Cope with NT 6.0, and with the x86-64 version of XP being NT 5.2 rather +than NT 5.1. -Some hosts when using relative offsets do not specify a proper value for rxid in teh commands instead htey lkeave it as 0xffff -Change the FCP conversation matching to ignore RXID when searching for a conversation. +------------------------------------------------------------------------ +r16099 | guy | 2005-10-03 20:16:06 -0500 (Mon, 03 Oct 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-iax2.c +Don't assume that every packet has a non-null "call_data" value. Fixes +bug 497 (as well as a crash on an *unfuzzed* IAX2 capture!). +Set "pinfo->can_desegment" before calling dissectors; that's expected +for dissectors that do TCP-style desegmentation. ------------------------------------------------------------------------ -r15075 | lego | 2005-07-25 18:54:02 -0500 (Mon, 25 Jul 2005) | 3 lines +r16098 | guy | 2005-10-03 17:26:32 -0500 (Mon, 03 Oct 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/gtk/t38_analysis.c -Avoid leaking tap info by using emem allocators +Properly terminate some value_string tables. +------------------------------------------------------------------------ +r16097 | guy | 2005-10-03 17:23:04 -0500 (Mon, 03 Oct 2005) | 5 lines +Changed paths: + M /trunk/gtk/t38_analysis.c + +Include "gui_stat_menu.h" to declare "register_stat_menu_item()". + +Fix the type of "t38_analysis_init()" to match what +"register_stat_cmd_arg()" expects. ------------------------------------------------------------------------ -r15074 | ulfl | 2005-07-25 18:45:56 -0500 (Mon, 25 Jul 2005) | 1 line +r16096 | guy | 2005-10-03 17:17:32 -0500 (Mon, 03 Oct 2005) | 6 lines Changed paths: - M /trunk/NEWS + M /trunk/epan/stream.c + +A hash table doesn't *have* to have a value destroy function - and, in +fact, in GLib 1.2, it *can't* have one. As the value destroy function +for this hash table does nothing, don't bother with it - and create the +hash table with "g_hash_table_new(), rather than +"g_hash_table_new_full()", so it works with GLib 1.2[.x]. -added some other things that came to my mind ------------------------------------------------------------------------ -r15073 | lego | 2005-07-25 18:33:44 -0500 (Mon, 25 Jul 2005) | 4 lines +r16095 | guy | 2005-10-03 17:04:58 -0500 (Mon, 03 Oct 2005) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-pktc.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-snmp.h + M /trunk/epan/stream.c -From Thomas Anders: -SNMP Engine ID dissection according to RFC3411 +It's "svn:keywords", not "svn:Keywords". +------------------------------------------------------------------------ +r16094 | guy | 2005-10-03 17:02:47 -0500 (Mon, 03 Oct 2005) | 3 lines +Changed paths: + M /trunk/epan/stream.h + +The "extern" in "struct _fragment_items" doesn't do anything, as data +types aren't objects and don't have storage classes, etc.. ------------------------------------------------------------------------ -r15072 | gerald | 2005-07-25 18:11:32 -0500 (Mon, 25 Jul 2005) | 4 lines +r16093 | ulfl | 2005-10-03 15:04:06 -0500 (Mon, 03 Oct 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-fcp.c + M /trunk/gtk/capture_dlg.c + +Win32: don't crash if Capture/Start is clicked and WinPcap is not installed. +------------------------------------------------------------------------ +r16092 | ulfl | 2005-10-03 14:37:17 -0500 (Mon, 03 Oct 2005) | 1 line +Changed paths: + M /trunk/gtk/expert_dlg.c -From Ronnie: Offset checking/handling fix. +move the list down to the latest message while new messages rush in. We might want to have a checkbox or alike to en/disable this (as discussed for the Statistics) lately. +------------------------------------------------------------------------ +r16091 | ulfl | 2005-10-03 14:34:58 -0500 (Mon, 03 Oct 2005) | 3 lines +Changed paths: + M /trunk/gtk/gui_utils.c -Fix up whitespace and newlines. +major Win32 bugfix: when getting messages from the capture slave, only one message was processed every 200ms (UNIX handles this differently). If more messages were initiated from the slave, they stacked up. This slowed down the display update and slowed down stopping the capture as a lot of messages had to be processed before the close really finished ... +Now the timer callback function will call the pipe read function up to 5 times to avoid this, but won't do this more often to prevent "endless blocking". ------------------------------------------------------------------------ -r15071 | gerald | 2005-07-25 17:16:43 -0500 (Mon, 25 Jul 2005) | 4 lines +r16090 | ulfl | 2005-10-03 14:11:57 -0500 (Mon, 03 Oct 2005) | 1 line Changed paths: - M /trunk/ChangeLog - M /trunk/NEWS + M /trunk/gtk/main.c -Prep for 0.10.12. If you've added or changed any major features since -0.10.11 you may want to check the NEWS file to make sure your work is -present and correct. +minor bugfix: hide main widgets, if command line file couldn't be loaded +------------------------------------------------------------------------ +r16089 | etxrab | 2005-10-03 14:00:52 -0500 (Mon, 03 Oct 2005) | 1 line +Changed paths: + A /trunk/plugins/h223/Makefile.nmake +First check in of yhe h223 plugin, not part of the build script yet. ------------------------------------------------------------------------ -r15070 | lego | 2005-07-25 17:02:04 -0500 (Mon, 25 Jul 2005) | 3 lines +r16088 | etxrab | 2005-10-03 13:59:41 -0500 (Mon, 03 Oct 2005) | 1 line Changed paths: - M /trunk/plugins/xml/xml_lexer.l + A /trunk/plugins/h223/moduleinfo.h + A /trunk/plugins/h223/packet-h223.c + A /trunk/plugins/h223/packet-h223.h + A /trunk/plugins/h223/plugin.c -rename OUT to OUTSIDE and TEXT to CDATA +First check in of yhe h223 plugin, not part of the build script yet. +------------------------------------------------------------------------ +r16087 | etxrab | 2005-10-03 13:54:41 -0500 (Mon, 03 Oct 2005) | 1 line +Changed paths: + A /trunk/plugins/h223/Makefile.am +First check in of yhe h223 plugin, not part of the build script yet. +------------------------------------------------------------------------ +r16086 | etxrab | 2005-10-03 13:54:13 -0500 (Mon, 03 Oct 2005) | 1 line +Changed paths: + A /trunk/plugins/h223/golay.c +First check in of yhe h223 plugin, not part of the build script yet. ------------------------------------------------------------------------ -r15069 | sahlberg | 2005-07-25 16:18:58 -0500 (Mon, 25 Jul 2005) | 6 lines +r16085 | etxrab | 2005-10-03 13:53:52 -0500 (Mon, 03 Oct 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ifcp.c + A /trunk/plugins/h223/COPYING -from aboo +First check in of yhe h223 plugin, not part of the build script yet. +------------------------------------------------------------------------ +r16084 | etxrab | 2005-10-03 13:53:28 -0500 (Mon, 03 Oct 2005) | 1 line +Changed paths: + A /trunk/plugins/h223/ChangeLog +First check in of yhe h223 plugin, not part of the build script yet. +------------------------------------------------------------------------ +r16083 | etxrab | 2005-10-03 13:51:54 -0500 (Mon, 03 Oct 2005) | 1 line +Changed paths: + A /trunk/plugins/h223 + A /trunk/plugins/h223/AUTHORS -fix multiple pdus in one segment +First check in of yhe h223 plugin, not part of the build script yet. +------------------------------------------------------------------------ +r16082 | etxrab | 2005-10-03 13:34:21 -0500 (Mon, 03 Oct 2005) | 7 lines +Changed paths: + M /trunk/epan/Makefile.common + M /trunk/epan/packet.c + A /trunk/epan/stream.c + A /trunk/epan/stream.h +From Jeff Snyder: +04-stream.diff + A simplified packet reassembly API built on top of fragment_add_seq_next for +reassembling fragments that are delivered in-order, where fragments are +identified by a framenum and an offset into that frame. Streams are attached +to a conversation or a circuit and are unidirectional. ------------------------------------------------------------------------ -r15068 | jmayer | 2005-07-25 16:10:29 -0500 (Mon, 25 Jul 2005) | 1 line +r16081 | etxrab | 2005-10-03 13:18:38 -0500 (Mon, 03 Oct 2005) | 1 line Changed paths: - M /trunk/manuf + M /trunk/asn1/gnm/gnm.cnf + M /trunk/asn1/gnm/packet-gnm-template.c + M /trunk/epan/dissectors/packet-gnm.c -Update manuf +Add dissection of some more OID's and use the #.REGISTER function. ------------------------------------------------------------------------ -r15067 | jmayer | 2005-07-25 16:08:14 -0500 (Mon, 25 Jul 2005) | 1 line +r16080 | ulfl | 2005-10-03 11:24:43 -0500 (Mon, 03 Oct 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-ip.c -Warning fixes +from Yaniv Kaul: add a Preference setting for IP checksum validation ------------------------------------------------------------------------ -r15066 | etxrab | 2005-07-25 14:52:08 -0500 (Mon, 25 Jul 2005) | 10 lines +r16079 | ulfl | 2005-10-03 10:52:14 -0500 (Mon, 03 Oct 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-ospf.c - M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-iax2.c -From Morro Roberto : - - bug fixes to the dissectors for the GENERALIZED_UNI and - LABEL objects - - improved dissector of flag field for the ERROR object - - improved LABEL_SET object dissector - - support for the new (proposed) ASSOCIATION object (see - draft-ietf-ccamp-gmpls-recovery-e2e-signaling). - Moveover find also attached a patch to OSPF that fixes a line - of source code lost in the TNA TLV (the code compiled anyway). +from Peter Johansson: +The supplied patch resolves an issue with the use of the not yet initialized variable "fid". +/ Regards, Peter ------------------------------------------------------------------------ -r15065 | lego | 2005-07-25 14:19:34 -0500 (Mon, 25 Jul 2005) | 3 lines +r16078 | lego | 2005-10-03 08:10:28 -0500 (Mon, 03 Oct 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-rtse.c -Get rid of a unused variable +dissect_rtse_EXTERNAL is already declared in the header as extern. ------------------------------------------------------------------------ -r15064 | lego | 2005-07-25 14:06:02 -0500 (Mon, 25 Jul 2005) | 3 lines +r16077 | lego | 2005-10-03 06:36:24 -0500 (Mon, 03 Oct 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-user_encap.c + A /trunk/gtk/t38_analysis.c -Make the DLT an option, reduce the number of instances and rename them. +This one was missing from the checkin... ------------------------------------------------------------------------ -r15063 | lego | 2005-07-25 14:03:57 -0500 (Mon, 25 Jul 2005) | 3 lines +r16076 | sahlberg | 2005-10-03 04:30:10 -0500 (Mon, 03 Oct 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-mount.c + +prettify mount, -Fix the IP address representation string (was inverted on little endians) +if MNT fails with an error, put the error string in the INFO column ------------------------------------------------------------------------ -r15062 | ulfl | 2005-07-25 13:54:21 -0500 (Mon, 25 Jul 2005) | 1 line +r16075 | guy | 2005-10-03 02:30:49 -0500 (Mon, 03 Oct 2005) | 3 lines Changed paths: - M /trunk/README.win32 + M /trunk/simple_dialog.h + +C89 doesn't allow a comma after the end of the last value in an +enumerator list, and some compilers don't allow it as an extension. -updated GTK-Wimp section to reflect GTK 2.4 ------------------------------------------------------------------------ -r15061 | ulfl | 2005-07-25 13:44:59 -0500 (Mon, 25 Jul 2005) | 1 line +r16074 | etxrab | 2005-10-03 00:59:17 -0500 (Mon, 03 Oct 2005) | 1 line Changed paths: - M /trunk/config.nmake + M /trunk/epan/dissectors/packet-sigcomp.c -found by Thomas Boehne: corrected GTK_WIMP_DIR, used by the NSIS installer +Fix a typo. ------------------------------------------------------------------------ -r15060 | ulfl | 2005-07-25 13:30:35 -0500 (Mon, 25 Jul 2005) | 1 line +r16073 | etxrab | 2005-10-03 00:55:26 -0500 (Mon, 03 Oct 2005) | 12 lines Changed paths: - M /trunk/config.nmake + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-t38.h + M /trunk/epan/libethereal.def + M /trunk/gtk/Makefile.common + M /trunk/gtk/graph_analysis.c + M /trunk/gtk/graph_analysis.h + M /trunk/gtk/voip_calls.c + +From Alejandro Vaquero: + + New "Fax T38 Analysis" added to the "Statistics" menu to: + +- Reassemble the HDLC t30 frames and dissect the header. +- Analyze the UPDTLPacket seq num for packet lost +- Stats of V.x Data: + - Count the Data bytes + - Duration + - Wrong seq num + - Max Burst of packet lost -update to latest zlib version 123 ------------------------------------------------------------------------ -r15059 | ulfl | 2005-07-25 13:27:35 -0500 (Mon, 25 Jul 2005) | 1 line +r16072 | etxrab | 2005-10-03 00:17:51 -0500 (Mon, 03 Oct 2005) | 5 lines Changed paths: - M /trunk/README.win32 - M /trunk/doc/README.plugins + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-acse.h + M /trunk/epan/dissectors/packet-cms.c + M /trunk/epan/dissectors/packet-cms.h + M /trunk/epan/dissectors/packet-ess.c + M /trunk/epan/dissectors/packet-ess.h + M /trunk/epan/dissectors/packet-rtse.c + M /trunk/epan/dissectors/packet-rtse.h + M /trunk/epan/dissectors/packet-x420.c + +From Graeme Lunt +X420 - incorrect ExtendedBodyPart handling +ACSE - support for implicitly tagged EXTERNALs and dissection based upon direct-reference RTSE - same change for RTSE EXTERNAL handling as above CMS - support for ContentType, MessageDigest, SigningTime and CounterSignature attributes ESS - support for ESSSecurityLabel and EquivalentLabels attributes + -from Thomas Boehne: update README's to reflect latest changes ------------------------------------------------------------------------ -r15058 | ulfl | 2005-07-25 13:03:38 -0500 (Mon, 25 Jul 2005) | 1 line +r16071 | etxrab | 2005-10-03 00:16:57 -0500 (Mon, 03 Oct 2005) | 5 lines Changed paths: - M /trunk/plugins/stats_tree/pinfo_stats_tree.c + M /trunk/asn1/cms/CryptographicMessageSyntax.asn + M /trunk/asn1/cms/cms.cnf + M /trunk/asn1/ess/ExtendedSecurityServices.asn + M /trunk/asn1/ess/ess.cnf + M /trunk/asn1/rtse/rtse-exp.cnf + M /trunk/asn1/rtse/rtse.cnf + M /trunk/asn1/x420/x420.asn + M /trunk/asn1/x420/x420.cnf + +From Graeme Lunt +X420 - incorrect ExtendedBodyPart handling +ACSE - support for implicitly tagged EXTERNALs and dissection based upon direct-reference RTSE - same change for RTSE EXTERNAL handling as above CMS - support for ContentType, MessageDigest, SigningTime and CounterSignature attributes ESS - support for ESSSecurityLabel and EquivalentLabels attributes + -fix a typo: lenght -> length ------------------------------------------------------------------------ -r15057 | guy | 2005-07-25 13:03:19 -0500 (Mon, 25 Jul 2005) | 15 lines +r16070 | etxrab | 2005-10-03 00:14:39 -0500 (Mon, 03 Oct 2005) | 5 lines Changed paths: - M /trunk/epan/reassemble.c + M /trunk/asn1/acse/acse.cnf -When reassembling a packet, all data, including data with -FD_NOT_MALLOCED set, has to be copied - all FD_NOT_MALLOCED means is -that the fragment's data is part of the old reassembled data, rather -than a malloced chunk of its own (this happens if, after reassembly, the -dissector says more reassembly is necessary, as can happen, for example, -in the case of HTTP and other protocols where reassembly continues until -a terminator is seen). Not copying the data means that the reassembled -data is, in part, whatever random junk happens to be in the -newly-allocated buffer. +From Graeme Lunt +X420 - incorrect ExtendedBodyPart handling +ACSE - support for implicitly tagged EXTERNALs and dissection based upon direct-reference RTSE - same change for RTSE EXTERNAL handling as above CMS - support for ContentType, MessageDigest, SigningTime and CounterSignature attributes ESS - support for ESSSecurityLabel and EquivalentLabels attributes -Back out the change not to copy the data, but add some sanity checks, in -the hopes of preventing the crash that caused the change not to copy the -data to be added, and in the hopes of discovering the ultimate source of -that crash and fixing it. ------------------------------------------------------------------------ -r15056 | ulfl | 2005-07-25 13:02:32 -0500 (Mon, 25 Jul 2005) | 3 lines +r16069 | etxrab | 2005-10-02 16:14:35 -0500 (Sun, 02 Oct 2005) | 3 lines Changed paths: - M /trunk/gtk/drag_and_drop.c - M /trunk/gtk/main.h + M /trunk/asn1/cms/cms.cnf + M /trunk/epan/dissectors/packet-cms.c + +From Graeme Lunt +allows the dissection of ContentInfo based upon it's OID - something that is used for a secure X.400 messages (Protecting Content Type (PCT)). -two bugfixes: -- don't use GtkSelectionData after returned to GTK, as it might free this data immediately (copy the data instead and free it after usage) -- fix return value handling for DnD merge, so it will work again ------------------------------------------------------------------------ -r15055 | ulfl | 2005-07-25 12:56:19 -0500 (Mon, 25 Jul 2005) | 8 lines +r16068 | etxrab | 2005-10-02 15:59:54 -0500 (Sun, 02 Oct 2005) | 20 lines Changed paths: - M /trunk/packaging/nsis/AdditionalTasksPage.ini - M /trunk/packaging/nsis/WinPcapPage.ini - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-amr.c + M /trunk/epan/dissectors/packet-h261.c + M /trunk/epan/dissectors/packet-h263.c + M /trunk/epan/dissectors/packet-iax2.c -bugfix: default for NPF service was default on for NT and above, but it has to be off (secure default) +From Jeff Snyder -stop NPF service and set it back to "On demand" if user deselected the corresponding checkbox +00-iax.diff + Modifications to the IAX2 dissector so that it offers desegmentation to +subdissectors using the same API as TCP offers (pinfo->desegment_len etc) -when upgrading from a previous Ethereal install, try to detect which choices of icons and alike was used last time, and set this as default (e.g. don't install desktop icon if I choose not to install last time) +01-amr.diff + Modifications to the AMR dissector to allow AMR IF2 data to be dissected via +call_dissector() from packet-h223.c. This patch also causes the AMR dissector +to append the frame type string to the info column, so that the info column +shows what protocols an H.223 frame contains. -minor text changes +02-h263-data.diff + Modifications to packet-h263.c to separate the dissection of h.263 RTP +encpasulation from the dissection of the actual h.263 data. The data +dissection functions are added as a second dissector. This data-only +dissector is used to dissect the video channel in our h.223 streams. As with +the AMR modification, this makes the H.263 dissector append to the info +column. ------------------------------------------------------------------------ -r15054 | gerald | 2005-07-25 10:43:38 -0500 (Mon, 25 Jul 2005) | 2 lines +r16067 | ulfl | 2005-10-02 10:41:11 -0500 (Sun, 02 Oct 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-bittorrent.c + +enhancements COL_INFO output and make bittorrent protocol filterable +------------------------------------------------------------------------ +r16066 | ulfl | 2005-10-02 09:56:27 -0500 (Sun, 02 Oct 2005) | 1 line +Changed paths: + M /trunk/epan/column-utils.c + M /trunk/epan/column-utils.h + M /trunk/epan/epan.c + +add doxygen comments to column-utils.h and do a slight code cleanup +------------------------------------------------------------------------ +r16065 | lego | 2005-10-01 10:19:36 -0500 (Sat, 01 Oct 2005) | 8 lines +Changed paths: + M /trunk/epan/tpg.c + M /trunk/epan/tpg.h + M /trunk/epan/tvbparse.c + M /trunk/plugins/tpg/http.tpg + M /trunk/plugins/tpg/packet-http.c + M /trunk/tools/tpg/tpg.yp + +one step further... + TPG now uses the ignore feature of tvbparse + named sub_rules can have cardinality + +epan/tvbparse.c: + do not crash on zero cardinality + + +------------------------------------------------------------------------ +r16064 | lego | 2005-10-01 06:16:17 -0500 (Sat, 01 Oct 2005) | 5 lines Changed paths: M /trunk/epan/dissectors/packet-radius.c -Break out of an infinite loop. Fixes bugs 296 and 297. +propperly initialize vendor->ett if the vendor is not found while radius_register_avp_dissector(). + +fixes bug 488. + ------------------------------------------------------------------------ -r15053 | ulfl | 2005-07-25 02:50:11 -0500 (Mon, 25 Jul 2005) | 1 line +r16063 | lego | 2005-10-01 05:41:00 -0500 (Sat, 01 Oct 2005) | 3 lines Changed paths: - M /trunk/README.win32 + M /trunk/plugins/tpg/http.tpg + M /trunk/plugins/tpg/packet-http.c + +match changes to tpg infrastructure. + -add a section about the Developer's Guide ------------------------------------------------------------------------ -r15052 | ulfl | 2005-07-25 02:42:06 -0500 (Mon, 25 Jul 2005) | 2 lines +r16062 | lego | 2005-10-01 05:39:38 -0500 (Sat, 01 Oct 2005) | 3 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/tools/tpg/tpg.yp + +Some changes in tpg's grammar to avoid constructing elements that cannot be dereferenced + -as the buildbot is updated now: -using the /SOLID switch in SetCompressor again, making NSIS at least 2.07 a requirement ------------------------------------------------------------------------ -r15051 | ulfl | 2005-07-24 20:22:03 -0500 (Sun, 24 Jul 2005) | 3 lines +r16061 | lego | 2005-10-01 05:36:57 -0500 (Sat, 01 Oct 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c - M /trunk/epan/dissectors/packet-kink.c + M /trunk/epan/emem.c + M /trunk/epan/emem.h + M /trunk/epan/tpg.c + M /trunk/epan/tpg.h + +emem.[ch]: +Add a simple stack implememtation that uses ep_alloc +Add ep_new() ep_new0() macros + +tpg.[ch]: +use the stack in tpg helpers + -packet-http.c(484) : warning C4101: 'i' : unreferenced local variable -packet-http.c(486) : warning C4101: 'si' : unreferenced local variable -packet-kink.c(628) : warning C4101: 'quick_mode_payloads_length' : unreferenced local variable ------------------------------------------------------------------------ -r15050 | guy | 2005-07-24 17:01:14 -0500 (Sun, 24 Jul 2005) | 2 lines +r16060 | obiot | 2005-09-30 14:29:21 -0500 (Fri, 30 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/reassemble.c + M /trunk/epan/dissectors/packet-wsp.c -Fix indentation. +Fix bug 492 - the MMSE dissector calls add_content_type() defined in WSP, which +uses proto_item_append_string(). The visibility hack must be present, otherwise +a dissector assert is generated within the MMSE dissector. ------------------------------------------------------------------------ -r15049 | ulfl | 2005-07-24 16:25:29 -0500 (Sun, 24 Jul 2005) | 1 line +r16059 | etxrab | 2005-09-30 13:20:44 -0500 (Fri, 30 Sep 2005) | 1 line Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/diameter/dictionary.xml -make the default to not use the /SOLID switch for SetCompressor, so buildbot is working again +Update AVP:s and error codes. ------------------------------------------------------------------------ -r15048 | ulfl | 2005-07-24 16:23:10 -0500 (Sun, 24 Jul 2005) | 3 lines +r16058 | lego | 2005-09-29 15:38:41 -0500 (Thu, 29 Sep 2005) | 3 lines Changed paths: - M /trunk/plugins/stats_tree/Makefile.nmake - M /trunk/plugins/stats_tree/pinfo_stats_tree.c + M /trunk/plugins/tpg/packet-http.c + +this struct moved to tvbparse.c -include pinfo_stats_tree.c in the build process, so MSVC compiles again -don't use extern before a function body, that don't make sense ------------------------------------------------------------------------ -r15047 | gerald | 2005-07-24 16:02:40 -0500 (Sun, 24 Jul 2005) | 2 lines +r16057 | lego | 2005-09-29 15:37:05 -0500 (Thu, 29 Sep 2005) | 5 lines Changed paths: - M /trunk/plugins/megaco/packet-megaco.c + M /trunk/epan/tvbparse.c + +I needed to cut'n'paste something more... + +I did not even try to compile it before check it in, sorry! -Break out of another infinite loop. Fixes bug 293. ------------------------------------------------------------------------ -r15046 | guy | 2005-07-24 15:39:19 -0500 (Sun, 24 Jul 2005) | 39 lines +r16056 | etxrab | 2005-09-29 15:24:02 -0500 (Thu, 29 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-eap.c - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-uma.c -Fix some typoes. +Update to the latest version of the standard. +------------------------------------------------------------------------ +r16055 | etxrab | 2005-09-29 15:22:55 -0500 (Thu, 29 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/sigcomp_state_hdlr.c -Call "dissect_attribute_value_pairs()" regardless of whether we're -building a protocol tree, so the EAP subdissector is always called. +make n a guint32 to not wrap around at 65536 +------------------------------------------------------------------------ +r16054 | lego | 2005-09-29 15:07:29 -0500 (Thu, 29 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/tvbparse.c + M /trunk/epan/tvbparse.h -"dissect_attribute_value_pairs()" is only called when the length of AVPs -in the packet is non-zero; don't bother checking for a zero length. +add a debugging function that creates a tree exploding the parsed elements -Don't put two items in for each AVP - one is sufficient. -Add some more length checks when processing AVPs. Don't require AVPs to -be at least 3 bytes long - they might have just a type and length; let -an exception be thrown if that's a problem. +------------------------------------------------------------------------ +r16053 | lego | 2005-09-29 15:05:24 -0500 (Thu, 29 Sep 2005) | 3 lines +Changed paths: + M /trunk/plugins/tpg/http.tpg + M /trunk/plugins/tpg/packet-http.c -Don't require that the entire AVP be available in the tvbuff before -processing it; let an exception be thrown as we're processing the AVP if -we don't have all the data, so the stuff before the end is processed. +at this point this makes a good parser for http headers... -Give the tvbuff for the AVP data a length that reflects the length of -data left in the tvbuff, so that the appropriate exception is thrown if -the packet was cut short by a snapshot length. -Don't have a fixed-length buffer for reassembled EAP messages; grow it -as necessary. +------------------------------------------------------------------------ +r16052 | lego | 2005-09-29 14:56:21 -0500 (Thu, 29 Sep 2005) | 3 lines +Changed paths: + M /trunk/tools/tpg/tpg.pl + M /trunk/tools/tpg/tpg.yp -Don't special-case the initial part of the processing of EAP messages; -put in the standard length item, as well as, for fragments, an item for -the fragment data. +another step closer -Check for non-consecutive EAP-Message attributes. -Set the columns non-writable while dissecting the EAP message, so -Protocol and Info reflect the RADIUS packet. +------------------------------------------------------------------------ +r16051 | etxrab | 2005-09-29 00:37:27 -0500 (Thu, 29 Sep 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-jxta.c -Doing the reassembly by gluing together all the consecutive EAP-Message -attributes means we don't need help from the EAP dissector, returning -the total length of the EAP message. Get rid of the no-longer-needed -eap_fragment dissector; just call the regular EAP dissector. +From Mike Duigou +A patch to allow the JXTA dissector to pass fuzz testing. It +also removes a couple of unused things and optimizes handling of the raw +data dissector. ------------------------------------------------------------------------ -r15045 | guy | 2005-07-24 15:10:05 -0500 (Sun, 24 Jul 2005) | 2 lines +r16050 | guy | 2005-09-28 21:20:29 -0500 (Wed, 28 Sep 2005) | 13 lines Changed paths: - M /trunk/epan + M /trunk/Makefile.am + A /trunk/diameter + A /trunk/diameter/dictionary.dtd (from /trunk/dictionary.dtd:16044) + A /trunk/diameter/dictionary.xml (from /trunk/dictionary.xml:16044) + A /trunk/diameter/imscxdx.xml (from /trunk/imscxdx.xml:16044) + A /trunk/diameter/mobileipv4.xml (from /trunk/mobileipv4.xml:16044) + A /trunk/diameter/nasreq.xml (from /trunk/nasreq.xml:16044) + A /trunk/diameter/sunping.xml (from /trunk/sunping.xml:16044) + D /trunk/dictionary.dtd + D /trunk/dictionary.xml + M /trunk/epan/dissectors/packet-cops.c + D /trunk/imscxdx.xml + D /trunk/mobileipv4.xml + D /trunk/nasreq.xml + M /trunk/packaging/nsis/ethereal.nsi + D /trunk/sunping.xml -sminmpec.c is now a generated file, so add it to the ignore list. +Move the Diameter dictionary files to a "diameter" subdirectory, along +the lines of what's done for RADIUS. That keeps them together (and +separate from other files), and makes the layout of the top-level source +directory closer to the layout of the installation directory, so that if +you run Ethereal or Tethereal from the top-level directory on Windows +it'll pick up the Diameter dictionary files (if it supports loading +them), and can do so on UN*X if we support a mechanism to let it find +its control files in the directory in which the binary resides. + +Use the diameter_DATA, dtds_DATA, and radius_DATA macros in the +EXTRA_DIST macro, so you only have to change the lists of Diameter, DTD, +and RADIUS files in one place if you add or remove a file. ------------------------------------------------------------------------ -r15044 | tuexen | 2005-07-24 14:58:05 -0500 (Sun, 24 Jul 2005) | 2 lines +r16049 | guy | 2005-09-28 20:31:19 -0500 (Wed, 28 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-smb.c -Fix a typo. +Make "top_tree" static; nobody else uses it, and if they're both not +static, they collide with one another in builds on at least some +platforms. ------------------------------------------------------------------------ -r15043 | guy | 2005-07-24 14:01:28 -0500 (Sun, 24 Jul 2005) | 9 lines +r16048 | ulfl | 2005-09-28 17:15:38 -0500 (Wed, 28 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-aim.h - M /trunk/epan/dissectors/packet-dcerpc-epm.c - M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-clnp.c M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-dcom.c - M /trunk/epan/dissectors/packet-dcom.h - M /trunk/epan/dissectors/packet-diameter.c - M /trunk/epan/dissectors/packet-giop.h - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-k12.c - M /trunk/epan/dissectors/packet-ntlmssp.c - M /trunk/epan/dissectors/packet-portmap.c - M /trunk/epan/dissectors/packet-pres.c - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-ldp.c + M /trunk/epan/dissectors/packet-mq.c + M /trunk/epan/dissectors/packet-ndmp.c M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-rpc.h - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-spnego.c - M /trunk/epan/dissectors/packet-tacacs.c - M /trunk/epan/dissectors/packet-tzsp.c - M /trunk/epan/dissectors/packet-user_encap.c - M /trunk/epan/packet.c - M /trunk/epan/packet.h - M /trunk/epan/prefs-int.h - M /trunk/epan/prefs.c - M /trunk/epan/proto.c - M /trunk/epan/proto.h - M /trunk/gtk/dcerpc_stat.c - M /trunk/gtk/decode_as_dcerpc.h - M /trunk/gtk/decode_as_dlg.c - M /trunk/gtk/dfilter_expr_dlg.c - M /trunk/gtk/prefs_dlg.c - M /trunk/gtk/proto_dlg.c - M /trunk/gtk/rpc_stat.c - M /trunk/gtk/supported_protos_dlg.c - M /trunk/tap-dcerpcstat.c - M /trunk/tap-rpcstat.c - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-smpp.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-x25.c + M /trunk/plugins/opsi/packet-opsi.c -Constify to remove a bunch of warnings. Add some casts to squelch -(presumably-)harmless-but-otherwise-unremovable const-to-nonconst -warnings. +fix #480: Change defaults for all reassembling settings to ON -In the TACACS dissector, clean up the variables used in option parsing -to avoid some const-to-nonconst warnings. +I've changed all settings I could find to TRUE. It might be reasonable to change some protocol settings back to FALSE, if reassembling fails very often. +------------------------------------------------------------------------ +r16047 | lego | 2005-09-28 16:35:14 -0500 (Wed, 28 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dtd_preparse.l + +be more flexible in what's a name -Clean up some white space. ------------------------------------------------------------------------ -r15042 | guy | 2005-07-24 12:48:10 -0500 (Sun, 24 Jul 2005) | 7 lines +r16046 | lego | 2005-09-28 16:33:44 -0500 (Wed, 28 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/reassemble.c + M /trunk/epan/stats_tree.c -"fragment_add_common()" isn't used outside this file - make it static. +one leak less... -Move to "show_fragment()" the code to append the fragment information to -the top-level item. -Fix indentation. +------------------------------------------------------------------------ +r16045 | lego | 2005-09-28 16:32:47 -0500 (Wed, 28 Sep 2005) | 9 lines +Changed paths: + M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/tvbparse.c + M /trunk/epan/tvbparse.h + +tvbparse.[ch]: +- add a tvbparse_handle() (for recursion) +- change tvbparse_until() to allow more control when parsing +- make the wanted control an union so that different types of data can be used + +packet-xml.c: +- change the parser definition to match changes to tvbparse_until() + ------------------------------------------------------------------------ -r15041 | ulfl | 2005-07-24 09:35:12 -0500 (Sun, 24 Jul 2005) | 1 line +r16044 | etxrab | 2005-09-28 15:06:58 -0500 (Wed, 28 Sep 2005) | 1 line Changed paths: - M /trunk/doc/ethereal.pod - M /trunk/doc/tethereal.pod + M /trunk/Makefile.am -from Graeme Hewson: "Fixes for ethereal config files" +Add radius/dictionary.ericsson \ ------------------------------------------------------------------------ -r15040 | ulfl | 2005-07-24 09:16:54 -0500 (Sun, 24 Jul 2005) | 1 line +r16043 | etxrab | 2005-09-28 14:57:45 -0500 (Wed, 28 Sep 2005) | 1 line Changed paths: - M /trunk/NEWS - M /trunk/tools/win32-setup.sh + M /trunk/epan/dissectors/packet-sigcomp.c -Update to zlib 1.2.3 +Handle sigcomp over TCP. ------------------------------------------------------------------------ -r15039 | ulfl | 2005-07-24 08:54:19 -0500 (Sun, 24 Jul 2005) | 1 line +r16042 | jmayer | 2005-09-28 12:16:30 -0500 (Wed, 28 Sep 2005) | 1 line Changed paths: - M /trunk/Makefile.nmake + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/etypes.h + M /trunk/manuf + M /trunk/wka.tmpl -Update to zlib 1.2.3 +Updates for foundry addresses/protocols ------------------------------------------------------------------------ -r15038 | jmayer | 2005-07-24 06:35:41 -0500 (Sun, 24 Jul 2005) | 6 lines +r16041 | etxrab | 2005-09-28 11:39:20 -0500 (Wed, 28 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/packaging/nsis/ethereal.nsi -Lars Ruoff: - Use correct offsets to decode bssid in all cases: - Depending on the packet type the header contains - up to 4 addresses but may contain less. The position/ - definition of the bssid changes as a result of this. +Add disctionary.ericsson +------------------------------------------------------------------------ +r16040 | etxrab | 2005-09-28 11:38:40 -0500 (Wed, 28 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/sigcomp_state_hdlr.c +It's the UDVM_MEMORY_SIZE that should be checked. ------------------------------------------------------------------------ -r15037 | guy | 2005-07-24 06:14:13 -0500 (Sun, 24 Jul 2005) | 8 lines +r16039 | guy | 2005-09-28 11:16:37 -0500 (Wed, 28 Sep 2005) | 5 lines Changed paths: - M /trunk/plugins/asn1/packet-asn1.c + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-esis.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-frame.h + M /trunk/epan/dissectors/packet-gsm_sms_ud.c + M /trunk/epan/dissectors/packet-msdp.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-pppoe.c + M /trunk/epan/dissectors/packet-smb-pipe.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-udp.c + M /trunk/epan/ftypes/ftype-string.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h -Register the port range preferences as such, rather than doing our own -range implementation. +Have show_exception() take a "const char *" as its exception message, +and not free the string to which it points. Pass to +REPORT_DISSECTOR_BUG() strings allocated with ep_strdup_printf(), so +that they're freed automatically. -Make string preferences "const", to squelch compiler warnings, and make -other variables and arguments "const" to match. +------------------------------------------------------------------------ +r16038 | guy | 2005-09-28 04:31:37 -0500 (Wed, 28 Sep 2005) | 7 lines +Changed paths: + M /trunk/epan/dissectors/packet-hsrp.c -Port numbers are unsigned; display them as such. +Don't change the Info column if we have an unknown opcode; we've already +set it to a value that should indicate that the opcode is unknown, and +also indicates what the value is. (Especially don't do it without +calling check_col() to check whether we *should* change the info column, +as we'll dereference a null pointer if we shouldn't; this change should +fix bug 489.) ------------------------------------------------------------------------ -r15036 | lego | 2005-07-24 05:32:37 -0500 (Sun, 24 Jul 2005) | 3 lines +r16037 | jmayer | 2005-09-28 03:14:54 -0500 (Wed, 28 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-sndcp.c + M /trunk/tools/fuzz-test.sh -register the dissector by name +In case the paths to the tools are wrong, inform the +user about it instead of complaining that no capture files +could be found. ------------------------------------------------------------------------ -r15035 | guy | 2005-07-24 05:32:22 -0500 (Sun, 24 Jul 2005) | 9 lines +r16036 | guy | 2005-09-28 03:01:54 -0500 (Wed, 28 Sep 2005) | 3 lines Changed paths: - M /trunk/plugins/stats_tree/Makefile.am - M /trunk/plugins/stats_tree/pinfo_stats_tree.c - A /trunk/plugins/stats_tree/pinfo_stats_tree.h - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/epan/dissectors/packet-snmp.c -Add "pinfo_stats_tree.h" to declare "register_pinfo_stat_trees()", and -include it in "pinfo_stats_tree.c" (which defines it) and -"stats_tree_plugin.c" (which refers to it). +Note that we should redo the handling of OIDs when +"dissect_ber_object_identifier()" can return the OID in a binary form. -Make all the other routines defined in "pinfo_stats_tree.c" static, as -they're not used outside "pinfo_stats_tree.c". +------------------------------------------------------------------------ +r16035 | obiot | 2005-09-28 02:08:57 -0500 (Wed, 28 Sep 2005) | 11 lines +Changed paths: + M /trunk/epan/proto.c -Get rid of declaration of unused "register_http_stat_trees()". +The TRY_TO_FAKE_THIS_ITEM() speed optimization has a side effect in that it +will only process FT_PROTOCOL fields. As a result, proto_item_append_string() +calls may throw a dissector exception, as only a FT_STRING or FT_STRINGZ can be +appended to with this call. + +In order to prevent these dissector assertions, silently return from the append +call if the field is a FT_PROTOCOL. + +Note that when the tree is visible, the updates of the fields occur normally, +as expected. ------------------------------------------------------------------------ -r15034 | sahlberg | 2005-07-23 23:24:30 -0500 (Sat, 23 Jul 2005) | 3 lines +r16034 | etxrab | 2005-09-28 00:16:51 -0500 (Wed, 28 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-mq.c - M /trunk/epan/dissectors/packet-sdp.c - M /trunk/epan/dissectors/packet-slsk.c - M /trunk/epan/dissectors/packet-tacacs.c - M /trunk/epan/dissectors/packet-ucp.c - M /trunk/epan/dissectors/packet-uma.c + M /trunk/Makefile.am -some more ep_tvb_get_string updates +Add dictionarry.ericsson +------------------------------------------------------------------------ +r16033 | lego | 2005-09-27 20:17:45 -0500 (Tue, 27 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-xml.c + +make sure we tell tvbparse_until() to include the last token. ------------------------------------------------------------------------ -r15033 | lego | 2005-07-23 22:36:21 -0500 (Sat, 23 Jul 2005) | 3 lines +r16032 | lego | 2005-09-27 20:06:39 -0500 (Tue, 27 Sep 2005) | 6 lines Changed paths: - M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.nmake - A /trunk/epan/enterprise-numbers - A /trunk/epan/make-sminmpec.pl - D /trunk/epan/sminmpec.c + M /trunk/epan/tpg.h + M /trunk/epan/tvbparse.c + M /trunk/plugins/tpg/http.tpg + M /trunk/tools/tpg/tpg.pl + M /trunk/tools/tpg/tpg.yp + +update tpg -Autogenerate the sminmpec.c file from iana's enterprise-numbers file +tvbparse: + - for tvbparse_until spend the target token even if it isn't included ------------------------------------------------------------------------ -r15032 | lego | 2005-07-23 22:05:08 -0500 (Sat, 23 Jul 2005) | 3 lines +r16031 | lego | 2005-09-27 17:57:07 -0500 (Tue, 27 Sep 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/tvbparse.c + M /trunk/epan/tvbparse.h + +in tvbparse: + - tvbparse_some now handles 0 items. + - added accessors for a tt's offset and remaining length. -fix a leak of tap info data by replacing g_strdup with ep_strdup +in packet-xml: + - min_len=0 for tvbparse_chars() is soon going to mean zero instead of 1 change the 0s to 1s. + - attribute names can have ':' even if it's namespaces isn't managed yet. + - split the xml grammar in more elements so It can be actually read by a human being. ------------------------------------------------------------------------ -r15031 | sahlberg | 2005-07-23 22:01:41 -0500 (Sat, 23 Jul 2005) | 6 lines +r16030 | lego | 2005-09-27 17:06:36 -0500 (Tue, 27 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-msrp.c - M /trunk/epan/dissectors/packet-pagp.c - M /trunk/epan/dissectors/packet-q931.c - M /trunk/epan/dissectors/packet-quake2.c - M /trunk/epan/dissectors/packet-rsvp.c - M /trunk/epan/dissectors/packet-rtcp.c - M /trunk/epan/dissectors/packet-rtsp.c + A /trunk/plugins/tpg + A /trunk/plugins/tpg/Makefile.am + A /trunk/plugins/tpg/Makefile.nmake + A /trunk/plugins/tpg/http.tpg + A /trunk/plugins/tpg/packet-http.c -some more dissectors converted to ep_tvb_get_string +A "working" example of TPG... -again at least one obvious memleak was found in the old code +------------------------------------------------------------------------ +r16029 | lego | 2005-09-27 16:56:14 -0500 (Tue, 27 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/tpg.c + +http_dissector_add doesn't belong here! ------------------------------------------------------------------------ -r15030 | lego | 2005-07-23 21:59:17 -0500 (Sat, 23 Jul 2005) | 3 lines +r16028 | lego | 2005-09-27 16:54:45 -0500 (Tue, 27 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-alcap.c + M /trunk/tools/tpg/tpg.pl -use ep_alloc instead of statically allocated buffers +now it starts to work... ------------------------------------------------------------------------ -r15029 | lego | 2005-07-23 21:56:41 -0500 (Sat, 23 Jul 2005) | 2 lines +r16027 | ulfl | 2005-09-27 16:51:08 -0500 (Tue, 27 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-actrace.c + M /trunk/gtk/font_utils.c + M /trunk/gtk/gui_prefs.c + M /trunk/gtk/menu.c + M /trunk/gtk/packet_list.c + M /trunk/gtk/packet_list.h + M /trunk/gtk/stream_prefs.c -change g_strdup() calls with ep_strdup calls (fixing a significant leakage of tap data) +code cleanup: use the prefix packet_list_ for every function mentioned in packet_list.h +------------------------------------------------------------------------ +r16026 | jmayer | 2005-09-27 16:50:50 -0500 (Tue, 27 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-hsrp.c +Op Code 3 (Advertisement) dissection ------------------------------------------------------------------------ -r15028 | lego | 2005-07-23 21:53:09 -0500 (Sat, 23 Jul 2005) | 6 lines +r16025 | ulfl | 2005-09-27 16:48:17 -0500 (Tue, 27 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radius.c - M /trunk/epan/dissectors/packet-radius.h + M /trunk/capture_loop.c -- change the report_failure dialog for a less painful g_warning -- use ep_alloc for reassemling eap fragments instead of a static buffer -- use ep_strdup_printf() instead of a static buffe to return the cosine's VP/VC AVP label -- add few TODO comments +mention "http://wiki.ethereal.com/CaptureSetup" in the error dialog, when the capture interface couldn't be opened +------------------------------------------------------------------------ +r16024 | ulfl | 2005-09-27 16:46:39 -0500 (Tue, 27 Sep 2005) | 1 line +Changed paths: + M /trunk/file.c +minor bugfix: call cf_callback_invoke() from cf_close() even if the file is already closed. Otherwise the GUI will remain in the wrong state if a capture couldn't be started (e.g. wrong interface). +------------------------------------------------------------------------ +r16023 | ulfl | 2005-09-27 16:44:46 -0500 (Tue, 27 Sep 2005) | 1 line +Changed paths: + M /trunk/docbook/edg_src/EDG_chapter_sources.xml +add a new subsection "Code Requirements" and mention fuzz testing there ------------------------------------------------------------------------ -r15027 | sahlberg | 2005-07-23 21:43:41 -0500 (Sat, 23 Jul 2005) | 6 lines +r16022 | etxrab | 2005-09-27 16:04:59 -0500 (Tue, 27 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-3g-a11.c - M /trunk/epan/dissectors/packet-afp.c - M /trunk/epan/dissectors/packet-aim-messaging.c - M /trunk/epan/dissectors/packet-aim.c - M /trunk/epan/dissectors/packet-ansi_a.c - M /trunk/epan/dissectors/packet-atalk.c - M /trunk/epan/dissectors/packet-bacapp.c - M /trunk/epan/dissectors/packet-dsi.c - M /trunk/epan/dissectors/packet-fix.c - M /trunk/epan/dissectors/packet-gtp.c - M /trunk/epan/dissectors/packet-icep.c + M /trunk/radius/dictionary + A /trunk/radius/dictionary.ericsson -convert some uses of tvb_get_string() to ep_tvb_get_string() +Add a miniscule ericsson radius dictionary. +------------------------------------------------------------------------ +r16021 | lego | 2005-09-27 15:48:48 -0500 (Tue, 27 Sep 2005) | 9 lines +Changed paths: + A /trunk/epan/tpg.c + A /trunk/epan/tpg.h + A /trunk/tools/tpg + A /trunk/tools/tpg/Makefile.am + A /trunk/tools/tpg/Makefile.nmake + A /trunk/tools/tpg/V2P.pm + A /trunk/tools/tpg/tpg.pl + A /trunk/tools/tpg/tpg.yp + +TPG TVB Parser Generator -there was at least one obvious memleak in one of the uses of tvb_get_string() +Given a bnf-like grammar generate a set of helpers for a dissector +It's not working yet, however I need this checkin as a cheeckpoint + +(I'll write the doc when it starts to be ready) ------------------------------------------------------------------------ -r15026 | lego | 2005-07-23 21:43:20 -0500 (Sat, 23 Jul 2005) | 5 lines +r16020 | kukosa | 2005-09-27 05:05:42 -0500 (Tue, 27 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/epan/dissectors/packet-h225.c -Replace two calls to tvb_get_string with the new ep_tvb_get_string (this fixes a leak I introdduced at the last checkin) +new option whether tunnelled H.245 and tunnelled protocol are displayed inside H.225 tree or outside +------------------------------------------------------------------------ +r16019 | sahlberg | 2005-09-27 03:03:13 -0500 (Tue, 27 Sep 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcels.c -remove the stat_infos PtrArray as we do not need to free our tap data anymore, YEAH! +remove all strcpy from fcels +ito make it easier to read use doublespace to separate the items on the expansion line instead of ',' since so many of the strings contain spaces. + +cleanup fc slightly and remove a redundant parameter ------------------------------------------------------------------------ -r15025 | lego | 2005-07-23 21:12:33 -0500 (Sat, 23 Jul 2005) | 3 lines +r16018 | kukosa | 2005-09-27 02:14:07 -0500 (Tue, 27 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/Makefile.common - D /trunk/gtk/isup_stat.c - -Remove the isup messages tap as it's been superceeded by the stats_tree one - + M /trunk/epan/dissectors/packet-per.c +bug in dissect_per_object_identifier_str() fixed, wrong pointer was passed to oid_to_str() ------------------------------------------------------------------------ -r15024 | sahlberg | 2005-07-23 20:56:01 -0500 (Sat, 23 Jul 2005) | 6 lines +r16017 | kukosa | 2005-09-27 01:09:14 -0500 (Tue, 27 Sep 2005) | 1 line Changed paths: - M /trunk/epan/tvbuff.c - M /trunk/epan/tvbuff.h + M /trunk/epan/except.c + M /trunk/epan/except.h -add -ep_tvb_get_string -that acts the same as tvb_get_string but the buffer returned need not be freed. +get rid of warnings about qualifier discarding +------------------------------------------------------------------------ +r16016 | etxrab | 2005-09-27 00:39:58 -0500 (Tue, 27 Sep 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-tpkt.c +- Make the reassemble TCP preference default TRUE. +- in dissect_tpkt_encap() only check the desegment flag passed in the function. ------------------------------------------------------------------------ -r15023 | lego | 2005-07-23 20:48:01 -0500 (Sat, 23 Jul 2005) | 5 lines +r16015 | guy | 2005-09-26 19:03:45 -0500 (Mon, 26 Sep 2005) | 17 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-radius.c -From Alejandro Vaquero: +Give more details about too-short AVPs, give up immediately for AVPs +shorter than 2 bytes, and make the item for an AVP with a length < 2 a +generated item. -fix a crash when graphing packets whose src and dst is the same address +Put the top-level item for an AVP into the tree the same way regardless +of whether it's Vendor-Specific or not, and skip past the type and +length right after that, before we check for Vendor-Specific. (This +means we no longer treat "vendor ID = 0" as an indication that this +isn't Vendor-Specific - nothing prevents a packet from getting onto the +wire with a vendor ID of 0; this fixes bug 485.) +Don't require a Vendor-Specific AVP to be at least 6 bytes long; it +might not be particularly useful to have one that has a vendor ID and +nothing else, but we might as well dissect the vendor ID portion. + +Do some other cleanups. ------------------------------------------------------------------------ -r15022 | lego | 2005-07-23 20:42:41 -0500 (Sat, 23 Jul 2005) | 5 lines +r16014 | obiot | 2005-09-26 15:49:33 -0500 (Mon, 26 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-wsp.c -move the stats_tree tap into the http dissector (not anymore in the plugin) +Part 2 of the fix: also add the correct offset for non-WSP address records. -change several calls to g_memdup into ep_strndup, fix the free calls +------------------------------------------------------------------------ +r16013 | guy | 2005-09-26 15:34:13 -0500 (Mon, 26 Sep 2005) | 5 lines +Changed paths: + M /trunk/epan/proto.h +Make "REPORT_DISSECTOR_BUG()" (and the macros that use it) call +"abort()" if the ETHEREAL_ABORT_ON_DISSECTOR_BUG environment variable is +set; this is for debugging purposes, to make it easier to get a stack +trace of the offending call. ------------------------------------------------------------------------ -r15021 | lego | 2005-07-23 20:39:04 -0500 (Sat, 23 Jul 2005) | 3 lines +r16012 | obiot | 2005-09-26 15:00:37 -0500 (Mon, 26 Sep 2005) | 8 lines Changed paths: - M /trunk/plugins/stats_tree/Makefile.am - M /trunk/plugins/stats_tree/Makefile.nmake - D /trunk/plugins/stats_tree/http_stats_tree.c - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/epan/dissectors/packet-wsp.c -http_stats_tree is moving to a new home (packet-http.c) +Fix WSP redirect and SIR address parsing: + - The incorrect number of octets were highlighted (bearer type and port number + were disregarded). + + - In SIR version 1 content, correct the parsing (full WSP address length was + not added to the offset for parsing the non-WSP contact points). ------------------------------------------------------------------------ -r15020 | lego | 2005-07-23 20:31:59 -0500 (Sat, 23 Jul 2005) | 3 lines +r16011 | ulfl | 2005-09-26 14:24:06 -0500 (Mon, 26 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/Makefile.common - D /trunk/gtk/http_stat.c - -remove the old http packet count tap as it has been superceeded by the new stats tree tap + M /trunk/gtk/prefs_dlg.c +fix #322, 2nd try: don't pass NULL to gtk_tree_iter_free(), this seems to cause an assert on some GTK versions +------------------------------------------------------------------------ +r16010 | etxrab | 2005-09-26 13:18:06 -0500 (Mon, 26 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/format-oid.h + M /trunk/epan/dissectors/packet-cops.c +Remove dependencies on asn1.c, stil endes to be included to define subid_t. ------------------------------------------------------------------------ -r15019 | lego | 2005-07-23 20:21:38 -0500 (Sat, 23 Jul 2005) | 5 lines +r16009 | sahlberg | 2005-09-26 05:11:38 -0500 (Mon, 26 Sep 2005) | 13 lines Changed paths: - M /trunk/epan/emem.c + M /trunk/epan/dissectors/packet-fc.c -I believe we should use DISSECTOR_ASSERT instead of g_assert. +remove all strcpy() from packet-fc.c + +rewrite the functions to do proto_item_append_text() instead of building a string and then printing it. + +The new function is functionally equivalent to the previous function except it does not print the values of the multi-bit fields to the expansion +(the expansion line is already a km wide as it is) + + + +there are now only 202 strcpy() left in epan/dissectors down from 300+ instances some weeks ago. -fix and clean g_strdup_printf() ------------------------------------------------------------------------ -r15018 | lego | 2005-07-23 19:29:57 -0500 (Sat, 23 Jul 2005) | 8 lines +r16008 | guy | 2005-09-26 03:48:19 -0500 (Mon, 26 Sep 2005) | 13 lines Changed paths: - M /trunk/epan/emem.c - M /trunk/epan/emem.h + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-radius.h + M /trunk/epan/radius_dict.l + +Add a new "ipxnet" type for the RADIUS dictionary, for IPX network +numbers. (Currently, we don't have any dictionary entries with that +type, although we have an attribute with special code to handle it that +uses that type.) -add some utility functions that use ep_alloc instead of g_malloc. +Specially handle Framed-IP-Address, Login-IP-Host, and +Framed-IPX-Network, so that the special values are displayed specially. -ep_memdup -ep_strdup -ep_strndup -ep_strdup_printf +Clean up indentation. +Don't specify a number base for IPv4 or IPv6 addresses; the number base +is ignored. ------------------------------------------------------------------------ -r15017 | ulfl | 2005-07-23 15:37:00 -0500 (Sat, 23 Jul 2005) | 1 line +r16007 | guy | 2005-09-26 03:44:31 -0500 (Mon, 26 Sep 2005) | 3 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-gtp.c + +Use VENDOR_THE3GPP, rather than a hardcoded 10415, for the vendor ID for +the 3GPP. -... I should switch compression back on, the installer would otherwise become a bit large ... ------------------------------------------------------------------------ -r15016 | ulfl | 2005-07-23 15:34:43 -0500 (Sat, 23 Jul 2005) | 12 lines +r16006 | ulfl | 2005-09-26 02:08:42 -0500 (Mon, 26 Sep 2005) | 1 line Changed paths: - A /trunk/packaging/nsis/AdditionalTasksPage.ini - M /trunk/packaging/nsis/Makefile.am - M /trunk/packaging/nsis/Makefile.nmake - A /trunk/packaging/nsis/WinPcapPage.ini - A /trunk/packaging/nsis/WinPcap_3_0.exe - M /trunk/packaging/nsis/ethereal.nsi - A /trunk/packaging/nsis/servicelib.nsh + M /trunk/gtk/packet_list.c + +compiler warning removed +------------------------------------------------------------------------ +r16005 | etxrab | 2005-09-26 00:43:25 -0500 (Mon, 26 Sep 2005) | 9 lines +Changed paths: + M /trunk/epan/dissectors/packet-stun.c + M /trunk/epan/dissectors/packet-ymsg.c + +From Martin Mathieson: +stun - add support for 3 extra Message Attributes as described in draft-ietf-behave-rfc3489bis-00 + +ymsg + - avoid looking beyond the tvb while looking for content item delimiters (causing most frames to be shown as malformed packet) +- makes content items (and their keys and values) filterable (includes fix to bug 415) -Installer: -- Installer now includes and installs WinPcap 3.0 (with detection) -- Install Sections are grouped now -- New Seperate page to select additional tasks like: icons, file extensions ... -- New Seperate page for WinPcap detection/installation -- Start WinPcap "NPF" service doesn't require a reboot -Uninstaller: -- New Uninstall sections page (uninstall, settings, plugins, WinPcap) -- If uninstallation selected, plugins will now be completely uninstalled (all versions, not only the current one) -- If selected, uninstallation of WinPcap ------------------------------------------------------------------------ -r15015 | jmayer | 2005-07-23 06:41:25 -0500 (Sat, 23 Jul 2005) | 2 lines +r16004 | ulfl | 2005-09-25 17:46:49 -0500 (Sun, 25 Sep 2005) | 3 lines Changed paths: - M /trunk/clopts_common.c - M /trunk/clopts_common.h - M /trunk/disabled_protos.c - M /trunk/epan/addr_resolv.c - M /trunk/epan/asn1.c - M /trunk/epan/asn1.h - M /trunk/epan/column.c - M /trunk/epan/column.h - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-giop.c - M /trunk/epan/dissectors/packet-giop.h - M /trunk/epan/filesystem.c - M /trunk/epan/filesystem.h - M /trunk/epan/packet.c - M /trunk/epan/packet.h - M /trunk/epan/packet_info.h - M /trunk/epan/prefs.c - M /trunk/epan/prefs.h - M /trunk/epan/proto.c - M /trunk/epan/proto.h - M /trunk/epan/stats_tree.c - M /trunk/epan/stats_tree.h - M /trunk/epan/tap.c - M /trunk/epan/tap.h - M /trunk/epan/to_str.c - M /trunk/epan/xdlc.c - M /trunk/plugins/gryphon/packet-gryphon.c - M /trunk/plugins/gryphon/packet-gryphon.h - M /trunk/plugins/irda/irda-appl.h - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_grammar.lemon - M /trunk/plugins/mate/mate_parser.l - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/mate_util.c - M /trunk/plugins/mate/mate_util.h - M /trunk/plugins/mate/packet-mate.c - M /trunk/plugins/mgcp/packet-mgcp.c - M /trunk/plugins/opsi/packet-opsi.h - M /trunk/plugins/profinet/packet-pn-dcp.c - M /trunk/plugins/rlm/packet-rlm.c - M /trunk/print.c - M /trunk/randpkt.c - M /trunk/tap-iousers.c - M /trunk/tethereal.c - M /trunk/text2pcap.c - M /trunk/tools/lemon/lempar.c + M /trunk/gtk/prefs_dlg.c -More 'char*' -> 'const char*' changes to fix warnings. +fix #322: packet detail window -> Protocol Preferences: tree not expanded +also removed global notebook value ------------------------------------------------------------------------ -r15014 | jmayer | 2005-07-23 03:18:44 -0500 (Sat, 23 Jul 2005) | 1 line +r16003 | gerald | 2005-09-25 17:19:57 -0500 (Sun, 25 Sep 2005) | 3 lines Changed paths: - M /trunk/plugins/asn1/packet-asn1.c + M /trunk/docbook/release-notes.xml + M /trunk/plugins/agentx/packet-agentx.c + +Don't write before the beginning of a buffer. Add an item to the +release notes. -'char*' -> 'const char*' to fix warnings ------------------------------------------------------------------------ -r15013 | jmayer | 2005-07-23 01:53:59 -0500 (Sat, 23 Jul 2005) | 3 lines +r16002 | guy | 2005-09-25 04:32:01 -0500 (Sun, 25 Sep 2005) | 17 lines Changed paths: - M /trunk/epan/dfilter/dfilter-int.h - M /trunk/epan/dfilter/dfilter.c + M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-gsm_map.c + +A loop processing all the bytes in a tvbuff from a given offset to the +end of the data in the tvbuff should stop when the offset is >= the +total amount of data in the tvbuff, not when it's > the total amount in +the tvbuff following the starting offset. + +In "unpack_digits()", return a null string, not a null pointer, if +there's nothing left in the tvbuff starting at the starting offset, so +that the caller doesn't have to check for a null pointer, and return an +ep_alloc()ed buffer, so the caller doesn't have to worry about freeing +the result. -Some more 'char*' -> 'const char*' changes +If we see a filler digit, don't advance the offset in the string buffer; +we want to put the terminating '\0' right after the character we just +put into the string. +Fuzzed against some GSM captures. ------------------------------------------------------------------------ -r15012 | jmayer | 2005-07-23 01:51:57 -0500 (Sat, 23 Jul 2005) | 4 lines +r16001 | guy | 2005-09-25 04:07:41 -0500 (Sun, 25 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dfilter/gencode.c - M /trunk/epan/dfilter/semcheck.c + M /trunk/epan/dissectors/packet-ber.c -Add includes to fix warnings of type -gencode.c:383: warning: no previous declaration for - 'dfw_interesting_fields' +Show unsigned quantities as such. ------------------------------------------------------------------------ -r15011 | jmayer | 2005-07-23 01:49:07 -0500 (Sat, 23 Jul 2005) | 8 lines +r16000 | guy | 2005-09-25 04:06:48 -0500 (Sun, 25 Sep 2005) | 8 lines Changed paths: - M /trunk/epan/dfilter/syntax-tree.c - M /trunk/epan/dfilter/syntax-tree.h + M /trunk/epan/dissectors/packet-dcerpc.c -Move declaration of sttype_register_* functions from -syntax-tree.c to syntax-tree.h. +If "dissect_dcerpc_cn()" throws an exception when called by +"dissect_dcerpc_cn_bs_body()", it's because it recognized the packet as +a DCE RPC packet, but it ran out of data dissecting it as such; +increment the count of DCE RPC PDUs, so "dissect_dcerpc_cn_bs_body()" +returns TRUE, and its caller doesn't think nothing was dissected. -This fixes some warning of type -sttype-integer.c:33: warning: no previous declaration for - 'sttype_register_integer' +Fuzzed with some DCE RPC captures. + +------------------------------------------------------------------------ +r15999 | lego | 2005-09-24 21:50:03 -0500 (Sat, 24 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-radius.c + +test the avp_vsa_len not the avp_lenght! ------------------------------------------------------------------------ -r15010 | jmayer | 2005-07-23 01:21:17 -0500 (Sat, 23 Jul 2005) | 6 lines +r15998 | lego | 2005-09-24 21:48:53 -0500 (Sat, 24 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/ftypes/ftype-bytes.c - M /trunk/epan/ftypes/ftypes-int.h - M /trunk/epan/ftypes/ftypes.c + M /trunk/epan/dissectors/packet-radius.c + +Don't ASSERT if a VSA is too short, add an item reporting the error and leave. -Move declaration of void ftype_register_* to ftypes-int.h. -This fixes some warnings like -ftype-bytes.c:52: warning: no previous declaration for 'bytes_fvalue_free' +------------------------------------------------------------------------ +r15997 | lego | 2005-09-24 21:44:37 -0500 (Sat, 24 Sep 2005) | 2 lines +Changed paths: + M /trunk/dtds/rss.dtd +rating was defined twice ------------------------------------------------------------------------ -r15009 | jmayer | 2005-07-23 01:19:08 -0500 (Sat, 23 Jul 2005) | 5 lines +r15996 | sahlberg | 2005-09-24 20:44:23 -0500 (Sat, 24 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/ftypes/ftypes.h + M /trunk/epan/dissectors/packet-ospf.c + +remove some redundant code that would always evaluate to true anyway. + -Fix lots of warnings of type: -ftypes.c:257: warning: passing argument 1 of 'logfunc' discards - qualifiers from pointer target type -by changing 'char*' -> 'const char*' ------------------------------------------------------------------------ -r15008 | lego | 2005-07-22 21:07:02 -0500 (Fri, 22 Jul 2005) | 3 lines +r15995 | sahlberg | 2005-09-24 18:25:38 -0500 (Sat, 24 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/packet-fcp.c -avoid a crash when tree is null +prettify the previous patch + +remove the remaining strcpy() from this dissector and make it decode the bitmap PROPERLY. ------------------------------------------------------------------------ -r15007 | sahlberg | 2005-07-22 19:46:14 -0500 (Fri, 22 Jul 2005) | 5 lines +r15994 | sahlberg | 2005-09-24 17:43:15 -0500 (Sat, 24 Sep 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-fcp.c + +refactor the "dissector" for task management flags to dissect the bits properly +and get rid of the silly strcpy() stuff. + -ICMP MPLS updates and a new preference option from -Brice Augustin and Maria-Luiza +there is a HUGE number of these kinds of very ugly bitmap dissection in all the fibre channel related dissectors and all need to be converted to proer dissection. ------------------------------------------------------------------------ -r15006 | sahlberg | 2005-07-22 19:42:31 -0500 (Fri, 22 Jul 2005) | 3 lines +r15993 | sahlberg | 2005-09-24 16:22:24 -0500 (Sat, 24 Sep 2005) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ospf.c -add back two entries that must have been removed by mistake +remove an array from the stack, remove some strcpy() and strcat() calls ------------------------------------------------------------------------ -r15005 | sahlberg | 2005-07-22 19:22:02 -0500 (Fri, 22 Jul 2005) | 6 lines +r15992 | sahlberg | 2005-09-24 16:14:47 -0500 (Sat, 24 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-hclnfsd.c - M /trunk/epan/dissectors/packet-mount.c - M /trunk/epan/dissectors/packet-nfs.c - M /trunk/epan/dissectors/packet-pcnfsd.c - M /trunk/epan/dissectors/packet-ypserv.c + M /trunk/epan/dissectors/packet-quakeworld.c -we no longer need to g_free() teh string returned by dissect_rpc_string. +get rid of one array from the stack and convert all strcpy() to pointers to literal strings. -when checking the calls in packet-ndmp.c we must have had a memleak there since it never freed those strings. +------------------------------------------------------------------------ +r15991 | guy | 2005-09-24 14:09:40 -0500 (Sat, 24 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-isakmp.c +Squelch some compiler warnings. ------------------------------------------------------------------------ -r15004 | sahlberg | 2005-07-22 18:38:51 -0500 (Fri, 22 Jul 2005) | 2 lines +r15990 | lego | 2005-09-24 14:03:35 -0500 (Sat, 24 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/emem.c + M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/dtd_grammar.lemon + M /trunk/epan/dtd_parse.l + +get rid of most dtd leaks. +There's just one left I'm aware of (the doctype name). -include stdlib instead of malloc.h ------------------------------------------------------------------------ -r15003 | sahlberg | 2005-07-22 18:33:12 -0500 (Fri, 22 Jul 2005) | 5 lines +r15989 | lego | 2005-09-24 11:37:48 -0500 (Sat, 24 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-rpc.c + D /trunk/plugins/xml -recode tvb_memdup() into more efficient emem fucntions. -Now that we dont have to free() the memory explicitely we got rid of a few unnessecary g_strdup() as well. +delete the xml plugin +------------------------------------------------------------------------ +r15988 | jmayer | 2005-09-24 10:52:42 -0500 (Sat, 24 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-isakmp.c + +That code was never even compiled for testing +------------------------------------------------------------------------ +r15987 | jmayer | 2005-09-24 10:42:37 -0500 (Sat, 24 Sep 2005) | 10 lines +Changed paths: + M /trunk/epan/dissectors/packet-isakmp.c + +Shoichi Sakane: +Hi, I fixed some bugs to decoding IKEv2 payloads. the following things +have been checked at the IPsec bake off in Toronto this week. + + - fixed decoding IP address in TS payload + - fixed decoding IPv6 address in ID payload + - fixed decoding IKEv2 Delete payload + - SPI printing ------------------------------------------------------------------------ -r15002 | etxrab | 2005-07-22 18:12:26 -0500 (Fri, 22 Jul 2005) | 1 line +r15986 | lego | 2005-09-24 10:07:38 -0500 (Sat, 24 Sep 2005) | 4 lines Changed paths: - D /trunk/epan/dissectors/packet-mms-control.c - D /trunk/epan/dissectors/packet-mms-data.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/radius_dict.l + +- There can be '/' in attribute names as well +- 140Kb of leaks less. + -No longer needed ------------------------------------------------------------------------ -r15001 | etxrab | 2005-07-22 18:11:11 -0500 (Fri, 22 Jul 2005) | 3 lines +r15985 | sahlberg | 2005-09-23 16:33:02 -0500 (Fri, 23 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-ms-mms.c + M /trunk/epan/dissectors/packet-irc.c + +From MartinM + +IRC update and fix for bug 218 -From Martin Mathieson: -Collapsed the control and data protocols into dissector to cope with commands and data over the same TCP connection. I've also prettified things a bit and now decoded a few more command parameters. ------------------------------------------------------------------------ -r15000 | sahlberg | 2005-07-22 18:04:52 -0500 (Fri, 22 Jul 2005) | 4 lines +r15984 | jmayer | 2005-09-23 16:27:03 -0500 (Fri, 23 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-mmse.c + M /trunk/tools/Makefile.am + +Add MANIFEST +------------------------------------------------------------------------ +r15983 | sahlberg | 2005-09-23 16:26:09 -0500 (Fri, 23 Sep 2005) | 5 lines +Changed paths: + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-dcerpc-netlogon.c -recode the tvb_memdup() to use emem calls. +From Kaul +One of the "unknown" fields are actually a digest. ------------------------------------------------------------------------ -r14999 | sahlberg | 2005-07-22 17:56:08 -0500 (Fri, 22 Jul 2005) | 3 lines +r15982 | sahlberg | 2005-09-23 15:51:09 -0500 (Fri, 23 Sep 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-ipdc.c + M /trunk/epan/dissectors/packet-radius.c -remove a redundant tvb_memdup() and fix a potential buffer overflow at the same time. +Dont decrement the length by 2 if it is already less than two +since then the length will wrap and become +4G or so. + +This fixes bug 479 ------------------------------------------------------------------------ -r14998 | sahlberg | 2005-07-22 17:45:36 -0500 (Fri, 22 Jul 2005) | 3 lines +r15981 | ulfl | 2005-09-23 13:50:07 -0500 (Fri, 23 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-armagetronad.c + M /trunk/gtk/file_dlg.c -replace one tvb_memdup() with a tvb_memcpy() using an automatically freed emem buffer +disable gzip output compression for now, as it won't work in some cases (see source commment for details) +------------------------------------------------------------------------ +r15980 | ulfl | 2005-09-23 13:27:30 -0500 (Fri, 23 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/tvbuff.c +as tvb functions are frequently used by a lot of dissectors, use DISSECTOR_ASSERT() like instead of g_assert throughout tvbuff, so a malicious dissector won't crash Ethereal (at least at the ways we can detect it) +of course this won't catch e.g. NULL pointers, but far better than nothing ... ------------------------------------------------------------------------ -r14997 | jmayer | 2005-07-22 12:57:40 -0500 (Fri, 22 Jul 2005) | 1 line +r15979 | ulfl | 2005-09-23 13:05:36 -0500 (Fri, 23 Sep 2005) | 1 line Changed paths: - M /trunk/epan/prefs.c - M /trunk/tools/lemon/lemon.c - M /trunk/wiretap/ascend-grammar.y - M /trunk/wiretap/ascend-int.h - M /trunk/wiretap/wtap.h + M /trunk/epan/dissectors/packet-frame.c -Fix some warnings (and one of my previous 'fixes') +show the same [Packet size limited during capture] message in the column info, instead of the former (unintuitive) [Short Frame] ------------------------------------------------------------------------ -r14996 | jmayer | 2005-07-22 12:55:47 -0500 (Fri, 22 Jul 2005) | 1 line +r15978 | ulfl | 2005-09-23 12:53:37 -0500 (Fri, 23 Sep 2005) | 1 line Changed paths: - M /trunk/epan/emem.c - M /trunk/epan/emem.h + M /trunk/docbook/developer-guide.xml -Set svn:keywords and svn:eol-style +The Ethereal version is 0.10.12 for some time now ... ------------------------------------------------------------------------ -r14995 | gerald | 2005-07-22 11:43:05 -0500 (Fri, 22 Jul 2005) | 2 lines +r15977 | ulfl | 2005-09-23 12:26:59 -0500 (Fri, 23 Sep 2005) | 3 lines Changed paths: - M /trunk/NEWS - M /trunk/config.nmake - M /trunk/configure.in + M /trunk/docbook/edg_src/EDG_chapter_tools.xml -Bump the version and add a few entries to the NEWS file. +from Jaap Keuter: fixed the package names for yacc and lexx (being bison and flex) +and from myself: add a section about GNU unzip and add it to the optional tools ------------------------------------------------------------------------ -r14994 | etxrab | 2005-07-22 10:55:06 -0500 (Fri, 22 Jul 2005) | 3 lines +r15976 | ulfl | 2005-09-23 12:01:19 -0500 (Fri, 23 Sep 2005) | 1 line Changed paths: - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h + M /trunk/epan/dissectors/packet-pn-rt.c + +when I've done the last change here, I wasn't expecting to get an fcs_len value of -1, fixed now +------------------------------------------------------------------------ +r15975 | sahlberg | 2005-09-23 05:39:58 -0500 (Fri, 23 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-lldp.c + +remove some compiler warnings -From Hannes Gredler: -support for support for DLT_JUNIPER_MLPPP ------------------------------------------------------------------------ -r14993 | gerald | 2005-07-22 10:51:20 -0500 (Fri, 22 Jul 2005) | 2 lines +r15974 | sahlberg | 2005-09-23 05:31:39 -0500 (Fri, 23 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-dcerpc.c + +remove some compiler warnings -Fix a potential memory leak. ------------------------------------------------------------------------ -r14992 | etxrab | 2005-07-22 10:20:57 -0500 (Fri, 22 Jul 2005) | 2 lines +r15973 | etxrab | 2005-09-23 00:38:10 -0500 (Fri, 23 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dnp.c + M /trunk/radius/dictionary.3gpp -From Graham Bloice -updates. +Add som 3GPP AVP:s ------------------------------------------------------------------------ -r14991 | etxrab | 2005-07-22 08:37:19 -0500 (Fri, 22 Jul 2005) | 1 line +r15972 | ulfl | 2005-09-22 18:18:34 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/Makefile.nmake + M /trunk/config.nmake + M /trunk/tools/win32-setup.sh -From Maynard, Chris. +replace WinPcap devel pack 3.0 with current 3.1 version ------------------------------------------------------------------------ -r14990 | kukosa | 2005-07-22 05:38:22 -0500 (Fri, 22 Jul 2005) | 1 line +r15971 | gerald | 2005-09-22 17:00:06 -0500 (Thu, 22 Sep 2005) | 2 lines Changed paths: - M /trunk/asn1/tcap/tcap.cnf + M /trunk/tools/Makefile.am + +Remove pidl.1.xml from the distribution. -fix for new asn2eth ------------------------------------------------------------------------ -r14989 | etxrab | 2005-07-22 03:56:41 -0500 (Fri, 22 Jul 2005) | 1 line +r15970 | ulfl | 2005-09-22 16:24:28 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-pn-rt.c -Use NULL intead of "" in all calls to packet-gsm_a.c +fix offset calculation of DataStatus fields if Ethernet FCS (or a similar trailer) is present ------------------------------------------------------------------------ -r14988 | etxrab | 2005-07-22 03:55:06 -0500 (Fri, 22 Jul 2005) | 1 line +r15969 | ulfl | 2005-09-22 16:21:29 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/dissectors/packet-media.c -Add ep_init_chunk. +bugfix: don't crash, if pinfo->match_string == NULL ------------------------------------------------------------------------ -r14987 | sahlberg | 2005-07-22 03:27:20 -0500 (Fri, 22 Jul 2005) | 4 lines +r15968 | ulfl | 2005-09-22 16:19:23 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/to_str.c + M /trunk/epan/dissectors/packet-wbxml.c -convert all other nasty "rotating static array" from to_str.c and make them use the new emem api. +bugfix: don't crash, if tag_save_literal == NULL +------------------------------------------------------------------------ +r15967 | ulfl | 2005-09-22 16:18:19 -0500 (Thu, 22 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-xml.c +bugfix: don't crash, if current_frame->ns == NULL +------------------------------------------------------------------------ +r15966 | ulfl | 2005-09-22 16:16:54 -0500 (Thu, 22 Sep 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-ses.c +enhance heuristics: +some Siemens SIMATIC protocols also use COTP, and shouldn't be +misinterpreted as SES. +the starter in this case is fixed to 0x32 (SES_MINOR_SYNC_ACK for SES), +so if the following parameter type is unknown, it's probably SIMATIC and not SES +------------------------------------------------------------------------ +r15965 | ulfl | 2005-09-22 16:14:39 -0500 (Thu, 22 Sep 2005) | 1 line +Changed paths: + M /trunk/gtk/packet_list.c +do freeze/thaw in packet_list_set_selected_row only, if the list must be moved. This avoids some screen flickering. ------------------------------------------------------------------------ -r14986 | jmayer | 2005-07-22 02:55:51 -0500 (Fri, 22 Jul 2005) | 1 line +r15964 | ulfl | 2005-09-22 16:12:51 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/prefs.c - M /trunk/rdps.c - M /trunk/tools/lemon/lemon.c - M /trunk/wiretap/airopeek9.c - M /trunk/wiretap/ascend.c + M /trunk/epan/dissectors/packet-dcom-cba-acco.c -More 'char*' -> 'const char*' warning fixes +change ConnectCR flag item sequence, so the "most significant" bit will come first (as done in the other req/responses) ------------------------------------------------------------------------ -r14985 | jmayer | 2005-07-22 02:54:18 -0500 (Fri, 22 Jul 2005) | 1 line +r15963 | ulfl | 2005-09-22 16:09:02 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radiotap.c + M /trunk/epan/dissectors/packet-dcerpc-lsa.c -Beginning of radiotap's header dissection +bugfix: don't simply use length field value from packet data, ensure the bytes really exist ------------------------------------------------------------------------ -r14984 | sahlberg | 2005-07-22 02:46:58 -0500 (Fri, 22 Jul 2005) | 14 lines +r15962 | ulfl | 2005-09-22 16:07:25 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/Makefile.common - A /trunk/epan/emem.c - A /trunk/epan/emem.h - M /trunk/epan/epan.c - M /trunk/epan/to_str.c - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-dcerpc.c -EMEM : a simple and FAST api to allocate memory that will be automatically freed() when the next packet is dissected. +add two more bind reject reasons from the specs +------------------------------------------------------------------------ +r15961 | guy | 2005-09-22 13:39:25 -0500 (Thu, 22 Sep 2005) | 9 lines +Changed paths: + M /trunk/epan/dtd_parse.l + M /trunk/epan/dtd_preparse.l + M /trunk/plugins/mate/mate_parser.l -This offesr memory allocation with a packet scope making memory leaks less likely and memory management faster. +Make the private variables for various lexical analyzers static, so +that we don't have all the lexical analyzers in libethereal share them +(note that they're already static in radius_dict.l, so they weren't +sharing with any other lexical analyzer), and so that OS X 10.3.9's +run-time linker doesn't get upset at finding them defined in libethereal +and the MATE plugin. +Fix up indentation. -Add initialization calls for both tethereal and ethereal. +------------------------------------------------------------------------ +r15960 | lego | 2005-09-22 12:01:06 -0500 (Thu, 22 Sep 2005) | 4 lines +Changed paths: + M /trunk/epan/stats_tree.c + M /trunk/epan/stats_tree_priv.h + M /trunk/gtk/stats_tree_stat.c -Convert the ip_to_str() function to use this and avoid doing the silly rotating buffers thing it previously did. +Instead of checking if this is a new packet at every call to avoid recounting the packets at every rerun remove the tap listener of this stats tree. +fixes bug 474 -We also need an equivalent set of functions for allocation with capture file scope (free when next capture is loaded) but i dont know where to put the free_all call. +------------------------------------------------------------------------ +r15959 | lego | 2005-09-22 11:41:53 -0500 (Thu, 22 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-xml.c +in register_dtd() do not leak the elements hash ------------------------------------------------------------------------ -r14983 | sahlberg | 2005-07-21 21:07:43 -0500 (Thu, 21 Jul 2005) | 6 lines +r15958 | kukosa | 2005-09-22 09:40:26 -0500 (Thu, 22 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/epan/dissectors/packet-h225.c -fix some bugs in a value string +Call H245 decoding and tunelled protocols decoding at the end of H225 dissector. I makes less confusion in info column. +------------------------------------------------------------------------ +r15957 | jmayer | 2005-09-22 05:07:26 -0500 (Thu, 22 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-hsrp.c -this fixes bug 291 +Add the cisco url as well +------------------------------------------------------------------------ +r15956 | jmayer | 2005-09-22 05:00:40 -0500 (Thu, 22 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-hsrp.c +Add a comment on packets with opcode 3 +------------------------------------------------------------------------ +r15955 | jmayer | 2005-09-22 04:13:33 -0500 (Thu, 22 Sep 2005) | 1 line +Changed paths: + A /trunk/tools/pidl/MANIFEST + M /trunk/tools/pidl/lib/Parse/Pidl/Compat.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Dump.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Ethereal/Conformance.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Ethereal/NDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl/NDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl/ODL.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Header.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Proxy.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Stub.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/EJS.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/EJSHeader.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/Header.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Client.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Header.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Parser.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Server.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/SWIG.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/TDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/Template.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Test.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Typelist.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Util.pm +Update from samba + new file MANIFEST ------------------------------------------------------------------------ -r14982 | sahlberg | 2005-07-21 21:00:04 -0500 (Thu, 21 Jul 2005) | 6 lines +r15954 | ulfl | 2005-09-21 21:18:19 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-netsync.c -fix for bug 290 +replace match_strval with val_to_str, where the output was used by string output, but not expecting NULL +------------------------------------------------------------------------ +r15953 | guy | 2005-09-21 21:08:03 -0500 (Wed, 21 Sep 2005) | 2 lines +Changed paths: + M /trunk/asn1/x411/x411.cnf + M /trunk/epan/dissectors/packet-x411.c -v2 exchange code 37 is "INFORMATIONAL" +Squelch some compiler warnings. +------------------------------------------------------------------------ +r15952 | guy | 2005-09-21 21:00:38 -0500 (Wed, 21 Sep 2005) | 4 lines +Changed paths: + M /trunk/capture_loop.c + M /trunk/tethereal.c +Libpcap uses u_char; use it in our calls to libpcap routines and in our +libpcap callback routine (if it's not getting defined, <pcap.h> doesn't +work). ------------------------------------------------------------------------ -r14981 | gerald | 2005-07-21 16:40:57 -0500 (Thu, 21 Jul 2005) | 3 lines +r15951 | guy | 2005-09-21 20:53:54 -0500 (Wed, 21 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/tvbuff.c + M /trunk/capture_loop.c + M /trunk/tethereal.c -When trying to handle gzip-compressed data, don't seek past the end of our -compressed data buffer. Fixes bug 288. +Update to current reality (WinPcap 3.1) the messages shown on Windows if +a capture device open fails. ------------------------------------------------------------------------ -r14980 | sahlberg | 2005-07-21 16:12:09 -0500 (Thu, 21 Jul 2005) | 4 lines +r15950 | ulfl | 2005-09-21 20:16:25 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cms/cms-exp.cnf - M /trunk/asn1/ftam/ftam.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/inap/packet-inap-template.c - M /trunk/asn1/pkixcmp/cmp-exp.cnf - M /trunk/asn1/pkixcrmf/crmf-exp.cnf - M /trunk/asn1/tcap/tcap.cnf - M /trunk/asn1/x509af/x509af-exp.cnf - M /trunk/asn1/x509ce/x509ce-exp.cnf - M /trunk/asn1/x509if/x509if-exp.cnf - M /trunk/asn1/x509sat/x509sat-exp.cnf - M /trunk/epan/dissectors/packet-MAP_DialoguePDU.c - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h + M /trunk/epan/dissectors/packet-gsm_a.c + +prevent output of NULL strings +------------------------------------------------------------------------ +r15949 | ulfl | 2005-09-21 20:09:01 -0500 (Wed, 21 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-giop.c + +replace match_strval with val_to_str in several places, where the output was used by string output, but not expecting NULL +------------------------------------------------------------------------ +r15948 | guy | 2005-09-21 19:51:11 -0500 (Wed, 21 Sep 2005) | 4 lines +Changed paths: + M /trunk/asn1/camel/camel.cnf + M /trunk/asn1/gsm_ss/gsm_ss.cnf + M /trunk/asn1/h248/h248.cnf + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/asn1/x411/x411.cnf M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmp.c - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-crmf.c - M /trunk/epan/dissectors/packet-ess.c - M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-inap.c M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-logotypecertextn.c - M /trunk/epan/dissectors/packet-mms.c - M /trunk/epan/dissectors/packet-ocsp.c - M /trunk/epan/dissectors/packet-pkinit.c - M /trunk/epan/dissectors/packet-pkix1implicit.c - M /trunk/epan/dissectors/packet-pkixqualified.c - M /trunk/epan/dissectors/packet-smrse.c - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/libethereal.def - M /trunk/tools/asn2eth.py + M /trunk/epan/dissectors/packet-x411.c -change the symbol dissect_ber_CHOICE back into dissect_ber_choice +Fix a bunch of places where we were calling "dissect_ber_octet_string()" +with a non-null pointer-to-pointer-to-tvbuff and not checking whether +the returned tvbuff pointer was non-null. +------------------------------------------------------------------------ +r15947 | guy | 2005-09-21 18:30:26 -0500 (Wed, 21 Sep 2005) | 3 lines +Changed paths: + M /trunk/asn1/gsm_ss/gsm_ss.cnf +Set svn:eol-style properly, and get rid of a bogus proprty. Fix the +line endings. ------------------------------------------------------------------------ -r14979 | ulfl | 2005-07-21 15:32:25 -0500 (Thu, 21 Jul 2005) | 1 line +r15946 | guy | 2005-09-21 18:23:58 -0500 (Wed, 21 Sep 2005) | 5 lines Changed paths: - M /trunk/COPYING + M /trunk/asn1/spnego/spnego.cnf + M /trunk/epan/dissectors/packet-spnego.c + +dissect_ber_octet_string() can return a null tvbuff pointer, if the +putative octet string isn't one; always check before using it to +dissect, and don't call the dissector if the tvbuff is null. This +should fix bug 472. -make the prefix "Just to avoid some misunderstandings..." a little bit more NSIS installer friendly (without making it odd looking) ------------------------------------------------------------------------ -r14978 | ulfl | 2005-07-21 15:17:52 -0500 (Thu, 21 Jul 2005) | 1 line +r15945 | guy | 2005-09-21 18:07:07 -0500 (Wed, 21 Sep 2005) | 4 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h + +OIDs are put into the protocol tree as strings containing a textual +representation of the OID, so the fields for them should be of type +FT_STRING. This should fix bug 470. -remove the radius dir and all it's files while uninstalling ------------------------------------------------------------------------ -r14977 | ulfl | 2005-07-21 15:05:37 -0500 (Thu, 21 Jul 2005) | 3 lines +r15944 | jmayer | 2005-09-21 17:41:47 -0500 (Wed, 21 Sep 2005) | 5 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + D /trunk/tools/pidl/pidl.1.xml + -Make GTK Wimp the default, so the installation type isn't always "Custom" on recent OS like 2K or XP (it will be disabled, if an "unappropriate" OS like Win98 is detected) +pidl.1.xml doesn't exist any more in this form. It's now integrated +into pidl itself. So remove the file again and also the reference to +the file in tools/Makefile.am -Grouping the sections together, so getting an idea of the available sections become an easier task ------------------------------------------------------------------------ -r14976 | jmayer | 2005-07-21 12:23:29 -0500 (Thu, 21 Jul 2005) | 1 line +r15943 | ulfl | 2005-09-21 15:33:12 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dhcp-failover.c + M /trunk/gtk/main.c -More warining fixes: char -> const char +fix 467: when using -k command line option, convert interface name display string ("user_description: devicename" from Preferences) into device name. Hopefully this won't break the UNIX version. ------------------------------------------------------------------------ -r14975 | jmayer | 2005-07-21 12:21:48 -0500 (Thu, 21 Jul 2005) | 1 line +r15942 | ulfl | 2005-09-21 15:27:32 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/epan/tap.c - M /trunk/epan/tap.h + M /trunk/gtk/main.c -More warining fixes: char -> const char +fix #465: replace all fprintf(stderr, ...) with g_warning(...) calls ------------------------------------------------------------------------ -r14974 | jmayer | 2005-07-21 12:17:16 -0500 (Thu, 21 Jul 2005) | 1 line +r15941 | ulfl | 2005-09-21 15:11:55 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/tvbuff.h + M /trunk/epan/xmlstub.h + M /trunk/gtk/capture_if_details_dlg.h + M /trunk/gtk/cfilter_combo_utils.h + M /trunk/gtk/fileset_dlg.h + M /trunk/gtk/main.h + M /trunk/gtk/range_utils.h -One forgotten warning fix +fix/add doxygen comments ------------------------------------------------------------------------ -r14973 | jmayer | 2005-07-21 12:04:10 -0500 (Thu, 21 Jul 2005) | 1 line +r15940 | ulfl | 2005-09-21 15:08:32 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - M /trunk/epan/prefs.h + M /trunk/gtk/fileset_dlg.c -small warning fixes +fix a copy/paste error inside of a comment ------------------------------------------------------------------------ -r14972 | ulfl | 2005-07-20 17:11:48 -0500 (Wed, 20 Jul 2005) | 1 line +r15939 | sahlberg | 2005-09-21 15:05:13 -0500 (Wed, 21 Sep 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/dissectors/packet-mip.c + M /trunk/epan/dissectors/packet-mpls-echo.c + M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-ntp.h + M /trunk/epan/dissectors/packet-rtcp.c + +get rid of strcpy in packet-ntp.c + +at the same time change ntp_fmt_ts to return a pointer to ian ep-allocated buffer. +remove the redundant buffer parameter in the signature and change all callers. + -"fix" bug #244: the implementation was correct but a bit hard to understand. I've added some small explanations, so it should be understandable somewhat better ------------------------------------------------------------------------ -r14971 | gerald | 2005-07-20 15:57:04 -0500 (Wed, 20 Jul 2005) | 12 lines +r15938 | guy | 2005-09-21 13:27:28 -0500 (Wed, 21 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-uma.c + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/asn1/spnego/spnego.cnf + M /trunk/epan/dissectors/packet-spnego.c -In packet-gsm_a.c: +Some compilers don't allow a static declaration of a function inside +another function, so move the declaration of +dissect_spnego_PrincipalSeq() to the top of the file. - - Make sure every function that has an "add_string" argument, make sure - it isn't NULL before we write to it. - a null "add_string". - - Use "_U_" instead of "add_string = add_string" to squelch compiler - warnings. - - Fix other compiler warnings. +------------------------------------------------------------------------ +r15937 | guy | 2005-09-21 12:42:11 -0500 (Wed, 21 Sep 2005) | 26 lines +Changed paths: + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/asn1/spnego/spnego.asn + M /trunk/asn1/spnego/spnego.cnf + M /trunk/epan/dissectors/packet-spnego.c -In packet-uma.c, pass NULL instead of "" for the add_string argument to -de_mid(). Fixes bug 287. +An InnerContextToken comes with an OID for the mechanism, which is what +we use to determine how to interpret the token; don't bother fetching +the OID attached to the frame or conversation, as we're not using it. + +Indent code in the .cnf file to match the code generated by asn2eth. + +The mechListMIC in a NegTokenInit is sometimes a sequence containing a +string; check the header of the mechListMIC and dissect it as such a +sequence or as a regular item depending on whether it's a sequence or +not. + +If we see a supportedMech in a NegTokenTarg, save next_level_value for +that OID with the conversation. + +Dissect a responseToken in a NegTokenTarg, and a mechListMIC in a +NegTokenTarg, appropriately. + +Get rid of "gssapi_dissector_handle()", and just use +next_level_value->handle - it was never being called if next_level_value +was null. + +When we're dissecting a KRB5 blob, just use get_ber_identifier() to get +the header, so we don't report an ASN.1 error if there isn't a BER +identifier there; dissect the identifier and length only if we know we +have them. ------------------------------------------------------------------------ -r14970 | jmayer | 2005-07-20 10:08:29 -0500 (Wed, 20 Jul 2005) | 7 lines +r15936 | guy | 2005-09-21 12:33:04 -0500 (Wed, 21 Sep 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-radiotap.c + D /trunk/epan/dissectors/packet-winsrepl.h +Don't fill in a data structure for the packet while dissecting; we use +almost none of the data - fill in only variables for what we need, and +use proto_tree_add_item() in most cases. -Convert the result of tvb_get_guint8 to (gint8) so that the display -as FT_INT32 shows a negative number if appropriate. +Move what's left of the packet-winsrepl.h header into packet-winsrepl.c, +and get rid of the header. -Is there a better way to solve this? -Does this problem occur in other places too? +Dissect the name flags field in detail, as per the Samba code. + +We don't do any checks for whether the packet is a valid WINS +replication packet, so don't make the dissector a new-style dissector. ------------------------------------------------------------------------ -r14969 | sahlberg | 2005-07-20 07:20:56 -0500 (Wed, 20 Jul 2005) | 4 lines +r15935 | guy | 2005-09-21 12:32:21 -0500 (Wed, 21 Sep 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-winsrepl.c + +Don't fill in a data structure for the packet while dissecting; we use +almost none of the data - fill in only variables for what we need, and +use proto_tree_add_item() in most cases. -prettify the HW type and address printouts slightly. +Move what's left of the packet-winsrepl.h header into packet-winsrepl.c, +and get rid of the header. +Dissect the name flags field in detail, as per the Samba code. +We don't do any checks for whether the packet is a valid WINS +replication packet, so don't make the dissector a new-style dissector. ------------------------------------------------------------------------ -r14968 | jmayer | 2005-07-20 07:05:14 -0500 (Wed, 20 Jul 2005) | 1 line +r15934 | gerald | 2005-09-21 11:18:30 -0500 (Wed, 21 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dis-enums.h + M /trunk/epan/dissectors/packet-dcp.c + +Use a proper length for booleans. If we have a malformed packet, throw an +exception. Fixes bug 468. -Fix: packet-dis-enums.h:248: warning: comma at end of enumerator list ------------------------------------------------------------------------ -r14967 | sahlberg | 2005-07-20 06:44:57 -0500 (Wed, 20 Jul 2005) | 5 lines +r15933 | gerald | 2005-09-21 11:06:59 -0500 (Wed, 21 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dhcpv6.c + A /trunk/tools/pidl/pidl.1.xml + A /trunk/tools/pidl/tests + A /trunk/tools/pidl/tests/ndr_align.pl + A /trunk/tools/pidl/tests/ndr_alloc.pl + A /trunk/tools/pidl/tests/ndr_array.pl + A /trunk/tools/pidl/tests/ndr_refptr.pl + A /trunk/tools/pidl/tests/ndr_simple.pl + A /trunk/tools/pidl/tests/ndr_string.pl -add proper decoding and presentation of domain strings in dhcpv6 +Add the "test" directory and man page to pidl. This should hopefully +fix the current distcheck and RPM build failures. -this fixes bug 273 +------------------------------------------------------------------------ +r15932 | gerald | 2005-09-21 10:54:09 -0500 (Wed, 21 Sep 2005) | 2 lines +Changed paths: + M /trunk/plugins/agentx/packet-agentx.c +Move a comment to the right place. ------------------------------------------------------------------------ -r14966 | jmayer | 2005-07-20 06:01:35 -0500 (Wed, 20 Jul 2005) | 1 line +r15931 | sahlberg | 2005-09-21 10:38:12 -0500 (Wed, 21 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/proto.c - M /trunk/epan/proto.h + M /trunk/epan/dissectors/packet-afs.c + +remove some strcpy() with g_snprintf() + -Change proto_register_protocol to use 'const char*' instead of 'char*' ------------------------------------------------------------------------ -r14965 | jmayer | 2005-07-20 06:00:01 -0500 (Wed, 20 Jul 2005) | 1 line +r15930 | gerald | 2005-09-21 10:26:12 -0500 (Wed, 21 Sep 2005) | 2 lines Changed paths: - M /trunk/epan + M /trunk/docbook/release-notes.xml + +Add an item about the X11 dissector. -Add radius_dict.c to svn:ignore ------------------------------------------------------------------------ -r14964 | sahlberg | 2005-07-20 02:51:24 -0500 (Wed, 20 Jul 2005) | 5 lines +r15929 | gerald | 2005-09-21 10:03:19 -0500 (Wed, 21 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-xml.c -fix for bug 285 +If pinfo->match_string is null (e.g. when we're called from the Jabber +dissector), don't try to look it up in a hash table. Fixes the current +Buildbot failure. -decode isakmp nat keepalive packets properly +------------------------------------------------------------------------ +r15928 | gerald | 2005-09-21 09:20:43 -0500 (Wed, 21 Sep 2005) | 3 lines +Changed paths: + M /trunk/docbook/release-notes.xml + M /trunk/gtk/graph_analysis.c +Free our flow graph strings when we're done with them. Add a note about +flow graphs to the release notes, along with other stuff. ------------------------------------------------------------------------ -r14963 | ulfl | 2005-07-19 19:47:58 -0500 (Tue, 19 Jul 2005) | 3 lines +r15927 | ulfl | 2005-09-21 05:29:22 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/docbook/Makefile + M /trunk/epan/dissectors/packet-x11.c -print in the first target output line also which kind of target is in the making: "EUG" or "EDG" +fix #372: the bug raised a "division by zero" exception. I've add a check for this and simply replaced the expression with 0 in that case. Don't know if it's correct to do so, but fixes the exception at least :-) +------------------------------------------------------------------------ +r15926 | ulfl | 2005-09-21 05:22:14 -0500 (Wed, 21 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-sip.c -remove obsolete HHC setting +bugfix: break out of an endless loop, if dissect_sip_common() returns 0 or -2, found in a file send to me by david martin in an attempt to fix #372 ------------------------------------------------------------------------ -r14962 | gerald | 2005-07-19 17:24:28 -0500 (Tue, 19 Jul 2005) | 3 lines +r15925 | jmayer | 2005-09-21 04:50:09 -0500 (Wed, 21 Sep 2005) | 1 line Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/epan/dissectors/pidl/README -Move Win32-specific variable declaration to the beginning of a function. -Fixes a recent buildbot failure. +manpages are now done automagically +------------------------------------------------------------------------ +r15924 | jmayer | 2005-09-21 04:40:45 -0500 (Wed, 21 Sep 2005) | 1 line +Changed paths: + M /trunk/tools/pidl/Makefile.PL + M /trunk/tools/pidl/README + M /trunk/tools/pidl/pidl + D /trunk/tools/pidl/pidl.1.xml +Sync with samba: Update to fix manpage handling ------------------------------------------------------------------------ -r14961 | lego | 2005-07-19 16:40:12 -0500 (Tue, 19 Jul 2005) | 4 lines +r15923 | gerald | 2005-09-20 22:28:22 -0500 (Tue, 20 Sep 2005) | 3 lines Changed paths: M /trunk/gtk/graph_analysis.c -Avoid the selected item been white on white by making all analysis widows colored. -Fixes bug 286. - +In an attempt to fix bug 396, switch over to GStrings. There still appears +to be a problem with formatting, but we don't crash any more. ------------------------------------------------------------------------ -r14960 | ulfl | 2005-07-19 16:05:17 -0500 (Tue, 19 Jul 2005) | 1 line +r15922 | guy | 2005-09-20 21:12:24 -0500 (Tue, 20 Sep 2005) | 4 lines Changed paths: - M /trunk/docbook/developer-guide.xml - M /trunk/docbook/user-guide.xml + M /trunk/epan/dissectors/packet-ip.c + +Use BASE_DEC_HEX for the identifier field; that means we don't have to +use "proto_tree_add_uint_format()", we can just let the Ethereal core +format it. -current Ethereal version is 0.10.11 ------------------------------------------------------------------------ -r14959 | ulfl | 2005-07-19 15:49:28 -0500 (Tue, 19 Jul 2005) | 1 line +r15921 | guy | 2005-09-20 20:47:46 -0500 (Tue, 20 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/proto.h + M /trunk/epan/dissectors/packet-ber.c + +Squelch some compiler wranings, and fix up the creation of a subset +tvbuff. + +Fix indentation. -fix three doxygen warnings ------------------------------------------------------------------------ -r14958 | ulfl | 2005-07-19 15:46:38 -0500 (Tue, 19 Jul 2005) | 1 line +r15920 | guy | 2005-09-20 20:39:39 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/compat_macros.h - M /trunk/gtk/help_dlg.h - M /trunk/gtk/main.h - M /trunk/gtk/menu.h - M /trunk/gtk/recent.h + M /trunk/epan/dissectors/packet-user_encap.c + +Squelch a compiler warning. -fix various doxygen warnings ------------------------------------------------------------------------ -r14957 | sahlberg | 2005-07-19 15:45:17 -0500 (Tue, 19 Jul 2005) | 5 lines +r15919 | guy | 2005-09-20 20:39:00 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-ifcp.c + M /trunk/epan/sigcomp-udvm.c -From Aboo +I think this is the check that was intended.... -New protocol : iFCP protocol +------------------------------------------------------------------------ +r15918 | guy | 2005-09-20 20:34:40 -0500 (Tue, 20 Sep 2005) | 2 lines +Changed paths: + M /trunk/image/stock_dialog_stop_48.xpm +Fix a compiler warning. ------------------------------------------------------------------------ -r14956 | ulfl | 2005-07-19 15:44:45 -0500 (Tue, 19 Jul 2005) | 1 line +r15917 | guy | 2005-09-20 20:34:04 -0500 (Tue, 20 Sep 2005) | 4 lines Changed paths: - M /trunk/disabled_protos.c - M /trunk/doc/ethereal.pod - M /trunk/epan/addr_resolv.c M /trunk/gtk/main.c -from Graeme Hewson: "Fixes for ethereal config files" +Squelch a compiler warning (the argument might be used later). + +Clean up indentation. + ------------------------------------------------------------------------ -r14955 | ulfl | 2005-07-19 15:06:19 -0500 (Tue, 19 Jul 2005) | 1 line +r15916 | guy | 2005-09-20 20:33:16 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/docbook/developer-guide.xml - M /trunk/docbook/edg_src/EDG_chapter_env_intro.xml - M /trunk/docbook/edg_src/EDG_preface.xml + M /trunk/asn1/h450/packet-h450-template.c + M /trunk/epan/dissectors/packet-h450.c + M /trunk/epan/dissectors/packet-h450.h + +Fix a compiler warning. -from Jaap Keuter: "Syncing info from User Guide into Dev Guide" ------------------------------------------------------------------------ -r14954 | etxrab | 2005-07-19 14:48:02 -0500 (Tue, 19 Jul 2005) | 1 line +r15915 | guy | 2005-09-20 20:15:32 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-nbns.c + +Fix a comment. -Fix an unpack_digits off by one error. ------------------------------------------------------------------------ -r14953 | etxrab | 2005-07-19 14:47:17 -0500 (Tue, 19 Jul 2005) | 1 line +r15914 | guy | 2005-09-20 19:00:43 -0500 (Tue, 20 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-winsrepl.c + +Put in some comments based on stuff seen in the Samba code +(include/nameserv.h, code in wrepld). -Fix an unpack_digits off by one error. ------------------------------------------------------------------------ -r14952 | sahlberg | 2005-07-19 03:58:20 -0500 (Tue, 19 Jul 2005) | 8 lines +r15913 | guy | 2005-09-20 17:55:48 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-app-pkix-cert.c -minor fix to add required alignment for AueryPathInfo level 0x107 +Give it an RCS ID. +------------------------------------------------------------------------ +r15912 | guy | 2005-09-20 17:53:31 -0500 (Tue, 20 Sep 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-h221_nonstd.c -it decodes "better" but might still be broken since none of the packets I have match any of the "standards" +Fix the name in the comment. +Give it an RCS ID. +------------------------------------------------------------------------ +r15911 | guy | 2005-09-20 17:52:31 -0500 (Tue, 20 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-actrace.c + M /trunk/epan/dissectors/packet-actrace.h +Give them RCS IDs. ------------------------------------------------------------------------ -r14951 | kukosa | 2005-07-18 15:45:46 -0500 (Mon, 18 Jul 2005) | 1 line +r15910 | guy | 2005-09-20 17:51:42 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/tools/asn2eth.py - M /trunk/tools/lex.py - M /trunk/tools/yacc.py + M /trunk/epan/dissectors/packet-dis-enums.c + M /trunk/epan/dissectors/packet-dis-enums.h + M /trunk/epan/dissectors/packet-dis-fields.c + M /trunk/epan/dissectors/packet-dis-fields.h + M /trunk/epan/dissectors/packet-dis-pdus.c + M /trunk/epan/dissectors/packet-dis-pdus.h + M /trunk/epan/dissectors/packet-dis.c + +Give them RCS IDs. -PLY package updated to version 1.6 ------------------------------------------------------------------------ -r14950 | guy | 2005-07-18 04:55:54 -0500 (Mon, 18 Jul 2005) | 5 lines +r15909 | guy | 2005-09-20 17:49:54 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dis.c + M /trunk/epan/dissectors/packet-lldp.c -DIS packets must be at least 12 bytes long. DIS uses port 3000, by -default, but the Cisco Redundant Link Management protocol can also use -that port; RLM packets are 8 bytes long, so we use this to distinguish -between them. +Give it an RCS ID. ------------------------------------------------------------------------ -r14949 | sahlberg | 2005-07-18 03:29:03 -0500 (Mon, 18 Jul 2005) | 7 lines +r15908 | etxrab | 2005-09-20 15:25:55 -0500 (Tue, 20 Sep 2005) | 5 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.h -GTK 1.2 does not define the macro GDK_IS_DRAWABLE which made compilation of the recent flow analysis fail to compile. +From Hannes Gredler: +patch to support 4 additional juniper DLTs. -For the time being, just add a dummy define for this symbol making it always TRUE for gtk-1.x users so that it compiles. +all those are wrappers for exisiting media types augmented with meta-information which gets also displayed using this patch; -this should be fixed properly at a later stage, but i guess there are very few users of gtk-1.2 anyway so no urgency. +------------------------------------------------------------------------ +r15907 | etxrab | 2005-09-20 15:20:08 -0500 (Tue, 20 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-jabber.c +From Kaul: +Jabber traffic is XML, attached patch dissects it as such +------------------------------------------------------------------------ +r15906 | etxrab | 2005-09-20 15:04:01 -0500 (Tue, 20 Sep 2005) | 1 line +Changed paths: + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-gsm_map.c +Fix bug #404 Decoding of MSISDN on GSM is incomplete. ------------------------------------------------------------------------ -r14948 | lego | 2005-07-17 18:12:12 -0500 (Sun, 17 Jul 2005) | 4 lines +r15905 | sahlberg | 2005-09-20 14:42:40 -0500 (Tue, 20 Sep 2005) | 6 lines Changed paths: - M /trunk/gtk/Makefile.common - A /trunk/gtk/flow_graph.c - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-dcp.c + +from francesco + +update to remove sprintf() -From Francisco Alcoba -Flow Graphs for any protocol ------------------------------------------------------------------------ -r14947 | gerald | 2005-07-17 17:30:56 -0500 (Sun, 17 Jul 2005) | 2 lines +r15904 | sahlberg | 2005-09-20 14:36:38 -0500 (Tue, 20 Sep 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-dcp.c + +make options field filterable + +remove silly rotating buffers + -Tweak the previous fix. ------------------------------------------------------------------------ -r14946 | gerald | 2005-07-17 17:16:59 -0500 (Sun, 17 Jul 2005) | 2 lines +r15903 | guy | 2005-09-20 14:01:04 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-winsrepl.c -Make the recent RADIUS changes work on IA64. +Set EOL type and expansion of $Id$. ------------------------------------------------------------------------ -r14945 | jmayer | 2005-07-17 08:55:46 -0500 (Sun, 17 Jul 2005) | 3 lines +r15902 | etxrab | 2005-09-20 13:45:21 -0500 (Tue, 20 Sep 2005) | 1 line Changed paths: - M /trunk/epan/Makefile.am + M /trunk/plugins/megaco/packet-megaco.c -Add radius_dict.c to DISTCLEAN +Fix bug #343 Parsing Problem - TransactionResponseAck (MEGACO). +------------------------------------------------------------------------ +r15901 | gerald | 2005-09-20 12:26:43 -0500 (Tue, 20 Sep 2005) | 2 lines +Changed paths: + M /trunk/docbook/release-notes.xml + M /trunk/epan/sigcomp-udvm.c +Be more paranoid about buffer overruns. ------------------------------------------------------------------------ -r14944 | ulfl | 2005-07-17 08:39:24 -0500 (Sun, 17 Jul 2005) | 1 line +r15900 | gerald | 2005-09-20 12:24:23 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/Makefile.nmake + M /trunk/epan/asn1.c + M /trunk/epan/dtd_parse.l + +Fix a couple of errors found by valgrind. -add radius_dict.c to the distclean target, don't know how to do this for Makefile.am ------------------------------------------------------------------------ -r14943 | guy | 2005-07-17 03:41:07 -0500 (Sun, 17 Jul 2005) | 2 lines +r15899 | gerald | 2005-09-20 12:23:19 -0500 (Tue, 20 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/reassemble.c -It's "svn:keywords", not "svn:keyword". +Don't try to reassemble a zero-length fragment. Add a comment to +reassemble.c about the handling of zero-length fragments. ------------------------------------------------------------------------ -r14942 | guy | 2005-07-17 03:39:51 -0500 (Sun, 17 Jul 2005) | 2 lines +r15898 | jmayer | 2005-09-20 10:19:11 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/Makefile.common -Fix the RCS ID. +Francesco Fondelli: Add dcp support (forgot this file) ------------------------------------------------------------------------ -r14941 | etxrab | 2005-07-16 16:34:19 -0500 (Sat, 16 Jul 2005) | 1 line +r15897 | jmayer | 2005-09-20 10:18:28 -0500 (Tue, 20 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-t38.c + M /trunk/AUTHORS + M /trunk/epan/addr_resolv.c + M /trunk/epan/addr_resolv.h + M /trunk/epan/address.h + A /trunk/epan/dissectors/packet-dcp.c + A /trunk/epan/dissectors/packet-dcp.h + M /trunk/epan/ipproto.c + M /trunk/epan/ipproto.h + + +Francesco Fondelli; Add dcp support -Update to the new per signatures. ------------------------------------------------------------------------ -r14940 | etxrab | 2005-07-16 14:59:21 -0500 (Sat, 16 Jul 2005) | 1 line +r15896 | jmayer | 2005-09-20 10:08:14 -0500 (Tue, 20 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_a.h - M /trunk/epan/dissectors/packet-uma.c + M /trunk/tools/Makefile.am + + +Add the pidl files. -Remove some unused variables. ------------------------------------------------------------------------ -r14939 | etxrab | 2005-07-16 14:58:23 -0500 (Sat, 16 Jul 2005) | 1 line +r15895 | kukosa | 2005-09-20 09:14:07 -0500 (Tue, 20 Sep 2005) | 1 line Changed paths: - M /trunk/epan/libethereal.def + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-per.c -Remove an unused export +get rid of few warnings ------------------------------------------------------------------------ -r14938 | guy | 2005-07-16 01:20:56 -0500 (Sat, 16 Jul 2005) | 2 lines +r15894 | kukosa | 2005-09-20 05:56:08 -0500 (Tue, 20 Sep 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h245/h245.cnf + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/asn1/h450/packet-h450-template.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h235.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h450.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-per.h + M /trunk/tools/asn2eth.py -List the new "packet-radius.h" file so it's included in the tarball. +asn2eth + - #.FN_BODY accepts parameters too + - single line variant of #.FN_PAR is possible + - new parameter FN_VARIANT for OBJECT IDENTIFIER +packet-per.c + - dissect_per_object_identifier() returns value as tvb + - new dissect_per_object_identifier_str() function +PER dissectors adapted and regenerated +------------------------------------------------------------------------ +r15893 | ulfl | 2005-09-20 04:02:38 -0500 (Tue, 20 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-lldp.c +fix: packet-lldp.c(2071) : warning C4761: integral size mismatch in argument; conversion supplied ------------------------------------------------------------------------ -r14937 | guy | 2005-07-15 20:55:58 -0500 (Fri, 15 Jul 2005) | 7 lines +r15892 | ulfl | 2005-09-20 03:55:50 -0500 (Tue, 20 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-dcerpc.c -Get rid of the newline between "radius:" and the error when trying to -read the RADIUS directory. +fix: packet-dcerpc.c(4019) : warning C4018: '<' : signed/unsigned mismatch +------------------------------------------------------------------------ +r15891 | ulfl | 2005-09-20 03:42:35 -0500 (Tue, 20 Sep 2005) | 6 lines +Changed paths: + M /trunk/capture.c + M /trunk/file.c + M /trunk/file.h + M /trunk/gtk/main.c -The error string from "radius_load_dictionary()" is g_malloced; free it, -and g_strdup the "Could not find the radius directory" error, so we -don't have to worry about constant vs. g_malloced strings. +add two new callbacks: +cf_cb_file_closing (called before closing a capture file) cf_cb_file_closed will be called afterwards, but both only if a file is really closed as cf_close is called more often ... +If we are closing large capture files (~20MB), the screen looks ugly while the file is closed. Change this so the screen will immediately go back to initial state and a dialog (without buttons) is shown that the file is currently closed. As the operation which takes most of the time to close the file is a single eth_clist_clear call, we can't use a progress bar here. + +cf_cb_live_capture_stopping: called when the user wants to stop the capture (toolbar or menu clicked). At least on Win32, the time between this and the actual stop completed can be noticeable (1-2 seconds), so the user doesn't know if the button press did anything at all. Do something similar as above, show a dialog box without buttons to inform that the close is in progress. ------------------------------------------------------------------------ -r14936 | guy | 2005-07-15 20:33:22 -0500 (Fri, 15 Jul 2005) | 5 lines +r15890 | ulfl | 2005-09-20 03:31:09 -0500 (Tue, 20 Sep 2005) | 1 line Changed paths: - M /trunk/epan/radius_dict.l + M /trunk/capture_wpcap_packet.c -Throw in some casts to squelch warnings, at least with some compilers -(the values are const because nobody's supposed to modify them once -they've been allocated, but they *can* be freed - by us - when we're -done with them). +fix a compiler warning (... copied from RFC2553 :-) +------------------------------------------------------------------------ +r15889 | ulfl | 2005-09-20 03:18:41 -0500 (Tue, 20 Sep 2005) | 1 line +Changed paths: + M /trunk/gtk/main.c +if the capture child pops up it's own console, title it as such ------------------------------------------------------------------------ -r14935 | sahlberg | 2005-07-15 20:04:36 -0500 (Fri, 15 Jul 2005) | 5 lines +r15888 | guy | 2005-09-20 03:01:00 -0500 (Tue, 20 Sep 2005) | 2 lines Changed paths: - A /trunk/asn1/wlancertextn - A /trunk/asn1/wlancertextn/Makefile - A /trunk/asn1/wlancertextn/Makefile.nmake - A /trunk/asn1/wlancertextn/WLANCERTEXTN.asn - A /trunk/asn1/wlancertextn/packet-wlancertextn-template.c - A /trunk/asn1/wlancertextn/packet-wlancertextn-template.h - A /trunk/asn1/wlancertextn/wlancertextn.cnf - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-wlancertextn.c - A /trunk/epan/dissectors/packet-wlancertextn.h + M /trunk/gtk/capture_if_details_dlg.c -new protocol +Squelch a compiler warning. + +------------------------------------------------------------------------ +r15887 | ulfl | 2005-09-19 21:10:48 -0500 (Mon, 19 Sep 2005) | 3 lines +Changed paths: + M /trunk/capture_wpcap_packet.c + M /trunk/gtk/capture_if_details_dlg.c -RFC3770 Wlan Certificate Extensions +the buildbot has a problem not knowing sa_family_t, define eth_sa_family_t and use it here (ok, this *is* a dirty hack) +don't know why the last commit compiled on my machine and not on the buildbot. +------------------------------------------------------------------------ +r15886 | ulfl | 2005-09-19 20:53:38 -0500 (Mon, 19 Sep 2005) | 1 line +Changed paths: + M /trunk/gtk/dlg_utils.c + M /trunk/gtk/simple_dialog.c + M /trunk/simple_dialog.h +enhance simple dialog: add the possibility to use no buttons at all and add a stop icon (similar to the splash_window, but with a slightly different layout and a way to choose the icon shown) ------------------------------------------------------------------------ -r14934 | guy | 2005-07-15 19:45:22 -0500 (Fri, 15 Jul 2005) | 2 lines +r15885 | ulfl | 2005-09-19 20:45:35 -0500 (Mon, 19 Sep 2005) | 1 line Changed paths: M /trunk/Makefile.am + M /trunk/image/README.image + A /trunk/image/stock_dialog_stop_48.xpm + +add a new stop icon 48x48 for (simple) dialogs (derived from the openoffice stock icons and slightly enlarged using the Gimp) +------------------------------------------------------------------------ +r15884 | lego | 2005-09-19 19:31:53 -0500 (Mon, 19 Sep 2005) | 5 lines +Changed paths: + M /trunk/epan/dtd_parse.l + + avoid freeing the last location twice. + +add some #ifed out code to help debugging the parser -It's "plugins", not "Plugins". ------------------------------------------------------------------------ -r14933 | guy | 2005-07-15 19:37:44 -0500 (Fri, 15 Jul 2005) | 3 lines +r15883 | jmayer | 2005-09-19 18:33:45 -0500 (Mon, 19 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/tools/pidl + +Add svn:ignore from samba +------------------------------------------------------------------------ +r15882 | jmayer | 2005-09-19 18:31:47 -0500 (Mon, 19 Sep 2005) | 3 lines +Changed paths: + A /trunk/tools/pidl + A /trunk/tools/pidl/Makefile.PL + A /trunk/tools/pidl/README + A /trunk/tools/pidl/TODO + A /trunk/tools/pidl/idl.yp + A /trunk/tools/pidl/lib + A /trunk/tools/pidl/lib/Parse + A /trunk/tools/pidl/lib/Parse/Pidl + A /trunk/tools/pidl/lib/Parse/Pidl/Compat.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Dump.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Ethereal + A /trunk/tools/pidl/lib/Parse/Pidl/Ethereal/Conformance.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Ethereal/NDR.pm + A /trunk/tools/pidl/lib/Parse/Pidl/IDL.pm + A /trunk/tools/pidl/lib/Parse/Pidl/NDR.pm + A /trunk/tools/pidl/lib/Parse/Pidl/ODL.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Header.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Proxy.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Stub.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/EJS.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/EJSHeader.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/Header.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Client.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Header.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Parser.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Server.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/SWIG.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/TDR.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/Template.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Test.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Typelist.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Util.pm + A /trunk/tools/pidl/lib/Parse/Pidl.pm + A /trunk/tools/pidl/pidl + A /trunk/tools/pidl/pidl.1.xml + A /trunk/tools/pidl/ref_notes.txt + A /trunk/tools/pidl/smb_interfaces.pm + A /trunk/tools/pidl/smb_interfaces.yp -epan/dissectors/packet-gtp.h has rung down the curtain and joined the -Choir Invisible. +Revert back to local copy: The samba svn server does not support svn +over http - this was a much requested feature for Ethereals svn server. ------------------------------------------------------------------------ -r14932 | guy | 2005-07-15 19:27:53 -0500 (Fri, 15 Jul 2005) | 2 lines +r15881 | jmayer | 2005-09-19 18:29:03 -0500 (Mon, 19 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-radius_packetcable.c + M /trunk/tools -Fix the name of the "svn:keywords" property. +pidl: Revert back to local copy. The samba svn server does not support svn +over http - this was a much requested feature for Ethereal's svn server. ------------------------------------------------------------------------ -r14931 | guy | 2005-07-15 19:26:07 -0500 (Fri, 15 Jul 2005) | 2 lines +r15880 | jmayer | 2005-09-19 16:24:46 -0500 (Mon, 19 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radius_packetcable.c + M /trunk/FAQ + M /trunk/help/faq.txt -Fix the RCS ID. +Update faq +------------------------------------------------------------------------ +r15879 | jmayer | 2005-09-19 16:24:07 -0500 (Mon, 19 Sep 2005) | 1 line +Changed paths: + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-lldp.c + M /trunk/manuf + M /trunk/wka.tmpl +Jim Young: LLDP improvements ------------------------------------------------------------------------ -r14930 | lego | 2005-07-15 17:36:21 -0500 (Fri, 15 Jul 2005) | 3 lines +r15878 | ulfl | 2005-09-19 15:59:50 -0500 (Mon, 19 Sep 2005) | 1 line Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/capture_wpcap_packet.c + M /trunk/gtk/capture_if_details_dlg.c -comments are ";" not ":" +fix #340: define the missing sockaddr_storage struct to be able to use Packet32.h even with WinPcap 3.1 and without the platform SDK +------------------------------------------------------------------------ +r15877 | gerald | 2005-09-19 15:50:51 -0500 (Mon, 19 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dtd.h +Small whitespace cleanup. ------------------------------------------------------------------------ -r14929 | lego | 2005-07-15 16:45:34 -0500 (Fri, 15 Jul 2005) | 2 lines +r15876 | gerald | 2005-09-19 15:50:10 -0500 (Mon, 19 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-radius_packetcable.c + M /trunk/epan/sigcomp-udvm.c -propset and fix the filename +Throw an exception instead of trying to read past the end of a buffer. +Fixes bug 455. ------------------------------------------------------------------------ -r14928 | lego | 2005-07-15 16:41:47 -0500 (Fri, 15 Jul 2005) | 3 lines +r15875 | lego | 2005-09-19 14:48:55 -0500 (Mon, 19 Sep 2005) | 3 lines Changed paths: + M /trunk/epan/dissectors/packet-gtp.c + +display something useful in the radius VSA item + + +------------------------------------------------------------------------ +r15874 | gerald | 2005-09-19 14:46:25 -0500 (Mon, 19 Sep 2005) | 2 lines +Changed paths: + M /trunk/asn1/spnego/spnego.cnf + M /trunk/epan/dissectors/packet-spnego.c + +Don't dereference a null pointer. Fixes bug 460. + +------------------------------------------------------------------------ +r15873 | lego | 2005-09-19 14:36:32 -0500 (Mon, 19 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-radius.c + +Change "Value" into "VSA" for Vendor SPecific Attributes + +------------------------------------------------------------------------ +r15872 | etxrab | 2005-09-19 14:11:50 -0500 (Mon, 19 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-amr.c + +Add a preference to decode different types of AMR payload. +------------------------------------------------------------------------ +r15871 | gerald | 2005-09-19 12:50:38 -0500 (Mon, 19 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc-afs4int.c + +Throw an exception if our ACL length is flat-out wrong. + +------------------------------------------------------------------------ +r15870 | lego | 2005-09-19 12:42:02 -0500 (Mon, 19 Sep 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-radius.c M /trunk/epan/dissectors/packet-radius.h M /trunk/epan/radius_dict.l -forgot to add the (c) notice + +- allow multiple attributes inside one VSA (fixes bug 438) +- preference to choose whether to add the AVP's payload length items +- preference to add an alternate UDP port ------------------------------------------------------------------------ -r14927 | lego | 2005-07-15 16:32:12 -0500 (Fri, 15 Jul 2005) | 3 lines +r15869 | gerald | 2005-09-19 11:23:05 -0500 (Mon, 19 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ranap.c + M /trunk/asn1/spnego/spnego.cnf + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-spnego.c -register the dissector by name +In the SPNEGO dissector, don't call a subdissector if we don't have a TVB. +Fixes bugs 448, 449, 451, 452, 454, 456, and 461. +Add similar TVB checks to the BER dissector. ------------------------------------------------------------------------ -r14926 | lego | 2005-07-15 16:18:32 -0500 (Fri, 15 Jul 2005) | 4 lines +r15868 | jmayer | 2005-09-19 09:59:32 -0500 (Mon, 19 Sep 2005) | 4 lines Changed paths: - M /trunk/Makefile.am - M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.common - M /trunk/epan/Makefile.nmake - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/pidl/README -Radius Dictionary Support -Part 3: the makefiles +Change README to reflect the fact that tools/pidl is now a +svn:externals reference. ------------------------------------------------------------------------ -r14925 | lego | 2005-07-15 16:12:27 -0500 (Fri, 15 Jul 2005) | 3 lines +r15867 | jmayer | 2005-09-19 09:53:46 -0500 (Mon, 19 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-gtp.c - D /trunk/epan/dissectors/packet-gtp.h - M /trunk/epan/dissectors/packet-radius.c - A /trunk/epan/dissectors/packet-radius.h - A /trunk/epan/dissectors/packet-radius_packetcable.c - A /trunk/epan/radius_dict.l - -Radius Dictionary Support -Part 2: the code - ------------------------------------------------------------------------- -r14924 | lego | 2005-07-15 16:03:13 -0500 (Fri, 15 Jul 2005) | 4 lines -Changed paths: - A /trunk/radius - A /trunk/radius/dictionary - A /trunk/radius/dictionary.3com - A /trunk/radius/dictionary.3gpp - A /trunk/radius/dictionary.3gpp2 - A /trunk/radius/dictionary.acc - A /trunk/radius/dictionary.alcatel - A /trunk/radius/dictionary.alteon - A /trunk/radius/dictionary.altiga - A /trunk/radius/dictionary.aptis - A /trunk/radius/dictionary.ascend - A /trunk/radius/dictionary.bay - A /trunk/radius/dictionary.bintec - A /trunk/radius/dictionary.bristol - A /trunk/radius/dictionary.cablelabs - A /trunk/radius/dictionary.cabletron - A /trunk/radius/dictionary.cisco - A /trunk/radius/dictionary.cisco.bbsm - A /trunk/radius/dictionary.cisco.vpn3000 - A /trunk/radius/dictionary.cisco.vpn5000 - A /trunk/radius/dictionary.colubris - A /trunk/radius/dictionary.columbia_university - A /trunk/radius/dictionary.compat - A /trunk/radius/dictionary.cosine - A /trunk/radius/dictionary.erx - A /trunk/radius/dictionary.extreme - A /trunk/radius/dictionary.foundry - A /trunk/radius/dictionary.freeradius - A /trunk/radius/dictionary.gandalf - A /trunk/radius/dictionary.garderos - A /trunk/radius/dictionary.gemtek - A /trunk/radius/dictionary.itk - A /trunk/radius/dictionary.juniper - A /trunk/radius/dictionary.karlnet - A /trunk/radius/dictionary.livingston - A /trunk/radius/dictionary.localweb - A /trunk/radius/dictionary.merit - A /trunk/radius/dictionary.microsoft - A /trunk/radius/dictionary.mikrotik - A /trunk/radius/dictionary.navini - A /trunk/radius/dictionary.netscreen - A /trunk/radius/dictionary.nokia - A /trunk/radius/dictionary.nomadix - A /trunk/radius/dictionary.propel - A /trunk/radius/dictionary.quintum - A /trunk/radius/dictionary.redback - A /trunk/radius/dictionary.redcreek - A /trunk/radius/dictionary.shasta - A /trunk/radius/dictionary.shiva - A /trunk/radius/dictionary.sonicwall - A /trunk/radius/dictionary.springtide - A /trunk/radius/dictionary.t_systems_nova - A /trunk/radius/dictionary.telebit - A /trunk/radius/dictionary.trapeze - A /trunk/radius/dictionary.tunnel - A /trunk/radius/dictionary.unisphere - A /trunk/radius/dictionary.unix - A /trunk/radius/dictionary.usr - A /trunk/radius/dictionary.valemount - A /trunk/radius/dictionary.versanet - A /trunk/radius/dictionary.wispr - A /trunk/radius/dictionary.xedia - -Radius dictionary support -Part 1: the dictionary - - ------------------------------------------------------------------------- -r14923 | gerald | 2005-07-15 15:50:34 -0500 (Fri, 15 Jul 2005) | 2 lines + M /trunk/tools + +Add svn:externals for pidl: That way svn up will pull the pidl sources +directly from the samba svn instead of keeping a copy of them in the +Ethereal svn. + + +------------------------------------------------------------------------ +r15866 | jmayer | 2005-09-19 09:50:23 -0500 (Mon, 19 Sep 2005) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/config.nmake - M /trunk/tools/win32-setup.sh + D /trunk/tools/pidl -Point to the latest Windows library tag and versions. +Change pidl to svn:externals +------------------------------------------------------------------------ +r15865 | jmayer | 2005-09-19 08:26:49 -0500 (Mon, 19 Sep 2005) | 1 line +Changed paths: + A /trunk/epan/dissectors/pidl/idl_types.h +Add idl_types.h from samba to fix warning ------------------------------------------------------------------------ -r14922 | etxrab | 2005-07-15 15:26:36 -0500 (Fri, 15 Jul 2005) | 1 line +r15864 | jmayer | 2005-09-19 04:23:52 -0500 (Mon, 19 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/pidl/README + +Point to tools/pidl/README.ethereal +------------------------------------------------------------------------ +r15863 | guy | 2005-09-19 03:09:41 -0500 (Mon, 19 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-winsrepl.c + +Fix a typo. -Updare Id, and a comment. ------------------------------------------------------------------------ -r14921 | kukosa | 2005-07-15 10:20:40 -0500 (Fri, 15 Jul 2005) | 5 lines +r15862 | sahlberg | 2005-09-19 03:06:25 -0500 (Mon, 19 Sep 2005) | 9 lines Changed paths: + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + +sometimes it seems that we have the text based h248/megaco running ontop of +m3ua and not the binary one. + + +make the binary dissector check if it is really the text based one to be used and if so +call that dissector instead. + + + +------------------------------------------------------------------------ +r15861 | kukosa | 2005-09-19 02:35:05 -0500 (Mon, 19 Sep 2005) | 1 line +Changed paths: + M /trunk/asn1/h450/packet-h450-template.c M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h235.c M /trunk/epan/dissectors/packet-h245.c M /trunk/epan/dissectors/packet-h450.c M /trunk/epan/dissectors/packet-per.c M /trunk/epan/dissectors/packet-per.h + M /trunk/epan/dissectors/packet-t38.c M /trunk/tools/asn2eth.py -- PER helper functions for SET/SEQUENCE OF dissection were changed to have prototype similar to BER (per_sequence_t is used as parameter) -- asn2eth was updated to support new PER helper functions for SET/SEQUENCE OF -- #.FN_PARS implemented for SET/SEQUENCE OF and REAL -- PER SET/SEQUENCE OF field can be FT_UINTxx to display number of items -- PER dissectors regenerated +remove unused parameter 'name' from dissect_per_choice() ------------------------------------------------------------------------ -r14920 | sahlberg | 2005-07-15 03:29:26 -0500 (Fri, 15 Jul 2005) | 8 lines +r15860 | jmayer | 2005-09-18 16:58:39 -0500 (Sun, 18 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/io_stat.c - -make io-stat able to do SUM(*) for FT_RELATIVE_TIME fields - - -Example: SUM(tcp.analysis.rto) -so one can plot the total amount of time that TCP sessions were idle due to waiting for a retransmission to occur. - + M /trunk/tools/checkhf.pl +Small update +------------------------------------------------------------------------ +r15859 | jmayer | 2005-09-18 16:57:59 -0500 (Sun, 18 Sep 2005) | 1 line +Changed paths: + M /trunk/tools/pidl + M /trunk/tools/pidl/README.ethereal + M /trunk/tools/pidl/lib/Parse/Pidl/IDL.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba/TDR.pm + D /trunk/tools/pidl/pm_to_blib +Update README.ethereal and sync with current samba tree ------------------------------------------------------------------------ -r14919 | ulfl | 2005-07-14 16:45:18 -0500 (Thu, 14 Jul 2005) | 1 line +r15858 | ulfl | 2005-09-18 15:11:54 -0500 (Sun, 18 Sep 2005) | 1 line Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_capture.xml - M /trunk/docbook/user-guide.xml + M /trunk/epan/tvbuff.c -minor change: add TcpdumpManpage entity +assert that tvb is not NULL ------------------------------------------------------------------------ -r14918 | etxrab | 2005-07-14 16:05:38 -0500 (Thu, 14 Jul 2005) | 3 lines +r15857 | etxrab | 2005-09-18 15:04:04 -0500 (Sun, 18 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_a.h - M /trunk/epan/dissectors/packet-gtp.c - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-cops.c -Packet-gtp.c - Fix up decoding of the rest of the IE:s use routines from packet-gsm_a.c -Packet-uma.c Let packet-gsm_a handle som IE dissection. -Packet-gsm.a add some IE dissection and export some routines. +Change some of the asn1 functions to use packet-ber ones. ------------------------------------------------------------------------ -r14917 | sahlberg | 2005-07-14 03:10:30 -0500 (Thu, 14 Jul 2005) | 9 lines +r15856 | guy | 2005-09-18 11:54:00 -0500 (Sun, 18 Sep 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-ber.c -ISAKMP version2 has changed the payload format of a CertificateRequest. +If the tag field is a bitfield, always show it as such, otherwise always +show the value of 1 1111 as "Continued" in the bitfield and the actual +tag value in the following bytes. -In version 2 this is just a concatenation of 20 byte SHA-1 hashes with no other encxapsulation. +Show the BER identifier data before an OID if we're showing internal BER +fields. -this resolves bug 281 +------------------------------------------------------------------------ +r15855 | ulfl | 2005-09-18 06:18:42 -0500 (Sun, 18 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-frame.c +as discussed in the Users list: replace "Short Frame" by "Packet size limited during capture" message +------------------------------------------------------------------------ +r15854 | lego | 2005-09-18 04:10:03 -0500 (Sun, 18 Sep 2005) | 3 lines +Changed paths: + M /trunk/Makefile.am +add dtds to EXTRA_DIST ------------------------------------------------------------------------ -r14916 | jmayer | 2005-07-14 03:03:59 -0500 (Thu, 14 Jul 2005) | 2 lines +r15853 | etxrab | 2005-09-17 16:02:51 -0500 (Sat, 17 Sep 2005) | 1 line Changed paths: - M /trunk/plugins/v5ua/packet-v5ua.c - -moduleinfo.h was included twice. + M /trunk/epan/dissectors/packet-ber.c +If unkown Tag's are found in a set add length. ------------------------------------------------------------------------ -r14915 | lego | 2005-07-13 18:40:06 -0500 (Wed, 13 Jul 2005) | 3 lines +r15852 | lego | 2005-09-17 12:17:42 -0500 (Sat, 17 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/h248/packet-h248-template.c - M /trunk/epan/dissectors/packet-h248.c + M /trunk/Makefile.am + A /trunk/dtds + A /trunk/dtds/dc.dtd + A /trunk/dtds/itunes.dtd + A /trunk/dtds/rss.dtd + A /trunk/dtds/smil.dtd + M /trunk/packaging/nsis/ethereal.nsi -fix a string +Get the first few dtds installed. ------------------------------------------------------------------------ -r14914 | etxrab | 2005-07-13 16:38:07 -0500 (Wed, 13 Jul 2005) | 4 lines +r15851 | lego | 2005-09-17 12:05:46 -0500 (Sat, 17 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/dtd.h + M /trunk/epan/dtd_grammar.lemon + M /trunk/epan/dtd_parse.l + M /trunk/epan/dtd_preparse.l + +Because there's more than just text in XML... + +DTDs are imported to create fields -From Ilya Konstantinov : -fixes a tiny bug which caused the boolean fields not to refer to the same offset as their -parent. ------------------------------------------------------------------------ -r14913 | sahlberg | 2005-07-13 03:24:05 -0500 (Wed, 13 Jul 2005) | 3 lines +r15850 | ulfl | 2005-09-17 09:14:24 -0500 (Sat, 17 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/dcerpc/dssetup/packet-dcerpc-dssetup.c - M /trunk/epan/dissectors/packet-dcerpc-budb.c - M /trunk/epan/dissectors/packet-dcerpc-dssetup.c + M /trunk/epan/dissectors/packet-h1.c + +using heur_dissector_add("cotp_is") doesn't seem to be enough, if H1 is used over TCP/TPKT (RFC1006). Add heur_dissector_add("cotp") so it will be dissected correctly, hopefully this won't introduce new problems with other "cotp" heuristics ... +------------------------------------------------------------------------ +r15849 | sahlberg | 2005-09-17 07:16:11 -0500 (Sat, 17 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcm.c -convert two other autogenerated dissectors to use FT_GUID +remove some strcpy() ------------------------------------------------------------------------ -r14912 | sahlberg | 2005-07-13 03:00:15 -0500 (Wed, 13 Jul 2005) | 9 lines +r15848 | sahlberg | 2005-09-17 07:09:36 -0500 (Sat, 17 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/dcerpc/idl2eth.c - M /trunk/epan/dissectors/packet-dcerpc-drsuapi.c - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-fcswils.c -make idl2eth generate FT_GUID hf fields for uuid_t and GUID types. +remove some strcpy() -make dissect_dcerpc_uuid_t() accept eitehr FT_STRING (old style) and FT_GUID (new style) hf fields. once all dissectors are modified to use FT_GUID we can remove the FT_STRING support here. -regenerate the DRSUAPI interface with the new FT_GUID support. +------------------------------------------------------------------------ +r15847 | guy | 2005-09-16 21:14:44 -0500 (Fri, 16 Sep 2005) | 4 lines +Changed paths: + M /trunk/strerror.c +Fix Gerald's e-mail address (and possibly provoke a copy of the main +repository to the anonymous repository - the current anonymous +repository appears to be out-of-date, which is breaking the buildbot). +------------------------------------------------------------------------ +r15846 | guy | 2005-09-16 19:39:52 -0500 (Fri, 16 Sep 2005) | 2 lines +Changed paths: + M /trunk/gtk/expert_dlg.c +Mark some unused and unremovable arguments as unused. ------------------------------------------------------------------------ -r14911 | etxrab | 2005-07-13 00:06:38 -0500 (Wed, 13 Jul 2005) | 3 lines +r15845 | guy | 2005-09-16 19:31:15 -0500 (Fri, 16 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-aim-messaging.c - M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/Makefile.common + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/format-oid.h (from /trunk/epan/format-oid.h:15844) + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-smb-browse.c + M /trunk/epan/dissectors/packet-smb-mailslot.c + M /trunk/epan/dissectors/packet-smb-pipe.c + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + M /trunk/epan/dissectors/packet-smb.c + A /trunk/epan/dissectors/packet-smb.h (from /trunk/epan/smb.h:15844) + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-windows-common.c + A /trunk/epan/dissectors/rpc_defrag.h (from /trunk/epan/rpc_defrag.h:15844) + D /trunk/epan/format-oid.h + D /trunk/epan/rpc_defrag.h + D /trunk/epan/smb.h + M /trunk/gtk/smb_stat.c + M /trunk/tap-smbsids.c + M /trunk/tap-smbstat.c -From Ilya Konstantinov : - A patch to the AIM dissector to support Client Auto Response messages. I still don't know the meaning of all the fields as they weren't all mapped but this patch decodes all the important ones. +Move some headers for stuff defined by a dissector into epan/dissectors +- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file. ------------------------------------------------------------------------ -r14910 | ulfl | 2005-07-12 16:21:14 -0500 (Tue, 12 Jul 2005) | 1 line +r15844 | guy | 2005-09-16 19:02:31 -0500 (Fri, 16 Sep 2005) | 7 lines Changed paths: + M /trunk/Makefile.common + D /trunk/aftypes.h + D /trunk/arcnet_pids.h + M /trunk/asn1/h248/packet-h248-template.c + D /trunk/bridged_pids.h + D /trunk/chdlctypes.h + M /trunk/configure.in + M /trunk/epan/Makefile.common + A /trunk/epan/aftypes.h (from /trunk/aftypes.h:15843) + A /trunk/epan/arcnet_pids.h (from /trunk/arcnet_pids.h:15843) + A /trunk/epan/bridged_pids.h (from /trunk/bridged_pids.h:15843) + A /trunk/epan/chdlctypes.h (from /trunk/chdlctypes.h:15843) + M /trunk/epan/dissectors/packet-3com-xns.c + M /trunk/epan/dissectors/packet-aarp.c + M /trunk/epan/dissectors/packet-ap1394.c + M /trunk/epan/dissectors/packet-arcnet.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-asap.c + M /trunk/epan/dissectors/packet-atalk.c + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-bacnet.c + M /trunk/epan/dissectors/packet-bpdu.c + M /trunk/epan/dissectors/packet-brdwlk.c + M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-chdlc.c + M /trunk/epan/dissectors/packet-cisco-oui.c + M /trunk/epan/dissectors/packet-cisco-wireless.c M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-dec-bpdu.c + M /trunk/epan/dissectors/packet-dec-dnart.c + M /trunk/epan/dissectors/packet-dua.c + M /trunk/epan/dissectors/packet-eap.c + M /trunk/epan/dissectors/packet-eapol.c + M /trunk/epan/dissectors/packet-enc.c + M /trunk/epan/dissectors/packet-enrp.c + M /trunk/epan/dissectors/packet-esis.c + M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/dissectors/packet-extreme.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcct.c + M /trunk/epan/dissectors/packet-fcdns.c + M /trunk/epan/dissectors/packet-fcels.c + M /trunk/epan/dissectors/packet-fcfcs.c + M /trunk/epan/dissectors/packet-fcfzs.c + M /trunk/epan/dissectors/packet-fclctl.c + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-fcsb3.c + M /trunk/epan/dissectors/packet-fcsp.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/dissectors/packet-fw1.c + M /trunk/epan/dissectors/packet-g723.c + M /trunk/epan/dissectors/packet-gmrp.c + M /trunk/epan/dissectors/packet-gre.c + M /trunk/epan/dissectors/packet-gvrp.c + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h261.c + M /trunk/epan/dissectors/packet-h263.c + M /trunk/epan/dissectors/packet-hpext.c + M /trunk/epan/dissectors/packet-hpsw.c + M /trunk/epan/dissectors/packet-iapp.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-idp.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ieee802a.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-ipfc.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-isis-clv.c + M /trunk/epan/dissectors/packet-isis.c + M /trunk/epan/dissectors/packet-isl.c + M /trunk/epan/dissectors/packet-ismp.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-iua.c + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/epan/dissectors/packet-lapbether.c + M /trunk/epan/dissectors/packet-lapd.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-lldp.c + M /trunk/epan/dissectors/packet-lmi.c + M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-loop.c + M /trunk/epan/dissectors/packet-m2pa.c + M /trunk/epan/dissectors/packet-m2tp.c + M /trunk/epan/dissectors/packet-m2ua.c + M /trunk/epan/dissectors/packet-m3ua.c + M /trunk/epan/dissectors/packet-maccontrol.c + M /trunk/epan/dissectors/packet-mip6.c + M /trunk/epan/dissectors/packet-mpeg1.c + M /trunk/epan/dissectors/packet-mpls.c + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-netbios.c + M /trunk/epan/dissectors/packet-nt-oui.c + M /trunk/epan/dissectors/packet-nt-sonmp.c + M /trunk/epan/dissectors/packet-null.c + M /trunk/epan/dissectors/packet-osi-options.c + M /trunk/epan/dissectors/packet-osi.c + M /trunk/epan/dissectors/packet-pagp.c + M /trunk/epan/dissectors/packet-pflog.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-pppoe.c + M /trunk/epan/dissectors/packet-q2931.c + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-q933.c + M /trunk/epan/dissectors/packet-redback.c + M /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/epan/dissectors/packet-rmp.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rpl.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-sll.c + M /trunk/epan/dissectors/packet-slowprotocols.c + M /trunk/epan/dissectors/packet-smb-browse.c + M /trunk/epan/dissectors/packet-smb-mailslot.c + M /trunk/epan/dissectors/packet-smb-pipe.c + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-snaeth.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-sua.c + M /trunk/epan/dissectors/packet-symantec.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-teimanagement.c + M /trunk/epan/dissectors/packet-vines.c + M /trunk/epan/dissectors/packet-vj.c + M /trunk/epan/dissectors/packet-vlan.c + M /trunk/epan/dissectors/packet-wcp.c + M /trunk/epan/dissectors/packet-wfleet-hdlc.c + M /trunk/epan/dissectors/packet-windows-common.c + M /trunk/epan/dissectors/packet-x25.c + M /trunk/epan/dissectors/packet-x29.c + A /trunk/epan/etypes.h (from /trunk/etypes.h:15843) + A /trunk/epan/format-oid.h (from /trunk/format-oid.h:15843) + A /trunk/epan/greproto.h (from /trunk/greproto.h:15843) + A /trunk/epan/iax2_codec_type.h (from /trunk/iax2_codec_type.h:15843) + A /trunk/epan/ip_opts.h (from /trunk/ip_opts.h:15843) + A /trunk/epan/lapd_sapi.h (from /trunk/lapd_sapi.h:15843) + A /trunk/epan/llcsaps.h (from /trunk/llcsaps.h:15843) + A /trunk/epan/nlpid.h (from /trunk/nlpid.h:15843) + A /trunk/epan/oui.h (from /trunk/oui.h:15843) + A /trunk/epan/ppptypes.h (from /trunk/ppptypes.h:15843) + A /trunk/epan/rpc_defrag.h (from /trunk/rpc_defrag.h:15843) + A /trunk/epan/rtp_pt.h (from /trunk/rtp_pt.h:15843) + A /trunk/epan/sctpppids.h (from /trunk/sctpppids.h:15843) + A /trunk/epan/smb.h (from /trunk/smb.h:15843) + A /trunk/epan/x264_prt_id.h (from /trunk/x264_prt_id.h:15843) + D /trunk/etypes.h + D /trunk/format-oid.h + D /trunk/greproto.h + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls.c + D /trunk/iax2_codec_type.h + D /trunk/ip_opts.h + D /trunk/lapd_sapi.h + D /trunk/llcsaps.h + D /trunk/nlpid.h + D /trunk/oui.h + M /trunk/plugins/megaco/packet-megaco.c + M /trunk/plugins/rdm/packet-rdm.c + M /trunk/plugins/rtnet/packet-rtnet.c + M /trunk/plugins/v5ua/packet-v5ua.c + D /trunk/ppptypes.h + D /trunk/rpc_defrag.h + D /trunk/rtp_pt.h + D /trunk/sctpppids.h + D /trunk/smb.h + M /trunk/tap-smbsids.c + M /trunk/tap-smbstat.c + D /trunk/x264_prt_id.h + +Move a pile of protocol-related headers from the top-level source +directory to the epan directory. Some of them should perhaps ultimately +be moved to epan/dissectors, if they pertain only to stuff exported by a +particular dissector. + +Fix Gerald's e-mail address in files we're moving. -code cleanup: use "correct" proto_tree_add_... functions for li and tpdu code fields ------------------------------------------------------------------------ -r14909 | ulfl | 2005-07-12 16:09:34 -0500 (Tue, 12 Jul 2005) | 1 line +r15843 | ulfl | 2005-09-16 17:17:50 -0500 (Fri, 16 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-tpkt.c + M /trunk/epan/dissectors/packet-dcom-cba-acco.c -add some more textual explanations of the protocol and it's fields +add an expert info based on QualityCode and a COL_INFO output ------------------------------------------------------------------------ -r14908 | tuexen | 2005-07-12 16:04:05 -0500 (Tue, 12 Jul 2005) | 2 lines +r15842 | ulfl | 2005-09-16 17:14:33 -0500 (Fri, 16 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/sctp_assoc_analyse.c - M /trunk/gtk/sctp_graph_dlg.c + M /trunk/epan/dissectors/packet-pn-rt.c -From Irene Ruengeler: Handle multiple gap reports correctly and use correct name of a button. +slightly shrink COL_INFO output +------------------------------------------------------------------------ +r15841 | ulfl | 2005-09-16 17:05:50 -0500 (Fri, 16 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc.c +split call id's with a #, if more than one DCE/RPC call is in a data PDU ------------------------------------------------------------------------ -r14907 | etxrab | 2005-07-12 15:30:33 -0500 (Tue, 12 Jul 2005) | 1 line +r15840 | gerald | 2005-09-16 11:25:53 -0500 (Fri, 16 Sep 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-gtp.c + M /trunk/Makefile.nmake + M /trunk/config.nmake + M /trunk/gtk/conversations_table.c + +Sort each conversation column numerically. Fix up whitespace. + +It looks like we can't put "COPYCMD=/Y" in config.nmake and expect nmake +to do the right thing. Add a comment, and set COPYCMD explicitly in the +root Makefile.nmake. The rest of the occurrences of xcopy will have to +be taken care of at some point. -Fix decoding of quintuplets. ------------------------------------------------------------------------ -r14906 | jmayer | 2005-07-12 12:08:17 -0500 (Tue, 12 Jul 2005) | 4 lines +r15839 | tpot | 2005-09-16 07:30:33 -0500 (Fri, 16 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors + M /trunk/epan/dissectors/Makefile.common -Update svn:ignore - Add register.c-tmp - Remove duplicate tags and TAGS +Aargh - undo r15838 as I missed jmayer's commit of r15835. ------------------------------------------------------------------------ -r14905 | jmayer | 2005-07-12 12:06:09 -0500 (Tue, 12 Jul 2005) | 3 lines +r15838 | tpot | 2005-09-16 07:11:17 -0500 (Fri, 16 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-radiotap.c + M /trunk/epan/dissectors/Makefile.common -Add value for FCS (no decoding). -Fix a signedness warning. +Comment out pidl dissectors for the moment to get the win32 build +going again. I have most of a patch to get it working but I don't +think it will be finished tonight. ------------------------------------------------------------------------ -r14904 | jmayer | 2005-07-12 07:44:42 -0500 (Tue, 12 Jul 2005) | 8 lines +r15837 | guy | 2005-09-16 04:47:18 -0500 (Fri, 16 Sep 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-snmp.c + +If we've enabled the display of BER encapsulation tokens, only put them +into the protocol tree once. + +Fix the offsets and lengths used to put the variable binding values into +the protocol tree. + +------------------------------------------------------------------------ +r15836 | jmayer | 2005-09-16 04:31:05 -0500 (Fri, 16 Sep 2005) | 5 lines +Changed paths: + A /trunk/tools/pidl + A /trunk/tools/pidl/Makefile.PL + A /trunk/tools/pidl/README + A /trunk/tools/pidl/README.ethereal + A /trunk/tools/pidl/TODO + A /trunk/tools/pidl/idl.yp + A /trunk/tools/pidl/lib + A /trunk/tools/pidl/lib/Parse + A /trunk/tools/pidl/lib/Parse/Pidl + A /trunk/tools/pidl/lib/Parse/Pidl/Compat.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Dump.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Ethereal + A /trunk/tools/pidl/lib/Parse/Pidl/Ethereal/Conformance.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Ethereal/NDR.pm + A /trunk/tools/pidl/lib/Parse/Pidl/IDL.pm + A /trunk/tools/pidl/lib/Parse/Pidl/NDR.pm + A /trunk/tools/pidl/lib/Parse/Pidl/ODL.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Header.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Proxy.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/COM/Stub.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/EJS.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/EJSHeader.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/Header.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Client.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Header.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Parser.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/NDR/Server.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/SWIG.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/TDR.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Samba/Template.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Test.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Typelist.pm + A /trunk/tools/pidl/lib/Parse/Pidl/Util.pm + A /trunk/tools/pidl/lib/Parse/Pidl.pm + A /trunk/tools/pidl/pidl + A /trunk/tools/pidl/pidl.1.xml + A /trunk/tools/pidl/pm_to_blib + A /trunk/tools/pidl/ref_notes.txt + A /trunk/tools/pidl/smb_interfaces.pm + A /trunk/tools/pidl/smb_interfaces.yp + + +Add a local copy of pidl, add a README.ethereal to include +minimalistic building and usage instructions. + + +------------------------------------------------------------------------ +r15835 | jmayer | 2005-09-16 03:55:51 -0500 (Fri, 16 Sep 2005) | 6 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.common - M /trunk/epan/dissectors/Makefile.am M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-dcerpc-atsvc.c (from /trunk/epan/dissectors/pidl/packet-dcerpc-atsvc.c:15833) + A /trunk/epan/dissectors/packet-dcerpc-atsvc.h (from /trunk/epan/dissectors/pidl/packet-dcerpc-atsvc.h:15833) + A /trunk/epan/dissectors/packet-dcerpc-initshutdown.c (from /trunk/epan/dissectors/pidl/packet-dcerpc-initshutdown.c:15833) + A /trunk/epan/dissectors/packet-dcerpc-initshutdown.h (from /trunk/epan/dissectors/pidl/packet-dcerpc-initshutdown.h:15833) + A /trunk/epan/dissectors/packet-dcerpc-winreg.c (from /trunk/epan/dissectors/pidl/packet-dcerpc-winreg.c:15833) + A /trunk/epan/dissectors/packet-dcerpc-winreg.h (from /trunk/epan/dissectors/pidl/packet-dcerpc-winreg.h:15833) -Remove/replace SPACES at the beginning of Makefile.am/Makefile.common -files as not all make implementation work with this. -Found by running -grep '^ ' `find . -name "Makefile.am" -o -name "Makefile.common"` +Move the packet-dcerpc-*.[hc] from pidl/ back to dissectors. +This makes Ethereal build again - there's no real reason that +ethereal fails to build for such a long time on so many platforms. -Gerald: Maybe adding this to the buildbot would be a good idea after all. ------------------------------------------------------------------------ -r14903 | guy | 2005-07-11 20:01:19 -0500 (Mon, 11 Jul 2005) | 2 lines +r15834 | jmayer | 2005-09-16 03:40:08 -0500 (Fri, 16 Sep 2005) | 5 lines Changed paths: - M /trunk/asn1/ftam/ftam.cnf - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-spnego.c - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/manuf + M /trunk/wka.tmpl -Fix some more signed vs. unsigned warnings. +wka.tmpl: + Show MS NLB Adresses individually +manuf: + Update ------------------------------------------------------------------------ -r14902 | guy | 2005-07-11 17:48:51 -0500 (Mon, 11 Jul 2005) | 3 lines +r15833 | guy | 2005-09-16 03:30:35 -0500 (Fri, 16 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ntlmssp.c + M /trunk/epan/dissectors/packet-ber.c -In NTLMSP_AUTH messages, include the domain name and user name in the -Info column. +Note problems with some values that appear in, for example, some SNMP +captures. ------------------------------------------------------------------------ -r14901 | etxrab | 2005-07-11 17:27:20 -0500 (Mon, 11 Jul 2005) | 1 line +r15832 | guy | 2005-09-16 02:50:02 -0500 (Fri, 16 Sep 2005) | 2 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-lldp.c + +Fix a type. -Add Jeremy j Ouellette ------------------------------------------------------------------------ -r14900 | etxrab | 2005-07-11 17:23:57 -0500 (Mon, 11 Jul 2005) | 1 line +r15831 | tpot | 2005-09-15 23:25:12 -0500 (Thu, 15 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/pidl/winreg.cnf + +Add conformance file used for building winreg dissector. -DIS dissection ------------------------------------------------------------------------ -r14899 | etxrab | 2005-07-11 17:23:15 -0500 (Mon, 11 Jul 2005) | 2 lines +r15830 | ulfl | 2005-09-15 19:02:31 -0500 (Thu, 15 Sep 2005) | 1 line Changed paths: - A /trunk/epan/dissectors/packet-dis-enums.c - A /trunk/epan/dissectors/packet-dis-enums.h - A /trunk/epan/dissectors/packet-dis-fields.c - A /trunk/epan/dissectors/packet-dis-fields.h - A /trunk/epan/dissectors/packet-dis-pdus.c - A /trunk/epan/dissectors/packet-dis-pdus.h - A /trunk/epan/dissectors/packet-dis.c + M /trunk/gtk/packet_list.c -From Jeremy j Ouellette: -DIS dissection. +fixing the fix, it's time to go to bed ... ------------------------------------------------------------------------ -r14898 | ulfl | 2005-07-11 15:14:43 -0500 (Mon, 11 Jul 2005) | 1 line +r15829 | ulfl | 2005-09-15 18:44:07 -0500 (Thu, 15 Sep 2005) | 1 line Changed paths: - M /trunk/colorfilters + M /trunk/gtk/packet_list.c -fix a syntax error in the "Routing" rule, reported by Jeff Morriss +bugfix: don't crash (assert), if jumping to the first packet and packet_list is currently empty. Can happen at capture start. ------------------------------------------------------------------------ -r14897 | etxrab | 2005-07-11 14:25:25 -0500 (Mon, 11 Jul 2005) | 1 line +r15828 | guy | 2005-09-15 18:39:08 -0500 (Thu, 15 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_a.h - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-spnego.h + +Don't use u_char - not all platforms define it, and even those that do +might require other files to be included to get it. -Dissect some more fields ------------------------------------------------------------------------ -r14896 | etxrab | 2005-07-11 14:24:30 -0500 (Mon, 11 Jul 2005) | 1 line +r15827 | guy | 2005-09-15 18:17:42 -0500 (Thu, 15 Sep 2005) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + A /trunk/asn1/spnego/Makefile + +Add a Makefile. -Dissect some more fields ------------------------------------------------------------------------ -r14895 | guy | 2005-07-10 13:29:43 -0500 (Sun, 10 Jul 2005) | 9 lines +r15826 | lego | 2005-09-15 14:30:44 -0500 (Thu, 15 Sep 2005) | 4 lines Changed paths: - M /trunk/gtk/tcp_graph.c - -Just pass &cfile to select_tcpip_session(); we don't need to pass -cfile.current_frame to it separately. + M /trunk/epan/dissectors/packet-alcap.c + M /trunk/epan/dissectors/packet-alcap.h -Note that we shouldn't ever get a "Selected packet isn't a TCP segment" -error any more; we can now handle all link layers. +Add more information regarding call legs. +Make the release cause value filterable. -Give a little more detail in the message shown if there's *more than -one* TCP header in the packet. ------------------------------------------------------------------------ -r14894 | guy | 2005-07-10 05:10:40 -0500 (Sun, 10 Jul 2005) | 5 lines +r15825 | lego | 2005-09-15 14:26:05 -0500 (Thu, 15 Sep 2005) | 3 lines Changed paths: - M /trunk/gtk/tcp_graph.c + M /trunk/gtk/stats_tree_stat.c -Fix some comment typos. +leak fix -Don't regenerate the packet list when generating the TCP stream graph - -it won't be changing; just redissect and run the tap. ------------------------------------------------------------------------ -r14893 | guy | 2005-07-10 04:26:20 -0500 (Sun, 10 Jul 2005) | 3 lines +r15824 | gerald | 2005-09-15 13:42:04 -0500 (Thu, 15 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-lpd.c + M /trunk/epan/dissectors/packet-fc.c -Put the data (print job contents) in LPD requests under the LPD protocol -item, rather than making it a top-level item. +Fix fragment length checks. Fixes bugs 440 and 442-446. ------------------------------------------------------------------------ -r14892 | guy | 2005-07-10 04:21:57 -0500 (Sun, 10 Jul 2005) | 2 lines +r15823 | sahlberg | 2005-09-15 08:41:56 -0500 (Thu, 15 Sep 2005) | 3 lines Changed paths: - M /trunk/gtk/tcp_graph.c + M /trunk/epan/dissectors/packet-vines.c + +remove some redundant strcpy() -Get rid of an unused argument. ------------------------------------------------------------------------ -r14891 | jmayer | 2005-07-10 03:04:27 -0500 (Sun, 10 Jul 2005) | 7 lines +r15822 | sahlberg | 2005-09-15 08:36:31 -0500 (Thu, 15 Sep 2005) | 3 lines Changed paths: - M /trunk/Makefile.am - M /trunk/doc/Makefile.am - M /trunk/epan/Makefile.am - M /trunk/epan/dfilter/Makefile.am - M /trunk/epan/dissectors/Makefile.am - M /trunk/epan/ftypes/Makefile.am - M /trunk/gtk/Makefile.am - M /trunk/help/Makefile.am - M /trunk/packaging/Makefile.am - M /trunk/packaging/nsis/Makefile.am - M /trunk/packaging/rpm/Makefile.am - M /trunk/packaging/rpm/SPECS/Makefile.am - M /trunk/packaging/svr4/Makefile.am - M /trunk/plugins/Makefile.am - M /trunk/plugins/acn/Makefile.am - M /trunk/plugins/agentx/Makefile.am - M /trunk/plugins/artnet/Makefile.am - M /trunk/plugins/asn1/Makefile.am - M /trunk/plugins/ciscosm/Makefile.am - M /trunk/plugins/docsis/Makefile.am - M /trunk/plugins/enttec/Makefile.am - M /trunk/plugins/giop/Makefile.am - M /trunk/plugins/gryphon/Makefile.am - M /trunk/plugins/irda/Makefile.am - M /trunk/plugins/lwres/Makefile.am - M /trunk/plugins/mate/Makefile.am - M /trunk/plugins/megaco/Makefile.am - M /trunk/plugins/mgcp/Makefile.am - M /trunk/plugins/opsi/Makefile.am - M /trunk/plugins/pcli/Makefile.am - M /trunk/plugins/profinet/Makefile.am - M /trunk/plugins/rdm/Makefile.am - M /trunk/plugins/rlm/Makefile.am - M /trunk/plugins/rtnet/Makefile.am - M /trunk/plugins/rudp/Makefile.am - M /trunk/plugins/stats_tree/Makefile.am - M /trunk/plugins/v5ua/Makefile.am - M /trunk/plugins/xml/Makefile.am - M /trunk/tools/Makefile.am - M /trunk/tools/lemon/Makefile.am - M /trunk/wiretap/Makefile.am + M /trunk/epan/dissectors/packet-isis-lsp.c -After doing "make maintainer-clean", "svn status --no-ignore | grep ^I" -returned quite a list of files. Add them to MAINTAINERCLEANFILES. +remove some redundant strcpy() -Whitespace changes (replace multiple spaces by TABs, in a few cases this -needed to be done at the beginning of Makefile lines. + +------------------------------------------------------------------------ +r15821 | sahlberg | 2005-09-15 08:31:05 -0500 (Thu, 15 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ip.c + +remove a whole bunch of strcpy() fix minor bug where whe checked the wrong string before we display it ------------------------------------------------------------------------ -r14890 | sahlberg | 2005-07-10 00:27:38 -0500 (Sun, 10 Jul 2005) | 19 lines +r15820 | sahlberg | 2005-09-15 08:20:32 -0500 (Thu, 15 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ospf.c -For packets flagged as Retransmission +update for ospf from Senthil Kumar Nagappan -calculate RTO as the delta between the retransmitted frame and the last previous frame seen for this session (in the same direction). -while this is technically not the RTO this delta is in most cases more important/useful than the tru RTO anyway since this measure represents the amount of thiime that the link went idle while waiting for an RTO. +------------------------------------------------------------------------ +r15819 | sahlberg | 2005-09-15 05:20:08 -0500 (Thu, 15 Sep 2005) | 3 lines +Changed paths: + D /trunk/epan/dissectors/dcerpc/atsvc +delete the old dissector +------------------------------------------------------------------------ +r15818 | sahlberg | 2005-09-15 05:19:25 -0500 (Thu, 15 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common + D /trunk/epan/dissectors/packet-dcerpc-atsvc.c + D /trunk/epan/dissectors/packet-dcerpc-atsvc.h + +delete the old dissector and point the makefile to the new dissector -It would be nice with a statistics tap for TCP where one couls see, seeion by session : -Length in time of the session. -Total bytes transferred -Number of retransmissions -Time spent waiting for an RTO -Time spent waiting for an RTO in % of the total time. +------------------------------------------------------------------------ +r15817 | sahlberg | 2005-09-15 05:18:08 -0500 (Thu, 15 Sep 2005) | 3 lines +Changed paths: + A /trunk/epan/dissectors/pidl/atsvc.cnf + A /trunk/epan/dissectors/pidl/atsvc.idl + A /trunk/epan/dissectors/pidl/packet-dcerpc-atsvc.c + A /trunk/epan/dissectors/pidl/packet-dcerpc-atsvc.h +new pidl generated atsvc dissector and its conformance file ------------------------------------------------------------------------ -r14889 | sahlberg | 2005-07-09 21:59:50 -0500 (Sat, 09 Jul 2005) | 14 lines +r15816 | guy | 2005-09-15 04:09:00 -0500 (Thu, 15 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/tcp_graph.c + M /trunk/epan/value_string.c -It works reasonably well with extensive testing so here goes : +Get rid of a no-longer-used variable. -tcp-graph has been modified to extract tcp data from a TAP instead of reading and parsing directly from the capture file. +------------------------------------------------------------------------ +r15815 | guy | 2005-09-15 03:57:51 -0500 (Thu, 15 Sep 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-lldp.c + M /trunk/oui.h -This makes tcp graph work for any type of capture and for any transport. +Move OUIs from LLDP dissector to oui.h. +Get rid of remaining sprintf'ing into on-the-stack buffers. +Note where some items came from. +------------------------------------------------------------------------ +r15814 | guy | 2005-09-15 03:55:43 -0500 (Thu, 15 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/value_string.c -In the future someone with access to captures with TCP over something over TCP -to add a dialog where the user can specify WHICH of the multiple TCP sessions to graph. +Use ep_strdup_printf() to generate the "not found in value_string table" +string for val_to_str(). +------------------------------------------------------------------------ +r15813 | guy | 2005-09-15 03:54:56 -0500 (Thu, 15 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/emem.h +Tag ep_strdup_printf() and se_strdup_printf() as printf-like functions, +so we get compile-time checking of arguments when possible. ------------------------------------------------------------------------ -r14888 | ulfl | 2005-07-09 06:28:13 -0500 (Sat, 09 Jul 2005) | 5 lines +r15812 | tpot | 2005-09-15 02:34:52 -0500 (Thu, 15 Sep 2005) | 7 lines Changed paths: - M /trunk/gtk/summary_dlg.c + M /trunk/epan/dissectors/Makefile.common + D /trunk/epan/dissectors/packet-dcerpc-initshutdown.c + D /trunk/epan/dissectors/packet-dcerpc-initshutdown.h + D /trunk/epan/dissectors/packet-dcerpc-reg.c + D /trunk/epan/dissectors/packet-dcerpc-reg.h + M /trunk/epan/dissectors/packet-dcerpc-spoolss.c + A /trunk/epan/dissectors/pidl + A /trunk/epan/dissectors/pidl/README + A /trunk/epan/dissectors/pidl/initshutdown.idl + A /trunk/epan/dissectors/pidl/packet-dcerpc-initshutdown.c + A /trunk/epan/dissectors/pidl/packet-dcerpc-initshutdown.h + A /trunk/epan/dissectors/pidl/packet-dcerpc-winreg.c + A /trunk/epan/dissectors/pidl/packet-dcerpc-winreg.h + A /trunk/epan/dissectors/pidl/winreg.idl -MSVC: fix some guint64 related compiler errors +A first go at importing some pidl generated code into ethereal. This +commit replaces the hand written dcerpc initshutdown and winreg +interfaces with autogenerated ones. -strange enough, MSVC cannot convert from guint64 to float, so cast guint64 -> gint64 -> float +The pidl generated code is still a bit rought around the edges but will +hopefully improve with time. -However, even gint64 might be big enough to prevent us from an overflow :-) ------------------------------------------------------------------------ -r14887 | ulfl | 2005-07-09 06:26:46 -0500 (Sat, 09 Jul 2005) | 2 lines +r15811 | guy | 2005-09-15 01:04:33 -0500 (Thu, 15 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/conversations_table.c - M /trunk/gtk/hostlist_table.c + M /trunk/acinclude.m4 + M /trunk/config.h.win32 + M /trunk/configure.in -MSVC: fix some guint64 related compiler warnings, could someone please review my comment(s), I don't think it's currently implemented correct +Add PRIX64, as we now use it. ------------------------------------------------------------------------ -r14886 | guy | 2005-07-08 22:25:25 -0500 (Fri, 08 Jul 2005) | 4 lines +r15810 | etxrab | 2005-09-15 00:38:37 -0500 (Thu, 15 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h - M /trunk/epan/dissectors/packet-kink.c + A /trunk/asn1/spnego + A /trunk/asn1/spnego/Makefile.nmake + A /trunk/asn1/spnego/packet-spnego-template.c + A /trunk/asn1/spnego/packet-spnego-template.h + A /trunk/asn1/spnego/spnego.asn + A /trunk/asn1/spnego/spnego.cnf M /trunk/epan/dissectors/packet-spnego.c + A /trunk/epan/dissectors/packet-spnego.h -Make a bunch of items in encryption code arrays of guint8, and make some -pointers either "void *" or "guint8 *", to reduce the level of compiler -warnings (the data in question is largely binary in those cases). - +Replace the spnego dissector with an asn2eth generated one. ------------------------------------------------------------------------ -r14885 | guy | 2005-07-08 21:58:07 -0500 (Fri, 08 Jul 2005) | 8 lines +r15809 | guy | 2005-09-15 00:22:20 -0500 (Thu, 15 Sep 2005) | 8 lines Changed paths: - M /trunk/asn1/acse/acse.cnf - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/ocsp/ocsp.cnf - M /trunk/asn1/pkix1explicit/pkix1explicit.cnf - M /trunk/asn1/smrse/smrse.cnf - M /trunk/asn1/x509af/x509af.cnf - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-ocsp.c - M /trunk/epan/dissectors/packet-ocsp.h - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-pkix1explicit.h - M /trunk/epan/dissectors/packet-smrse.c - M /trunk/epan/dissectors/packet-smrse.h - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h + M /trunk/epan/dissectors/packet-lldp.c + +Rename TLV_INFO_MASK to TLV_INFO_LEN_MASK, to match TLV_TYPE_MASK. -Fix up a bunch of arguments to "dissect_ber_identifier()" to match its -current signature ("class" is a "gint8 *", not a "guint8 *", and "tag" -is a "gint32 *", not a "guint32 *"). Re-generate the dissectors from -the ASN.1 and the .cnf files in the cases where the arguments were fixed -in a .cnf file. +Use "tvb_format_stringzpad()" rather than "tvb_format_text()" on +strings, as some of them are null-padded. (XXX - are they null-padded +or null-terminated?) -Give some dissectors the right svn:keywords and svn:eol-style settings. +Clean up the TLV length checks, and do many more such checks. ------------------------------------------------------------------------ -r14884 | guy | 2005-07-08 19:53:17 -0500 (Fri, 08 Jul 2005) | 20 lines +r15808 | guy | 2005-09-14 23:08:53 -0500 (Wed, 14 Sep 2005) | 16 lines Changed paths: - M /trunk/epan/dissectors/packet-ans.c - M /trunk/epan/dissectors/packet-ap1394.c - M /trunk/epan/dissectors/packet-aruba-adp.c - M /trunk/epan/dissectors/packet-beep.c - M /trunk/epan/dissectors/packet-bssap.c - M /trunk/epan/dissectors/packet-bssgp.c - M /trunk/epan/dissectors/packet-cip.c - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/dissectors/packet-echo.c - M /trunk/epan/dissectors/packet-enc.c - M /trunk/epan/dissectors/packet-eth.c - M /trunk/epan/dissectors/packet-gtp.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-igmp.c - M /trunk/epan/dissectors/packet-ip.c - M /trunk/epan/dissectors/packet-ipdc.c - M /trunk/epan/dissectors/packet-ipv6.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/epan/dissectors/packet-lmp.c - M /trunk/epan/dissectors/packet-m2pa.c - M /trunk/epan/dissectors/packet-manolito.c - M /trunk/epan/dissectors/packet-nlm.c - M /trunk/epan/dissectors/packet-nsip.c - M /trunk/epan/dissectors/packet-pgm.c - M /trunk/epan/dissectors/packet-rdt.c - M /trunk/epan/dissectors/packet-retix-bpdu.c - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-skinny.c - M /trunk/epan/dissectors/packet-uma.c - -Squelch various signed vs. unsigned warnings by: + M /trunk/epan/dissectors/packet-lldp.c - making pointers to byte data be "guint8 *" rather than "char *", - and making buffers holding byte data arrays of "guint8" rather - than arrays of "char"; +We already define ETHERTYPE_LLDP in "etypes.h" - use that, don't define +our own. - making pointers to text strings "char *" rather than "guchar *"; +Get rid of MAC_to_str() - ether_to_str() suffices. - appropriately casting pointers (cast to "guint8 *" when passing - to routines expecting "guint8 *" or when assigning to "guint8 - *"); +Don't copy to on-the-stack fixed-size string buffers, just save the +results of various formatting calls as pointers. - making port-number preferences "guint"; +Use tvb_format_text() to get displayable versions of text strings. - making enum preferences "gint"; +Use tvb_get_ipv4() and tvb_get_ipv6(). - making hf_ variables "int". - -Clean up white space. +Don't put an item into the protocol tree as text and then put in a +hidden item that, if unhidden, would display the same or almost exactly +the same; just put the item into the tree unhidden. ------------------------------------------------------------------------ -r14883 | guy | 2005-07-08 19:47:57 -0500 (Fri, 08 Jul 2005) | 6 lines +r15807 | guy | 2005-09-14 22:09:40 -0500 (Wed, 14 Sep 2005) | 22 lines Changed paths: - M /trunk/epan/dissectors/packet-lwapp.c + M /trunk/epan/dissectors/packet-lldp.c + +Properly handle 64-bit integer constants (they don't happen by magic, +and the stuff you have to do is compiler-dependent, so use +G_GINT64_CONSTANT()). + +Properly handle formatting 64-bit quantities (they don't format +correctly by magic, and the stuff you have to do is compiler-dependent, +so use PRI[duoxX]64). -MAC addresses are arrays of bytes, not strings; make the destination MAC -address an array of guint8 - that squelches some compiler warnings. +Don't copy the result of tvb_bytes_to_str() to a string buffer and then +only use it as an argument to a "%s" - just use the result directly. -Use -1 rather than tvb_length(tvb) to make the item for LWAPP go to the -end of the tvbuff. +Don't copy constant strings to a buffer - just use the strings directly. + +Fetch 64-bit integral quantities with tvb_get_ntoh64(); they're +presumably in a standard byte order, which is probably big-endian for +Internet-family protocols, and using tvb_memcpy() is *guaranteed* to be +wrong on some platforms. + +Fix up a format string. + +Fix up indentation a bit. ------------------------------------------------------------------------ -r14882 | guy | 2005-07-08 19:44:44 -0500 (Fri, 08 Jul 2005) | 11 lines +r15806 | guy | 2005-09-14 22:03:29 -0500 (Wed, 14 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-bittorrent.c - -Find the BitTorrent dissector immediately after registering it, and save -the handle, rather than finding it every time we need it. + M /trunk/epan/dissectors/packet-fcswils.c -Just make a guint8 array with the BitTorrent magic string length -followed by the string, and use "tvb_memeql()" to test against that - it -handles checking to make sure there's enough data in the tvbuff (if -not, it returns -1 as a "no match" indication) and then checks all of -the first 20 bytes in one operation. +Squelch some warnings, fix some typoes. -Clean up white space. +------------------------------------------------------------------------ +r15805 | ulfl | 2005-09-14 18:15:12 -0500 (Wed, 14 Sep 2005) | 1 line +Changed paths: + M /trunk/tethereal.c +fix wtap_dump_flush function name and don't check for it's return value. We don't do this check in Ethereal either and we will recognize problems at next write anyway ... ------------------------------------------------------------------------ -r14881 | guy | 2005-07-08 19:35:13 -0500 (Fri, 08 Jul 2005) | 8 lines +r15804 | ulfl | 2005-09-14 16:57:30 -0500 (Wed, 14 Sep 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-icep.c + M /trunk/capture_loop.c + M /trunk/editcap.c + M /trunk/file.c + M /trunk/file.h + M /trunk/gtk/file_dlg.c + M /trunk/mergecap.c + M /trunk/randpkt.c + M /trunk/ringbuffer.c + M /trunk/tethereal.c + M /trunk/wiretap/file_access.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/wtap-int.h + M /trunk/wiretap/wtap.def + M /trunk/wiretap/wtap.h + +added compression support for capture file output. The Save/As dialog now has a checkbox "Compress with gzip" + +currently limited to Ethereal and all the variants of libpcap filetypes only. -Use "tvb_get_string()" rather than duplicating its functionality by -hand. +We might want to add output compression support to the other tools as well (tethereal, mergecap, ...). -Use "g_strdup()" rather than duplicating its functionality by hand. +We might also want to add support for the other filetypes, but this is only possible if the filetype functions doesn't use special output operations like fseek. -Make the magic number an array of "guint8", as "tvb_memeql()" expects a -pointer to "guint8". +One bug is still left: if the input and output filetypes while saving are the same, Ethereal currently optimizes this by simply copy the binary file instead of using wiretap (so it will be faster but it will ignore the compress setting). +Don't know a good workaround for this, as I don't know a way to find out if the input file is currently compressed or not. One idea might be to use a heuristic on the filesize (compared to the packet size summmary). Another workaround I see is to remove this optimization, which is of course not the way I like to do it ... ------------------------------------------------------------------------ -r14880 | ulfl | 2005-07-08 17:11:13 -0500 (Fri, 08 Jul 2005) | 1 line +r15803 | ulfl | 2005-09-14 15:09:17 -0500 (Wed, 14 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dnp.c - M /trunk/epan/dissectors/packet-eth.c - M /trunk/epan/dissectors/packet-gprs-llc.c - M /trunk/epan/dissectors/packet-gre.c - M /trunk/epan/dissectors/packet-icmpv6.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-igmp.c - M /trunk/epan/dissectors/packet-ip.c - M /trunk/epan/dissectors/packet-isis-hello.c - M /trunk/epan/dissectors/packet-isis-lsp.c - M /trunk/epan/dissectors/packet-isis-snp.c - M /trunk/epan/dissectors/packet-lmp.c - M /trunk/epan/dissectors/packet-ospf.c - M /trunk/epan/dissectors/packet-pgm.c - M /trunk/epan/dissectors/packet-pim.c - M /trunk/epan/dissectors/packet-ppp.c - M /trunk/epan/dissectors/packet-rsvp.c - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/dissectors/packet-vrrp.c - -checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages ------------------------------------------------------------------------- -r14879 | ulfl | 2005-07-08 17:04:35 -0500 (Fri, 08 Jul 2005) | 1 line -Changed paths: - M /trunk/docbook/graphics/ethereal-analyze-menu.png - M /trunk/docbook/graphics/ethereal-bytes-pane-popup-menu.png - M /trunk/docbook/graphics/ethereal-capture-menu.png - M /trunk/docbook/graphics/ethereal-capture-options.png - M /trunk/docbook/graphics/ethereal-decode-as.png - M /trunk/docbook/graphics/ethereal-details-pane-popup-menu.png - M /trunk/docbook/graphics/ethereal-details-pane.png - M /trunk/docbook/graphics/ethereal-display-filter-tcp.png - M /trunk/docbook/graphics/ethereal-edit-menu.png - M /trunk/docbook/graphics/ethereal-file-menu.png - M /trunk/docbook/graphics/ethereal-filter-toolbar.png - M /trunk/docbook/graphics/ethereal-find-packet.png - M /trunk/docbook/graphics/ethereal-follow-stream.png - M /trunk/docbook/graphics/ethereal-go-menu.png - M /trunk/docbook/graphics/ethereal-gui-preferences.png - M /trunk/docbook/graphics/ethereal-help-menu.png - M /trunk/docbook/graphics/ethereal-list-pane.png - M /trunk/docbook/graphics/ethereal-main-toolbar.png - M /trunk/docbook/graphics/ethereal-main.png - M /trunk/docbook/graphics/ethereal-packet-pane-popup-menu.png - M /trunk/docbook/graphics/ethereal-packet-selected.png - M /trunk/docbook/graphics/ethereal-statistics-menu.png - M /trunk/docbook/graphics/ethereal-stats-conversations.png - M /trunk/docbook/graphics/ethereal-stats-endpoints.png - M /trunk/docbook/graphics/ethereal-time-reference.png - M /trunk/docbook/graphics/ethereal-view-menu.png - M /trunk/docbook/user-guide.xml - -Update the EDG screenshots to reflect the latest Ethereal GUI changes ------------------------------------------------------------------------- -r14878 | etxrab | 2005-07-08 15:01:11 -0500 (Fri, 08 Jul 2005) | 3 lines + M /trunk/epan/dissectors/packet-dcerpc.c + +add E_OUTOFMEMORY +------------------------------------------------------------------------ +r15802 | etxrab | 2005-09-14 14:14:23 -0500 (Wed, 14 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/proto.c -Add some missing IMPLICIT tags, and use FN_PARS directive. +From Peter Johansson +I added a description for the call to DISSECTOR_ASSERT in proto.c to be +printed to stderr. -Add disection of some RR elements and command Handover. ------------------------------------------------------------------------ -r14877 | etxrab | 2005-07-08 14:59:56 -0500 (Fri, 08 Jul 2005) | 1 line +r15801 | etxrab | 2005-09-14 14:11:23 -0500 (Wed, 14 Sep 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-snmp.c -Add some missing IMPLICIT tags, and use FN_PARS directive. +Fix a warning. ------------------------------------------------------------------------ -r14876 | tuexen | 2005-07-08 06:47:59 -0500 (Fri, 08 Jul 2005) | 2 lines +r15800 | etxrab | 2005-09-14 14:06:54 -0500 (Wed, 14 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/sctp_graph_dlg.c - -Fix a crash reported by Jeff Morris. + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-lldp.c +From Brian Bogora: +Our company (Mitel) has developed an LLDP-MED plug-in for Ethereal. ------------------------------------------------------------------------ -r14875 | guy | 2005-07-08 04:12:11 -0500 (Fri, 08 Jul 2005) | 3 lines +r15799 | etxrab | 2005-09-14 13:40:16 -0500 (Wed, 14 Sep 2005) | 16 lines Changed paths: - M /trunk/gtk/summary_dlg.c - M /trunk/summary.h + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fc.h + M /trunk/epan/dissectors/packet-fcct.c + M /trunk/epan/dissectors/packet-fcct.h + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-fcswils.h + M /trunk/epan/dissectors/packet-mdshdr.c + M /trunk/epan/dissectors/packet-scsi.c -Make the counters in the summary 64-bit, so they don't overflow on -Really Big Captures. +From Dinesh G Dutt + +Support some new messages and fix a couple of bugs. + +packet-fc.h - Added a #define for a Cisco MDS-specific frame called OHMS (online health mgmt srv) packet-fc.c - Support for OHMS frame, fixed an incorrect "malformed frame" error caused on ACK1 frames (they + don't contain anything but (encap hdr + FC hdr + encap trailer), fixed incorrect detection of + last-data-frame + +packet-fcct.h - Support for new service type, "Fabric Controller", used in conjunction with FC-SW3 ESS message, + exported the service name value string definitions and +packet-fcct.c - Support for recognizing "Fabric Controller" service type and "vendor-specific" service + +packet-fcswils.h - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-fcswils.c - Support for ESS & MRRA messages, defined as part of FC-SW3 + +packet-scsi.c - Support for Verify and Write&Verify SBC commands. ------------------------------------------------------------------------ -r14874 | guy | 2005-07-07 21:31:45 -0500 (Thu, 07 Jul 2005) | 23 lines +r15798 | etxrab | 2005-09-14 12:08:41 -0500 (Wed, 14 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-actrace.c + M /trunk/epan/dissectors/packet-snmp.c + +Do the variable binding with dissect_ber_x() routines rather than asn1 ones. +------------------------------------------------------------------------ +r15797 | etxrab | 2005-09-14 12:04:36 -0500 (Wed, 14 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-ber.c -Get rid of most unused arguments and variables (including some that are -set but not used). (Leave "pi" around so the warning acts as a reminder -that the tap structure stuff needs a cleanup - currently, the tap -structures aren't freed; perhaps the new memory allocation scheme -proposed by Ronnie could be used for tap structures.) +Dont't carsh if dissect_ber_null() isn't passed a hf_id. +------------------------------------------------------------------------ +r15796 | sahlberg | 2005-09-14 11:06:11 -0500 (Wed, 14 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc.c -Have "ac_istrace()" return NOT_ACTRACE for apparently non-actrace -packets and return the packet type for actrace packets, so that we don't -need a global variable for the packet type. +Allow dissection of dcerpc of short frames instead of aborting as soon as it is detected the pdu is "short" -Make "actrace_udp_port" unsigned to squelch a signed vs. unsigned -warning. -Use "col_set_str()" rather than "col_add_str()" when setting the -Protocol column. +------------------------------------------------------------------------ +r15795 | sahlberg | 2005-09-14 11:04:59 -0500 (Wed, 14 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ber.c -We don't recognized packets as CAS packets unless they're 48 bytes long, -so we don't need to test whether they're 48 bytes long in the CAS packet -dissection code. +for octet strings that span beyond the end of a "short" tvb, create a new subset tvb of what we have and use that instead of bailing out completely. -Use the reported length, not the captured length, when doing length -checks. ------------------------------------------------------------------------ -r14873 | guy | 2005-07-07 21:21:16 -0500 (Thu, 07 Jul 2005) | 3 lines +r15794 | sahlberg | 2005-09-14 11:02:54 -0500 (Wed, 14 Sep 2005) | 4 lines Changed paths: - M /trunk/wiretap/nettl.c + M /trunk/epan/dissectors/packet-spnego.c + +when we have raw keberos inside the spnego blob, pass it as is over to +the kerberos dissector and do not strip the ber tag and lengths off -Make nettl file header items containing strings "gchar", to squelch -signed vs. unsigned compiler warnings. ------------------------------------------------------------------------ -r14872 | sahlberg | 2005-07-07 17:24:28 -0500 (Thu, 07 Jul 2005) | 7 lines +r15793 | guy | 2005-09-14 03:59:41 -0500 (Wed, 14 Sep 2005) | 4 lines Changed paths: + M /trunk/file.c + M /trunk/file.h + M /trunk/gtk/afp_stat.c + M /trunk/gtk/bootp_stat.c M /trunk/gtk/conversations_table.c - M /trunk/gtk/conversations_table.h + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/expert_dlg.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c M /trunk/gtk/hostlist_table.c - M /trunk/gtk/hostlist_table.h + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/stats_tree_stat.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c -make the packets/bytes counters 64bit integers to not wrap when using really large captures. +Have cf_retap_packets() take an argument that indicates whether to +generate columns; use cf_retap_packets instead of cf_redissect_packets() +when running taps (the general flow graph stat uses the Info column). +------------------------------------------------------------------------ +r15792 | ulfl | 2005-09-13 21:07:20 -0500 (Tue, 13 Sep 2005) | 3 lines +Changed paths: + M /trunk/docbook/eug_src/EUG_chapter_build_install.xml + M /trunk/packaging/nsis/ethereal.nsi + +fix #388: add /desktopicon and /quicklaunchicon command line options to the NSIS installer + +update the User's Guide accordingly +------------------------------------------------------------------------ +r15791 | ulfl | 2005-09-13 18:46:42 -0500 (Tue, 13 Sep 2005) | 7 lines +Changed paths: + M /trunk/gtk/expert_dlg.c -setting packet counter to 64bit is overkill but makes it consistent with the very similar bytes counter. +Move "Expert Info" from "Statistics" to "Analyze" menu item. +*significantly* improve performance (100000 infos from ~5min to 25sec!) +Add a simple severity based filter mechanism. +replace // style comments by /**/ ------------------------------------------------------------------------ -r14871 | gerald | 2005-07-07 16:26:09 -0500 (Thu, 07 Jul 2005) | 6 lines +r15790 | ulfl | 2005-09-13 14:01:08 -0500 (Tue, 13 Sep 2005) | 5 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/epan/dissectors/make-reg-dotc.py - M /trunk/tools/cvsdiff-fix.py - M /trunk/tools/win32-setup.sh + M /trunk/config.nmake -Make sure "which" is present before we verify our tools. Add "env" to -the list of programs to check. Make sure our python scripts start with -"#!/usr/bin/env python" as recommended at +Turn around the sequence of PATH, so the former PATH will be in front of the newly added things. - http://www.python.org/doc/faq/library.html#how-do-i-make-a-python-script-executable-on-unix +This way, the cygwin link.exe command will be behind the link.exe from MSVC. +Also added a definition of the docbook dir, floating around in my personal file for a while. This will be needed if the User's Guide is included in the NSIS installer later. ------------------------------------------------------------------------ -r14870 | etxrab | 2005-07-07 14:48:06 -0500 (Thu, 07 Jul 2005) | 1 line +r15789 | gerald | 2005-09-13 14:01:01 -0500 (Tue, 13 Sep 2005) | 6 lines Changed paths: - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/docbook/release-notes.xml + M /trunk/epan/dissectors/packet-smb.c + +In smb_trans_defragment(), throw an exception if we encounter a too-large +fragment size. The limit is conservatively set at 65536 bytes. It may +have to be increased. Fixes bug 421. + +Add an entry to the release notes. -Add parlay.dll and tango.dll to the installer. ------------------------------------------------------------------------ -r14869 | kukosa | 2005-07-07 00:45:51 -0500 (Thu, 07 Jul 2005) | 1 line +r15788 | ulfl | 2005-09-13 13:45:52 -0500 (Tue, 13 Sep 2005) | 1 line Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h450/h450.cnf + M /trunk/gtk/menu.c + M /trunk/stat_menu.h -avoid few warnings from asn2eth compiler +implement a way to add menu items to the "Analyze" menu ------------------------------------------------------------------------ -r14868 | guy | 2005-07-06 23:05:01 -0500 (Wed, 06 Jul 2005) | 3 lines +r15787 | ulfl | 2005-09-13 13:42:12 -0500 (Tue, 13 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/decode_as_dcerpc.c -Squelch a compiler pointer vs. integer warning - NULL is for pointers, -'\0' is for characters. +don't crash with a NULL pointer exception, if "do not decode as" is used +------------------------------------------------------------------------ +r15786 | ulfl | 2005-09-13 13:40:58 -0500 (Tue, 13 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-frame.c +add to the protocol item a short description what a "Short Frame" is ------------------------------------------------------------------------ -r14867 | guy | 2005-07-06 23:03:35 -0500 (Wed, 06 Jul 2005) | 4 lines +r15785 | ulfl | 2005-09-13 13:39:26 -0500 (Tue, 13 Sep 2005) | 1 line Changed paths: - M /trunk/epan/address.h - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-dcom-remunkn.c -Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness" -warnings. Use SET_ADDRESS in the VOIP calls code, rather than -explicitly filling in "pstn_add". +increment index of IID's in COL_INFO +------------------------------------------------------------------------ +r15784 | ulfl | 2005-09-13 13:38:19 -0500 (Tue, 13 Sep 2005) | 1 line +Changed paths: + M /trunk/gtk/flow_graph.c +use the same name for menu item and dialog box title, use the right capitalization for both ------------------------------------------------------------------------ -r14866 | guy | 2005-07-06 22:20:43 -0500 (Wed, 06 Jul 2005) | 3 lines +r15783 | etxrab | 2005-09-13 11:56:28 -0500 (Tue, 13 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-diameter.c -Explicitly initialize all the elements of a voip_calls_tapinfo_t, to -squelch a compiler warning. +Get application ID from the packet. +------------------------------------------------------------------------ +r15782 | etxrab | 2005-09-13 11:48:13 -0500 (Tue, 13 Sep 2005) | 5 lines +Changed paths: + M /trunk/config.nmake +From Peter Johansson +PATH contents one had before starting the build, that PATH is added to the new PATH variable 5 additional times +instead of 1. +I have made changes (supplied) to config.nmake that takes care of this +problem. ------------------------------------------------------------------------ -r14865 | guy | 2005-07-06 18:55:19 -0500 (Wed, 06 Jul 2005) | 2 lines +r15781 | ulfl | 2005-09-13 03:03:16 -0500 (Tue, 13 Sep 2005) | 1 line Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/epan/dissectors/packet-frame.c -Fix a spelling error. +don't simply remove the expert_info output at BoundsError, but add the comment from Guy why this (usually) isn't a bug (because of a short snapshot length). +------------------------------------------------------------------------ +r15780 | etxrab | 2005-09-13 00:05:19 -0500 (Tue, 13 Sep 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-ieee80211.c +From Ankur Aggarwal: +First phase of testing revealed the following errors ------------------------------------------------------------------------ -r14864 | kukosa | 2005-07-06 11:19:34 -0500 (Wed, 06 Jul 2005) | 1 line +r15779 | etxrab | 2005-09-13 00:00:17 -0500 (Tue, 13 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h245/h245.cnf + M /trunk/epan/dissectors/packet-winsrepl.c + +From Stefan Metzmacher +Some updates to the winsrepl-dssector to add COL_INFO strings... -more usage of #.FN_PARS directive and usage of DEFAULT_BODY parameter ------------------------------------------------------------------------ -r14863 | kukosa | 2005-07-06 11:15:12 -0500 (Wed, 06 Jul 2005) | 2 lines +r15778 | etxrab | 2005-09-12 23:53:36 -0500 (Mon, 12 Sep 2005) | 2 lines Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/gtk/graph_analysis.c + M /trunk/gtk/graph_analysis.h + +From Alejandro Vaquero. -- #.FN_PARS implemented for BOOLEAN -- user defined body #.FN_BODY can be combined with default body using DEFAULT_BODY parameter (see e.g. H.225) ------------------------------------------------------------------------ -r14862 | jmayer | 2005-07-05 17:58:00 -0500 (Tue, 05 Jul 2005) | 1 line +r15777 | etxrab | 2005-09-12 23:51:49 -0500 (Mon, 12 Sep 2005) | 2 lines Changed paths: - M /trunk/wiretap/AUTHORS + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-cimd.c + A /trunk/epan/dissectors/packet-cimd.h -Replace Chris Lydick by Robert Long as Author of the Sniffer 2.003 support patch +From Piros Lucian: +A new dissector - cimd dissector. CIMD stands for Computer Interface to Message Distribution and it's used to transfer short messages between applications and Nokia Short Message Service Center. ------------------------------------------------------------------------ -r14861 | ulfl | 2005-07-05 17:33:22 -0500 (Tue, 05 Jul 2005) | 1 line +r15776 | guy | 2005-09-12 23:00:47 -0500 (Mon, 12 Sep 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-isns.c + M /trunk/epan/Makefile.common + M /trunk/epan/column-utils.h + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/expert.h + A /trunk/epan/gnuc_format_check.h + M /trunk/epan/proto.h + +Move the definition of GNUC_FORMAT_CHECK() to its own header, use it in +column-utils.h, and add it to expert.h, so we check the arguments to +"expert_add_info_format()", at least if the format argument is a +constant string. + +Fix some more calls to "expert_add_info_format()" to pass it a format +string. + +Don't record BoundsError exceptions as expert events - they merely +reflect a capture done with a snapshot length too short to capture all +of the packet (any case where it's caused by something else is a bug). -fix *several* dissector bugs, found by private fuzz-tests ------------------------------------------------------------------------ -r14860 | kukosa | 2005-07-05 16:42:13 -0500 (Tue, 05 Jul 2005) | 1 line +r15775 | guy | 2005-09-12 21:39:37 -0500 (Mon, 12 Sep 2005) | 5 lines Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/epan/dissectors/packet-http.c + +Don't pass an arbitrary string from a packet to a routine expecting a +format string - the arbitrary string might contain "%" characters, so +the routine might then fetch arbitrary junk and try to use it as, for +example, a string pointer. -new directives #.PDU_NEW and #.REGISTER_NEW creating and registering PDU dissectors with new_dissector_t prototype ------------------------------------------------------------------------ -r14859 | gerald | 2005-07-05 15:20:15 -0500 (Tue, 05 Jul 2005) | 3 lines +r15774 | guy | 2005-09-12 19:50:43 -0500 (Mon, 12 Sep 2005) | 8 lines Changed paths: - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-bgp.h + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-radius.c + +Convert some more "tvb_memcpy()"s fetching IPv4 and IPv6 addresses to +calls to "tvb_get_ipv4()" and "tvb_get_ipv6()". + +Fix a call in the BGP dissector to properly fetch an IEEE floating-point +number. -Call proto_tree_add_guid_hidden() for an FT_GUID value. Fixes bugs 274, -276, and 277. +Update some I-D info. ------------------------------------------------------------------------ -r14858 | gerald | 2005-07-05 15:04:03 -0500 (Tue, 05 Jul 2005) | 3 lines +r15773 | guy | 2005-09-12 16:01:25 -0500 (Mon, 12 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/reassemble.c + M /trunk/epan -Don't crash if we're handed a zero-length fragment. Fixes bug 272. Although -we don't crash now, we still don't handle zero-length fragments correctly. +Ignore files generated from dtd_grammar.lemon, dtd_parse.l, and +dtd_preparse.l. ------------------------------------------------------------------------ -r14857 | kukosa | 2005-07-05 14:53:38 -0500 (Tue, 05 Jul 2005) | 1 line +r15772 | ulfl | 2005-09-12 15:10:44 -0500 (Mon, 12 Sep 2005) | 7 lines Changed paths: - M /trunk/asn1/h225/h225.cnf + M /trunk/gtk/packet_list.c + +When jumping (e.g. using menu item Go/Go to Packet...) to a new packet which is currently not displayed, this newly selected packet will become the first in the packet list. + +This is inconvenient, as most of the time (at least) I'm interested not only in the packets behind the newly selected one, but also to have some history *before* it. + +So this change will scroll the packet list to have the selected packet after the first third of the packet list. -more usage of #.FN_PARS +This change won't take effect if the new packet is already visible (only the selection is changed) or it's near the beginning or end of the packet list (so the whole beginning/end of the list is shown). ------------------------------------------------------------------------ -r14856 | kukosa | 2005-07-05 14:47:04 -0500 (Tue, 05 Jul 2005) | 2 lines +r15771 | ulfl | 2005-09-12 15:02:58 -0500 (Mon, 12 Sep 2005) | 1 line Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/epan/dissectors/packet-dcerpc.c -- #.FN_PARS support for ENUMERATED type -- cleanup unused parameters for some methods +add number of defragmented bytes to the expert info output ------------------------------------------------------------------------ -r14855 | kukosa | 2005-07-05 13:55:17 -0500 (Tue, 05 Jul 2005) | 1 line +r15770 | guy | 2005-09-12 14:50:45 -0500 (Mon, 12 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/to_str.c + M /trunk/epan/Makefile.am + M /trunk/epan/Makefile.nmake + +Get rid of "dtd_grammar.out" on a "make distclean". + +Get rid of all the Flex-generated (and Lemon-generated) files on a +"nmake -f Makefile.nmake distclean". -GUID lowercase form seems to be preferred ------------------------------------------------------------------------ -r14854 | etxrab | 2005-07-05 12:10:09 -0500 (Tue, 05 Jul 2005) | 1 line +r15769 | guy | 2005-09-12 14:32:35 -0500 (Mon, 12 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-text-media.c + M /trunk/epan/Makefile.common + M /trunk/epan/dtd_grammar.lemon + A /trunk/epan/dtd_parse.h + M /trunk/epan/dtd_parse.l + +Add a header file to declare routines defined in lexer and used in +parser, or vice versa. -Add application/vnd.wv.csp.xml ------------------------------------------------------------------------ -r14853 | etxrab | 2005-07-05 12:09:28 -0500 (Tue, 05 Jul 2005) | 1 line +r15768 | guy | 2005-09-12 10:54:20 -0500 (Mon, 12 Sep 2005) | 2 lines Changed paths: - M /trunk/plugins/xml/packet-xml.c + M /trunk/epan/dtd_grammar.lemon + +Again, "g_strdown()" doesn't return a value in GLib 1.2[.x]. -Add application/vnd.wv.csp.xml ------------------------------------------------------------------------ -r14852 | etxrab | 2005-07-05 00:16:28 -0500 (Tue, 05 Jul 2005) | 10 lines +r15767 | guy | 2005-09-12 02:55:14 -0500 (Mon, 12 Sep 2005) | 3 lines Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/graph_analysis.h - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dissectors/packet-xml.c -From Alejandro Vaquero +"g_strdown()" doesn't return a value in GLib 1.2[.x]; don't depend on it +doing so. -- avoid the clist of the calls dlg to be refreshed multiple times when -first appear. -- destroy the Graph window when the data is not valid anymore. -- fixes an H245 packet count error -- resizing the Graph windows when is displayed (up to 5 columns). -With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct = - {0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0}; -alone. ------------------------------------------------------------------------ -r14851 | etxrab | 2005-07-04 23:32:32 -0500 (Mon, 04 Jul 2005) | 4 lines +r15766 | guy | 2005-09-12 02:44:11 -0500 (Mon, 12 Sep 2005) | 18 lines Changed paths: - M /trunk/epan/dissectors/packet-lwapp.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/osi-utils.c + +The previous checkin for packet-isup.c was accidentally checked in along +with some unrelated changes; it got rid of some calls to get IPv4/IPv6 +addresses and add them to the protocol tree, replacing them with +proto_tree_add_item() calls, and fixed up the length of one protocol +tree item. + +Note that we have (at least) three count 'em three different routines +for dissecting/displaying NSAPs (there might be more - I might have +missed some), and suggest that we might want to reduce that to one. + +Update the URL for ICP values for IPv{4,6} addresses inside NSAPs. -From : David Frascone +Fix the offset in the call to add the IPv6 address part of an NSAP +containing such an address, and the length in the call adding the DSP +for an NSAP containing an IPv4 address. -These minor changes fix some errors, and add some messages to the LWAPP dissector. +Fix up indentation a bit. ------------------------------------------------------------------------ -r14850 | etxrab | 2005-07-04 23:30:59 -0500 (Mon, 04 Jul 2005) | 4 lines +r15765 | tuexen | 2005-09-12 01:24:02 -0500 (Mon, 12 Sep 2005) | 8 lines Changed paths: - M /trunk/gtk/rtp_analysis.c + M /trunk/epan/dissectors/packet-sctp.c -From Ainsley Pereira: +In now supports also: + - http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctpimpguide-15.txt + - http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-addip-sctp-13.txt + - http://www.ietf.org/internet-drafts/draft-stewart-sctp-pktdrprep-02.txt + - http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctp-auth-01.txt + - http://www.ietf.org/internet-drafts/draft-ladha-sctp-nonce-02.txt -If you have an RTP stream in which the first packet is duplicated, and has the marker bit set, then the RTP stream analysis will try to pad silence into a temporary file from 0 upto whatever the RTP timestamp is (which is enough to fill up my disk...). The patch fixes this misbehaviour. ------------------------------------------------------------------------ -r14849 | etxrab | 2005-07-04 14:09:38 -0500 (Mon, 04 Jul 2005) | 1 line +r15764 | guy | 2005-09-12 01:21:35 -0500 (Mon, 12 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/addr_and_mask.c + M /trunk/epan/addr_resolv.c + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-isis-lsp.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/ipv6-utils.h + +Don't collide with the "regular" IPv6 defintions in at least some +platforms in ipv6-utils.h. -Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again. ------------------------------------------------------------------------ -r14848 | etxrab | 2005-07-04 14:07:02 -0500 (Mon, 04 Jul 2005) | 1 line +r15763 | ulfl | 2005-09-11 19:29:19 -0500 (Sun, 11 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_a.h - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-dcerpc.c -Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again. +fix fault defragmentation the same way as in the request/response path + +Unfortunately, I don't have a capture file to test this... ------------------------------------------------------------------------ -r14847 | kukosa | 2005-07-04 08:19:58 -0500 (Mon, 04 Jul 2005) | 1 line +r15762 | ulfl | 2005-09-11 19:16:57 -0500 (Sun, 11 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/reassemble.c + M /trunk/epan/reassemble.h + +fix reassembling problem I've introduced yesterday, by using fragment_add_seq_next() function instead of fragment_add() -usage of FT_GUID field type in H.225 dissector +in addition, I had to implement fragment_get_reassembled() in addition to fragment_get(), which works with reassembled_table ------------------------------------------------------------------------ -r14846 | kukosa | 2005-07-04 08:13:07 -0500 (Mon, 04 Jul 2005) | 1 line +r15761 | guy | 2005-09-11 17:31:36 -0500 (Sun, 11 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/dissectors/packet-clnp.c + +Fix a typo. -export of proto_tree_add_guid...() functions ------------------------------------------------------------------------ -r14845 | kukosa | 2005-07-04 08:04:53 -0500 (Mon, 04 Jul 2005) | 1 line +r15760 | guy | 2005-09-11 17:25:33 -0500 (Sun, 11 Sep 2005) | 9 lines Changed paths: - M /trunk/epan/dfilter/semcheck.c - M /trunk/epan/ftypes/ftype-bytes.c - M /trunk/epan/ftypes/ftypes.h - M /trunk/epan/proto.c - M /trunk/epan/proto.h - M /trunk/epan/to_str.c - M /trunk/epan/to_str.h + M /trunk/epan/expert.c + M /trunk/epan/expert.h + M /trunk/epan/frame_data.h + M /trunk/file.c + M /trunk/gtk/expert_dlg.c + +Frame numbers are unsigned, and they start at 1; 0 is what's used for +"unknown" for frame numbers. Note that in epan/frame_data.h, and make +the frame number in experts unsigned, and use 0 for "unknown", and +display it as an unsigned number - and, if it's 0, don't display it at +all. + +Fix the signature of "expert_dlg_draw()" to match what a tap's draw +routine's signature is expected to be. -new field type FT_GUID ------------------------------------------------------------------------ -r14844 | kukosa | 2005-07-04 04:35:25 -0500 (Mon, 04 Jul 2005) | 7 lines +r15759 | guy | 2005-09-11 17:19:41 -0500 (Sun, 11 Sep 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-tcp.c + +Add some braces to squelch a compiler warning. + +Fix up indentation. + +------------------------------------------------------------------------ +r15758 | guy | 2005-09-11 16:25:37 -0500 (Sun, 11 Sep 2005) | 11 lines Changed paths: M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/asn1/h235/Makefile.nmake - M /trunk/asn1/h235/h235-exp.cnf M /trunk/asn1/h245/h245.cnf - M /trunk/asn1/h245/packet-h245-template.c - M /trunk/asn1/h450/packet-h450-template.c + M /trunk/epan/addr_and_mask.c + M /trunk/epan/dissectors/packet-aodv.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-auto_rp.c + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-chdlc.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gtp.c M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - M /trunk/epan/dissectors/packet-h235.c - M /trunk/epan/dissectors/packet-h235.h M /trunk/epan/dissectors/packet-h245.c M /trunk/epan/dissectors/packet-h245.h - M /trunk/epan/dissectors/packet-h450.c - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-per.h - M /trunk/epan/dissectors/packet-t38.c - M /trunk/tools/asn2eth.py + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-igmp.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-isis-lsp.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-ldp.c + M /trunk/epan/dissectors/packet-manolito.c + M /trunk/epan/dissectors/packet-msdp.c + M /trunk/epan/dissectors/packet-msnip.c + M /trunk/epan/dissectors/packet-msproxy.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-netflow.c + M /trunk/epan/dissectors/packet-nsip.c + M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-olsr.c + M /trunk/epan/dissectors/packet-quake3.c + M /trunk/epan/dissectors/packet-skinny.c + M /trunk/epan/dissectors/packet-socks.c + M /trunk/epan/dissectors/packet-teredo.c + M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-wccp.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/packet.c + M /trunk/epan/proto.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h + M /trunk/plugins/opsi/packet-opsi.c + M /trunk/plugins/profinet/packet-pn-dcp.c + +Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32, +and that extract IPv6 addresses into a "struct e_in6_addr", with +tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we +remove, by using proto_tree_add_item(), rather than replacing. + +Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct +e_in6_addr" (not necessary to declare the tvbuff routines, but including +it there means "struct e_in6_addr" is guaranteed to be defined before +those declarations, so we don't get compiler complaints if we define it +*after* those declarations). -- use tvb instead of offset and length in dissect_per_octet_string() for value returning -- asn2eth: #.FN_PARS support for OCTET STRING -- usage of #.FN_PARS in h225 and h245 -- h225: ParallelH245Control support -- h245: better support of NonStandardParameter -- usage of MAX_OID_STR_LEN constant -- all PER dissectors regenerated ------------------------------------------------------------------------ -r14843 | ulfl | 2005-07-04 02:03:04 -0500 (Mon, 04 Jul 2005) | 1 line +r15757 | ulfl | 2005-09-11 16:10:26 -0500 (Sun, 11 Sep 2005) | 2 lines Changed paths: - M /trunk/docbook/custom_layer_pdf.xsl + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/reassemble.c + M /trunk/epan/reassemble.h -add a link to special documentation +rename fragment_add_dcerpc -> fragment_add_dcerpc_dg to avoid confusion a bit, +as connection oriented (cn) and connectionless (dg) DCE/RPC uses different ways to handle defragmentation and this function is only used for dg ------------------------------------------------------------------------ -r14842 | guy | 2005-07-03 22:45:29 -0500 (Sun, 03 Jul 2005) | 2 lines +r15756 | etxrab | 2005-09-11 16:10:20 -0500 (Sun, 11 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-giop.c - -Mark stub data as such if no dissector claims it. + M /trunk/epan/dissectors/packet-spnego.c +Get rid of dependency on format-oid.h ------------------------------------------------------------------------ -r14841 | ulfl | 2005-07-03 17:53:11 -0500 (Sun, 03 Jul 2005) | 1 line +r15755 | ulfl | 2005-09-11 12:15:00 -0500 (Sun, 11 Sep 2005) | 1 line Changed paths: - M /trunk/docbook/custom_layer_pdf.xsl + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/libethereal.def + M /trunk/gtk/expert_dlg.c -from Jaap Keuter: some improvements to the custom PDF creation stylesheet +some things fixed, leftover from code cleanup (thanks to the buggy MSVC dependencies) ------------------------------------------------------------------------ -r14840 | etxrab | 2005-07-03 16:20:27 -0500 (Sun, 03 Jul 2005) | 1 line +r15754 | ulfl | 2005-09-11 11:55:34 -0500 (Sun, 11 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_a.h - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/Makefile.common + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/epan.c + A /trunk/epan/expert.c + A /trunk/epan/expert.h + M /trunk/epan/libethereal.def + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/gtk/Makefile.common + A /trunk/gtk/expert_dlg.c + M /trunk/gtk/proto_draw.c + M /trunk/gtk/proto_draw.h + +I'm adding the "Expert Info" prototype now, as it seems to be in a state where others might have a look and probably already find it useful :-). Anyway, we can easily disable it at one or two places in the code if it get's in our way of a new release. -Add an exported value string +Please see: http://wiki.ethereal.com/Development/ExpertInfo for a complete overview of the intended feature and it's current state of implementation. + +While I'm working on this, I've also added some more status result codes to the DCE/RPC and DCOM dissectors. ------------------------------------------------------------------------ -r14839 | etxrab | 2005-07-03 16:19:49 -0500 (Sun, 03 Jul 2005) | 1 line +r15753 | guy | 2005-09-10 14:43:41 -0500 (Sat, 10 Sep 2005) | 5 lines Changed paths: + M /trunk/doc/README.developer + M /trunk/epan/dissectors/packet-winsrepl.c M /trunk/epan/libethereal.def + M /trunk/epan/proto.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h + +Add "tvb_get_ipv4()" and "tvb_get_ipv6()" addresses, to fetch IPv4 and +IPv6 addresses. Use "tvb_get_ipv4()" in the WINS Replication dissector, +so that it gets the right answer on little-endian *AND* big-endian +machines. -Add an exported value string ------------------------------------------------------------------------ -r14838 | etxrab | 2005-07-03 15:33:06 -0500 (Sun, 03 Jul 2005) | 2 lines +r15752 | guy | 2005-09-10 14:39:56 -0500 (Sat, 10 Sep 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-sip.c + +In "dissect_sip()", return 0 if "dissect_sip_common()" returns a +negative value, so we reject the packet as "not SIP". + +Add a "dissect_sip_tcp_heur()" that's heuristic - it'll return FALSE if +the first packet doesn't look like SIP, but once it's dissected one +packet it'll just treat subsequent SIP packets as continuations if they +don't look right. + +Clean up indentation a bit. -Change gsm_a.c to use value strings in some places in preparation to use it from packet-uma.c and gsm_map. -Some bug fixes to packet-uma.c ------------------------------------------------------------------------ -r14837 | etxrab | 2005-07-03 07:01:11 -0500 (Sun, 03 Jul 2005) | 1 line +r15751 | lego | 2005-09-10 13:59:02 -0500 (Sat, 10 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dtd_preparse.l + +propperly handle the errors when loading a file fails. + -Add packet-mms.h ------------------------------------------------------------------------ -r14836 | sahlberg | 2005-07-03 01:08:53 -0500 (Sun, 03 Jul 2005) | 4 lines +r15750 | lego | 2005-09-10 13:46:03 -0500 (Sat, 10 Sep 2005) | 3 lines Changed paths: - A /trunk/asn1/mms - A /trunk/asn1/mms/Makefile - A /trunk/asn1/mms/Makefile.nmake - A /trunk/asn1/mms/mms-exp.cnf - A /trunk/asn1/mms/mms.asn - A /trunk/asn1/mms/mms.cnf - A /trunk/asn1/mms/packet-mms-template.c - A /trunk/asn1/mms/packet-mms-template.h - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-mms.c - A /trunk/epan/dissectors/packet-mms.h + M /trunk/epan/dtd_preparse.l -New protocol : -MMS Manufacturing Message Specification +don't use fgets() as MSVC does not implement it. use fgetc instead. ------------------------------------------------------------------------ -r14835 | sahlberg | 2005-07-03 00:28:12 -0500 (Sun, 03 Jul 2005) | 3 lines +r15749 | ulfl | 2005-09-10 13:33:32 -0500 (Sat, 10 Sep 2005) | 5 lines Changed paths: - M /trunk/asn1/acse/acse-exp.cnf - M /trunk/asn1/acse/acse.cnf - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-acse.h + M /trunk/epan/Makefile.nmake -export a few more symbols from acse +fix MSVC slash/backslash and other such problems, now getting: +dtd_preparse.obj : error LNK2001: Nichtaufgeloestes externes Symbol _fgetln +MSVC doesn't support fgetln! ------------------------------------------------------------------------ -r14834 | guy | 2005-07-02 19:52:08 -0500 (Sat, 02 Jul 2005) | 5 lines +r15748 | lego | 2005-09-10 13:00:28 -0500 (Sat, 10 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/Makefile.nmake -Note that the MPLS extension dissector will misdissect ICMP packets that -contain more than 128 bytes of the original datagram. (Yes, RFC 1812 -and the ICMP Extensions for MPLS draft collide here, as the draft in -question notes.) +Make sure lemon is built before trying to use it ------------------------------------------------------------------------ -r14833 | tuexen | 2005-07-02 16:16:17 -0500 (Sat, 02 Jul 2005) | 2 lines +r15747 | lego | 2005-09-10 12:55:16 -0500 (Sat, 10 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/Makefile.am + +fix the dtd_grammar.c rule -Use brackets instead of parentheses for the checksum info, which is generated. ------------------------------------------------------------------------ -r14832 | jmayer | 2005-07-02 10:40:49 -0500 (Sat, 02 Jul 2005) | 5 lines +r15746 | lego | 2005-09-10 12:47:02 -0500 (Sat, 10 Sep 2005) | 3 lines Changed paths: - M /trunk/wiretap/AUTHORS - M /trunk/wiretap/netxray.c + M /trunk/epan/Makefile.nmake + +nmake does not have the $^ macro -Chris Lydick: Support for Sniffer 2.003 files. -Modified to match the current codebase. +------------------------------------------------------------------------ +r15745 | lego | 2005-09-10 12:29:15 -0500 (Sat, 10 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/Makefile.am + M /trunk/epan/Makefile.common + M /trunk/epan/Makefile.nmake + M /trunk/epan/dissectors/packet-xml.c + A /trunk/epan/dtd.h + A /trunk/epan/dtd_grammar.lemon + A /trunk/epan/dtd_parse.l + A /trunk/epan/dtd_preparse.l + +the dtd parser (still missing the glue) and few fixes to packet-xml.c ------------------------------------------------------------------------ -r14831 | guy | 2005-07-02 03:18:17 -0500 (Sat, 02 Jul 2005) | 17 lines +r15744 | ulfl | 2005-09-10 10:11:21 -0500 (Sat, 10 Sep 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/reassemble.c -Have separate fields for NFSv2, NFSv3, and NFSv4 return statuses, using -the names in the v2, v3, and v4 specs for values, so that they display -correctly and can be filtered on correctly. +fix DCE/RPC defragmentation, if both middle and last DCE/RPC fragments are in the same TCP desegmented data blob -Have "nfs.status" as a hidden field, with a name table giving just "OK" -and "ERR_" values, and having items for v2, v3, and v4 status values -(the only collision is that the v3 JUKEBOX error is the v4 DELAY error), -so that filters on "nfs.status" will still work, but will now be able to -filter symbolically on values from v2, v3, and v4. +reassemble.c: +I had to change the way the reassemble code works if the dissector is telling that more fragments *will* follow. In this case the reassemble code shouldn't try to reassemble already at that time ... -Show 33 status values in the Info column and the summary entry using the -table of v3 status values and names, not the table of v2 status values -and names. +I've also changed the way if a fragment was already seen or not, as it's not enough to check for the frame number, in the scenario described above. -Fix some v3 dissectors to use the v3 return status field rather than the -v2 return status field. +Unfortunately both changes *might* broke other protocols from reassemble properly. I've checked with excessive TCP desegmentation and it's still working without any changes :-) + +packet-dcerpc.c: +use a tvb subset to limit the "end of bytes" processed in a single fragment dissect run, as each fragment has it's own DCE/RPC header (and isn't part of the stub data of the previous packet). ------------------------------------------------------------------------ -r14830 | ulfl | 2005-07-01 16:04:13 -0500 (Fri, 01 Jul 2005) | 1 line +r15743 | ulfl | 2005-09-09 16:04:19 -0500 (Fri, 09 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-isns.c - M /trunk/epan/dissectors/packet-smpp.c + M /trunk/packaging/nsis/ethereal.nsi -fixed various issues (two serious ones) found by "private" fuzz-testing +NSIS warning removed: the label "lbl_winpcap_dont_install" is currently unused ------------------------------------------------------------------------ -r14829 | ulfl | 2005-07-01 15:47:22 -0500 (Fri, 01 Jul 2005) | 5 lines +r15742 | etxrab | 2005-09-09 14:46:57 -0500 (Fri, 09 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/find_dlg.c - -fix #271: don't do: - -g_free(bytes); + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/asn1/pres/pres.cnf + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-pres.c -twice, probably a copy/paste error +Dissect "nbs-9". ------------------------------------------------------------------------ -r14828 | kukosa | 2005-07-01 08:48:52 -0500 (Fri, 01 Jul 2005) | 1 line +r15741 | etxrab | 2005-09-09 11:19:51 -0500 (Fri, 09 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-diameter-defs.h -beter displaying of true/false strings in dissect_ber_bitstring() +Add some 3GPP AVP:s ------------------------------------------------------------------------ -r14827 | ulfl | 2005-06-30 17:51:17 -0500 (Thu, 30 Jun 2005) | 1 line +r15740 | kukosa | 2005-09-09 10:36:39 -0500 (Fri, 09 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-per.c -add some more information to the DCE/RPC packet details summary line +- dissect_per_choice() creates now only one level tree insted of two levels tree +- dissect_per_choice() rewritten ------------------------------------------------------------------------ -r14826 | ulfl | 2005-06-30 17:46:19 -0500 (Thu, 30 Jun 2005) | 3 lines +r15739 | guy | 2005-09-09 03:40:58 -0500 (Fri, 09 Sep 2005) | 12 lines Changed paths: - M /trunk/epan/column-utils.c - M /trunk/epan/column.c - M /trunk/epan/column_info.h - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/gtk/packet_list.c + M /trunk/wiretap/netxray.c + M /trunk/wiretap/wtap-int.h + +From Bill Meier: + + define "timezone" as "gint16", as it can be positive (west of + UTC) or negative (east of UTC); -add a new DCE/RPC related column, which contains the call_id for connection oriented packets or the sequence number for connectionless (datagram) packets. + update comments to refer to the new names for structure members; + + say the precision of the time stamps is 1 nanosecond only if the + ticks per second is > 10 million; + + fix the handling of files truncated exactly on a frame boundary. -This is extremely useful, to keep track of the corresponding request/response packets of a DCE/RPC call (which can be quite a lot packets if fragmentation is used). ------------------------------------------------------------------------ -r14825 | etxrab | 2005-06-30 14:19:50 -0500 (Thu, 30 Jun 2005) | 1 line +r15738 | guy | 2005-09-09 03:29:10 -0500 (Fri, 09 Sep 2005) | 2 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-afp.c + +From Didier Gautheron: pass error replies to the tap. -Add Karl Knoebl as an author. ------------------------------------------------------------------------ -r14824 | etxrab | 2005-06-30 14:17:46 -0500 (Thu, 30 Jun 2005) | 3 lines +r15737 | guy | 2005-09-09 03:20:16 -0500 (Fri, 09 Sep 2005) | 3 lines Changed paths: - M /trunk/plugins/megaco/packet-megaco.c + M /trunk/gtk/conversations_rsvp.c + M /trunk/gtk/hostlist_rsvp.c + +Update new RSVP host list and conversation stats to match recent changes +to the way command-line arguments and menu items for stats are done. -From Karl Knoebl -Accept SP as separator and * provide info to COL_INFO and some "prettification" - Cleaned up some comments as well. ------------------------------------------------------------------------ -r14823 | sahlberg | 2005-06-30 02:48:25 -0500 (Thu, 30 Jun 2005) | 7 lines +r15736 | guy | 2005-09-09 03:11:47 -0500 (Fri, 09 Sep 2005) | 4 lines Changed paths: - M /trunk/asn1/cmip/cmip.cnf - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmip.h + M /trunk/gtk/dlg_utils.c + +Don't handle the ETHEREAL_STOCK_CAPTURE_START button if we don't have +libpcap - ETHEREAL_STOCK_CAPTURE_START isn't defined, and we can't +capture in any case, so we don't need that button. -fix a bug in the conformance file for CMIP to make it compile again -(semi-recent changes to asn2eth and PARAM handling makes us have to use double %% in some BODY statements) +------------------------------------------------------------------------ +r15735 | ulfl | 2005-09-08 19:22:37 -0500 (Thu, 08 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/sigcomp_state_hdlr.c -at the same time, regenerate it so it also benefit from bugfixes to handling of indefinite length +fix MSVC warning: sigcomp_state_hdlr.c(601) : warning C4101: 'partial_state_str' : unreferenced local variable +------------------------------------------------------------------------ +r15734 | lego | 2005-09-08 17:55:39 -0500 (Thu, 08 Sep 2005) | 3 lines +Changed paths: + M /trunk/packaging/nsis/Makefile.nmake + M /trunk/packaging/nsis/ethereal.nsi +the xml plugin was removed ------------------------------------------------------------------------ -r14822 | sahlberg | 2005-06-29 21:31:15 -0500 (Wed, 29 Jun 2005) | 5 lines +r15733 | lego | 2005-09-08 17:51:12 -0500 (Thu, 08 Sep 2005) | 3 lines Changed paths: - M /trunk/wiretap/network_instruments.c + M /trunk/epan/dissectors/packet-text-media.c -make reading of observer files work again + some content-types are now handled by xml -for some reason we have forgotten to skip the initial (always 8?) bytes prior to the start of the frame. - ------------------------------------------------------------------------ -r14821 | guy | 2005-06-29 18:19:21 -0500 (Wed, 29 Jun 2005) | 6 lines +r15732 | ulfl | 2005-09-08 16:36:40 -0500 (Thu, 08 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ip.c - -If only part of an entry in an object fits in the object, don't report -the stuff that didn't fit as a negative number of junk bytes. + M /trunk/file.c -The difference between two pointers isn't guaranteed to have a -particular size; cast it to "long" and display it with "%ld". +start with fdata->num = -1, so we don't have an uninitialised value while doing read_filter style dissection +------------------------------------------------------------------------ +r15731 | ulfl | 2005-09-08 16:33:11 -0500 (Thu, 08 Sep 2005) | 1 line +Changed paths: + M /trunk/doc/README.tapping +(very minor) issue found while working on a new tap ------------------------------------------------------------------------ -r14820 | guy | 2005-06-29 17:39:36 -0500 (Wed, 29 Jun 2005) | 4 lines +r15730 | lego | 2005-09-08 16:21:05 -0500 (Thu, 08 Sep 2005) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-xml.c -Add the usual (minimal) protection against email address harvesting. +forgot the Id -Fix one entry to have tabs between the name and the address. ------------------------------------------------------------------------ -r14819 | sahlberg | 2005-06-29 06:59:42 -0500 (Wed, 29 Jun 2005) | 5 lines +r15729 | lego | 2005-09-08 16:18:58 -0500 (Thu, 08 Sep 2005) | 3 lines Changed paths: - M /trunk/proto_hier_stats.c + M /trunk/configure.in + M /trunk/epan/Makefile.common + M /trunk/epan/dissectors/Makefile.common + M /trunk/plugins/Makefile.am + M /trunk/plugins/Makefile.nmake -add fix for bug 224 +Let's migrate the xml dissector... -we now put generated items as top-level items in the decode pane so -we should not check and abort if such are found. ------------------------------------------------------------------------ -r14818 | sahlberg | 2005-06-29 05:39:09 -0500 (Wed, 29 Jun 2005) | 7 lines +r15728 | lego | 2005-09-08 16:14:24 -0500 (Thu, 08 Sep 2005) | 4 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-ip.c - -from -Maria-Luiza Crivat and -Brice Augustin + A /trunk/epan/dissectors/packet-xml.c -ICMP MPLS extensions +a new version of the xml dissector, look ma no lex! +mmh still missing the dtd parser... ------------------------------------------------------------------------ -r14817 | sahlberg | 2005-06-29 03:11:23 -0500 (Wed, 29 Jun 2005) | 3 lines +r15727 | lego | 2005-09-08 15:11:01 -0500 (Thu, 08 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/ftam/ISO8571-FTAM.asn - M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/tvbparse.c + M /trunk/epan/tvbparse.h -fix a typo for the name of a bit +fix the svn keywords and some comments that were out of date ------------------------------------------------------------------------ -r14816 | ulfl | 2005-06-29 03:06:07 -0500 (Wed, 29 Jun 2005) | 1 line +r15726 | lego | 2005-09-08 14:50:13 -0500 (Thu, 08 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom-cba-acco.c - M /trunk/epan/libethereal.def + A /trunk/epan/tvbparse.c + A /trunk/epan/tvbparse.h + +an API for "bufferless" parsing of text tvbs + -make dissect_CBA_Connection_Data available for plugins ------------------------------------------------------------------------ -r14815 | ulfl | 2005-06-29 03:03:06 -0500 (Wed, 29 Jun 2005) | 1 line +r15725 | gerald | 2005-09-08 10:01:16 -0500 (Thu, 08 Sep 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/asn1/camel/camel.cnf + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/wiretap/k12.c + +Fix more problems found by Steve Grubb, along with other changes: + +Camel: Fix an off-by-one error. Don't alloc and free where it's not +needed. Remove an unused variable. + +PPP and K12: Fix memory leaks. -add references to the corresponding request of datagram ping and ack packets ------------------------------------------------------------------------ -r14814 | sahlberg | 2005-06-29 03:00:55 -0500 (Wed, 29 Jun 2005) | 6 lines +r15724 | sahlberg | 2005-09-08 07:39:02 -0500 (Thu, 08 Sep 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-winsrepl.c -be more careful when attempting to dissect an unknown ber field not to read beyond the end and triggering a [malformed packet] +start making winsrepl into a new style dissector and use tcp_dissect_pdus() -also prettify the error when finding "unknown" entries inside a SEQUENCE to make it easier to track down what went wrong. +also fix bugs 417 / 418 +this dissector still needs to have heuristics to be added to it. + ------------------------------------------------------------------------ -r14813 | guy | 2005-06-28 17:39:56 -0500 (Tue, 28 Jun 2005) | 2 lines +r15723 | sahlberg | 2005-09-08 05:12:12 -0500 (Thu, 08 Sep 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-actrace.c + M /trunk/epan/dissectors/packet-winsrepl.c + M /trunk/epan/dissectors/packet-winsrepl.h -Squelch a compiler warning. +from M&Y Kaul ------------------------------------------------------------------------- -r14812 | guy | 2005-06-28 17:15:12 -0500 (Tue, 28 Jun 2005) | 2 lines -Changed paths: - M /trunk/gtk/wsp_stat.c +rename Wins to WINS -More constification. +add some new decodes ------------------------------------------------------------------------- -r14811 | guy | 2005-06-28 17:01:18 -0500 (Tue, 28 Jun 2005) | 3 lines -Changed paths: - M /trunk/gtk/voip_calls_dlg.c -"Handle" a couple of cases in the switch statement by adding them to the -"not supported" case, to suppress compiler warnings. ------------------------------------------------------------------------ -r14810 | guy | 2005-06-28 16:43:24 -0500 (Tue, 28 Jun 2005) | 6 lines +r15722 | sahlberg | 2005-09-08 05:08:01 -0500 (Thu, 08 Sep 2005) | 7 lines Changed paths: - M /trunk/gtk/mtp3_summary.c + M /trunk/epan/dissectors/packet-dcerpc.c + +from Michal & Yaniv Kaul + + +Updates to prettify the Bind ACK context handles + -"mtp3_sum_draw()" is never called with a null "table" argument - the -code before the call would have blown up if "table" were null. Remove -the check for a null pointer; this squelches some unset-variable -warnings you get from GCC4 because its dataflow analysis runs across -function boundaries. ------------------------------------------------------------------------ -r14809 | guy | 2005-06-28 16:25:56 -0500 (Tue, 28 Jun 2005) | 2 lines +r15721 | ulfl | 2005-09-08 04:42:19 -0500 (Thu, 08 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-kerberos.h - -Declare "decrypt_krb5_data()" for use by the KINK dissector. + M /trunk/docbook/eug_src/EUG_chapter_build_install.xml +add description of the Windows installer command line parameters ------------------------------------------------------------------------ -r14808 | etxrab | 2005-06-28 16:14:59 -0500 (Tue, 28 Jun 2005) | 1 line +r15720 | ulfl | 2005-09-08 04:19:46 -0500 (Thu, 08 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/gtk/main.c -Fix to SendAuthenticationInfoRes +set the window title of the Win32 debug console ------------------------------------------------------------------------ -r14807 | etxrab | 2005-06-28 16:14:09 -0500 (Tue, 28 Jun 2005) | 1 line +r15719 | ulfl | 2005-09-07 17:00:25 -0500 (Wed, 07 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/gtk/capture_if_dlg.c + +close the capture interfaces dialog if the user pressed "Capture" or "Prepare" -Fix to SendAuthenticationInfoRes. +this dialog is live capturing from all "known" interfaces while it's open, so huge system load is generated, which is not preferred while doing a real capture. ------------------------------------------------------------------------ -r14806 | etxrab | 2005-06-28 14:14:14 -0500 (Tue, 28 Jun 2005) | 1 line +r15718 | ulfl | 2005-09-07 16:47:51 -0500 (Wed, 07 Sep 2005) | 1 line Changed paths: - M /trunk/plugins/giop/packet-tango.c + M /trunk/gtk/main.c -Regenerated Tango with the latest idl2eth and the tango.idl +don't wait for a keypress if this is a capture child. This was very annoying, as stopping a capture seems to freeze Ethereal, but it simply waits for a keypress on the capture_child's console window. ------------------------------------------------------------------------ -r14805 | etxrab | 2005-06-28 14:13:11 -0500 (Tue, 28 Jun 2005) | 1 line +r15717 | ulfl | 2005-09-07 15:50:03 -0500 (Wed, 07 Sep 2005) | 1 line Changed paths: - A /trunk/idl/tango.idl + M /trunk/epan/dissectors/packet-rsvp.c -Add the Tango IDL file from Paolo Frigo. +MSVC don't like empty structs, add a dummy element to rsvp_session_ipv6_info ------------------------------------------------------------------------ -r14804 | gerald | 2005-06-28 09:46:47 -0500 (Tue, 28 Jun 2005) | 2 lines +r15716 | gerald | 2005-09-07 15:49:16 -0500 (Wed, 07 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-actrace.c + M /trunk/Makefile.am -Add missing commas. +Add Valgrind core files to CLEANFILES. ------------------------------------------------------------------------ -r14803 | gerald | 2005-06-28 09:02:21 -0500 (Tue, 28 Jun 2005) | 2 lines +r15715 | gerald | 2005-09-07 15:09:40 -0500 (Wed, 07 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-actrace.c + M /trunk/docbook/release-notes.xml + M /trunk/epan/sigcomp-udvm.c + M /trunk/epan/sigcomp_state_hdlr.c + M /trunk/epan/sigcomp_state_hdlr.h -Terminate a bunch of value_strings. +Add bounds checking in several places to the SigComp UDVM. Use memset() +instead of while loops to initialize variables. Use a define instead +of magic numbers. Don't use guint8s for counters. Add a corresponding +entry to the release notes. ------------------------------------------------------------------------ -r14802 | sahlberg | 2005-06-28 06:23:56 -0500 (Tue, 28 Jun 2005) | 4 lines +r15714 | sahlberg | 2005-09-07 14:52:44 -0500 (Wed, 07 Sep 2005) | 8 lines Changed paths: - M /trunk/asn1/ftam/ISO8571-FTAM.asn - M /trunk/asn1/ftam/ftam.cnf - M /trunk/epan/dissectors/packet-ftam.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-rsvp.h + M /trunk/gtk/Makefile.common + A /trunk/gtk/conversations_rsvp.c + A /trunk/gtk/hostlist_rsvp.c + +From Manu Pathak + +Make RSVP tappable + +add hostlist and conversation listing for RSVP conversations -addition of NBS9 -and bugfix for FTAM where we sometimes forgot to check if the tag was implicit. ------------------------------------------------------------------------ -r14801 | sahlberg | 2005-06-27 15:45:02 -0500 (Mon, 27 Jun 2005) | 3 lines +r15713 | gerald | 2005-09-07 10:40:59 -0500 (Wed, 07 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-ftam.h - -regenerate FTAM with the bugfix for GraphicString in asn2eth + M /trunk/epan/dissectors/packet-ber.c +If dissect_ber_octet_string() gives us a null tvb, assume we have a malformed +packet and throw an exception. Don't pass the null tvb to tvb_length(). ------------------------------------------------------------------------ -r14800 | kukosa | 2005-06-27 08:45:47 -0500 (Mon, 27 Jun 2005) | 1 line +r15712 | gerald | 2005-09-07 08:59:10 -0500 (Wed, 07 Sep 2005) | 2 lines Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/docbook + M /trunk/image + +Add patterns to svn:ignore. -fix for BER string tags ------------------------------------------------------------------------ -r14799 | sahlberg | 2005-06-27 06:43:18 -0500 (Mon, 27 Jun 2005) | 4 lines +r15711 | sahlberg | 2005-09-07 08:29:44 -0500 (Wed, 07 Sep 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-winsrepl.c + A /trunk/epan/dissectors/packet-winsrepl.h -fix two bugs when updating offset incorrectly that could lead to an infinite loop when trying to decode an unknown ber structure +From Metze with minor changes. + +New protocol +NBNS Replication support ------------------------------------------------------------------------ -r14798 | sahlberg | 2005-06-27 06:06:40 -0500 (Mon, 27 Jun 2005) | 4 lines +r15710 | gerald | 2005-09-07 08:26:23 -0500 (Wed, 07 Sep 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-actrace.c - -remove a \n in the preference string to prevent it from creating a garbage/invalid preference file entry. + M /trunk/Makefile.nmake + M /trunk/asn1/MAP_Dialogue/Makefile.nmake + M /trunk/asn1/acse/Makefile.nmake + M /trunk/asn1/camel/Makefile.nmake + M /trunk/asn1/cmip/Makefile.nmake + M /trunk/asn1/cms/Makefile.nmake + M /trunk/asn1/ess/Makefile.nmake + M /trunk/asn1/ftam/Makefile.nmake + M /trunk/asn1/gnm/Makefile.nmake + M /trunk/asn1/gsm_ss/Makefile.nmake + M /trunk/asn1/gsmmap/Makefile.nmake + M /trunk/asn1/h225/Makefile.nmake + M /trunk/asn1/h235/Makefile.nmake + M /trunk/asn1/h245/Makefile.nmake + M /trunk/asn1/h248/Makefile.nmake + M /trunk/asn1/h450/Makefile.nmake + M /trunk/asn1/logotype-cert-extn/Makefile.nmake + M /trunk/asn1/mms/Makefile.nmake + M /trunk/asn1/ns-cert-exts/Makefile.nmake + M /trunk/asn1/ocsp/Makefile.nmake + M /trunk/asn1/pkcs1/Makefile.nmake + M /trunk/asn1/pkinit/Makefile.nmake + M /trunk/asn1/pkix1explicit/Makefile.nmake + M /trunk/asn1/pkix1implicit/Makefile.nmake + M /trunk/asn1/pkixcmp/Makefile.nmake + M /trunk/asn1/pkixcrmf/Makefile.nmake + M /trunk/asn1/pkixproxy/Makefile.nmake + M /trunk/asn1/pkixqualified/Makefile.nmake + M /trunk/asn1/pkixtsp/Makefile.nmake + M /trunk/asn1/pres/Makefile.nmake + M /trunk/asn1/ros/Makefile.nmake + M /trunk/asn1/rtse/Makefile.nmake + M /trunk/asn1/s4406/Makefile.nmake + M /trunk/asn1/smrse/Makefile.nmake + M /trunk/asn1/tcap/Makefile.nmake + M /trunk/asn1/wlancertextn/Makefile.nmake + M /trunk/asn1/x411/Makefile.nmake + M /trunk/asn1/x420/Makefile.nmake + M /trunk/asn1/x509af/Makefile.nmake + M /trunk/asn1/x509ce/Makefile.nmake + M /trunk/asn1/x509if/Makefile.nmake + M /trunk/asn1/x509sat/Makefile.nmake + M /trunk/config.nmake + M /trunk/epan/Makefile.nmake + M /trunk/plugins/Makefile.nmake +Set "COPYCMD=/Y" and remove the "/Y" from each XCOPY command in order +to fix compilation under Windows NT. This should fix bug 403. +The changes were made using "find . -name Makefile.nmake | xargs perl +-pi.bak -e 's: /y::i'". They appear to work under XP, but if anything +broke I blame Larry Wall. ------------------------------------------------------------------------ -r14797 | etxrab | 2005-06-27 03:55:39 -0500 (Mon, 27 Jun 2005) | 1 line +r15709 | kukosa | 2005-09-07 05:08:13 -0500 (Wed, 07 Sep 2005) | 1 line Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/dissectors/packet-sip.c -Missed from previous commit. +SIP reassembly using req_resp_hdrs_do_reassembly() ------------------------------------------------------------------------ -r14796 | sahlberg | 2005-06-27 03:27:49 -0500 (Mon, 27 Jun 2005) | 6 lines +r15708 | gerald | 2005-09-06 17:07:35 -0500 (Tue, 06 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-fcip.c + M /trunk/docbook/release-notes.xml -some implementations do provide a CRC in the FCIP frame so skip the -'test for zero' check. -the heuristics are probably strong enough even without this check. +Add a note about PCRE. +------------------------------------------------------------------------ +r15707 | gerald | 2005-09-06 14:50:31 -0500 (Tue, 06 Sep 2005) | 2 lines +Changed paths: + M /trunk +Add patterns to svn:ignore. ------------------------------------------------------------------------ -r14795 | etxrab | 2005-06-27 03:13:41 -0500 (Mon, 27 Jun 2005) | 1 line +r15706 | gerald | 2005-09-06 14:48:57 -0500 (Tue, 06 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/capture_if_details_dlg.c - M /trunk/gtk/gtk_stat_util.c - M /trunk/gtk/service_response_time_table.c - M /trunk/gtk/service_response_time_table.h + M /trunk/Makefile.nmake + M /trunk/config.nmake + M /trunk/tools/win32-setup.sh + +Move to the latest ethereal-win32-libs tag. -Add som more const qualifiers. ------------------------------------------------------------------------ -r14794 | sahlberg | 2005-06-27 03:12:55 -0500 (Mon, 27 Jun 2005) | 4 lines +r15705 | gerald | 2005-09-06 14:21:48 -0500 (Tue, 06 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dnp.c - -From Chris Bontje -DNP3 Application Layer Object dissection + M /trunk/docbook/release-notes.xml +Add a section on file locations. ------------------------------------------------------------------------ -r14793 | guy | 2005-06-27 02:50:11 -0500 (Mon, 27 Jun 2005) | 17 lines +r15704 | gerald | 2005-09-06 13:41:25 -0500 (Tue, 06 Sep 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c + M /trunk/Makefile.nmake + M /trunk/doc/Makefile.nmake + M /trunk/plugins/Makefile.nmake -The name returned by "get_dns_name()" (and thus by -"get_dns_name_type_class()") is null-terminated - and the length -returned is *NOT* the length of the string, it's the length of the chunk -of DNS data extracted by "get_dns_name()", and that chunk could just -point to a later chunk as part of DNS compression. When running the -name through "format_text()", just use "strlen()" to get the length, so -you don't get a value that's too large *OR* too small (both are -possible - "too large" if it's uncompressed and includes length -informatioin, "too small" if it contains a pointer to a string longer -than the pointer). +In doc/Makefile.nmake, use the "install-deps" target from the root +Makefile.nmake instead of doing our own XCOPYing. Use the "clean-deps" +target when we're done instead of leaving DLLs lying around. -When adding a string value to the protocol tree, add the *raw* name, not -the formatted name - the Ethereal display code will format the string's -value as necessary. +Normalize the use of underscores vs hyphens in the "clean-deps" target. -Add formatting code for DNS names in replies. +------------------------------------------------------------------------ +r15703 | etxrab | 2005-09-06 13:08:45 -0500 (Tue, 06 Sep 2005) | 2 lines +Changed paths: + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-pres.c +Ftam - Use some mofe FN_PAR:s +PRES Dissect PDU type based on SS-user data from SES(Info from asn1 file). ------------------------------------------------------------------------ -r14792 | ulfl | 2005-06-27 02:39:48 -0500 (Mon, 27 Jun 2005) | 1 line +r15702 | guy | 2005-09-06 12:44:20 -0500 (Tue, 06 Sep 2005) | 2 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/asn1/h225/h225.cnf + M /trunk/epan/dissectors/packet-h225.c + +Make sure we don't overflow the dialedDigits array. -I've removed ethereal-capture-normal.* yesterday, as they are obsolete now ------------------------------------------------------------------------ -r14791 | ulfl | 2005-06-27 02:28:25 -0500 (Mon, 27 Jun 2005) | 1 line +r15701 | guy | 2005-09-06 12:43:22 -0500 (Tue, 06 Sep 2005) | 2 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/epan/dissectors/packet-snmp.c + +Fail somewhat gracefully if malloc() fails. -from Jaap Keuter: fix the graphics path of the edg_html_chunked target ------------------------------------------------------------------------ -r14790 | etxrab | 2005-06-27 01:21:51 -0500 (Mon, 27 Jun 2005) | 6 lines +r15700 | kukosa | 2005-09-06 09:18:49 -0500 (Tue, 06 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-actrace.c - A /trunk/epan/dissectors/packet-actrace.h - M /trunk/epan/dissectors/packet-q931.c - M /trunk/epan/dissectors/packet-q931.h + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h245/h245.cnf + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/proto.h -From Alejandro Vaquero -new dissector for the AudioCodes trunk trace protocol. -This protocol is used to debug the trunk protocol in AudioCodes -gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, -etc...) trunk protocols. It also add these protocols in the "Voip Calls -Graph..." +get rid of few warnings ------------------------------------------------------------------------ -r14789 | etxrab | 2005-06-27 01:20:23 -0500 (Mon, 27 Jun 2005) | 6 lines +r15699 | kukosa | 2005-09-06 05:38:25 -0500 (Tue, 06 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dissectors/packet-sip.c -From Alejandro Vaquero -new dissector for the AudioCodes trunk trace protocol. -This protocol is used to debug the trunk protocol in AudioCodes -gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, -etc...) trunk protocols. It also add these protocols in the "Voip Calls -Graph..." +reassembly improvements ------------------------------------------------------------------------ -r14788 | guy | 2005-06-26 16:11:22 -0500 (Sun, 26 Jun 2005) | 2 lines +r15698 | etxrab | 2005-09-06 00:30:06 -0500 (Tue, 06 Sep 2005) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-windows-common.c - M /trunk/epan/dissectors/packet-windows-common.h + M /trunk/epan/dissectors/packet-ber.c + +From Graeme Lunt: -Yet more constification. +Attached is a patch to solve the CHOICE problem for review. +Problem was two-fold: +1) not passing original class/tag to sub-choice we had matched BER_CLASS_ANY +2) not handling a count==0 if we had matched BER_CLASS_ANY + +The patch also includes a my constructed octet string fix again. ------------------------------------------------------------------------ -r14787 | guy | 2005-06-26 15:39:21 -0500 (Sun, 26 Jun 2005) | 2 lines +r15697 | guy | 2005-09-05 17:39:09 -0500 (Mon, 05 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-slsk.c + M /trunk/asn1/x411/packet-x411-template.c + M /trunk/epan/dissectors/packet-x411.c + M /trunk/epan/dissectors/packet-x411.h -More constification. +Squelch compiler warnings. ------------------------------------------------------------------------ -r14786 | guy | 2005-06-26 14:56:52 -0500 (Sun, 26 Jun 2005) | 26 lines +r15696 | guy | 2005-09-05 17:38:13 -0500 (Mon, 05 Sep 2005) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/h245/packet-h245-template.c - M /trunk/epan/dissectors/packet-aarp.c - M /trunk/epan/dissectors/packet-aim.c - M /trunk/epan/dissectors/packet-ajp13.c - M /trunk/epan/dissectors/packet-alcap.c - M /trunk/epan/dissectors/packet-ansi_637.c - M /trunk/epan/dissectors/packet-ansi_683.c - M /trunk/epan/dissectors/packet-ansi_801.c - M /trunk/epan/dissectors/packet-ansi_a.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-arp.c - M /trunk/epan/dissectors/packet-arp.h - M /trunk/epan/dissectors/packet-bgp.c - M /trunk/epan/dissectors/packet-bittorrent.c - M /trunk/epan/dissectors/packet-bssgp.c - M /trunk/epan/dissectors/packet-cast.c - M /trunk/epan/dissectors/packet-cdp.c - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/dissectors/packet-cops.c - M /trunk/epan/dissectors/packet-dcerpc-afs4int.c - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dcerpc-rs_pgo.c - M /trunk/epan/dissectors/packet-dcerpc-spoolss.c - M /trunk/epan/dissectors/packet-dhcp-failover.c - M /trunk/epan/dissectors/packet-dns.c - M /trunk/epan/dissectors/packet-dns.h - M /trunk/epan/dissectors/packet-edonkey.c - M /trunk/epan/dissectors/packet-esis.c - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/dissectors/packet-fclctl.c - M /trunk/epan/dissectors/packet-fclctl.h - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_sms.c - M /trunk/epan/dissectors/packet-gsm_ss.c - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h245.h - M /trunk/epan/dissectors/packet-iapp.c - M /trunk/epan/dissectors/packet-icmpv6.c - M /trunk/epan/dissectors/packet-icq.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-image-jfif.c - M /trunk/epan/dissectors/packet-ipdc.c - M /trunk/epan/dissectors/packet-ipp.c - M /trunk/epan/dissectors/packet-ipsec.c - M /trunk/epan/dissectors/packet-ipv6.c - M /trunk/epan/dissectors/packet-isis-hello.c - M /trunk/epan/dissectors/packet-laplink.c - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-lmp.c - M /trunk/epan/dissectors/packet-mbtcp.c - M /trunk/epan/dissectors/packet-mmse.c - M /trunk/epan/dissectors/packet-nbns.c - M /trunk/epan/dissectors/packet-ncp2222.inc - M /trunk/epan/dissectors/packet-ndps.c - M /trunk/epan/dissectors/packet-netbios.c - M /trunk/epan/dissectors/packet-netbios.h - M /trunk/epan/dissectors/packet-nfs.c - M /trunk/epan/dissectors/packet-ospf.c - M /trunk/epan/dissectors/packet-pgsql.c - M /trunk/epan/dissectors/packet-pim.c - M /trunk/epan/dissectors/packet-pppoe.c - M /trunk/epan/dissectors/packet-radius.c - M /trunk/epan/dissectors/packet-rmcp.c - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-rsvp.c - M /trunk/epan/dissectors/packet-scsi.c - M /trunk/epan/dissectors/packet-ses.c - M /trunk/epan/dissectors/packet-skinny.c - M /trunk/epan/dissectors/packet-slsk.c - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-smpp.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-ssl.c - M /trunk/epan/dissectors/packet-stun.c - M /trunk/epan/dissectors/packet-trmac.c - M /trunk/epan/dissectors/packet-tzsp.c - M /trunk/epan/dissectors/packet-wsp.c - M /trunk/epan/dissectors/packet-wtls.c - M /trunk/epan/dissectors/packet-x11.c - M /trunk/epan/dissectors/packet-ypserv.c - M /trunk/epan/libethereal.def - M /trunk/epan/value_string.c - M /trunk/epan/value_string.h - M /trunk/epan/xdlc.c - M /trunk/plugins/rtnet/packet-rtnet.c - M /trunk/tap-wspstat.c + M /trunk/asn1/rtse/rtse.cnf + M /trunk/epan/dissectors/packet-rtse.c + M /trunk/epan/dissectors/packet-rtse.h -Get rid of the private "my_match_strval()" routine in many dissectors; -add a "match_strval_idx()" routine that does the same thing, and have -"match_strval()" call it. +Squelch compiler warnings. -Make those routines, and "val_to_str()", return a "const" pointer. -Update dissectors as necessary to squelch compiler warnings produced by -that. - -Use "val_to_str()" rather than using "match_strval()" and then, if the -result is null, substituting a specific string. Clean up some other -"match_strval()"/"val_to_str()" usages. +------------------------------------------------------------------------ +r15695 | guy | 2005-09-05 17:36:52 -0500 (Mon, 05 Sep 2005) | 2 lines +Changed paths: + M /trunk/asn1/acse/acse.cnf + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-acse.h -Add a null pointer check in the NDPS dissector's "attribute_value()" -routine, as it's not clear that "global_attribute_name" won't be null at -that point. +Squelch a compiler warning. -Make some global variables in the AFS4INT dissector local. +------------------------------------------------------------------------ +r15694 | gerald | 2005-09-05 16:38:10 -0500 (Mon, 05 Sep 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-snmp.c -Make some routines not used outside the module they're in static. +For SNMP, malloc memory that we're going to free later. Fixes bug 406. -Make some tables "static const". +For RTP, don't free se_allocated memory. -Clean up white space. +------------------------------------------------------------------------ +r15693 | guy | 2005-09-05 16:30:15 -0500 (Mon, 05 Sep 2005) | 3 lines +Changed paths: + M /trunk/asn1/s4406/packet-s4406-template.c + M /trunk/epan/dissectors/packet-s4406.c + M /trunk/epan/dissectors/packet-s4406.h -Fix Gerald's address in some files. +Use the same string for the protocol's filter name as is used in the +names of its filterable fields. ------------------------------------------------------------------------ -r14785 | guy | 2005-06-26 14:55:06 -0500 (Sun, 26 Jun 2005) | 5 lines +r15692 | guy | 2005-09-05 16:21:29 -0500 (Mon, 05 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-hyperscsi.c - -Set the Info column to the correctly-capitalized name. + M /trunk/epan/dissectors/packet-sip.c -Use "val_to_str()" to set the Info column, and give the "hyperscsi.cmd" -field a value_string table. +Include "packet-tcp.h" to declare tcp_dissect_pdus(). ------------------------------------------------------------------------ -r14784 | ulfl | 2005-06-26 06:40:26 -0500 (Sun, 26 Jun 2005) | 1 line +r15691 | guy | 2005-09-05 16:18:06 -0500 (Mon, 05 Sep 2005) | 5 lines Changed paths: - M /trunk/epan/value_string.c + M /trunk/epan/ftypes/ftype-bytes.c + +"strlen()" returns a "size_t"; use that for its return value. + +Cast the argument to <ctype.h> macros to "guchar", so that if the 8th +bit is set in the byte, it doesn't get sign-extended. -value_string.c(71) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r14783 | ulfl | 2005-06-26 06:32:02 -0500 (Sun, 26 Jun 2005) | 4 lines +r15690 | obiot | 2005-09-05 15:37:47 -0500 (Mon, 05 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/prefs.c + M /trunk/AUTHORS + +Don't use curly braces in an author's log entry: it confuses the parser. -prefs.c(1218) : warning C4761: integral size mismatch in argument; conversion supplied -prefs.c(1230) : warning C4761: integral size mismatch in argument; conversion supplied -prefs.c(1240) : warning C4761: integral size mismatch in argument; conversion supplied -prefs.c(1245) : warning C4761: integral size mismatch in argument; conversion supplied ------------------------------------------------------------------------ -r14782 | ulfl | 2005-06-26 06:29:04 -0500 (Sun, 26 Jun 2005) | 2 lines +r15689 | etxrab | 2005-09-05 11:41:46 -0500 (Mon, 05 Sep 2005) | 1 line Changed paths: - M /trunk/epan/proto.c + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-ftam.h + M /trunk/epan/dissectors/packet-mms.c + M /trunk/epan/dissectors/packet-mms.h -proto.c(2941) : warning C4090: 'function' : different 'const' qualifiers -proto.c(2941) : warning C4022: 'g_tree_insert' : pointer mismatch for actual parameter 2 +Add some OID:s as we now use the Presentation context and use FN_PARS. ------------------------------------------------------------------------ -r14781 | ulfl | 2005-06-26 06:24:26 -0500 (Sun, 26 Jun 2005) | 3 lines +r15688 | etxrab | 2005-09-05 11:41:11 -0500 (Mon, 05 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-x11.c + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/asn1/mms/packet-mms-template.c -packet-x11.c(1780) : warning C4090: 'function' : different 'const' qualifiers -packet-x11.c(1780) : warning C4022: 'g_tree_insert' : pointer mismatch for actual parameter 3 -packet-x11.c(2209) : warning C4090: 'initializing' : different 'const' qualifiers +Add some OID:s as we now use the Presentation context and use FN_PARS. ------------------------------------------------------------------------ -r14780 | ulfl | 2005-06-26 06:21:39 -0500 (Sun, 26 Jun 2005) | 1 line +r15687 | etxrab | 2005-09-05 11:31:24 -0500 (Mon, 05 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-ber.c -packet-smb.c(14406) : warning C4090: 'return' : different 'const' qualifiers +branch_taken got lost in the recent changes. ------------------------------------------------------------------------ -r14779 | ulfl | 2005-06-26 06:18:47 -0500 (Sun, 26 Jun 2005) | 1 line +r15686 | etxrab | 2005-09-05 11:30:31 -0500 (Mon, 05 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-pgsql.c + M /trunk/epan/dissectors/packet-multipart.c -packet-pgsql.c(891) : warning C4090: 'return' : different 'const' qualifiers +Add a missing include ------------------------------------------------------------------------ -r14778 | ulfl | 2005-06-26 06:10:26 -0500 (Sun, 26 Jun 2005) | 6 lines +r15685 | kukosa | 2005-09-05 08:25:49 -0500 (Mon, 05 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-sip.c -packet-diameter.c(856) : warning C4090: 'function' : different 'const' qualifiers -packet-diameter.c(856) : warning C4024: 'addVendor' : different types for formal and actual parameter 2 -packet-diameter.c(857) : warning C4090: 'function' : different 'const' qualifiers -packet-diameter.c(857) : warning C4024: 'addVendor' : different types for formal and actual parameter 3 -packet-diameter.c(863) : warning C4090: 'function' : different 'const' qualifiers -packet-diameter.c(863) : warning C4024: 'addCommand' : different types for formal and actual parameter 2 +the first attempt at SIP reassembly ------------------------------------------------------------------------ -r14777 | etxrab | 2005-06-26 06:03:39 -0500 (Sun, 26 Jun 2005) | 1 line +r15684 | kukosa | 2005-09-05 08:20:56 -0500 (Mon, 05 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-multipart.c -Add a signal +buffer where parameters variable pointed into was freed +it is necessary to make a copy ------------------------------------------------------------------------ -r14776 | ulfl | 2005-06-26 06:02:13 -0500 (Sun, 26 Jun 2005) | 3 lines +r15683 | kukosa | 2005-09-05 06:59:22 -0500 (Mon, 05 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-multipart.c + +- set length for "Encapsulated multipart part" tree item +- pass right content type to media subdissectors -packet-dcerpc-samr.c(2795) : warning C4090: '=' : different 'const' qualifiers -packet-dcerpc-samr.c(2900) : warning C4090: '=' : different 'const' qualifiers -packet-dcerpc-samr.c(2933) : warning C4090: '=' : different 'const' qualifiers ------------------------------------------------------------------------ -r14775 | etxrab | 2005-06-26 06:01:04 -0500 (Sun, 26 Jun 2005) | 1 line +r15682 | kukosa | 2005-09-05 05:56:41 -0500 (Mon, 05 Sep 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h -Add a signal +new BASE_DEC_HEX and BASE_HEX_DEC displaying numbers in "dual" format ------------------------------------------------------------------------ -r14774 | etxrab | 2005-06-26 06:00:19 -0500 (Sun, 26 Jun 2005) | 1 line +r15681 | etxrab | 2005-09-05 00:29:14 -0500 (Mon, 05 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-ftam.h + M /trunk/epan/dissectors/Makefile.common -Fix a compiler warning. +Fix a typo, should make the buildbot hapy again. ------------------------------------------------------------------------ -r14773 | etxrab | 2005-06-26 05:59:15 -0500 (Sun, 26 Jun 2005) | 1 line +r15680 | etxrab | 2005-09-04 15:30:31 -0500 (Sun, 04 Sep 2005) | 15 lines Changed paths: - M /trunk/asn1/ftam/ftam.cnf - M /trunk/asn1/ftam/packet-ftam-template.c - M /trunk/asn1/ftam/packet-ftam-template.h + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/asn1/ros/packet-ros-template.c + M /trunk/asn1/rtse/packet-rtse-template.c + M /trunk/asn1/rtse/packet-rtse-template.h + M /trunk/asn1/s4406/packet-s4406-template.c + M /trunk/asn1/x420/packet-x420-template.c + M /trunk/asn1/x420/packet-x420-template.h + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-pres.c + A /trunk/epan/dissectors/packet-ros.c + A /trunk/epan/dissectors/packet-ros.h + A /trunk/epan/dissectors/packet-rtse.c + A /trunk/epan/dissectors/packet-rtse.h + A /trunk/epan/dissectors/packet-s4406.c + A /trunk/epan/dissectors/packet-s4406.h + M /trunk/epan/dissectors/packet-ses.h + A /trunk/epan/dissectors/packet-x411.c + A /trunk/epan/dissectors/packet-x411.h + A /trunk/epan/dissectors/packet-x420.c + A /trunk/epan/dissectors/packet-x420.h -Fix a compiler warning and set eol-style. ------------------------------------------------------------------------- -r14772 | ulfl | 2005-06-26 05:58:32 -0500 (Sun, 26 Jun 2005) | 1 line + From Graeme Lunt + + I attach my RTSE dissector (in tar file) which requires the included ROS dissector, as well as a patch to the latest pres.{cnf,asn}. The ROS dissector uses a new field in the SESSION_DATA_STRUCTURE to pass the ROS operation to the sub-dissector, though this is also set by other dissectors (RTSE uses it in X.410 mode). + + Note that X.400 P1 in X.410 mode doesn't use ROS, so it is useful not to explicitly include ROS in my X411 dissector. However, the inclusion of a ROS dissector won't effect any dissectors that currently implement their own ROS. + + I also include dissectors for: + + X.411 (P1) X.400 OSI Message Transfer Service + X.420 (P22) X.400 OSI Information Object + STANAG 4406 (P772) STANAG 4406 Military Message Extensions (to P22) + + These rely on the RTSE and ROS dissectors. + +Withs some changes to remove various warnings and errors. +------------------------------------------------------------------------ +r15679 | etxrab | 2005-09-04 11:22:12 -0500 (Sun, 04 Sep 2005) | 14 lines +Changed paths: + M /trunk/asn1/pres/ISO8823-PRESENTATION.asn + M /trunk/asn1/pres/pres.cnf + A /trunk/asn1/ros + A /trunk/asn1/ros/Makefile + A /trunk/asn1/ros/Makefile.nmake + A /trunk/asn1/ros/packet-ros-template.c + A /trunk/asn1/ros/packet-ros-template.h + A /trunk/asn1/ros/ros-exp.cnf + A /trunk/asn1/ros/ros.asn + A /trunk/asn1/ros/ros.cnf + A /trunk/asn1/rtse + A /trunk/asn1/rtse/Makefile + A /trunk/asn1/rtse/Makefile.nmake + A /trunk/asn1/rtse/packet-rtse-template.c + A /trunk/asn1/rtse/packet-rtse-template.h + A /trunk/asn1/rtse/rtse-exp.cnf + A /trunk/asn1/rtse/rtse.asn + A /trunk/asn1/rtse/rtse.cnf + A /trunk/asn1/s4406 + A /trunk/asn1/s4406/Makefile + A /trunk/asn1/s4406/Makefile.nmake + A /trunk/asn1/s4406/packet-s4406-template.c + A /trunk/asn1/s4406/packet-s4406-template.h + A /trunk/asn1/s4406/s4406.asn + A /trunk/asn1/s4406/s4406.cnf + A /trunk/asn1/x411 + A /trunk/asn1/x411/Makefile + A /trunk/asn1/x411/Makefile.nmake + A /trunk/asn1/x411/packet-x411-template.c + A /trunk/asn1/x411/packet-x411-template.h + A /trunk/asn1/x411/x411-exp.cnf + A /trunk/asn1/x411/x411.asn + A /trunk/asn1/x411/x411.cnf + A /trunk/asn1/x420 + A /trunk/asn1/x420/Makefile + A /trunk/asn1/x420/Makefile.nmake + A /trunk/asn1/x420/packet-x420-template.c + A /trunk/asn1/x420/packet-x420-template.h + A /trunk/asn1/x420/x420-exp.cnf + A /trunk/asn1/x420/x420.asn + A /trunk/asn1/x420/x420.cnf + +From Graeme Lunt + +I attach my RTSE dissector (in tar file) which requires the included ROS dissector, as well as a patch to the latest pres.{cnf,asn}. The ROS dissector uses a new field in the SESSION_DATA_STRUCTURE to pass the ROS operation to the sub-dissector, though this is also set by other dissectors (RTSE uses it in X.410 mode). + +Note that X.400 P1 in X.410 mode doesn't use ROS, so it is useful not to explicitly include ROS in my X411 dissector. However, the inclusion of a ROS dissector won't effect any dissectors that currently implement their own ROS. + +I also include dissectors for: + +X.411 (P1) X.400 OSI Message Transfer Service +X.420 (P22) X.400 OSI Information Object +STANAG 4406 (P772) STANAG 4406 Military Message Extensions (to P22) + +These rely on the RTSE and ROS dissectors. + +------------------------------------------------------------------------ +r15678 | etxrab | 2005-09-04 04:00:01 -0500 (Sun, 04 Sep 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/asn1/acse/acse.cnf + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/asn1/pres/packet-pres-template.h + M /trunk/asn1/pres/pres.cnf + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-acse.h + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-pres.h + +From Graeme Lunt: +Basically the changes are: +a) [pres] make the find_oid_by_[pres_]ctx_id (I changed the name to make it more specific) non-static so it can be called from other dissectors (see acse.cnf changes). I also call it from RTSE and ROS dissectors +b) [acse] remove (#ifdef NOT_NEEDED) the oid lookup table and any reference to acse_handle - as these are no longer needed +c) [acse] register the acse dissector on 2.2.1.0.1 +with some modifications: -#ifdef:ed code removed +- renamed aco -> pco -packet-ansi_map.c(760) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r14771 | ulfl | 2005-06-26 05:55:34 -0500 (Sun, 26 Jun 2005) | 1 line +r15677 | etxrab | 2005-09-04 03:53:04 -0500 (Sun, 04 Sep 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ansi_a.c + M /trunk/epan/dissectors/packet-giop.c -packet-ansi_a.c(460) : warning C4090: 'return' : different 'const' qualifiers +Make Objekt Key a HEX string. ------------------------------------------------------------------------ -r14770 | ulfl | 2005-06-26 05:51:56 -0500 (Sun, 26 Jun 2005) | 1 line +r15676 | guy | 2005-09-03 13:51:55 -0500 (Sat, 03 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ansi_801.c + M /trunk/tethereal.c + +Make usage messages fit within 80 characters. -packet-ansi_801.c(93) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r14769 | ulfl | 2005-06-26 05:48:27 -0500 (Sun, 26 Jun 2005) | 1 line +r15675 | guy | 2005-09-03 13:31:45 -0500 (Sat, 03 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ansi_683.c + M /trunk/tethereal.c + +As with Ethereal, so with Tethereal; we're not a GNU program, don't say +we are. -packet-ansi_683.c(93) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r14768 | ulfl | 2005-06-26 05:45:25 -0500 (Sun, 26 Jun 2005) | 1 line +r15674 | guy | 2005-09-03 13:21:48 -0500 (Sat, 03 Sep 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-ansi_637.c + M /trunk/gtk/main.c + +Use the "svnversion" variable, exported by version_info.c, to print the +version number from SVN for non-release builds, just as Tethereal does. +Fixes bug 408. -packet-ansi_637.c(288) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r14767 | ulfl | 2005-06-26 05:41:38 -0500 (Sun, 26 Jun 2005) | 1 line +r15673 | gerald | 2005-09-02 14:54:16 -0500 (Fri, 02 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-alcap.c + M /trunk/docbook/release-notes.xml + M /trunk/plugins/rtnet/packet-rtnet.c + +In RTnet, make sure we don't pass a null handle to call_dissector(). Add +an entry about this to the release notes. Fixes a recent buildbot crash. -packet-alcap.c(195) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r14766 | ulfl | 2005-06-26 05:28:51 -0500 (Sun, 26 Jun 2005) | 1 line +r15672 | gerald | 2005-09-02 14:50:01 -0500 (Fri, 02 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/proto_hier_stats_dlg.c + M /trunk/epan/emem.c + +Fix a typo. -proto_hier_stats_dlg.c(99) : warning C4090: '=' : different 'const' qualifiers ------------------------------------------------------------------------ -r14765 | ulfl | 2005-06-26 05:26:47 -0500 (Sun, 26 Jun 2005) | 1 line +r15671 | ulfl | 2005-09-02 14:08:25 -0500 (Fri, 02 Sep 2005) | 1 line Changed paths: - M /trunk/gtk/sctp_graph_dlg.c + M /trunk/gtk/fileset_dlg.c -sctp_graph_dlg.c(383) : warning C4244: '=' : conversion from 'unsigned int ' to 'float ', possible loss of data +don't crash if the file_set dialog is opened and a "none fileset" file is already loaded. This bug was introduced by me after the 0.10.12 release ------------------------------------------------------------------------ -r14764 | ulfl | 2005-06-26 05:23:39 -0500 (Sun, 26 Jun 2005) | 3 lines +r15670 | guy | 2005-09-02 11:50:51 -0500 (Fri, 02 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/doc/text2pcap.pod + +text2pcap can add fake SCTP headers. -remove compiler warnings: -main.c(345) : warning C4090: 'function' : different 'const' qualifiers -main.c(345) : warning C4022: 'simple_dialog_set_cb' : pointer mismatch for actual parameter 3 ------------------------------------------------------------------------ -r14763 | ulfl | 2005-06-26 04:24:38 -0500 (Sun, 26 Jun 2005) | 1 line +r15669 | sahlberg | 2005-09-02 04:28:30 -0500 (Fri, 02 Sep 2005) | 3 lines Changed paths: - D /trunk/docbook/edg_graphics/ethereal-capture-normal.dia - D /trunk/docbook/edg_graphics/ethereal-capture-normal.png + M /trunk/epan/dissectors/packet-ansi_637.c + +another switch that should be a value_string + -we don't have the capture normal mode any longer ------------------------------------------------------------------------ -r14762 | ulfl | 2005-06-26 04:14:12 -0500 (Sun, 26 Jun 2005) | 1 line +r15668 | sahlberg | 2005-09-02 04:16:50 -0500 (Fri, 02 Sep 2005) | 3 lines Changed paths: - M /trunk/doc/README.capture + M /trunk/epan/dissectors/packet-alcap.c + +make two thigs that should be value_strings value_strings + -update text to reflect the current implementation (e.g. we don't have normal/sync mode any longer) ------------------------------------------------------------------------ -r14761 | sahlberg | 2005-06-26 03:12:54 -0500 (Sun, 26 Jun 2005) | 4 lines +r15667 | guy | 2005-09-02 03:19:15 -0500 (Fri, 02 Sep 2005) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-mms-control.c - M /trunk/epan/dissectors/packet-mms-data.c + M /trunk/epan/dissectors/packet-giop.c -rename the protocol and the protocol fields to msmms from mms to make way for the telco mms protocol. +A PDU dissector called by tcp_dissect_pdus() can't return anything. +A PDU length routine called by tcp_dissect_pdus() should use the offset +passed to it as the offset of the beginning of the PDU. +In the heuristic GIOP dissector, if we're running over TCP, and accept +the packet, call "dissect_giop_tcp()" so that we handle multiple PDUs +within the segment or PDUs split across segments. ------------------------------------------------------------------------ -r14760 | sahlberg | 2005-06-26 01:28:53 -0500 (Sun, 26 Jun 2005) | 3 lines +r15666 | etxrab | 2005-09-02 00:49:25 -0500 (Fri, 02 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/libethereal.def - -update libethereal.def to the new name dissect_ber_CHOICE + M /trunk/epan/dissectors/packet-bacapp.c +From Steve Karg ------------------------------------------------------------------------ -r14759 | sahlberg | 2005-06-26 01:16:03 -0500 (Sun, 26 Jun 2005) | 3 lines +r15665 | etxrab | 2005-09-02 00:46:10 -0500 (Fri, 02 Sep 2005) | 3 lines Changed paths: - M /trunk/asn1/ftam/ftam.cnf - M /trunk/asn1/ftam/packet-ftam-template.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ftam.c - -prettify ftam by puttign the command name in the info column + M /trunk/asn1/gsmmap/GSMMAP.asn + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-gsm_map.c +From ouli: +- Add version 2 CancelLocation decoding ------------------------------------------------------------------------ -r14758 | sahlberg | 2005-06-26 00:48:50 -0500 (Sun, 26 Jun 2005) | 13 lines +r15664 | guy | 2005-09-02 00:43:49 -0500 (Fri, 02 Sep 2005) | 2 lines Changed paths: - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/ftam/ftam.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/inap/packet-inap-template.c + M /trunk/asn1/cms/cms-exp.cnf + M /trunk/asn1/mms/mms-exp.cnf M /trunk/asn1/pkixcmp/cmp-exp.cnf - M /trunk/asn1/tcap/tcap.cnf + M /trunk/asn1/pkixcrmf/crmf-exp.cnf + M /trunk/asn1/x509af/x509af-exp.cnf + M /trunk/asn1/x509ce/x509ce-exp.cnf + M /trunk/asn1/x509if/x509if-exp.cnf + M /trunk/asn1/x509sat/x509sat-exp.cnf M /trunk/epan/dissectors/packet-MAP_DialoguePDU.c + M /trunk/epan/dissectors/packet-MAP_DialoguePDU.h M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-camel.h - M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-acse.h M /trunk/epan/dissectors/packet-cmp.c - M /trunk/epan/dissectors/packet-cmp.h M /trunk/epan/dissectors/packet-cms.c M /trunk/epan/dissectors/packet-crmf.c M /trunk/epan/dissectors/packet-ess.c M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-inap.h - M /trunk/epan/dissectors/packet-kerberos.c M /trunk/epan/dissectors/packet-logotypecertextn.c + M /trunk/epan/dissectors/packet-mms.c + M /trunk/epan/dissectors/packet-ns_cert_exts.c M /trunk/epan/dissectors/packet-ocsp.c M /trunk/epan/dissectors/packet-pkinit.c + M /trunk/epan/dissectors/packet-pkix1explicit.c M /trunk/epan/dissectors/packet-pkix1implicit.c - M /trunk/epan/dissectors/packet-pkix1implicit.h M /trunk/epan/dissectors/packet-pkixqualified.c + M /trunk/epan/dissectors/packet-pkixtsp.c M /trunk/epan/dissectors/packet-smrse.c - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h + M /trunk/epan/dissectors/packet-wlancertextn.c M /trunk/epan/dissectors/packet-x509af.c M /trunk/epan/dissectors/packet-x509ce.c M /trunk/epan/dissectors/packet-x509if.c M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/tools/asn2eth.py -make dissect_ber_choice take a guint* that will return the -index of the branch taken or -1 to make prettifications easier to implement. +Regenerate dissectors with the current asn2eth. +------------------------------------------------------------------------ +r15663 | etxrab | 2005-09-01 14:44:26 -0500 (Thu, 01 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-giop.c -change the signature of dissect_ber_choice and rename it to dissect_ber_CHOICE to catch all -occurences of the use of this function +It looks like there might not always be a body, check if there is. +------------------------------------------------------------------------ +r15662 | gerald | 2005-09-01 14:35:23 -0500 (Thu, 01 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ber.c -update asn2eth to use the new name/signature +Normalize our hf_id checks and make sure our hf_ids are valid before we +try to use them. This should fix bugs 399 and 401. -update all occurences of this function to the new name and new signature. +------------------------------------------------------------------------ +r15661 | etxrab | 2005-09-01 14:31:48 -0500 (Thu, 01 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-giop.c +Re-assemble GIOP over TCP. +------------------------------------------------------------------------ +r15660 | sahlberg | 2005-09-01 14:05:00 -0500 (Thu, 01 Sep 2005) | 5 lines +Changed paths: + M /trunk/epan/prefs.c + M /trunk/epan/range.c + M /trunk/gtk/prefs_dlg.c + M /trunk/plugins/asn1/packet-asn1.c + +convert to g_snprintf() + +also make range_convert_range() return an emem allocated string ------------------------------------------------------------------------ -r14757 | sahlberg | 2005-06-25 19:12:15 -0500 (Sat, 25 Jun 2005) | 3 lines +r15659 | guy | 2005-09-01 13:03:02 -0500 (Thu, 01 Sep 2005) | 2 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-bootp.c -From Alejandro, fix for GTK1 graph_analysis issue. +Get rid of a no-longer-used #define. +------------------------------------------------------------------------ +r15658 | guy | 2005-09-01 06:34:10 -0500 (Thu, 01 Sep 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-isis-clv.c + +Use "proto_item_append_text()" rather than filling up an allocated +buffer. This fixes one place where the "NLPID(s):" wasn't being put +into the protocol tree item. ------------------------------------------------------------------------ -r14756 | sahlberg | 2005-06-25 18:12:24 -0500 (Sat, 25 Jun 2005) | 5 lines +r15657 | guy | 2005-09-01 06:32:14 -0500 (Thu, 01 Sep 2005) | 5 lines Changed paths: - M /trunk/asn1/cmip/CMIP.asn - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/epan/inet_ntop.c -some updates for CMIP. +128 bytes isn't much room for the stack; revert to using an on-the-stack +buffer (the buffer in question is temporary, so it doesn't need to +survive after inet_ntop() returns), which should fix some compile errors +on Windows. -note taht cmip does not yet compile due to a possible asn2eth compiler bug +------------------------------------------------------------------------ +r15656 | kukosa | 2005-09-01 05:52:33 -0500 (Thu, 01 Sep 2005) | 1 line +Changed paths: + M /trunk/epan/ftypes/ftype-bytes.c +filter expression can contain GUID in XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX form now +------------------------------------------------------------------------ +r15655 | guy | 2005-09-01 05:38:41 -0500 (Thu, 01 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-bootp.c + +Use "proto_tree_append_text()" rather than appending to an ep_alloced +buffer (that buffer wasn't getting cleared for each item). ------------------------------------------------------------------------ -r14755 | sahlberg | 2005-06-25 17:15:51 -0500 (Sat, 25 Jun 2005) | 6 lines +r15654 | guy | 2005-09-01 04:56:23 -0500 (Thu, 01 Sep 2005) | 2 lines Changed paths: - M /trunk/epan/conversation.c + M /trunk/epan/dissectors/packet-bgp.c -from Kashyap Desai +Get rid of a trailing comma. -fix bug in conversation_delete_proto_data -second argument to g_slist_remove() is a pointer to the data, not a GSlist containing a list of such pointers. +------------------------------------------------------------------------ +r15653 | sahlberg | 2005-09-01 04:40:55 -0500 (Thu, 01 Sep 2005) | 3 lines +Changed paths: + M /trunk/epan/inet_ntop.c + +replace one sprintf with g_snprintf and move one array off the stack and into emem allocated memory ------------------------------------------------------------------------ -r14754 | sahlberg | 2005-06-25 16:57:11 -0500 (Sat, 25 Jun 2005) | 4 lines +r15652 | sahlberg | 2005-09-01 04:29:21 -0500 (Thu, 01 Sep 2005) | 6 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-mms-control.c - A /trunk/epan/dissectors/packet-mms-data.c + M /trunk/epan/proto.c + +hmmm i though i removed some sprintf in the previous commit apparently not. -From Martin Mathieson -New protocol : MS MediaServer protocol + +remove all sprintf and replace with g_snprintf() ------------------------------------------------------------------------ -r14753 | ulfl | 2005-06-25 16:27:26 -0500 (Sat, 25 Jun 2005) | 1 line +r15651 | sahlberg | 2005-09-01 04:03:29 -0500 (Thu, 01 Sep 2005) | 6 lines Changed paths: + M /trunk/epan/proto.c M /trunk/gtk/main.c + M /trunk/tap-protocolinfo.c + +convert one sprintf into g_snprintf() + +at the same time, make proto_construct_dfilter_string() return an emem allocated string. +This fixes a tiny memleak in print.c that never freed the string returned by this function. + -we are not a GNU program, so we shouldn't report as such in the command line help output ------------------------------------------------------------------------ -r14752 | guy | 2005-06-25 14:14:17 -0500 (Sat, 25 Jun 2005) | 3 lines +r15650 | sahlberg | 2005-09-01 03:39:52 -0500 (Thu, 01 Sep 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/sha1.c + +replace one ifdeffed out sprintf with g_snprintf() so that it doesnt show up in a 'grep sprintf *.c' any more -The data in an Identification packet is a message intended to be -human-readable; displayh it with "tvb_format_text()". ------------------------------------------------------------------------ -r14751 | guy | 2005-06-25 13:56:08 -0500 (Sat, 25 Jun 2005) | 2 lines +r15649 | etxrab | 2005-09-01 00:44:40 -0500 (Thu, 01 Sep 2005) | 1 line Changed paths: M /trunk/AUTHORS -Give Paolo Frigo credit for the TANGO dissector. - +Add Tomer Shani ------------------------------------------------------------------------ -r14750 | guy | 2005-06-25 13:20:13 -0500 (Sat, 25 Jun 2005) | 8 lines +r15648 | etxrab | 2005-09-01 00:41:59 -0500 (Thu, 01 Sep 2005) | 10 lines Changed paths: - M /trunk/ethereal_gen.py - M /trunk/plugins/giop/packet-coseventcomm.c - M /trunk/plugins/giop/packet-cosnaming.c - M /trunk/plugins/giop/packet-parlay.c + M /trunk/gtk/rtp_analysis.c -In generated GIOP dissectors, don't set the Protocol or Info columns, or -create the top-level protocol tree item, until the dissector accepts the -packet as being for it. +From Tomer Shani: +Patch which will enable saving payload in raw (binary) format in addition to the existing au format. -"strcmp()" isn't a Boolean; don't treat it as such. +We have found it very useful to be able to extract the RTP data for use with other tools (especially when dealing with proprietary/uncommon coders). -Get rid of trailing white space. +Changes: + +rtp_packet_save_payload: no longer transforms packet to linear coding, payload is saved in raw format +copy_file: will perform the needed transcoding and save to needed format (au or raw) ------------------------------------------------------------------------ -r14749 | etxrab | 2005-06-25 12:26:30 -0500 (Sat, 25 Jun 2005) | 1 line +r15647 | etxrab | 2005-09-01 00:34:52 -0500 (Thu, 01 Sep 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-rdt.c + M /trunk/epan/dissectors/packet-rdt.h + M /trunk/epan/dissectors/packet-rtsp.c + +From Martin Mathieson + +These small patches: + +- add RTSP header 'RDTFeatureLevel as a proper field +- show feature level in RDT stream setup info +- tidy up RDT info column text -Major rewrite to update to version TS 129 002 V6.9.0 ------------------------------------------------------------------------ -r14748 | etxrab | 2005-06-25 12:25:44 -0500 (Sat, 25 Jun 2005) | 1 line +r15646 | ulfl | 2005-08-31 18:52:40 -0500 (Wed, 31 Aug 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/plugins/xml/moduleinfo.h -Major rewrite to update to version TS 129 002 V6.9.0 +fix probable copy and paste error, as the xml dissector should be named xml and not mate ------------------------------------------------------------------------ -r14747 | sahlberg | 2005-06-25 07:40:53 -0500 (Sat, 25 Jun 2005) | 4 lines +r15645 | gerald | 2005-08-31 16:38:08 -0500 (Wed, 31 Aug 2005) | 4 lines Changed paths: - A /trunk/asn1/ftam - A /trunk/asn1/ftam/ISO8571-FTAM.asn - A /trunk/asn1/ftam/Makefile - A /trunk/asn1/ftam/Makefile.nmake - A /trunk/asn1/ftam/ftam.cnf - A /trunk/asn1/ftam/packet-ftam-template.c - A /trunk/asn1/ftam/packet-ftam-template.h - M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-ftam.h - -new FTAM dissector generated by asn2eth + M /trunk/epan/column-utils.c +If we set one or more time references and then changed the time display +format, our time-formatted columns would display a time value instead of +"*REF*". Don't to that. +------------------------------------------------------------------------ +r15644 | etxrab | 2005-08-31 15:25:48 -0500 (Wed, 31 Aug 2005) | 1 line +Changed paths: + M /trunk/plugins/giop/packet-parlay.c +Parlay re-generated with the updated idl2eth generator. ------------------------------------------------------------------------ -r14746 | sahlberg | 2005-06-25 02:46:14 -0500 (Sat, 25 Jun 2005) | 3 lines +r15643 | etxrab | 2005-08-31 15:20:56 -0500 (Wed, 31 Aug 2005) | 2 lines Changed paths: - A /trunk/asn1/acse/acse-exp.cnf M /trunk/asn1/acse/acse.cnf - M /trunk/asn1/acse/packet-acse-template.h - M /trunk/asn1/cmip/CMIP.asn + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/asn1/pres/pres.cnf M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-acse.h + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-pres.h -Make ACSE export the EXTERNAL construct since both CMIP and FTAM rely on it. +Upadte to call Data dissector from PRES based on OID in Presentation Context, +based on the code in ACSE. +------------------------------------------------------------------------ +r15642 | guy | 2005-08-31 15:02:06 -0500 (Wed, 31 Aug 2005) | 2 lines +Changed paths: + A /trunk/asn1/gnm/Makefile +Add a Makefile. ------------------------------------------------------------------------ -r14745 | guy | 2005-06-24 07:43:32 -0500 (Fri, 24 Jun 2005) | 5 lines +r15641 | guy | 2005-08-31 14:51:53 -0500 (Wed, 31 Aug 2005) | 2 lines Changed paths: - M /trunk/plugins/giop/packet-coseventcomm.c - M /trunk/plugins/giop/packet-cosnaming.c - M /trunk/plugins/giop/packet-parlay.c - M /trunk/plugins/giop/packet-tango.c + M /trunk/epan/dissectors/packet-camel.c -Re-generate the CosNaming, CosEventComm, and Parlay dissectors from the -IDL (and re-insert an earlier bug fix into the CosNaming and -CosEventComm dissectors), and add a new check added to ethereal_gen.py -to the Tango dissector. +Give it an RCS ID. ------------------------------------------------------------------------ -r14744 | guy | 2005-06-24 06:38:19 -0500 (Fri, 24 Jun 2005) | 2 lines +r15640 | etxrab | 2005-08-31 14:51:24 -0500 (Wed, 31 Aug 2005) | 2 lines Changed paths: - A /trunk/idl/coseventcomm.idl - A /trunk/idl/cosnaming.idl + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/sigcomp-udvm.c -Add IDL for cosnaming and coseventcomm. +udvm: initialise a variable +sigcomp: implement RFC 4077 +------------------------------------------------------------------------ +r15639 | guy | 2005-08-31 14:51:16 -0500 (Wed, 31 Aug 2005) | 2 lines +Changed paths: + M /trunk/asn1/camel/packet-camel-template.c + +Give it an RCS ID. ------------------------------------------------------------------------ -r14743 | guy | 2005-06-24 06:26:19 -0500 (Fri, 24 Jun 2005) | 6 lines +r15638 | guy | 2005-08-31 14:43:37 -0500 (Wed, 31 Aug 2005) | 4 lines Changed paths: - M /trunk/ethereal_gen.py + M /trunk/epan/stat_cmd_args.c -There's no guarantee that a reply with a reply status of USER_EXCEPTION -includes an exception ID - the sequence length could be zero. When -generating a dissector for a USER_EXCEPTION reply, return FALSE if -there's no exception ID. (And since we're now always using the header -pointer argument, un-_U_ize it.) +Keep the list of possible "-z" arguments sorted, so we can display them +in sorted order (to make it a bit easier to find the one you're +interested in). ------------------------------------------------------------------------ -r14742 | sahlberg | 2005-06-24 05:03:20 -0500 (Fri, 24 Jun 2005) | 5 lines +r15637 | guy | 2005-08-31 13:49:14 -0500 (Wed, 31 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/tethereal.c - for unknown GraphicString -just decode them as an octet string and say in the decode pane this is an unknown GraphicString +Fix a typo. +------------------------------------------------------------------------ +r15636 | kukosa | 2005-08-31 10:03:12 -0500 (Wed, 31 Aug 2005) | 3 lines +Changed paths: + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h235/packet-h235-template.c + M /trunk/asn1/h245/h245.cnf + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/asn1/h245/packet-h245-template.h + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h235.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h +- more standard way for FastStart item dissection +- protocol names fixed ------------------------------------------------------------------------ -r14741 | sahlberg | 2005-06-24 03:57:41 -0500 (Fri, 24 Jun 2005) | 5 lines +r15635 | kukosa | 2005-08-31 09:53:15 -0500 (Wed, 31 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-per.c -fix to ber NULL handling -1, make it actually show the hf field when present -2, make it handle imlicit_tag properly +internal length field for constrained SEQUNCE/SET OF was not hidden +------------------------------------------------------------------------ +r15634 | kukosa | 2005-08-31 09:32:29 -0500 (Wed, 31 Aug 2005) | 3 lines +Changed paths: + M /trunk/tools/asn2eth.py +- OID names table extended +- NAME and ABBREV attributes can be used in #.FIELD_ATTR +- following constraint format is supported (1..10, ..., 11..MAX) +------------------------------------------------------------------------ +r15633 | tuexen | 2005-08-31 08:52:43 -0500 (Wed, 31 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-ses.h + +Make ses_vals extern. Required to get it linked on Mac OS X. ------------------------------------------------------------------------ -r14740 | guy | 2005-06-23 21:51:01 -0500 (Thu, 23 Jun 2005) | 2 lines +r15632 | sahlberg | 2005-08-31 03:49:10 -0500 (Wed, 31 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/proto.c - M /trunk/epan/proto.h - M /trunk/gtk/main.c - M /trunk/plugins/mate/mate_setup.c + M /trunk/epan/dissectors/packet-bgp.c + +remove some g_string_printf[a]() and replace with g_snprintf() -More constification. ------------------------------------------------------------------------ -r14739 | guy | 2005-06-23 20:32:42 -0500 (Thu, 23 Jun 2005) | 5 lines +r15631 | sahlberg | 2005-08-31 03:09:00 -0500 (Wed, 31 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/prefs.c - M /trunk/epan/prefs.h - M /trunk/gtk/dfilter_expr_dlg.c - M /trunk/gtk/http_stat.c - M /trunk/gtk/service_response_time_table.c - M /trunk/gtk/service_response_time_table.h - M /trunk/gtk/sip_stat.c - M /trunk/gtk/wsp_stat.c - M /trunk/tap-httpstat.c - M /trunk/tap-protohierstat.c - M /trunk/tap-sipstat.c - M /trunk/tap-wspstat.c + M /trunk/epan/dissectors/packet-bootp.c -Constify a bunch of structure members and function arguments, to squelch -compiler warnings. +change g_string_sprintf[a]() to g_snprintf() and emem allocated memory. -Clean up indentation. ------------------------------------------------------------------------ -r14738 | etxrab | 2005-06-23 17:17:03 -0500 (Thu, 23 Jun 2005) | 2 lines +r15630 | etxrab | 2005-08-31 00:46:20 -0500 (Wed, 31 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h + M /trunk/asn1/h450/packet-h450-template.c + M /trunk/epan/dissectors/packet-h450.c -From Valery Vybornov: -add register_dissector to packet-tcap.c +Decode CmnInform fixes bug 376. ------------------------------------------------------------------------ -r14737 | etxrab | 2005-06-23 17:15:47 -0500 (Thu, 23 Jun 2005) | 2 lines +r15629 | jmayer | 2005-08-30 15:21:11 -0500 (Tue, 30 Aug 2005) | 1 line Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/pres/Makefile -From Valery Vybornov: -add register_dissector to packet-tcap.c +propset svn:keywords and svn:eol-style ------------------------------------------------------------------------ -r14736 | ulfl | 2005-06-23 16:19:05 -0500 (Thu, 23 Jun 2005) | 3 lines +r15628 | gerald | 2005-08-30 14:52:38 -0500 (Tue, 30 Aug 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/docbook/release-notes.xml -fix #135: handle the command line parameters -v, -h and -G completely in their own getopt() loop. +Add an item about the packet list scroll bar. -This is done "long before" calling gtk_init() as this function requires a running X server, causing an error if running from the console only. ------------------------------------------------------------------------ -r14735 | ulfl | 2005-06-23 15:18:17 -0500 (Thu, 23 Jun 2005) | 1 line +r15627 | ulfl | 2005-08-30 14:43:38 -0500 (Tue, 30 Aug 2005) | 1 line Changed paths: - M /trunk/gtk/main.c + M /trunk/docbook/release-notes.xml -Win32: "fix" handling of create_console(), hopefully clarifying usage of the corresponding prefs flag +add timestamp enhancements to the changes section, do some editing with the existing entries ------------------------------------------------------------------------ -r14734 | ulfl | 2005-06-23 15:14:05 -0500 (Thu, 23 Jun 2005) | 1 line +r15626 | gerald | 2005-08-30 14:43:32 -0500 (Tue, 30 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/main.c + A /trunk/asn1/pres/Makefile + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-pres.h + +Break out of an infinite loop. Fixes bugs 392 - 395. Add a UNIX Makefile +for generation of the PRES dissector. -beautify version and usage output ------------------------------------------------------------------------ -r14733 | sahlberg | 2005-06-23 04:28:46 -0500 (Thu, 23 Jun 2005) | 5 lines +r15625 | ulfl | 2005-08-30 14:42:05 -0500 (Tue, 30 Aug 2005) | 5 lines Changed paths: - M /trunk/asn1/cmip/cmip.cnf - M /trunk/epan/dissectors/packet-cmip.c - -fix for CMIP, we should set the opcode_type BEFORE we try to use it in the subdissector, -it doesnt work really that well if we have opcode_type set to INVOKE from the previous packet and this new packet contains a ReturnResult. + M /trunk/docbook/Makefile +minor workflow enhancement, generate the HTML files before the pdf's and alike. +while working with the docbook sources, the html versions are a lot easier to look at than the pdf's. At least the Adobe Reader will lock the pdf file, so one has to close it to generate a next version, it's ugly to work with. +the html files can be viewed with e.g. Firefox while a new version is already generated, a simple reload will do the update then ... ------------------------------------------------------------------------ -r14732 | etxrab | 2005-06-22 11:17:18 -0500 (Wed, 22 Jun 2005) | 1 line +r15624 | ulfl | 2005-08-30 14:35:20 -0500 (Tue, 30 Aug 2005) | 5 lines Changed paths: - A /trunk/idl/parlay/Parlay.idl - A /trunk/idl/parlay/README.parlay - A /trunk/idl/parlay/am.idl - A /trunk/idl/parlay/cccs.idl - A /trunk/idl/parlay/cm.idl - A /trunk/idl/parlay/common_cc_data.idl - A /trunk/idl/parlay/cs.idl - A /trunk/idl/parlay/dsc.idl - A /trunk/idl/parlay/fw_data.idl - A /trunk/idl/parlay/fw_if.idl - A /trunk/idl/parlay/fw_if_access.idl - A /trunk/idl/parlay/fw_if_app.idl - A /trunk/idl/parlay/fw_if_entop.idl - A /trunk/idl/parlay/fw_if_service.idl - A /trunk/idl/parlay/gcc_data.idl - A /trunk/idl/parlay/gcc_interfaces.idl - A /trunk/idl/parlay/gms.idl - A /trunk/idl/parlay/mm.idl - A /trunk/idl/parlay/mmccs.idl - A /trunk/idl/parlay/mmm.idl - A /trunk/idl/parlay/mpcc_data.idl - A /trunk/idl/parlay/mpcc_interfaces.idl - A /trunk/idl/parlay/osa.idl - A /trunk/idl/parlay/pam_data.idl - A /trunk/idl/parlay/pam_interfaces.idl - A /trunk/idl/parlay/policy_data.idl - A /trunk/idl/parlay/policy_interfaces.idl - A /trunk/idl/parlay/termcap.idl - A /trunk/idl/parlay/ui_data.idl - A /trunk/idl/parlay/ui_interfaces.idl + M /trunk/docbook/edg_src/EDG_chapter_tools.xml + +from Jaap Keuter: -Add the IDL doc's needed to build the Parlay dissector. +There were so many little things in chapter 2 that I had to get to it and +weed them all out. Its mainly capitalizations, some wording, and the +addition of GnuWin32 references. ------------------------------------------------------------------------ -r14731 | etxrab | 2005-06-22 11:16:24 -0500 (Wed, 22 Jun 2005) | 1 line +r15623 | ulfl | 2005-08-30 04:43:47 -0500 (Tue, 30 Aug 2005) | 5 lines Changed paths: - A /trunk/idl/parlay + M /trunk/wiretap/file_access.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/libpcap.h + M /trunk/wiretap/wtap-int.h + M /trunk/wiretap/wtap.h + +Add support for slightly modified libpcap file format with nanosecond resolution (currently supported by Ethereal only). Support for both read and write was added. -Add a folder for Parlay IDL doc's +The file format stays the same as the common libpcap format, only the lower part of the timestamp field uses nanoseconds instead of microseconds. + +This file format uses the libpcap magic number 0xa1b23c4d. ------------------------------------------------------------------------ -r14730 | etxrab | 2005-06-22 11:15:16 -0500 (Wed, 22 Jun 2005) | 1 line +r15622 | sahlberg | 2005-08-30 04:38:06 -0500 (Tue, 30 Aug 2005) | 3 lines Changed paths: - A /trunk/idl + M /trunk/epan/dissectors/packet-bootp.c + +remove some g_string_printf[a]() and replace it with g_snprintf() to ememified buffers + -Add a folder for IDL dockuments ------------------------------------------------------------------------ -r14729 | gerald | 2005-06-22 10:37:46 -0500 (Wed, 22 Jun 2005) | 3 lines +r15621 | sahlberg | 2005-08-30 04:25:44 -0500 (Tue, 30 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/to_str.c + M /trunk/epan/addr_resolv.c + +remove a bunch of sprintf that should be perfectly safe but for the principle of it + +replace with g_snprintf() -Fix an off-by-four error, which should take care of bugs 254 - 258. Print -OID values as unsigned ints instead of signed. ------------------------------------------------------------------------ -r14728 | sahlberg | 2005-06-22 04:58:46 -0500 (Wed, 22 Jun 2005) | 7 lines +r15620 | sahlberg | 2005-08-30 04:05:44 -0500 (Tue, 30 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-dns.c -update to packet-ber +replace some g_string_sprintf() with g_snprintf() -1, start making indefinite length constructions actually work -2, when attempting to decode an unknown BER octet sequence, do not generate [malformed packet] just because the length does not make sense and might point outside the tvb. it might just be that there are implicit tags in the asn1 specification and that it is just impossible to decode the octet stream without knowledge of the asn. +remove one static 1kb char array and make it emem ep allocated +------------------------------------------------------------------------ +r15619 | sahlberg | 2005-08-30 03:47:25 -0500 (Tue, 30 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-isis-clv.c + +move an array off the stack into emem allocated memory + ------------------------------------------------------------------------ -r14727 | sahlberg | 2005-06-22 03:41:58 -0500 (Wed, 22 Jun 2005) | 7 lines +r15618 | sahlberg | 2005-08-30 03:41:18 -0500 (Tue, 30 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-isis-clv.c -add a dummy variable frame_number to dissect_frame() and assign it the current frame number so that the crashdump that buildbot generates will show which frame the problem occured in. +change g_string_sprintf() into g_snprintf() -this is useful since some bugs only trigger ia crash on some platforms. -example bug 255 which does not trigger a crash on linux redhat 7.1 +------------------------------------------------------------------------ +r15617 | sahlberg | 2005-08-30 03:23:50 -0500 (Tue, 30 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-windows-common.c + +change one g_string_sprintf() into g_snprintf() and move one array of characters from the stack into emem allocated memory ------------------------------------------------------------------------ -r14726 | sahlberg | 2005-06-22 03:28:59 -0500 (Wed, 22 Jun 2005) | 5 lines +r15616 | sahlberg | 2005-08-30 03:06:16 -0500 (Tue, 30 Aug 2005) | 3 lines Changed paths: - M /trunk/asn1/acse/packet-acse-template.c - M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-wcp.c + +remove a variable that is never used and thus two also completely redundant g_free() calls. + -only create the ACSE protocol tree if there is an ACSE layer present. +------------------------------------------------------------------------ +r15615 | sahlberg | 2005-08-30 02:54:15 -0500 (Tue, 30 Aug 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-wtp.c -do not create it if it is just a SES_DATA_TRANSFER PDU +replace some (safe) g_string_sprintf with g_snprintf() +(so we dont have that many different string handling functions to memorize their usage of and can standardize on a single one ) ------------------------------------------------------------------------ -r14725 | sahlberg | 2005-06-22 03:15:18 -0500 (Wed, 22 Jun 2005) | 9 lines +r15614 | etxrab | 2005-08-29 15:07:06 -0500 (Mon, 29 Aug 2005) | 12 lines Changed paths: - M /trunk/asn1/acse/Makefile - M /trunk/asn1/acse/acse.asn - M /trunk/asn1/acse/acse.cnf + M /trunk/asn1/MAP_Dialogue/MAP_DialoguePDU.cnf M /trunk/asn1/acse/packet-acse-template.c M /trunk/asn1/cmip/packet-cmip-template.c + A /trunk/asn1/pres + A /trunk/asn1/pres/ISO8823-PRESENTATION.asn + A /trunk/asn1/pres/Makefile.nmake + A /trunk/asn1/pres/packet-pres-template.c + A /trunk/asn1/pres/packet-pres-template.h + A /trunk/asn1/pres/pres.cnf M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-acse.h + M /trunk/epan/dissectors/packet-ber.c M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-pres.h + M /trunk/epan/dissectors/packet-ses.c + M /trunk/epan/dissectors/packet-ses.h -remove a dissector table we no longer use from ACSE -and also from the CMIP and FTAM dissectors that tried to register against it. +MapDialougePDU.cnf +Fix a typo. -Implement a workaround for the asn2eth bug (can not yet handle tagged assignments) to the conformance file and remove the warnings from the template file. +packet-ber.c +packet-acse.c +packet-cmip.c +- Add OID(s) -Since workaround is implemented in conformance file, make make copy_files install the dissector instead of printing a warning message. +packet-ses.c +Fix export of a value string and change names to the ones used in the protocol spec. +Replace PRES dissector with an asn2eth generated one. +------------------------------------------------------------------------ +r15613 | etxrab | 2005-08-29 11:51:58 -0500 (Mon, 29 Aug 2005) | 1 line +Changed paths: + M /trunk/tools/asn2eth.py +Fix a typo 'BER_UNI_TAG_TeletexString' +------------------------------------------------------------------------ +r15612 | jmayer | 2005-08-29 10:00:24 -0500 (Mon, 29 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc-fldb.c + +Change the field description to match the field name. ------------------------------------------------------------------------ -r14724 | lego | 2005-06-21 21:18:10 -0500 (Tue, 21 Jun 2005) | 2 lines +r15611 | jmayer | 2005-08-29 09:15:32 -0500 (Mon, 29 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sdp.c + A /trunk/tools/checkhf.pl -add ipbcp attribute as in Q.1970 +Add a tool to check the hf_ values. ------------------------------------------------------------------------ -r14723 | gerald | 2005-06-21 17:02:18 -0500 (Tue, 21 Jun 2005) | 2 lines +r15610 | kukosa | 2005-08-29 08:00:53 -0500 (Mon, 29 Aug 2005) | 1 line Changed paths: - M /trunk/epan/prefs.c + M /trunk/epan/dissectors/packet-per.c -Make a couple of variables dynamic, as suggested by Ulf. +avoid few warnings +------------------------------------------------------------------------ +r15609 | kukosa | 2005-08-29 06:37:08 -0500 (Mon, 29 Aug 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-per.c +- fix of bug made with too fast release ------------------------------------------------------------------------ -r14722 | guy | 2005-06-21 12:40:11 -0500 (Tue, 21 Jun 2005) | 2 lines +r15608 | kukosa | 2005-08-29 05:43:33 -0500 (Mon, 29 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/giop/packet-parlay.c + M /trunk/epan/dissectors/packet-per.c + +- put real value insted of only text into tree for choice extensions +- sort alphabet for restricted character strings +- different handling of PER internal fields (only hide them) +------------------------------------------------------------------------ +r15607 | sahlberg | 2005-08-29 03:24:15 -0500 (Mon, 29 Aug 2005) | 15 lines +Changed paths: + M /trunk/epan/dissectors/packet-ber.c + +In the SEQUENCE OF dissector helper + +Only count the number of items in the SEQUENCE OF IFF we have the full TVB containing the entire blob. +Dont count the items if the tvb is "short" since then this would just lead to a [short frame] before a single item in the SEQUENCE OF has been dissected. + + + + +Do we really need to count the items and create a FT_UINT field with the number of items at all? +Then count the items as we are calling the subdissectors and +append the '# item[s]' text to the FT_NONE items after we finished the loop? + + -It's svn:eol-style, not svn:eolstyle. ------------------------------------------------------------------------ -r14721 | sahlberg | 2005-06-21 05:19:10 -0500 (Tue, 21 Jun 2005) | 3 lines +r15606 | guy | 2005-08-28 20:18:27 -0500 (Sun, 28 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-lmp.c + M /trunk/wiretap/netxray.c -terminate some value_strings properly with a {0,NULL} +Get rid of the old file header definition. +Set the time stamp resolution based on whether the number of ticks per +second is > 1 million or not. ------------------------------------------------------------------------ -r14720 | sahlberg | 2005-06-21 04:38:59 -0500 (Tue, 21 Jun 2005) | 5 lines +r15605 | jmayer | 2005-08-28 19:02:50 -0500 (Sun, 28 Aug 2005) | 4 lines Changed paths: - M /trunk/asn1/acse/packet-acse-template.c - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h - M /trunk/epan/dissectors/packet-gssapi.c - M /trunk/epan/dissectors/packet-spnego.c - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/Makefile.common + D /trunk/epan/dissectors/packet-afs-defs.h + D /trunk/epan/dissectors/packet-afs-macros.h + D /trunk/epan/dissectors/packet-afs-register-info.h + M /trunk/epan/dissectors/packet-afs.c -the maximum ASN OID length is 256 bytes and there is a define to control this. +Merge packet-afs-register-info.h, packet-afs-defs.h and packet-afs-macros.h +into packet-afs.c -fix bug251 and all other occurances where an oid string passed to packet_ber_object_identifier() -is not defined as foo[MAX_OID_STR_LEN] ------------------------------------------------------------------------ -r14719 | guy | 2005-06-21 04:17:53 -0500 (Tue, 21 Jun 2005) | 5 lines +r15604 | jmayer | 2005-08-28 18:28:16 -0500 (Sun, 28 Aug 2005) | 1 line Changed paths: - M /trunk/plugins/giop/packet-parlay.c + M /trunk/epan/dissectors/packet-gnm.c + +properties: svn-keywords -> svn:keywords +------------------------------------------------------------------------ +r15603 | guy | 2005-08-28 18:11:53 -0500 (Sun, 28 Aug 2005) | 24 lines +Changed paths: + M /trunk/AUTHORS + M /trunk/wiretap/AUTHORS + M /trunk/wiretap/netxray.c + +From Bill Meier: -Fix the line endings. +1. Use the new (good work!) 'nanosec' precision only for gig pods; +2. Rework 'struct netxray_hdr' to make it (somewhat) easier + to maintain and revise: + a. Declare known hdr fields such as 'captype' instead + of using offsets in 'xxx placeholder' fields. + d. Define 'unknown' hdr fields using placeholder names + based upon hex-offset in the netxray header record. + (This isn't perfect, but I hope it will make things + more manageable). +3. Update hdr field info (based upon examination of various + capture files): + a. Define a hdr field which appears to be 'time-zone' + [offset in hours from UTC] for the machine doing + the capture. + (Maybe this field can eventually be used for Ethereal + to display the (local) time as it was at the time + of the capture). + b. Describe certain hdr fields as being "file offsets" + (altho the exact use is still unclear). -Get rid of include of "snprintf.h", and _U_-ify arguments, as per -changes made to idl2eth. +Update some comments. ------------------------------------------------------------------------ -r14718 | guy | 2005-06-21 04:15:26 -0500 (Tue, 21 Jun 2005) | 3 lines +r15602 | guy | 2005-08-28 17:52:05 -0500 (Sun, 28 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/giop/packet-tango.c + M /trunk/wiretap/lanalyzer.c -Get rid of include of "snprintf.h", and _U_-ify arguments, as per -changes made to idl2eth. +Ethereal requires 64-bit integrer support; do the time stamp +calculations with integers, which avoids some floating-point inaccuracy. ------------------------------------------------------------------------ -r14717 | lego | 2005-06-20 16:21:06 -0500 (Mon, 20 Jun 2005) | 3 lines +r15601 | gerald | 2005-08-28 15:15:57 -0500 (Sun, 28 Aug 2005) | 2 lines Changed paths: - M /trunk/asn1/h248/h248.cnf - M /trunk/asn1/h248/packet-h248-template.c - M /trunk/epan/dissectors/packet-h248.c + M /trunk/docbook/release-notes.xml -if exists call the h248term subdissector. +Update the RSVP entry. +------------------------------------------------------------------------ +r15600 | gerald | 2005-08-28 15:15:08 -0500 (Sun, 28 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-rsvp.c + +Correct an eariler infinite loop fix. Fixes bug 382. ------------------------------------------------------------------------ -r14716 | etxrab | 2005-06-20 15:15:33 -0500 (Mon, 20 Jun 2005) | 12 lines +r15599 | gerald | 2005-08-28 14:59:50 -0500 (Sun, 28 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-ansi_map.c -From Mike Duigou: +Add some length checks. Fixes bugs 381, 384, and 386. - In order to get filtering of conversations and -> endpoints to work from the endpoints and conversations windows I found -> it necessary to add a new AT_URI address type and a SAT_JXTA. This also -> necessitated a change to to_str.c to avoid a buffer overflow problem. -> Please review these changes carefully. -> -> Also includes some changes to the jxta dissector to fix filtering on -> generated fields and some changes to the types used for ints/unsigned ints. -> -> Fixes a bug with the processing of messages containing namespaces. ------------------------------------------------------------------------ -r14715 | etxrab | 2005-06-20 15:14:57 -0500 (Mon, 20 Jun 2005) | 12 lines +r15598 | guy | 2005-08-28 14:55:44 -0500 (Sun, 28 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/address.h - M /trunk/epan/to_str.c + M /trunk/wiretap/iptrace.c -From Mike Duigou: +Get rid of a no-longer-true comment. - In order to get filtering of conversations and -> endpoints to work from the endpoints and conversations windows I found -> it necessary to add a new AT_URI address type and a SAT_JXTA. This also -> necessitated a change to to_str.c to avoid a buffer overflow problem. -> Please review these changes carefully. -> -> Also includes some changes to the jxta dissector to fix filtering on -> generated fields and some changes to the types used for ints/unsigned ints. -> -> Fixes a bug with the processing of messages containing namespaces. ------------------------------------------------------------------------ -r14714 | etxrab | 2005-06-20 15:14:22 -0500 (Mon, 20 Jun 2005) | 12 lines +r15597 | etxrab | 2005-08-28 14:50:36 -0500 (Sun, 28 Aug 2005) | 5 lines Changed paths: - M /trunk/gtk/conversations_jxta.c - M /trunk/gtk/conversations_table.c - M /trunk/gtk/hostlist_jxta.c - M /trunk/gtk/hostlist_table.c - M /trunk/gtk/sat.h + M /trunk/epan/dissectors/packet-ber.c -From Mike Duigou: +From Graeme Lunt: + +b) dissect_ber_set() to report missing fields and handle untagged CHOICEs +c) dissect_ber_choice() to handle untagged CHOICEs (within the CHOICE) - In order to get filtering of conversations and -> endpoints to work from the endpoints and conversations windows I found -> it necessary to add a new AT_URI address type and a SAT_JXTA. This also -> necessitated a change to to_str.c to avoid a buffer overflow problem. -> Please review these changes carefully. -> -> Also includes some changes to the jxta dissector to fix filtering on -> generated fields and some changes to the types used for ints/unsigned ints. -> -> Fixes a bug with the processing of messages containing namespaces. ------------------------------------------------------------------------ -r14713 | gerald | 2005-06-20 14:35:58 -0500 (Mon, 20 Jun 2005) | 4 lines +r15596 | guy | 2005-08-28 14:28:04 -0500 (Sun, 28 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-afp.c - M /trunk/epan/dissectors/packet-ansi_637.c - M /trunk/epan/dissectors/packet-ansi_a.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-dcerpc-spoolss.c - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-iapp.c - M /trunk/epan/dissectors/packet-ncp2222.inc - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-rsvp.c - M /trunk/epan/dissectors/packet-slowprotocols.c - M /trunk/epan/proto.h - M /trunk/plugins/irda/packet-irda.c - M /trunk/plugins/profinet/packet-pn-dcp.c + M /trunk/epan/dissectors/packet-iax2.c -Fix a format string vulneratility in the AFP dissector identified -by iDEFENSE. Add constant format strings to proto_item_append_text() -in a bunch of other dissectors. Copy a comment from proto.c to proto.h. +Put back a subtraction of 1 millisecond that was lost. ------------------------------------------------------------------------ -r14712 | sahlberg | 2005-06-20 05:22:03 -0500 (Mon, 20 Jun 2005) | 5 lines +r15595 | guy | 2005-08-28 12:57:30 -0500 (Sun, 28 Aug 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-ber.c -convert the function -dissect_spnego_mechTypes() tu use the packet-ber api instead of the -asn1 api. +When creating subset tvbuffs, set the length to the minimum of the +desired reported length and the remaining length, so we don't throw an +exception at tvbuff creation time if we don't have all the desired data +- we want to throw the exception at dissection time, so we can dissect +the data we do have. +Use "tvb_ensure_bytes_exist()" to force exceptions to be thrown. + +When "dissect_unknown_ber()" is called from "call_ber_oid_callback()", +we're handing it a newly-created tvbuff, so the offset in that tvbuff +should be zero. ------------------------------------------------------------------------ -r14711 | sahlberg | 2005-06-20 04:43:29 -0500 (Mon, 20 Jun 2005) | 3 lines +r15594 | etxrab | 2005-08-28 10:02:38 -0500 (Sun, 28 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/Makefile.common -convert one function to use packet-ber instead of asn1 +Update the Makefile with GNM. +------------------------------------------------------------------------ +r15593 | etxrab | 2005-08-28 10:01:49 -0500 (Sun, 28 Aug 2005) | 1 line +Changed paths: + M /trunk/asn1/cmip/CMIP.asn + M /trunk/asn1/cmip/cmip.cnf + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmip.h +Co ordidnate CMIP abd GNM. +------------------------------------------------------------------------ +r15592 | etxrab | 2005-08-28 09:56:03 -0500 (Sun, 28 Aug 2005) | 1 line +Changed paths: + A /trunk/asn1/gnm + A /trunk/asn1/gnm/GNM.asn + A /trunk/asn1/gnm/Makefile.nmake + A /trunk/asn1/gnm/gnm.cnf + A /trunk/asn1/gnm/packet-gnm-template.c + A /trunk/asn1/gnm/packet-gnm-template.h + A /trunk/epan/dissectors/packet-gnm.c + A /trunk/epan/dissectors/packet-gnm.h +Add dissection of ITU M.3100 GNM (GENERIC NETWORK INFORMATION MODEL). ------------------------------------------------------------------------ -r14710 | sahlberg | 2005-06-20 02:18:10 -0500 (Mon, 20 Jun 2005) | 8 lines +r15591 | guy | 2005-08-28 01:44:06 -0500 (Sun, 28 Aug 2005) | 3 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/packet-tcap-template.h - M /trunk/epan/dissectors/packet-gsm_ss.c - M /trunk/epan/dissectors/packet-gsm_ss.h - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/libethereal.def + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h -move two functions that are not used by tcap and only used by gsm_a and gsm_ss into gsm_ss. +Export "bytestring_to_str()", and use it when adding the link-layer +address for the ND_OPT_TARGET_LINKADDR ICMPv6 packet type. -remove the include <epan.asn1.h> from tcap since it no longer needs that file. +------------------------------------------------------------------------ +r15590 | guy | 2005-08-28 01:41:49 -0500 (Sun, 28 Aug 2005) | 10 lines +Changed paths: + M /trunk/epan/dissectors/packet-kerberos.h -only 9 dissectors remain that use asn1.h +In at least some captures, some Kerberos packets contain just a Ticket +structure. Handle that. +Don't muck with the columns, or put a top-level Kerberos protocol item +into the protocol tree, until we decide that we really have a Kerberos +packet. +Do, however, clear the Info column if we're dissecting the Kerberos +protocol. ------------------------------------------------------------------------ -r14709 | sahlberg | 2005-06-20 00:28:56 -0500 (Mon, 20 Jun 2005) | 5 lines +r15589 | guy | 2005-08-28 01:40:59 -0500 (Sun, 28 Aug 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-gssapi.c - M /trunk/epan/dissectors/packet-gssapi.h M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-ntlmssp.c - M /trunk/epan/dissectors/packet-spnego.c -move one function only used by SPNEGO to packet-spnego.c +In at least some captures, some Kerberos packets contain just a Ticket +structure. Handle that. -remove the include of <epan/asn1.h> from kerberos, ntlmssp and gssapi since they no longer need to include that file. +Don't muck with the columns, or put a top-level Kerberos protocol item +into the protocol tree, until we decide that we really have a Kerberos +packet. +Do, however, clear the Info column if we're dissecting the Kerberos +protocol. ------------------------------------------------------------------------ -r14708 | sahlberg | 2005-06-19 23:44:39 -0500 (Sun, 19 Jun 2005) | 7 lines +r15588 | guy | 2005-08-28 01:38:30 -0500 (Sun, 28 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gssapi.c - M /trunk/epan/dissectors/packet-gssapi.h + M /trunk/epan/dissectors/packet-radiotap.c -convert gssapi to use packet-ber helpers instead of the asn1 ones. +Put the units after the values for signal and noise, as that's a bit +more natural. -once spnego is converted as well, the epan/asn1.h include can be removed from : -kerberos, spnego, gssapi and ntlmssp +------------------------------------------------------------------------ +r15587 | sahlberg | 2005-08-27 22:13:30 -0500 (Sat, 27 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ssh.c +add missing value_string termination ------------------------------------------------------------------------ -r14707 | sahlberg | 2005-06-19 21:37:42 -0500 (Sun, 19 Jun 2005) | 2 lines +r15586 | sahlberg | 2005-08-27 22:09:58 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/asn1/acse/packet-acse-template.c + M /trunk/epan/dissectors/packet-slowprotocols.c + M /trunk/epan/dissectors/packet-slsk.c + +add missing value_string termination -add Sids email as the original author of ACSE dissector ------------------------------------------------------------------------ -r14706 | guy | 2005-06-19 17:29:08 -0500 (Sun, 19 Jun 2005) | 4 lines +r15585 | sahlberg | 2005-08-27 22:05:53 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/ethereal_gen.py + M /trunk/epan/dissectors/packet-scsi.c -Get rid of the include of "snprintf.h", as g_snprintf()" should be used. +add missing value_string termination -Add _U_s to reduce the number of warnings. ------------------------------------------------------------------------ -r14705 | etxrab | 2005-06-19 16:16:04 -0500 (Sun, 19 Jun 2005) | 1 line +r15584 | sahlberg | 2005-08-27 22:01:37 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-rtcp.c + +add missing value_string termination + -Add some Cisco AVP:s ------------------------------------------------------------------------ -r14704 | etxrab | 2005-06-19 16:11:52 -0500 (Sun, 19 Jun 2005) | 2 lines +r15583 | sahlberg | 2005-08-27 21:56:24 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-radius_packetcable.c + +add missing value_string termination + -Update some OID:s and add some ASN1 code from ETSI TS 129 002 V5.7.0. -Will regenerate later. ------------------------------------------------------------------------ -r14703 | guy | 2005-06-19 14:17:15 -0500 (Sun, 19 Jun 2005) | 3 lines +r15582 | sahlberg | 2005-08-27 21:28:48 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/README.macos + M /trunk/asn1/inap/packet-inap-template.c + M /trunk/epan/dissectors/packet-inap.c + +add missing value_string termination -Add a note about the PNG, JPEG, and TIFF loaders not being usable (or -not easy to get to work) on Tiger. ------------------------------------------------------------------------ -r14702 | guy | 2005-06-19 14:08:37 -0500 (Sun, 19 Jun 2005) | 2 lines +r15581 | sahlberg | 2005-08-27 21:24:01 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/doc/idl2eth.pod + M /trunk/epan/dissectors/packet-icmpv6.c + +add missing value_string termination -Update URL for omniORB. ------------------------------------------------------------------------ -r14701 | jmayer | 2005-06-19 10:17:42 -0500 (Sun, 19 Jun 2005) | 1 line +r15580 | sahlberg | 2005-08-27 21:13:35 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h + M /trunk/epan/dissectors/packet-gprs-llc.c + +add missing value_string termination + -Fix trivial warning ------------------------------------------------------------------------ -r14700 | jmayer | 2005-06-19 10:16:30 -0500 (Sun, 19 Jun 2005) | 1 line +r15579 | sahlberg | 2005-08-27 21:06:40 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/packet.h + M /trunk/epan/dissectors/packet-dlsw.c + +add missing value_string terminator + -Warning fix: Declare some more strings const ------------------------------------------------------------------------ -r14699 | sahlberg | 2005-06-19 06:54:33 -0500 (Sun, 19 Jun 2005) | 8 lines +r15578 | sahlberg | 2005-08-27 20:57:13 -0500 (Sat, 27 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-acse.h + M /trunk/epan/dissectors/packet-cops.c -New autogenerated ACSE dissector. +value_strings are terminated with {0,NULL} not {0xff,NULL} -Note that the autogenerated dissector contains two bugs which i belive are asn2eth bugs. -This is why make copy_files does not work. -The comment at the top of the generated file explains which two changes one has to do manually after autogenerating the dissector, until asn2eth gets fixed. +------------------------------------------------------------------------ +r15577 | sahlberg | 2005-08-27 20:51:50 -0500 (Sat, 27 Aug 2005) | 5 lines +Changed paths: + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-camel.h + +another value_string that was not terminated + + +fix a bug from the previous checking as well. ------------------------------------------------------------------------ -r14698 | sahlberg | 2005-06-19 06:51:23 -0500 (Sun, 19 Jun 2005) | 7 lines +r15576 | sahlberg | 2005-08-27 20:44:30 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - A /trunk/asn1/acse - A /trunk/asn1/acse/Makefile - A /trunk/asn1/acse/Makefile.nmake - A /trunk/asn1/acse/acse.asn - A /trunk/asn1/acse/acse.cnf - A /trunk/asn1/acse/packet-acse-template.c - A /trunk/asn1/acse/packet-acse-template.h + M /trunk/epan/dissectors/packet-bootp.c + +add missing value_string termination -New autogenerated ACSE dissector. -There is a bug in ASN2ETH which means one can not do make copy_files -instead one needs to change two bugs in the generated code manually. -These two changes are in the comment at the top of the template/generated file +------------------------------------------------------------------------ +r15575 | sahlberg | 2005-08-27 20:42:51 -0500 (Sat, 27 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-bgp.c + +add missing value_string termination ------------------------------------------------------------------------ -r14697 | sahlberg | 2005-06-19 06:49:16 -0500 (Sun, 19 Jun 2005) | 3 lines +r15574 | sahlberg | 2005-08-27 20:35:29 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/epan/dissectors/packet-aim-messaging.c -register cmip as ber oid dissector +fix value_string termination ------------------------------------------------------------------------ -r14696 | sahlberg | 2005-06-19 06:47:59 -0500 (Sun, 19 Jun 2005) | 3 lines +r15573 | sahlberg | 2005-08-27 20:29:55 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-3g-a11.c -make cmip and ftam also register by ber oid so that they will work when the new ACSE goes in +add some missing value_string termination entries ------------------------------------------------------------------------ -r14695 | sahlberg | 2005-06-19 06:40:39 -0500 (Sun, 19 Jun 2005) | 3 lines +r15572 | guy | 2005-08-27 13:44:57 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-pres.c - M /trunk/epan/dissectors/packet-ses.h + M /trunk/epan/dissectors/packet-ber.c + +...and don't print a separating comma if you haven't already printed an +item. + +------------------------------------------------------------------------ +r15571 | guy | 2005-08-27 13:22:53 -0500 (Sat, 27 Aug 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-snmp.c -push one more object into the session structure so acse can pick it up later. +Use "free()", not "g_free()", to free strings allocated with "malloc()". +Don't free strings allocated with "ep_alloc()". ------------------------------------------------------------------------ -r14694 | lego | 2005-06-18 19:08:30 -0500 (Sat, 18 Jun 2005) | 5 lines +r15570 | guy | 2005-08-27 13:16:35 -0500 (Sat, 27 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-afp.c - M /trunk/epan/dissectors/packet-afp.h - M /trunk/epan/dissectors/packet-dsi.c + M /trunk/epan/dissectors/packet-ber.c + +If you don't print an "(", don't print a ")". + +------------------------------------------------------------------------ +r15569 | guy | 2005-08-27 13:15:42 -0500 (Sat, 27 Aug 2005) | 5 lines +Changed paths: + M /trunk/tethereal.c -from Didier Gautheron +Set the time stamp precision; we need it when printing packet summary +lines. -The new AFP 3.2 specification used by Apple OS X 10.4 +Clean up indentation. +------------------------------------------------------------------------ +r15568 | jmayer | 2005-08-27 10:11:00 -0500 (Sat, 27 Aug 2005) | 1 line +Changed paths: + M /trunk/make-manuf +Remove S/A from company names ------------------------------------------------------------------------ -r14693 | gerald | 2005-06-18 15:57:01 -0500 (Sat, 18 Jun 2005) | 2 lines +r15567 | jmayer | 2005-08-27 06:59:10 -0500 (Sat, 27 Aug 2005) | 1 line Changed paths: - M /trunk/epan/prefs.c + M /trunk/epan/dissectors/packet-extreme.c -Clear out any leftover preference information. Fix up whitespace. +Cosmectical comment updates +------------------------------------------------------------------------ +r15566 | jmayer | 2005-08-27 05:29:16 -0500 (Sat, 27 Aug 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-cisco-wireless.c +Small update to comments and beginnings of a type field ------------------------------------------------------------------------ -r14692 | jmayer | 2005-06-18 10:41:26 -0500 (Sat, 18 Jun 2005) | 1 line +r15565 | jmayer | 2005-08-27 04:21:41 -0500 (Sat, 27 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-telnet.c + M /trunk/manuf + M /trunk/manuf.tmpl -Partial fix for bug 191: Sanity check is ok now +Rename Cisco (00:40:96) back to Aironet ------------------------------------------------------------------------ -r14691 | jmayer | 2005-06-18 03:52:41 -0500 (Sat, 18 Jun 2005) | 1 line +r15564 | jmayer | 2005-08-27 01:10:08 -0500 (Sat, 27 Aug 2005) | 1 line Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-extreme.c -Add Dominik Kuhlen to AUTHORS +Typo ------------------------------------------------------------------------ -r14690 | jmayer | 2005-06-18 03:49:24 -0500 (Sat, 18 Jun 2005) | 3 lines +r15563 | jmayer | 2005-08-27 00:33:50 -0500 (Sat, 27 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-rmt-lct.c + M /trunk/colorfilters + M /trunk/epan/dissectors/packet-extreme.c + +- Add checksum verification +- Add checksum check to colorfilters -Dominik Kuhlen: Fix a copy/paste bug reported in - http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=211 ------------------------------------------------------------------------ -r14689 | lego | 2005-06-17 20:15:17 -0500 (Fri, 17 Jun 2005) | 5 lines +r15562 | jmayer | 2005-08-27 00:22:44 -0500 (Sat, 27 Aug 2005) | 11 lines Changed paths: M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-synergy.c + A /trunk/epan/dissectors/packet-cisco-wireless.c -from Vasanth Manickam +Started to decode some Cisco proprietary L2 protocol: -Synergy is a cross platform software which enables to easily share a single mouse and keyboard between multiple computers with different operating systems, each with its own display, without special hardware. Its listed on sourceforge (http://synergy2.sourceforge.net/). + * I couldn't find any documentation on this protocol. Neither + * what it's good for nor what the elements do. This is purely + * reverse engineered by looking at the hex dump of the packets. + * + * TODO + * - Find out more about unknown fields + * - Currently only one type of packet is really handled at all ------------------------------------------------------------------------ -r14688 | lego | 2005-06-17 20:09:04 -0500 (Fri, 17 Jun 2005) | 3 lines +r15561 | jmayer | 2005-08-27 00:17:35 -0500 (Sat, 27 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-k12.c - -- Use report_error and Co. to report errors + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/etypes.h + M /trunk/oui.h +Add classification of an aironet proprietary L2 protocol +in both, Ethernet V2 and IEEE802.3 SNAP packets. ------------------------------------------------------------------------ -r14687 | jmayer | 2005-06-17 19:10:59 -0500 (Fri, 17 Jun 2005) | 1 line +r15560 | jmayer | 2005-08-27 00:13:42 -0500 (Sat, 27 Aug 2005) | 4 lines Changed paths: - M /trunk/Makefile.am + M /trunk/FAQ + M /trunk/help/faq.txt + M /trunk/manuf + M /trunk/wka.tmpl + +- Update wka.tmpl with two Extreme MAC addresses +- Update manuf +- Update faq -Remove a leftover dummy list ------------------------------------------------------------------------ -r14686 | tuexen | 2005-06-17 16:02:40 -0500 (Fri, 17 Jun 2005) | 2 lines +r15559 | sahlberg | 2005-08-26 21:17:18 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/dissectors/packet-nbns.c + +remove the last remaining sprintf in epan/dissectors -Add support for draft-ietf-tsvwg-sctp-auth-00.txt. ------------------------------------------------------------------------ -r14685 | gerald | 2005-06-17 13:41:02 -0500 (Fri, 17 Jun 2005) | 5 lines +r15558 | sahlberg | 2005-08-26 20:19:12 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/colorfilters + M /trunk/epan/dissectors/packet-kerberos.c + +removal of sprintf -Tweak the global coloring rules a bit. Give "normal" traffic pastel -backgrounds and "bad" traffic bold backgrounds, which is the strategy -used in some of the sample coloring rules. Include a few rules from -the samples as well. ------------------------------------------------------------------------ -r14684 | lego | 2005-06-17 12:37:10 -0500 (Fri, 17 Jun 2005) | 4 lines +r15557 | sahlberg | 2005-08-26 20:11:02 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sscop.c - M /trunk/epan/dissectors/packet-sscop.h + M /trunk/epan/dissectors/packet-ranap.c -- fix a bug I introduced by copy pasting an incorrect offset of some items -- prepare the tap +sprintf removal ------------------------------------------------------------------------ -r14683 | lego | 2005-06-17 12:33:48 -0500 (Fri, 17 Jun 2005) | 3 lines +r15556 | sahlberg | 2005-08-26 20:05:14 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-radius.c -Register the dtap dissector by name. +sprintf removal ------------------------------------------------------------------------ -r14682 | lego | 2005-06-17 12:26:43 -0500 (Fri, 17 Jun 2005) | 4 lines +r15555 | sahlberg | 2005-08-26 19:58:55 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-k12.c - M /trunk/wiretap/file_access.c - M /trunk/wiretap/k12.c - M /trunk/wiretap/k12.h - M /trunk/wiretap/wtap-int.h + M /trunk/epan/dissectors/packet-nbns.c -- Write rf5 files (I don't think tektronix software will be able to read these, ethereal does) -- change k12.atm.vci and k12.atm.vpi into atm.vci and atm.vpi +remove one sprintf ------------------------------------------------------------------------ -r14681 | jmayer | 2005-06-17 12:12:12 -0500 (Fri, 17 Jun 2005) | 1 line +r15554 | sahlberg | 2005-08-26 19:48:22 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/FAQ - M /trunk/help/faq.txt + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + +sprintf removal + -Update FAQ ------------------------------------------------------------------------ -r14680 | jmayer | 2005-06-17 12:10:21 -0500 (Fri, 17 Jun 2005) | 1 line +r15553 | sahlberg | 2005-08-26 19:44:47 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/manuf + M /trunk/epan/dissectors/packet-icmpv6.c + +sprintf removal + -Update manuf ------------------------------------------------------------------------ -r14679 | gerald | 2005-06-17 10:03:26 -0500 (Fri, 17 Jun 2005) | 2 lines +r15552 | sahlberg | 2005-08-26 19:40:23 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/doc/README.developer + M /trunk/epan/dissectors/packet-fcels.c + +sprintf removals -Add a note about fuzz testing. ------------------------------------------------------------------------ -r14678 | ulfl | 2005-06-17 02:57:41 -0500 (Fri, 17 Jun 2005) | 1 line +r15551 | ulfl | 2005-08-26 19:37:48 -0500 (Fri, 26 Aug 2005) | 5 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/config.nmake + +bump up the wiretap.dll version from 0.2 to 0.3 as I've recently changed the wiretap API in an incompatible way -fix a typo in the usage output +the timestamps now contain nseconds instead of microseconds and there's a new function added. + +Is there a similar place for the Unix builds where this version has to be changed too? ------------------------------------------------------------------------ -r14677 | ulfl | 2005-06-17 02:56:27 -0500 (Fri, 17 Jun 2005) | 1 line +r15550 | sahlberg | 2005-08-26 19:25:32 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/editcap.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-fw1.c + +sprintf removal + -the -E probability parameter was missing in the usage summary ------------------------------------------------------------------------ -r14676 | ulfl | 2005-06-16 20:28:41 -0500 (Thu, 16 Jun 2005) | 1 line +r15549 | sahlberg | 2005-08-26 19:10:02 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/docbook/eug_src/EUG_app_tools.xml + M /trunk/epan/dissectors/packet-ieee80211.c + +sprintf big fix + -updated to latest Ethereal GUI ------------------------------------------------------------------------ -r14675 | ulfl | 2005-06-16 20:27:52 -0500 (Thu, 16 Jun 2005) | 1 line +r15548 | sahlberg | 2005-08-26 19:09:19 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_customize.xml + M /trunk/epan/dissectors/packet-ip.c + +some sprintf removals + -updated to latest Ethereal GUI ------------------------------------------------------------------------ -r14674 | ulfl | 2005-06-16 18:27:57 -0500 (Thu, 16 Jun 2005) | 1 line +r15547 | ulfl | 2005-08-26 18:13:43 -0500 (Fri, 26 Aug 2005) | 1 line Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_statistics.xml - M /trunk/docbook/eug_src/EUG_chapter_work.xml + M /trunk/epan/dissectors/packet-clnp.c -updated to latest Ethereal GUI +show the list of reassembled COTP fragments as a toplevel tree item and show it only at the last packet (not in every packet involved) ------------------------------------------------------------------------ -r14673 | etxrab | 2005-06-16 17:07:38 -0500 (Thu, 16 Jun 2005) | 1 line +r15546 | sahlberg | 2005-08-26 18:05:38 -0500 (Fri, 26 Aug 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-tcp.c + +There will be a lot of tcp_unacked data structures we only need to keep +around until they have been acked. +Use a slab allocator for these structs so that we dont keep the structs around in memory longer than we need to. + + -Change "radius type" on some vendor AVP:s and add some more ones. ------------------------------------------------------------------------ -r14672 | etxrab | 2005-06-16 17:06:12 -0500 (Thu, 16 Jun 2005) | 1 line +r15545 | guy | 2005-08-26 14:44:30 -0500 (Fri, 26 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/sminmpec.c - M /trunk/epan/sminmpec.h + M /trunk/wiretap/airopeek9.c + +Fix indentation, and fix a comment. -Add some more vendors ------------------------------------------------------------------------ -r14671 | ulfl | 2005-06-16 16:51:17 -0500 (Thu, 16 Jun 2005) | 1 line +r15544 | guy | 2005-08-26 14:40:46 -0500 (Fri, 26 Aug 2005) | 7 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_advanced.xml + M /trunk/wiretap/erf.c + M /trunk/wiretap/erf.h + M /trunk/wiretap/etherpeek.c + M /trunk/wiretap/wtap-int.h + +Ethereal now requires 64-bit integer support, so get rid of the tests of +G_HAVE_GINT64. + +Get rid of the floating-point stuff in the Etherpeek Classic file +reading code, just use 64-bit integers. Fix up the calculation of the +nanoseconds portion of the time stamp. -updated to latest Ethereal GUI ------------------------------------------------------------------------ -r14670 | ulfl | 2005-06-16 16:34:06 -0500 (Thu, 16 Jun 2005) | 1 line +r15543 | gerald | 2005-08-26 14:01:58 -0500 (Fri, 26 Aug 2005) | 2 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_io.xml + M /trunk/docbook/release-notes.xml + +Docbook isn't HTML. Use <ulink> instead of <a>. -add ChIOExportCSVDialog section, docbook validation should work again ------------------------------------------------------------------------ -r14669 | ulfl | 2005-06-16 16:19:50 -0500 (Thu, 16 Jun 2005) | 1 line +r15542 | ulfl | 2005-08-26 13:42:12 -0500 (Fri, 26 Aug 2005) | 1 line Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_io.xml - M /trunk/docbook/eug_src/EUG_chapter_use.xml + M /trunk/epan/dissectors/packet-clnp.c -add a "file sets" section and fix a link to it +don't use -1 if the remaining length (the fragment length) is actually zero, this will throw an Exception ------------------------------------------------------------------------ -r14668 | etxrab | 2005-06-16 16:19:37 -0500 (Thu, 16 Jun 2005) | 1 line +r15541 | gerald | 2005-08-26 10:47:32 -0500 (Fri, 26 Aug 2005) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/docbook/release-notes.xml + +Add an item about ip.checksum_bad's new behavior. Update the WinPcap +installer notes. -Add Paul Ollis ------------------------------------------------------------------------ -r14667 | etxrab | 2005-06-16 16:16:23 -0500 (Thu, 16 Jun 2005) | 16 lines +r15540 | gerald | 2005-08-26 10:46:53 -0500 (Fri, 26 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/asn1/h225/packet-h225-template.h + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h -From Paul Ollis: - epan/dissectors/packet-sigcomp.c - -------------------------------- +Make sure the size of dialedDigits matches the ASN.1 definition. - Function dissect_sigcomp: +------------------------------------------------------------------------ +r15539 | gerald | 2005-08-26 10:45:31 -0500 (Fri, 26 Aug 2005) | 8 lines +Changed paths: + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/emem.c - 1. Make sure the temporary buffer that is used to load byte-code from - state is zeroed, since the function udvm_state_access implicitly - relies on this. +Add a pair of #defines to emem.c that make ep_alloc() and se_alloc() +use individual g_malloc() calls instead of memchunks. This lets us use +tools like Valgrind and ElectricFence to find bugs. - 2. Pass the SigComp message header length, state length and partial - state length to decompress_sigcomp_message. +In the H.245 dissector, set h245_pi to NULL after we're done with +it so that we don't go stomping through our memchunks with muddy +boots later on. Fixes the current Buildbot menagerie failure. - 3. Removed the state_vars_valid parameter from calls to - udvm_state_access. +------------------------------------------------------------------------ +r15538 | kukosa | 2005-08-26 07:15:49 -0500 (Fri, 26 Aug 2005) | 1 line +Changed paths: + M /trunk/asn1/h225/packet-h225-template.c +time resolution changes from packet-h225.c moved to packet-h225-template.c ------------------------------------------------------------------------ -r14666 | etxrab | 2005-06-16 16:15:12 -0500 (Thu, 16 Jun 2005) | 115 lines +r15537 | guy | 2005-08-25 20:31:32 -0500 (Thu, 25 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/sigcomp-udvm.c - M /trunk/epan/sigcomp-udvm.h - M /trunk/epan/sigcomp_state_hdlr.c - M /trunk/epan/sigcomp_state_hdlr.h + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmip.h -From Paul Ollis: - epan/sigcomp_state_hdlr.c epan/sigcomp_state_hdlr.h - --------------------------------------------------- +Dissectors registered with "register_ber_oid_dissector()" return void. - Function udvm_state_access: +Fix the spelling of "attribute". - 1. Removed the state_vars_valid parameter. It is no longer used. +------------------------------------------------------------------------ +r15536 | ulfl | 2005-08-25 19:59:07 -0500 (Thu, 25 Aug 2005) | 1 line +Changed paths: + M /trunk/packaging/nsis/ethereal.nsi - 2. The function now correctly updates each of state_length, - state_address and state_instruction with saved state value. +fix #339: don't try to install WinPcap with a silent installer +------------------------------------------------------------------------ +r15535 | ulfl | 2005-08-25 19:01:49 -0500 (Thu, 25 Aug 2005) | 4 lines +Changed paths: + M /trunk/colorfilters + M /trunk/packaging/nsis/ethereal.nsi - [Previously this was only done for state referenced in the SigComp - message header.] +fix #378: +use "ip.checksum_bad == 1" instead of simply "ip.checksum_bad" in the example colorfilter file, as the implementation of that filter string changed - 3. Removed code that (incorrectly) read byte_copy_left from UDVM memory - within the loop that writes the state to UDVM memory. +install the global example files unconditionally by the win32 installer, to fix this problem and be compatible with the unix install process +------------------------------------------------------------------------ +r15534 | ulfl | 2005-08-25 16:29:54 -0500 (Thu, 25 Aug 2005) | 6 lines +Changed paths: + M /trunk/cfile.h + M /trunk/dftest.c + M /trunk/epan/column-utils.c + M /trunk/epan/column.c + M /trunk/epan/libethereal.def + M /trunk/epan/timestamp.c + M /trunk/epan/timestamp.h + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h + M /trunk/file.c + M /trunk/gtk/main.c + M /trunk/gtk/menu.c + M /trunk/gtk/packet_list.c + M /trunk/gtk/recent.c + M /trunk/gtk/recent.h + M /trunk/tethereal.c + M /trunk/wiretap/5views.c + M /trunk/wiretap/airopeek9.c + M /trunk/wiretap/ascend.c + M /trunk/wiretap/cosine.c + M /trunk/wiretap/csids.c + M /trunk/wiretap/dbs-etherwatch.c + M /trunk/wiretap/erf.c + M /trunk/wiretap/etherpeek.c + M /trunk/wiretap/eyesdn.c + M /trunk/wiretap/hcidump.c + M /trunk/wiretap/i4btrace.c + M /trunk/wiretap/iptrace.c + M /trunk/wiretap/k12.c + M /trunk/wiretap/lanalyzer.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/netmon.c + M /trunk/wiretap/nettl.c + M /trunk/wiretap/network_instruments.c + M /trunk/wiretap/netxray.c + M /trunk/wiretap/ngsniffer.c + M /trunk/wiretap/pppdump.c + M /trunk/wiretap/radcom.c + M /trunk/wiretap/snoop.c + M /trunk/wiretap/toshiba.c + M /trunk/wiretap/visual.c + M /trunk/wiretap/vms.c + M /trunk/wiretap/wtap-int.h + M /trunk/wiretap/wtap.h - 4. Removed the code that set the useful values in UDVM memory. This - should only be done for state referenced in the SigComp message - header. (The decompress_sigcomp_message function, sets the useful - values.) +timestamp display precision: +- automatic adjustment depending on file format +- manual adjustment through menu items + +save the setting in the recent file +------------------------------------------------------------------------ +r15533 | etxrab | 2005-08-25 16:25:52 -0500 (Thu, 25 Aug 2005) | 1 line +Changed paths: + M /trunk/asn1/cmip/CMIP.asn + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmip.h - epan/sigcomp-udvm.c epan/sigcomp-udvm.h - --------------------------------------- +Fix malformed packet if linkedId is present dissect some OID:s +------------------------------------------------------------------------ +r15532 | ulfl | 2005-08-25 16:01:42 -0500 (Thu, 25 Aug 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-llc.c + M /trunk/oui.h - Function decompress_sigcomp_message: +add OUI's for Siemens and Xerox (and a hyperlink to the IEEE page) +------------------------------------------------------------------------ +r15531 | etxrab | 2005-08-25 14:23:15 -0500 (Thu, 25 Aug 2005) | 12 lines +Changed paths: + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/sigcomp-udvm.c + M /trunk/epan/sigcomp-udvm.h - 1. Added three new parameters; header_len, byte_code_state_len, - byte_code_id_len. The byte_code_state_len and byte_code_id_len - are used to set the useful values in UDVM memory. The - header_len is required to calculate the cycles available - for decompression. +From Timo Metsala +Changes: - 2. Various minor corrections to spellings, etc in generated - messages. +o Implemented CRC and SHA-1 (sort operations are still missing) - 3. Reduced the number of lines of output for print_level_1. Now - the execution trace shows the instruction name and parameter - values on one line. +o After state acccess, the execution start is not necessarily the + beginning of the bytecode; start IP is now a new parameter to + decompress_sigcomp_message() - [This was done because, we found that even at the lowest - level of detail ethereal became unusably slow; running on - a 500 MHz SPARC. This seems to be related to the number of - lines produced by the SigComp trace, which can easily be over - 1000 with the modified code.] +o Removed some hard-coded assumptions about bytecode starting at offset + 128 - 4. Removed the used of some floating point functions. In all - cases they were unnecessary and could potentially cause the - code to produce the wrong results on some platforms (although - this is unlikely). +------------------------------------------------------------------------ +r15530 | lego | 2005-08-25 10:48:28 -0500 (Thu, 25 Aug 2005) | 3 lines +Changed paths: + M /trunk/gtk/stats_tree_stat.c + M /trunk/tap-stats_tree.c - 5. The useful values are now set correctly, using the new - byte_code_state_len and byte_code_id_len parameters. +http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=377 - 6. The message header length is now included in the calculation of - maximum_UDVM_cycles. Previously, the calculation could underestimate - the value, resulting in the (small) chance that some legitimate - messages might fail to decompress. - Note: The calculation might now slightly over-estimate the cycles - but this is a reasonable thing to do. +------------------------------------------------------------------------ +r15529 | gerald | 2005-08-25 08:58:34 -0500 (Thu, 25 Aug 2005) | 3 lines +Changed paths: + M /trunk/gtk/conversations_table.c - 7. Implemented the PUSH, POP, CALL and RETURN instructions. +Fix sorting in the "Ports" columns. Add a comment about address sorting. +Remove unused code. - Note: The two SORT instructions and the CRC and SHA-1 instructions - are still not implemented. +------------------------------------------------------------------------ +r15528 | guy | 2005-08-25 03:16:08 -0500 (Thu, 25 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-radiotap.c - 8. The COPY and COPY-LITERAL instructions now apply the - byte-copying-rules to the source address as well as the destination - address. +Show dBm and dB signal and noise values differently, so that the user +knows what they're getting. - 9. The COPY-LITERAL and COPY-OFFSET now correctly handle the - destination operand. Previously, it was possible for the destination - to be left at byte_copy_right when it should be left at - byte_copy_left. +------------------------------------------------------------------------ +r15527 | sahlberg | 2005-08-25 02:45:57 -0500 (Thu, 25 Aug 2005) | 8 lines +Changed paths: + M /trunk/epan/dissectors/packet-nbns.c - 10. All three COPY instructions will now behave correctly if the source - or destination start at byte_copy_right; i.e. they read/write to - byte_copy_right, byte_copy_right+1, etc. Previously the parameters - would wrap to byte_copy_left. +when tracking PDU bondaries, only do this IFF +the next few bytes match an SMB header. - 11. The COPY-OFFSET instruction now correctly calculates the source - address for all values of offset. Previously a very large offset - (greater than the circular buffer size) could cause the starting - position to be mis-calculated. +1, SMB is the only important protocol transported atop NBSS +2, if we miss the first packets of a PDU, we DONT! want nbns to suddenly think there are Xmegabytes until the end of it and thus prevent any real PDUs from being dissected. - 12. Modulo 65536 arithmetic has been added in some places where it was - missing. - [Only when noticed, we have not been able to check all the code.] - 13. Some redundant code was removed for the INPUT-BITS instruction. - Also, INPUT-BITS (0, x, x) now correctly discards spare bits when - the P-bit, has changed. +------------------------------------------------------------------------ +r15526 | guy | 2005-08-24 22:43:16 -0500 (Wed, 24 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-spnego.c - 14. Corrected the cycles used calculation for the INPUT-BITS - instruction. +I missed one OID string. - 15. Corrected some minor cases where the used_udvm_cycles was not - incremented. +------------------------------------------------------------------------ +r15525 | guy | 2005-08-24 22:31:54 -0500 (Wed, 24 Aug 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-spnego.c - [Not really a problem, but it allowed us to verify correctness with - some of the SigComp torture tests.] +The OID strings returned by new_format_oid(), and the OID string +returned by format_oid(), are allocated with the ep_alloc routines; +don't free them. - 16. Removed some redundant code in INPUT-HUFFMAN (and reorganised some - comments to keep them making sense). +------------------------------------------------------------------------ +r15524 | guy | 2005-08-24 22:28:31 -0500 (Wed, 24 Aug 2005) | 10 lines +Changed paths: + M /trunk/epan/dissectors/packet-snmp.c +"sprint_realloc_objid()" expects to be handled a malloced buffer, so +hand it one (and check for malloc failures), and it returns a malloced +or realloced buffer, so free it when we're done. - Function decomp_dispatch_get_bits: +That means that routines that use it can return/supply back a null +pointer, so check for that. - 1. This has been rewritten. The original version could not correctly - handle requests for more than 8 bits. The new version is cleaner and - correctly handles all cases. +Don't ep_allocate fixed-length buffers for formatted OID information, +allocate one that's 'big enough". ------------------------------------------------------------------------ -r14665 | ulfl | 2005-06-16 15:27:55 -0500 (Thu, 16 Jun 2005) | 1 line +r15523 | guy | 2005-08-24 20:16:40 -0500 (Wed, 24 Aug 2005) | 5 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_capture.xml - M /trunk/docbook/eug_src/EUG_chapter_io.xml + M /trunk/gtk/main.c + +The "secs" field of a "struct wtap_nstime" is a time_t, so it could be +an int or it could be a long; print stuff computed from it with %lu, and +cast the arguments to "long" so that it works on platforms where time_t +*isn't* a long and where "long int" and "int" have different sizes. -updated to latest Ethereal GUI ------------------------------------------------------------------------ -r14664 | gerald | 2005-06-16 14:51:14 -0500 (Thu, 16 Jun 2005) | 2 lines +r15522 | guy | 2005-08-24 18:53:40 -0500 (Wed, 24 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-smpp.c + M /trunk/randpkt.c -Fix Win32 compilation, broken by yesterday's checkin. +The time stamp in a Wiretap packet header is now a wtap_nstime, not a +"struct timeval". ------------------------------------------------------------------------ -r14663 | jmayer | 2005-06-16 12:23:34 -0500 (Thu, 16 Jun 2005) | 3 lines +r15521 | ulfl | 2005-08-24 17:27:21 -0500 (Wed, 24 Aug 2005) | 1 line Changed paths: - M /trunk/epan/proto.h - M /trunk/epan/value_string.h - -Get rid of several megabytes worth of warnings about -"discards qualifier from assignment". + M /trunk/editcap.c +fix usec -> nsec translation ------------------------------------------------------------------------ -r14662 | guy | 2005-06-16 05:06:22 -0500 (Thu, 16 Jun 2005) | 4 lines +r15520 | ulfl | 2005-08-24 16:31:56 -0500 (Wed, 24 Aug 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-k12.c + M /trunk/capinfos.c + M /trunk/cfile.h + M /trunk/epan/column-utils.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-afs.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/dissectors/packet-nlm.c + M /trunk/epan/dissectors/packet-rlogin.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtcp.h + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/frame_data.h + M /trunk/epan/h225-persistentdata.c + M /trunk/epan/libethereal.def + M /trunk/epan/nstime.c + M /trunk/epan/nstime.h + M /trunk/epan/stats_tree.c + M /trunk/epan/stats_tree_priv.h + M /trunk/file.c + M /trunk/gtk/file_dlg.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/main.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/packet_list.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/service_response_time_table.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls.c + M /trunk/merge.c + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mgcp/packet-mgcp.c + M /trunk/proto_hier_stats.c + M /trunk/summary.c + M /trunk/tap-afpstat.c + M /trunk/tap-dcerpcstat.c + M /trunk/tap-iostat.c + M /trunk/tap-mgcpstat.c + M /trunk/tap-rpcprogs.c + M /trunk/tap-rpcstat.c + M /trunk/tap-smbstat.c + M /trunk/tethereal.c + M /trunk/timestats.c + M /trunk/wiretap/5views.c + M /trunk/wiretap/airopeek9.c + M /trunk/wiretap/ascend.c + M /trunk/wiretap/cosine.c + M /trunk/wiretap/csids.c + M /trunk/wiretap/dbs-etherwatch.c + M /trunk/wiretap/erf.c + M /trunk/wiretap/etherpeek.c + M /trunk/wiretap/eyesdn.c + M /trunk/wiretap/file_access.c + M /trunk/wiretap/hcidump.c + M /trunk/wiretap/i4btrace.c + M /trunk/wiretap/iptrace.c + M /trunk/wiretap/k12.c + M /trunk/wiretap/lanalyzer.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/netmon.c + M /trunk/wiretap/nettl.c + M /trunk/wiretap/network_instruments.c + M /trunk/wiretap/netxray.c + M /trunk/wiretap/ngsniffer.c + M /trunk/wiretap/pppdump.c + M /trunk/wiretap/radcom.c + M /trunk/wiretap/snoop.c + M /trunk/wiretap/toshiba.c + M /trunk/wiretap/visual.c + M /trunk/wiretap/vms.c + M /trunk/wiretap/wtap-int.h + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.def + M /trunk/wiretap/wtap.h -Remove unused variable. +EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry! -Clean up indentation. +I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ... ------------------------------------------------------------------------- -r14661 | guy | 2005-06-16 05:05:23 -0500 (Thu, 16 Jun 2005) | 4 lines -Changed paths: - M /trunk/gtk/hostlist_jxta.c +What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere. -Get rid of unnecessary assignment and unnecessary "volatile" qualifier. +As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon. -Mark unused parameter as such. +Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way... +As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number... ------------------------------------------------------------------------ -r14660 | guy | 2005-06-16 04:58:01 -0500 (Thu, 16 Jun 2005) | 3 lines +r15519 | gerald | 2005-08-24 15:34:15 -0500 (Wed, 24 Aug 2005) | 4 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-rtcp.c -From Peter Kovar: fix an incorrect assignment that caused a compilation -error with GCC 4. +Properly initialize our hf_ arrays. Make hf_rtcp_app_poc1_conn_session_type +an FT_UINT8 instead of an FT_BOOLEAN. This keeps the Solaris builder from +crashing while running "-G values". ------------------------------------------------------------------------ -r14659 | guy | 2005-06-16 03:10:13 -0500 (Thu, 16 Jun 2005) | 5 lines +r15518 | ulfl | 2005-08-24 13:35:54 -0500 (Wed, 24 Aug 2005) | 1 line Changed paths: - M /trunk/wiretap/netxray.c - -Note that the WAN_CAPTYPE value of 4 can correspond to Cisco HDLC -traffic as well as Frame Relay traffic, and give some information about -the cruft found in the xxc field of the header for one CHDLC and one FR -capture. + M /trunk/epan/column_info.h +fix a comment typo ------------------------------------------------------------------------ -r14658 | guy | 2005-06-16 02:46:03 -0500 (Thu, 16 Jun 2005) | 20 lines +r15517 | sahlberg | 2005-08-24 02:28:28 -0500 (Wed, 24 Aug 2005) | 6 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h + M /trunk/gtk/graph_analysis.c -Clean up white space. +From Graeme Hewson -Register "standard" and "lock_info_col" as obsolete preferences, so -they're silently ignored rather than triggering warnings. +Fix for infinite loop of configure events that were present for early GTK 2.4 in addition to 2.2 -Propagate changes to check for "dissect_ber_octet_string()" supplying a -null tvbuff pointer from the checkins to the generated dissector ("Do -not modify this file" means "Do not modify this file"!) to the tcap.cnf -file, so that they're not lost if the dissector is regenerated. (Don't -propagate the checks for "tvb_new_subset()" returning null - it never -returns null.) -Pass -1 to "tvb_new_subset()" when appropriate. -When looping over packet data, check against the reported length, not -the captured length, so we indicate a short frame if we get stopped by -the snapshot length. +------------------------------------------------------------------------ +r15516 | guy | 2005-08-23 03:49:57 -0500 (Tue, 23 Aug 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-extreme.c -Get rid of unused variables. +The name in a Display TLV is null-terminated (or padded with a null byte +and extra crud). + +Don't bother with length checking on the VLAN name item - if it's +zero-length, so be it. ------------------------------------------------------------------------ -r14657 | guy | 2005-06-16 01:50:20 -0500 (Thu, 16 Jun 2005) | 3 lines +r15515 | guy | 2005-08-23 03:34:19 -0500 (Tue, 23 Aug 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-extreme.c -Register "version" as an obsolete preference, so it's silently ignored, -rather than provoking a warning. +Use "format_text()" and "tvb_format_text()" when displaying strings. +(It's not necessary, or desirable, to use them when fetching strings.) + +When processing a VLAN TLV, check the length of the TLV, so we don't end +up running past the end of the TLV and getting a negative remaining +length. Append to the protocol tree item for the TLV, and the Info +column, as we dissect the VLAN ID and VLAN name fields. ------------------------------------------------------------------------ -r14656 | guy | 2005-06-16 01:41:28 -0500 (Thu, 16 Jun 2005) | 2 lines +r15514 | guy | 2005-08-23 03:01:46 -0500 (Tue, 23 Aug 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-ber.c -Don't hand a null pointer to a "%s" format. +Fix the parenthesization of an expression. ------------------------------------------------------------------------ -r14655 | guy | 2005-06-16 01:34:27 -0500 (Thu, 16 Jun 2005) | 2 lines +r15513 | lego | 2005-08-22 18:11:48 -0500 (Mon, 22 Aug 2005) | 8 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-k12.c + M /trunk/wiretap/k12.c + +Two fixes to tektronix k12 import: + +- it appears that there are more packet record types other than 0x00010020. + accept anything matching 0x00010020/28 as a packet record. + +- make the stack filename lowercase before comparing it so that capitalization is not an issue. -Fix a typo, and squelch a compiler warning. ------------------------------------------------------------------------ -r14654 | guy | 2005-06-16 01:33:49 -0500 (Thu, 16 Jun 2005) | 2 lines +r15512 | jmayer | 2005-08-22 12:48:17 -0500 (Mon, 22 Aug 2005) | 1 line Changed paths: - M /trunk/gtk/recent.c - -Include <ctype.h> to define/declare "isspace()". + M /trunk/epan/dissectors/packet-extreme.c +Length of string == lengt of element - headerlength ------------------------------------------------------------------------ -r14653 | guy | 2005-06-16 01:32:20 -0500 (Thu, 16 Jun 2005) | 2 lines +r15511 | etxrab | 2005-08-22 11:26:29 -0500 (Mon, 22 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-isup_thin.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-rtcp.c -"dissect_isup_thin()" is a new-style dissector; register it as such. +From Timo Metsala: +Updates the PoC floor control parsing to comply to the latest version of the +specification. ------------------------------------------------------------------------ -r14652 | guy | 2005-06-16 01:31:25 -0500 (Thu, 16 Jun 2005) | 2 lines +r15510 | etxrab | 2005-08-22 11:19:31 -0500 (Mon, 22 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-jxta.c - -Squelch some unitialized variable warnings. + M /trunk/asn1/gsmmap/GSMMAP.asn + M /trunk/asn1/gsmmap/gsm_map-exp.cnf + M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-gsm_map.c +Fix decoding of sendIdentificationArg/Res and ProvideSubscriberLocation ------------------------------------------------------------------------ -r14651 | guy | 2005-06-16 01:30:33 -0500 (Thu, 16 Jun 2005) | 6 lines +r15509 | guy | 2005-08-22 02:12:20 -0500 (Mon, 22 Aug 2005) | 13 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/libethereal.def + M /trunk/epan/nstime.c + M /trunk/epan/nstime.h + M /trunk/gtk/service_response_time_table.c + M /trunk/gtk/service_response_time_table.h + M /trunk/timestats.c + M /trunk/timestats.h -"proto_tree_add_text()" doesn't add a named field, so it takes no "hf_" -argument. +Add a "time_stat_init()" routine to initialize the fields of a +"timestat_t". -Report a non-integral type used with "dissect_per_integer()" with an -explicit "REPORT_DISSECTOR_BUG()" call, as that's a dissector bug. +Move "nstime_to_msec()" to "epan/nstime.c", as it has nothing to do with +a "timestat_t". + +Use structure assignment when possible. + +Fix the "addtime()" macro and use it in "time_stat_update()". + +Use "timestat_t"s, and the routines to manipulate them, in the service +response time table code. ------------------------------------------------------------------------ -r14650 | guy | 2005-06-16 01:28:50 -0500 (Thu, 16 Jun 2005) | 6 lines +r15508 | etxrab | 2005-08-22 00:49:09 -0500 (Mon, 22 Aug 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-ber.c -Include <ctype.h> to get "isdigit()" defined/declared. +From Graeme Lunt: + Zero length elements (e.g. an empty SET) the logic is slightly wrong in get_ber_length(). -"dissect_msrp()" is a "new-style" dissector; register it as such. +Make SET work. -Squelch an uninitialized variable warning. ------------------------------------------------------------------------ -r14649 | guy | 2005-06-16 01:27:18 -0500 (Thu, 16 Jun 2005) | 2 lines +r15507 | guy | 2005-08-21 18:24:20 -0500 (Sun, 21 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-kink.c + M /trunk/epan/libethereal.def -Squelch some compiler warnings. +Export get_timesum(). ------------------------------------------------------------------------ -r14648 | guy | 2005-06-16 01:19:03 -0500 (Thu, 16 Jun 2005) | 11 lines +r15506 | guy | 2005-08-21 16:50:49 -0500 (Sun, 21 Aug 2005) | 15 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-isakmp.c - A /trunk/epan/dissectors/packet-isakmp.h - M /trunk/epan/dissectors/packet-kink.c + M /trunk/gtk/service_response_time_table.c + +Use "g_strdup_printf()" rather than formatting into a fixed-length +buffer and "g_strdup()"ing it. -Static variables considered harmful. Make the ISAKMP version a -parameter to many functions inside the ISAKMP dissector, as well as to -the "isakmp_dissect_payloads()" routine it exports. Get rid of -"isakmp_set_version()", as the version can be passed to -"isakmp_dissect_payloads()" from the KINK dissector. +Use the nstime.c routines to compute time deltas and to add up times. -Put the declaration of "isakmp_dissect_payloads()" into a -"packet-isakmp.h" header, and have "packet-isakmp.c" and "packet-kink.h" -include it rather than declariing "isakmp_dissect_payloads()" itself - -or not doing so at all. +Don't add rows to the CList until a procedure gets a non-zero call +count, so only the ones with non-zero call counts are displayed (and +especially so that procedure numbers not corresponding to real +procedures aren't displayed!). + +Ethereal requires 64-bit integer support, so don't bother checking +whether we have it. + +Use the right format for 64-bit integers. ------------------------------------------------------------------------ -r14647 | guy | 2005-06-16 01:06:18 -0500 (Thu, 16 Jun 2005) | 2 lines +r15505 | jmayer | 2005-08-21 16:32:19 -0500 (Sun, 21 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-extreme.c -Regenerate - this squelches some compiler warnings. +- Make it possible to filter on eap.null, eap.info, eap.unknown etc +- Display "Info" instead of "System" in packet summary +- Make the Null element look like the other elements. +- Small element summary formatting changes ------------------------------------------------------------------------ -r14646 | lego | 2005-06-15 21:27:30 -0500 (Wed, 15 Jun 2005) | 5 lines +r15504 | guy | 2005-08-21 15:24:59 -0500 (Sun, 21 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-k12.c - M /trunk/wiretap/k12.c - M /trunk/wiretap/wtap.h - -third and last(?) iteration on the import routines for tektronix 32bit rf5 files. -Now the import is correct even for large files. -I found out when and where the "junk" was inserted. + M /trunk/gtk/ldap_stat.c +Use the tap_dfilter_dlg mechanism. ------------------------------------------------------------------------ -r14645 | ulfl | 2005-06-15 18:55:46 -0500 (Wed, 15 Jun 2005) | 1 line +r15503 | guy | 2005-08-21 15:16:12 -0500 (Sun, 21 Aug 2005) | 2 lines Changed paths: - M /trunk/docbook/Makefile - M /trunk/docbook/eug_src/EUG_chapter_use.xml - A /trunk/docbook/graphics/toolbar/autoscroll_24.png - D /trunk/docbook/graphics/toolbar/capture_24.png - A /trunk/docbook/graphics/toolbar/capture_filter_24.png - A /trunk/docbook/graphics/toolbar/capture_interfaces_24.png - A /trunk/docbook/graphics/toolbar/capture_options_24.png - A /trunk/docbook/graphics/toolbar/capture_restart_24.png - A /trunk/docbook/graphics/toolbar/capture_start_24.png - A /trunk/docbook/graphics/toolbar/capture_stop_24.png - D /trunk/docbook/graphics/toolbar/cfilter_24.png - A /trunk/docbook/graphics/toolbar/colorize_24.png - D /trunk/docbook/graphics/toolbar/dfilter_24.png - A /trunk/docbook/graphics/toolbar/display_filter_24.png - A /trunk/docbook/graphics/toolbar/resize_columns_24.png - M /trunk/docbook/user-guide.xml + M /trunk/gtk/fc_stat.c + +Use the tap_dfilter_dlg code. -update toolbar items and icons ------------------------------------------------------------------------ -r14644 | ulfl | 2005-06-15 18:05:37 -0500 (Wed, 15 Jun 2005) | 1 line +r15502 | jmayer | 2005-08-21 14:25:45 -0500 (Sun, 21 Aug 2005) | 7 lines Changed paths: - M /trunk/gtk/compat_macros.h + M /trunk/epan/dissectors/packet-extreme.c + +- In the info summary, port# and slot# were exchanged +- In the Display element, the length of the display string + was 4 too long +- Display the Vlan id in the packet summary, not just "Vlan" +- Remove trailing whitespace + -don't call "Capture/Start" Capture but Start in the toolbar ------------------------------------------------------------------------ -r14643 | gerald | 2005-06-15 17:56:23 -0500 (Wed, 15 Jun 2005) | 2 lines +r15501 | guy | 2005-08-21 14:24:11 -0500 (Sun, 21 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/gtk/Makefile.am + M /trunk/gtk/Makefile.common + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/conversations_eth.c + M /trunk/gtk/conversations_fc.c + M /trunk/gtk/conversations_fddi.c + M /trunk/gtk/conversations_ip.c + M /trunk/gtk/conversations_ipx.c + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_sctp.c + M /trunk/gtk/conversations_tcpip.c + M /trunk/gtk/conversations_tr.c + M /trunk/gtk/conversations_udpip.c + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/gsm_map_summary.c + D /trunk/gtk/gtk_stat_menu.h + D /trunk/gtk/gtk_stat_util.c + D /trunk/gtk/gtk_stat_util.h + A /trunk/gtk/gui_stat_menu.h (from /trunk/gtk/gtk_stat_menu.h:15499) + A /trunk/gtk/gui_stat_util.c (from /trunk/gtk/gtk_stat_util.c:15499) + A /trunk/gtk/gui_stat_util.h (from /trunk/gtk/gtk_stat_util.h:15499) + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_fc.c + M /trunk/gtk/hostlist_fddi.c + M /trunk/gtk/hostlist_ip.c + M /trunk/gtk/hostlist_ipx.c + M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/hostlist_tcpip.c + M /trunk/gtk/hostlist_tr.c + M /trunk/gtk/hostlist_udpip.c + M /trunk/gtk/hostlist_wlan.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/menu.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/tap_dfilter_dlg.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls_dlg.c -Handle FT_UINTs in dissect_per_integer(). Fixes bug 234. +As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so +that it doesn't appear to be part of GTK+. ------------------------------------------------------------------------ -r14642 | ulfl | 2005-06-15 17:47:20 -0500 (Wed, 15 Jun 2005) | 1 line +r15500 | etxrab | 2005-08-21 13:42:54 -0500 (Sun, 21 Aug 2005) | 12 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_use.xml + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-jxta.h + +From Mike Duigou: + +A patch to the JXTA dissector. It's purpose is to improve +the behaviour of the dissector when dissecting captures that do not +include the whole conversation. + +The dissector is now more capable of isolating a conversation without +seeing the beginning of the conversation. It's still not always able to +pick up all conversations (suggestions, patches and hints welcome). + +improved some of the doxygen docs and comments. -update various menu items (screenshots must be updated as well) ------------------------------------------------------------------------ -r14641 | ulfl | 2005-06-15 17:45:51 -0500 (Wed, 15 Jun 2005) | 1 line +r15499 | ulfl | 2005-08-21 10:23:48 -0500 (Sun, 21 Aug 2005) | 11 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_build_install.xml + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/proto.h + M /trunk/gtk/proto_draw.c + +The protocol item in the protocol tree will have a gray background now, which makes it much better visible. -minor editing +Add some more optional flags to the protocol items, so more "special cases" can be marked in the protocol tree. + +New flags: +/** The protocol field has a bad checksum */ +FI_CHECKSUM_ERROR +/** The protocol field has an unusual sequence (e.g. TCP window is zero) */ +FI_SEQUENCE_WARNING +/** The protocol field has a bad sequence (e.g. TCP segment is lost) */ +FI_SEQUENCE_ERROR ------------------------------------------------------------------------ -r14640 | gerald | 2005-06-15 17:08:43 -0500 (Wed, 15 Jun 2005) | 3 lines +r15498 | ulfl | 2005-08-21 10:13:47 -0500 (Sun, 21 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-browser.c - -Make sure dissect_browser_TYPE_12_data() returns the right value. Catch -integer overflows in that and other functions. Fixes bug 236. + M /trunk/epan/dissectors/packet-ip.c +as discussed some time ago: don't add bad checksum fields conditionally but use a subtree and use boolean flags instead ------------------------------------------------------------------------ -r14639 | gerald | 2005-06-15 16:42:30 -0500 (Wed, 15 Jun 2005) | 2 lines +r15497 | etxrab | 2005-08-21 08:52:33 -0500 (Sun, 21 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-smpp.c + M /trunk/asn1/gsmmap/gsmmap.cnf -Catch an infinite loop in smpp_handle_dlist(). Fixes bug 246. +remove sprintf from gsm_a +Do the update for the .cnf file too. ------------------------------------------------------------------------ -r14638 | gerald | 2005-06-15 16:33:48 -0500 (Wed, 15 Jun 2005) | 2 lines +r15496 | guy | 2005-08-21 06:09:36 -0500 (Sun, 21 Aug 2005) | 15 lines Changed paths: - M /trunk/epan/dissectors/packet-pagp.c + M /trunk/gtk/Makefile.am + M /trunk/gtk/afp_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/dlg_utils.h + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/stats_tree_stat.c + M /trunk/gtk/tap_dfilter_dlg.c + D /trunk/gtk/tap_dfilter_dlg.h + M /trunk/gtk/wsp_stat.c + M /trunk/tap_dfilter_dlg.h + +"gtk_tap_dfilter_dlg_cb()" is no longer used outside +gtk/tap_dfilter_dlg.c; don't export it. + +That means that gtk/tap_dfilter_dlg.h is no longer useful; get rid of +it. + +Rename "gtk_tap_dfilter_dlg_cb()" to "tap_dfilter_dlg_cb()", as it's +inside GTK+-specific code, so there's no need to distinguish it from +non-GTK+ callbacks. + +Update some comments to reflect the name change and the new API for +registering tap_dfilter_dlg stats. -Add missing hf entries. Fixes bug 240. +Make the AFP and SMB stats use the gtk/tap_dfilter_dlg.c stuff. ------------------------------------------------------------------------ -r14637 | gerald | 2005-06-15 15:55:11 -0500 (Wed, 15 Jun 2005) | 4 lines +r15495 | guy | 2005-08-21 05:29:47 -0500 (Sun, 21 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/tap_dfilter_dlg.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c -In sam_dissect_SAM_SECURITY_DESCRIPTOR_data(), throw an exception if we -fetch a too-long length. Fixes bug 236. +Have "register_dfilter_stat()" add "..." to the menu item, as all menu +items registered with it pop up a dialog box before displaying the stat. +Don't pass a name with "..." to it. +Put "..." into other menu items that pop up a dialog box before +displaying the stat; remove "..." from other menu items that don't. ------------------------------------------------------------------------ -r14636 | gerald | 2005-06-15 13:35:13 -0500 (Wed, 15 Jun 2005) | 3 lines +r15494 | guy | 2005-08-21 05:00:56 -0500 (Sun, 21 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-lmp.c + M /trunk/stat_menu.h -Fix a couple of infinite loops found by Buildbot. Were the recent -changes to this dissector fuzz tested at all? +Set properties. ------------------------------------------------------------------------ -r14635 | gerald | 2005-06-15 12:56:47 -0500 (Wed, 15 Jun 2005) | 3 lines +r15493 | guy | 2005-08-21 04:48:27 -0500 (Sun, 21 Aug 2005) | 14 lines Changed paths: - M /trunk/epan/dissectors/packet-csm-encaps.c + M /trunk/Makefile.common + M /trunk/epan/dissectors/packet-ansi_637.c + M /trunk/file.c + M /trunk/gtk/Makefile.am + M /trunk/gtk/afp_stat.c + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/conversations_eth.c + M /trunk/gtk/conversations_fc.c + M /trunk/gtk/conversations_fddi.c + M /trunk/gtk/conversations_ip.c + M /trunk/gtk/conversations_ipx.c + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_sctp.c + M /trunk/gtk/conversations_tcpip.c + M /trunk/gtk/conversations_tr.c + M /trunk/gtk/conversations_udpip.c + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/follow_dlg.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/gsm_map_summary.c + A /trunk/gtk/gtk_stat_menu.h (from /trunk/gtk/stat_menu.h:15480) + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_fc.c + M /trunk/gtk/hostlist_fddi.c + M /trunk/gtk/hostlist_ip.c + M /trunk/gtk/hostlist_ipx.c + M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/hostlist_tcpip.c + M /trunk/gtk/hostlist_tr.c + M /trunk/gtk/hostlist_udpip.c + M /trunk/gtk/hostlist_wlan.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/menu.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_byte_graph_dlg.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/gtk/sctp_error_dlg.c + M /trunk/gtk/sctp_graph_dlg.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + D /trunk/gtk/stat_menu.h + M /trunk/gtk/stats_tree_stat.c + M /trunk/gtk/tap_dfilter_dlg.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c + A /trunk/stat_menu.h + M /trunk/tap_dfilter_dlg.h + +Add a "register_dfilter_stat()", to register stats that take a display +filter as an argument on the command line and have a dialog box to enter +the display filter through the GUI. Use it for all stats using +"gtk_tap_dfilter_dlg_cb()". -Fix an infinite loop found by randpkt testing. Change the line endings from -DOS to UNIX. +Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E" +for the benefit of the declaration of "register_dfilter_stat()" in the +top-level "tap_dfilter_dlg.h". Rename the "stat_menu.h" in the gtk +directory to "gtk_stat_menu.h", so as not to have two headers with the +same name. + +Get rid of headers not declaring any functions not being used in the +module. ------------------------------------------------------------------------ -r14634 | gerald | 2005-06-15 10:10:02 -0500 (Wed, 15 Jun 2005) | 5 lines +r15492 | sahlberg | 2005-08-20 20:52:09 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/proto.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_a.h + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-uma.c -When we add an FT_STRINGZ item, throw an exception if the length is -less than -1. If the length is 0, set the item string to "[Empty]". -This fixes bug 219. +remove sprintf from gsm_a ------------------------------------------------------------------------ -r14633 | etxrab | 2005-06-14 17:01:55 -0500 (Tue, 14 Jun 2005) | 1 line +r15491 | sahlberg | 2005-08-20 20:14:43 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-cops.c + +remove gmalloc and sprintf + -Add Samuel Thibault ------------------------------------------------------------------------ -r14632 | etxrab | 2005-06-14 16:58:54 -0500 (Tue, 14 Jun 2005) | 2 lines +r15490 | sahlberg | 2005-08-20 19:55:46 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ymsg.c + M /trunk/epan/dissectors/packet-ansi_map.c + +remove sprintf + -From Samuel Thibault, -Some updates to the yahoo msg dissector. ------------------------------------------------------------------------ -r14631 | etxrab | 2005-06-14 16:57:17 -0500 (Tue, 14 Jun 2005) | 1 line +r15489 | guy | 2005-08-20 17:28:49 -0500 (Sat, 20 Aug 2005) | 11 lines Changed paths: - M /trunk/plugins/giop/Makefile.am + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/mtp3_stat.c + +The routines registered with "register_stat_cmd_arg()" *are* called if +you use the "-z" command-line options for them; make them pop up the +appropriate windows. + +Move the calls to "register_stat_cmd_arg()" after the code to register +the tap, just as the calls to "register_stat_menu_item()" are done after +registering the tap. + +Use "g_strdup_printf()" rather than formatting into a fixed-length +buffer and "g_strdup()"ing that buffer. -Correct a typo ------------------------------------------------------------------------ -r14630 | etxrab | 2005-06-14 16:48:42 -0500 (Tue, 14 Jun 2005) | 3 lines +r15488 | guy | 2005-08-20 17:26:32 -0500 (Sat, 20 Aug 2005) | 5 lines Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/rtp_stream.c -From Javier Acuna -patch to include Cic info in Voip Calls +We already have a tap that registers as a command-line stat under the +name "rtp"; we don't need another one, especially given that +"rtp_stream.c" doesn't directly implement a stat (note that it doesn't +register a menu item). ------------------------------------------------------------------------ -r14629 | etxrab | 2005-06-14 16:46:51 -0500 (Tue, 14 Jun 2005) | 1 line +r15487 | ulfl | 2005-08-20 17:16:12 -0500 (Sat, 20 Aug 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/capture_sync.c -Add vendor AVP:s for T-Mobile and T-Systems Nova International GmbH. +capture_sync.c(290) : warning C4090: 'function' : different 'const' qualifiers +capture_sync.c(290) : warning C4022: 'g_realloc' : pointer mismatch for actual parameter 1 +capture_sync.c(431) : warning C4090: 'function' : different 'const' qualifiers +capture_sync.c(431) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1 +capture_sync.c(442) : warning C4090: 'function' : different 'const' qualifiers +capture_sync.c(442) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1 +capture_sync.c(549) : warning C4090: 'function' : different 'const' qualifiers +capture_sync.c(549) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1 ------------------------------------------------------------------------ -r14628 | etxrab | 2005-06-14 16:45:29 -0500 (Tue, 14 Jun 2005) | 1 line +r15486 | sahlberg | 2005-08-20 17:15:39 -0500 (Sat, 20 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/sminmpec.c - M /trunk/epan/sminmpec.h + M /trunk/epan/dissectors/packet-ansi_637.c + +remove sprintf -Add Vendor ID of T-Mobile and T-Systems Nova International GmbH. ------------------------------------------------------------------------ -r14627 | gerald | 2005-06-14 13:18:05 -0500 (Tue, 14 Jun 2005) | 15 lines +r15485 | ulfl | 2005-08-20 17:08:35 -0500 (Sat, 20 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/packet-gtp.c - M /trunk/epan/dissectors/packet-isis-lsp.c - M /trunk/epan/dissectors/packet-ncp2222.inc - M /trunk/tools/lemon/lemon.c + M /trunk/epan/radius_dict.l -From Steve Grubb: +radius_dict.l(216) : warning C4090: 'function' : different 'const' qualifiers +radius_dict.l(216) : warning C4022: 'g_hash_table_insert' : pointer mismatch for actual parameter 2 +radius_dict.l(268) : warning C4090: 'function' : different 'const' qualifiers +radius_dict.l(268) : warning C4022: 'g_free' : pointer mismatch for actual parameter 1 +------------------------------------------------------------------------ +r15484 | sahlberg | 2005-08-20 17:06:31 -0500 (Sat, 20 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ajp13.c -Fix bounds checking in lemon.c. Fix up an if/else block in -packet-dcerpc-samr.c. Fix hex printing in packet-gtp.c. +removal of sprintf -Fix other problems discovered by Steve: +------------------------------------------------------------------------ +r15483 | guy | 2005-08-20 15:06:05 -0500 (Sat, 20 Aug 2005) | 4 lines +Changed paths: + M /trunk/epan/Makefile.common + D /trunk/epan/stat.c + D /trunk/epan/stat.h + A /trunk/epan/stat_cmd_args.c (from /trunk/epan/stat.c:15480) + A /trunk/epan/stat_cmd_args.h (from /trunk/epan/stat.h:15480) + M /trunk/gtk/afp_stat.c + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/conversations_eth.c + M /trunk/gtk/conversations_fc.c + M /trunk/gtk/conversations_fddi.c + M /trunk/gtk/conversations_ip.c + M /trunk/gtk/conversations_ipx.c + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_sctp.c + M /trunk/gtk/conversations_tcpip.c + M /trunk/gtk/conversations_tr.c + M /trunk/gtk/conversations_udpip.c + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_fc.c + M /trunk/gtk/hostlist_fddi.c + M /trunk/gtk/hostlist_ip.c + M /trunk/gtk/hostlist_ipx.c + M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/hostlist_tcpip.c + M /trunk/gtk/hostlist_tr.c + M /trunk/gtk/hostlist_udpip.c + M /trunk/gtk/hostlist_wlan.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/main.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/stats_tree_stat.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c + M /trunk/tap-afpstat.c + M /trunk/tap-ansi_astat.c + M /trunk/tap-bootpstat.c + M /trunk/tap-dcerpcstat.c + M /trunk/tap-gsm_astat.c + M /trunk/tap-h225counter.c + M /trunk/tap-h225rassrt.c + M /trunk/tap-httpstat.c + M /trunk/tap-iostat.c + M /trunk/tap-iousers.c + M /trunk/tap-mgcpstat.c + M /trunk/tap-protocolinfo.c + M /trunk/tap-protohierstat.c + M /trunk/tap-rpcprogs.c + M /trunk/tap-rpcstat.c + M /trunk/tap-sctpchunkstat.c + M /trunk/tap-sipstat.c + M /trunk/tap-smbsids.c + M /trunk/tap-smbstat.c + M /trunk/tap-stats_tree.c + M /trunk/tap-wspstat.c + M /trunk/tethereal.c -Fix a bounds check in packet-isis-lsp.c. Also, fix netmask printing -on non-little-endian machines. Add a comment about adding a netmask -routine to to_str.c. Add bounds checks to packet-ncp2222.inc. +Rename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with +implementing the "-z" command-line arguments, it doesn't deal with *all* +issues for stats. +------------------------------------------------------------------------ +r15482 | guy | 2005-08-20 14:49:22 -0500 (Sat, 20 Aug 2005) | 3 lines +Changed paths: + M /trunk/gtk/gui_utils.c + M /trunk/gtk/gui_utils.h -All of these apply to bug 217. +Explain in more detail the split between the stuff in ui_util.h and in +gtk/gui_utils.h. ------------------------------------------------------------------------ -r14626 | jmayer | 2005-06-14 09:33:55 -0500 (Tue, 14 Jun 2005) | 4 lines +r15481 | guy | 2005-08-20 14:45:53 -0500 (Sat, 20 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-wlancap.c + M /trunk/ui_util.h -Always skip the whole header: The current code would only decode -sizeof strcut wlan_header_v1 bytes, but if our struct was missing -some newer elements, things would go wrong. +Explain in more detail what this file is for. ------------------------------------------------------------------------ -r14625 | jmayer | 2005-06-14 08:35:24 -0500 (Tue, 14 Jun 2005) | 1 line +r15480 | guy | 2005-08-20 13:17:36 -0500 (Sat, 20 Aug 2005) | 8 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/asn1/acse/acse-exp.cnf + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/epan/dissectors/packet-acse.c + +There's no longer a need to individually remove items from +acse_ctx_oid_table - destroying the hash table will destroy the hash +table items, and the destroy function no longer has any work to do +because the OID strings are now allocated with se_strdup() (and thus get +freed when the capture is closed). + +Regenerate packet-acse.c, which also regenerates acse-exp.cnf. -No // comments ------------------------------------------------------------------------ -r14624 | gerald | 2005-06-13 17:40:11 -0500 (Mon, 13 Jun 2005) | 8 lines +r15479 | guy | 2005-08-20 13:01:07 -0500 (Sat, 20 Aug 2005) | 9 lines Changed paths: - M /trunk/clopts_common.c - M /trunk/epan/prefs.c + M /trunk/epan/dissectors/packet-ansi_map.c -Change read_prefs() to use GStrings instead of (re)allocating memory -ourselves. This fixes a potential off-by-one error found by Steve Grubb. +Flag the "add_string" parameter as unused if it is - and don't flag it +as such if it *is* used. Get rid of the "add_string" parameter to +"param_digits_basic", as that function *isn't* called through a pointer. -Add two new -G options: defaultprefs and currentprefs. The first dumps -the default preferences to stdout and the second dumps the user's prefs -to stdout. +Don't flag arguments in declarations as unused; you only do that in +definitions. +Clean up indentation. ------------------------------------------------------------------------ -r14623 | ulfl | 2005-06-13 15:04:09 -0500 (Mon, 13 Jun 2005) | 1 line +r15478 | guy | 2005-08-20 12:49:58 -0500 (Sat, 20 Aug 2005) | 7 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_introduction.xml + M /trunk/wiretap/ascend-grammar.y + +"ascend-grammar.h" is generated by Bison with a copy of the definition +of the YYSTYPE structure in "ascend-grammar.c"; the intent is that other +files include "ascend-grammar.h" if they need that structure, but that +"ascend-grammar.c" not itself include "ascend-grammar.h". If it *does* +include it, the compiler complains about YYSTYPE being redefined (even +though the two structures are identical). -the note about not sending sensitive information to the lists should really be a warning, not only a note ------------------------------------------------------------------------ -r14622 | ulfl | 2005-06-13 15:01:05 -0500 (Mon, 13 Jun 2005) | 1 line +r15477 | jmayer | 2005-08-20 11:30:23 -0500 (Sat, 20 Aug 2005) | 1 line Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_build_install.xml + M /trunk/gtk/Makefile.am -minor editing +And if we add a file, add it to Makefile.am as well ------------------------------------------------------------------------ -r14621 | lego | 2005-06-13 14:45:21 -0500 (Mon, 13 Jun 2005) | 3 lines +r15476 | jmayer | 2005-08-20 11:24:35 -0500 (Sat, 20 Aug 2005) | 2 lines Changed paths: M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-k12.c - M /trunk/wiretap/k12.c - M /trunk/wiretap/wtap.h - -use a helper dissector to show k12 files. +If we delete a file, don't forget to remove it from Makefile.common ------------------------------------------------------------------------ -r14620 | gerald | 2005-06-13 11:31:01 -0500 (Mon, 13 Jun 2005) | 4 lines +r15475 | jmayer | 2005-08-20 11:19:22 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/Makefile.am - M /trunk/make-version.pl + M /trunk/epan/bitswap.c + M /trunk/epan/dfilter/dfilter.c + M /trunk/epan/dfilter/grammar.lemon + D /trunk/epan/dissectors/packet-sna.h + M /trunk/epan/ftypes/ftypes.c + M /trunk/epan/stats_tree.c + M /trunk/gtk/print_mswin.c + M /trunk/mkstemp.c + M /trunk/plugins/mate/mate_grammar.lemon + M /trunk/plugins/mate/mate_util.c + M /trunk/wiretap/ascend-grammar.y + M /trunk/wiretap/wtap.c -Read .svn/entries directly instead of calling "svn info", as suggested by -Thomas Anders. This should make things more locale-independent and remove -a dependency on "svn" being present. +- Include the .h files in their .c files. +- Remove epan/dissectors/packet-sna.h, it isn't used anywhere. ------------------------------------------------------------------------ -r14619 | lego | 2005-06-13 03:47:24 -0500 (Mon, 13 Jun 2005) | 2 lines +r15474 | ulfl | 2005-08-20 10:58:42 -0500 (Sat, 20 Aug 2005) | 7 lines Changed paths: - M /trunk/plugins/giop/Makefile.am + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-quakeworld.c + M /trunk/epan/dissectors/packet-smb.c -Add the missing parlay.la to the makefile +removed MSVC warnings: +packet-camel.c(6829) : warning C4101: 'version_str' : unreferenced local variable +packet-quakeworld.c(172) : warning C4090: 'return' : different 'const' qualifiers +packet-smb.c(10859) : warning C4101: 'target_name_len' : unreferenced local variable +packet-smb.c(10860) : warning C4101: 'fn_len' : unreferenced local variable +packet-smb.c(10858) : warning C4101: 'fn' : unreferenced local variable ------------------------------------------------------------------------ -r14618 | ulfl | 2005-06-13 01:55:06 -0500 (Mon, 13 Jun 2005) | 1 line +r15473 | ulfl | 2005-08-20 10:19:31 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/docbook/catalog.xml + M /trunk/epan/dissectors/packet-afp.h + +Win32: exported DATA must be declared with ETH_VAR_IMPORT to be available from outside the lib -from Jaap Keuter: add some comments, how paths should look like for a debian distro +fixes current Win32 buildbot problem ------------------------------------------------------------------------ -r14617 | etxrab | 2005-06-11 16:31:13 -0500 (Sat, 11 Jun 2005) | 1 line +r15472 | jmayer | 2005-08-20 09:08:53 -0500 (Sat, 20 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-yhoo.c + M /trunk/gtk/proto_hier_stats_dlg.c -Add some yhoo_service_vals +One file missed in last checkin ------------------------------------------------------------------------ -r14616 | guy | 2005-06-11 14:03:49 -0500 (Sat, 11 Jun 2005) | 2 lines +r15471 | jmayer | 2005-08-20 09:02:00 -0500 (Sat, 20 Aug 2005) | 6 lines Changed paths: - M /trunk/docbook/user-guide.xml + M /trunk/gtk/about_dlg.c + M /trunk/gtk/capture_if_dlg.c + M /trunk/gtk/fileset_dlg.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/gsm_map_summary.c + M /trunk/gtk/gui_utils.c + M /trunk/gtk/gui_utils.h + M /trunk/gtk/main.h + M /trunk/gtk/menu.h + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/plugins_dlg.c + A /trunk/gtk/plugins_dlg.h + M /trunk/gtk/prefs_dlg.c + M /trunk/gtk/print_dlg.c + M /trunk/gtk/proto_dlg.c + M /trunk/gtk/proto_draw.c + M /trunk/gtk/proto_hier_stats_dlg.c + M /trunk/gtk/range_utils.c + M /trunk/gtk/recent.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_byte_graph_dlg.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/gtk/sctp_error_dlg.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/toolbar.h + M /trunk/gtk/voip_calls.c + M /trunk/gtk/voip_calls_dlg.c + +- Declare some functions static +- Add plugins_dlg.h +- Include .h files in their respective .c files +- Include .h and remove extern declarations in .c files +- set eol-style and keywords on gui_utils.[hc] -Update references to the WinPcap Web site. +------------------------------------------------------------------------ +r15470 | jmayer | 2005-08-20 08:21:09 -0500 (Sat, 20 Aug 2005) | 1 line +Changed paths: + M /trunk/ui_util.h +Add some comments on the originating files of the declarations ------------------------------------------------------------------------ -r14615 | guy | 2005-06-11 14:02:31 -0500 (Sat, 11 Jun 2005) | 2 lines +r15469 | sahlberg | 2005-08-20 08:02:08 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/docbook/edg_src/EDG_chapter_libraries.xml + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-fcdns.c + M /trunk/epan/dissectors/packet-icep.c + M /trunk/epan/dissectors/packet-ieee80211.c + +more sprintf updates -Update references to the WinPcap Web site. ------------------------------------------------------------------------ -r14614 | ulfl | 2005-06-11 11:50:18 -0500 (Sat, 11 Jun 2005) | 1 line +r15468 | jmayer | 2005-08-20 07:57:52 -0500 (Sat, 20 Aug 2005) | 4 lines Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/afp_stat.c + M /trunk/gtk/packet_win.c + M /trunk/gtk/proto_draw.c + +- Include ../ui_util.h into files that implement functions declard in + ui_util.h +- Replace one instance of ui_util.h by gui_utils.h -add missing #include "webbrowser.h" from previous commit ------------------------------------------------------------------------ -r14613 | etxrab | 2005-06-11 11:03:24 -0500 (Sat, 11 Jun 2005) | 1 line +r15467 | sahlberg | 2005-08-20 07:38:45 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-aarp.c + +remove sprintf + -Add Angelo Bannack as an author. ------------------------------------------------------------------------ -r14612 | etxrab | 2005-06-11 10:58:01 -0500 (Sat, 11 Jun 2005) | 4 lines +r15466 | sahlberg | 2005-08-20 07:28:16 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-csm-encaps.c + M /trunk/epan/dissectors/packet-ansi_a.c + +get rid of a whole chunk of sprintfs -From Angelo Bannack, - A CSM_ENCAPS dissector to use with ethereal. -The CSM_ENCAPS is a protocol used by MindSpeed to communicate with your products, and configure VoIP channels. ------------------------------------------------------------------------ -r14611 | ulfl | 2005-06-11 07:12:12 -0500 (Sat, 11 Jun 2005) | 1 line +r15465 | ulfl | 2005-08-20 07:09:48 -0500 (Sat, 20 Aug 2005) | 1 line Changed paths: + M /trunk/gtk/Makefile.am + M /trunk/gtk/Makefile.common + M /trunk/gtk/about_dlg.c + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/capture_if_details_dlg.c + M /trunk/gtk/capture_if_dlg.c + M /trunk/gtk/capture_info_dlg.c + M /trunk/gtk/capture_prefs.c + M /trunk/gtk/color_dlg.c + M /trunk/gtk/column_prefs.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/decode_as_dcerpc.c + M /trunk/gtk/decode_as_dlg.c + M /trunk/gtk/dfilter_expr_dlg.c + M /trunk/gtk/dlg_utils.c + M /trunk/gtk/dlg_utils.h + M /trunk/gtk/fc_stat.c + M /trunk/gtk/file_dlg.c + M /trunk/gtk/fileset_dlg.c + M /trunk/gtk/filter_dlg.c + M /trunk/gtk/find_dlg.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/follow_dlg.c + M /trunk/gtk/goto_dlg.c + M /trunk/gtk/graph_analysis.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/gsm_map_summary.c + M /trunk/gtk/gui_prefs.c + A /trunk/gtk/gui_utils.c + A /trunk/gtk/gui_utils.h + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/help_dlg.c + M /trunk/gtk/hostlist_table.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/layout_prefs.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/main.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/nameres_prefs.c + M /trunk/gtk/packet_list.c + M /trunk/gtk/packet_win.c + M /trunk/gtk/plugins_dlg.c + M /trunk/gtk/prefs_dlg.c + M /trunk/gtk/print_dlg.c + M /trunk/gtk/print_prefs.c + M /trunk/gtk/progress_dlg.c + M /trunk/gtk/proto_dlg.c + M /trunk/gtk/proto_draw.c + M /trunk/gtk/proto_hier_stats_dlg.c + M /trunk/gtk/range_utils.c + M /trunk/gtk/recent.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_byte_graph_dlg.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/gtk/sctp_error_dlg.c + M /trunk/gtk/sctp_graph_dlg.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/service_response_time_table.c + M /trunk/gtk/simple_dialog.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/stats_tree_stat.c + M /trunk/gtk/summary_dlg.c + M /trunk/gtk/supported_protos_dlg.c + M /trunk/gtk/tap_dfilter_dlg.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/text_page.c + D /trunk/gtk/ui_util.c + D /trunk/gtk/ui_util.h M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c -add help button pointing to the wiki page +renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir ------------------------------------------------------------------------ -r14610 | ulfl | 2005-06-10 14:09:49 -0500 (Fri, 10 Jun 2005) | 5 lines +r15464 | guy | 2005-08-20 05:03:07 -0500 (Sat, 20 Aug 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/libethereal.def -this is an attempt, please report problems: +From Gisle Vanem: export get_timedelta() for use by AFP and SMB taps. -after asking the devlist if this would break things and got no negative response, try to scan command line parameters twice, trying to "rewind" the getopt settings +------------------------------------------------------------------------ +r15463 | guy | 2005-08-20 04:35:55 -0500 (Sat, 20 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/osi-utils.c + +The order in which arguments to a function are evaluated isn't defined +by C. Do decrements of arguments before passing them to a function. -this way, fixing #135 ------------------------------------------------------------------------ -r14609 | ulfl | 2005-06-10 13:30:33 -0500 (Fri, 10 Jun 2005) | 1 line +r15462 | guy | 2005-08-20 04:08:24 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/stats_tree/pinfo_stats_tree.c + M /trunk/file.c + +Widen some variables so the code in question can handle large files if, +as, and when Wiretap can handle them. -don't call g_assert_not_reached() for an unknown port type ------------------------------------------------------------------------ -r14608 | ulfl | 2005-06-10 13:28:22 -0500 (Fri, 10 Jun 2005) | 9 lines +r15461 | guy | 2005-08-20 03:15:21 -0500 (Sat, 20 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-bittorrent.c - M /trunk/epan/dissectors/packet-bssgp.c - M /trunk/epan/dissectors/packet-cops.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcm.c - M /trunk/epan/dissectors/packet-dns.c - M /trunk/epan/dissectors/packet-esis.c - M /trunk/epan/dissectors/packet-gsm_sms_ud.c - M /trunk/epan/dissectors/packet-iax2.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/epan/dissectors/packet-jxta.c - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-msdp.c - M /trunk/epan/dissectors/packet-msproxy.c - M /trunk/epan/dissectors/packet-mtp3.c - M /trunk/epan/dissectors/packet-ncp2222.inc - M /trunk/epan/dissectors/packet-ospf.c - M /trunk/epan/dissectors/packet-pim.c - M /trunk/epan/dissectors/packet-ppp.c - M /trunk/epan/dissectors/packet-pppoe.c - M /trunk/epan/dissectors/packet-radius.c - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-rtsp.c - M /trunk/epan/dissectors/packet-smb-pipe.c - M /trunk/epan/dissectors/packet-smpp.c - M /trunk/epan/dissectors/packet-sna.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-socks.c - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/dissectors/packet-udp.c - M /trunk/epan/dissectors/packet-vj.c - M /trunk/epan/dissectors/packet-wbxml.c - M /trunk/epan/dissectors/packet-wcp.c - M /trunk/epan/dissectors/packet-x11.c + M /trunk/epan/libethereal.def -just to get things straight: a dissector should *never* do any g_assert() calls! +Export AFP's CommandCode_vals for use by the AFP taps. -in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED() +------------------------------------------------------------------------ +r15460 | sahlberg | 2005-08-20 00:37:08 -0500 (Sat, 20 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ospf.c -this will replace application crash by showing a dissector bug, which is the desired behaviour +sprintf elimination -there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too -one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain. ------------------------------------------------------------------------ -r14607 | lego | 2005-06-10 11:23:22 -0500 (Fri, 10 Jun 2005) | 3 lines +r15459 | sahlberg | 2005-08-20 00:31:36 -0500 (Sat, 20 Aug 2005) | 3 lines Changed paths: - M /trunk/wiretap/k12.c + M /trunk/epan/dissectors/packet-wbxml.c -Fixed indentation and removed control characters, in an attempt to understand why windows fail to compile. +sprintf removals ------------------------------------------------------------------------ -r14606 | lego | 2005-06-10 11:01:16 -0500 (Fri, 10 Jun 2005) | 5 lines +r15458 | sahlberg | 2005-08-19 21:51:13 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/wiretap/Makefile.common - M /trunk/wiretap/file_access.c - A /trunk/wiretap/k12.c - A /trunk/wiretap/k12.h - M /trunk/wiretap/wtap-int.h - M /trunk/wiretap/wtap.h - -Initial checkin of the 32 bit tektronix k12 binary format (rf5) + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-tds.c -There is still much to do, but at the very least it can import files allowing the user to choose which protocols handle the diferent sources. +remove some more sprintf ------------------------------------------------------------------------ -r14605 | ulfl | 2005-06-09 17:49:08 -0500 (Thu, 09 Jun 2005) | 1 line +r15457 | sahlberg | 2005-08-19 21:33:33 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/osi-utils.c + M /trunk/epan/osi-utils.h + M /trunk/epan/sna-utils.c + M /trunk/epan/sna-utils.h + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h + M /trunk/epan/value_string.c + M /trunk/epan/xdlc.c + +removal of even more sprintf + -add Julian Onions ------------------------------------------------------------------------ -r14604 | ulfl | 2005-06-09 17:46:41 -0500 (Thu, 09 Jun 2005) | 1 line +r15456 | guy | 2005-08-19 21:19:37 -0500 (Fri, 19 Aug 2005) | 6 lines Changed paths: - M /trunk/docbook/edg_src/EDG_chapter_dissection.xml + M /trunk/Makefile.common + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-afp.h + M /trunk/gtk/Makefile.common + A /trunk/gtk/afp_stat.c + A /trunk/tap-afpstat.c + +For AFP requests, add in the frame with the (last part of the) reply, if +possible, and, for AFP replies, add in the frame with the request and +the time between those two frames. + +Have AFP per-request-type RTT statistics, similar to SMB's statistics. -from Julian Onions: add more about protocol dissection to the developer's guide ------------------------------------------------------------------------ -r14603 | ulfl | 2005-06-09 15:08:39 -0500 (Thu, 09 Jun 2005) | 1 line +r15455 | guy | 2005-08-19 21:15:02 -0500 (Fri, 19 Aug 2005) | 2 lines Changed paths: - M /trunk/plugins/profinet/ChangeLog - M /trunk/plugins/profinet/moduleinfo.h + M /trunk/epan/dissectors/packet-smb.c + M /trunk/tap-smbstat.c + +Use get_timedelta() to get the difference between two times. -raise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test.sh since the last Ethereal release ------------------------------------------------------------------------ -r14602 | ulfl | 2005-06-09 14:58:02 -0500 (Thu, 09 Jun 2005) | 1 line +r15454 | guy | 2005-08-19 21:14:01 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/cfile.h + M /trunk/file.c + M /trunk/tethereal.c + +Get rid of f_len field in capture_file structure - we can just keep +the length locally. within cf_read(). -fix positions of create_console()/destroy_console() calls for help and version output ------------------------------------------------------------------------ -r14601 | ulfl | 2005-06-09 14:55:55 -0500 (Thu, 09 Jun 2005) | 1 line +r15453 | jmayer | 2005-08-19 21:05:02 -0500 (Fri, 19 Aug 2005) | 1 line Changed paths: - M /trunk/gtk/main.c + M /trunk/configure.in + M /trunk/wiretap/configure.in -bugfix: don't crash, if cf->filename is NULL (which happens if an invalid capture filter is entered) +Add -Wmissing-declarations -Wwrite-strings to extra-gcc-flags ------------------------------------------------------------------------ -r14600 | ulfl | 2005-06-09 14:52:10 -0500 (Thu, 09 Jun 2005) | 1 line +r15452 | jmayer | 2005-08-19 21:03:40 -0500 (Fri, 19 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-pn-rt.c + M /trunk/epan/dissectors/packet-alcap.c -add some more details of the RT protocols frame ID's +Trivial warning fixes ------------------------------------------------------------------------ -r14599 | ulfl | 2005-06-09 14:49:56 -0500 (Thu, 09 Jun 2005) | 1 line +r15451 | sahlberg | 2005-08-19 20:24:23 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/doc/ethereal.pod + M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/epan/dissectors/packet-mtp3.h + M /trunk/epan/to_str.c + M /trunk/gtk/mtp3_stat.c + +remove sprintf from mtp3 + -add some more details to the files section ------------------------------------------------------------------------ -r14598 | gerald | 2005-06-09 13:24:55 -0500 (Thu, 09 Jun 2005) | 2 lines +r15450 | sahlberg | 2005-08-19 20:10:40 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/Makefile.am + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-x11.c + +remove sprintf from pgm and x11 -Change "colorfilter" to "colorfilters". Fix up whitespace. ------------------------------------------------------------------------ -r14597 | etxrab | 2005-06-09 12:25:40 -0500 (Thu, 09 Jun 2005) | 2 lines +r15449 | sahlberg | 2005-08-19 19:33:08 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/giop/Makefile.am - M /trunk/plugins/giop/Makefile.nmake - A /trunk/plugins/giop/packet-parlay.c + M /trunk/epan/dissectors/packet-v120.c + M /trunk/epan/dissectors/packet-wccp.c + +remove sprintf from v120 and wccp + -Add dissection of parlay -www.parlay.org ------------------------------------------------------------------------ -r14596 | ulfl | 2005-06-09 03:03:34 -0500 (Thu, 09 Jun 2005) | 1 line +r15448 | sahlberg | 2005-08-19 19:27:46 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/doc/ethereal.pod + M /trunk/epan/dissectors/packet-rpc.c + +remove sprintf from rpc + -we possibly have global cfilters/dfilters files now ------------------------------------------------------------------------ -r14595 | ulfl | 2005-06-09 02:43:32 -0500 (Thu, 09 Jun 2005) | 7 lines +r15447 | sahlberg | 2005-08-19 19:07:20 -0500 (Fri, 19 Aug 2005) | 8 lines Changed paths: - M /trunk/Makefile.am - A /trunk/cfilters - A /trunk/colorfilters - A /trunk/dfilters - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-rtps.c + +fix buffer handling and remove sprintf + -provide global default files for cfilters/colorfilters/dfilters +there was at least one instance where an ip address was printed in dotted decimal to a 10 byte array on the stack. +I.e. a guaranteed buffer overrun for a stack object. -at least the colorfilters file needs some more "finetuning" -NSIS (Win32): install these files into the Ethereal Program dir, but don't overwrite existing ones -makefile.am: I've added the three files to EXTRA_DIST and pkgdata_DATA, which *seems* to be the right places ------------------------------------------------------------------------ -r14594 | ulfl | 2005-06-09 01:58:03 -0500 (Thu, 09 Jun 2005) | 3 lines +r15446 | sahlberg | 2005-08-19 18:28:23 -0500 (Fri, 19 Aug 2005) | 4 lines Changed paths: - M /trunk/filters.c + M /trunk/epan/dissectors/packet-smpp.c + M /trunk/epan/dissectors/packet-x25.c + +more sprintf removals, +replace some char arrays on the stack to ep_alloc()ed memory -Try to read the "cfilters"/"dfilters" config files from the global path (program dir), if no personal versions of these files are available. -This is the same behaviour, as we do it for the colorfilters/preferences/... files already. ------------------------------------------------------------------------ -r14593 | etxrab | 2005-06-09 00:40:26 -0500 (Thu, 09 Jun 2005) | 2 lines +r15445 | sahlberg | 2005-08-19 18:03:56 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/doc/README.developer - M /trunk/doc/README.tapping + M /trunk/epan/dissectors/packet-spnego.c + +remove a gmalloc and al sprintf from spnego + -From Mike Duigou -Minor corrections to README.developer and README.tapping ------------------------------------------------------------------------ -r14592 | etxrab | 2005-06-08 23:28:13 -0500 (Wed, 08 Jun 2005) | 2 lines +r15444 | sahlberg | 2005-08-19 17:44:56 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-snmp.c + +no more g_malloc or sprintf in snmp + -From Tim Endean: -Check for tvb. ------------------------------------------------------------------------ -r14591 | etxrab | 2005-06-08 13:53:11 -0500 (Wed, 08 Jun 2005) | 3 lines +r15443 | sahlberg | 2005-08-19 17:34:28 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-snmp.c + +more gmalloc sprintf removals + -From Olivier Jacques, -- beautify TCAP decoding without upper dissector associated. -With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output ------------------------------------------------------------------------ -r14590 | etxrab | 2005-06-08 13:52:34 -0500 (Wed, 08 Jun 2005) | 3 lines +r15442 | sahlberg | 2005-08-19 17:26:10 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-snmp.c + +remove two gmalloc and some sprintf + -From Olivier Jacques, -- beautify TCAP decoding without upper dissector associated. -With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output ------------------------------------------------------------------------ -r14589 | gerald | 2005-06-08 10:32:00 -0500 (Wed, 08 Jun 2005) | 2 lines +r15441 | sahlberg | 2005-08-19 16:19:49 -0500 (Fri, 19 Aug 2005) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-h1.c + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h + +from Jeff Snyder + + +H245 updates +make multiple pdus/frame work + +update to have nu limit on the max number of tappable pdus per frame -Break out of an infinite loop. Fixes bug 232. ------------------------------------------------------------------------ -r14588 | ulfl | 2005-06-08 01:40:17 -0500 (Wed, 08 Jun 2005) | 1 line +r15440 | ulfl | 2005-08-19 16:13:49 -0500 (Fri, 19 Aug 2005) | 1 line Changed paths: - M /trunk/tools/fuzz-test.sh + M /trunk/ringbuffer.c -fix a problem if the tools have a space char in their path +fix #357: increment ring buffer "file names" (again?) ------------------------------------------------------------------------ -r14587 | ulfl | 2005-06-08 01:33:49 -0500 (Wed, 08 Jun 2005) | 1 line +r15439 | ulfl | 2005-08-19 16:09:38 -0500 (Fri, 19 Aug 2005) | 1 line Changed paths: - M /trunk/tools/fuzz-test.sh + M /trunk/docbook/eug_src/EUG_chapter_build_install.xml -add some general and some cygwin related comments +as the WinPcap installation is now longer really needed (it has become part of the main Ethereal installer) clarify things about installation ------------------------------------------------------------------------ -r14586 | etxrab | 2005-06-08 00:06:30 -0500 (Wed, 08 Jun 2005) | 1 line +r15438 | guy | 2005-08-19 14:44:21 -0500 (Fri, 19 Aug 2005) | 6 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/config.nmake + +We've changed the Wiretap ABI (removed one routine), so bump the library +version number. + +WinPcap 3.1 is no longer in alpha. (Should we make WINPCAP_VERSION 3.1, +so we default to assuming WinPcap 3.1?) -Cahnge ssn range ------------------------------------------------------------------------ -r14585 | etxrab | 2005-06-08 00:04:26 -0500 (Wed, 08 Jun 2005) | 2 lines +r15437 | guy | 2005-08-19 14:40:00 -0500 (Fri, 19 Aug 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/capinfos.c + M /trunk/cfile.h + M /trunk/file.c + M /trunk/gtk/file_dlg.c + M /trunk/gtk/fileset_dlg.c + M /trunk/merge.c + M /trunk/merge.h + M /trunk/ringbuffer.c + M /trunk/tethereal.c + M /trunk/wiretap/ascend.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.def + M /trunk/wiretap/wtap.h + +Add APIs to Wiretap to return the file of the size as supplied by the OS +(so if the file's gzipped, it's *NOT* the size of the file after +uncompressing), and an approximation of the amount of that data read +sequentially so far. + +Use those for various progress bars and the like. + +Make the fstat() in the Ascend trace reader directly use wth->fd, as +it's inside Wiretap; that gets rid of the last caller of wtap_fd() (as +we're no longer directly using fstat() or lseek() in Ethereal), so get +rid of wtap_fd(). -From Tim Endean: -Fix ssn range ------------------------------------------------------------------------ -r14584 | etxrab | 2005-06-08 00:03:36 -0500 (Wed, 08 Jun 2005) | 1 line +r15436 | ulfl | 2005-08-19 14:29:29 -0500 (Fri, 19 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/docbook/eug_src/EUG_chapter_introduction.xml -Fix a typo. +add information about unsupported/fresh windows versions ------------------------------------------------------------------------ -r14583 | lego | 2005-06-07 18:25:46 -0500 (Tue, 07 Jun 2005) | 5 lines +r15435 | gerald | 2005-08-19 13:28:50 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rtcp.c - M /trunk/epan/dissectors/packet-rtp.c - M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-smb.c + +Restore pinfo->private_data after calling another dissector, in case it gets +overwritten. Fixes bug 367. -From: Martin Mathieson +------------------------------------------------------------------------ +r15434 | lego | 2005-08-19 11:46:46 -0500 (Fri, 19 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common -fix cases where %d has been used instead of %u... +Add packet-alcap.h to the Makefiles. ------------------------------------------------------------------------ -r14582 | lego | 2005-06-07 18:22:37 -0500 (Tue, 07 Jun 2005) | 3 lines +r15433 | lego | 2005-08-19 10:50:48 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-alcap.c + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/epan/dissectors/packet-acse.c -make sure that colifo gets set and put some other useful info there +some ememification ------------------------------------------------------------------------ -r14581 | etxrab | 2005-06-07 15:57:27 -0500 (Tue, 07 Jun 2005) | 1 line +r15432 | lego | 2005-08-19 10:46:39 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/asn1/camel/camel.asn + M /trunk/asn1/camel/packet-camel-template.h + +add the $Id:$ + -Add some ethertypes ------------------------------------------------------------------------ -r14580 | etxrab | 2005-06-07 15:56:54 -0500 (Tue, 07 Jun 2005) | 1 line +r15431 | lego | 2005-08-19 10:35:42 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/etypes.h + M /trunk/epan/dissectors/packet-dcerpc-lsa.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-fw1.c + +some ememification + -Add some ethertypes ------------------------------------------------------------------------ -r14579 | etxrab | 2005-06-07 15:30:04 -0500 (Tue, 07 Jun 2005) | 1 line +r15430 | lego | 2005-08-19 06:53:39 -0500 (Fri, 19 Aug 2005) | 4 lines Changed paths: - M /trunk/asn1/tcap/tcap.asn - M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-alcap.c + A /trunk/epan/dissectors/packet-alcap.h + +Keep information about the call-leg so that all the messages of a leg can be filtered given a parameter of it. +Create the header to export the structures thyat hold that info. + -Some fixes from Tim Endean ------------------------------------------------------------------------ -r14578 | etxrab | 2005-06-07 15:29:23 -0500 (Tue, 07 Jun 2005) | 1 line +r15429 | guy | 2005-08-19 05:00:14 -0500 (Fri, 19 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/Makefile.common + M /trunk/epan/Makefile.common + M /trunk/epan/libethereal.def + A /trunk/epan/stat.c (from /trunk/stat.c:15427) + A /trunk/epan/stat.h (from /trunk/stat.h:15427) + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/conversations_eth.c + M /trunk/gtk/conversations_fc.c + M /trunk/gtk/conversations_fddi.c + M /trunk/gtk/conversations_ip.c + M /trunk/gtk/conversations_ipx.c + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_sctp.c + M /trunk/gtk/conversations_tcpip.c + M /trunk/gtk/conversations_tr.c + M /trunk/gtk/conversations_udpip.c + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_fc.c + M /trunk/gtk/hostlist_fddi.c + M /trunk/gtk/hostlist_ip.c + M /trunk/gtk/hostlist_ipx.c + M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/hostlist_tcpip.c + M /trunk/gtk/hostlist_tr.c + M /trunk/gtk/hostlist_udpip.c + M /trunk/gtk/hostlist_wlan.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/main.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/stats_tree_stat.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c + D /trunk/stat.c + D /trunk/stat.h + M /trunk/tap-ansi_astat.c + M /trunk/tap-bootpstat.c + M /trunk/tap-dcerpcstat.c + M /trunk/tap-gsm_astat.c + M /trunk/tap-h225counter.c + M /trunk/tap-h225rassrt.c + M /trunk/tap-httpstat.c + M /trunk/tap-iostat.c + M /trunk/tap-iousers.c + M /trunk/tap-mgcpstat.c + M /trunk/tap-protocolinfo.c + M /trunk/tap-protohierstat.c + M /trunk/tap-rpcprogs.c + M /trunk/tap-rpcstat.c + M /trunk/tap-sctpchunkstat.c + M /trunk/tap-sipstat.c + M /trunk/tap-smbsids.c + M /trunk/tap-smbstat.c + M /trunk/tap-stats_tree.c + M /trunk/tap-wspstat.c + M /trunk/tethereal.c + +Move the stats.[ch] stuff into epan, so plugins can use it. -Some fixes from Tim Endean ------------------------------------------------------------------------ -r14577 | etxrab | 2005-06-07 10:21:22 -0500 (Tue, 07 Jun 2005) | 5 lines +r15428 | sahlberg | 2005-08-19 04:47:11 -0500 (Fri, 19 Aug 2005) | 12 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ldap.c + +From Matthias Drochner: +I'll attach a patch which fixes the decoding of authenticated +LDAP bind replies. The SASL credentials are always "context +specific" in terms of ASN.1. +I've tested the fix with DIGEST-MD5 authentication. +(Without the patch, ethereal complains about a wrong type +because it expects an ASN.a octet string.) +(You might also consider a stricter check of the ASN.1 header +type for the GSSAPI and GSS-SPNEGO cases, but I can't test this.) + + -From Alejandro Vaquero: -glib-object.h is is glib2 only. - graph_analysis.c:47:25: glib-object.h: No such file or directory - a patch for ths issue and also to correct the "first_item" -issue reported in "RE: [Ethereal-dev] Voip graph analysis "Save as" button" ------------------------------------------------------------------------ -r14576 | kukosa | 2005-06-07 07:05:03 -0500 (Tue, 07 Jun 2005) | 1 line +r15427 | guy | 2005-08-19 04:29:41 -0500 (Fri, 19 Aug 2005) | 8 lines Changed paths: - M /trunk/asn1/h225/h225.cnf + M /trunk/Makefile.common + M /trunk/epan/libethereal.def + M /trunk/epan/tap.c + M /trunk/epan/tap.h + M /trunk/gtk/Makefile.am + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/conversations_eth.c + M /trunk/gtk/conversations_fc.c + M /trunk/gtk/conversations_fddi.c + M /trunk/gtk/conversations_ip.c + M /trunk/gtk/conversations_ipx.c + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_sctp.c + M /trunk/gtk/conversations_tcpip.c + M /trunk/gtk/conversations_tr.c + M /trunk/gtk/conversations_udpip.c + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/flow_graph.c + M /trunk/gtk/follow_dlg.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/gsm_map_summary.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_fc.c + M /trunk/gtk/hostlist_fddi.c + M /trunk/gtk/hostlist_ip.c + M /trunk/gtk/hostlist_ipx.c + M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/hostlist_tcpip.c + M /trunk/gtk/hostlist_tr.c + M /trunk/gtk/hostlist_udpip.c + M /trunk/gtk/hostlist_wlan.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/main.c + M /trunk/gtk/menu.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_byte_graph_dlg.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/gtk/sctp_error_dlg.c + M /trunk/gtk/sctp_graph_dlg.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + A /trunk/gtk/stat_menu.h (from /trunk/gtk/tap_menu.h:15420) + M /trunk/gtk/stats_tree_stat.c + D /trunk/gtk/tap_menu.h + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c + A /trunk/stat.c + A /trunk/stat.h + M /trunk/tap-ansi_astat.c + M /trunk/tap-bootpstat.c + M /trunk/tap-dcerpcstat.c + M /trunk/tap-gsm_astat.c + M /trunk/tap-h225counter.c + M /trunk/tap-h225rassrt.c + M /trunk/tap-httpstat.c + M /trunk/tap-iostat.c + M /trunk/tap-iousers.c + M /trunk/tap-mgcpstat.c + M /trunk/tap-protocolinfo.c + M /trunk/tap-protohierstat.c + M /trunk/tap-rpcprogs.c + M /trunk/tap-rpcstat.c + M /trunk/tap-sctpchunkstat.c + M /trunk/tap-sipstat.c + M /trunk/tap-smbsids.c + M /trunk/tap-smbstat.c + M /trunk/tap-stats_tree.c + M /trunk/tap-wspstat.c + M /trunk/tap_dfilter_dlg.h + M /trunk/tethereal.c + +Move the APIs for registering and processing "-z" command-line arguments +and "Statistics" menu items into "stat.h" and "stat.c", to separate them +from the core tapping APIs. A tap could conceivably not register as a +"-z" command-line argument or "Statistics" menu item, and a stat could +conceivably not be implemented as a tap, and dissectors that implement +tapping points don't need the UI-related stuff from "stat.h", they just +want the tap-related stuff in <epan/tap.h>. -Usage of new #.FN_PARS directive instead of #.FN_BODY ------------------------------------------------------------------------ -r14575 | kukosa | 2005-06-07 06:58:22 -0500 (Tue, 07 Jun 2005) | 3 lines +r15426 | sahlberg | 2005-08-19 04:28:58 -0500 (Fri, 19 Aug 2005) | 5 lines Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ptp.c + +From Markus Seehofer + +PTP updates + -- usage of dissect_per_null() and dissect_ber_null() -- new #.FN_PARS directive (implemented only for OCTET STRING and INTEGER now) -- set true value strings for named bits ------------------------------------------------------------------------ -r14574 | etxrab | 2005-06-07 00:50:28 -0500 (Tue, 07 Jun 2005) | 6 lines +r15425 | sahlberg | 2005-08-19 03:43:58 -0500 (Fri, 19 Aug 2005) | 5 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/tcap.cnf + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c -From Tim Endean: +From Michael Lum: + +Statistics data structure was not being passed to the draw routine. -- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags. -- Both ANSI and ITU variants supported without configuration. -- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first. ------------------------------------------------------------------------ -r14573 | etxrab | 2005-06-07 00:49:57 -0500 (Tue, 07 Jun 2005) | 6 lines +r15424 | sahlberg | 2005-08-19 03:39:19 -0500 (Fri, 19 Aug 2005) | 7 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-ansi_map.c + +From Michael Lum: +Fixed quite a few parameter IDs based on TIA-41-E (originally my mistakes). +Added support for filtering by DN, MIN, etc. +Moved where embedded 'Bearer Data' parameter is sub-dissected. -From Tim Endean: -- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags. -- Both ANSI and ITU variants supported without configuration. -- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first. ------------------------------------------------------------------------ -r14572 | etxrab | 2005-06-07 00:49:06 -0500 (Tue, 07 Jun 2005) | 7 lines +r15423 | sahlberg | 2005-08-19 03:36:38 -0500 (Fri, 19 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h + M /trunk/epan/dissectors/packet-sccp.c -From Tim Endean: +From Michael Lum + +Slight modification to allow a protocol beneath SCCP (i.e. MTP3) +specify how the SCCP message should be dissected. -- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags. -- Both ANSI and ITU variants supported without configuration. -- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first. ------------------------------------------------------------------------ -r14571 | etxrab | 2005-06-06 15:42:18 -0500 (Mon, 06 Jun 2005) | 1 line +r15422 | sahlberg | 2005-08-19 03:32:27 -0500 (Fri, 19 Aug 2005) | 5 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-3g-a11.c + +from Michael Lum + +update to 3g-a11 +Modified support for ESN in the Airlink Setup Record -Let the sub dissector use the top tree. ------------------------------------------------------------------------ -r14570 | ulfl | 2005-06-06 15:32:08 -0500 (Mon, 06 Jun 2005) | 3 lines +r15421 | sahlberg | 2005-08-19 03:19:52 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/docbook/edg_src/EDG_chapter_dissection.xml + M /trunk/epan/dissectors/packet-etheric.c + +remove gmalloc from etheric -from Julian Onions: add a devel section about start writing a dissector -some editing by me ... ------------------------------------------------------------------------ -r14569 | lego | 2005-06-06 13:53:43 -0500 (Mon, 06 Jun 2005) | 3 lines +r15420 | sahlberg | 2005-08-19 03:12:26 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-alcap.c + M /trunk/epan/dissectors/packet-smb-common.c + M /trunk/epan/dissectors/packet-smb-common.h + M /trunk/epan/dissectors/packet-smb-logon.c -register the dissector so that it can be found +remove g_malloc() from packet-smb-common ------------------------------------------------------------------------ -r14568 | lego | 2005-06-06 13:52:54 -0500 (Mon, 06 Jun 2005) | 4 lines +r15419 | sahlberg | 2005-08-19 03:03:28 -0500 (Fri, 19 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sscop.c + M /trunk/epan/dissectors/packet-rtsp.c -- add an hf entry I forgot -- get the STAT/USTAT PDU list straight +remove g_malloc() ------------------------------------------------------------------------ -r14567 | lego | 2005-06-06 13:51:05 -0500 (Mon, 06 Jun 2005) | 3 lines +r15418 | ulfl | 2005-08-19 02:03:34 -0500 (Fri, 19 Aug 2005) | 2 lines Changed paths: - M /trunk/asn1/h248/h248.cnf - M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-h248.h + M /trunk/file.c -- make sure there's something to add to colinfo. -- auditValueRequest is a request too +file.c(3079) : warning C4090: 'function' : different 'const' qualifiers +file.c(3079) : warning C4022: 'cf_callback_invoke' : pointer mismatch for actual parameter 2 +------------------------------------------------------------------------ +r15417 | guy | 2005-08-18 20:57:44 -0500 (Thu, 18 Aug 2005) | 4 lines +Changed paths: + M /trunk/gtk/fileset_dlg.c + +Include <string.h> to declare "strrchr()". + +Clean up indentation. ------------------------------------------------------------------------ -r14566 | lego | 2005-06-06 13:45:47 -0500 (Mon, 06 Jun 2005) | 2 lines +r15416 | guy | 2005-08-18 20:56:14 -0500 (Thu, 18 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-user_encap.c + M /trunk/epan/dissectors/packet-ber.c -the trailer's offset and len were not ok. +Set "hoffset" before using it. ------------------------------------------------------------------------ -r14565 | etxrab | 2005-06-06 13:01:58 -0500 (Mon, 06 Jun 2005) | 1 line +r15415 | guy | 2005-08-18 20:17:24 -0500 (Thu, 18 Aug 2005) | 5 lines Changed paths: - A /trunk/epan/dissectors/packet-isup_thin.c + M /trunk/cfile.h + M /trunk/file.c + M /trunk/gtk/main.c + M /trunk/summary.c + M /trunk/tethereal.c + +Have "f_datalen" keep track of the number of bytes of uncompressed file +data, so that "f_len" still keeps the size of the underlying file (which +is necessary in order to make the progress bar when files are being read +work correctly). -Dissector for ISUP over TCP. ------------------------------------------------------------------------ -r14564 | etxrab | 2005-06-06 12:40:07 -0500 (Mon, 06 Jun 2005) | 1 line +r15414 | etxrab | 2005-08-18 16:36:59 -0500 (Thu, 18 Aug 2005) | 12 lines Changed paths: - A /trunk/asn1/tcap/Makefile.nmake + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcap.h + +From Tim Endean: + +Small patch to ber.c + +The tcap dissector has been updated to use this length. I have not tested other asn.1 dissectors to ensure that they correctly use the indefinite encoding flag instead of the length value returning zero. + +There may also be some problems when re-assembly is needed, but the ability to deal with indefinite length is much more useful. + +For developers the get_ber_length now returns the length of the pdu including the EOC, where you have dissectors that use packet-ber.c the eoc may need to be dealt with separately. + +The tcap dissector has had numerous changes to make it less cluttered, and the useful feature of the previous version where a dialogue could be filtered out by selecting either the source or destination transaction ID has been incorporated into this version. -Add makefile.nmake ------------------------------------------------------------------------ -r14563 | etxrab | 2005-06-06 12:08:37 -0500 (Mon, 06 Jun 2005) | 1 line +r15413 | ulfl | 2005-08-18 14:36:19 -0500 (Thu, 18 Aug 2005) | 1 line Changed paths: - M /trunk/gtk/conversations_jxta.c - M /trunk/gtk/conversations_table.h - M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/fileset_dlg.c -Add an ifdef and "dont apply patch twice". +fix #305: don't get file creation date/time of the file but just use the filename ------------------------------------------------------------------------ -r14562 | etxrab | 2005-06-06 12:07:04 -0500 (Mon, 06 Jun 2005) | 1 line +r15412 | ulfl | 2005-08-18 14:31:15 -0500 (Thu, 18 Aug 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-jxta.h + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/config.h.win32 + M /trunk/epan/column-utils.c + M /trunk/epan/dfilter/dfilter.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-fcdns.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-fddi.c + M /trunk/epan/dissectors/packet-fw1.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-icep.c + M /trunk/epan/plugins.c + M /trunk/epan/proto.c + M /trunk/mkstemp.c + +several times replacing: -Fix a typo and add an ifdef +sprintf -> g_snprintf +snprintf -> g_snprintf +vsnprintf -> g_vsnprintf +strdup -> g_strdup ------------------------------------------------------------------------ -r14561 | etxrab | 2005-06-06 10:39:20 -0500 (Mon, 06 Jun 2005) | 1 line +r15411 | ulfl | 2005-08-18 14:19:59 -0500 (Thu, 18 Aug 2005) | 1 line Changed paths: - A /trunk/asn1/tcap/Makefile - A /trunk/asn1/tcap/packet-tcap-template.c - A /trunk/asn1/tcap/packet-tcap-template.h - A /trunk/asn1/tcap/tcap.asn - A /trunk/asn1/tcap/tcap.cnf + M /trunk/fileset.c -Add the asn2eth generated TCAP dissector made by Tim Endean to the SVN tree. +while sorting the entries, don't use the file creation date but the filename for comparison ------------------------------------------------------------------------ -r14560 | etxrab | 2005-06-06 10:37:12 -0500 (Mon, 06 Jun 2005) | 1 line +r15410 | ulfl | 2005-08-18 14:09:01 -0500 (Thu, 18 Aug 2005) | 1 line Changed paths: - A /trunk/asn1/tcap + M /trunk/gtk/menu.c -Add the asn2eth genereated TCAP dissector to SVN +init the file set submenu items, so that the next and previous file items are disabled by default ------------------------------------------------------------------------ -r14559 | etxrab | 2005-06-06 10:22:17 -0500 (Mon, 06 Jun 2005) | 26 lines +r15409 | gerald | 2005-08-18 13:12:55 -0500 (Thu, 18 Aug 2005) | 2 lines Changed paths: - M /trunk/gtk/Makefile.common - A /trunk/gtk/conversations_jxta.c - A /trunk/gtk/hostlist_jxta.c + M /trunk/epan/dissectors/packet-per.c -From Mike Duigou: - a patch which adds support for displaying jxta -conversations and endpoints from the 'Statistics' menu. Also adds : +Fix value_tvb pointers. - - a generated field to Welcome messages to indicate whether this -welcome is from the initiator or the receiver. You can filter on this -field with 'jxta.welcome.initiator==[0|1]' +------------------------------------------------------------------------ +r15408 | kukosa | 2005-08-18 09:32:49 -0500 (Thu, 18 Aug 2005) | 7 lines +Changed paths: + M /trunk/asn1/h225/h225.asn + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h245/h245.asn + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h235.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-per.h + M /trunk/tools/asn2eth.py - - Marks the source and destination fields of message added in the last -patch as generated fields. (Saw it being done for some other protocol). +- dissect_per_restricted_character_string() returns value in tvbbuff_t instead of char +- asn2eth: + fixed CHOICE tag handling + #.FN_PARS support for BIT STRING and all string types + intersection of SIZE and FROM constraints for string is handled +- new asn2eth features used in h225 and h245 +- PER dissectors regeneration +------------------------------------------------------------------------ +r15407 | etxrab | 2005-08-18 07:55:01 -0500 (Thu, 18 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/ftypes/ftype-time.c - - Cleans up dissection of Message which used to assume it would -dissected more than one set of hdr/message per tvbuff. Now it only -attempts to dissect one. +From Richard van der Hoff +negative relative time fixes. +------------------------------------------------------------------------ +r15406 | etxrab | 2005-08-18 06:09:50 -0500 (Thu, 18 Aug 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-gsm_a.c -- Uses GMemChunk for tap info and for conversation data rather than -g_malloc() There's still a major leakage of g_malloc()ed the c-strings -which are used in jxta addresses. Any suggestions for how these can be -allocated such that they can be freed re-init is called would be -appreciated. For address objects whose data ptr doesn't point into a -tvbuff it's not clear what the lifecyle of an address object is. +Decode some more of MultiRate configuration. +------------------------------------------------------------------------ +r15405 | sahlberg | 2005-08-18 05:37:41 -0500 (Thu, 18 Aug 2005) | 19 lines +Changed paths: + M /trunk/epan/dissectors/packet-kerberos.c - - Fixes a bug with filling in the of the transport layer conversation -data. >= vs. > +when kerberos claims a conversation, it only claims it for the source port +since a KDC MIGTH send the reply back from a different port. +Then comes X.L's capture (ethereal-dev) 816fc4.cap from 16Aug2005 where +the client is reusing the same source port to talk to DNS after finishing +doing the port 88 KDC stuff. ------------------------------------------------------------------------- -r14558 | etxrab | 2005-06-06 10:20:10 -0500 (Mon, 06 Jun 2005) | 26 lines -Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-jxta.c - A /trunk/epan/dissectors/packet-jxta.h -From Mike Duigou: - a patch which adds support for displaying jxta -conversations and endpoints from the 'Statistics' menu. Also adds : +==> + +Make kerberos/udp able to test the packet for sanity and reject packets that +do not look like kerberos (even if there was a conversation that said it was kerberos) +and thus let other dissectors have a go at it. - - a generated field to Welcome messages to indicate whether this -welcome is from the initiator or the receiver. You can filter on this -field with 'jxta.welcome.initiator==[0|1]' - - Marks the source and destination fields of message added in the last -patch as generated fields. (Saw it being done for some other protocol). +in doubt, try 816fc4.cap before and after this patch :-) - - Cleans up dissection of Message which used to assume it would -dissected more than one set of hdr/message per tvbuff. Now it only -attempts to dissect one. -- Uses GMemChunk for tap info and for conversation data rather than -g_malloc() There's still a major leakage of g_malloc()ed the c-strings -which are used in jxta addresses. Any suggestions for how these can be -allocated such that they can be freed re-init is called would be -appreciated. For address objects whose data ptr doesn't point into a -tvbuff it's not clear what the lifecyle of an address object is. - - Fixes a bug with filling in the of the transport layer conversation -data. >= vs. > +------------------------------------------------------------------------ +r15404 | guy | 2005-08-18 04:47:00 -0500 (Thu, 18 Aug 2005) | 3 lines +Changed paths: + M /trunk/wiretap/netxray.c +Try yet another scheme for handling time stamps; realtick isn't always +correct. ------------------------------------------------------------------------ -r14557 | etxrab | 2005-06-06 10:17:41 -0500 (Mon, 06 Jun 2005) | 5 lines +r15403 | sahlberg | 2005-08-18 03:55:22 -0500 (Thu, 18 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/to_str.c + M /trunk/epan/dissectors/packet-tr.c -From Mike Duigou: +replace sprintf with ememified g_snprintf - a patch to to_str.c which adds support for printing -AT_STRINGZ address type. Amazing that this wasn't there! ------------------------------------------------------------------------ -r14556 | etxrab | 2005-06-06 09:01:04 -0500 (Mon, 06 Jun 2005) | 10 lines +r15402 | sahlberg | 2005-08-18 03:37:31 -0500 (Thu, 18 Aug 2005) | 6 lines Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/graph_analysis.h + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ber.h -From Alejandro Vaquero: +Tim's patches for packet-ber for extra testing (works ok with my and with Anders captures) -- Add a pane to contain the main graph and the comments to be able to -split them -- Change the main graph area to be a scrolled_window -- Change the look of the selected item to be blue with white text color -- Gray color the title area -- Change the conversations color to more "soft" colors (it was difficult -to read in some cases before) +Anders' beginnings of a new dissect_ber_set() function + + ------------------------------------------------------------------------ -r14555 | etxrab | 2005-06-06 08:55:47 -0500 (Mon, 06 Jun 2005) | 2 lines +r15401 | guy | 2005-08-18 02:09:43 -0500 (Thu, 18 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-bittorrent.c + +The length returned for continuation data should be the length remaining +in the tvbuff starting at the specified offset, not the entire length of +the tvbuff. -From Richard Rabbat: -a patch for a couple of fixes to rsvp sub-objects. ------------------------------------------------------------------------ -r14554 | ulfl | 2005-06-04 17:05:50 -0500 (Sat, 04 Jun 2005) | 3 lines +r15400 | guy | 2005-08-18 01:40:10 -0500 (Thu, 18 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-per.h + M /trunk/epan/dissectors/packet-sflow.c -if some PER errors has to be put to the stderr, give at least info where it's coming from (__FILE__ and __LINE__) +Get rid of a no-longer-used variable. -BTW: time for something like a "NotImplementedException"?!?, this seems to be a common mechanism, if a dissector hasn't implemented all protocol elemements (yet) ------------------------------------------------------------------------ -r14553 | guy | 2005-06-04 16:58:55 -0500 (Sat, 04 Jun 2005) | 7 lines +r15399 | guy | 2005-08-17 20:17:46 -0500 (Wed, 17 Aug 2005) | 2 lines Changed paths: - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/netmon.c - M /trunk/wiretap/nettl.c - -Fix some more leaks in error returns from open routines (if the open can -fail after the private data is allocated, you have to free the private -data). + M /trunk/epan/dissectors/packet-bittorrent.c -The file header in nettl files is 128 bytes - use a #define for it, and -also a #define for the magic number size. +Show BitTorrent stuff that doesn't look right as continuation data. ------------------------------------------------------------------------ -r14552 | ulfl | 2005-06-04 16:39:36 -0500 (Sat, 04 Jun 2005) | 1 line +r15398 | ulfl | 2005-08-17 18:10:28 -0500 (Wed, 17 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/proto.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h + M /trunk/plugins/lwres/packet-lwres.c -fix #225-#231: the enum lmp_filter_keys contained holes, so the logic to detect the field type failed, resulting in the bug +snprintf -> g_snprintf ------------------------------------------------------------------------ -r14551 | lego | 2005-06-04 14:22:39 -0500 (Sat, 04 Jun 2005) | 3 lines +r15397 | ulfl | 2005-08-17 17:49:07 -0500 (Wed, 17 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-user_encap.c + M /trunk/docbook/Makefile -Give the user the ability to decide how to decode USER DLTs +put the intermediate files of the release_notes chm build into it's own dir release_notes_chm/ instead of . +------------------------------------------------------------------------ +r15396 | ulfl | 2005-08-17 17:32:40 -0500 (Wed, 17 Aug 2005) | 3 lines +Changed paths: + M /trunk/docbook/release-notes.xml +0.10.12 -> 0.10.13 (preliminary) +add a section about "new and updated features" ------------------------------------------------------------------------ -r14550 | ulfl | 2005-06-04 06:47:38 -0500 (Sat, 04 Jun 2005) | 1 line +r15395 | gerald | 2005-08-17 17:27:15 -0500 (Wed, 17 Aug 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-snmp.c + +Flip the separators in the MIBS environment variable between ":" and +";" depending on our platform. This is a modified version of a patch +that Jaap Keuter sent in. Leave the preferences tooltip as-is in case +we want to be more strict about separators in the future. + +Add a link to an email from Wes explaining that we shouldn't use a +default MIB list. -fix #201 second part: adapt the string length of the unformatted text, so it won't show \000 and beyond ------------------------------------------------------------------------ -r14549 | ulfl | 2005-06-04 05:23:10 -0500 (Sat, 04 Jun 2005) | 1 line +r15394 | ulfl | 2005-08-17 17:08:06 -0500 (Wed, 17 Aug 2005) | 1 line Changed paths: - M /trunk/proto_hier_stats.c + M /trunk/Makefile.common -fix #224: hierarchy stats had problems with the new generated toplevel desegmentation items "[Reassembled TCP Segments]" +fix a typo ------------------------------------------------------------------------ -r14548 | ulfl | 2005-06-03 23:57:10 -0500 (Fri, 03 Jun 2005) | 1 line +r15393 | ulfl | 2005-08-17 17:03:21 -0500 (Wed, 17 Aug 2005) | 1 line Changed paths: - M /trunk/doc/ethereal.pod + M /trunk/epan/dissectors/packet-ip.c -update to changes done in the menu +snprintf -> g_snprintf ------------------------------------------------------------------------ -r14547 | ulfl | 2005-06-03 23:14:02 -0500 (Fri, 03 Jun 2005) | 1 line +r15392 | ulfl | 2005-08-17 16:52:16 -0500 (Wed, 17 Aug 2005) | 1 line Changed paths: - M /trunk/doc/ethereal.pod - M /trunk/doc/tethereal.pod + M /trunk/gtk/io_stat.c -make a complete redesign of the files section +strdup -> g_strdup and alike ------------------------------------------------------------------------ -r14546 | ulfl | 2005-06-03 21:06:16 -0500 (Fri, 03 Jun 2005) | 3 lines +r15391 | sahlberg | 2005-08-17 15:45:18 -0500 (Wed, 17 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/packet_list.c + M /trunk/epan/addr_resolv.h + +update some comments pointing out these buffers need not be freed -fix #220: the automatic display of the vertical scrollbar at the packet list doesn't seem to work in all cases (not shown although scrolling would be necessary) -as I don't see a way to fix this (and it just don't really hurt, as this scrollbar is usually shown anyway if some more packets have to be display) just show it always ------------------------------------------------------------------------ -r14545 | ulfl | 2005-06-03 20:29:14 -0500 (Fri, 03 Jun 2005) | 5 lines +r15390 | gerald | 2005-08-17 10:04:44 -0500 (Wed, 17 Aug 2005) | 9 lines Changed paths: - M /trunk/doc/ethereal.pod - M /trunk/doc/tethereal.pod - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-bittorrent.c -update usage output and manual pages for both Ethereal and Tethereal to reflect the latest changes in the command line. +If we receive junk data from the network it means we have a +malformed packet. It doesn't necessarily mean that we have a problem +with our dissector. If we see something we didn't expect, throw a +ReportedBoundsError instead of calling DISSECTOR_ASSERT() (which makes +BuildBot open a ticket). + +Fixes bugs 362 - 366. -clarifications of some command line parameter descriptions in the manual pages -this also fixes #221 ------------------------------------------------------------------------ -r14544 | lego | 2005-06-03 09:02:06 -0500 (Fri, 03 Jun 2005) | 3 lines +r15389 | jmayer | 2005-08-17 07:27:05 -0500 (Wed, 17 Aug 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-sscop.c + M /trunk/epan/dissectors/packet-extreme.c -fix the PDU list, and put it at the bottom +As reported by Jim Young: +- The port number was incorrectly displayed +- Be a bit more verbose in the "Info" summary line. +- Display the version including the internal number. ------------------------------------------------------------------------ -r14543 | lego | 2005-06-03 08:54:34 -0500 (Fri, 03 Jun 2005) | 3 lines +r15388 | jmayer | 2005-08-17 04:59:47 -0500 (Wed, 17 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sscop.h + M /trunk/epan/dissectors/packet-extreme.c -keywords and eol-style +Comment fixes +------------------------------------------------------------------------ +r15387 | etxrab | 2005-08-17 04:43:16 -0500 (Wed, 17 Aug 2005) | 2 lines +Changed paths: + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h + from Tomas Kukosa, remove a redundant g_strdup() ------------------------------------------------------------------------ -r14542 | lego | 2005-06-03 08:50:30 -0500 (Fri, 03 Jun 2005) | 6 lines +r15386 | sahlberg | 2005-08-17 04:36:20 -0500 (Wed, 17 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-sscop.c - A /trunk/epan/dissectors/packet-sscop.h - + M /trunk/epan/addr_resolv.c + M /trunk/epan/atalk-utils.c + M /trunk/epan/osi-utils.c + M /trunk/epan/strutil.c -- add a way to call the sscop dissector with an arbitrary handle\ -- make most fields "filterable" -- dissect stat and ustat pdu lists +replace some more silly rotating buffers with ep_alloc() calls ------------------------------------------------------------------------ -r14541 | etxrab | 2005-06-03 04:56:03 -0500 (Fri, 03 Jun 2005) | 2 lines +r15385 | sahlberg | 2005-08-17 04:28:24 -0500 (Wed, 17 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/sna-utils.c + M /trunk/epan/value_string.c -Register the ISUP dissector to make it callable through -call_dissector() ------------------------------------------------------------------------- -r14540 | guy | 2005-06-03 04:55:28 -0500 (Fri, 03 Jun 2005) | 2 lines -Changed paths: - M /trunk/capture-wpcap.c - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/capture_if_dlg.c +fix some more silly rotating buffers -Update URLs and domain names that refer to the WinPcap site. ------------------------------------------------------------------------ -r14539 | etxrab | 2005-06-03 01:37:05 -0500 (Fri, 03 Jun 2005) | 4 lines +r15384 | sahlberg | 2005-08-17 04:25:04 -0500 (Wed, 17 Aug 2005) | 6 lines Changed paths: - M /trunk/packaging/rpm/SPECS/ethereal.spec.in + M /trunk/epan/dissectors/packet-aarp.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-smb-common.c + M /trunk/epan/dissectors/packet-wccp.c -From Mike Duigou: -Fixes a problem with the RPM spec which prevents it from -working with current versions of rpmbuild. +replace a whole bunch of silly rotating stating buffers with ep_alloc() calls + +this should fix a whole number of display bugs when there are too many such pdus in a single frame for the silly buffers to handle before they wrap. ------------------------------------------------------------------------- -r14538 | etxrab | 2005-06-03 01:36:07 -0500 (Fri, 03 Jun 2005) | 4 lines -Changed paths: - M /trunk/doc/README.developer -From Mike Duigou: -A few doxygen updates and an improved section on -writing dissectors that don't use tcp_dissect_pdus(). ------------------------------------------------------------------------ -r14537 | etxrab | 2005-06-03 01:35:44 -0500 (Fri, 03 Jun 2005) | 4 lines +r15383 | sahlberg | 2005-08-17 04:11:37 -0500 (Wed, 17 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/address.h - M /trunk/epan/packet.h - M /trunk/epan/packet_info.h + M /trunk/epan/dissectors/packet-manolito.c + +remove g_malloc from manolito -From Mike Duigou: -A few doxygen updates and an improved section on -writing dissectors that don't use tcp_dissect_pdus(). ------------------------------------------------------------------------ -r14536 | etxrab | 2005-06-03 01:34:35 -0500 (Fri, 03 Jun 2005) | 4 lines +r15382 | sahlberg | 2005-08-17 03:54:25 -0500 (Wed, 17 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-rtcp.c + +remove g_malloc()s from rtcp -From Mike Duigou: -A few doxygen updates and an improved section on -writing dissectors that don't use tcp_dissect_pdus(). ------------------------------------------------------------------------ -r14535 | etxrab | 2005-06-03 01:31:58 -0500 (Fri, 03 Jun 2005) | 4 lines +r15381 | sahlberg | 2005-08-17 03:50:04 -0500 (Wed, 17 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/dissectors/packet-tcp.h + M /trunk/epan/dissectors/packet-ftp.c + M /trunk/epan/dissectors/packet-sdp.c + +replace g_malloc() with ep_alloc() for ftp and sdp + + +sdp never free the allocated memory so it were leaking memory for every packet containng sdp. +fix memleak for sdp -From Mike Duigou: - A minor change to the prototype of tcp_dissect_pdus() -which uses the function pointer type from packet.h ------------------------------------------------------------------------ -r14534 | etxrab | 2005-06-03 01:29:25 -0500 (Fri, 03 Jun 2005) | 6 lines +r15380 | sahlberg | 2005-08-17 03:43:40 -0500 (Wed, 17 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-rip.c + M /trunk/epan/dissectors/packet-tacacs.c -From Mike Duigou: +remove g_malloc() from rip remove one g_malloc() from tacacs -Extends the jxta dissector to add higher level conversation -tracking, improved display, tapping and fixes a bug which caused some -conversations to get lost. ------------------------------------------------------------------------ -r14533 | ashokn | 2005-06-02 17:49:59 -0500 (Thu, 02 Jun 2005) | 7 lines +r15379 | sahlberg | 2005-08-17 03:31:54 -0500 (Wed, 17 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-lmp.c + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/epan/dissectors/packet-camel.c +from Tomas Kukosa, remove a redundant g_strdup() -Updated LMP to handle the latest protocol. Removed old protocol values -since they are no longer useful. -Manu Pathak <mapathak@cisco.com> contributed these changes +------------------------------------------------------------------------ +r15378 | jmayer | 2005-08-16 16:38:18 -0500 (Tue, 16 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-extreme.c +- Small comment updates. +- Add some info about the element to the top level. ------------------------------------------------------------------------ -r14532 | ulfl | 2005-06-02 17:11:22 -0500 (Thu, 02 Jun 2005) | 1 line +r15377 | gerald | 2005-08-16 11:11:02 -0500 (Tue, 16 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/packet.c + +For "-G decodes", print the selector values as unsigned ints. -fix call to show_fragment_seq_tree() reported by buildbot ------------------------------------------------------------------------ -r14531 | ulfl | 2005-06-02 15:55:58 -0500 (Thu, 02 Jun 2005) | 2 lines +r15376 | gerald | 2005-08-16 11:09:49 -0500 (Tue, 16 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dnp.c - M /trunk/epan/dissectors/packet-eap.c - M /trunk/epan/dissectors/packet-ndps.c - M /trunk/epan/dissectors/packet-netbios.c - M /trunk/epan/dissectors/packet-q931.c - M /trunk/epan/dissectors/packet-x25.c - M /trunk/epan/reassemble.c - M /trunk/epan/reassemble.h + M /trunk/docbook/release-notes.xml -add a generated toplevel line between the connectionless DCE/RPC protocol and the defragmented DCE/RPC content, to better understand what's going on if defragmentation is done. +Add a note about sFlow. Remove the CSM_ENCAPS bug; I inadvertently +reintroduced it after the 0.10.12 release. ------------------------------------------------------------------------ -r14530 | ulfl | 2005-06-02 15:52:13 -0500 (Thu, 02 Jun 2005) | 1 line +r15375 | gerald | 2005-08-16 11:04:30 -0500 (Tue, 16 Aug 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-udp.c + M /trunk/epan/dissectors/packet-sflow.c + M /trunk/epan/proto.c + +In packet-sflow.c, don't pass a NULL value pointer to +proto_tree_add_ipv6(). Add tree items for the extended router source +and dest mask, and fix offsets. These changes appear to be correct, +but I don't have a valid capture with extended router data. + +In proto.c, throw a dissector error if we try to pass a NULL value to +various proto_tree_set_*() routines. + +Fixes bug 356. + -use [] not () brackets to indicate [correct] UDP checksum, as this is a generated field ------------------------------------------------------------------------ -r14529 | ulfl | 2005-06-02 15:03:15 -0500 (Thu, 02 Jun 2005) | 1 line +r15374 | sahlberg | 2005-08-16 03:40:06 -0500 (Tue, 16 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-smb.c + +add SetFileInfo level 1013 SetDispositionInfo decoding + -add length information to "Content-encoded entity body" ------------------------------------------------------------------------ -r14528 | ulfl | 2005-06-02 14:31:16 -0500 (Thu, 02 Jun 2005) | 1 line +r15373 | sahlberg | 2005-08-16 02:49:03 -0500 (Tue, 16 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-mount.c + +prettify MNT (and friends) by placing the path in COL_INFO -fix #223: add another tvb_ensure_bytes_exist() call ------------------------------------------------------------------------ -r14527 | ulfl | 2005-06-02 13:52:55 -0500 (Thu, 02 Jun 2005) | 3 lines +r15372 | jmayer | 2005-08-16 01:48:06 -0500 (Tue, 16 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-smb-pipe.c - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/reassemble.c - M /trunk/epan/reassemble.h + M /trunk/epan/prefs.c + -add a generated toplevel line between the TCP protocol and the desegmented content, to better understand what's going on while desegmenting. +Change the default font size on Unix (etc) to 10 pt, just as it was +already on Windows. +Changed the default font to Monospace, as some Linux distributions did +that already. In case this isn't available on all platforms we will +need to change it back to "fixed medium". -We'll have to add similar mechanisms for other protocols as well... ------------------------------------------------------------------------ -r14526 | ulfl | 2005-06-02 13:44:17 -0500 (Thu, 02 Jun 2005) | 1 line +r15371 | jmayer | 2005-08-16 01:45:17 -0500 (Tue, 16 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/gtk/about_dlg.c + M /trunk/gtk/main.c + M /trunk/tethereal.c + M /trunk/version_info.c + M /trunk/version_info.h + +Move SVNVERSION handling into version_info. That way, we won't have +to recompile tethereal.o etc each time the svn version has changed, +relinking is sufficient. + +I'm not sure what to do about mergecap, as it currently doesn't link +against version_info, so it's "overhead" either way. -bugfix (fuzz_tested): t2i can be zero, test at all places before using it ------------------------------------------------------------------------ -r14525 | ulfl | 2005-06-02 13:39:45 -0500 (Thu, 02 Jun 2005) | 1 line +r15370 | guy | 2005-08-16 01:09:39 -0500 (Tue, 16 Aug 2005) | 19 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-ieee80211.c + +Change to match more closely the way I read 802.11h, at least; I'm just +guessing about the "17" indicator for "management notification" frames - +I'm not sure whether, after paying USD 60 to get the current 802.11e +draft, Preview on my Mac could even decrypt it. + +802.11h seems to say in 7.2.3.12 and 7.3.1.11 that the body of an Action +frame has a 1-byte Category field, with a value of 0 meaning "Spectrum +management", followed by, for Spectrum management, a 1-byte Action +field, with 0=Measurement Request, 1=Measurement Report, 2=TPC Request, +3=TPC Report, and 4=Channel Switch Announcement, followed by: + + for all but Channel Switch Announcement, a 1-byte Dialog Token + followed by some tagged parameters; + + for the Channel Switch announcement, some tagged parameters. + +Show some fields given in decimal in various 802.11 specs in decimal, +not hex. -bugfix (fuzz_tested): add tvb_ensure_bytes_exist() before adding a fragment at two places, otherwise we get an access violation ------------------------------------------------------------------------ -r14524 | ulfl | 2005-06-02 13:35:20 -0500 (Thu, 02 Jun 2005) | 1 line +r15369 | guy | 2005-08-16 00:58:50 -0500 (Tue, 16 Aug 2005) | 6 lines Changed paths: - M /trunk/epan/proto.c - M /trunk/epan/proto.h + M /trunk/epan/dissectors/packet-bittorrent.c + +From Peter Johansson: add an option to decode the client information, +and check the validity of messages a bit more carefully. + +Reformat a bit so not as much code is missed by those of us who like +narrow editor windows. -add new function proto_tree_move_item(), which will move an already existing proto_item inside the tree (but it can't be moved to a different "tree level") ------------------------------------------------------------------------ -r14523 | ulfl | 2005-06-02 13:29:29 -0500 (Thu, 02 Jun 2005) | 1 line +r15368 | guy | 2005-08-15 21:04:02 -0500 (Mon, 15 Aug 2005) | 6 lines Changed paths: - M /trunk/epan/proto.c + M /trunk/epan/dissectors/packet-daap.c + +The real problem is that iTunes requests gzipped data and responds with +it, so unless you're reassembling headers and bodies the DAAP dissector +will see the gzipped crap. The HTTP dissector should perhaps not bother +handing gzipped or otherwise unusually-encoded bodies to subdissectors +if it's not undoing the encoding. -show Ethernet and IPX addresses the same way as we do with other fields as well (e.g. IP addresses), first the converted value (e.g. IP address or manufaturer name) and then in brackets the "raw data" ------------------------------------------------------------------------ -r14522 | ulfl | 2005-06-02 02:29:24 -0500 (Thu, 02 Jun 2005) | 3 lines +r15367 | guy | 2005-08-15 20:34:44 -0500 (Mon, 15 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-wbxml.c + M /trunk/epan/dissectors/packet-fc.c -bugfix: don't use match_strval() in combination with format strings (as it may return NULL) but val_to_str() +gcc4 gets confused by the break statements, and I guess it thinks you +can reach them, and thus thinks you can fall off the end of +"fc_get_ftype()". -I don't know if the output as hex is appropriate, someone with more WBXML knowledge might have a look (however, it's done for unknown values only) ------------------------------------------------------------------------ -r14521 | guy | 2005-06-02 02:17:08 -0500 (Thu, 02 Jun 2005) | 2 lines +r15366 | guy | 2005-08-15 20:24:19 -0500 (Mon, 15 Aug 2005) | 2 lines Changed paths: - M /trunk/INSTALL + M /trunk/epan/dissectors/packet-ieee80211.c -Note that this is *not* what you use if you're building from Subversion. +Note where a table comes from, and that we don't use it. ------------------------------------------------------------------------ -r14520 | ulfl | 2005-06-01 19:28:38 -0500 (Wed, 01 Jun 2005) | 1 line +r15365 | lego | 2005-08-15 20:01:17 -0500 (Mon, 15 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/emem.h + +se_alloc not ep_alloc! + -add the resolved Ethernet addresses to the "Ethernet II" summary line ------------------------------------------------------------------------ -r14519 | ulfl | 2005-06-01 18:47:55 -0500 (Wed, 01 Jun 2005) | 1 line +r15364 | lego | 2005-08-15 19:55:08 -0500 (Mon, 15 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/emem.c + M /trunk/epan/emem.h + +more allocators se_alloc0() se_memdups() se_strdup() se_strndup() se_strdup_printf() -add a reference to the corresponding RFC's of the Differentiated Services field pref setting ------------------------------------------------------------------------ -r14518 | ulfl | 2005-06-01 18:44:24 -0500 (Wed, 01 Jun 2005) | 5 lines +r15363 | jmayer | 2005-08-15 16:06:09 -0500 (Mon, 15 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c - -add some hidden fields to be able to filter on the resolved hostname "ip.host" / "ip.src_host" / "ip.dst_host", this was formerly not possible. + M /trunk/manuf + M /trunk/wka.tmpl -replace some deprecated proto_tree_add_..._hidden() calls by seperate calls by proto_tree_add_...() and PROTO_ITEM_SET_HIDDEN() +- Update manuf +- Add some Extreme MAC addresses to wka.tmpl -some other cosmetic changes ------------------------------------------------------------------------ -r14517 | ulfl | 2005-06-01 16:28:40 -0500 (Wed, 01 Jun 2005) | 1 line +r15362 | jmayer | 2005-08-15 15:31:57 -0500 (Mon, 15 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-frame.c + M /trunk/idl2eth.sh + +- Change $1 to $@ +- Don't exit if we can't find the scripts - try to continue anyway, + as they might be installed in some preconfigured system directory. -mark some fields as generated and clarify some field descriptions ------------------------------------------------------------------------ -r14516 | ulfl | 2005-06-01 14:19:40 -0500 (Wed, 01 Jun 2005) | 1 line +r15361 | gerald | 2005-08-15 15:28:04 -0500 (Mon, 15 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-telnet.c + +When we create a new tvb, make sure the memory is freed at some point. -prevent "Dissector Bug": prevent a string processing of length 0 ------------------------------------------------------------------------ -r14515 | ulfl | 2005-06-01 14:17:59 -0500 (Wed, 01 Jun 2005) | 1 line +r15360 | etxrab | 2005-08-15 14:35:09 -0500 (Mon, 15 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-windows-common.c + M /trunk/epan/dissectors/packet-gsm_sms.c -bugfix: use g_snprintf instead of sprintf to prevent a buffer overflow +TP-PI (TP-Parameter-Indicator) is optional. ------------------------------------------------------------------------ -r14514 | etxrab | 2005-06-01 01:47:15 -0500 (Wed, 01 Jun 2005) | 5 lines +r15359 | jmayer | 2005-08-15 10:50:25 -0500 (Mon, 15 Aug 2005) | 1 line Changed paths: - M /trunk/ethereal_gen.py + M /trunk/epan/dissectors/packet-extreme.c -From Paolo Frigo : -A new plugin based on GIOP to recognize Tango packets. TANGO is -an object oriented distributed control system based on CORBA. Tango is -being actively developed as a collaborative effort among the ESRF, Soleil, Elettra and ALBA synchrotron facilities. TANGO is an open source -project hosted by SourceForge. +Properly dissect vlan flags ------------------------------------------------------------------------ -r14513 | etxrab | 2005-06-01 01:46:41 -0500 (Wed, 01 Jun 2005) | 5 lines +r15358 | jmayer | 2005-08-15 07:41:08 -0500 (Mon, 15 Aug 2005) | 5 lines Changed paths: - M /trunk/plugins/giop/Makefile.am - M /trunk/plugins/giop/Makefile.nmake - M /trunk/plugins/giop/README - A /trunk/plugins/giop/packet-tango.c + M /trunk/epan/dissectors/packet-extreme.c + +- Documentation update +- The slot and port numbers printed on the chassis are off by + one when compared to the transmitted values (reported by + Jim Young). -From Paolo Frigo : -A new plugin based on GIOP to recognize Tango packets. TANGO is -an object oriented distributed control system based on CORBA. Tango is -being actively developed as a collaborative effort among the ESRF, Soleil, Elettra and ALBA synchrotron facilities. TANGO is an open source -project hosted by SourceForge. ------------------------------------------------------------------------ -r14512 | lroland | 2005-05-31 16:34:14 -0500 (Tue, 31 May 2005) | 3 lines +r15357 | sahlberg | 2005-08-15 07:04:15 -0500 (Mon, 15 Aug 2005) | 3 lines Changed paths: - M /trunk/config.nmake - M /trunk/plugins/stats_tree/Makefile.nmake + M /trunk/epan/dissectors/packet-icep.c + M /trunk/epan/dissectors/packet-icmpv6.c + +ememify g_malloc() calls -Add a note to config.nmake that it is required to set ENABLE_LIBETHEREAL to get plugin support in Ethereal. -Change Makefile.nmake of the stats_tree plugin to the current scheme. ------------------------------------------------------------------------ -r14511 | ulfl | 2005-05-31 16:30:40 -0500 (Tue, 31 May 2005) | 1 line +r15356 | sahlberg | 2005-08-15 06:53:57 -0500 (Mon, 15 Aug 2005) | 4 lines Changed paths: - M /trunk/doc/ethereal.pod - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-ldp.c + +ememify g_malloc() calls + + -add new command line flag "-g", will go to a given packet, after loading a capture file with -r ------------------------------------------------------------------------ -r14510 | ulfl | 2005-05-31 16:17:54 -0500 (Tue, 31 May 2005) | 1 line +r15355 | jmayer | 2005-08-14 18:25:20 -0500 (Sun, 14 Aug 2005) | 1 line Changed paths: + M /trunk/capture_sync.c + M /trunk/color_filters.c + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-atalk.c + M /trunk/epan/dissectors/packet-atalk.h + M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-rpc.c M /trunk/file.c + M /trunk/fileset.c + M /trunk/g711.c + M /trunk/gtk/menu.c + M /trunk/packet-range.c -convenience: if a "Go To Packet" didn't succeeded, add the requested packet number to the error message, +Some 'no previous declararion' warning fixes ------------------------------------------------------------------------ -r14509 | lroland | 2005-05-31 15:42:15 -0500 (Tue, 31 May 2005) | 3 lines +r15354 | sahlberg | 2005-08-14 01:00:20 -0500 (Sun, 14 Aug 2005) | 9 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/plugins/Makefile.nmake + M /trunk/epan/dissectors/packet-sip.c + +ememify sip and at the same plug a memleak + +every single time the sip dissector was called a 32byte or larger blob was g_malloced and never freed. +this not only leaks 32+ bytes + g_malloc bookkeeping overhead but also fragments memory so the real leak of memory is likely much bigger. + + +fix bad memleak -As suggested by Jaap Keuter: -Add generated files copied by "install-deps" to the -"clean" target ------------------------------------------------------------------------- -r14508 | ulfl | 2005-05-31 13:31:27 -0500 (Tue, 31 May 2005) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-dcom-remact.c -better dissect ProtSeqs values ------------------------------------------------------------------------ -r14507 | ulfl | 2005-05-31 13:30:37 -0500 (Tue, 31 May 2005) | 1 line +r15353 | sahlberg | 2005-08-14 00:54:54 -0500 (Sun, 14 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom-cba.c + M /trunk/epan/dissectors/packet-cip.c + +ememify cip + + -bugfix: remove some not required dissect_dcom_that() calls, as "ORPC that" was errorneously dissected twice ------------------------------------------------------------------------ -r14506 | ulfl | 2005-05-31 13:27:20 -0500 (Tue, 31 May 2005) | 3 lines +r15352 | sahlberg | 2005-08-14 00:50:14 -0500 (Sun, 14 Aug 2005) | 8 lines Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/epan/dissectors/packet-dcm.c + +change a g_malloc() that was never released into ep_alloc() + +this function would always leak memory when called. + +this fixes a memleak in dcm + -add another tvb_ensure_bytes_exist() call -replace dissect_ndr_uuid_t by dissect_dcerpc_uuid_t, as this is the correct function to use and will prevent a problem with access to non existing private_data in dissect_ndr_uuid_t ------------------------------------------------------------------------ -r14505 | gram | 2005-05-31 09:07:16 -0500 (Tue, 31 May 2005) | 4 lines +r15351 | sahlberg | 2005-08-14 00:37:12 -0500 (Sun, 14 Aug 2005) | 7 lines Changed paths: - M /trunk/AUTHORS - M /trunk/print.c + M /trunk/epan/dissectors/packet-x11.c + +ememify packet-x11 + + +plug a memleak for ...].strptr that is alloced by g_malloc() but never released. + -Put 'unmaskedvalue' field in XML for bit-masked values. -Fix interpretation of 'value' field. -Patch from Vasanth Manickam. ------------------------------------------------------------------------ -r14504 | gram | 2005-05-31 09:03:34 -0500 (Tue, 31 May 2005) | 3 lines +r15350 | sahlberg | 2005-08-13 20:48:43 -0500 (Sat, 13 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-giop.c + +giop allocates only and never releases the memory from the gmemchunk so replace it with equivalen g_malloc() calls and get rid of the gmemchunks -Remove bitmasks from field definitions for FT_IPv4 -and FT_IPv6 fields. ------------------------------------------------------------------------ -r14503 | ulfl | 2005-05-31 03:02:24 -0500 (Tue, 31 May 2005) | 2 lines +r15349 | sahlberg | 2005-08-13 20:41:55 -0500 (Sat, 13 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-tds.c + +the tds dissector were only using a GMemChunk as a simple way to prevent memleaks in case of an exception. (reset the gmemchunk at the start of each packet) + +replace this gmemchunk with ep_alloc() + -fix handling, if ArraySize of a BSTR is 0, -replace a g_assert by DISSECTOR_ASSERT ------------------------------------------------------------------------ -r14502 | ulfl | 2005-05-30 17:40:55 -0500 (Mon, 30 May 2005) | 1 line +r15348 | sahlberg | 2005-08-13 20:26:34 -0500 (Sat, 13 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/reassemble.c + +remove two more GMemChunks + -add a tvb_ensure_bytes_exist() to prevent a dissector bug ------------------------------------------------------------------------ -r14501 | ulfl | 2005-05-30 16:10:21 -0500 (Mon, 30 May 2005) | 3 lines +r15347 | sahlberg | 2005-08-13 19:37:05 -0500 (Sat, 13 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/h225-persistentdata.c + +get rid of another two GMemChunks -don't go into an (almost) endless loop, if si->info_count is -1, which is the default value. Seems to be a general bug worth to thought about, but I don't know the SMB internals and this bugfix should work anyway. -Found this by a privately fuzzed capture file (sorry, can't give it away) ------------------------------------------------------------------------ -r14500 | gerald | 2005-05-30 16:08:16 -0500 (Mon, 30 May 2005) | 2 lines +r15346 | sahlberg | 2005-08-13 19:26:56 -0500 (Sat, 13 Aug 2005) | 8 lines Changed paths: - M /trunk/wiretap/netmon.c + M /trunk/epan/packet.c + +Data sources have a lifetime spanning a single packet +so instead for g-alloc and g_free data +just use ep_alloc() that is automatically freed instead. + +this also gets rid of one more GMemChunk + -From Steve Grubb: Fix a memory leak. Fixes part of bug 217. ------------------------------------------------------------------------ -r14499 | gerald | 2005-05-30 16:04:58 -0500 (Mon, 30 May 2005) | 3 lines +r15345 | sahlberg | 2005-08-13 19:10:41 -0500 (Sat, 13 Aug 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-telnet.c + M /trunk/epan/dissectors/packet-scsi.c + +add dissection of two more SSC commands + + +add 4 commands from SMC to the SSC tables. +the fallback for missing commands/i.e. commands defined outside the SSC +only handles SPC I.e. If a command for SSC is missing in the SSC tables, assume it might be imported from SPC instead. + +This fallback only works with opcodes imported from SPC. -Don't try to check the suboption length type if we don't have a suboption. -Found by Steve Grubb. Fixes part of bug 217. ------------------------------------------------------------------------ -r14498 | gerald | 2005-05-30 16:01:52 -0500 (Mon, 30 May 2005) | 2 lines +r15344 | guy | 2005-08-13 17:35:50 -0500 (Sat, 13 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-extreme.c + +Use gboolean for Booleans. -From Steve Grubb: Fix buffer and array length checks. Fixes part of bug 217. +Use "proto_tree_add_item()" whenever possible. ------------------------------------------------------------------------ -r14497 | gerald | 2005-05-30 16:00:05 -0500 (Mon, 30 May 2005) | 2 lines +r15343 | guy | 2005-08-13 17:34:44 -0500 (Sat, 13 Aug 2005) | 3 lines Changed paths: M /trunk/epan/dissectors/packet-ieee8023.c - M /trunk/epan/dissectors/packet-isl.c -From Steve Grubb: Initialize some variables. Fixes part of bug 217. +Construct the tvbuff for the payload of an 802.3 packet to have the +appropriate length (min(reported length, captured data present)). ------------------------------------------------------------------------ -r14496 | gerald | 2005-05-30 15:58:20 -0500 (Mon, 30 May 2005) | 2 lines +r15342 | guy | 2005-08-13 17:08:22 -0500 (Sat, 13 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-cpfi.c - M /trunk/epan/dissectors/packet-dcm.c - M /trunk/epan/dissectors/packet-dcom-cba-acco.c - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-rpc.c -More bug fixes from Steve Grubb. See bug 217 for details. +Properly terminate the string generated for string items. + +Use "format_text()" to handle non-printable characters in the display +string for those items. ------------------------------------------------------------------------ -r14495 | gerald | 2005-05-30 15:55:16 -0500 (Mon, 30 May 2005) | 6 lines +r15341 | guy | 2005-08-13 17:05:01 -0500 (Sat, 13 Aug 2005) | 13 lines Changed paths: - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-scsi.c + +Get rid of unused variables. -From Steve Grubb: Fix a memory leak. +Use "tvb_format_text()" and friends to format strings for display. -Don't pass a null to atoi(). +Don't throw an exception on errors if we can keep dissecting. -Fixes part of bug 217. +Use "PROTO_ITEM_SET_GENERATED()" to mark items as generated. ------------------------------------------------------------------------- -r14494 | gerald | 2005-05-30 15:53:08 -0500 (Mon, 30 May 2005) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-bootp.c +If an item covers real data, it's not generated. -From Steve Grubb: Fix off by one errors. Fixes part of bug 217. +Dissect WRITE FILEMARKS (6) (we already had a dissector, but it wasn't +being used). ------------------------------------------------------------------------ -r14493 | gerald | 2005-05-30 15:51:36 -0500 (Mon, 30 May 2005) | 2 lines +r15340 | gerald | 2005-08-13 13:52:41 -0500 (Sat, 13 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/docbook/release-notes.xml -From Steve Grubb: Initialize a variable. Fixes part of bug 217. +Add an item for CSM_ENCAPS. ------------------------------------------------------------------------ -r14492 | gerald | 2005-05-30 15:48:12 -0500 (Mon, 30 May 2005) | 6 lines +r15339 | gerald | 2005-08-13 13:49:57 -0500 (Sat, 13 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/column.c + M /trunk/epan/dissectors/packet-csm-encaps.c -Fix an off-by-one error found by Steve Grubb. Steve gets the award -for longest standing bug found so far. This has been present since -version 0.5.0. +Fix another infinite loop found by randpkt. -Fixes part of bug 217. +------------------------------------------------------------------------ +r15338 | etxrab | 2005-08-13 05:17:20 -0500 (Sat, 13 Aug 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-gsm_a.c +Get rid of an unused variable, don't include tcap.h and remove some redundant code. ------------------------------------------------------------------------ -r14491 | etxrab | 2005-05-30 13:39:39 -0500 (Mon, 30 May 2005) | 3 lines +r15337 | etxrab | 2005-08-13 05:11:23 -0500 (Sat, 13 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-gsm_a.c -Add dissection of MSRP -http://www.ietf.org/internet-drafts/draft-ietf-simple-message-sessions-10.txt +From Peter Johansson: +mnc>>4; Should be replaced with mnc = mnc>>4; ------------------------------------------------------------------------ -r14490 | ulfl | 2005-05-30 13:37:19 -0500 (Mon, 30 May 2005) | 7 lines +r15336 | guy | 2005-08-13 03:10:12 -0500 (Sat, 13 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/debian/ethereal-root.desktop -fix highlighting length, if more than one RPC call is in a TCP PDU +"fi" comes before "fr" in alphabetical order. (This also makes it match +the main "ethereal.desktop" file.) -set "n*DCERPC" in the proto column if more than one RPC call in a TCP PDU, overwriting the interface name, as there's probably more than one interface involved +Expand the RCS ID. -add some more RPC info to the toplevel RPC proto_item - -add a comment, if some bytes are not dissected but might be in the next TCP PDU ------------------------------------------------------------------------ -r14489 | gerald | 2005-05-30 11:49:47 -0500 (Mon, 30 May 2005) | 2 lines +r15335 | guy | 2005-08-13 02:30:57 -0500 (Sat, 13 Aug 2005) | 9 lines Changed paths: - M /trunk/editcap.c + M /trunk/epan/dissectors/packet-tcp.c -Add random bit errors to the fuzz tests. +Do the sequence number analysis *before* dissecting the payload, so we +don't have to worry about catching exceptions in the payload dissection +and doing the sequence number analysis - we weren't doing so in one +place. That also puts the sequence number analysis *before* the "TCP +payload" entry for payload being reassembled into a later packet. + +XXX - should we do the tapping before dissecting the payload, too, so +that it gets done even if we throw an exception? ------------------------------------------------------------------------ -r14488 | gerald | 2005-05-30 11:03:24 -0500 (Mon, 30 May 2005) | 3 lines +r15334 | jmayer | 2005-08-13 01:42:19 -0500 (Sat, 13 Aug 2005) | 1 line Changed paths: - M /trunk/plugins/giop/packet-coseventcomm.c - M /trunk/plugins/giop/packet-cosnaming.c + M /trunk/idl2eth.sh -Throw an exception if we're handed a null pointer when we weren't -expecting one. Fixes bug 200. +Small optimization +------------------------------------------------------------------------ +r15333 | jmayer | 2005-08-13 01:29:09 -0500 (Sat, 13 Aug 2005) | 1 line +Changed paths: + M /trunk/ethereal.desktop +Additions from current Suse and Debian ------------------------------------------------------------------------ -r14487 | gerald | 2005-05-30 10:51:03 -0500 (Mon, 30 May 2005) | 2 lines +r15332 | sahlberg | 2005-08-13 01:21:37 -0500 (Sat, 13 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/megaco/packet-megaco.c + M /trunk/epan/epan.c + M /trunk/epan/frame_data.c + M /trunk/epan/frame_data.h + +get rid of one more gmemchunk -Break out of an infinite loop. Fixes bugs 213 & 214. ------------------------------------------------------------------------ -r14486 | sahlberg | 2005-05-30 07:09:39 -0500 (Mon, 30 May 2005) | 3 lines +r15331 | jmayer | 2005-08-13 00:55:06 -0500 (Sat, 13 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/debian/changelog + M /trunk/debian/control + M /trunk/debian/ethereal-common.files + M /trunk/debian/ethereal-common.manpages + M /trunk/debian/ethereal-dev.docs + M /trunk/debian/ethereal-dev.files + M /trunk/debian/ethereal-dev.header-files + M /trunk/debian/ethereal-dev.manpages + M /trunk/debian/ethereal-dev.postinst + M /trunk/debian/ethereal-dev.prerm + A /trunk/debian/ethereal-root.desktop + M /trunk/debian/ethereal.files + M /trunk/debian/ethereal.manpages + M /trunk/debian/ethereal.menu + A /trunk/debian/patches + A /trunk/debian/patches/00list + A /trunk/debian/patches/01_idl2deb.dpatch + A /trunk/debian/patches/02_asn2deb.dpatch + A /trunk/debian/patches/03_preferences.dpatch + A /trunk/debian/patches/04_drop-capabilities.dpatch + A /trunk/debian/patches/05_plugin-libdir.dpatch + A /trunk/debian/patches/06_giop-buffer.dpatch + A /trunk/debian/patches/07_gcc4.dpatch + A /trunk/debian/patches/08_ethereal-desktop-menu.dpatch + A /trunk/debian/patches/09_idl2eth.dpatch + A /trunk/debian/patches/10_ethereal_gen.dpatch + A /trunk/debian/patches/11_diameter_vendors.dpatch + M /trunk/debian/rules + M /trunk/debian/tethereal.files + M /trunk/debian/tethereal.manpages -add MMC READ DISC INFORMATION cdb +Aplly those parts of ethereal_0.10.12-3.diff.gz +from Debian, that change debian/ ------------------------------------------------------------------------ -r14485 | sahlberg | 2005-05-30 06:16:08 -0500 (Mon, 30 May 2005) | 3 lines +r15330 | sahlberg | 2005-08-12 21:24:11 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/circuit.c -add MMC READ TRACK INFORMATION cdb +more gmemchunk -> se_alloc() conversions ------------------------------------------------------------------------ -r14484 | ulfl | 2005-05-29 23:46:25 -0500 (Sun, 29 May 2005) | 1 line +r15329 | sahlberg | 2005-08-12 21:19:03 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/capture_opts.c - M /trunk/capture_sync.c - M /trunk/doc/ethereal.pod - M /trunk/gtk/main.c + M /trunk/epan/conversation.c + +start converting gmemchunk into se_alloc() in /epan + -fix #148: (win32 only) use command line parameter -B to set capture buffer size ------------------------------------------------------------------------ -r14483 | ulfl | 2005-05-29 23:06:22 -0500 (Sun, 29 May 2005) | 3 lines +r15328 | sahlberg | 2005-08-12 20:29:31 -0500 (Fri, 12 Aug 2005) | 10 lines Changed paths: - M /trunk/doc/ethereal.pod - M /trunk/gtk/main.c - M /trunk/gtk/recent.c - M /trunk/gtk/recent.h + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-dcerpc-nt.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-ncp.c + M /trunk/epan/dissectors/packet-ntlmssp.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-ssh.c + M /trunk/epan/dissectors/packet-wcp.c + +some more gmemchunk -> se_alloc() updates + + +there are only 5 gmemchunks left but they have different litetime for their allocations than the 100+ ones that have been removed. + +The remaining 5 should be converted some other way. + + -First part to fix #148: use command line parameter -o not only for preferences but also for recent settings. -This way we can simply remove the GUI related command line parameters -B, -P and -T, which are useless now. ------------------------------------------------------------------------ -r14482 | ulfl | 2005-05-29 22:10:37 -0500 (Sun, 29 May 2005) | 1 line +r15327 | sahlberg | 2005-08-12 19:03:12 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-afs.c + +gmemchunk -> se_alloc() improvements + -fix #215: the field hf_smb_print_spool_file_name used the wrong type, use FT_STRINGZ to add a string ------------------------------------------------------------------------ -r14481 | ulfl | 2005-05-29 21:58:13 -0500 (Sun, 29 May 2005) | 3 lines +r15326 | sahlberg | 2005-08-12 18:57:01 -0500 (Fri, 12 Aug 2005) | 2 lines Changed paths: M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-nfs.c -add two more tvb_ensure_bytes_exist() calls to fix #216 +gmemchunk -> se_alloc() improvements -When I look at the remaining code, I fear this will become a never ending story :-( ------------------------------------------------------------------------ -r14480 | ulfl | 2005-05-29 09:09:58 -0500 (Sun, 29 May 2005) | 1 line +r15325 | sahlberg | 2005-08-12 18:46:46 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/recent.c + M /trunk/epan/dissectors/packet-tcp.c + +some gmemchunk -> se_alloc() improvements for tcp + -clarify some recent file entry descriptions ------------------------------------------------------------------------ -r14479 | ulfl | 2005-05-29 08:02:57 -0500 (Sun, 29 May 2005) | 1 line +r15324 | sahlberg | 2005-08-12 18:34:59 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-ajp13.c + M /trunk/epan/dissectors/packet-aoe.c + +gmemchunk -> se_alloc() improvements + -fix #201: add format_text before output of the DNS name, in case it contains invalid chars ------------------------------------------------------------------------ -r14478 | ulfl | 2005-05-29 07:27:31 -0500 (Sun, 29 May 2005) | 1 line +r15323 | sahlberg | 2005-08-12 18:29:19 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rsync.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-eap.c + +gmemchunk -> se_alloc() improvements + -fix #86: use format_text before adding version string to the info column ------------------------------------------------------------------------ -r14477 | ulfl | 2005-05-29 06:23:42 -0500 (Sun, 29 May 2005) | 1 line +r15322 | sahlberg | 2005-08-12 18:17:30 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/proto.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcdns.c + M /trunk/epan/dissectors/packet-fcels.c + M /trunk/epan/dissectors/packet-fcswils.c + +gmemchunk -> se_alloc() improvements + -fix #11: add a [truncated] to the label, if the message to display is too long ------------------------------------------------------------------------ -r14476 | sahlberg | 2005-05-29 03:45:09 -0500 (Sun, 29 May 2005) | 3 lines +r15321 | sahlberg | 2005-08-12 18:00:01 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-fcfcs.c + M /trunk/epan/dissectors/packet-fcfzs.c + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-iscsi.c -add MMC RESERVE TRACK cdb +more gmemchunk -> se_alloc() improvements ------------------------------------------------------------------------ -r14475 | sahlberg | 2005-05-29 03:29:55 -0500 (Sun, 29 May 2005) | 3 lines +r15320 | jmayer | 2005-08-12 17:55:58 -0500 (Fri, 12 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-extreme.c -MMC SET STREAMING command +Fix dissector bug on last element of ESRP +------------------------------------------------------------------------ +r15319 | sahlberg | 2005-08-12 17:12:32 -0500 (Fri, 12 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-x11.c + +more gmemchunk->se_alloc() improvements ------------------------------------------------------------------------ -r14474 | jmayer | 2005-05-29 03:19:11 -0500 (Sun, 29 May 2005) | 5 lines +r15318 | sahlberg | 2005-08-12 16:29:06 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c - + M /trunk/epan/dissectors/packet-rdt.c + M /trunk/epan/dissectors/packet-sip.c -Add minimal 802.11j decoding. There's not fun in doing more unless -someone provides a capture file. +gmemchunk -> se_alloc() improvements ------------------------------------------------------------------------ -r14473 | sahlberg | 2005-05-28 22:18:53 -0500 (Sat, 28 May 2005) | 3 lines +r15317 | sahlberg | 2005-08-12 16:21:49 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-fcp.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/epan/dissectors/packet-ndmp.c - M /trunk/epan/dissectors/packet-scsi.c - M /trunk/epan/dissectors/packet-scsi.h + M /trunk/epan/dissectors/packet-socks.c + M /trunk/epan/dissectors/packet-vj.c -remove offset and len from the signature of dissect_scsi_payload() +gmemchunk -> se_alloc() updates ------------------------------------------------------------------------ -r14472 | sahlberg | 2005-05-28 21:55:12 -0500 (Sat, 28 May 2005) | 6 lines +r15316 | etxrab | 2005-08-12 16:08:02 -0500 (Fri, 12 Aug 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-fcp.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/epan/dissectors/packet-ndmp.c - M /trunk/epan/dissectors/packet-scsi.c - M /trunk/epan/dissectors/packet-scsi.h + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.h -make all callers of dissect_scsi_cdb() first create a new subset tvb +From Hannes Gredler -change the signature for dissect_scsi_cdb since we no longer need to pass offset over. +- add support for Multi-Link Frame-Relay (FRF.15) captures + taken on Juniper ML-, LS-, AS- PICs. +- rework of the common juniper header dissector: + test the extension flag (0x80) which indicates that there are + meta-information like interface-index, interface-name etc. + present +- minor bugfix (LSQ L3-proto masks, direction masks were broken) ------------------------------------------------------------------------ -r14471 | sahlberg | 2005-05-28 21:30:49 -0500 (Sat, 28 May 2005) | 3 lines +r15315 | gerald | 2005-08-12 11:32:28 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-giop.c -create a subset tvb before calling off to the SCSI dissector -so that the right part of the hexpane is highlighted when one clicks on an nondissected data line +Don't try to allocate more than ITEM_LABEL_LENGTH bytes for something we're +adding to the tree. Fixes bugs 349 and 352. ------------------------------------------------------------------------ -r14470 | sahlberg | 2005-05-28 20:54:22 -0500 (Sat, 28 May 2005) | 6 lines +r15314 | gerald | 2005-08-12 10:27:11 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-dcerpc.c -minor prettification +Fix the length that we pass to proto_tree_add_uint_format() so that we don't +throw a dissector error. Fixes bug 348. -in the decode pane for the SCSI protocol, -put the name of the CDB on the protocol line +------------------------------------------------------------------------ +r15313 | jmayer | 2005-08-12 09:05:38 -0500 (Fri, 12 Aug 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-extreme.c +- Bug fix: Show ip-addresses with correct endianess. +- Show version properly +- VLAN ID was at a different place than expected. +- Add some documentation infos ------------------------------------------------------------------------ -r14469 | sahlberg | 2005-05-28 20:49:09 -0500 (Sat, 28 May 2005) | 5 lines +r15312 | sahlberg | 2005-08-12 05:50:55 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-iscsi.c - -update iscsi so that when we have ImmediateData we also call SCSI to decode the -payload (DATAOUT) and not just the scsi CDB. + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-rtsp.c +more gmemchunk -> se_alloc() improvements ------------------------------------------------------------------------ -r14468 | sahlberg | 2005-05-28 18:05:41 -0500 (Sat, 28 May 2005) | 4 lines +r15311 | sahlberg | 2005-08-12 05:41:22 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/mgcp/packet-mgcp.c + M /trunk/epan/dissectors/packet-atalk.c -from Alejandro Vaquero -fox to packet-mgcp.c to make the viop analysis working again. +more gmemchunk -> se_alloc() improvements ------------------------------------------------------------------------ -r14467 | sahlberg | 2005-05-28 08:29:45 -0500 (Sat, 28 May 2005) | 3 lines +r15310 | sahlberg | 2005-08-12 05:29:09 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-ldap.c -add MMC READ BUFFER CAPACITY command +more gmemchunk -> se_alloc() improvements ------------------------------------------------------------------------ -r14466 | sahlberg | 2005-05-28 08:01:14 -0500 (Sat, 28 May 2005) | 3 lines +r15309 | sahlberg | 2005-08-12 05:21:14 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-beep.c + M /trunk/epan/dissectors/packet-rlogin.c -add the SynchronizeCache command for MMC +some more gmemchunk -> se_alloc() improvements ------------------------------------------------------------------------ -r14465 | ulfl | 2005-05-28 07:49:19 -0500 (Sat, 28 May 2005) | 1 line +r15308 | sahlberg | 2005-08-12 05:03:17 -0500 (Fri, 12 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-smtp.c + +remove some unused variables from scsi + +change two gmemchunks in smtp to se_alloc() and remove one now redundant init routine. + -add some tvb_ensure_bytes_exist() calls, fixes #197, #202 and #208 ------------------------------------------------------------------------ -r14464 | sahlberg | 2005-05-28 07:45:38 -0500 (Sat, 28 May 2005) | 3 lines +r15307 | sahlberg | 2005-08-12 04:56:28 -0500 (Fri, 12 Aug 2005) | 4 lines Changed paths: + M /trunk/epan/dissectors/packet-msproxy.c M /trunk/epan/dissectors/packet-scsi.c -updates to mmc, add more dissection of GET_CONFIGURATION and READ_TOC +add missing include to scsi +change two gmemchunks to se_alloc() for msproxy ------------------------------------------------------------------------ -r14463 | ulfl | 2005-05-28 06:04:11 -0500 (Sat, 28 May 2005) | 1 line +r15306 | jmayer | 2005-08-12 04:56:13 -0500 (Fri, 12 Aug 2005) | 1 line Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-extreme.c -prevent unused function warning +EDS/EAPS/EPRS mostly finished - several fixmes remain ------------------------------------------------------------------------ -r14462 | sahlberg | 2005-05-28 03:27:44 -0500 (Sat, 28 May 2005) | 2 lines +r15305 | sahlberg | 2005-08-12 04:47:33 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/libethereal.def + +add some symbols to libethereal.def -some more MMC4 updates ------------------------------------------------------------------------ -r14461 | sahlberg | 2005-05-28 00:42:39 -0500 (Sat, 28 May 2005) | 6 lines +r15304 | sahlberg | 2005-08-12 04:31:07 -0500 (Fri, 12 Aug 2005) | 4 lines Changed paths: M /trunk/epan/dissectors/packet-scsi.c -more scsi refactoring - -starting to implement MMC codeset : CDROM/DVD +oops forgot to delete a variable ------------------------------------------------------------------------ -r14460 | sahlberg | 2005-05-27 22:37:16 -0500 (Fri, 27 May 2005) | 5 lines +r15303 | sahlberg | 2005-08-12 04:30:24 -0500 (Fri, 12 Aug 2005) | 15 lines Changed paths: M /trunk/epan/dissectors/packet-scsi.c -refactor scsi dissector toi be table driven so it will be easier to add new -commandsets. + get rid of some unnessecary GMemChunks. + + +These GMemChunks are used here because : +1, GMemChunks are cheap to allocate and cheap to free +2, We always unconditionally free the entire chunk When and only when we load a new capture. + +==> +se_alloc() does exactly the same thing but with significantly less code + +==> +se_alloc() is a much better fit to out allocation requirements and useage than GMemChunks ------------------------------------------------------------------------ -r14459 | obiot | 2005-05-27 19:51:56 -0500 (Fri, 27 May 2005) | 2 lines +r15302 | tuexen | 2005-08-12 04:16:51 -0500 (Fri, 12 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-image-gif.c + M /trunk/epan/dissectors/packet-asap.c -From Gilbert Ramirez - Fix a FT_NONE with a bitmask (shouldn't have one). +Fix handling of ASAP_ENDPOINT_KEEP_ALIVE message. ------------------------------------------------------------------------ -r14458 | sahlberg | 2005-05-27 16:39:38 -0500 (Fri, 27 May 2005) | 7 lines +r15301 | sahlberg | 2005-08-12 03:51:08 -0500 (Fri, 12 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-kink.c + M /trunk/epan/emem.c + M /trunk/epan/emem.h + M /trunk/epan/packet.c + M /trunk/gtk/main.c + M /trunk/tethereal.c -from Gilbert, +Add beginning of seasonal allocation in addition to the existing ephemeral ones. -make kink compile again on non-kerberos builds. -encapsulate a call to decrypt kerberos to only be compiled in when compiling with kerberos. +------------------------------------------------------------------------ +r15300 | guy | 2005-08-12 02:47:27 -0500 (Fri, 12 Aug 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-iax2.c +In an "address" structure, "data" is a pointer; dereferencing "&data" +doesn't give you the address value, it gives a pointer to the address +value. + +Don't assume that pointer is aligned on a 32-bit boundary. ------------------------------------------------------------------------ -r14457 | sahlberg | 2005-05-27 16:33:27 -0500 (Fri, 27 May 2005) | 3 lines +r15299 | jmayer | 2005-08-11 23:06:04 -0500 (Thu, 11 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-extreme.c -from didier fix for the regression for bug 62 +Beginnings of a EDP, ESRP and EAPS dissector +------------------------------------------------------------------------ +r15298 | lego | 2005-08-11 18:51:35 -0500 (Thu, 11 Aug 2005) | 3 lines +Changed paths: + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + +avoid throwing a malformed packet ------------------------------------------------------------------------ -r14456 | etxrab | 2005-05-27 13:35:19 -0500 (Fri, 27 May 2005) | 7 lines +r15297 | jmayer | 2005-08-11 18:18:46 -0500 (Thu, 11 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rdt.c + M /trunk/epan/dissectors/packet-llc.c -From Martin Mathieson -packet-rdt.c: -- register a configurable UDP port (off by default, but needed where setup traffic isn't captured) -- dissect extra 'buffer info' fields -- move bit fields into 'flags' subtrees -- misc. minor fixes and improvements (mainly formatting) -Missed eralier... +Add Extreme OUI, reorder alphabetically ------------------------------------------------------------------------ -r14455 | lego | 2005-05-27 13:33:09 -0500 (Fri, 27 May 2005) | 4 lines +r15296 | etxrab | 2005-08-11 15:47:09 -0500 (Thu, 11 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/prefs.c + M /trunk/epan/dissectors/packet-gsm_a.c + +From Rene Pilz: +The MCC/MNC in de_gmm_rai is not correct decoded +------------------------------------------------------------------------ +r15295 | etxrab | 2005-08-11 15:14:41 -0500 (Thu, 11 Aug 2005) | 16 lines +Changed paths: + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-giop.h + M /trunk/ethereal_gen.py + +From W. Borgert: +three trivial corrections for the GIOP dissector: + +- allow filtering GIOP exceptions, e.g. "giop.replystatus = 2" + or "giop.exceptionid matches MyError", older patch at + http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314835 -don't use a static buffer for preference values, allocate it, and, if necessary reallocate so that -the string always fits. +- show IDLs sequence<octet> more compact, not one line per + octet, older patch at + http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314836 +- decode _is_a requests and replies, older patch at + http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314871 + +With a change to not create a malformed packet in the "stub data". ------------------------------------------------------------------------ -r14454 | gram | 2005-05-27 10:13:09 -0500 (Fri, 27 May 2005) | 5 lines +r15294 | lego | 2005-08-11 13:21:23 -0500 (Thu, 11 Aug 2005) | 9 lines Changed paths: - M /trunk/clopts_common.c - M /trunk/epan/proto.c - A /trunk/tools/ftsanity.py + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + +Change a switch into an "if else if else if else" that fixes the "too large for switch" in HP-UX 10.20 . + +The generated file has a lot of indentation changes due probably to a change in asn2eth. + +The underlying reason for which I added this code (dissect_ber_integer() would not add as a "filterable" field if it is larger than 4 bytes, should be handled in dissect_ber_integer() ) remains there. + +Should we change dissect_ber_integer() itself to make sure that a 5 byte unsigned integer which fits in 4 bytes gets added to the tree as "filterable"? -Add a "-G fields3" report which prints the bitmask of the field, and avoids -printing the blurb twice, like fields2 does. -Add a script, fsanity.py, to check sanity of FT definitions. Right now the -only check is for bitmasks for integer-like fields. ------------------------------------------------------------------------ -r14453 | sahlberg | 2005-05-27 03:53:07 -0500 (Fri, 27 May 2005) | 4 lines +r15293 | gerald | 2005-08-11 11:24:12 -0500 (Thu, 11 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h - M /trunk/epan/dissectors/packet-kink.c + M /trunk/docbook/release-notes.xml -From T.Nakashima -updates to KINK +Add notes about SCSI, BER, and ONC RPC bugs. +------------------------------------------------------------------------ +r15292 | gerald | 2005-08-11 10:35:17 -0500 (Thu, 11 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-ber.c + +Add checks for infinite loops. Fixes recent Buildbot failures. ------------------------------------------------------------------------ -r14452 | sahlberg | 2005-05-27 01:00:08 -0500 (Fri, 27 May 2005) | 9 lines +r15291 | sahlberg | 2005-08-11 05:08:45 -0500 (Thu, 11 Aug 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-wsp.c - M /trunk/epan/proto.c + M /trunk/epan/dissectors/packet-iscsi.c -cket wsp is creating string items and later appending to them and their value at runtime which breaks when the TRY_TO_FAKE_THIS_ITEM() is used. +Fix for bug 342 -Add a comment to proto_item_append_string() explaining the "danger" and what needs to be done if one decides to use proto_item_append_string() -Add a small change to WSP so that it will disable this speed optimization so not to trigger a DISSECTOR_BUG in proto_item_append_string() +If we encounter a frame we have already seen (i.e. visited==1) but we can not fing the ISCSI command inside the _matched table, this just means there were no response pdu nor any data pdu with the S bit set. +So, then just pick the cdata structure up from the _unmatched table instead. + +The SCSI CDB dissector really really want a real CDATA structure passed to it. ------------------------------------------------------------------------ -r14451 | sahlberg | 2005-05-27 00:04:03 -0500 (Fri, 27 May 2005) | 3 lines +r15290 | sahlberg | 2005-08-11 04:20:23 -0500 (Thu, 11 Aug 2005) | 15 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-rpc.c + +We use heuristics to detect what MIGHT be onc-rpc packets. + +as heuristics they are not 100% perfect, else they would not be heuristics. -GdKEventScroll is not available in GTK-1.2 + +IF the preference option "Dissect unknown RPC program numbers" are enabled, +add a sanity check to see that program_version is <=10 + (no one uses versions >10 ?) +to avoid trying to add 2 bilion different versions to the program->version linked list +in case we mistook the packet for ONC-RPC and the "version" field contains a huge random number. + + +This bug would only trigger a hang/crash IFF the option above is enabled. ------------------------------------------------------------------------ -r14450 | guy | 2005-05-26 21:30:10 -0500 (Thu, 26 May 2005) | 3 lines +r15289 | sahlberg | 2005-08-11 03:15:52 -0500 (Thu, 11 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-smb-browse.c + M /trunk/epan/dissectors/packet-scsi.c + +fix several bugs where we might dereference a null pointer + -The DESIRE_ and OS_ values are bit indices, not numerical values that -appear by themselves; get rid of the value_string tables for them. ------------------------------------------------------------------------ -r14449 | guy | 2005-05-26 20:34:42 -0500 (Thu, 26 May 2005) | 2 lines +r15288 | sahlberg | 2005-08-11 02:44:38 -0500 (Thu, 11 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/profinet + M /trunk/epan/dissectors/packet-smpp.c + M /trunk/epan/dissectors/packet-wsp.c + +some more tcv_get_stringz() to tvb_get_ephemeral_stringz() conversions -Set svn:ignore to ignore generated files. ------------------------------------------------------------------------ -r14448 | ulfl | 2005-05-26 18:18:10 -0500 (Thu, 26 May 2005) | 1 line +r15287 | gerald | 2005-08-10 15:17:53 -0500 (Wed, 10 Aug 2005) | 2 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/docbook/release-notes.xml + +Add bug IDs to the list of bugs fixed. -fix #203: the scroll event handler used an inappropriate implementation to get event values, fixed this. On win32 this was working before and after the changes, so the bug *might* remain ... ------------------------------------------------------------------------ -r14447 | ulfl | 2005-05-26 16:49:48 -0500 (Thu, 26 May 2005) | 3 lines +r15286 | ulfl | 2005-08-10 14:49:45 -0500 (Wed, 10 Aug 2005) | 5 lines Changed paths: + M /trunk/gtk/capture_prefs.c + M /trunk/gtk/color_dlg.c + M /trunk/gtk/column_prefs.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/decode_as_dlg.c + M /trunk/gtk/dfilter_expr_dlg.c + M /trunk/gtk/gtk_stat_util.c + M /trunk/gtk/hostlist_table.c M /trunk/gtk/main.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/packet_list.c + M /trunk/gtk/proto_dlg.c + M /trunk/gtk/proto_draw.c + M /trunk/gtk/proto_hier_stats_dlg.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/toolbar.c + M /trunk/gtk/ui_util.c + +removed tons of MSVC const related warnings. -show the complete filename in the statusbar, as there's no good reason to hide it (bugzilla #198) +This might at some places interfere with the changes for gcc4, we might have to negotiate in that case :-) -fix various log related problems +Please note that a lot of these warnings were GTK1.x related only! ------------------------------------------------------------------------ -r14446 | ulfl | 2005-05-26 16:45:58 -0500 (Thu, 26 May 2005) | 1 line +r15285 | guy | 2005-08-10 14:38:04 -0500 (Wed, 10 Aug 2005) | 2 lines Changed paths: - M /trunk/capture.c + M /trunk/docbook/release-notes.xml + +Fix a typo. -changed the loglevel of "capture kill" from message to info (it's no action that the user directly triggered) ------------------------------------------------------------------------ -r14445 | ulfl | 2005-05-26 15:23:13 -0500 (Thu, 26 May 2005) | 1 line +r15284 | ulfl | 2005-08-10 14:37:29 -0500 (Wed, 10 Aug 2005) | 1 line Changed paths: - M /trunk/Makefile.common + M /trunk/file.c -add log.h +more snprintf() -> g_snprintf() replacements ------------------------------------------------------------------------ -r14444 | etxrab | 2005-05-26 15:13:42 -0500 (Thu, 26 May 2005) | 6 lines +r15283 | ulfl | 2005-08-10 14:34:09 -0500 (Wed, 10 Aug 2005) | 1 line Changed paths: - M /trunk/plugins/mgcp/packet-mgcp.c + M /trunk/gtk/capture_if_details_dlg.c -From Martin Mathieson: +don't warn the user about the WinPcap 3.1 release version as being unknown +------------------------------------------------------------------------ +r15282 | gerald | 2005-08-10 14:31:21 -0500 (Wed, 10 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-csm-encaps.c -This 2-liner: -- adds the correct item for localconnectionoptions param -- recognises the message verb "MESG" +Remove proprietary information at the author's request. ------------------------------------------------------------------------ -r14443 | etxrab | 2005-05-26 15:11:35 -0500 (Thu, 26 May 2005) | 13 lines +r15281 | gerald | 2005-08-10 14:28:08 -0500 (Wed, 10 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/libethereal.def -These 2 patches make RDT support pretty complete now: -From Martin Mathieson: +ep_tvb_get_string -> tvb_get_ephemeral_string -packet-rdt.c: -- register a configurable UDP port (off by default, but needed where setup traffic isn't captured) -- dissect extra 'buffer info' fields -- move bit fields into 'flags' subtrees -- misc. minor fixes and improvements (mainly formatting) +------------------------------------------------------------------------ +r15280 | gerald | 2005-08-10 13:54:30 -0500 (Wed, 10 Aug 2005) | 2 lines +Changed paths: + M /trunk/docbook/release-notes.xml -packet-rtsp.c: -- improve detection of RDT as the transport -- allow interleaved frame data to be dissected as RDT packets +Add an item for the SLIMP3 overflow. ------------------------------------------------------------------------ -r14442 | ulfl | 2005-05-26 14:38:26 -0500 (Thu, 26 May 2005) | 1 line +r15279 | gerald | 2005-08-10 13:50:36 -0500 (Wed, 10 Aug 2005) | 4 lines Changed paths: - M /trunk/capture_loop.c + M /trunk/epan/dissectors/packet-slimp3.c + +Don't overflow a buffer. This might fix bug 327. + +Don't print non-pritable characters. -fix #125: as suggested, the data in rechdr has to be kept over several calls to capture_loop_dispatch, so put it in the loop_data ------------------------------------------------------------------------ -r14441 | ulfl | 2005-05-26 14:06:01 -0500 (Thu, 26 May 2005) | 1 line +r15278 | gerald | 2005-08-10 11:05:50 -0500 (Wed, 10 Aug 2005) | 7 lines Changed paths: - M /trunk/capture_loop.c - M /trunk/capture_sync.c + M /trunk/epan/dissectors/packet-scsi.c + +When we receive junk data, mark it as a malformed packet instead of +a dissector bug. This keeps buildbot from opening unnecessary bugs +during fuzz testing. + +When we create a new scsi_task_data_t struct make sure all of its +members are initialized. -some cleanup of capture error notification handling ------------------------------------------------------------------------ -r14440 | ulfl | 2005-05-26 13:29:09 -0500 (Thu, 26 May 2005) | 1 line +r15277 | gerald | 2005-08-10 10:58:26 -0500 (Wed, 10 Aug 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/plugins/mgcp/packet-mgcp.c + +ep_tvb_get_string() -> tvb_get_ephemeral_string(). -don't use stdout but stderr for logging, as this will confuse the capture childs sync_pipe (has to be solved later) ------------------------------------------------------------------------ -r14439 | ulfl | 2005-05-26 13:03:34 -0500 (Thu, 26 May 2005) | 1 line +r15276 | sahlberg | 2005-08-10 09:37:52 -0500 (Wed, 10 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-smb-common.c + M /trunk/epan/dissectors/packet-smb-logon.c + +tvb_get_stringz() to tvb_get_ephemeral_stringz() conversion + -avoid two gcc warnings ------------------------------------------------------------------------ -r14438 | ulfl | 2005-05-26 12:50:27 -0500 (Thu, 26 May 2005) | 7 lines +r15275 | sahlberg | 2005-08-10 09:35:24 -0500 (Wed, 10 Aug 2005) | 3 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_loop.c - M /trunk/capture_opts.c - M /trunk/capture_sync.c - M /trunk/gtk/main.c - A /trunk/log.h + M /trunk/epan/dissectors/packet-image-jfif.c + M /trunk/epan/dissectors/packet-pgsql.c + M /trunk/epan/dissectors/packet-smb-browse.c + +tvb_get_stringz() to tvb_get_ephemeral_stringz() conversion. -use the log features of the GLib to have verbose output of the capturing engine, e.g. GLib provides different domains for different submodules. Output more verbose than warning level will be disabled by default (just like before). -use the console_log_handler in main.c for win32 AND unix now +------------------------------------------------------------------------ +r15274 | sahlberg | 2005-08-10 09:28:18 -0500 (Wed, 10 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-afp.c -Currently use the log for the capturing engine (only), as I desperately needed a log output for debugging. +convert to tvb_get_ephemeral_stringz() and fix an obvious memleak ------------------------------------------------------------------------ -r14437 | gerald | 2005-05-26 09:53:39 -0500 (Thu, 26 May 2005) | 9 lines +r15273 | sahlberg | 2005-08-10 09:25:59 -0500 (Wed, 10 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/proto.c - -In some places we call proto_tree_add_item() with hfindex and length -values that may not be valid (e.g. dissect_ber_octet_string() -in packet-ber.c). If the length is invalid, get_uint_value() or -get_int_value() will abort. Change them to throw an exception instead. -This keeps us from having to do a lot of extra work in the dissector. + M /trunk/doc/README.developer + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h -Fixes bug 182. +add new function tvb_get_ephemeral_stringz() ------------------------------------------------------------------------ -r14436 | ulfl | 2005-05-25 18:28:59 -0500 (Wed, 25 May 2005) | 3 lines +r15272 | sahlberg | 2005-08-10 09:17:27 -0500 (Wed, 10 Aug 2005) | 3 lines Changed paths: - M /trunk/capture.c - M /trunk/file.h - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-dcerpc-nt.c + M /trunk/epan/dissectors/packet-gsm_sms.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-ms-mms.c + M /trunk/epan/dissectors/packet-ntlmssp.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-srvloc.c + +convert some tvb_fake_unicode() to tvb_get_ephemeral_faked_unicode() -the capture child might not respond shortly after bringing it up (especially it will block, if no input coming from an input capture pipe (e.g. mkfifo) is coming in) -to prevent problems, bring the main GUI into "capture mode" right after successfully spawn/exec the capture child, without waiting for any response from it ------------------------------------------------------------------------ -r14435 | ulfl | 2005-05-25 17:20:46 -0500 (Wed, 25 May 2005) | 1 line +r15271 | sahlberg | 2005-08-10 08:56:34 -0500 (Wed, 10 Aug 2005) | 3 lines Changed paths: - M /trunk/capture_sync.c + M /trunk/doc/README.developer + M /trunk/epan/dissectors/packet-tds.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h + +rename ep_tvb_fake_unicode() to tvb_get_ephemeral_faked_unicode() and update the README file. + -forgot to init savefilestring = NULL; ------------------------------------------------------------------------ -r14434 | ulfl | 2005-05-25 16:37:46 -0500 (Wed, 25 May 2005) | 1 line +r15270 | sahlberg | 2005-08-10 08:41:13 -0500 (Wed, 10 Aug 2005) | 3 lines Changed paths: - M /trunk/capture-wpcap.c + M /trunk/doc/README.developer + M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-ansi_a.c + M /trunk/epan/dissectors/packet-atalk.c + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-dcerpc-nt.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-dhcp-failover.c + M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/epan/dissectors/packet-dsi.c + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-fcdns.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-fix.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-icep.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-image-gif.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-mmse.c + M /trunk/epan/dissectors/packet-mq.c + M /trunk/epan/dissectors/packet-ms-mms.c + M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-multipart.c + M /trunk/epan/dissectors/packet-pagp.c + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-quake2.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-sipfrag.c + M /trunk/epan/dissectors/packet-slsk.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/dissectors/packet-tds.c + M /trunk/epan/dissectors/packet-telnet.c + M /trunk/epan/dissectors/packet-ucp.c + M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-vnc.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h + +rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer + -add const to pcap_next_ex() parameter, as WinPcap 3.1 beta 4 (and libpcap 0.8) requires it ------------------------------------------------------------------------ -r14433 | etxrab | 2005-05-25 13:27:33 -0500 (Wed, 25 May 2005) | 2 lines +r15269 | sahlberg | 2005-08-10 08:01:16 -0500 (Wed, 10 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dissectors/packet-dhcp-failover.c + +ememify tywo more tvb_get_string() + -Back out the two last changes by popular demand :) -as we don't want multiple language versions. ------------------------------------------------------------------------ -r14432 | ulfl | 2005-05-25 12:46:04 -0500 (Wed, 25 May 2005) | 1 line +r15268 | gerald | 2005-08-09 09:46:06 -0500 (Tue, 09 Aug 2005) | 2 lines Changed paths: - M /trunk/capture_sync.c + M /trunk/docbook/release-notes.xml + +Add a note about the IrDA dissector crash. -fix #199: encapsulate capture filename, to avoid problems with spaces in the filename (win32 only) ------------------------------------------------------------------------ -r14431 | guy | 2005-05-25 11:59:59 -0500 (Wed, 25 May 2005) | 2 lines +r15267 | gerald | 2005-08-09 09:38:11 -0500 (Tue, 09 Aug 2005) | 4 lines Changed paths: - M /trunk/doc/ethereal-filter.pod.template + M /trunk/plugins/irda/packet-irda.c -Update URLs for WinPcap. +Make sure we initialize our iap_conv struct _before_ we go digging +into a tvbuff. This keeps us from leaving junk data behind if we +throw an exception. ------------------------------------------------------------------------ -r14430 | guy | 2005-05-25 03:25:14 -0500 (Wed, 25 May 2005) | 2 lines +r15266 | guy | 2005-08-08 19:07:12 -0500 (Mon, 08 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/gtk/proto_draw.c -Add some more reassembly routines. +"g_locale_to_utf8()" returns a "gchar *", and the string it returns is +dynamically allocated. Don't assign its result to "const gchar *". ------------------------------------------------------------------------ -r14429 | ulfl | 2005-05-24 15:01:08 -0500 (Tue, 24 May 2005) | 1 line +r15265 | guy | 2005-08-08 19:03:45 -0500 (Mon, 08 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom-remunkn.c + M /trunk/plugins/irda/packet-irda.c + +The "proto" argument to "conversation_get_proto_data()" and +"conversation_add_proto_data()" is supposed to be a protocol ID, as +returned by "proto_register_protocol()". In addition, there are two +different types of protocol data being attached to a conversation; use +different protocol IDs for them, so we don't misinterpret an +"iap_conversation_t" as a "lmp_conversation_t" or vice versa. -fix IRemUnknown2 UUID ------------------------------------------------------------------------ -r14428 | ulfl | 2005-05-24 15:00:14 -0500 (Tue, 24 May 2005) | 1 line +r15264 | ulfl | 2005-08-08 13:50:39 -0500 (Mon, 08 Aug 2005) | 5 lines Changed paths: + M /trunk/capture_sync.c + M /trunk/disabled_protos.c + M /trunk/epan/addr_resolv.c + M /trunk/epan/asn1.c + M /trunk/epan/atalk-utils.c + M /trunk/epan/atalk-utils.h + M /trunk/epan/column-utils.c + M /trunk/epan/dfilter/dfilter.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-amr.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-brdwlk.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-ccsds.c + M /trunk/epan/dissectors/packet-cip.c + M /trunk/epan/dissectors/packet-cpfi.c + M /trunk/epan/dissectors/packet-cpha.c + M /trunk/epan/dissectors/packet-csm-encaps.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcm.c M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-enip.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcct.c + M /trunk/epan/dissectors/packet-fcdns.c + M /trunk/epan/dissectors/packet-fcels.c + M /trunk/epan/dissectors/packet-fcfcs.c + M /trunk/epan/dissectors/packet-fcfzs.c + M /trunk/epan/dissectors/packet-fclctl.c + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-fcsb3.c + M /trunk/epan/dissectors/packet-fcsp.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-g723.c + M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/epan/dissectors/packet-hyperscsi.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-igmp.c + M /trunk/epan/dissectors/packet-image-gif.c + M /trunk/epan/dissectors/packet-image-jfif.c + M /trunk/epan/dissectors/packet-ipdc.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-ipvs-syncd.c + M /trunk/epan/dissectors/packet-ismp.c + M /trunk/epan/dissectors/packet-isns.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-isup_thin.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-laplink.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-lwapp.c + M /trunk/epan/dissectors/packet-mdshdr.c + M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/epan/dissectors/packet-mtp3mg.c + M /trunk/epan/dissectors/packet-multipart.c + M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-pflog.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-pn-rt.c + M /trunk/epan/dissectors/packet-ptp.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-rtps.c + M /trunk/epan/dissectors/packet-sccp.c + M /trunk/epan/dissectors/packet-sccpmg.c + M /trunk/epan/dissectors/packet-sebek.c + M /trunk/epan/dissectors/packet-sflow.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-sndcp.c + M /trunk/epan/dissectors/packet-stun.c + M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-wccp.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/packet-wtls.c + M /trunk/epan/dissectors/packet-wtp.c + M /trunk/epan/filesystem.c + M /trunk/epan/follow.c + M /trunk/epan/inet_ntop.c + M /trunk/epan/ipproto.c + M /trunk/epan/plugins.c + M /trunk/epan/proto.c + M /trunk/epan/sigcomp-udvm.c + M /trunk/epan/sigcomp_state_hdlr.c + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h + M /trunk/epan/value_string.c + M /trunk/filters.c + M /trunk/pcap-util-unix.c + M /trunk/plugins/asn1/packet-asn1.c + M /trunk/plugins/ciscosm/packet-sm.c + M /trunk/plugins/docsis/packet-vendor.c + M /trunk/plugins/irda/packet-ircomm.c + M /trunk/plugins/irda/packet-irda.c + M /trunk/plugins/opsi/packet-opsi.c + M /trunk/plugins/rlm/packet-rlm.c + M /trunk/plugins/v5ua/packet-v5ua.c + M /trunk/ringbuffer.c + M /trunk/tap-iousers.c + M /trunk/tap-rpcprogs.c + M /trunk/tethereal.c + M /trunk/util.c -add values for STDOBJREF flags +various code cleanup: +-use g_snprintf instead of sprintf and snprintf +-use g_strdup_printf where appropriate +-remove #include "snprintf.h" (as only g_snprintf should be used) +-replace some more alloc/realloc/calloc/free with their glib pendants ------------------------------------------------------------------------ -r14427 | ulfl | 2005-05-24 14:59:20 -0500 (Tue, 24 May 2005) | 1 line +r15263 | ulfl | 2005-08-08 12:22:55 -0500 (Mon, 08 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcom-sysact.c + M /trunk/gtk/simple_dialog.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/toolbar.c + M /trunk/gtk/ui_util.c + M /trunk/gtk/ui_util.h -dissect ORPC this/that of RemoteCreateInstance +fix some MSVC const warnings ------------------------------------------------------------------------ -r14426 | ulfl | 2005-05-24 14:57:37 -0500 (Tue, 24 May 2005) | 1 line +r15262 | jmayer | 2005-08-08 11:53:09 -0500 (Mon, 08 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom-oxid.c + M /trunk/epan/Makefile.am + +OK, so Didier was probably right using $^ :-) -dissect ServerAlive response ------------------------------------------------------------------------ -r14425 | gerald | 2005-05-24 11:46:18 -0500 (Tue, 24 May 2005) | 3 lines +r15261 | jmayer | 2005-08-08 09:17:42 -0500 (Mon, 08 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/Makefile.am + +Didier Gautheron: + A small patch for compiling ethereal outside the source tree. -Add extra TLV length checks and signedness fixes. Fixes the infinite loop in -bug 196. ------------------------------------------------------------------------ -r14424 | gerald | 2005-05-24 08:50:20 -0500 (Tue, 24 May 2005) | 2 lines +r15260 | sahlberg | 2005-08-08 04:52:59 -0500 (Mon, 08 Aug 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-rpc.c -Throw an exception instead of calling g_assert_not_reached(). Fixes bug 175. +From +Eric Wedel + +Add a preference to RPC (default off) that will heuristically attempt to find +PDUs starting in the middle of a segment. ------------------------------------------------------------------------- -r14423 | guy | 2005-05-23 20:28:25 -0500 (Mon, 23 May 2005) | 2 lines -Changed paths: - M /trunk/gtk/voip_calls_dlg.c -Include "webbrowser.h" to declare "browser_open_url()". ------------------------------------------------------------------------ -r14422 | gerald | 2005-05-23 16:18:14 -0500 (Mon, 23 May 2005) | 3 lines +r15259 | sahlberg | 2005-08-08 03:53:05 -0500 (Mon, 08 Aug 2005) | 6 lines Changed paths: - M /trunk/plugins/docsis/packet-docsis.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-gsm_ss.c + M /trunk/epan/dissectors/packet-gsm_ss.h + +updates from Anders B + +Regenerate gsm ss and gsm map + -Make sure we don't loop when we dissect concatenated PDUs. Make some int -values larger in order to keep them from overflowing. ------------------------------------------------------------------------ -r14421 | etxrab | 2005-05-23 13:37:45 -0500 (Mon, 23 May 2005) | 3 lines +r15258 | guy | 2005-08-08 02:27:14 -0500 (Mon, 08 Aug 2005) | 7 lines Changed paths: - M /trunk/asn1/camel/packet-camel-template.h + M /trunk/epan/dissectors/packet-rsvp.c + +Centralize the code to create the subtree for RSVP objects and to put +the length and object class items into that tree. Put the object class +item into the tree as a visible item, rather than as a hidden item and +as a text entry. + +Add some additional length checks. - Warning fix: - packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined -do this change also for the template file. ------------------------------------------------------------------------ -r14420 | jmayer | 2005-05-23 07:32:37 -0500 (Mon, 23 May 2005) | 5 lines +r15257 | sahlberg | 2005-08-07 18:39:00 -0500 (Sun, 07 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-slowprotocols.c -Warning fix: -packet-bacapp.c:1264: warning: ISO C does not allow extra ';' outside of -a function +from Dominique Bastien + +small update for slowprotocols ------------------------------------------------------------------------ -r14419 | jmayer | 2005-05-23 07:19:00 -0500 (Mon, 23 May 2005) | 4 lines +r15256 | ulfl | 2005-08-07 18:10:06 -0500 (Sun, 07 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-camel.h + M /trunk/packaging/nsis/Makefile.am + M /trunk/packaging/nsis/WinPcapPage.ini + A /trunk/packaging/nsis/WinPcap_3_1.exe + D /trunk/packaging/nsis/WinPcap_3_1_beta4.exe + M /trunk/packaging/nsis/ethereal.nsi -Warning fix: -packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined +Use the now released WinPcap 3.1 version instead of the beta 4. +We don't need to uninstall an old WinPcap version first, as this is done by the WinPcap installer itself now. ------------------------------------------------------------------------ -r14418 | jmayer | 2005-05-23 07:18:10 -0500 (Mon, 23 May 2005) | 5 lines +r15255 | guy | 2005-08-07 15:06:01 -0500 (Sun, 07 Aug 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-dhcp-failover.c + +DHCP Failover runs over TCP; use tcp_dissect_pdus. + +There's no need to build a list of all the options and then dissect them +individually; just have one loop that dissects them. (The full list +wasn't being freed, so we were leaking memory.) -Warning fix: -packet-bacapp.c:1266:1: warning: C++ style comments are not allowed in ISO C90 -packet-bacapp.c:1266:1: warning: (this will be reported only once per input file) +Add some more sanity checks. +Clean up a bunch of other things. ------------------------------------------------------------------------ -r14417 | etxrab | 2005-05-23 00:52:28 -0500 (Mon, 23 May 2005) | 36 lines +r15254 | guy | 2005-08-07 13:03:34 -0500 (Sun, 07 Aug 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c - M /trunk/epan/dissectors/packet-bacapp.h - M /trunk/epan/dissectors/packet-bvlc.c - -From Steve Karg: - -* added additional value string enumerations from BACnet-2004 -* removed vendor specific value string enumerations -* corrected some value strings enumerations that were incorrect -* refactored some common strings as strings + format -* refactored some value strings to use a reserved range and a -proprietary range by using val_to_split_str function which now correctly -shows the split range when a value is not matched. -* corrected some spelling errors -* converted some item text values to dissector registration -* added protocol tree for the BACnet tag headers -* added value strings tree display for some bit string BACnet properties -* added value strings tree display for some enumerated BACnet properties -* changed the conversion of signed, unsigned, and enumerated BACnet -values to use ntohx functions. -* added proper handling for large values of signed, unsigned, and -enumerated BACnet values. -* refactored BACnet Null and Boolean Tag tree -* refactored BACnet Real and Double Tag tree -* changed comments into functions for special tags -* changed some white space to match existing file style -* refactored tvb_reported_length to tvb_length_remaining to simplify -* corrected octet-string tree when length is zero -* refactored octet-string tree to use tvb_bytes_to_str -* corrected application tagged productions that were context tagged -* corrected context tagged productions that were application tagged -* corrected offset for BACnet character strings -* refactored some identical service request tree handling -* changed confirmed APDU to highlight the correct portion of the APDU -* changed some dissector registration values to display as decimal -* changed cast in call to iconv() to fix compiler warning -* corrected bit-wise AND in AtomicFile tree handling - -packet-bvlc.c -* added error text in tree when encoded length doesn't match actual length ------------------------------------------------------------------------- -r14416 | lego | 2005-05-21 19:44:34 -0500 (Sat, 21 May 2005) | 7 lines -Changed paths: - M /trunk/plugins/mate - M /trunk/plugins/mate/mate_grammar.lemon - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/mate_setup.c + M /trunk/epan/dissectors/packet-dhcp-failover.c -at this point mate should be working as it did before the grammar - - - pdu transports were upside down (ip/tcp vs tcp/ip) - - the gop to gog index was not being populated - - tell svn to ignore generated c files +Fix the spelling of "transferred". + +Fix the sizes of some items to match what's in the I-D and what's being +fetched from the packet. +Check for the length of items before doing *anything* with the item, +including fetching the data from the packet. Just put a "bad length" +indication into the protocol tree; don't abort the dissection (we can +just move on to the next TLV). ------------------------------------------------------------------------ -r14415 | lego | 2005-05-21 10:47:18 -0500 (Sat, 21 May 2005) | 3 lines +r15253 | jmayer | 2005-08-06 19:21:35 -0500 (Sat, 06 Aug 2005) | 1 line Changed paths: - M /trunk/plugins/mate/packet-mate.c + M /trunk/docbook -PDU, GOP and GOG should be at the same level not nested +Add release-notes-...pdf to svn:ignore +------------------------------------------------------------------------ +r15252 | jmayer | 2005-08-06 19:07:18 -0500 (Sat, 06 Aug 2005) | 6 lines +Changed paths: + M /trunk/docbook/README.txt + +Start a list of packages required for each distro. +So far only Suse 9.3 is covered. + +Infos for other systems are very welcome. ------------------------------------------------------------------------ -r14414 | ulfl | 2005-05-21 06:10:16 -0500 (Sat, 21 May 2005) | 1 line +r15251 | guy | 2005-08-06 16:38:43 -0500 (Sat, 06 Aug 2005) | 9 lines Changed paths: - M /trunk/capture_wpcap_packet.c - M /trunk/gtk/capture_if_details_dlg.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-frame.h + M /trunk/epan/exceptions.h + +If a dissector writer directly throws DissectorError, don't punish the +user by crashing due to a null pointer dereference, punish the dissector +writer by saying he or she didn't bother providing an explanation of the +error. + +The exception message isn't a const string any more; make the +"exception_message" argument to "show_exception()" a "char *", not a +"const char *". -don't crash if packet.dll is not available, add some more packet.dll version numbers ------------------------------------------------------------------------ -r14413 | ulfl | 2005-05-21 06:08:48 -0500 (Sat, 21 May 2005) | 1 line +r15250 | guy | 2005-08-06 14:58:45 -0500 (Sat, 06 Aug 2005) | 14 lines Changed paths: - M /trunk/capture-wpcap.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/except.c + M /trunk/epan/except.h + M /trunk/epan/exceptions.h + +Support throwing an exception with a null message pointer, and have the +message not be const (as we generate messages with "g_strdup_sprintf()", +which means they need to be freed; using a null message means that we +don't have to use a special string for exceptions with no message, and +don't have to worry about not freeing that). + +Have THROW() throw an exception with a null message pointer. (This +means that you crash if you throw DissectorError with THROW(). Don't do +that - it means you don't get a more detailed explanation of the +dissector problem. Use the DISSECTOR_ASSERT, etc. macros in +epan/proto.h instead.) + +Free the exception message for DissectorError, as it's mallocated. -bugfix: prevent a (null pointer access) crash with very early WinPcap version < 2.3 ------------------------------------------------------------------------ -r14412 | ulfl | 2005-05-21 04:59:49 -0500 (Sat, 21 May 2005) | 3 lines +r15249 | guy | 2005-08-06 13:42:07 -0500 (Sat, 06 Aug 2005) | 5 lines Changed paths: - M /trunk/capture-wpcap.c - M /trunk/config.h.win32 + M /trunk/filters.c + M /trunk/filters.h -bugfix: mark pcap_freecode() as optional, as it's not available by WinPcap 2.3 +"read_filter_list()" and "save_filter_list()" mallocate the path string +that they return through the "pref_path_return" argument; make it a +"char **", as a pointer to a "char *" is passed to it, and the caller +has to free that. -add optional pcap_next_ex() which is currently unused ------------------------------------------------------------------------ -r14411 | ulfl | 2005-05-21 04:41:57 -0500 (Sat, 21 May 2005) | 1 line +r15248 | guy | 2005-08-06 13:40:03 -0500 (Sat, 06 Aug 2005) | 5 lines Changed paths: - M /trunk/capture_wpcap_packet.c - M /trunk/capture_wpcap_packet.h - M /trunk/gtk/capture_if_details_dlg.c + M /trunk/file.c + +We no longer generate a "Loading" message ourselves, we just pass the +name of the file being loaded to "delayed_create_progress_dlg()". Get +rid of the pointless "g_strdup_printf()" call (which amounted to a +more-expensive "g_strdup()", and the variables it used. -as suggested by Loris: add wpcap_packet_get_version() and check the packet.dll version before using it (very restrictive for now, will check for exact DLL version strings). If version is unknown, ask user to continue or not. ------------------------------------------------------------------------ -r14410 | etxrab | 2005-05-21 04:26:16 -0500 (Sat, 21 May 2005) | 5 lines +r15247 | guy | 2005-08-06 13:38:35 -0500 (Sat, 06 Aug 2005) | 15 lines Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/util.c + +"setup_tmpdir()" either returns the const string passed to it, or it +returns a malloced string that's supposed to persist as long as Ethereal +is running. Make it return "const char *", and return either the former +pointer or the result of mallocation, so we don't end up using the same +variable for a const pointer and a non-const pointer. + +Make the variables to which its result is assigned const pointers as +well. -From Javier Acuna: -It adds "CIC" info display on the comments column for ISUP -It adds a small Help button that open up a window that offers you to vist the Wiki page containing the explanation of the Dialog window. +"strlen()" returns size_t; make a argument to which its result is +assigned a size_t. +Just out of paranoia, check for a zero-length string passed to +"setup_tmpdir()". ------------------------------------------------------------------------ -r14409 | etxrab | 2005-05-21 04:13:28 -0500 (Sat, 21 May 2005) | 2 lines +r15246 | gerald | 2005-08-06 10:23:52 -0500 (Sat, 06 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/docbook/release-notes.xml + +Add a note about the ISIS LSP bug. -From Javier Acuna: -filter packets by their Billing ID ------------------------------------------------------------------------ -r14408 | ulfl | 2005-05-20 19:10:17 -0500 (Fri, 20 May 2005) | 1 line +r15245 | gerald | 2005-08-06 10:18:45 -0500 (Sat, 06 Aug 2005) | 3 lines Changed paths: - M /trunk/capture_wpcap_packet.c - M /trunk/capture_wpcap_packet.h + M /trunk/epan/dissectors/packet-isis-lsp.c + +Increase the size of some variables so that we don't overflow them and loop +forever. Fixes bug 320. -don't use LPADAPTER but simply void * as we don't need to look inside the members of this struct ------------------------------------------------------------------------ -r14407 | ulfl | 2005-05-20 17:23:00 -0500 (Fri, 20 May 2005) | 1 line +r15244 | jmayer | 2005-08-06 09:03:14 -0500 (Sat, 06 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - A /trunk/gtk/capture_if_details_dlg.c - A /trunk/gtk/capture_if_details_dlg.h - M /trunk/gtk/capture_if_dlg.c - M /trunk/gtk/main.c + M /trunk/capture_loop.c + M /trunk/capture_sync.c + M /trunk/file.c + M /trunk/filters.c + M /trunk/filters.h + M /trunk/gtk/io_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/progress_dlg.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/progress_dlg.h + M /trunk/tap-iostat.c + M /trunk/util.c + M /trunk/util.h + + +Last set of char -> const char trivial warning fixes. -win32 only: get interface details from WinPcap's packet.dll (direct access to NDIS specific driver information, upper second GTK part) ------------------------------------------------------------------------ -r14406 | ulfl | 2005-05-20 17:16:47 -0500 (Fri, 20 May 2005) | 1 line +r15243 | tuexen | 2005-08-06 07:02:34 -0500 (Sat, 06 Aug 2005) | 6 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake - A /trunk/capture_wpcap_packet.c - A /trunk/capture_wpcap_packet.h + M /trunk/epan/dissectors/packet-asap.c + M /trunk/epan/dissectors/packet-enrp.c + +Update to + * http://www.ietf.org/internet-drafts/draft-ietf-rserpool-common-param-09.txt + * http://www.ietf.org/internet-drafts/draft-ietf-rserpool-enrp-12.txt + * http://www.ietf.org/internet-drafts/draft-ietf-rserpool-asap-12.txt + -win32 only: get interface details from WinPcap's packet.dll (direct access to NDIS specific driver information, lower first part) ------------------------------------------------------------------------ -r14405 | ulfl | 2005-05-20 16:44:17 -0500 (Fri, 20 May 2005) | 1 line +r15242 | guy | 2005-08-06 05:31:27 -0500 (Sat, 06 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/addr_resolv.c - M /trunk/epan/addr_resolv.h - M /trunk/epan/libethereal.def + M /trunk/epan/packet.h + M /trunk/gtk/decode_as_dlg.c + M /trunk/tethereal.c + +Squelch more const pointer warnings. -add get_manuf_name_if_known (returns NULL if unknown) in addition to get_manuf_name ------------------------------------------------------------------------ -r14404 | ulfl | 2005-05-20 16:40:03 -0500 (Fri, 20 May 2005) | 1 line +r15241 | guy | 2005-08-06 05:30:21 -0500 (Sat, 06 Aug 2005) | 4 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/gtk/voip_calls.c + +Make some structure members that are always set from mallocated data not +"const" pointers, so that we don't get warnings when we free the data +they point to. -bugfix: add the profinet plugin to NSIS ------------------------------------------------------------------------ -r14403 | lego | 2005-05-20 14:43:40 -0500 (Fri, 20 May 2005) | 3 lines +r15240 | guy | 2005-08-06 05:29:20 -0500 (Sat, 06 Aug 2005) | 3 lines Changed paths: M /trunk/plugins/mate/mate_parser.l -Fix the Id tag - +Make a variable whose value might be trashed by setjmp/longjmp +"volatile" to avoid that. ------------------------------------------------------------------------ -r14402 | lego | 2005-05-20 14:40:10 -0500 (Fri, 20 May 2005) | 4 lines +r15239 | guy | 2005-08-06 04:23:28 -0500 (Sat, 06 Aug 2005) | 14 lines Changed paths: - M /trunk/epan/stats_tree.c + M /trunk/epan/dissectors/packet-ms-mms.c + +Don't assign "" to a string that's only used after it's assigned to. + +"tvb_fake_unicode()" never returns a null pointer, so there's no need to +check for it; there's also no need to check that it's not an empty +string before freeing it, as it's always assigned a g_malloc()ed string. + +It also takes as an argument the number of Unicode characters in the +string, not the number of bytes in the string. -dup the filter string so that it can be freed without problems. -fixes bug 195 +Use "format_text()" when adding a string to the Info column, in case +it has non-printable characters. +Don't use "proto_tree_add_string_format()" if you don't have to. ------------------------------------------------------------------------ -r14401 | lego | 2005-05-20 14:38:24 -0500 (Fri, 20 May 2005) | 3 lines +r15238 | guy | 2005-08-06 04:18:52 -0500 (Sat, 06 Aug 2005) | 9 lines Changed paths: - M /trunk/asn1/h248/h248.cnf - M /trunk/asn1/h248/packet-h248-template.c - M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-dcm.c -some cosmetic fixes +Use a NULL value for di->xfer as an indication that we don't know the +transfer context; that way, we don't have to make "di->xfer" a "const" +pointer, and can thus pass it to "g_free()" (if non-null) without +the compiler whining at us. +Note that telling the user to "click on ASSOC request" is not the best +thing to do, unless we simply cannot determine the right ASSOC request +to click on. ------------------------------------------------------------------------ -r14400 | etxrab | 2005-05-19 15:35:30 -0500 (Thu, 19 May 2005) | 1 line +r15237 | guy | 2005-08-05 23:01:38 -0500 (Fri, 05 Aug 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-h221_nonstd.c + M /trunk/epan/dissectors/packet-smb.c + +DissectorError is not supposed to be directly thrown; one should use the +various DISSECTOR_ macros, so the error message includes an indication +of the problem, and the file and line number. -Use value_string for codec values/strings. ------------------------------------------------------------------------ -r14399 | etxrab | 2005-05-19 15:34:35 -0500 (Thu, 19 May 2005) | 1 line +r15236 | guy | 2005-08-05 22:44:55 -0500 (Fri, 05 Aug 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/tap.c + M /trunk/epan/tap.h + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_fc.c + M /trunk/gtk/hostlist_fddi.c + M /trunk/gtk/hostlist_ip.c + M /trunk/gtk/hostlist_ipx.c + M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/hostlist_table.h + M /trunk/gtk/hostlist_tcpip.c + M /trunk/gtk/hostlist_tr.c + M /trunk/gtk/hostlist_udpip.c + M /trunk/gtk/hostlist_wlan.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/menu.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/stats_tree_stat.c + M /trunk/gtk/summary_dlg.c + M /trunk/gtk/toolbar.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c + M /trunk/tap-ansi_astat.c + M /trunk/tap-bootpstat.c + M /trunk/tap-dcerpcstat.c + M /trunk/tap-gsm_astat.c + M /trunk/tap-h225counter.c + M /trunk/tap-h225rassrt.c + M /trunk/tap-httpstat.c + M /trunk/tap-iostat.c + M /trunk/tap-iousers.c + M /trunk/tap-mgcpstat.c + M /trunk/tap-protocolinfo.c + M /trunk/tap-protohierstat.c + M /trunk/tap-rpcprogs.c + M /trunk/tap-rpcstat.c + M /trunk/tap-sctpchunkstat.c + M /trunk/tap-sipstat.c + M /trunk/tap-smbsids.c + M /trunk/tap-smbstat.c + M /trunk/tap-stats_tree.c + M /trunk/tap-wspstat.c + M /trunk/tap_dfilter_dlg.h + +Squelch more const warnings (and fix some memory leaks that found). + +_U_-ify some unused arguments, rather than assigning them to themselves. + +Un-constify one variable that gets assigned a mallocated pointer. + +Clean up indentation. -Display version number and product number as strings. ------------------------------------------------------------------------ -r14398 | etxrab | 2005-05-19 15:33:59 -0500 (Thu, 19 May 2005) | 1 line +r15235 | gerald | 2005-08-05 22:43:42 -0500 (Fri, 05 Aug 2005) | 6 lines Changed paths: - M /trunk/epan/t35.c + M /trunk/epan/asn1.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-spnego.c + +In packet-frame.c, don't free static memory when we throw a +DissectorError. In packet-kerberos.c, restore pinfo->private_data if +we throw an exception, which keeps the SMB dissector from throwing +a DissectorError. Initialize variables in other places to squelch +valgrind warnings. -Add Sony and Nokia VendorID:s ------------------------------------------------------------------------ -r14397 | etxrab | 2005-05-19 15:32:58 -0500 (Thu, 19 May 2005) | 1 line +r15234 | guy | 2005-08-05 20:39:51 -0500 (Fri, 05 Aug 2005) | 2 lines Changed paths: - M /trunk/asn1/h245/h245.cnf + M /trunk/epan/dissectors/packet-socks.c + +Squelch another const warning. -Display version number and product number as strings. ------------------------------------------------------------------------ -r14396 | guy | 2005-05-19 04:26:15 -0500 (Thu, 19 May 2005) | 6 lines +r15233 | ulfl | 2005-08-05 19:06:14 -0500 (Fri, 05 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-h221_nonstd.c + M /trunk/plugins/xml/xml_plugin.c -Clean up indentation. +fix a comment typo +------------------------------------------------------------------------ +r15232 | ulfl | 2005-08-05 18:58:58 -0500 (Fri, 05 Aug 2005) | 1 line +Changed paths: + M /trunk/capture_stop_conditions.c + M /trunk/conditions.c + M /trunk/docbook/edg_src/EDG_chapter_dissection.xml + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/follow.c + M /trunk/epan/tap.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_stat.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/ui_util.c -Add some comments with questions. +replace malloc and alike calls by their GLib pendants -> g_malloc +------------------------------------------------------------------------ +r15231 | guy | 2005-08-05 18:18:05 -0500 (Fri, 05 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-daap.c -Mark an unused argument as such, and get rid of an unused variable. +Put in a comment asking about the music going over the connection - we +shouldn't try to parse it as DAAP. ------------------------------------------------------------------------ -r14395 | ulfl | 2005-05-18 14:30:18 -0500 (Wed, 18 May 2005) | 1 line +r15230 | guy | 2005-08-05 18:17:15 -0500 (Fri, 05 Aug 2005) | 2 lines Changed paths: - M /trunk/gtk/menu.c - M /trunk/gtk/proto_draw.c + M /trunk/plugins/mate/mate_parser.l + +Squelch a warning about "state" being used uninitialized. -insensitive context menu "Expand Subtrees" if no protocol field is currently selected, sort and name the tree related menu items like the context menu ones ------------------------------------------------------------------------ -r14394 | ulfl | 2005-05-18 14:02:11 -0500 (Wed, 18 May 2005) | 1 line +r15229 | lego | 2005-08-05 17:36:28 -0500 (Fri, 05 Aug 2005) | 3 lines Changed paths: - M /trunk/fileset.c + M /trunk/gtk/hostlist_table.c + +have the definition of init_hostlist_table *ACTUALLY* match its declaration. + -do some code cleanup (from the previous commit) and close the directories opened with opendir/g_dir_open ------------------------------------------------------------------------ -r14393 | lego | 2005-05-18 08:51:49 -0500 (Wed, 18 May 2005) | 3 lines +r15228 | lego | 2005-08-05 17:34:45 -0500 (Fri, 05 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-isup.c + M /trunk/gtk/hostlist_table.c -- add an isup stats_tree with statistics regarding message types and the directions in which they flow. +have the definition of init_hostlist_table match the declaration. ------------------------------------------------------------------------ -r14392 | etxrab | 2005-05-18 00:44:12 -0500 (Wed, 18 May 2005) | 2 lines +r15227 | jmayer | 2005-08-05 15:59:08 -0500 (Fri, 05 Aug 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-h221_nonstd.c + M /trunk/color_filters.c + M /trunk/color_filters.h + M /trunk/epan/packet.c + M /trunk/epan/packet.h + M /trunk/gtk/about_dlg.c + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/capture_prefs.c + M /trunk/gtk/color_dlg.c + M /trunk/gtk/column_prefs.c + M /trunk/gtk/conversations_eth.c + M /trunk/gtk/conversations_fc.c + M /trunk/gtk/conversations_fddi.c + M /trunk/gtk/conversations_ip.c + M /trunk/gtk/conversations_ipx.c + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_sctp.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/conversations_table.h + M /trunk/gtk/conversations_tcpip.c + M /trunk/gtk/conversations_tr.c + M /trunk/gtk/conversations_udpip.c + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/decode_as_dcerpc.c + M /trunk/gtk/decode_as_dcerpc.h + M /trunk/gtk/decode_as_dlg.c + M /trunk/gtk/dfilter_expr_dlg.c + M /trunk/gtk/dlg_utils.c + M /trunk/gtk/dlg_utils.h + M /trunk/gtk/file_dlg.c + M /trunk/gtk/filter_dlg.c + M /trunk/gtk/filter_dlg.h + M /trunk/gtk/find_dlg.c + M /trunk/gtk/find_dlg.h + M /trunk/gtk/flow_graph.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/gtk_stat_util.c + M /trunk/gtk/gtk_stat_util.h + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/help_dlg.c + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_table.c + M /trunk/gtk/hostlist_table.h + M /trunk/gtk/main.c + M /trunk/gtk/menu.c + M /trunk/gtk/menu.h + M /trunk/gtk/packet_list.c + M /trunk/gtk/plugins_dlg.c + M /trunk/gtk/print_dlg.c + M /trunk/gtk/proto_dlg.c + M /trunk/gtk/proto_draw.c + M /trunk/gtk/proto_hier_stats_dlg.c + M /trunk/gtk/recent.c + M /trunk/gtk/sctp_error_dlg.c + M /trunk/gtk/sctp_stat.h + M /trunk/gtk/service_response_time_table.c + M /trunk/gtk/tap_menu.h + M /trunk/gtk/ui_util.c + M /trunk/gtk/ui_util.h + M /trunk/gtk/voip_calls.c + M /trunk/gtk/voip_calls.h + M /trunk/image/dn_arrow.xpm + M /trunk/image/eexcl3d64.xpm + M /trunk/image/eicon3d16.xpm + M /trunk/image/eicon3d32.xpm + M /trunk/image/eicon3d48.xpm + M /trunk/image/icon-ethereal.xpm + M /trunk/image/icon-excl.xpm + M /trunk/image/stock_dialog_error_48.xpm + M /trunk/image/stock_dialog_info_48.xpm + M /trunk/image/stock_dialog_question_48.xpm + M /trunk/image/stock_dialog_warning_48.xpm + M /trunk/image/toolbar/autoscroll_24.xpm + M /trunk/image/toolbar/capture_filter_24.xpm + M /trunk/image/toolbar/capture_interfaces_24.xpm + M /trunk/image/toolbar/capture_options_24.xpm + M /trunk/image/toolbar/capture_restart_24.xpm + M /trunk/image/toolbar/capture_start_24.xpm + M /trunk/image/toolbar/capture_stop_24.xpm + M /trunk/image/toolbar/checkbox_16.xpm + M /trunk/image/toolbar/colorize_24.xpm + M /trunk/image/toolbar/conversations_16.xpm + M /trunk/image/toolbar/decode_as_16.xpm + M /trunk/image/toolbar/display_filter_24.xpm + M /trunk/image/toolbar/endpoints_16.xpm + M /trunk/image/toolbar/file_set_list_16.xpm + M /trunk/image/toolbar/file_set_next_16.xpm + M /trunk/image/toolbar/file_set_previous_16.xpm + M /trunk/image/toolbar/graphs_16.xpm + M /trunk/image/toolbar/internet_24.xpm + M /trunk/image/toolbar/resize_columns_24.xpm + M /trunk/image/toolbar/stock_add_24.xpm + M /trunk/image/toolbar/stock_bottom_24.xpm + M /trunk/image/toolbar/stock_clear_24.xpm + M /trunk/image/toolbar/stock_close_24.xpm + M /trunk/image/toolbar/stock_colorselector_24.xpm + M /trunk/image/toolbar/stock_help_24.xpm + M /trunk/image/toolbar/stock_jump_to_24.xpm + M /trunk/image/toolbar/stock_left_arrow_24.xpm + M /trunk/image/toolbar/stock_ok_20.xpm + M /trunk/image/toolbar/stock_open_24.xpm + M /trunk/image/toolbar/stock_preferences_24.xpm + M /trunk/image/toolbar/stock_print_24.xpm + M /trunk/image/toolbar/stock_properties_24.xpm + M /trunk/image/toolbar/stock_refresh_24.xpm + M /trunk/image/toolbar/stock_right_arrow_24.xpm + M /trunk/image/toolbar/stock_save_24.xpm + M /trunk/image/toolbar/stock_save_as_24.xpm + M /trunk/image/toolbar/stock_search_24.xpm + M /trunk/image/toolbar/stock_stop_24.xpm + M /trunk/image/toolbar/stock_top_24.xpm + M /trunk/image/toolbar/stock_zoom_1_24.xpm + M /trunk/image/toolbar/stock_zoom_in_24.xpm + M /trunk/image/toolbar/stock_zoom_out_24.xpm + M /trunk/image/toolbar/telephony_16.xpm + M /trunk/image/toolbar/time_24.xpm + M /trunk/image/toolbar/web_support_24.xpm + M /trunk/image/toolbar/wiki_24.xpm + M /trunk/image/up_arrow.xpm + M /trunk/plugins/stats_tree/pinfo_stats_tree.c + M /trunk/tap_dfilter_dlg.h + + +More char -> const char warning fixes. +Removed (very few) casts that only change the warning message + but don't remove it (with gcc-4). -Add a dissector for h221 nonstandard data which can easily be expanded with publically avalable data or -replaced by a propriatary one. ------------------------------------------------------------------------ -r14391 | etxrab | 2005-05-18 00:19:22 -0500 (Wed, 18 May 2005) | 3 lines +r15226 | etxrab | 2005-08-05 14:37:57 -0500 (Fri, 05 Aug 2005) | 12 lines Changed paths: - M /trunk/gtk/sctp_stat.c + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h -From Albert Chin: -C++ comments in C source files (gtk/sctp_stat.c) +From David Richards: +here are the highlights of what's fixed: + +1) Decoding of vendor-defined types +2) Decoding of some event notification parameters (not all) +3) Decoding of ABSTRACT-SYNTAX&Type +4) Decoding of BACnetTimeStamp +5) Some problems with context-tagged values (like booleans) +6) Continuation segments - don't try to decode them since you can't +start mid-PDU +7) Removed some excessive levels of subtrees ------------------------------------------------------------------------ -r14390 | ulfl | 2005-05-17 20:21:49 -0500 (Tue, 17 May 2005) | 1 line +r15225 | etxrab | 2005-08-05 14:32:26 -0500 (Fri, 05 Aug 2005) | 2 lines Changed paths: - M /trunk/fileset.c + M /trunk/plugins/asn1/packet-asn1.c -don't crash, if the given filename doesn't contain a dot e.g. 'test123' +From Thomas Steffen: +Fix a copy-paste error in the prefs. code ------------------------------------------------------------------------ -r14389 | ulfl | 2005-05-17 19:55:44 -0500 (Tue, 17 May 2005) | 1 line +r15224 | etxrab | 2005-08-05 14:16:29 -0500 (Fri, 05 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/epan/dissectors/packet-gsm_a.c + +From THORNTON, MATT +Some changes that I made to flesh out GPRS message parsing. More information is displayed about the various frame formats. I have also added some code to parse XID parameters in the U frame. I have also fixed a couple of display bugs in the GSM and GPRS LLC parser. -fix #187: don't crash if using "Expand Subtrees" in an empty area, just do nothing in that case ------------------------------------------------------------------------ -r14388 | etxrab | 2005-05-17 15:32:30 -0500 (Tue, 17 May 2005) | 1 line +r15223 | jmayer | 2005-08-05 08:23:47 -0500 (Fri, 05 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h245.h + M /trunk/epan/proto.c -Make it possible to dissect h221nonstandard data and fix some compile warnings from asn2eth. +char -> const char warning fixes ------------------------------------------------------------------------ -r14387 | etxrab | 2005-05-17 15:30:49 -0500 (Tue, 17 May 2005) | 1 line +r15222 | jmayer | 2005-08-05 08:10:58 -0500 (Fri, 05 Aug 2005) | 1 line Changed paths: - M /trunk/asn1/h245/h245.cnf - M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ber.h + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-telnet.c + M /trunk/epan/dissectors/packet-tr.c + M /trunk/epan/dissectors/packet-trmac.c + M /trunk/epan/dissectors/packet-user_encap.c + M /trunk/epan/dissectors/packet-vines.c + M /trunk/epan/dissectors/packet-windows-common.c + M /trunk/epan/dissectors/packet-x25.c -Make it possible to dissect h221nonstandarddata and fix some errors from the new asn2eth generator. +More char -> const char warning fixes ------------------------------------------------------------------------ -r14386 | etxrab | 2005-05-17 14:51:09 -0500 (Tue, 17 May 2005) | 2 lines +r15221 | ulfl | 2005-08-05 04:20:48 -0500 (Fri, 05 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-nettl.c + M /trunk/docbook/edg_src/EDG_chapter_sources.xml + M /trunk/docbook/edg_src/EDG_chapter_tools.xml + +note that calling distclean target should be done first -From Mark C Brown,: -Fixes for LAP-B (SX25L2) and X.25 (SX25L3) nettl trace records. +add the MSVC tools to the verify_tools target, add some explanation of common problems ------------------------------------------------------------------------ -r14385 | etxrab | 2005-05-17 14:50:38 -0500 (Tue, 17 May 2005) | 2 lines +r15220 | ulfl | 2005-08-05 03:34:47 -0500 (Fri, 05 Aug 2005) | 4 lines Changed paths: - M /trunk/wiretap/nettl.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h + M /trunk/Makefile.nmake + +verify_tools: +- not only look for the cygwin tools, but also check the MSVC tools required like cl.exe, link.exe and nmake.exe -From Mark C Brown,: -Fixes for LAP-B (SX25L2) and X.25 (SX25L3) nettl trace records. +- I don't know why we should use /usr/bin/find but simply find, check for it instead. If there's a reason to use /usr/bin/find, we should use $(FIND) instead but I currently don't see a reason for this ------------------------------------------------------------------------ -r14384 | etxrab | 2005-05-17 14:21:45 -0500 (Tue, 17 May 2005) | 3 lines +r15219 | jmayer | 2005-08-04 19:29:34 -0500 (Thu, 04 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-acse.c + M /trunk/asn1/gsm_ss/Makefile -From Yuriy Sidelnikov: -A perfectly good tvb_bytes_to_str() has been used instead of string_to_hex. +Add eol-style and keywords properties +------------------------------------------------------------------------ +r15218 | jmayer | 2005-08-04 19:23:22 -0500 (Thu, 04 Aug 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-gssapi.c + M /trunk/epan/dissectors/packet-gssapi.h + M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-nlsp.c + M /trunk/epan/dissectors/packet-nntp.c + M /trunk/epan/dissectors/packet-nt-sonmp.c + M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-osi-options.c + M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-pn-rt.c + M /trunk/epan/dissectors/packet-portmap.c + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-q933.c + M /trunk/epan/dissectors/packet-quakeworld.c + M /trunk/epan/dissectors/packet-radius.h + M /trunk/epan/dissectors/packet-ranap.c + M /trunk/epan/dissectors/packet-rdt.c + M /trunk/epan/dissectors/packet-rdt.h + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-sap.c + M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-slsk.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-socks.c + M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-t38.h + M /trunk/epan/radius_dict.l + M /trunk/epan/tap.c + M /trunk/epan/tap.h +More char -> const char warning fixes ------------------------------------------------------------------------ -r14383 | etxrab | 2005-05-17 14:15:31 -0500 (Tue, 17 May 2005) | 2 lines +r15217 | sahlberg | 2005-08-04 19:23:08 -0500 (Thu, 04 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter-defs.h + A /trunk/asn1/gsm_ss/Makefile + +Add unix makefile for work in progress GSM-SS dissector -Add some more AVP:s. ------------------------------------------------------------------------ -r14382 | etxrab | 2005-05-17 14:13:05 -0500 (Tue, 17 May 2005) | 1 line +r15216 | jmayer | 2005-08-04 17:54:04 -0500 (Thu, 04 Aug 2005) | 1 line Changed paths: - M /trunk/plugins/xml/packet-xml.c + M /trunk/epan/dissectors/packet-iax2.c -Add some more media types to be dissected as xml. +Separate declaration from initialization with non-static values ------------------------------------------------------------------------ -r14381 | lego | 2005-05-17 08:29:36 -0500 (Tue, 17 May 2005) | 3 lines +r15215 | guy | 2005-08-04 17:37:49 -0500 (Thu, 04 Aug 2005) | 3 lines Changed paths: - M /trunk/plugins/mate/mate_parser.l - -- change the state label OUT to OUTSIDE to avoid a name collision with a macro defined in the windows system headers. + M /trunk/README.win32 +Note that if you're building from a source tarball, before the first +build you must do "nmake -f makefile.make distclean". ------------------------------------------------------------------------ -r14380 | gram | 2005-05-16 20:47:04 -0500 (Mon, 16 May 2005) | 3 lines +r15214 | guy | 2005-08-04 17:22:53 -0500 (Thu, 04 Aug 2005) | 5 lines Changed paths: - M /trunk/tools/EtherealXML.py + M /trunk/epan/Makefile.nmake + M /trunk/plugins/mate/Makefile.nmake + M /trunk/plugins/xml/Makefile.nmake -Add get_items_before(), to help analyze in the presence of -tunneled protocols. +Put in comments explaining why we're removing some generated files with +"make distclean", even though they come with the distribution, and +make the one in plugins/xml/Makefile.nmake match the one in some other +files. ------------------------------------------------------------------------ -r14379 | gram | 2005-05-16 18:21:01 -0500 (Mon, 16 May 2005) | 3 lines +r15213 | guy | 2005-08-04 17:13:33 -0500 (Thu, 04 Aug 2005) | 3 lines Changed paths: - M /trunk/tools/EtherealXML.py + M /trunk/cleanbld.bat -Add get_hide() to return the value of the "hide" tag -in field attributes. +Delete some new Flex-generated files, and put in a comment explaining +that we're doing that and explaining why we're doing it. ------------------------------------------------------------------------ -r14378 | etxrab | 2005-05-16 13:24:27 -0500 (Mon, 16 May 2005) | 1 line +r15212 | jmayer | 2005-08-04 16:54:00 -0500 (Thu, 04 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/Makefile.common -Add TCP port for "radan-http 8088/tcp Radan HTTP" from IANA. +Forgot to remove gdebug.h from Makefile.common too ------------------------------------------------------------------------ -r14377 | etxrab | 2005-05-16 13:15:33 -0500 (Mon, 16 May 2005) | 1 line +r15211 | jmayer | 2005-08-04 16:40:58 -0500 (Thu, 04 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-text-media.c + M /trunk/doc/README.developer + +Don't initialize variables in their declaration with non-constant +values. -Add some more media types. ------------------------------------------------------------------------ -r14376 | lego | 2005-05-16 12:16:52 -0500 (Mon, 16 May 2005) | 3 lines +r15210 | jmayer | 2005-08-04 16:31:40 -0500 (Thu, 04 Aug 2005) | 6 lines Changed paths: - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_plugin.c - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/mate_util.c - M /trunk/plugins/mate/mate_util.h + M /trunk/epan/dissectors/packet-ms-mms.c + -Transforms and Pdus are working already, Gops start to work. +Albert Chin: + uses of some C99'isms which prevent compilation on + IRIX 6.5 with the SGI C compiler. ------------------------------------------------------------------------ -r14375 | lego | 2005-05-16 10:10:50 -0500 (Mon, 16 May 2005) | 3 lines +r15209 | jmayer | 2005-08-04 16:09:08 -0500 (Thu, 04 Aug 2005) | 6 lines Changed paths: - M /trunk/plugins/mate/Makefile.nmake + M /trunk/epan/dfilter/gencode.c + M /trunk/epan/ftypes/ftype-tvbuff.c + D /trunk/epan/gdebug.h -let's get things right, we are in plugins/mate not epan/dfilter (from which I stole the nmake rules) +Albert Chin: + Don't include epan/gdebug.h + +Now that epan/gdebug.h is unused: remove it ------------------------------------------------------------------------ -r14374 | lego | 2005-05-16 09:59:14 -0500 (Mon, 16 May 2005) | 3 lines +r15208 | jmayer | 2005-08-04 15:41:52 -0500 (Thu, 04 Aug 2005) | 6 lines Changed paths: - M /trunk/plugins/mate/Makefile.nmake + M /trunk/tools/lemon/lempar.c -Forgot this one in the last checkin! + +Albert Chin: + "config.h" should always be included first. However, lemon + includes <stdio.h> first. ------------------------------------------------------------------------ -r14373 | lego | 2005-05-16 08:28:35 -0500 (Mon, 16 May 2005) | 5 lines +r15207 | gerald | 2005-08-04 12:14:19 -0500 (Thu, 04 Aug 2005) | 2 lines Changed paths: - M /trunk/plugins/mate - M /trunk/plugins/mate/Makefile.am - M /trunk/plugins/mate/mate.h - A /trunk/plugins/mate/mate_grammar.lemon - A /trunk/plugins/mate/mate_parser.l - M /trunk/plugins/mate/mate_plugin.c - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/mate_util.c - M /trunk/plugins/mate/mate_util.h - M /trunk/plugins/mate/moduleinfo.h - M /trunk/plugins/mate/packet-mate.c + M /trunk/docbook/release-notes.xml -MATE has a grammar. +Add items for the recent FC-FCS and RSVP bug fixes. -Although not yet fully implemented I want this version as a reference. +------------------------------------------------------------------------ +r15206 | gerald | 2005-08-04 12:11:32 -0500 (Thu, 04 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-rsvp.c +Increase the size of some variables, so that we don't overflow them. Fixes +the infinite loops in bugs 311 and 314. ------------------------------------------------------------------------ -r14372 | etxrab | 2005-05-16 01:16:45 -0500 (Mon, 16 May 2005) | 6 lines +r15205 | gram | 2005-08-04 08:54:46 -0500 (Thu, 04 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rdt.c + M /trunk/AUTHORS + M /trunk/epan/Makefile.am + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/exceptions.h + A /trunk/epan/exntest.c -From Martin Mathieson: -new version of the RDT dissector. It turns out that -specs are available for this protocol on www.helixcommunity.org - this -version was written by myself and Tom Marshall of RealNetworks, Inc. +Exception handling fixes, and a fix to packet-frame.c, +from Richard van der Hoff. -I Changed stream_id and asm_rule_number to be guint16 to fix compiler warnings. ------------------------------------------------------------------------ -r14371 | etxrab | 2005-05-15 16:17:29 -0500 (Sun, 15 May 2005) | 3 lines +r15204 | guy | 2005-08-04 05:24:33 -0500 (Thu, 04 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-fcfcs.c - From Tim Endean: - Ss-code is Optional in some cases. +When processing records, advance the offset. ------------------------------------------------------------------------ -r14370 | etxrab | 2005-05-15 16:15:53 -0500 (Sun, 15 May 2005) | 2 lines +r15203 | etxrab | 2005-08-03 15:51:54 -0500 (Wed, 03 Aug 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn + M /trunk/asn1/gsmmap/gsm_map-exp.cnf + M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/asn1/gsmmap/packet-gsm_map-template.h -From Tim Endean: -Ss-code is Optional in some cases. +Use the new fn_par functions, fix of a bug and export functions used by gsm_ss. ------------------------------------------------------------------------ -r14369 | sahlberg | 2005-05-14 17:05:56 -0500 (Sat, 14 May 2005) | 5 lines +r15202 | etxrab | 2005-08-03 15:49:52 -0500 (Wed, 03 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + A /trunk/asn1/gsm_ss + A /trunk/asn1/gsm_ss/Makefile.nmake + A /trunk/asn1/gsm_ss/SS-Operations.asn + A /trunk/asn1/gsm_ss/gsm_ss.cnf + A /trunk/asn1/gsm_ss/packet-gsm_ss-template.c + A /trunk/asn1/gsm_ss/packet-gsm_ss-template.h -from martin m +First checkin of asn2eth generated gsm ss dissector - work in progress not ready to replace the existing +dissector yet. +------------------------------------------------------------------------ +r15201 | etxrab | 2005-08-03 15:37:28 -0500 (Wed, 03 Aug 2005) | 20 lines +Changed paths: + M /trunk/epan/Makefile.common + M /trunk/epan/dissectors/packet-iax2.c + A /trunk/epan/nstime.c + M /trunk/epan/nstime.h + M /trunk/timestats.c + M /trunk/timestats.h -prettify dcerpc +From Richard van der Hoff: +Among the improvements are: +- fixes to call-tracking (it's now less likely to confuse two separate +calls, for instance) +- improvements to Information Element dissection (clearer dissection, +dissects more IE types, easier to extend) +- you can now filter on the content of DTMF packets +- Analysis of timestamps (calculation of absolute timestamp, and packet +lateness). +- fixed a couple of assertion failures in subtle corner-cases. +negative relative times: + - get_timedelta() + - addtime() + - ftype-time.c:relative_val_from_unparsed() + +I've also moved get_timedelta() and addtime() out of calldata.c into a +new file, epan/nstime.c, as I needed to use them in a dissector I'm +working on (and they therefore needed to go into libethereal). ------------------------------------------------------------------------ -r14368 | gerald | 2005-05-14 16:13:07 -0500 (Sat, 14 May 2005) | 3 lines +r15200 | gerald | 2005-08-03 12:32:00 -0500 (Wed, 03 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee8023.c + M /trunk/wiretap/i4b_trace.h + M /trunk/wiretap/i4btrace.c -When we catch an exception, make sure we don't throw the same exception again -(and catch it again in the process). Fixes bug 170. +Don't assume ints are 32 bits. Fixes a recent Buildbot error. ------------------------------------------------------------------------ -r14367 | sahlberg | 2005-05-14 16:08:20 -0500 (Sat, 14 May 2005) | 4 lines +r15199 | etxrab | 2005-08-02 16:16:56 -0500 (Tue, 02 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-gsm_sms.c -from dinesh -fix to make Zone_Alias objects decode properly +Fix "tvb_fake_unicode takes the lengt in number of guint16's not guint8's" fix up indentation. +------------------------------------------------------------------------ +r15198 | gerald | 2005-08-02 13:26:31 -0500 (Tue, 02 Aug 2005) | 4 lines +Changed paths: + M /trunk/docbook/release-notes.xml +After reading through the code again, the LPD +dissector wasn't susceptible to a crash. The patch at +http://cvs.fedora.redhat.com/viewcvs/rpms/ethereal/FC-4/ is unneccessary. ------------------------------------------------------------------------ -r14366 | sahlberg | 2005-05-14 16:00:43 -0500 (Sat, 14 May 2005) | 4 lines +r15197 | sahlberg | 2005-08-02 12:34:14 -0500 (Tue, 02 Aug 2005) | 7 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-armagetronad.c + M /trunk/epan/dissectors/packet-mmse.c -From Guillaume Chazarain -New protocol : ARMAGETRONAD dissector for the protcol used by the game of the same name +ememify the tvb_get_string call in mmse. +the strings mmse got from tvb_get_string were never released anyway +so this would resolve significant memory leakage in mmse. + +there are still memleaks in mmse but one step at a time ------------------------------------------------------------------------ -r14365 | gerald | 2005-05-14 14:13:02 -0500 (Sat, 14 May 2005) | 4 lines +r15196 | sahlberg | 2005-08-02 12:24:26 -0500 (Tue, 02 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-rpc.c + +ememify packet-rpc call to tvb_get_string() -Throw an exception if AndXOffset is less than the current offset. Fixes bug -163. I'm not sure if this fix is entirely correct, but it doesn't appear to -have affected any SMB captures here adversely. ------------------------------------------------------------------------ -r14364 | sahlberg | 2005-05-14 12:41:07 -0500 (Sat, 14 May 2005) | 3 lines +r15195 | sahlberg | 2005-08-02 12:15:56 -0500 (Tue, 02 Aug 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-sdp.c -add decoding of teh REMOVABLE bit in inquiry data +remove a pointless g_strdup ------------------------------------------------------------------------ -r14363 | sahlberg | 2005-05-14 12:12:45 -0500 (Sat, 14 May 2005) | 3 lines +r15194 | gerald | 2005-08-02 10:25:41 -0500 (Tue, 02 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c - -add a missing field to the REPORT LUNS datain pdu + M /trunk/epan/dfilter/Makefile.am + M /trunk/plugins/mate/Makefile.am +Clean up after ourselves so that we pass "distcheck" again. ------------------------------------------------------------------------ -r14362 | gram | 2005-05-13 14:44:25 -0500 (Fri, 13 May 2005) | 3 lines +r15193 | guy | 2005-08-02 03:42:02 -0500 (Tue, 02 Aug 2005) | 3 lines Changed paths: - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.h + M /trunk/epan/exceptions.h -Add WTAP_GCOM_TIE1 and WTAP_GCOM_SERIAL for -Oolan Zimmer <ethereal@gcom.com> +Explain the BoundsError and ReportedBoundsError errors a bit more, as +per Ulf Lamping's request. ------------------------------------------------------------------------ -r14361 | lego | 2005-05-13 06:16:05 -0500 (Fri, 13 May 2005) | 4 lines +r15192 | jmayer | 2005-08-02 03:37:53 -0500 (Tue, 02 Aug 2005) | 1 line Changed paths: - M /trunk/asn1/h248/h248.cnf - M /trunk/asn1/h248/packet-h248-template.c - M /trunk/epan/dissectors/packet-h248.c + M /trunk/gtk -- make sure contextId and transactionId are added to the tree as filterable fields even if they are larger than 4 octets -- set COL_INFO to something useful +Include .libs in svn:ignore +------------------------------------------------------------------------ +r15191 | jmayer | 2005-08-02 03:30:33 -0500 (Tue, 02 Aug 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-sscop.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/dissectors/packet-tds.c + M /trunk/epan/dissectors/packet-ymsg.c + M /trunk/epan/stats_tree.c + M /trunk/gtk/menu.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/packet-mate.c +Last set of trivial fixes for "no previous declaration" warnings. ------------------------------------------------------------------------ -r14360 | etxrab | 2005-05-13 00:50:26 -0500 (Fri, 13 May 2005) | 1 line +r15190 | ulfl | 2005-08-02 02:30:38 -0500 (Tue, 02 Aug 2005) | 1 line Changed paths: - M /trunk/tools/Makefile.am + M /trunk/epan/epan.h -Forgott the lex.py file +add some comments, has to be extended ------------------------------------------------------------------------ -r14359 | etxrab | 2005-05-13 00:47:56 -0500 (Fri, 13 May 2005) | 1 line +r15189 | ulfl | 2005-08-02 02:29:15 -0500 (Tue, 02 Aug 2005) | 1 line Changed paths: - M /trunk/tools/Makefile.am + M /trunk/gtk/main.c -Add the asn2eth related files to extra-dist (I hope this is the right thing to do to get them into the SVN tarballs). +add some minor comments around the GTK main loop ------------------------------------------------------------------------ -r14358 | guy | 2005-05-11 22:31:33 -0500 (Wed, 11 May 2005) | 3 lines +r15188 | ulfl | 2005-08-02 02:26:57 -0500 (Tue, 02 Aug 2005) | 9 lines Changed paths: - M /trunk/acinclude.m4 - M /trunk/capture_loop.c + M /trunk/epan/dissectors/packet-dcerpc.c + +bugfix: in an attepmt to fix a crash while doing reassemling of connection oriented packets, some weeks ago I've added some tvb_ensure_bytes_exist() calls to test the case that the alloc_hint value is bogus (found in private fuzz testing). + +Unfortunately, this is *very* safe now as it will mark a lot of DCE/RPC packets as malformed, thus the reassembling code won't work with most packets :-( + +I've replaced this with the correct check and used THROW(ReportedBoundsError) instead which is hopefully the right error in this case. -Use "pcap_get_selectable_fd()" if we have it, and if it returns -1, -don't do a "select()". +BTW: could someone please add a description of the ReportedBoundsError vs. BoundsError to the code as I still don't get it. +In addition: Use a toplevel tree item to display the DCE/RPC defragmentation just as it's done in the TCP desegmentation code. ------------------------------------------------------------------------ -r14357 | guy | 2005-05-11 22:29:59 -0500 (Wed, 11 May 2005) | 2 lines +r15187 | jmayer | 2005-08-02 02:03:46 -0500 (Tue, 02 Aug 2005) | 1 line Changed paths: - M /trunk/tethereal.c - -Don't include <pcap.h> twice. + M /trunk/aclocal-flags +Make aclocal-flags executable again (hopefully fixes buildbot fc4) ------------------------------------------------------------------------ -r14356 | guy | 2005-05-11 22:29:26 -0500 (Wed, 11 May 2005) | 7 lines +r15186 | jmayer | 2005-08-02 01:44:18 -0500 (Tue, 02 Aug 2005) | 6 lines Changed paths: - M /trunk/gtk/drag_and_drop.c + M /trunk/doc/capinfos.pod + M /trunk/doc/editcap.pod + M /trunk/doc/ethereal-filter.pod.template + M /trunk/doc/ethereal-tut.mgp + M /trunk/doc/ethereal.pod + M /trunk/doc/idl2eth.pod + M /trunk/doc/mergecap.pod + M /trunk/doc/sgml.doc.template + M /trunk/doc/tethereal.pod + M /trunk/doc/text2pcap.pod -If we have libpcap, include <pcap.h>, because "capture.h" requires it. -If we *don't* have libpcap, don't include "capture.h", and don't test -whether a capture is in progress. + Fix svn properties where needed: + Add svn:eol-style + Add svn:keywords -Clean up a message. ------------------------------------------------------------------------ -r14355 | guy | 2005-05-11 21:55:59 -0500 (Wed, 11 May 2005) | 6 lines +r15185 | jmayer | 2005-08-02 01:39:04 -0500 (Tue, 02 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/docbook/Makefile + M /trunk/docbook/edg_src/EDG_chapter_build_intro.xml + M /trunk/docbook/edg_src/EDG_chapter_capture.xml + M /trunk/docbook/edg_src/EDG_chapter_dissection.xml + M /trunk/docbook/edg_src/EDG_chapter_works.xml + M /trunk/docbook/release-notes.xml -Squelch a compiler warning (GCC 4.0's data flow analysis is -interprocedural, so it knows "sip_parse_line()" doesn't always set -"*token_1_len", but it doesn't know that if it doesn't return OTHER_LINE -it *does* always set it, so it's safe not to set it as long as it's -never used if the return value is OTHER_LINE). + Fix svn properties where needed: + Remove svn:executable + Add svn:executable + Add svn:eol-style + Add svn:keywords + Add mime-type ------------------------------------------------------------------------ -r14354 | guy | 2005-05-11 21:51:59 -0500 (Wed, 11 May 2005) | 2 lines +r15184 | jmayer | 2005-08-02 01:29:49 -0500 (Tue, 02 Aug 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/help/capture_filters.txt + M /trunk/help/capturing.txt + M /trunk/help/display_filters.txt + M /trunk/help/faq.txt + M /trunk/help/getting_started.txt + M /trunk/help/overview.txt + M /trunk/help/toc + M /trunk/idl/coseventcomm.idl + M /trunk/idl/cosnaming.idl + M /trunk/idl/parlay/Parlay.idl + M /trunk/idl/parlay/am.idl + M /trunk/idl/parlay/cccs.idl + M /trunk/idl/parlay/cm.idl + M /trunk/idl/parlay/common_cc_data.idl + M /trunk/idl/parlay/cs.idl + M /trunk/idl/parlay/dsc.idl + M /trunk/idl/parlay/fw_data.idl + M /trunk/idl/parlay/fw_if.idl + M /trunk/idl/parlay/fw_if_access.idl + M /trunk/idl/parlay/fw_if_app.idl + M /trunk/idl/parlay/fw_if_entop.idl + M /trunk/idl/parlay/fw_if_service.idl + M /trunk/idl/parlay/gcc_data.idl + M /trunk/idl/parlay/gcc_interfaces.idl + M /trunk/idl/parlay/gms.idl + M /trunk/idl/parlay/mm.idl + M /trunk/idl/parlay/mmccs.idl + M /trunk/idl/parlay/mmm.idl + M /trunk/idl/parlay/mpcc_data.idl + M /trunk/idl/parlay/mpcc_interfaces.idl + M /trunk/idl/parlay/osa.idl + M /trunk/idl/parlay/pam_data.idl + M /trunk/idl/parlay/pam_interfaces.idl + M /trunk/idl/parlay/policy_data.idl + M /trunk/idl/parlay/policy_interfaces.idl + M /trunk/idl/parlay/termcap.idl + M /trunk/idl/parlay/ui_data.idl + M /trunk/idl/parlay/ui_interfaces.idl + M /trunk/idl/tango.idl + M /trunk/image/README.image + M /trunk/image/capinfos.rc.in + M /trunk/image/clist_ascend.xpm + M /trunk/image/clist_descend.xpm + M /trunk/image/dn_arrow.xpm + M /trunk/image/editcap.rc.in + M /trunk/image/eexcl3d64.xpm + M /trunk/image/eicon3d16.xpm + M /trunk/image/eicon3d32.xpm + M /trunk/image/eicon3d48.xpm + M /trunk/image/eicon3d64.xpm + M /trunk/image/elogo3d48x48.png + M /trunk/image/ethereal.rc.in + M /trunk/image/hi16-app-ethereal.png + M /trunk/image/hi32-app-ethereal.png + M /trunk/image/hi48-app-ethereal.png + M /trunk/image/icon-ethereal.xpm + M /trunk/image/icon-excl.xpm + M /trunk/image/icon_layout_1.xpm + M /trunk/image/icon_layout_2.xpm + M /trunk/image/icon_layout_3.xpm + M /trunk/image/icon_layout_4.xpm + M /trunk/image/icon_layout_5.xpm + M /trunk/image/icon_layout_6.xpm + M /trunk/image/libethereal.rc.in + M /trunk/image/lo16-app-ethereal.png + M /trunk/image/lo32-app-ethereal.png + M /trunk/image/lo48-app-ethereal.png + M /trunk/image/mergecap.rc.in + M /trunk/image/nsis-checked.bmp + M /trunk/image/nsis-unchecked.bmp + M /trunk/image/stock_dialog_error_48.xpm + M /trunk/image/stock_dialog_info_48.xpm + M /trunk/image/stock_dialog_question_48.xpm + M /trunk/image/stock_dialog_warning_48.xpm + M /trunk/image/toolbar/autoscroll_24.xpm + M /trunk/image/toolbar/capture_filter_24.xpm + M /trunk/image/toolbar/capture_interfaces_24.xpm + M /trunk/image/toolbar/capture_options_24.xpm + M /trunk/image/toolbar/capture_restart_24.xpm + M /trunk/image/toolbar/capture_start_24.xpm + M /trunk/image/toolbar/capture_stop_24.xpm + M /trunk/image/toolbar/checkbox_16.xpm + M /trunk/image/toolbar/colorize_24.xpm + M /trunk/image/toolbar/conversations_16.xpm + M /trunk/image/toolbar/decode_as_16.xpm + M /trunk/image/toolbar/display_filter_24.xpm + M /trunk/image/toolbar/endpoints_16.xpm + M /trunk/image/toolbar/file_set_list_16.xpm + M /trunk/image/toolbar/file_set_next_16.xpm + M /trunk/image/toolbar/file_set_previous_16.xpm + M /trunk/image/toolbar/graphs_16.xpm + M /trunk/image/toolbar/internet_24.xpm + M /trunk/image/toolbar/resize_columns_24.xpm + M /trunk/image/toolbar/stock_add_24.xpm + M /trunk/image/toolbar/stock_bottom_24.xpm + M /trunk/image/toolbar/stock_clear_24.xpm + M /trunk/image/toolbar/stock_close_24.xpm + M /trunk/image/toolbar/stock_colorselector_24.xpm + M /trunk/image/toolbar/stock_help_24.xpm + M /trunk/image/toolbar/stock_jump_to_24.xpm + M /trunk/image/toolbar/stock_left_arrow_24.xpm + M /trunk/image/toolbar/stock_ok_20.xpm + M /trunk/image/toolbar/stock_open_24.xpm + M /trunk/image/toolbar/stock_preferences_24.xpm + M /trunk/image/toolbar/stock_print_24.xpm + M /trunk/image/toolbar/stock_properties_24.xpm + M /trunk/image/toolbar/stock_refresh_24.xpm + M /trunk/image/toolbar/stock_right_arrow_24.xpm + M /trunk/image/toolbar/stock_save_24.xpm + M /trunk/image/toolbar/stock_save_as_24.xpm + M /trunk/image/toolbar/stock_search_24.xpm + M /trunk/image/toolbar/stock_stop_24.xpm + M /trunk/image/toolbar/stock_top_24.xpm + M /trunk/image/toolbar/stock_zoom_1_24.xpm + M /trunk/image/toolbar/stock_zoom_in_24.xpm + M /trunk/image/toolbar/stock_zoom_out_24.xpm + M /trunk/image/toolbar/telephony_16.xpm + M /trunk/image/toolbar/time_24.xpm + M /trunk/image/toolbar/web_support_24.xpm + M /trunk/image/toolbar/wiki_24.xpm + + + Fix svn properties where needed: + Remove svn:executable + Add svn:executable + Add svn:eol-style + Add svn:keywords + + +------------------------------------------------------------------------ +r15183 | jmayer | 2005-08-02 01:15:02 -0500 (Tue, 02 Aug 2005) | 7 lines +Changed paths: + M /trunk/packaging/Makefile.am + M /trunk/packaging/nsis/GetWindowsVersion.nsh + M /trunk/packaging/nsis/Makefile.am + M /trunk/packaging/rpm/Makefile.am + M /trunk/packaging/rpm/SPECS/Makefile.am + M /trunk/packaging/rpm/SPECS/ethereal.spec.in + +Fix svn properties where needed: + Remove svn:executable + Add svn:executable + Add svn:eol-style + Add svn:keywords -Fix a routine to return the value it's supposed to return. ------------------------------------------------------------------------ -r14353 | guy | 2005-05-11 21:50:27 -0500 (Wed, 11 May 2005) | 4 lines +r15182 | jmayer | 2005-08-02 00:58:15 -0500 (Tue, 02 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/tools/EtherealXML.py + M /trunk/tools/Makefile.nmake + M /trunk/tools/asn2eth.py + M /trunk/tools/ftsanity.py + M /trunk/tools/lemon/lemon.html + M /trunk/tools/lemon/lempar.c + M /trunk/tools/lex.py + M /trunk/tools/msnchat + M /trunk/tools/netscreen2dump.py + M /trunk/tools/pkt-from-core.py + M /trunk/tools/win32-setup.sh + M /trunk/tools/yacc.py + + Fix svn properties where needed: + Remove svn:executable + Add svn:executable + Add svn:eol-style + Add svn:keywords -Always set "*success" in "ipxnet_addr_lookup()" before returning (thanks -and a tip of the hat to GCC 4.0's interprocedural data flow analysis for -catching this one!). ------------------------------------------------------------------------ -r14352 | etxrab | 2005-05-11 17:20:11 -0500 (Wed, 11 May 2005) | 1 line +r15181 | jmayer | 2005-08-02 00:51:38 -0500 (Tue, 02 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/wiretap/AUTHORS + M /trunk/wiretap/COPYING + M /trunk/wiretap/ChangeLog + M /trunk/wiretap/INSTALL + M /trunk/wiretap/NEWS + M /trunk/wiretap/wtap.def + + + Fix svn properties where needed: + Remove svn:executable + Add svn:eol-style + Add svn:keywords + -Reinsert Gerards patch (r14342) which was lost. ------------------------------------------------------------------------ -r14351 | etxrab | 2005-05-11 17:19:36 -0500 (Wed, 11 May 2005) | 1 line +r15180 | jmayer | 2005-08-02 00:46:16 -0500 (Tue, 02 Aug 2005) | 4 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/AUTHORS + M /trunk/COPYING + M /trunk/ChangeLog + M /trunk/FAQ + M /trunk/INSTALL + M /trunk/INSTALL.configure + M /trunk/aclocal-flags + M /trunk/cfilters + M /trunk/colorfilters + M /trunk/config.guess + M /trunk/config.sub + M /trunk/dfilters + M /trunk/dictionary.dtd + M /trunk/dictionary.xml + M /trunk/doxygen.cfg.in + M /trunk/doxygen_global.cfg + M /trunk/getopt.h + M /trunk/imscxdx.xml + M /trunk/mkstemp.c + M /trunk/mkstemp.h + M /trunk/mobileipv4.xml + M /trunk/nasreq.xml + M /trunk/print.ps + M /trunk/strcasecmp.c + M /trunk/strncasecmp.c + M /trunk/strptime.c + M /trunk/sunping.xml + M /trunk/tap-sctpchunkstat.c + M /trunk/tap-stats_tree.c + +Remove svn:executable +Add svn:eol-style native +Add svn:keywords Id + +------------------------------------------------------------------------ +r15179 | jmayer | 2005-08-02 00:39:45 -0500 (Tue, 02 Aug 2005) | 7 lines +Changed paths: + M /trunk/epan/AUTHORS + M /trunk/epan/ChangeLog + M /trunk/epan/NEWS + M /trunk/epan/dfilter/README.dfilter + M /trunk/epan/dfilter/gencode.h + M /trunk/epan/dissectors/dcerpc/atsvc/Makefile + M /trunk/epan/dissectors/dcerpc/atsvc/atsvc.cnf + M /trunk/epan/dissectors/dcerpc/atsvc/atsvc.idl + M /trunk/epan/dissectors/dcerpc/atsvc/template.c + M /trunk/epan/dissectors/dcerpc/atsvc/template.h + M /trunk/epan/dissectors/dcerpc/budb/Makefile + M /trunk/epan/dissectors/dcerpc/budb/budb.cnf + M /trunk/epan/dissectors/dcerpc/budb/budb.idl + M /trunk/epan/dissectors/dcerpc/budb/template.c + M /trunk/epan/dissectors/dcerpc/budb/template.h + M /trunk/epan/dissectors/dcerpc/butc/Makefile + M /trunk/epan/dissectors/dcerpc/butc/butc.cnf + M /trunk/epan/dissectors/dcerpc/butc/butc.idl + M /trunk/epan/dissectors/dcerpc/butc/template.c + M /trunk/epan/dissectors/dcerpc/butc/template.h + M /trunk/epan/dissectors/dcerpc/drsuapi/Makefile + M /trunk/epan/dissectors/dcerpc/drsuapi/drsuapi.cnf + M /trunk/epan/dissectors/dcerpc/drsuapi/drsuapi.idl + M /trunk/epan/dissectors/dcerpc/drsuapi/template.c + M /trunk/epan/dissectors/dcerpc/drsuapi/template.h + M /trunk/epan/dissectors/dcerpc/dssetup/Makefile + M /trunk/epan/dissectors/dcerpc/dssetup/dssetup.cnf + M /trunk/epan/dissectors/dcerpc/dssetup/dssetup.idl + M /trunk/epan/dissectors/dcerpc/dssetup/packet-dcerpc-dssetup.c + M /trunk/epan/dissectors/dcerpc/dssetup/packet-dcerpc-dssetup.h + M /trunk/epan/dissectors/dcerpc/dssetup/template.c + M /trunk/epan/dissectors/dcerpc/dssetup/template.h + M /trunk/epan/dissectors/dcerpc/efs/Makefile + M /trunk/epan/dissectors/dcerpc/efs/efs.cnf + M /trunk/epan/dissectors/dcerpc/efs/efs.idl + M /trunk/epan/dissectors/dcerpc/efs/template.c + M /trunk/epan/dissectors/dcerpc/efs/template.h + M /trunk/epan/dissectors/dcerpc/idl2eth.c + M /trunk/epan/dissectors/make-reg-dotc + M /trunk/epan/dissectors/make-reg-dotc.py + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-app-pkix-cert.c + M /trunk/epan/dissectors/packet-armagetronad.c + M /trunk/epan/dissectors/packet-bacapp.h + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmip.h + M /trunk/epan/dissectors/packet-cmp.c + M /trunk/epan/dissectors/packet-cmp.h + M /trunk/epan/dissectors/packet-crmf.c + M /trunk/epan/dissectors/packet-crmf.h + M /trunk/epan/dissectors/packet-csm-encaps.c + M /trunk/epan/dissectors/packet-dcerpc-budb.h + M /trunk/epan/dissectors/packet-dcerpc-butc.h + M /trunk/epan/dissectors/packet-dcerpc-dssetup.h + M /trunk/epan/dissectors/packet-dec-dnart.c + M /trunk/epan/dissectors/packet-dua.c + M /trunk/epan/dissectors/packet-ess.c + M /trunk/epan/dissectors/packet-ess.h + M /trunk/epan/dissectors/packet-fr.h + M /trunk/epan/dissectors/packet-h248.h + M /trunk/epan/dissectors/packet-h248_package_bcp.c + M /trunk/epan/dissectors/packet-h248_package_bcp.h + M /trunk/epan/dissectors/packet-ifcp.c + M /trunk/epan/dissectors/packet-kerberos4.c + M /trunk/epan/dissectors/packet-logotypecertextn.c + M /trunk/epan/dissectors/packet-logotypecertextn.h + M /trunk/epan/dissectors/packet-mms.c + M /trunk/epan/dissectors/packet-mms.h + M /trunk/epan/dissectors/packet-mpls.h + M /trunk/epan/dissectors/packet-ms-mms.c + M /trunk/epan/dissectors/packet-netsync.c + M /trunk/epan/dissectors/packet-nettl.c + M /trunk/epan/dissectors/packet-ns_cert_exts.c + M /trunk/epan/dissectors/packet-pkcs1.c + M /trunk/epan/dissectors/packet-pkcs1.h + M /trunk/epan/dissectors/packet-pkinit.c + M /trunk/epan/dissectors/packet-pkinit.h + M /trunk/epan/dissectors/packet-pkix1implicit.c + M /trunk/epan/dissectors/packet-pkix1implicit.h + M /trunk/epan/dissectors/packet-pkixproxy.c + M /trunk/epan/dissectors/packet-pkixproxy.h + M /trunk/epan/dissectors/packet-pkixqualified.c + M /trunk/epan/dissectors/packet-pkixqualified.h + M /trunk/epan/dissectors/packet-pkixtsp.c + M /trunk/epan/dissectors/packet-pkixtsp.h + M /trunk/epan/dissectors/packet-synergy.c + M /trunk/epan/dissectors/packet-wlancertextn.c + M /trunk/epan/dissectors/packet-wlancertextn.h + M /trunk/epan/dissectors/packet-x509ce.c + M /trunk/epan/dissectors/packet-x509ce.h + M /trunk/epan/dissectors/packet-x509if.c + M /trunk/epan/dissectors/packet-x509if.h + M /trunk/epan/dissectors/packet-x509sat.c + M /trunk/epan/dissectors/packet-x509sat.h + M /trunk/epan/doxygen.cfg.in + M /trunk/epan/enterprise-numbers + M /trunk/epan/exceptions.h + M /trunk/epan/inet_aton.c + M /trunk/epan/sigcomp_state_hdlr.c + M /trunk/epan/sigcomp_state_hdlr.h + M /trunk/epan/xmlstub.h + M /trunk/gtk/STATUS.gtk2 + M /trunk/gtk/conversations_sctp.c + M /trunk/gtk/doxygen.cfg.in + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_chunk_stat_dlg.c + M /trunk/plugins/acn/AUTHORS + M /trunk/plugins/acn/COPYING + M /trunk/plugins/acn/INSTALL + M /trunk/plugins/acn/NEWS + M /trunk/plugins/acn/acn.h + M /trunk/plugins/acn/moduleinfo.h + M /trunk/plugins/artnet/AUTHORS + M /trunk/plugins/artnet/COPYING + M /trunk/plugins/artnet/INSTALL + M /trunk/plugins/artnet/NEWS + M /trunk/plugins/artnet/moduleinfo.h + M /trunk/plugins/asn1/AUTHORS + M /trunk/plugins/asn1/COPYING + M /trunk/plugins/asn1/ChangeLog + M /trunk/plugins/asn1/INSTALL + M /trunk/plugins/asn1/NEWS + M /trunk/plugins/asn1/moduleinfo.h + M /trunk/plugins/ciscosm/AUTHORS + M /trunk/plugins/ciscosm/COPYING + M /trunk/plugins/ciscosm/ChangeLog + M /trunk/plugins/ciscosm/INSTALL + M /trunk/plugins/ciscosm/NEWS + M /trunk/plugins/ciscosm/moduleinfo.h + M /trunk/plugins/docsis/AUTHORS + M /trunk/plugins/docsis/ChangeLog + M /trunk/plugins/docsis/INSTALL + M /trunk/plugins/docsis/NEWS + M /trunk/plugins/docsis/README + M /trunk/plugins/docsis/moduleinfo.h + M /trunk/plugins/enttec/AUTHORS + M /trunk/plugins/enttec/COPYING + M /trunk/plugins/enttec/INSTALL + M /trunk/plugins/enttec/NEWS + M /trunk/plugins/enttec/moduleinfo.h + M /trunk/plugins/giop/AUTHORS + M /trunk/plugins/giop/COPYING + M /trunk/plugins/giop/ChangeLog + M /trunk/plugins/giop/INSTALL + M /trunk/plugins/giop/NEWS + M /trunk/plugins/giop/README + M /trunk/plugins/giop/moduleinfo.h + M /trunk/plugins/giop/packet-coseventcomm.c + M /trunk/plugins/giop/packet-cosnaming.c + M /trunk/plugins/gryphon/AUTHORS + M /trunk/plugins/gryphon/COPYING + M /trunk/plugins/gryphon/ChangeLog + M /trunk/plugins/gryphon/INSTALL + M /trunk/plugins/gryphon/NEWS + M /trunk/plugins/gryphon/README + M /trunk/plugins/gryphon/moduleinfo.h + M /trunk/plugins/gryphon/stamp-h.in + M /trunk/plugins/irda/moduleinfo.h + M /trunk/plugins/irda/packet-sir.c + M /trunk/plugins/lwres/AUTHORS + M /trunk/plugins/lwres/moduleinfo.h + M /trunk/plugins/mate/AUTHORS + M /trunk/plugins/mate/COPYING + M /trunk/plugins/mate/INSTALL + M /trunk/plugins/mate/NEWS + M /trunk/plugins/mate/mate_grammar.lemon + M /trunk/plugins/mate/mate_parser.l + M /trunk/plugins/mate/moduleinfo.h + M /trunk/plugins/megaco/AUTHORS + M /trunk/plugins/megaco/COPYING + M /trunk/plugins/megaco/ChangeLog + M /trunk/plugins/megaco/INSTALL + M /trunk/plugins/megaco/NEWS + M /trunk/plugins/megaco/moduleinfo.h + M /trunk/plugins/mgcp/AUTHORS + M /trunk/plugins/mgcp/COPYING + M /trunk/plugins/mgcp/ChangeLog + M /trunk/plugins/mgcp/INSTALL + M /trunk/plugins/mgcp/NEWS + M /trunk/plugins/mgcp/moduleinfo.h + M /trunk/plugins/pcli/AUTHORS + M /trunk/plugins/pcli/COPYING + M /trunk/plugins/pcli/ChangeLog + M /trunk/plugins/pcli/INSTALL + M /trunk/plugins/pcli/NEWS + M /trunk/plugins/pcli/moduleinfo.h + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/plugins/profinet/packet-pn-dcp.c + M /trunk/plugins/rdm/AUTHORS + M /trunk/plugins/rdm/COPYING + M /trunk/plugins/rdm/moduleinfo.h + M /trunk/plugins/rlm/AUTHORS + M /trunk/plugins/rlm/COPYING + M /trunk/plugins/rlm/ChangeLog + M /trunk/plugins/rlm/INSTALL + M /trunk/plugins/rlm/NEWS + M /trunk/plugins/rlm/moduleinfo.h + M /trunk/plugins/rtnet/AUTHORS + M /trunk/plugins/rtnet/COPYING + M /trunk/plugins/rtnet/moduleinfo.h + M /trunk/plugins/rudp/AUTHORS + M /trunk/plugins/rudp/COPYING + M /trunk/plugins/rudp/ChangeLog + M /trunk/plugins/rudp/INSTALL + M /trunk/plugins/rudp/NEWS + M /trunk/plugins/rudp/moduleinfo.h + M /trunk/plugins/v5ua/AUTHORS + M /trunk/plugins/v5ua/COPYING + M /trunk/plugins/v5ua/ChangeLog + M /trunk/plugins/v5ua/moduleinfo.h + M /trunk/plugins/v5ua/packet-v5ua.c + M /trunk/plugins/xml/AUTHORS + M /trunk/plugins/xml/COPYING + + +Some warning fixes for "no previous declaration" +Remove svn:executable +Add svn:eol-style native +Add svn:keywords Id + -Reinsert Gerards patch (r14342) which was lost. ------------------------------------------------------------------------ -r14350 | etxrab | 2005-05-11 17:00:50 -0500 (Wed, 11 May 2005) | 2 lines +r15178 | jmayer | 2005-08-02 00:21:19 -0500 (Tue, 02 Aug 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/asn1/acse/Makefile + M /trunk/asn1/acse/Makefile.nmake + M /trunk/asn1/acse/acse-exp.cnf + M /trunk/asn1/acse/acse.asn + M /trunk/asn1/acse/acse.cnf + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/asn1/acse/packet-acse-template.h + M /trunk/asn1/camel/Makefile + M /trunk/asn1/camel/Makefile.nmake + M /trunk/asn1/camel/camel.asn + M /trunk/asn1/cmip/CMIP.asn + M /trunk/asn1/cmip/cmip.cnf + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/asn1/cmip/packet-cmip-template.h + M /trunk/asn1/cms/cms-exp.cnf + M /trunk/asn1/ess/ExtendedSecurityServices.asn + M /trunk/asn1/ess/ess.cnf + M /trunk/asn1/ess/packet-ess-template.c + M /trunk/asn1/ess/packet-ess-template.h + M /trunk/asn1/ftam/ISO8571-FTAM.asn + M /trunk/asn1/ftam/Makefile + M /trunk/asn1/ftam/Makefile.nmake + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/asn1/ftam/packet-ftam-template.h + M /trunk/asn1/gsmmap/gsm_map-exp.cnf + M /trunk/asn1/h225/h225-exp.cnf + M /trunk/asn1/h225/h225.asn + M /trunk/asn1/h235/h235-exp.cnf + M /trunk/asn1/h245/h245-exp.cnf + M /trunk/asn1/h245/h245.asn + M /trunk/asn1/h450/h4501.asn + M /trunk/asn1/inap/inap.asn + M /trunk/asn1/logotype-cert-extn/LogotypeCertExtn.asn + M /trunk/asn1/logotype-cert-extn/logotype-cert-extn.cnf + M /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.c + M /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.h + M /trunk/asn1/ocsp/OCSP.asn + M /trunk/asn1/ocsp/ocsp.cnf + M /trunk/asn1/ocsp/packet-ocsp-template.c + M /trunk/asn1/ocsp/packet-ocsp-template.h + M /trunk/asn1/pkixcmp/CMP.asn + M /trunk/asn1/pkixcmp/cmp-exp.cnf + M /trunk/asn1/pkixcmp/cmp.cnf + M /trunk/asn1/pkixcmp/packet-cmp-template.c + M /trunk/asn1/pkixcmp/packet-cmp-template.h + M /trunk/asn1/pkixcrmf/CRMF.asn + M /trunk/asn1/pkixcrmf/crmf-exp.cnf + M /trunk/asn1/pkixcrmf/crmf.cnf + M /trunk/asn1/pkixcrmf/packet-crmf-template.c + M /trunk/asn1/pkixcrmf/packet-crmf-template.h + M /trunk/asn1/pkixproxy/PKIXProxy.asn + M /trunk/asn1/pkixproxy/packet-pkixproxy-template.c + M /trunk/asn1/pkixproxy/packet-pkixproxy-template.h + M /trunk/asn1/pkixproxy/pkixproxy.cnf + M /trunk/asn1/pkixqualified/PKIXqualified.asn + M /trunk/asn1/pkixqualified/packet-pkixqualified-template.c + M /trunk/asn1/pkixqualified/packet-pkixqualified-template.h + M /trunk/asn1/pkixqualified/pkixqualified.cnf + M /trunk/asn1/pkixtsp/PKIXTSP.asn + M /trunk/asn1/pkixtsp/packet-pkixtsp-template.c + M /trunk/asn1/pkixtsp/packet-pkixtsp-template.h + M /trunk/asn1/pkixtsp/pkixtsp.cnf + M /trunk/asn1/smrse/SMRSE.asn + M /trunk/asn1/smrse/packet-smrse-template.c + M /trunk/asn1/smrse/packet-smrse-template.h + M /trunk/asn1/smrse/smrse.cnf + M /trunk/asn1/tcap/tcap.asn + M /trunk/asn1/wlancertextn/Makefile + M /trunk/asn1/wlancertextn/Makefile.nmake + M /trunk/asn1/wlancertextn/WLANCERTEXTN.asn + M /trunk/asn1/wlancertextn/packet-wlancertextn-template.c + M /trunk/asn1/wlancertextn/packet-wlancertextn-template.h + M /trunk/asn1/wlancertextn/wlancertextn.cnf + M /trunk/asn1/x509af/x509af-exp.cnf + M /trunk/asn1/x509ce/x509ce-exp.cnf + M /trunk/asn1/x509if/x509if-exp.cnf + M /trunk/asn1/x509sat/x509sat-exp.cnf + + +Fix svn properties where needed: + Remove svn:executable + Add svn:eol-style + Add svn:keywords -pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages. ------------------------------------------------------------------------ -r14349 | etxrab | 2005-05-11 16:59:44 -0500 (Wed, 11 May 2005) | 3 lines +r15177 | jmayer | 2005-08-02 00:17:00 -0500 (Tue, 02 Aug 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_sms.c - -From Viorel Suman: -Enable a proper deconding of an alphanumeric 7-bit encoded SMS TP-Originating-Address. + M /trunk/asn1/mms/Makefile + M /trunk/asn1/mms/Makefile.nmake + M /trunk/asn1/mms/mms-exp.cnf + M /trunk/asn1/mms/mms.asn + M /trunk/asn1/mms/mms.cnf + M /trunk/asn1/mms/packet-mms-template.c + M /trunk/asn1/mms/packet-mms-template.h +set svn:eol-style and svn:keywords ------------------------------------------------------------------------ -r14348 | etxrab | 2005-05-11 16:46:16 -0500 (Wed, 11 May 2005) | 1 line +r15176 | jmayer | 2005-08-02 00:12:23 -0500 (Tue, 02 Aug 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/asn1/MAP_Dialogue/MAP_DialoguePDU.asn + M /trunk/asn1/MAP_Dialogue/MAP_DialoguePDU.cnf + M /trunk/asn1/MAP_Dialogue/packet-MAP-DialoguePDU-template.c + M /trunk/asn1/MAP_Dialogue/packet-MAP-DialoguePDU-template.h -pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages. +It's svn:eol-style, not eol-style ------------------------------------------------------------------------ -r14347 | sahlberg | 2005-05-11 07:37:20 -0500 (Wed, 11 May 2005) | 2 lines +r15175 | jmayer | 2005-08-02 00:09:41 -0500 (Tue, 02 Aug 2005) | 3 lines Changed paths: - M /trunk/gtk/sctp_graph_dlg.c + M /trunk/asn1/MAP_Dialogue/MAP_DialoguePDU.asn + M /trunk/asn1/MAP_Dialogue/MAP_DialoguePDU.cnf + M /trunk/asn1/MAP_Dialogue/packet-MAP-DialoguePDU-template.c + M /trunk/epan/dissectors/packet-MAP_DialoguePDU.c -avoid a div-by-0 +Fix "no previous declaration" warnings +Remove trailing ^M (cr) from some files ------------------------------------------------------------------------ -r14346 | sahlberg | 2005-05-11 06:24:17 -0500 (Wed, 11 May 2005) | 4 lines +r15174 | jmayer | 2005-08-01 23:57:58 -0500 (Mon, 01 Aug 2005) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-juniper.c - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-h245.c -From Hannes Gredler -support for Juniper PPPOE encapsulation +Fix more "no previous declaration" warnings +------------------------------------------------------------------------ +r15173 | jmayer | 2005-08-01 23:47:15 -0500 (Mon, 01 Aug 2005) | 1 line +Changed paths: + M /trunk/gtk/capture_if_dlg.c + M /trunk/gtk/cfilter_combo_utils.c + M /trunk/gtk/color_dlg.c + M /trunk/gtk/decode_as_dlg.c + M /trunk/gtk/file_dlg.c + M /trunk/gtk/fileset_dlg.c + M /trunk/gtk/font_utils.c + M /trunk/gtk/graph_analysis.c + M /trunk/gtk/help_dlg.c + M /trunk/gtk/main.c + M /trunk/gtk/main.h + M /trunk/gtk/packet_history.c + M /trunk/gtk/packet_list.c +Fix more "no previous declaration" warnings +------------------------------------------------------------------------ +r15172 | jmayer | 2005-08-01 23:35:40 -0500 (Mon, 01 Aug 2005) | 1 line +Changed paths: + M /trunk/tools/lemon/lemon.c +Fix more "no previous declaration" warnings ------------------------------------------------------------------------ -r14345 | sahlberg | 2005-05-11 05:40:53 -0500 (Wed, 11 May 2005) | 17 lines +r15171 | jmayer | 2005-08-01 23:34:35 -0500 (Mon, 01 Aug 2005) | 1 line Changed paths: - M /trunk/doc/README.developer + M /trunk/epan/base64.c M /trunk/epan/conversation.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-tftp.c - M /trunk/epan/dissectors/packet-udp.c M /trunk/epan/packet.c - M /trunk/epan/packet.h - -Some applications do very naughty things like reusing a port for a different protocol during different stages of an application cycle. - -This is very naughty and will cause problems when we have assigned a dissector to a dynamic port using conversation_set_dissector(). + M /trunk/epan/prefs.c + M /trunk/epan/radius_dict.l + M /trunk/epan/sha1.c +Fix more "no previous declaration" warnings +------------------------------------------------------------------------ +r15170 | jmayer | 2005-08-01 23:32:33 -0500 (Mon, 01 Aug 2005) | 1 line +Changed paths: + M /trunk/asn1/pkcs1/packet-pkcs1-template.c + M /trunk/asn1/x509if/packet-x509if-template.c -To make ethereal handle this case I have changed the try_conversation_dissector() to allow it to fail and return 0, meaning yes there is indeed a protocol registered for this conversation but that protocol rejected this packet. -(which only happens for "new" style dissectors, "old" style dissectors will never reject a packet that way) +Fix more "no previous declaration" warnings - the forgotten files +------------------------------------------------------------------------ +r15169 | jmayer | 2005-08-01 23:31:42 -0500 (Mon, 01 Aug 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-dcerpc-atsvc.c + M /trunk/epan/dissectors/packet-dcerpc-nt.c + M /trunk/epan/dissectors/packet-ipmi.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-nlsp.c + M /trunk/epan/dissectors/packet-pcnfsd.c + M /trunk/epan/dissectors/packet-pflog.c + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-pkcs1.c + M /trunk/epan/dissectors/packet-q933.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-wbxml.c + M /trunk/epan/dissectors/packet-x509if.c -When this happens the decode_udp_port() helper will still allow other dissectors to be tried, in the hope that the conversation is now used for some other protocol and thus someone else might be able to decode the packet. +Fix more "no previous declaration" warnings +------------------------------------------------------------------------ +r15168 | jmayer | 2005-08-01 23:23:39 -0500 (Mon, 01 Aug 2005) | 4 lines +Changed paths: + M /trunk/wiretap/5views.c + M /trunk/wiretap/i4btrace.c + M /trunk/wiretap/k12.c +Include the .h files into the .c files. That way we +a) get rid of warnings of type "no previous declaration" and +b) make sure that declaration and implementation are in sync. -Update SNMP and TFTP dissectors to check that even if there already is a conversation but that conversation does NOT have snmp/tftp registered as the dissector for it, then create a new conversation anyway and attach the proper dissector. +------------------------------------------------------------------------ +r15167 | gerald | 2005-08-01 16:09:34 -0500 (Mon, 01 Aug 2005) | 3 lines +Changed paths: + M /trunk/epan/dfilter/Makefile.am + M /trunk/plugins/mate/Makefile.am -Since ethereal keeps track of which frame number a conversation started in, this actually works really well. +Make sure "lemon" exists before we try to use it. This can happen if we +run "make dist" before running "make". +------------------------------------------------------------------------ +r15166 | gerald | 2005-08-01 14:51:06 -0500 (Mon, 01 Aug 2005) | 3 lines +Changed paths: + M /trunk/Makefile.am +The .spec file now refers to "ethereal.desktop". Link to it when we +create our RPMs. ------------------------------------------------------------------------ -r14344 | gerald | 2005-05-10 18:45:39 -0500 (Tue, 10 May 2005) | 5 lines +r15165 | gerald | 2005-08-01 13:04:37 -0500 (Mon, 01 Aug 2005) | 2 lines Changed paths: - M /trunk/plugins/agentx/packet-agentx.c - -Don't write a '\0' way the heck past the end of an array. Fixes bug 164. + M /trunk/Makefile.am + M /trunk/packaging/rpm/SPECS/ethereal.spec.in -Add a comment asking if we shouldn't use oid_to_str() instead of our own -routine. +Update RPM builds. ------------------------------------------------------------------------ -r14343 | lego | 2005-05-10 16:54:37 -0500 (Tue, 10 May 2005) | 5 lines +r15164 | gerald | 2005-08-01 08:53:50 -0500 (Mon, 01 Aug 2005) | 2 lines Changed paths: - M /trunk/asn1/h248/packet-h248-template.c - M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-isup.c - M /trunk/epan/dissectors/packet-isup.h - -- export Audio Codec modes from isup/bicc -- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0) -- use it for H.248 + M /trunk/docbook/release-notes.xml +Add notes about the LPD and ISAKMP bugs. ------------------------------------------------------------------------ -r14342 | etxrab | 2005-05-10 15:09:09 -0500 (Tue, 10 May 2005) | 1 line +r15163 | gerald | 2005-08-01 08:52:22 -0500 (Mon, 01 Aug 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-isakmp.c + +Break out of a loop before we exhaust system memory. -Fix dissection of mo-forwardSM ------------------------------------------------------------------------ -r14341 | etxrab | 2005-05-10 15:06:04 -0500 (Tue, 10 May 2005) | 1 line +r15162 | kukosa | 2005-08-01 03:46:09 -0500 (Mon, 01 Aug 2005) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h245/h245.cnf + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h235.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h450.c -Fix dissection of mt-forwardSM. +- update ftam.cnf for new asn2eth compiler +- usage of #.FN_PARS in h225 and h245 dissectors +- PER dissectors regenerated ------------------------------------------------------------------------ -r14340 | etxrab | 2005-05-10 15:02:14 -0500 (Tue, 10 May 2005) | 1 line +r15161 | kukosa | 2005-08-01 03:40:13 -0500 (Mon, 01 Aug 2005) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/tools/asn2eth.py -fix some field rename errors turned up by the latest asn2eth compiler. +- fix name handling of imported types +- #.FN_PARS implemented for TypeRef, SET, SEQUENCE, CHOICE ------------------------------------------------------------------------ -r14339 | sahlberg | 2005-05-10 03:49:27 -0500 (Tue, 10 May 2005) | 2 lines +r15160 | etxrab | 2005-07-31 15:42:48 -0500 (Sun, 31 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-rtsp.c -make SNMP over UDP a new style dissector and add some heuristics to check if this is SNMP or not, +From Martin Mathieson +- Makes more of the header fields filterable +- Rationalises a bit the way header lines are parsed ------------------------------------------------------------------------ -r14338 | gerald | 2005-05-09 22:10:09 -0500 (Mon, 09 May 2005) | 2 lines +r15159 | etxrab | 2005-07-31 15:36:59 -0500 (Sun, 31 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-smb-pipe.c + M /trunk/epan/dissectors/packet-ms-mms.c -Make a field type check more strict. Remove some unnecessary code. +From Martin Mathieson: +This update: +- adds more command parameter details +- doesn't clutter the tree with unknown fields ------------------------------------------------------------------------ -r14337 | gerald | 2005-05-09 22:08:36 -0500 (Mon, 09 May 2005) | 4 lines +r15158 | jmayer | 2005-07-30 11:34:38 -0500 (Sat, 30 Jul 2005) | 4 lines Changed paths: + M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-icq.c + M /trunk/epan/dissectors/packet-ipp.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-isis-clv.h + M /trunk/epan/dissectors/packet-isis-lsp.c + M /trunk/epan/dissectors/packet-isis.c + M /trunk/epan/dissectors/packet-isis.h + M /trunk/epan/dissectors/packet-kink.c M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-manolito.c + M /trunk/epan/dissectors/packet-ms-mms.c + M /trunk/epan/dissectors/packet-msproxy.c + M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-multipart.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-ncp-int.h + M /trunk/epan/dissectors/packet-ncp.c + M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/dissectors/packet-netbios.c + M /trunk/epan/dissectors/packet-netbios.h -Make sure we don't feed a null string to strncmp(). Fixes bug 161. -Make sure we don't free static memory. Fix a small memory leak. +More char -> const char fixes +Declare some functions static ------------------------------------------------------------------------ -r14336 | jmayer | 2005-05-09 06:21:16 -0500 (Mon, 09 May 2005) | 5 lines +r15157 | jmayer | 2005-07-30 11:28:00 -0500 (Sat, 30 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-hpsw.c + M /trunk/epan/dissectors/packet-igmp.c + M /trunk/epan/dissectors/packet-igmp.h -I just found a packet with an option e. As the value looked very much -like the mac-address of the switch, I added decoding of option e as -mac address. +Include .h into .c to make sure declarations match. +Fix a copy/paste in the .h surrounding ifndef. +One char -> const char fix. ------------------------------------------------------------------------ -r14335 | lroland | 2005-05-08 20:21:41 -0500 (Sun, 08 May 2005) | 2 lines +r15156 | jmayer | 2005-07-30 11:15:23 -0500 (Sat, 30 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/proto.h + +Stefan Rompf: + Fix warnings of type: +proto.c:2219: warning: ISO C forbids conditional expr with only one void side + -Add another sanity check to the new SIP URI parser. -Just to be sure. ------------------------------------------------------------------------ -r14334 | lroland | 2005-05-08 20:15:45 -0500 (Sun, 08 May 2005) | 1 line +r15155 | jmayer | 2005-07-30 02:13:27 -0500 (Sat, 30 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-nfs.h + M /trunk/epan/dissectors/packet-nfsacl.c -Some fixes for the new SIP contact header parser. +More char -> const char warning fixes ------------------------------------------------------------------------ -r14333 | lroland | 2005-05-08 19:11:03 -0500 (Sun, 08 May 2005) | 5 lines +r15154 | jmayer | 2005-07-30 02:08:04 -0500 (Sat, 30 Jul 2005) | 3 lines Changed paths: - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-dcom-cba-acco.c + A /trunk/epan/dissectors/packet-dcom-cba-acco.h + -only lower-case ASCII letters, numbers, -underscores, and dots are allowed in the -preference name. +Create packet-dcom-cba-acco.h -Fix it the camel dissector. ------------------------------------------------------------------------ -r14332 | lroland | 2005-05-08 18:29:55 -0500 (Sun, 08 May 2005) | 1 line +r15153 | guy | 2005-07-29 21:44:20 -0500 (Fri, 29 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-dcom-cba-acco.c + +Make dissect_CBA_Connection_Data again available for plugins (although +it should be declared in a header file, so that the plugins can #include +the header file rather than using a possibly-out-of-date private +declaration, and so that it's clearer that it shouldn't be static). -Mark a function parameter as unused ------------------------------------------------------------------------ -r14331 | lroland | 2005-05-08 17:39:38 -0500 (Sun, 08 May 2005) | 3 lines +r15152 | jmayer | 2005-07-29 21:30:05 -0500 (Fri, 29 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/prefs.c -When saying that I remove the trailing white spaces I should do it, too. - -So I do it now and do some more reindentation, too. +Fix 'isn't prototype' warning ------------------------------------------------------------------------ -r14330 | lroland | 2005-05-08 17:19:18 -0500 (Sun, 08 May 2005) | 8 lines +r15151 | guy | 2005-07-29 21:22:22 -0500 (Fri, 29 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c - -Improve dissection of SIP contact header and counting of bindings in REGISTER messages. + M /trunk/epan/dissectors/packet-radius.c -Introduce a function for disseting a sip uri in general +Clean up some more const issues. -TODO: -- add dissection of contact and uri parameters -- simplify the ugly code for dissecting "to" and "from" headers - by using the new function for uri dissection ------------------------------------------------------------------------ -r14329 | lroland | 2005-05-08 16:17:37 -0500 (Sun, 08 May 2005) | 1 line +r15150 | guy | 2005-07-29 21:20:59 -0500 (Fri, 29 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-ieee80211.c + +Get rid of another unused variable. -Reindent dissect_sip_common() and remove trailing white spaces from packet-sip.c. ------------------------------------------------------------------------ -r14328 | etxrab | 2005-05-08 15:35:44 -0500 (Sun, 08 May 2005) | 3 lines +r15149 | guy | 2005-07-29 21:09:59 -0500 (Fri, 29 Jul 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-camel.h + M /trunk/epan/dissectors/packet-scsi.c + +Widen a variable, as a guint16 value is assigned to it; the upper 8 bits +might be irrelevant in this case, but we might as well not throw them +out. -From Javier Acuna: +Clean up some code that sets "cdata->flags". -Added some code to dissect DateAndTime. ------------------------------------------------------------------------ -r14327 | etxrab | 2005-05-08 15:34:57 -0500 (Sun, 08 May 2005) | 3 lines +r15148 | guy | 2005-07-29 21:07:36 -0500 (Fri, 29 Jul 2005) | 2 lines Changed paths: - M /trunk/asn1/camel/camel.asn - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/camel/packet-camel-template.h + M /trunk/epan/dissectors/packet-ieee80211.c -From Javier Acuna: +Get rid of some unused variables. -Added some code to dissect DateAndTime. ------------------------------------------------------------------------ -r14326 | ulfl | 2005-05-07 15:47:39 -0500 (Sat, 07 May 2005) | 1 line +r15147 | guy | 2005-07-29 21:06:13 -0500 (Fri, 29 Jul 2005) | 3 lines Changed paths: - M /trunk/Makefile.am - M /trunk/gtk/compat_macros.h - M /trunk/gtk/menu.c - M /trunk/gtk/toolbar.c - A /trunk/image/toolbar/file_set_list_16.xpm - A /trunk/image/toolbar/file_set_next_16.xpm - A /trunk/image/toolbar/file_set_previous_16.xpm + M /trunk/epan/dissectors/packet-lpd.c + +Declare the value_string tables as arrays of value_strings, not of +pointers to same, and make them "const" while we're at it. -add icons for the "File Set" menu items ------------------------------------------------------------------------ -r14325 | lroland | 2005-05-06 19:14:11 -0500 (Fri, 06 May 2005) | 3 lines +r15146 | jmayer | 2005-07-29 20:01:02 -0500 (Fri, 29 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-osi-options.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-dcom-cba-acco.c + M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-dis-fields.c + M /trunk/epan/dissectors/packet-dis.c + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-enc.c + M /trunk/epan/dissectors/packet-esis.c + M /trunk/epan/dissectors/packet-etheric.c + M /trunk/epan/dissectors/packet-fddi.c + M /trunk/epan/dissectors/packet-gnutella.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_sms.c + M /trunk/epan/dissectors/packet-gsm_ss.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-per.h + M /trunk/epan/dissectors/packet-radius.h + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtcp.h + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-rtp.h -Increase size of an integer to prevent an integer overflow +Make some funtions static. More char -> const char warning fixes +------------------------------------------------------------------------ +r15145 | jmayer | 2005-07-29 19:59:08 -0500 (Fri, 29 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/Makefile.common -Fixes Bug 162 +Remove packet-fcse.h ------------------------------------------------------------------------ -r14324 | sahlberg | 2005-05-06 05:11:08 -0500 (Fri, 06 May 2005) | 3 lines +r15144 | jmayer | 2005-07-29 19:55:30 -0500 (Fri, 29 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ypserv.c + M /trunk/epan/dissectors/packet-fcsp.c + D /trunk/epan/dissectors/packet-fcsp.h + -prettify YPSERV +Declare many functions static, move the #defines from packet-fcse.h to +packet-fcse.c and remove packet-fcse.h ------------------------------------------------------------------------ -r14323 | gram | 2005-05-05 21:08:30 -0500 (Thu, 05 May 2005) | 2 lines +r15143 | gerald | 2005-07-29 16:55:45 -0500 (Fri, 29 Jul 2005) | 13 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/config.h.win32 + M /trunk/configure.in + M /trunk/epan/dissectors/packet-lpd.c + M /trunk/epan/prefs.c + +Pick up some fixes and enhancements from +http://cvs.fedora.redhat.com/viewcvs/rpms/ethereal/FC-4/: + +In the LPD dissector, make lpd_client_code a value_string so that we +don't segfault. Do the same for lpd_server_code, although it's not +strictly necessary. + +Check to see if htmlview is installed, and use it as our HTML viewer. + +The Fedora RPM has other patches, but I'm not sure if they should +be applied. -A fix for the previous fix for the infinite loop in bootp, bug #160. ------------------------------------------------------------------------ -r14322 | gram | 2005-05-05 20:56:40 -0500 (Thu, 05 May 2005) | 5 lines +r15142 | sahlberg | 2005-07-29 05:00:37 -0500 (Fri, 29 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-sdp.c + +some more ememification of tvb_get_string() -Check the offset delta while we loop through the options. -Make sure the delta is > 0. -This intends to fix bug 160, although with a capture file -to test it, I can't be totally sure. ------------------------------------------------------------------------ -r14321 | jmayer | 2005-05-05 12:07:58 -0500 (Thu, 05 May 2005) | 1 line +r15141 | guy | 2005-07-29 02:35:43 -0500 (Fri, 29 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - M /trunk/epan/dissectors/packet-diameter-defs.h - M /trunk/epan/dissectors/packet-eapol.c - M /trunk/epan/dissectors/packet-ppp.c - M /trunk/epan/dissectors/packet-radius.c - M /trunk/epan/dissectors/packet-retix-bpdu.c - M /trunk/epan/dissectors/packet-sflow.c - M /trunk/epan/dissectors/packet-vlan.c + M /trunk/epan/dissectors/packet-http.c + +Suggest that perhaps displaying chunks in the chunked encoding with the +data dissector might be overkill, as it causes each of those chunks to +be dumped in hex in Tethereal output - along with whatever's done with +the data reassembled from those chunks. -Change 802.11f -> F, 802.1d -> D, 802.1x -> X, 802.1q -Q, 802.1P -> p ------------------------------------------------------------------------ -r14320 | ulfl | 2005-05-05 10:25:04 -0500 (Thu, 05 May 2005) | 1 line +r15140 | guy | 2005-07-29 02:28:07 -0500 (Fri, 29 Jul 2005) | 3 lines Changed paths: - M /trunk/packaging/nsis/Makefile.am + M /trunk/epan/dissectors/packet-radius.c + +Use "PROTO_ITEM_SET_GENERATED()" to mark generated items as such; it +takes care of the square brackets, etc.. -add GetWindowsVersion.nsh to the additional packaging files ------------------------------------------------------------------------ -r14319 | sahlberg | 2005-05-05 08:48:34 -0500 (Thu, 05 May 2005) | 3 lines +r15139 | guy | 2005-07-29 02:14:32 -0500 (Fri, 29 Jul 2005) | 9 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/reassemble.c -make tethereal compile when plugins are disabled +If we do reassembly and hand the packet to the dissector, and the +dissector says "sorry, I need even more data in this packet", don't flag +that packet as being reassembled in that frame. Indicate that we should +perhaps do all the "partial reassembly" stuff in +"fragment_set_partial_assembly()", which would obviate the need for the +hack in the TCP dissector. +Clean up indentation. ------------------------------------------------------------------------ -r14318 | guy | 2005-05-05 06:08:20 -0500 (Thu, 05 May 2005) | 2 lines +r15138 | guy | 2005-07-28 22:49:23 -0500 (Thu, 28 Jul 2005) | 3 lines Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rpc.h + M /trunk/tap-rpcstat.c -Fix a call to dereference a pointer (found by a compiler warning). +Constify some variables, functions, and structure members to squelch +compiler warnings. ------------------------------------------------------------------------ -r14317 | guy | 2005-05-05 06:07:22 -0500 (Thu, 05 May 2005) | 6 lines +r15137 | guy | 2005-07-28 22:48:03 -0500 (Thu, 28 Jul 2005) | 2 lines Changed paths: - M /trunk/gtk/voip_calls.c - -Don't explicitly initialize "h245_labels", as it's hard to initialize -all of it correctly, and as if you don't initialize all of it you get a -compiler warning. + M /trunk/epan/dissectors/packet-diameter.c -Add an assignment to squelch a compiler warning. +Constify some variables and arguments to squelch compiler warnings. ------------------------------------------------------------------------ -r14316 | guy | 2005-05-05 06:06:08 -0500 (Thu, 05 May 2005) | 2 lines +r15136 | guy | 2005-07-28 22:47:12 -0500 (Thu, 28 Jul 2005) | 2 lines Changed paths: - M /trunk/gtk/smb_stat.c + M /trunk/epan/dissectors/packet-jxta.c -Fix a test (bug found by a compiler warning). +Include <epan/emem.h> to declare ep_alloc(). ------------------------------------------------------------------------ -r14315 | guy | 2005-05-05 06:05:15 -0500 (Thu, 05 May 2005) | 5 lines +r15135 | guy | 2005-07-28 22:27:59 -0500 (Thu, 28 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-ber.c -Change some data types, and add initializations, to squelch compiler +Cast away some (otherwise unremovable, and harmless, in this case) warnings. -Fix indentation. - ------------------------------------------------------------------------ -r14314 | guy | 2005-05-05 06:03:46 -0500 (Thu, 05 May 2005) | 2 lines +r15134 | gerald | 2005-07-28 09:29:19 -0500 (Thu, 28 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c - M /trunk/epan/dissectors/packet-bacapp.h + M /trunk/docbook/Makefile + A /trunk/docbook/release-notes.xml -Change data types to match those of "iconv()", at least on OS X. +Add release notes. The content still needs to be filled in. ------------------------------------------------------------------------ -r14313 | guy | 2005-05-05 06:02:31 -0500 (Thu, 05 May 2005) | 2 lines +r15133 | sahlberg | 2005-07-28 05:05:37 -0500 (Thu, 28 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/dissectors/packet-sipfrag.c + M /trunk/epan/dissectors/packet-wsp.c + +more emeification of tvb_get_string() -Squelch a compiler warning. ------------------------------------------------------------------------ -r14312 | guy | 2005-05-05 05:00:29 -0500 (Thu, 05 May 2005) | 2 lines +r15132 | sahlberg | 2005-07-28 04:56:19 -0500 (Thu, 28 Jul 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/dissectors/packet-dcerpc-nt.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ms-mms.c + M /trunk/epan/dissectors/packet-multipart.c -Re-parenthesize an expression, to squelch a compiler warning. +ememify some more calls to tvb_get_string() ------------------------------------------------------------------------- -r14311 | guy | 2005-05-05 04:40:24 -0500 (Thu, 05 May 2005) | 3 lines -Changed paths: - M /trunk/epan/to_str.c - M /trunk/epan/to_str.h -"oid_to_str()" and "oid_to_str_buf()" don't modify what the "oid" -argument points to, so make it a "const" pointer. +this fixes an obvious memleak in ms-mms + ------------------------------------------------------------------------ -r14306 | gerald | 2005-05-04 12:02:56 -0500 (Wed, 04 May 2005) | 4 lines +r15131 | sahlberg | 2005-07-28 04:47:28 -0500 (Thu, 28 Jul 2005) | 3 lines Changed paths: + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-fcdns.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-image-gif.c M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-telnet.c + +some more memification of tvb_get_string() no obvious memleaks fixed this time :-( -Don't try to feed a null pointer to strncmp(). Fixes bug 158. -Shouldn't the number of fuzz bugs decrease asymptotically at some -point? ------------------------------------------------------------------------ -r14305 | gerald | 2005-05-04 11:40:30 -0500 (Wed, 04 May 2005) | 4 lines +r15130 | sahlberg | 2005-07-28 04:35:27 -0500 (Thu, 28 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-vnc.c + +ememify some more tvb_get_string() calls -From Lars Roland: +one memleak in vnc related to tvb_get_string() closed. -Make sure a hash table exists before trying to access it. Fixes bug 105. ------------------------------------------------------------------------ -r14304 | gerald | 2005-05-04 10:35:21 -0500 (Wed, 04 May 2005) | 6 lines +r15129 | sahlberg | 2005-07-28 04:20:56 -0500 (Thu, 28 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-tds.c -Don't roll our own buffer-overflow-able string_to_hex() routine -when there's a perfectly good tvb_bytes_to_str() lying around, just -_begging_ to be used. +ememify the tvb_get_string() and tvb_fake_unicode() calls in tds -Fix up white space. ------------------------------------------------------------------------ -r14303 | girlich | 2005-05-04 08:09:46 -0500 (Wed, 04 May 2005) | 2 lines +r15128 | sahlberg | 2005-07-28 03:55:11 -0500 (Thu, 28 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-rpc.h + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h + +add an ep version of tvb_fake_unicode() -Added RPC/ONC SYSTEM_ERROR accept state. ------------------------------------------------------------------------ -r14302 | etxrab | 2005-05-03 15:53:21 -0500 (Tue, 03 May 2005) | 1 line +r15127 | sahlberg | 2005-07-28 03:18:18 -0500 (Thu, 28 Jul 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-kerberos.c + +packet_ber has for some time been doing sanity checking of the BER Length fields +that they are not longer than the reported length of the tvb. + +this triggers some bugs since in packet-ber we are a bit too lax in setting reported_length of the tvb_new_subset() tvb. + +this cause short kerberos packets to not be decoded at all and the same for other short asn based packets as well. + + +fix some of these instances. + -Dissect GPRS user data. ------------------------------------------------------------------------ -r14301 | ulfl | 2005-05-03 14:58:05 -0500 (Tue, 03 May 2005) | 1 line +r15126 | jmayer | 2005-07-28 02:53:38 -0500 (Thu, 28 Jul 2005) | 1 line Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h + M /trunk/epan/dissectors/packet-beep.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ber.h + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-cups.c + M /trunk/epan/dissectors/packet-dcerpc-netlogon.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-llc.h + M /trunk/epan/dissectors/packet-rpc.h -add a *lot* more dissections of the various PN-IO blocks +char -> const char warning fixes ------------------------------------------------------------------------ -r14299 | gerald | 2005-05-03 14:33:02 -0500 (Tue, 03 May 2005) | 3 lines +r15125 | jmayer | 2005-07-28 02:51:52 -0500 (Thu, 28 Jul 2005) | 1 line Changed paths: - M /trunk/NEWS - M /trunk/epan/proto.c - -In proto_tree_set_string(), don't set a null fvalue or Ethereal will throw -a hissy fit. Fixes bug 157. + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_stat_dlg.c +Warning fixes ------------------------------------------------------------------------ -r14298 | gerald | 2005-05-03 13:43:06 -0500 (Tue, 03 May 2005) | 3 lines +r15124 | jmayer | 2005-07-28 02:50:31 -0500 (Thu, 28 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-pres.c + M /trunk/AUTHORS -Back out all of the tvb_ensure_bytes_exist() calls. They shouldn't be -neccessary any more, and were causing problems. +Updated Ankur Aggarwal's entry +------------------------------------------------------------------------ +r15123 | jmayer | 2005-07-28 02:49:55 -0500 (Thu, 28 Jul 2005) | 1 line +Changed paths: + M /trunk/oui.h + M /trunk/wka.tmpl +Add Extreme stuff ------------------------------------------------------------------------ -r14289 | gerald | 2005-05-03 09:36:08 -0500 (Tue, 03 May 2005) | 3 lines +r15122 | guy | 2005-07-27 13:38:35 -0500 (Wed, 27 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-dhcp-failover.c -Fix two places where we might loop infinitely, including the one found in -bug 155. Fix a couple of compiler warnings. +Squelch another qualifier warning. ------------------------------------------------------------------------ -r14288 | tuexen | 2005-05-03 03:34:11 -0500 (Tue, 03 May 2005) | 2 lines +r15121 | jmayer | 2005-07-27 13:15:07 -0500 (Wed, 27 Jul 2005) | 5 lines Changed paths: - M /trunk/gtk/sctp_stat.c + M /trunk/epan/radius_dict.l + -Base the assoc search on port/vtags only. +As Guy mentioned: last patch replaced one occurrence too many, +thus the dictionary keyword encrypt was changed from encrypt +to encrypted too. Undo this. ------------------------------------------------------------------------ -r14287 | etxrab | 2005-05-03 00:22:43 -0500 (Tue, 03 May 2005) | 7 lines +r15120 | jmayer | 2005-07-27 12:52:51 -0500 (Wed, 27 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-9p.c - -From Nils O. Sel?sdal: + M /trunk/epan/radius_dict.l -- Decodes all the remaining bitfields in 9P -- Tidies up display a bit (using more subtrees) -- Fixes a few fields that are better off displayed as decimal/octal. +The variable encrypt collides with the declaration in <unistd.h> on +some platforms. Rename encrypt to encrypted. ------------------------------------------------------------------------ -r14286 | gram | 2005-05-02 21:07:26 -0500 (Mon, 02 May 2005) | 2 lines +r15119 | gerald | 2005-07-27 11:25:44 -0500 (Wed, 27 Jul 2005) | 3 lines Changed paths: - M /trunk/tap-httpstat.c - M /trunk/tap-sipstat.c + M /trunk/epan/prefs.c -Fix typos in error messages. +Move preference initialization to its own routine and make sure it gets run +when we pass "-G defaultprefs" on the command line. ------------------------------------------------------------------------ -r14285 | ulfl | 2005-05-02 20:39:00 -0500 (Mon, 02 May 2005) | 1 line +r15118 | jmayer | 2005-07-27 11:05:41 -0500 (Wed, 27 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - D /trunk/epan/dissectors/packet-pn-dcp.c - M /trunk/plugins/profinet/Makefile.am - M /trunk/plugins/profinet/Makefile.nmake - A /trunk/plugins/profinet/packet-pn-dcp.c (from /trunk/epan/dissectors/packet-pn-dcp.c:14278) - M /trunk/plugins/profinet/profinet.c + M /trunk/epan/proto.h -move the pn-dcp dissector into the profinet plugin +Revert my previous patch - something else was seriously screwed up ------------------------------------------------------------------------ -r14284 | lroland | 2005-05-02 20:03:33 -0500 (Mon, 02 May 2005) | 11 lines +r15117 | jmayer | 2005-07-27 10:08:22 -0500 (Wed, 27 Jul 2005) | 6 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/doc/Makefile.nmake - M /trunk/plugins/Makefile.nmake + M /trunk/epan/proto.h -add the new target "install-plugins" to nmake makefile -in the plugins subdirectory. This target will copy all plugins to plugins/$(VERSION), thus (t)ethereal will -find and load the plugins when called from within the source tree. -call this target from the main nmake makefile after -installing other dependencies. call it from the nmake makefile -in the doc subdirectory before calling "tethereal -G". -This way "tethereal -G" will recognize the filterable -fields from the plugins, too. +gcc-4.0 (GCC) 4.0.2 20050720 (prerelease) (SUSE Linux) +fails when trying to use varargs. Due to a missing include +config.h we were using varargs with proto.h ------------------------------------------------------------------------ -r14283 | lroland | 2005-05-02 19:19:08 -0500 (Mon, 02 May 2005) | 2 lines +r15116 | jmayer | 2005-07-27 08:10:57 -0500 (Wed, 27 Jul 2005) | 5 lines Changed paths: - M /trunk/plugins/megaco/packet-megaco.c + M /trunk/epan/dissectors/packet-ieee80211.c + +The latest patch used the fields + hf_qos_buf_ac, hf_qos_buf_load and hf_qos_buf_state +but failed to add them to the hf_ array. Commented out their +use for now. -add another lenght check in the megaco dissector. -Fixes bug 150. ------------------------------------------------------------------------ -r14282 | tuexen | 2005-05-02 17:15:00 -0500 (Mon, 02 May 2005) | 2 lines +r15115 | jmayer | 2005-07-27 03:28:27 -0500 (Wed, 27 Jul 2005) | 4 lines Changed paths: - M /trunk/Makefile.am + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ieee80211.c + +Ankur Aggarwal: + IEEE 802.11 QoS decoding -Get profinet compiling on Unix. ------------------------------------------------------------------------ -r14280 | gerald | 2005-05-02 16:56:40 -0500 (Mon, 02 May 2005) | 27 lines +r15114 | jmayer | 2005-07-27 02:57:01 -0500 (Wed, 27 Jul 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-alcap.c + M /trunk/epan/dissectors/packet-ansi_637.c + M /trunk/epan/dissectors/packet-ansi_683.c + M /trunk/epan/dissectors/packet-ansi_801.c + M /trunk/epan/dissectors/packet-ansi_a.c + M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-arp.h -From Rich Coe: +Fix >2600 warnings by doing char -> const char changes. - - fix memory leak when Assoc packet is processed repeatedly in ethereal +Additionally in dissectors/packet-ansi_map.c: + Flag unused parameters as such and remove dummy + param = param; + statements. - - removed unused partial packet flag +------------------------------------------------------------------------ +r15113 | lego | 2005-07-26 20:32:31 -0500 (Tue, 26 Jul 2005) | 3 lines +Changed paths: + M /trunk/plugins/mgcp/packet-mgcp.c + +fix another leak of tap data + + +------------------------------------------------------------------------ +r15112 | guy | 2005-07-26 20:13:28 -0500 (Tue, 26 Jul 2005) | 2 lines +Changed paths: + M /trunk/gtk/flow_graph.c + +There aren't any clists here, and the clist arrows aren't used. - - added better support for DICOM VR - - sequences - - report actual VR in packet display, if supplied by xfer syntax - - show that we are not displaying entire tag string with '[...]', - some tags can hold up to 2^32-1 chars +------------------------------------------------------------------------ +r15111 | guy | 2005-07-26 20:12:44 -0500 (Tue, 26 Jul 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-ip.c - - remove my goofy attempt at trying to get access to the fragmented packets - (anyone have an idea on how to fix this ???) +Squelch another const warning. - - process all the data in the Assoc packet even if display is off +------------------------------------------------------------------------ +r15110 | guy | 2005-07-26 20:02:03 -0500 (Tue, 26 Jul 2005) | 8 lines +Changed paths: + M /trunk/epan/dissectors/packet-afp.c - - limit display of data in Assoc packet to defined size of the data even - if reported size is larger +*Removing* an include is usally not the right way of removing warnings; +if some function takes, for example, a "char *" as an argument, but +you're passing it an "unsigned char *", you don't squelch the warning by +removing the include of the header that declares that function (you then +get warnings about the function not being declared, at least with some +compilers), you put in a cast (if the signedness doesn't matter) or +arrange that you pass a "char *". - - show the last tag in a packet as [incomplete] if we don't have all the data +------------------------------------------------------------------------ +r15109 | lego | 2005-07-26 19:45:02 -0500 (Tue, 26 Jul 2005) | 3 lines +Changed paths: + M /trunk/epan/emem.c - - added framework for reporting DICOM async negotiation (not finished) - (I'm not aware of an implementation which currently supports this) +Remove two warnings - - still need to fix display of continuation packets ------------------------------------------------------------------------ |