diff options
| -rw-r--r-- | epan/dissectors/packet-ncp2222.inc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/epan/dissectors/packet-ncp2222.inc b/epan/dissectors/packet-ncp2222.inc index 0fa0d25d35..2dab4d0e87 100644 --- a/epan/dissectors/packet-ncp2222.inc +++ b/epan/dissectors/packet-ncp2222.inc @@ -2755,8 +2755,7 @@ build_expert_data(proto_tree *ncp_tree, const char *hf_name, char *buffer, case 18: case 19: case 20: /* string */ - /* XXX: Should we verify: buffer_size is as large as value returned by get_finfo_length(...) ??? */ - uni_to_string(get_finfo_value_string(PTREE_FINFO(tree_pointer)), get_finfo_length(PTREE_FINFO(tree_pointer)), buffer); + uni_to_string(get_finfo_value_string(PTREE_FINFO(tree_pointer)), MIN(get_finfo_length(PTREE_FINFO(tree_pointer)), buffer_size), buffer); if (repeat_lookup > 0) { if (strlen(temp_buffer) + strlen(buffer) < 250) { g_strlcat(temp_buffer, buffer, 256); |