path: root/wiretap
diff options
authorPeter Wu <peter@lekensteyn.nl>2016-02-20 16:02:54 +0100
committerPeter Wu <peter@lekensteyn.nl>2016-02-20 15:18:08 +0000
commit3b644a75c9530b8fc60e2fa964dfb2ae327e240d (patch)
tree4f4894c15139619ae2fdfc51de31bd660ec37f69 /wiretap
parent55b5b7caf3ec4856838b0416d5a91d3a3ff67ec8 (diff)
Fix various off-by-one in buffer sizes
Some only allow buffer overruns (read), others also buffer overflows (write). Found by looking for '\[ *N *\]' where N is 255, 0xff, 15 and 0xf (case insensitive). Change-Id: I250687e2fdeb8fbd5eaf0bbb8251c3dab9640760 Reviewed-on: https://code.wireshark.org/review/14034 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'wiretap')
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/catapult_dct2000.c b/wiretap/catapult_dct2000.c
index 8fb016f03e..a42bc52b1c 100644
--- a/wiretap/catapult_dct2000.c
+++ b/wiretap/catapult_dct2000.c
@@ -1494,7 +1494,7 @@ hex_from_char(gchar c)
/* Table allowing fast lookup from a pair of ascii hex characters to a guint8 */
-static guint8 s_tableValues[255][255];
+static guint8 s_tableValues[256][256];
/* Prepare table values so ready so don't need to check inside hex_byte_from_chars() */
static void prepare_hex_byte_from_chars_table(void)