diff options
| author | Evan Huus <eapache@gmail.com> | 2015-11-16 16:08:30 -0500 |
|---|---|---|
| committer | Evan Huus <eapache@gmail.com> | 2015-11-16 21:10:07 +0000 |
| commit | 0a0a811ea6124c8fa3a006032493eb44083848c4 (patch) | |
| tree | 61a8a828e715ec672d580a56f3ce3678c2bc155d /wiretap | |
| parent | 4224aab3453ab98c76d80bebae6301aa7c962fe3 (diff) | |
catapult: fix sscanf buffer overflow
Caught by cppcheck. The buffer is 9+1 characters, which means we should specify
9, not 10 to the scanf string since the count does not include the
null-terminator.
Change-Id: I0aae8cce337055b304efa9399cd5d8059928d2d8
Reviewed-on: https://code.wireshark.org/review/11887
Reviewed-by: Evan Huus <eapache@gmail.com>
Diffstat (limited to 'wiretap')
| -rw-r--r-- | wiretap/catapult_dct2000.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/catapult_dct2000.c b/wiretap/catapult_dct2000.c index f10dc65917..8fb016f03e 100644 --- a/wiretap/catapult_dct2000.c +++ b/wiretap/catapult_dct2000.c @@ -1579,7 +1579,7 @@ get_file_time_stamp(gchar *linebuff, time_t *secs, guint32 *usecs) /********************************************************/ /* Scan for all fields */ - scan_found = sscanf(linebuff, "%10s %2d, %4d %2d:%2d:%2d.%4u", + scan_found = sscanf(linebuff, "%9s %2d, %4d %2d:%2d:%2d.%4u", month, &day, &year, &hour, &minute, &second, usecs); if (scan_found != 7) { /* Give up if not all found */ |