diff options
| author | Guy Harris <guy@alum.mit.edu> | 2012-05-04 16:56:18 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2012-05-04 16:56:18 +0000 |
| commit | 33bb54a9452f4be53377a185195a63194016241a (patch) | |
| tree | 9308829e2105b6e51e0dc5cc0af2295d8d97a0a3 /wiretap/vms.c | |
| parent | f65cb5f27bab6310e847f88cd763eb08bff1c93b (diff) | |
file_seek() used to be a wrapper around fseek() or gzseek(), both of
which could use lseek() and were thus expensive due to system call
overhead. To avoid making a system call for every packet on a
sequential read, we maintained a data_offset field in the wtap structure
for sequential reads.
It's now a routine that just returns information from the FILE_T data
structure, so it's cheap. Use it, rather than maintaining the data_offset
field.
Readers for some file formats need to maintain file offset themselves;
have them do so in their private data structures.
svn path=/trunk/; revision=42423
Diffstat (limited to 'wiretap/vms.c')
| -rw-r--r-- | wiretap/vms.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/wiretap/vms.c b/wiretap/vms.c index 2b02dbf0d0..8173e576cf 100644 --- a/wiretap/vms.c +++ b/wiretap/vms.c @@ -265,7 +265,6 @@ int vms_open(wtap *wth, int *err, gchar **err_info) return -1; } - wth->data_offset = 0; wth->file_encap = WTAP_ENCAP_RAW_IP; wth->file_type = WTAP_FILE_VMS; wth->snapshot_length = 0; /* not known */ @@ -308,7 +307,6 @@ static gboolean vms_read(wtap *wth, int *err, gchar **err_info, if (!parse_vms_hex_dump(wth->fh, pkt_len, buf, err, err_info)) return FALSE; - wth->data_offset = offset; *data_offset = offset; return TRUE; } |