diff options
| author | Guy Harris <guy@alum.mit.edu> | 2017-07-18 04:27:53 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2017-07-18 04:28:20 +0000 |
| commit | 5fd255424fda27b1ca9ded48a83da31405ae1731 (patch) | |
| tree | 2bbd3679421455d6b4821e70523b8f56e316d7c5 /wiretap/erf.c | |
| parent | e934fad6389da228ae33e5fb83c29807a315ee77 (diff) | |
Revert "Don't byte-swap an 1-byte value."
This reverts commit 74a2ae4abac3be78d140d9671fa79977de449ed1.
No, that's just Coverity not understanding macros *again*, and thinking a particular expanded instance of a macro is the result of some human being silly rather than of the arguments being such that some computations can be elided at compile time.
Change-Id: I40f2ad8bf018b0df02d90ed0e272505be68dae7e
Reviewed-on: https://code.wireshark.org/review/22693
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'wiretap/erf.c')
| -rw-r--r-- | wiretap/erf.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/wiretap/erf.c b/wiretap/erf.c index a05a6c533c..6e5f8546cf 100644 --- a/wiretap/erf.c +++ b/wiretap/erf.c @@ -1065,7 +1065,6 @@ static void erf_write_wtap_option_to_interface_tag(wtap_block_t block _U_, struct erf_meta_section *section_ptr = (struct erf_meta_section*) user_data; struct erf_meta_tag *tag_ptr = NULL; - guint32 fcslen; tag_ptr = (struct erf_meta_tag*) g_malloc0(sizeof(struct erf_meta_tag)); @@ -1131,8 +1130,7 @@ static void erf_write_wtap_option_to_interface_tag(wtap_block_t block _U_, tag_ptr->type = ERF_META_TAG_fcs_len; tag_ptr->length = 4; tag_ptr->value = (guint8*)g_malloc(tag_ptr->length); - fcslen = (guint32)optval->uint8val; - phtonl(tag_ptr->value, fcslen); + phtonl(tag_ptr->value, (guint32)optval->uint8val); break; /* TODO: Don't know what to do with these yet */ case OPT_IDB_EUIADDR: |