path: root/ui/voip_calls.h
diff options
authorGerald Combs <gerald@wireshark.org>2014-12-12 16:51:40 -0800
committerGerald Combs <gerald@wireshark.org>2015-10-02 18:26:05 +0000
commit3687d393040a40655d84e3e03417a474032bad86 (patch)
tree55f208b60abb59c5812bae2407a9b36dfdd2f09a /ui/voip_calls.h
parentfd5eafa50a77bc319a240727600be38307e54f86 (diff)
Qt: Initial RTP playback.
Note the "initial". This is woefully incomplete. See the "to do" lists below and in the code. This differs a bit from the GTK+ version in that you specify one or more streams to be decoded. Instead of showing waveforms in individual widgets, add them all to a single QCustomPlot. This conserves screen real estate and lets us more easily take advantage of the QCP API. It also looks better IMHO. Change a bunch of checks for QtMultimediaWidgets to QtMultimedia. We probably won't use the widgets until we make 5.0 our minimum Qt version and plain old QtMultimedia lets us support Qt 4 more easily (in theory at least). Add resampling code from libspeex. I initially used this to resample each packet to match the preferred rate of our output device, but this resulted in poorer audio quality than expected. Leave it in and use to create visual samples for QCP and to match rates any time the rate changes. The latter is currently untested. Add some debugging macros. Note that both the RTP player and RTP analysis dialogs decode audio data using different code. Note that voip_calls_packet and voip_calls_init_tap appear to be dead code. To do: - Add silence frames where needed. - Implement the jitter buffer. - Implement the playback timing controls. - Tapping / scanning streams might be too slow. Change-Id: I20dd3b66d3df53c9b1f3501262dc01458849f6b4 Bug: 9007 Reviewed-on: https://code.wireshark.org/review/10458 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/voip_calls.h')
1 files changed, 17 insertions, 3 deletions
diff --git a/ui/voip_calls.h b/ui/voip_calls.h
index 6378f300cc..170042a454 100644
--- a/ui/voip_calls.h
+++ b/ui/voip_calls.h
@@ -189,8 +189,8 @@ typedef struct _voip_calls_tapinfo {
tap_draw_cb tap_draw; /**< tap draw callback */
void *tap_data; /**< data for tap callbacks */
int ncalls; /**< number of call */
- GQueue* callsinfos; /**< queue with all calls */
- GHashTable* callsinfo_hashtable[1]; /**< array of hashes per voip protocol; currently only the one for SIP is used */
+ GQueue* callsinfos; /**< queue with all calls (voip_calls_info_t) */
+ GHashTable* callsinfo_hashtable[1]; /**< array of hashes per voip protocol (voip_calls_info_t); currently only the one for SIP is used */
int npackets; /**< total number of packets of all calls */
voip_calls_info_t *filter_calls_fwd; /**< used as filter in some tap modes */
int start_packets;
@@ -227,6 +227,21 @@ typedef struct _voip_calls_tapinfo {
gboolean redraw;
} voip_calls_tapinfo_t;
+#if 0
+#ifdef _MSC_VER
+#define _ws_func_ __FUNCTION__
+#define _ws_func_ __func__
+#define VOIP_CALLS_DEBUG(...) { \
+ char *VOIP_CALLS_DEBUG_MSG = g_strdup_printf(__VA_ARGS__); \
+ g_warning("voip_calls: %s:%d %s", _ws_func_, __LINE__, VOIP_CALLS_DEBUG_MSG); \
@@ -268,4 +283,3 @@ void voip_calls_reset_all_taps(voip_calls_tapinfo_t *tapinfo);
* ex: set shiftwidth=4 tabstop=8 expandtab:
* :indentSize=4:tabSize=8:noTabs=true: