diff options
| author | Kevin Hogan <kwabena@google.com> | 2017-01-20 20:57:09 -0800 |
|---|---|---|
| committer | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2017-01-22 14:41:49 +0000 |
| commit | 799827b503a61d1b7c0306f2c987e42e7280b0a3 (patch) | |
| tree | ec107f1f6a3855b3f3fd71c5aace3a3de08744c2 /ui/tap-tcp-stream.h | |
| parent | 21a3b8cc71ac127e21375c62e0a738db8f3ea286 (diff) | |
Qt: Add Goodput graph (ACK rate), and minor bug fixes
Add Goodput graph:
- measures rate of ACKed bytes (including SACKed bytes)
- useful to compare to throughput during slow-start to estimate
bottleneck rate
Add graph selection checkboxes to multi-plot graphs:
- most important for Throughput, since there are good cases
for showing a subset of graphs at once
- also added for Window Scale, since the addition is similar
to that for Throughput
Minor bug fixes:
- allow zoom rect to work when growing in any direction
(not just right and up)
- keep stray mouse clicks from re-doing a previous zoom
- hide rubber band if active when keypress changes mouse mode
to drag
- allow mouse clicks on open space or grpah to return to default focus
(i.e. focus on graph)
Change-Id: Id29356ceec810ebdbed9c3c0d8415416401fe643
Reviewed-on: https://code.wireshark.org/review/19718
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Diffstat (limited to 'ui/tap-tcp-stream.h')
| -rw-r--r-- | ui/tap-tcp-stream.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/ui/tap-tcp-stream.h b/ui/tap-tcp-stream.h index 5a2e3ec71b..452f20d1ea 100644 --- a/ui/tap-tcp-stream.h +++ b/ui/tap-tcp-stream.h @@ -128,7 +128,11 @@ tcp_seq_eq_or_after(guint32 s1, guint32 s2) { static inline int tcp_seq_after(guint32 s1, guint32 s2) { - return (s1 != s2) && !tcp_seq_before(s1, s2); + return (gint32)(s1 - s2) > 0; +} + +static inline int tcp_seq_before_or_eq(guint32 s1, guint32 s2) { + return !tcp_seq_after(s1, s2); } #ifdef __cplusplus |