diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-12-29 00:00:59 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-12-29 08:01:54 +0000 |
| commit | ddd217469de7032a3509369b3ca7dfca55374c2e (patch) | |
| tree | 781bd60b0289cd9d0c8cabfacecbe0eb8df7c76e /ui/tap-rlc-graph.h | |
| parent | 98456ce10f92dcb58c65ca0506c143d5e767ddd1 (diff) | |
Always supply a g_mallocated error message from select_rlc_lte_session().
That way, we don't have to pass a "free this" indication separately.
While we're at it, don't just free the error message, *display* it in
all cases where rlc_graph_segment_list_get() fails.
(I wish more programming languages had a proper string type, including
some whose names consist solely of the third letter of the alphabet, but
I digress....)
Change-Id: I99f8b088aa19bc8fbb178bdb36d85ba5b89c06e0
Reviewed-on: https://code.wireshark.org/review/12902
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'ui/tap-rlc-graph.h')
| -rw-r--r-- | ui/tap-rlc-graph.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ui/tap-rlc-graph.h b/ui/tap-rlc-graph.h index 748471d1c9..679b89717e 100644 --- a/ui/tap-rlc-graph.h +++ b/ui/tap-rlc-graph.h @@ -83,7 +83,7 @@ struct rlc_graph { }; gboolean rlc_graph_segment_list_get(capture_file *cf, struct rlc_graph *tg, gboolean stream_known, - char **err_string, gboolean *free_err_string); + char **err_string); void rlc_graph_segment_list_free(struct rlc_graph * ); @@ -92,7 +92,7 @@ int compare_rlc_headers(guint16 ueid1, guint16 channelType1, guint16 channelId1, guint16 ueid2, guint16 channelType2, guint16 channelId2, guint8 rlcMode2, guint8 direction2, gboolean isControlFrame); rlc_lte_tap_info *select_rlc_lte_session(capture_file *cf, struct rlc_segment *hdrs, - gchar **err_msg, gboolean *free_err_msg); + gchar **err_msg); int rlc_lte_tap_for_graph_data(void *pct, packet_info *pinfo _U_, epan_dissect_t *edt _U_, const void *vip); |