aboutsummaryrefslogtreecommitdiffstats
path: root/ui/software_update.c
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2016-12-08 09:41:47 -0800
committerGerald Combs <gerald@wireshark.org>2016-12-13 01:52:16 +0000
commitdd816a121829f8129dc70b70c25d83eed08e279a (patch)
treed8ac9ee62d6fd7fd407eda610a7a07e936a3cb90 /ui/software_update.c
parentce54bfe055a8f1f674f0fe19fa0236e89744cddd (diff)
Update to WinSparkle 0.5.3.
Update our WinSparkle package to 0.5.3. This fixes a file deletion bug. Note that WinSparkle now supports application shutdown callbacks, which should let us fix bugs 9687 and 12989. Bug: 13217 Change-Id: I4b5f325c6dc251ce167f7bd344bbf3ca5ad3fe14 Reviewed-on: https://code.wireshark.org/review/19230 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/software_update.c')
-rw-r--r--ui/software_update.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/ui/software_update.c b/ui/software_update.c
index ffe2b2e712..a33dbd5b47 100644
--- a/ui/software_update.c
+++ b/ui/software_update.c
@@ -94,10 +94,19 @@ void
software_update_init(void) {
const char *update_url = get_appcast_update_url(prefs.gui_update_channel);
+ /*
+ * According to the WinSparkle 0.5 documentation these must be called
+ * once, before win_sparkle_init. We can't update them dynamically when
+ * our preferences change.
+ */
win_sparkle_set_registry_path("Software\\Wireshark\\WinSparkle Settings");
win_sparkle_set_appcast_url(update_url);
win_sparkle_set_automatic_check_for_updates(prefs.gui_update_enabled ? 1 : 0);
win_sparkle_set_update_check_interval(prefs.gui_update_interval);
+ /* Todo: Fix bugs 9687 and 12989.
+ * win_sparkle_set_can_shutdown_callback(...);
+ * win_sparkle_set_shutdown_request_callback(...);
+ */
win_sparkle_init();
}