diff options
| author | Stig Bjørlykke <stig@bjorlykke.org> | 2016-12-28 10:55:32 +0100 |
|---|---|---|
| committer | Stig Bjørlykke <stig@bjorlykke.org> | 2016-12-28 12:09:26 +0000 |
| commit | f3df81bf590a1c020155a485d77a2ab506270959 (patch) | |
| tree | cf8e08d5ed4bd9c1ea6fb38c9c047f9aece1dea3 /ui/qt | |
| parent | 40c618eac5034ebf53da664dfe5cea9b319a0f68 (diff) | |
Qt: Fix open extcap help URL.
The return value from QString::compare() is equal to zero when the
strings are equal. Fix the code for checking and opening the extcap
help URL if not matching "file".
This bug was introduced in g46caff30.
Ping-Bug: 13218
Change-Id: I2a84e61f0191b57269f8ce829ff82200bf19a7ac
Reviewed-on: https://code.wireshark.org/review/19442
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Diffstat (limited to 'ui/qt')
| -rw-r--r-- | ui/qt/extcap_options_dialog.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/ui/qt/extcap_options_dialog.cpp b/ui/qt/extcap_options_dialog.cpp index 7dcf618c00..2a47a6527c 100644 --- a/ui/qt/extcap_options_dialog.cpp +++ b/ui/qt/extcap_options_dialog.cpp @@ -329,8 +329,10 @@ void ExtcapOptionsDialog::on_buttonBox_helpRequested() QUrl help_url(interface_help); /* The help is not a local file, open it and exit */ - if (! help_url.scheme().compare("file")) + if (help_url.scheme().compare("file") != 0) { QDesktopServices::openUrl(help_url); + return; + } /* The help information is a file url and has been provided as-is by the extcap. Before attempting to open the it, check if it actually exists. |