aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt
diff options
context:
space:
mode:
authorMartin Kaiser <wireshark@kaiser.cx>2017-09-19 23:13:34 +0200
committerMichael Mann <mmann78@netscape.net>2017-09-19 23:30:41 +0000
commit70263eade4cadd157f0322d6df3dd79bfec26242 (patch)
treeda771e4bebbbc71a6eb99b0fdfb32de565e7c5c4 /ui/qt
parent253fcfa22182e123d4adfb54c2610e579f54a6db (diff)
Qt: main window slots: don't connect setCaptureFile to DecodeAsDialog
The refactored DecodeAsDialog class has no setCaptureFile slot any more. It seems it's always in the foreground and there's no way to change the capture file while the DecodeAsDialog is active. The dangling connection caused a warning QObject::connect: No such slot DecodeAsDialog::setCaptureFile(capture_file*) in ../ui/qt/main_window_slots.cpp:2881 QObject::connect: (sender name: 'MainWindow') QObject::connect: (receiver name: 'DecodeAsDialog') Change-Id: Ibb12b9cdded3c6b7cca40ce08874bc4f1af4eec7 Reviewed-on: https://code.wireshark.org/review/23623 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'ui/qt')
-rw-r--r--ui/qt/main_window_slots.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/ui/qt/main_window_slots.cpp b/ui/qt/main_window_slots.cpp
index 0f64ea9120..8e15e832eb 100644
--- a/ui/qt/main_window_slots.cpp
+++ b/ui/qt/main_window_slots.cpp
@@ -2877,8 +2877,6 @@ void MainWindow::on_actionAnalyzeDecodeAs_triggered()
}
DecodeAsDialog da_dialog(this, capture_file_.capFile(), create_new);
- connect(this, SIGNAL(setCaptureFile(capture_file*)),
- &da_dialog, SLOT(setCaptureFile(capture_file*)));
da_dialog.exec();
// Emitting PacketDissectionChanged directly from a QDialog can cause