diff options
| author | Dario Lombardo <lomato@gmail.com> | 2018-01-16 14:40:06 +0100 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2018-01-18 15:48:30 +0000 |
| commit | c5560babbd2656f49b5dc8a32f6c2ea67a276d57 (patch) | |
| tree | a662e7ed98a98716d9dd717203b377071f483877 /ui/qt/packet_dialog.cpp | |
| parent | dcacea5c1542611bbd8ca3a403f9099508aef67f (diff) | |
Qt: return if cf_read_record() fails in PacketDialog (found by clang).
Change-Id: I5187b378db9bae092052ce50b337f266e08e4332
Reviewed-on: https://code.wireshark.org/review/25340
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'ui/qt/packet_dialog.cpp')
| -rw-r--r-- | ui/qt/packet_dialog.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ui/qt/packet_dialog.cpp b/ui/qt/packet_dialog.cpp index c8a8dfb4ca..67a75f6c4a 100644 --- a/ui/qt/packet_dialog.cpp +++ b/ui/qt/packet_dialog.cpp @@ -41,7 +41,10 @@ PacketDialog::PacketDialog(QWidget &parent, CaptureFile &cf, frame_data *fdata) setWindowSubtitle(tr("Packet %1").arg(fdata->num)); - if (!cf_read_record(cap_file_.capFile(), fdata)) reject(); + if (!cf_read_record(cap_file_.capFile(), fdata)) { + reject(); + return; + } phdr_ = cap_file_.capFile()->phdr; packet_data_ = (guint8 *) g_memdup(ws_buffer_start_ptr(&(cap_file_.capFile()->buf)), fdata->cap_len); |