diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2018-01-23 17:56:42 +0100 |
|---|---|---|
| committer | Roland Knall <rknall@gmail.com> | 2018-02-14 08:03:10 +0000 |
| commit | 9198448f9db7b77af8d19f8265d6785fb005dc58 (patch) | |
| tree | 8ec8f7bfff3f106cff9987807bff644fe4aad949 /ui/qt/packet_dialog.cpp | |
| parent | f0db412f57effe6234edc78e1f438b735efae805 (diff) | |
Qt: fix crash in packet dialog on changing selection
"((capture_file_t *)cap_file_)->edt" is documented in cfile.h to cover
the currently selected packet (in the packet list). But in the packet
dialog, the packet selection is irrelevant and the data from a different
dissection tree must be used.
Change-Id: Ieaea3cf862d47540e7f6b6c84c1a2fa6945a877b
Fixes: v2.5.0rc0-1532-g56a130a152 ("ByteViewText: Remove epan dependancy")
Bug: 14246
Reviewed-on: https://code.wireshark.org/review/25437
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Diffstat (limited to 'ui/qt/packet_dialog.cpp')
| -rw-r--r-- | ui/qt/packet_dialog.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/qt/packet_dialog.cpp b/ui/qt/packet_dialog.cpp index f94a5ba2e9..0a6bc1d59e 100644 --- a/ui/qt/packet_dialog.cpp +++ b/ui/qt/packet_dialog.cpp @@ -69,7 +69,7 @@ PacketDialog::PacketDialog(QWidget &parent, CaptureFile &cf, frame_data *fdata) proto_tree_ = new ProtoTree(ui->packetSplitter); proto_tree_->setRootNode(edt_.tree); - byte_view_tab_ = new ByteViewTab(ui->packetSplitter); + byte_view_tab_ = new ByteViewTab(ui->packetSplitter, &edt_); byte_view_tab_->setCaptureFile(cap_file_.capFile()); byte_view_tab_->selectedFrameChanged(0); |