diff options
| author | Michael Mann <mmann78@netscape.net> | 2017-07-23 10:53:43 -0400 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-08-07 17:25:02 +0000 |
| commit | 5b3e3ee58748ac1fd9201d2d3facbed1b9b1e800 (patch) | |
| tree | 9b19a5d0f8abb396dd6063fa887892581e286b8a /ui/gtk | |
| parent | f63b0241c9eeb1ef3dc1e915820c440119c30526 (diff) | |
Use UAT model for I/O graph
Convert from using TreeWidgetItems to UAT model/delegate. More of the GUI
is "just handled" within the table.
Required to add support for "colors" and "protocol fields" to UAT types.
Also needed to add some hacks for "custom" UAT field handlers for
backwards compatibility with the existing UAT structure used.
Because UAT functionality was switched completely to the model, some
information in the table was "lost in translation" because the UATs
themselves aren't translated to other languages.
TODO:
2. Better "order of operations"? A bunch of NULL/size checks needed to be added to prevent crashing.
Now with model/"view" should events/functions be reordered?
Bug: 13585
Change-Id: I2bbba78182317c4fada07b927c05d0c6f4cdc0fe
Reviewed-on: https://code.wireshark.org/review/22766
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/gtk')
| -rw-r--r-- | ui/gtk/uat_gui.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ui/gtk/uat_gui.c b/ui/gtk/uat_gui.c index d63a153ea8..d18e840d62 100644 --- a/ui/gtk/uat_gui.c +++ b/ui/gtk/uat_gui.c @@ -294,6 +294,7 @@ static gboolean uat_dlg_cb(GtkWidget *win _U_, gpointer user_data) { case PT_TXTMOD_STRING: case PT_TXTMOD_BOOL: case PT_TXTMOD_DISPLAY_FILTER: + case PT_TXTMOD_PROTO_FIELD: text = gtk_entry_get_text(GTK_ENTRY(e)); len = (unsigned) strlen(text); break; @@ -518,6 +519,7 @@ static void uat_edit_dialog(uat_t *uat, gint row, gboolean copy) { case PT_TXTMOD_STRING: case PT_TXTMOD_HEXBYTES: case PT_TXTMOD_DISPLAY_FILTER: + case PT_TXTMOD_PROTO_FIELD: case PT_TXTMOD_BOOL: entry = gtk_entry_new(); if (! dd->is_new || copy) { |