diff options
| author | Gerald Combs <gerald@wireshark.org> | 2016-09-26 10:34:04 -0700 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2016-09-26 23:17:02 +0000 |
| commit | b725d6c9acc403dba30c72d20cf7103e4f490334 (patch) | |
| tree | 90a8b5d226630b8ed14fb9d5a1a50104a254bf6a /tools | |
| parent | 06352a27b1ad2f9197b6193f97fad0c6947cc6d6 (diff) | |
Add an initial "shellcheck" target.
Look for shellcheck in Autotools and CMake, and if found add a target
that checks some of our shell scripts.
Add a "source=" directive to targets that include test-common.sh so
that shellcheck will correctly process the scripts. Note that this
requires shellcheck 0.4.0 or later.
To do: Fix the issues that shellcheck found and check more scripts.
Change-Id: I441f9f59d8a3f8eec6718119c2370f2560b98f3c
Reviewed-on: https://code.wireshark.org/review/17943
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/fuzz-test.sh | 1 | ||||
| -rwxr-xr-x | tools/randpkt-test.sh | 1 | ||||
| -rwxr-xr-x | tools/test-captures.sh | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/tools/fuzz-test.sh b/tools/fuzz-test.sh index 7c6c7b7d02..ab6158e2ea 100755 --- a/tools/fuzz-test.sh +++ b/tools/fuzz-test.sh @@ -28,6 +28,7 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. TEST_TYPE="fuzz" +# shellcheck source=tools/test-common.sh . `dirname $0`/test-common.sh || exit 1 # Sanity check to make sure we can find our plugins. Zero or less disables. diff --git a/tools/randpkt-test.sh b/tools/randpkt-test.sh index 60a3b32f34..24e7c55858 100755 --- a/tools/randpkt-test.sh +++ b/tools/randpkt-test.sh @@ -7,6 +7,7 @@ # The files are processed repeatedly until an error is found. TEST_TYPE="randpkt" +# shellcheck source=tools/test-common.sh . `dirname $0`/test-common.sh || exit 1 # Run under AddressSanitizer ? diff --git a/tools/test-captures.sh b/tools/test-captures.sh index 6cbb208665..481e6c2cd9 100755 --- a/tools/test-captures.sh +++ b/tools/test-captures.sh @@ -28,6 +28,7 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. TEST_TYPE="manual" +# shellcheck source=tools/test-common.sh . `dirname $0`/test-common.sh || exit 1 # Run under AddressSanitizer ? |