diff options
| author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2019-01-30 23:56:54 +0000 |
|---|---|---|
| committer | João Valverde <j@v6e.pt> | 2019-07-21 15:54:41 +0000 |
| commit | 6e5ba74b31e5053c0ba0f3eaa79ff97d03eb5595 (patch) | |
| tree | f1dcb909bf5fd4a5154af20d58b559e39c0d4eee /tools | |
| parent | cdac470a60a0fd4ac871072f732a13038e691e73 (diff) | |
Remove ABI compliance checker code.
It's broken, unmaintained, poorly implemented and obsoleted by saner
debug-info methods.
Note: To do the compliance check properly would require much more
extensive work to clearly define public and private interfaces (without
manual bookeeping of files or symbols either, of course, because who
would want that...).
Change-Id: Ib801f3c152ca2369f95ca1f4af4d37cd8cc7c47a
Reviewed-on: https://code.wireshark.org/review/33928
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: João Valverde <j@v6e.pt>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/compare-abis.sh | 48 | ||||
| -rwxr-xr-x | tools/git-compare-abis.sh | 44 |
2 files changed, 0 insertions, 92 deletions
diff --git a/tools/compare-abis.sh b/tools/compare-abis.sh deleted file mode 100755 index 8d18683c8a..0000000000 --- a/tools/compare-abis.sh +++ /dev/null @@ -1,48 +0,0 @@ -#!/bin/bash -# -# Compare ABIs of two Wireshark working copies -# -# Copyright 2013 Balint Reczey <balint at balintreczey.hu> -# -# Wireshark - Network traffic analyzer -# By Gerald Combs <gerald@wireshark.org> -# Copyright 1998 Gerald Combs -# -# SPDX-License-Identifier: GPL-2.0-or-later - -# Tested with abi-compliance-checker 1.96.1 - -function acc () { - LIBNAME=$1 - DIR=$2 - # compare only dumped ABI descriptions first, then fall back to full comparison - # if no difference is found - if abi-compliance-checker -l $LIBNAME \ - -d1 $V1_PATH/$DIR/$REL_DUMP_PATH/$LIBNAME.abi.tar.gz \ - -d2 $V2_PATH/$DIR/$REL_DUMP_PATH/$LIBNAME.abi.tar.gz ; then - abi-compliance-checker -l $LIBNAME \ - -d1 $V1_PATH/$DIR/abi-descriptor.xml -relpath1 $V1_PATH/$DIR \ - -v1 `ls $V1_PATH/$DIR/$REL_LIB_PATH/$LIBNAME.so.?.*.*|sed 's/.*\.so\.//'` \ - -d2 $V2_PATH/$DIR/abi-descriptor.xml -relpath2 $V2_PATH/$DIR \ - -v2 `ls $V2_PATH/$DIR/$REL_LIB_PATH/$LIBNAME.so.?.*.*|sed 's/.*\.so\.//'` \ - -check-implementation - fi -} - -V1_PATH=$1 -V2_PATH=$2 - -# both working copies have to be built first with cmake -# make -C $V1_PATH all dumpabi -# make -C $V2_PATH all dumpabi - -REL_LIB_PATH=../lib -REL_DUMP_PATH=. - -acc libwiretap wiretap $V1_PATH $V2_PATH -RET=$? -acc libwsutil wsutil $V1_PATH $V2_PATH -RET=$(($RET + $?)) -acc libwireshark epan $V1_PATH $V2_PATH -exit $(($RET + $?)) - diff --git a/tools/git-compare-abis.sh b/tools/git-compare-abis.sh deleted file mode 100755 index 17a4c58fc0..0000000000 --- a/tools/git-compare-abis.sh +++ /dev/null @@ -1,44 +0,0 @@ -#!/bin/bash -# -# checks if Wireshark's ABI has been changes since last release (tag) -# -# Copyright 2011 Balint Reczey <balint@balintreczey.hu> -# -# Wireshark - Network traffic analyzer -# By Gerald Combs <gerald@wireshark.org> -# Copyright 1998 Gerald Combs -# -# SPDX-License-Identifier: GPL-2.0-or-later - -set -e - -if test -z "$1"; then - echo "Usage:" - echo "$0 \"<build commands>\"" - echo "e.g. $0 \"./autogen.sh && ./configure && make -j3 && make dumpabi\"" - exit 1 -fi - -# build current version -bash -c "$1" - -cd `git rev-parse --show-toplevel` -# we are at top level - -# Stable branches with releases -#LAST_TAG=`git describe --tags --abbrev=0` -#LAST_TAG_DIR=$LAST_TAG - -# Use latest commit -LAST_TAG=HEAD -LAST_TAG_DIR=master - -rm -rf $LAST_TAG_DIR -mkdir $LAST_TAG_DIR -git archive $LAST_TAG | tar -x -C $LAST_TAG_DIR - -# build latest tag -(cd $LAST_TAG_DIR && bash -c "$1") - -exec tools/compare-abis.sh `pwd`/$LAST_TAG_DIR `pwd` - |