aboutsummaryrefslogtreecommitdiffstats
path: root/tools/checkAPIs.pl
diff options
context:
space:
mode:
authorPeter Wu <peter@lekensteyn.nl>2016-08-31 15:58:20 +0200
committerGuy Harris <guy@alum.mit.edu>2016-09-06 02:42:27 +0000
commit232a8794293bf654fb61122adffa6a7aa2989cc0 (patch)
treefdc95cf5894c7515f880c7974ccff36f3e2ae8d8 /tools/checkAPIs.pl
parent5eb9170227a590560003dfc3b654e7be1b942b9a (diff)
Allow a lot more C99 features
Flexible array members are supported by gcc, clang and even MSVC2013. Note, so far it was only used in the Windows-specific airpcap.h. Trailing commas in enum declaration are already in use since for these dissectors (commit ID is the first occurrence): epan/dissectors/packet-gluster.h v2.1.0rc0-1070-g3b706ba epan/dissectors/packet-ipv6.c v2.1.2rc0-81-ge07b4aa epan/dissectors/packet-netlink.h v2.3.0rc0-389-gc0ab12b epan/dissectors/packet-netlink-netfilter.c v2.3.0rc0-239-g1767e08 epan/dissectors/packet-netlink-route.c v2.3.0rc0-233-g2a80b40 epan/dissectors/packet-quic.c v2.3.0rc0-457-gfa320f8 Inline functions using the "inline" keyword are supported via all glib versions we support (if it is missing, glib will define a suitable inline macro). Other c99 functions listed in the README.developer document were found to be compatible with GCC 4.4.7, Clang 3.4.2 and MSVC 2013. Change-Id: If5bab03bfd8577b15a24bedf08c03bdfbf34317a Reviewed-on: https://code.wireshark.org/review/17421 Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'tools/checkAPIs.pl')
-rwxr-xr-xtools/checkAPIs.pl11
1 files changed, 0 insertions, 11 deletions
diff --git a/tools/checkAPIs.pl b/tools/checkAPIs.pl
index cd6864c1fe..6117bf2575 100755
--- a/tools/checkAPIs.pl
+++ b/tools/checkAPIs.pl
@@ -2042,7 +2042,6 @@ while ($_ = pop @filelist)
my $fileContents = '';
my @foundAPIs = ();
my $line;
- my $prohibit_cpp_comments = 1;
if ($source_dir and ! -e $filename) {
$filename = $source_dir . '/' . $filename;
@@ -2059,10 +2058,6 @@ while ($_ = pop @filelist)
next;
}
- # Establish or remove local taboos
- if ($filename =~ m{ ui/qt/ }x) { $prohibit_cpp_comments = 0; }
- if ($filename =~ m{ image/*.rc }x) { $prohibit_cpp_comments = 0; }
-
# Read in the file (ouch, but it's easier that way)
open(FC, $filename) || die("Couldn't open $filename");
$line = 1;
@@ -2139,12 +2134,6 @@ while ($_ = pop @filelist)
#$errorCount += check_ett_registration(\$fileContents, $filename);
- if ($prohibit_cpp_comments && $fileContents =~ m{ \s// }xo)
- {
- print STDERR "Error: Found C++ style comments in " .$filename."\n";
- $errorCount++;
- }
-
# Remove all blank lines
$fileContents =~ s{ ^ \s* $ } []xog;