diff options
| author | Michael Mann <mmann78@netscape.net> | 2014-08-17 20:31:04 -0400 |
|---|---|---|
| committer | Evan Huus <eapache@gmail.com> | 2014-08-19 16:20:34 +0000 |
| commit | 0cda27c83e4aeadb195c9e9bbf55d51db5244347 (patch) | |
| tree | 26cd179e2b1a98e44d45bad3828d12579f8e4497 /tools/checkAPIs.pl | |
| parent | d7e456432165819903a0a946018efe8f182dac6e (diff) | |
"Highly discourage" use of proto_tree_add_text.
Change-Id: I2e8d18df71688c654f7acaff51fae7823c08aa6a
Reviewed-on: https://code.wireshark.org/review/3677
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Diffstat (limited to 'tools/checkAPIs.pl')
| -rwxr-xr-x | tools/checkAPIs.pl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/checkAPIs.pl b/tools/checkAPIs.pl index de1675bdb5..ff31b68505 100755 --- a/tools/checkAPIs.pl +++ b/tools/checkAPIs.pl @@ -135,6 +135,8 @@ my %APIs = ( 'tvb_ensure_length_remaining', # replaced with tvb_ensure_captured_length_remaining 'tvb_get_string', # replaced with tvb_get_string_enc 'tvb_get_stringz', # replaced with tvb_get_stringz_enc + 'proto_tree_add_text', # replaced with proto_tree_add_subtree[_format], expert_add_info[_format], or proto_tree_add_expert[_format] + 'proto_tree_add_text_valist', # replaced with proto_tree_add_subtree_format, expert_add_info_format, or proto_tree_add_expert_format # wmem calls should replace all emem calls (see doc/README.wmem) 'ep_alloc', @@ -1386,7 +1388,7 @@ sub checkAddTextCalls($$) my $okay_add_text_count = 0; my $add_xxx_count = 0; my $total_count = 0; - my $aggressive = 0; + my $aggressive = 1; my $percentage = 100; # The 3 loops here are slow, but trying a single loop with capturing |