path: root/tfshark.c
diff options
authorPeter Wu <peter@lekensteyn.nl>2017-04-08 19:34:24 +0200
committerMichael Mann <mmann78@netscape.net>2017-04-08 19:14:00 +0000
commitf1751ef22fc9877e59fad3b1c60826bff8569d94 (patch)
tree78baa38910c7a9c7e4951efe6625a629efe4de72 /tfshark.c
parent6d204e51520d3b5013e5acf319eb01cef6fab0a3 (diff)
checkhf: handle C++-style comments
"tools/checkhf.pl epan/dissectors/packet-umts_fp.c" gave this error: Complex regular subexpression recursion limit (32766) exceeded at tools/checkhf.pl line 273. This is caused by the comment "// ... Indicator's ..." which failed to match the single-quoted string and caused "catastrophic backtracking". Solution to fix this case is to disallow unescaped newlines (add "\n" to the negated character class). Additionally, add logic to remove C++-style comments for completeness. Tested against all epan/dissectors/packet-*.c files, the only difference in output is this umts_fp case, the running time has not regressed. Change-Id: I7b43e01e1580acf831c0485513135b613bb02e8b Reported-by: Joerg Mayer Reviewed-on: https://code.wireshark.org/review/20965 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'tfshark.c')
0 files changed, 0 insertions, 0 deletions