diff options
| author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2015-11-21 23:48:27 +0000 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2015-12-12 16:21:19 +0000 |
| commit | 2aab706c5a5d61c61bbff6e9e36a57afc4ef3be8 (patch) | |
| tree | 311fa08b5404d23cc4cfa644c87f84ab7422b61f /text2pcap.c | |
| parent | 95142cf09d4789c9c68108b56f5fbe467108494f (diff) | |
Remove -Wwrite-strings compiler flag
The "-Wwrite-strings" flag produces nuisance warnings. These warnings are
not useful, they're impossible to fix in a sane way and therefore are being
handled with casts of static strings to (char *).
This just moves the warning to [-Wcast-qual] and a compiler pragma is
in turn required (and used) to squelch that warning.
Remove the Wwrite-strings warning. Let that responsibility fall on the
programmer (as is done by casting).
Change-Id: I5a44dfd9decd6d80797a521a3373593074962fb5
Reviewed-on: https://code.wireshark.org/review/12162
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'text2pcap.c')
| -rw-r--r-- | text2pcap.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/text2pcap.c b/text2pcap.c index ccc2a187b9..3f002fd86c 100644 --- a/text2pcap.c +++ b/text2pcap.c @@ -1531,13 +1531,11 @@ parse_options (int argc, char *argv[]) GString *runtime_info_str; int c; char *p; -DIAG_OFF(cast-qual) static const struct option long_options[] = { - {(char *)"help", no_argument, NULL, 'h'}, - {(char *)"version", no_argument, NULL, 'v'}, + {"help", no_argument, NULL, 'h'}, + {"version", no_argument, NULL, 'v'}, {0, 0, 0, 0 } }; -DIAG_ON(cast-qual) #ifdef _WIN32 arg_list_utf_16to8(argc, argv); |