diff options
| author | Michael Mann <mmann78@netscape.net> | 2014-11-24 10:10:12 -0500 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2014-12-01 14:05:44 +0000 |
| commit | 6d207fe5f47f20f7c83d5c5da3e4ee0b0bca7b9b (patch) | |
| tree | 5671e4db547624855d20cbf6fc4bc24187a3681f /test | |
| parent | e77507b0eac903e74389ef1bf2dfa51d4cf00aad (diff) | |
Remove private_data member from packet_info structure.
Dissectors should pass data directly to their subdissectors through the data parameter (of new-style dissectors). This avoids unintentional "trampling" from other dissectors trying to "share" private_data member.
Change-Id: I2efef5c8dfeef64588ba3ac6e695b469238c6468
Reviewed-on: https://code.wireshark.org/review/5487
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'test')
| -rw-r--r-- | test/lua/pinfo.lua | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/lua/pinfo.lua b/test/lua/pinfo.lua index 756af89cf7..f4b922db29 100644 --- a/test/lua/pinfo.lua +++ b/test/lua/pinfo.lua @@ -123,7 +123,6 @@ silently accept being set (though nothing happens) Blech!! test("Pinfo.curr_proto-set-1",not pcall(setPinfo,pinfo,"curr_proto",0)) test("Pinfo.columns-set-1",not pcall(setPinfo,pinfo,"columns",0)) test("Pinfo.cols-set-1",not pcall(setPinfo,pinfo,"cols",0)) - test("Pinfo.private_data-set-1",not pcall(setPinfo,pinfo,"private_data",0)) test("Pinfo.private-set-1",not pcall(setPinfo,pinfo,"private",0)) test("Pinfo.fragmented-set-1",not pcall(setPinfo,pinfo,"fragmented",0)) test("Pinfo.in_error_pkt-set-1",not pcall(setPinfo,pinfo,"in_error_pkt",0)) @@ -188,7 +187,6 @@ again, these *should* pass, but Pinfo silently allows it! test("Pinfo.columns-get-2",typeof(pinfo.columns) == "Columns") test("Pinfo.cols-get-1",tostring(pinfo.cols) == "Columns") test("Pinfo.cols-get-2",typeof(pinfo.cols) == "Columns") - test("Pinfo.private_data-get-1",type(pinfo.private_data) == "userdata") test("Pinfo.private-get-1",type(pinfo.private) == "userdata") test("Pinfo.fragmented-get-1",pinfo.fragmented == false) |