Fix a bunch of warnings.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748

1 files changed, 1 insertions, 1 deletions

diff --git a/summary.h b/summary.h
index d467796a0d..a0f49c009a 100644
--- a/summary.h
+++ b/summary.h
@@ -77,7 +77,7 @@ typedef struct _summary_tally {
     gchar        *opt_comment;      /**< comment from SHB block */
     gchar        *shb_hardware;     /**< Capture HW from SHB block */
     gchar        *shb_os;           /**< The OS the capture was made on from SHB block */
-    gchar        *shb_user_appl;    /**< The application that made the capture from SHB block */
+    const gchar  *shb_user_appl;    /**< The application that made the capture from SHB block */
     /* capture related, use summary_fill_in_capture() to get values */
     GArray       *ifaces;
     gboolean      legacy;