diff options
| author | Guy Harris <guy@alum.mit.edu> | 2001-08-28 08:28:19 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2001-08-28 08:28:19 +0000 |
| commit | aa4cd01b9bcd64fc3785668692f2be0f19f69bb8 (patch) | |
| tree | 3a75d49278b2ef01f583e4346c84e22e30332616 /plugins/plugin_api.c | |
| parent | d9019638eef40ef97c69e7a28277d1886aa800cc (diff) | |
Get rid of "proto_tree_add_notext()" - if you create a subtree using it,
but, before you set the text, you throw an exception while putting stuff
under the subtree, you end up with an absolutely blank protocol tree
item, which is really gross. Instead of calling
"proto_tree_add_notext()", call "proto_tree_add_text()" with at least a
minimal label - yes, it does mean you do some work that will probably be
unnecessary, but, absent a scheme to arrange to do that work if it *is*
necessary (e.g., catching exceptions), the alternative is an ugly
protocol tree display.
svn path=/trunk/; revision=3879
Diffstat (limited to 'plugins/plugin_api.c')
| -rw-r--r-- | plugins/plugin_api.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/plugins/plugin_api.c b/plugins/plugin_api.c index a2c8eff5b4..16736e838b 100644 --- a/plugins/plugin_api.c +++ b/plugins/plugin_api.c @@ -1,11 +1,10 @@ /* plugin_api.c * Routines for Ethereal plugins. * - * $Id: plugin_api.c,v 1.20 2001/07/22 10:12:11 guy Exp $ + * $Id: plugin_api.c,v 1.21 2001/08/28 08:28:19 guy Exp $ * * Ethereal - Network traffic analyzer * Copyright 2000 by Gilbert Ramirez <gram@xiexie.org> - * * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -20,7 +19,6 @@ * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. - * */ #ifdef HAVE_CONFIG_H @@ -98,7 +96,6 @@ plugin_address_table_init(plugin_address_table_t *pat) p_proto_tree_add_int_hidden = pat->p_proto_tree_add_int_hidden; p_proto_tree_add_int_format = pat->p_proto_tree_add_int_format; p_proto_tree_add_text = pat->p_proto_tree_add_text; - p_proto_tree_add_notext = pat->p_proto_tree_add_notext; p_tvb_new_subset = pat->p_tvb_new_subset; p_tvb_length = pat->p_tvb_length; p_tvb_length_remaining = pat->p_tvb_length_remaining; |