diff options
| author | Guy Harris <guy@alum.mit.edu> | 2002-03-09 22:54:27 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2002-03-09 22:54:27 +0000 |
| commit | 56902650875cd87e16ccbd9207f4041311421dc5 (patch) | |
| tree | 92c673160f627f78acdaaaa3588819c2f24454e5 /packet-socks.c | |
| parent | f4ee24a894d32e8ff9c3c8d3508d73bb31322269 (diff) | |
Fix some "proto_tree_add_uint()" and "proto_tree_add_uint_hidden()"
calls that passed TRUE or FALSE, rather than an integer value, as the
last argument.
A SOCKS command is one byte, so make the "socks.command" field an
FT_UINT8.
svn path=/trunk/; revision=4904
Diffstat (limited to 'packet-socks.c')
| -rw-r--r-- | packet-socks.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/packet-socks.c b/packet-socks.c index c024133604..6d71a18dc4 100644 --- a/packet-socks.c +++ b/packet-socks.c @@ -2,7 +2,7 @@ * Routines for socks versions 4 &5 packet dissection * Copyright 2000, Jeffrey C. Foster <jfoste@woodward.com> * - * $Id: packet-socks.c,v 1.35 2002/01/24 09:20:51 guy Exp $ + * $Id: packet-socks.c,v 1.36 2002/03/09 22:54:27 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -525,7 +525,7 @@ display_socks_v4(tvbuff_t *tvb, int offset, packet_info *pinfo, ++offset; /* Do results code */ proto_tree_add_item( tree, hf_socks_results_4, tvb, offset, 1, FALSE); - proto_tree_add_uint_hidden(tree, hf_socks_results, tvb, offset, 1, FALSE); + proto_tree_add_item_hidden(tree, hf_socks_results, tvb, offset, 1, FALSE); ++offset; @@ -631,11 +631,12 @@ display_socks_v5(tvbuff_t *tvb, int offset, packet_info *pinfo, command = tvb_get_guint8(tvb, offset); if (compare_packet( hash_info->command_row)) - proto_tree_add_uint( tree, hf_socks_cmd, tvb, offset, 1, FALSE); + proto_tree_add_uint( tree, hf_socks_cmd, tvb, offset, 1, + command); else { proto_tree_add_item( tree, hf_socks_results_5, tvb, offset, 1, FALSE); - proto_tree_add_uint_hidden(tree, hf_socks_results, tvb, offset, 1, FALSE); + proto_tree_add_item_hidden(tree, hf_socks_results, tvb, offset, 1, FALSE); } ++offset; @@ -1137,7 +1138,7 @@ proto_register_socks( void){ } }, { &hf_socks_cmd, - { "Command", "socks.command", FT_UINT16, + { "Command", "socks.command", FT_UINT8, BASE_DEC, VALS(cmd_strings), 0x0, "", HFILL } }, |