path: root/packet-ppp.h
diff options
authorGuy Harris <guy@alum.mit.edu>2002-11-11 19:23:14 +0000
committerGuy Harris <guy@alum.mit.edu>2002-11-11 19:23:14 +0000
commit5ae19d6256d8a85330699f84d21766d5bdce69fc (patch)
treeff90b1bd990b87f9c5e0cb89451b3fc8589c145c /packet-ppp.h
parent3cd4fed22dc579fe7732106f18c18566ace63f9a (diff)
Instead of tweaking a "Protocol configuration options" extension header
item to look more-or-less like a PPP packet, just dissect it in place and hand off to the appropriate subdissector using the PPP dissector's handoff table (which we export, along with its value_string table for protocol IDs, which we use to report the protocol ID symbolically). This means there's no point in having a configurable option to control whether to do that tweaking; make it an obsolete option. Bring "col_get_writable()" back from the dead, and have the GTP dissector save the current "writable" flag for columns, mark the columns non-writable before calling the subdissector for the PPP configuration protocol, and restore the state of the writable flag, rather than putting the columns back after the PPP configuration protocol's dissector is done. Fix some more typos in comments. Don't register the IP dissector in the "ppp.protocol" table in the GTP dissector's handoff registration routine - it's already being done in the IP dissector's handoff routine. Fix the name for CHAP to match what RFC 1994 calls it (if the name changed, it should be changed in all places, but, at least according to this message, a while ago, from Bob Sutterfield, "since the RFC defines the protocol, the RFC defines the name": http://mail-index.netbsd.org/netbsd-help/1996/05/16/0011.html and the RFC defines the name as "PPP Challenge Handshake Authentication Protocol (CHAP)"). svn path=/trunk/; revision=6617
Diffstat (limited to 'packet-ppp.h')
1 files changed, 7 insertions, 1 deletions
diff --git a/packet-ppp.h b/packet-ppp.h
index 6332addbb9..30dd083d80 100644
--- a/packet-ppp.h
+++ b/packet-ppp.h
@@ -1,6 +1,6 @@
/* packet-ppp.h
- * $Id: packet-ppp.h,v 1.11 2002/08/28 21:00:25 jmayer Exp $
+ * $Id: packet-ppp.h,v 1.12 2002/11/11 19:23:12 guy Exp $
* Ethereal - Network traffic analyzer
* By Gerald Combs <gerald@ethereal.com>
@@ -29,4 +29,10 @@ extern gboolean ppp_vj_decomp;/* FALSE = No VJ header decompression,
TRUE = Decompress VJ */
void capture_ppp_hdlc(const guchar *, int, int, packet_counts *);
+ * Used by the GTP dissector as well.
+ */
+extern dissector_table_t ppp_subdissector_table;
+extern const value_string ppp_vals[];