aboutsummaryrefslogtreecommitdiffstats
path: root/packet-mip.c
diff options
context:
space:
mode:
authorGuy Harris <guy@alum.mit.edu>2000-11-19 08:54:37 +0000
committerGuy Harris <guy@alum.mit.edu>2000-11-19 08:54:37 +0000
commit252d55d80f92fa8267758fbf4faab520d2f79273 (patch)
treeb6449cf609799ebb75b91e1cd6b600b06ee3d11a /packet-mip.c
parente88bd04f9aa217173cc86d785e9206e272a832ce (diff)
For each column, have both a buffer into which strings for that column
can be put, and a pointer to the string for the column, which might or might not point to that buffer. Add a routine "col_set_str()", which sets the string for the column to the string passed to it as an argument; it should only be handed a static string (a string constant would be ideal). It doesn't do any copying, so it's faster than "col_add_str()". Make the routines that append to columns check whether the pointer to the string for the column points to the buffer for the column and, if not, copy the string for the column to the buffer for the column so that you can append to it (so you can use "col_set_str()" and then use "col_append_str()" or "col_append_fstr()"). Convert a bunch of "col_add_str()" calls that take a string constant as an argument to "col_set_str()" calls. Convert some "col_add_fstr()" calls that take a string constant as the only argument - i.e., the format string doesn't have any "%" slots into which to put strings for subsequent arguments to "col_set_str()" calls (those calls are just like "col_add_str()" calls). Replace an END_OF_FRAME reference in a tvbuffified dissector with a "tvb_length(tvb)" call. svn path=/trunk/; revision=2670
Diffstat (limited to 'packet-mip.c')
-rw-r--r--packet-mip.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/packet-mip.c b/packet-mip.c
index c6913b8d53..a6d398d20e 100644
--- a/packet-mip.c
+++ b/packet-mip.c
@@ -2,7 +2,7 @@
* Routines for Mobile IP dissection
* Copyright 2000, Stefan Raab <Stefan.Raab@nextel.com>
*
- * $Id: packet-mip.c,v 1.8 2000/08/13 14:08:28 deniel Exp $
+ * $Id: packet-mip.c,v 1.9 2000/11/19 08:54:00 guy Exp $
*
* Ethereal - Network traffic analyzer
* By Gerald Combs <gerald@unicom.net>
@@ -153,14 +153,14 @@ dissect_mip(const u_char *pd, int offset, frame_data *fd, proto_tree *tree)
pinfo->current_proto = "Mobile IP";
if (check_col(fd, COL_PROTOCOL))
- col_add_str(fd, COL_PROTOCOL, "mip");
+ col_set_str(fd, COL_PROTOCOL, "mip");
type = tvb_get_guint8(tvb, 0);
if (type==1) {
if (check_col(fd, COL_INFO))
- col_add_str(fd, COL_INFO, "Mobile IP Registration Request");
+ col_set_str(fd, COL_INFO, "Mobile IP Registration Request");
if (tree) {
ti = proto_tree_add_item(tree, proto_mip, tvb, 0, tvb_length(tvb), FALSE);
@@ -186,7 +186,7 @@ dissect_mip(const u_char *pd, int offset, frame_data *fd, proto_tree *tree)
if (type==3){
if (check_col(fd, COL_INFO))
- col_add_str(fd, COL_INFO, "Mobile IP Registration Reply");
+ col_set_str(fd, COL_INFO, "Mobile IP Registration Reply");
if (tree) {
ti = proto_tree_add_item(tree, proto_mip, tvb, 0, tvb_length(tvb), FALSE);