path: root/packet-mip.c
diff options
authorGilbert Ramirez <gram@alumni.rice.edu>2000-06-15 03:49:00 +0000
committerGilbert Ramirez <gram@alumni.rice.edu>2000-06-15 03:49:00 +0000
commit0ab8dd8cbd69bcafc65f2a24d02f9976f8bb90be (patch)
treeda3484a5835ecf78293f109946a67ec6751de1b7 /packet-mip.c
parentadaefea44d13402f406a73f7ca64a3dd9030141e (diff)
Convert IPX-and-friend dissectors in packet-ipx.c to use
tvbuffs. In doing so, I realied that my recommendation for using tvb_new_subset(pi.compat_top_tvb, -1, -1) was incorrect, because some dissectors (ethernet!) change pi.len and pi.cap_len. So, I have to take those two variables into account instead of using -1 and -1. So, I provide a macro called tvb_create_from_top(offset), where offset is the name of your offset variable. It is a wrapper around tvb_new_subset(). I converted the lines that followed my suggestion to use tvb_create_from_top(). In proto.c I added proto_tree_add_debug_text(proto_tree*, const char*, ...) It's much like proto_tree_add_text(), except that it takes no offset or length; it's soley for temporarily putting debug text into the proto_tree while debugging a dissector. In making sure that its use is temporary, the funciton also prints the debug string to stdout to remind the programmer that the debug code needs to be removed before shipping the code. svn path=/trunk/; revision=2068
Diffstat (limited to 'packet-mip.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/packet-mip.c b/packet-mip.c
index ce71552fd1..88827f2924 100644
--- a/packet-mip.c
+++ b/packet-mip.c
@@ -2,7 +2,7 @@
* Routines for Mobile IP dissection
* Copyright 2000, Stefan Raab <Stefan.Raab@nextel.com>
- * $Id: packet-mip.c,v 1.4 2000/05/31 05:07:18 guy Exp $
+ * $Id: packet-mip.c,v 1.5 2000/06/15 03:48:42 gram Exp $
* Ethereal - Network traffic analyzer
* By Gerald Combs <gerald@unicom.net>
@@ -149,7 +149,7 @@ dissect_mip(const u_char *pd, int offset, frame_data *fd, proto_tree *tree)
/* Make our own tvb until the function call includes one */
tvbuff_t *tvb;
packet_info *pinfo = &pi;
- tvb = tvb_new_subset(pi.compat_top_tvb, offset, -1, -1);
+ tvb = tvb_create_from_top(offset);
/* Make entries in Protocol column and Info column on summary display */