diff options
| author | Gilbert Ramirez <gram@alumni.rice.edu> | 1999-10-12 06:21:15 +0000 |
|---|---|---|
| committer | Gilbert Ramirez <gram@alumni.rice.edu> | 1999-10-12 06:21:15 +0000 |
| commit | bacb9d5bae5e1aa9d9144463cd24d8c5adb9398e (patch) | |
| tree | 13a576cc1a346d2364a1b13bf493b2efc42a856f /packet-icp.c | |
| parent | 10c4bab8e129dc0012e8e341fb74fc725e66fee8 (diff) | |
New proto_tree header_field_info stuff. Header_field_infos now contain
the base for numbers to be displayed in, bitmasks for bitfields, and blurbs
(which are one or two sentences describing the field).
proto_tree_add*() routines now automatically handle bitfields. You tell
it which header field you are adding, and just pass it the value of the
entire field, and the proto_tree routines will do the masking and shifting
for you.
This means that bitfields are more naturally filtered via dfilter now.
Added Phil Techau's support for signed integers in dfilters/proto_tree.
Added the beginning of the SNA dissector. It's not complete, but I'm
committing it now because it has example after example of how to use
bitfields with the new header_field_info struct and proto_tree routines.
It was the impetus to change how header_field_info works.
svn path=/trunk/; revision=815
Diffstat (limited to 'packet-icp.c')
| -rw-r--r-- | packet-icp.c | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/packet-icp.c b/packet-icp.c index 41a39c1f6b..717a2df487 100644 --- a/packet-icp.c +++ b/packet-icp.c @@ -2,7 +2,7 @@ * Routines for ICP (internet cache protocol) packet disassembly RFC 2186 && RFC 2187 * * - * $Id: packet-icp.c,v 1.1 1999/09/14 08:06:24 guy Exp $ + * $Id: packet-icp.c,v 1.2 1999/10/12 06:20:07 gram Exp $ * * Ethereal - Network traffic analyzer * By Peter Torvals @@ -260,13 +260,21 @@ proto_register_icp(void) { static hf_register_info hf[] = { { &hf_icp_opcode, - { "Opcode","icp.opcode", FT_UINT8, NULL }}, + { "Opcode","icp.opcode", FT_UINT8, BASE_HEX, NULL, 0x0, + "" }}, + { &hf_icp_version, - { "Version", "icp.version", FT_UINT8, NULL }}, + { "Version", "icp.version", FT_UINT8, BASE_DEC, NULL, 0x0, + "" }}, + { &hf_icp_length, - { "Length","icp.length", FT_UINT16, NULL }}, + { "Length","icp.length", FT_UINT16, BASE_DEC, NULL, 0x0, + "" }}, + { &hf_icp_request_nr, - { "Request Number","icp.nr", FT_UINT32, NULL }} }; + { "Request Number","icp.nr", FT_UINT32, BASE_DEC, NULL, 0x0, + "" }}, + }; proto_icp = proto_register_protocol ("Internet Cache protocol", "icp"); proto_register_field_array(proto_icp, hf, array_length(hf)); |