diff options
| author | Guy Harris <guy@alum.mit.edu> | 2002-05-06 01:25:45 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2002-05-06 01:25:45 +0000 |
| commit | 1bff9074efdb94734e16059641caab7cd03d5167 (patch) | |
| tree | 5ac552933d1ddd41a01aeb8dbd381518d9e68d4e /packet-afs.c | |
| parent | 08b87db529dd30cdf0858a14e7308df60a595e94 (diff) | |
Note a problem with "GETSTR".
svn path=/trunk/; revision=5404
Diffstat (limited to 'packet-afs.c')
| -rw-r--r-- | packet-afs.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/packet-afs.c b/packet-afs.c index d6646645f5..96bb46668a 100644 --- a/packet-afs.c +++ b/packet-afs.c @@ -8,7 +8,7 @@ * Portions based on information/specs retrieved from the OpenAFS sources at * www.openafs.org, Copyright IBM. * - * $Id: packet-afs.c,v 1.44 2002/05/02 10:59:37 guy Exp $ + * $Id: packet-afs.c,v 1.45 2002/05/06 01:25:45 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -429,7 +429,16 @@ dissect_afs(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) * ASCII strings containing the UID/PTS record and and a ascii number * representing a logical OR of all the ACL permission bits */ -/* FIXME: sscanf is probably quite dangerous if we run outside the packet. */ +/* + * XXX - FIXME: + * + * sscanf is probably quite dangerous if we run outside the packet. + * + * "GETSTR" doesn't guarantee that the resulting string is + * null-terminated. + * + * Should this just scan the string itself, rather than using "sscanf()"? + */ static int dissect_acl(tvbuff_t *tvb, struct rxinfo *rxinfo _U_, proto_tree *tree, int offset) { |