Internalize struct preference

Move "struct preference" into prefs.c, essentially creating a "private"
structure to handle preferences. The 2 motivating factors were:
1. Better memory management so that clients/users of API don't have to worry
about it.
2. Hide the ugliness of the union stuff and make it transparent to the API.

A few bugs related to preference <-> Decode As integration were fixed
while in the neighborhood.

Change-Id: I509b9a236235d066b139c98222b701475e0ed365
Reviewed-on: https://code.wireshark.org/review/19578
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 0 insertions, 1 deletions

diff --git a/extcap.c b/extcap.c
index 082193d63c..e8f28e1567 100644
--- a/extcap.c
+++ b/extcap.c
@@ -48,7 +48,6 @@
 #include <log.h>
 
 #include <epan/prefs.h>
-#include <epan/prefs-int.h>
 
 #include <wsutil/file_util.h>
 #include <wsutil/filesystem.h>