diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2016-05-17 19:32:31 +0200 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2016-05-20 15:27:48 +0000 |
| commit | cafa1dbf18545e6e35e57d7a5f595cccc3cec61f (patch) | |
| tree | 85cb53c4ba9a13bfbfb38c0f6fdd1f277f47cbb4 /epan | |
| parent | 949bc3eb8508f20a8c3728ac942db2de8e8a5f1c (diff) | |
QUIC: Enhance Connection Close error check
There is some false positive (and get display malformed frame)
May be add also a check about error_code (< QUIC_LAST_ERROR) ?
Change-Id: Ib7df622d62f1441193fa4b2475220f08a62c9462
Reviewed-on: https://code.wireshark.org/review/15478
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan')
| -rw-r--r-- | epan/dissectors/packet-quic.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/epan/dissectors/packet-quic.c b/epan/dissectors/packet-quic.c index 91b5989b55..aa9dea1f3b 100644 --- a/epan/dissectors/packet-quic.c +++ b/epan/dissectors/packet-quic.c @@ -998,9 +998,8 @@ static gboolean is_quic_unencrypt(tvbuff_t *tvb, guint offset, guint16 len_pkn){ len_reason = tvb_get_letohs(tvb, offset); offset += 2; /* Reason Phrase */ - offset += len_reason; - /* There is no other data after Connection Close */ - if (tvb_captured_length_remaining(tvb, offset) == 0){ + /* If length remaining == len_reason, it is Connection Close */ + if (tvb_captured_length_remaining(tvb, offset) == len_reason){ return TRUE; } } |