diff options
| author | Gerald Combs <gerald@wireshark.org> | 2015-03-06 16:10:37 -0800 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2015-03-12 16:47:17 +0000 |
| commit | 8bae919a5d627d9644657bfd4389d5e857974ea3 (patch) | |
| tree | efeb36faef22f35b07a61cf93adc7b42b9721851 /epan | |
| parent | dd8a79974ceecf075d6f91d1860ba6d5008ccb80 (diff) | |
One check mark for ACKs, two check marks for dup ACKs.
Add FT_FRAMENUM_ACK and FT_FRAMENUM_DUP_ACK and set them for
tcp.analysis.acks_frame and tcp.analysis.duplicate_ack_frame. Draw a
single or double check mark in the packet list accordingly.
These are probably specific to TCP, but as it happens there are a lot of
TCP packets.
Change-Id: I35416506419159a79ad8cc2e35f8a14485edfb7e
Reviewed-on: https://code.wireshark.org/review/7568
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan')
| -rw-r--r-- | epan/dissectors/packet-tcp.c | 4 | ||||
| -rw-r--r-- | epan/ftypes/ftypes.h | 4 |
2 files changed, 5 insertions, 3 deletions
diff --git a/epan/dissectors/packet-tcp.c b/epan/dissectors/packet-tcp.c index 37e8148e25..a478010e83 100644 --- a/epan/dissectors/packet-tcp.c +++ b/epan/dissectors/packet-tcp.c @@ -5216,7 +5216,7 @@ proto_register_tcp(void) "This is duplicate ACK number #", HFILL }}, { &hf_tcp_analysis_duplicate_ack_frame, - { "Duplicate to the ACK in frame", "tcp.analysis.duplicate_ack_frame", FT_FRAMENUM, BASE_NONE, NULL, 0x0, + { "Duplicate to the ACK in frame", "tcp.analysis.duplicate_ack_frame", FT_FRAMENUM, BASE_NONE, FRAMENUM_TYPE(FT_FRAMENUM_DUP_ACK), 0x0, "This is a duplicate to the ACK in frame #", HFILL }}, { &hf_tcp_continuation_to, @@ -5228,7 +5228,7 @@ proto_register_tcp(void) NULL, HFILL}}, { &hf_tcp_analysis_acks_frame, - { "This is an ACK to the segment in frame", "tcp.analysis.acks_frame", FT_FRAMENUM, BASE_NONE, NULL, 0x0, + { "This is an ACK to the segment in frame", "tcp.analysis.acks_frame", FT_FRAMENUM, BASE_NONE, FRAMENUM_TYPE(FT_FRAMENUM_ACK), 0x0, "Which previous segment is this an ACK for", HFILL}}, { &hf_tcp_analysis_bytes_in_flight, diff --git a/epan/ftypes/ftypes.h b/epan/ftypes/ftypes.h index 226084449a..c215ca2ea4 100644 --- a/epan/ftypes/ftypes.h +++ b/epan/ftypes/ftypes.h @@ -100,7 +100,9 @@ typedef enum ftenum ftenum_t; enum ft_framenum_type { FT_FRAMENUM_NONE, FT_FRAMENUM_REQUEST, - FT_FRAMENUM_RESPONSE + FT_FRAMENUM_RESPONSE, + FT_FRAMENUM_ACK, + FT_FRAMENUM_DUP_ACK }; typedef enum ft_framenum_type ft_framenum_type_t; |