aboutsummaryrefslogtreecommitdiffstats
path: root/epan
diff options
context:
space:
mode:
authorMartin Kaiser <wireshark@kaiser.cx>2017-05-07 22:59:08 +0200
committerMartin Kaiser <wireshark@kaiser.cx>2017-05-07 21:02:57 +0000
commit2229665d4871ad52faaf363f5a4604893771dfa4 (patch)
tree475fd16c5d442a6f3ac31dc2695f5401b445227e /epan
parent163d66099d7ef338c475f63e56b242957c9103c7 (diff)
gif: fix the version detection
tvb_strneql() returns 0 if the two strings are equal. Thanks to Ahmad Fatoum for reporting this bug. Change-Id: Id6cde56623e18fe0a28f37b108dc1848cc58e1c3 Reviewed-on: https://code.wireshark.org/review/21554 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Diffstat (limited to 'epan')
-rw-r--r--epan/dissectors/file-gif.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/file-gif.c b/epan/dissectors/file-gif.c
index 03c47caa5d..68b87d8597 100644
--- a/epan/dissectors/file-gif.c
+++ b/epan/dissectors/file-gif.c
@@ -315,9 +315,9 @@ dissect_gif(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U_)
/* Check whether we're processing a GIF object */
/* see http://www.w3.org/Graphics/GIF/spec-gif89a.txt section 17 */
- if (!tvb_strneql(tvb, 0, "GIF87a", 6) == 0) {
+ if (tvb_strneql(tvb, 0, "GIF87a", 6) == 0) {
version = GIF_87a;
- } else if (!tvb_strneql(tvb, 0, "GIF89a", 6) == 0) {
+ } else if (tvb_strneql(tvb, 0, "GIF89a", 6) == 0) {
version = GIF_89a;
} else {
/* Not a GIF image! */