diff options
| author | Guy Harris <guy@alum.mit.edu> | 2014-12-31 14:47:04 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2014-12-31 22:47:37 +0000 |
| commit | 0e57ff2ca1ac3f8e409927d677ae4f6d5c3a9bcb (patch) | |
| tree | 2f7d3a9356f1ebab4ae7d8832b1222e3aed70803 /epan | |
| parent | 23b1127daf17ce2eaa46fba208970b2228abd3d8 (diff) | |
We no longer do anything signal-related, so don't include <signal.h>.
Update a comment pertaining to that, while we're at it.
Change-Id: Ic0a3f8575f8e98ca6032ed3e06e3dd76055d65a1
Reviewed-on: https://code.wireshark.org/review/6192
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan')
| -rw-r--r-- | epan/addr_resolv.c | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/epan/addr_resolv.c b/epan/addr_resolv.c index f9a468829f..7a8d5b30bc 100644 --- a/epan/addr_resolv.c +++ b/epan/addr_resolv.c @@ -50,12 +50,19 @@ * code in tcpdump, to avoid those sorts of problems, and that was * picked up by tcpdump.org tcpdump. * - * So, for now, we do not define AVOID_DNS_TIMEOUT. If we get a - * significantly more complaints about lookups taking a long time, - * we can reconsider that decision. (Note that tcpdump originally - * added that for the benefit of systems using NIS to look up host - * names; that might now be fixed in NIS implementations, for those - * sites still using NIS rather than DNS for that....) + * So, for now, we do not use alarm() and SIGALRM to time out host name + * lookups. If we get a lot of complaints about lookups taking a long time, + * we can reconsider that decision. (Note that tcpdump originally added + * such a timeout mechanism that for the benefit of systems using NIS to + * look up host names; that might now be fixed in NIS implementations, for + * those sites still using NIS rather than DNS for that.... tcpdump no + * longer does that, for the same reasons that we don't.) + * + * If we're using an asynchronous DNS resolver, that shouldn't be an issue. + * If we're using a synchronous name lookup mechanism (which we'd do mainly + * to support resolving addresses and host names using more mechanisms than + * just DNS, such as NIS, NBNS, or Mr. Hosts File), we could do that in + * a separate thread, making it, in effect, asynchronous. */ #ifdef HAVE_UNISTD_H @@ -74,8 +81,6 @@ #include <arpa/inet.h> #endif -#include <signal.h> - #ifdef HAVE_SYS_SOCKET_H #include <sys/socket.h> /* needed to define AF_ values on UNIX */ #endif |